http://permalink.gmane.org/gmane.comp.cms.magnolia.devel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15221 [ http://jira.magnolia.info/browse/MAGNOLIA-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18556#action_18556 ] Jan Haderka commented on MAGNOLIA-2427: --------------------------------------- Excellent. Thanks very much. I'll have a look and try to apply it soon. JIRA (on behalf of Jan Haderka 2008-10-12T19:17:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15220 replace custom thread pool with library --------------------------------------- Key: MAGNOLIA-2427 URL: http://jira.magnolia.info/browse/MAGNOLIA-2427 Project: Magnolia Issue Type: Improvement Components: activation Affects Versions: 3.6.3 Reporter: Philippe Marschall Assignee: Philipp Bracher Priority: Minor Attachments: ThreadPool.java.patch The module exchange-simple uses it's own thread pool instead of a library. There is no need for this since there are mature, stable, tested and debugged libraries available that do this. The attached patch uses the backport of java.util.concurrent that as an easy migration path to JDK 1.5 in Magnlia 4. The patch also removes two unused variables and corrects some indentation issues. JIRA (on behalf of Philippe Marschall 2008-10-12T14:18:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15219 JS files still contains old header ---------------------------------- Key: MAGNOLIA-2426 URL: http://jira.magnolia.info/browse/MAGNOLIA-2426 Project: Magnolia Issue Type: Bug Components: admininterface Affects Versions: 3.6.3 Reporter: Jan Haderka Assignee: Philipp Bracher For example WebsiteSearchList.js in m-m-admininterface JIRA (on behalf of Jan Haderka 2008-10-10T20:06:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15218 Wrong direction of module dependency for javascript ---------------------------------------------------- Key: MAGNOLIA-2425 URL: http://jira.magnolia.info/browse/MAGNOLIA-2425 Project: Magnolia Issue Type: Bug Components: admininterface, gui Affects Versions: 3.6.3 Reporter: Jan Haderka Assignee: Philipp Bracher Priority: Minor This will probably be obsolete once 4.0 and GenUIne is delivered. Currently, PasswordDialog from m-gui calls JS function that exists only in dialogs.js which is part of m-m-admininterface, while pom and module dependencies suggest that admininterface depends on gui not the other way around. JIRA (on behalf of Jan Haderka 2008-10-10T19:46:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15217 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka resolved MAGNOLIA-2416. ----------------------------------- Resolution: Fixed Changing client side javascript posed some undesired side effects (circular validation) as well as forcing both fields to be filled all the time. Solved by implementing server side validation for DialogPassword. Seems to be safer way to handle things like changing password since its behaviour can be easily tested and can't be bypassed by the client. Added tests for the validation. trunk - r18937, r18938, 3.6 branch - r18939. JIRA (on behalf of Jan Haderka 2008-10-10T19:42:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15216 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18552#action_18552 ] Hudson CI server commented on MAGNOLIA-2416: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-3.6-branch #30|http://hudson.magnolia.info/job/magnolia_main-3.6-branch/30/] Force password change request validation on the server side as well as on client. JIRA (on behalf of Hudson CI server 2008-10-10T19:40:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15215 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18551#action_18551 ] Hudson CI server commented on MAGNOLIA-2416: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #125|http://hudson.magnolia.info/job/magnolia_main-trunk/125/] Verify password on a server side in addition to client side verification to ensure request to change of password is correct. JIRA (on behalf of Hudson CI server 2008-10-10T18:50:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15214 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18550#action_18550 ] Hudson CI server commented on MAGNOLIA-2416: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #124|http://hudson.magnolia.info/job/magnolia_main-trunk/124/] Verify password on a server side in addition to client side verification to ensure request to change of password is correct. JIRA (on behalf of Hudson CI server 2008-10-10T18:45:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15213 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on MAGNOLIA-2416 started by Jan Haderka. JIRA (on behalf of Jan Haderka 2008-10-10T18:41:06 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15212 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka reassigned MAGNOLIA-2416: ------------------------------------- Assignee: Jan Haderka (was: Philipp Bracher) JIRA (on behalf of Jan Haderka 2008-10-10T18:41:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15211 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18545#action_18545 ] Hudson CI server commented on MAGNOLIA-2419: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-3.6-branch #29|http://hudson.magnolia.info/job/magnolia_main-3.6-branch/29/] merging r18928 from trunk: : fixed tld - showInPreview is false by default JIRA (on behalf of Hudson CI server 2008-10-10T15:14:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15210 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18544#action_18544 ] Hudson CI server commented on MAGNOLIA-2419: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #123|http://hudson.magnolia.info/job/magnolia_main-trunk/123/] : fixed tld - showInPreview is false by default JIRA (on behalf of Hudson CI server 2008-10-10T15:12:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15209 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18543#action_18543 ] Hudson CI server commented on MAGNOLIA-2419: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-3.5-branch #9|http://hudson.magnolia.info/job/magnolia_main-3.5-branch/9/] : fixed tld - showInPreview is false by default JIRA (on behalf of Hudson CI server 2008-10-10T15:10:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15208 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18541#action_18541 ] Hudson CI server commented on MAGNOLIA-2419: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #122|http://hudson.magnolia.info/job/magnolia_main-trunk/122/] : fixed javadoc - showInPreview is false by default JIRA (on behalf of Hudson CI server 2008-10-10T15:07:05 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15207 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Joseph resolved MAGNOLIA-2419. -------------------------------------- Fix Version/s: 3.5.x Resolution: Fixed thanks, javadoc and tld fixed in svn, trunk and 3.6 and 3.5 branches. (published docs are generated.. feel free to provide a patch to fix them, i'll apply it) JIRA (on behalf of Gregory Joseph 2008-10-10T15:07:05 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15206 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18540#action_18540 ] Hudson CI server commented on MAGNOLIA-2419: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-3.6-branch #28|http://hudson.magnolia.info/job/magnolia_main-3.6-branch/28/] merging r18926 from trunk: : fixed javadoc - showInPreview is false by default JIRA (on behalf of Hudson CI server 2008-10-10T15:07:05 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15205 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Joseph updated MAGNOLIA-2419: ------------------------------------- Summary: cms:publicOnly 's showInPreview is false by default - documentation is wrong. (was: CMS:PublicOnly should also work for preview-mode) Fix Version/s: 3.6.x 3.7 Assignee: Gregory Joseph (was: Fabrizio Giustina) you're right, it's indeed false by default. fixing documentation. JIRA (on behalf of Gregory Joseph 2008-10-10T14:59:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15204 [ http://jira.magnolia.info/browse/MAGNOLIA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18538#action_18538 ] Olivier Marti commented on MAGNOLIA-2419: ----------------------------------------- Tested it with several templates now, the switch showInPreview="true" is not default, it has to actually be set that it is working in Preview Mode. JIRA (on behalf of Olivier Marti 2008-10-10T13:39:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15203 [ http://jira.magnolia.info/browse/MAGNOLIA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18537#action_18537 ] Hudson CI server commented on MAGNOLIA-2186: -------------------------------------------- Integrated in !http://hudson.magnolia.info/nocacheImages/16x16/blue.gif! [magnolia_main-trunk #121|http://hudson.magnolia.info/job/magnolia_main-trunk/121/] : render freemarker error message JIRA (on behalf of Hudson CI server 2008-10-10T12:35:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15202 [ http://jira.magnolia.info/browse/MAGNOLIA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18536#action_18536 ] Philipp Bracher commented on MAGNOLIA-2186: ------------------------------------------- For now if a template fails no exception is thrown but the yellowish freemarker exception is rendered into the stream (easier to develop) JIRA (on behalf of Philipp Bracher 2008-10-10T12:29:04 http://permalink.gmane.org/gmane.comp.cms.magnolia.devel/15201 [ http://jira.magnolia.info/browse/MAGNOLIA-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18535#action_18535 ] Jan Haderka commented on MAGNOLIA-2416: --------------------------------------- The obvious solution to the issue is to fill value always in both fields. When I look in code I could see that this was done once before, but is commented out now without explanation ... and have been commented out ever since first revision of DialogPassword (r206) in svn. JIRA (on behalf of Jan Haderka 2008-10-10T12:23:04 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.cms.magnolia.devel