gmane.text.xml.forrest.devel

[jira] Updated: (FOR-1133) PDF don't display images in deployed WAR file on Tomcat

Ross Gardler (JIRA — 2008-12-04T01:09:44

[ https://issues.apache.org/jira/browse/FOR-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ross Gardler updated FOR-1133: ------------------------------ Priority: Major (was: Critical) Urgency: Normal (was: Urgent) This is an issue with a version of Forrest that has been in production for quite some time. The problem would therefore appear to be with the specific configuration. Can you please report what happens when you do forrest run and retrieve a PDF, can you also tell us what the fo:external-graphic is when doing forrest run. Testing a built war file in a diferent servlet engine (e.g. Jettry) would also be informative. Please also test using 0.9-dev so that we can ascertain if this is a problem with 0.8 only or also a problem with SVN head. On my configuration I am unabe to reproduce this problem, so the more information you can provide us the more likely we are to be able to help you fix the problem. I'm reducing the priority to major as this issue needs to be confirmed as a problem in Forrest rather than a problem in your configuration (although I note you have tested on multiple operating systems). I'm also reducing the urgency to Normal, this means active devs are likely to help you solve the problem, but that they are not likely to do the work for you (i.e. an existing dev is not being affected by the issue)

Re: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Ross Gardler — 2008-12-04T00:54:52

On 2 Dec 2008, at 11:52, Gavin wrote: ... +1 Thorsten and I talked about the solution for reusing resources some time ago. The result was his commit you refer to. A side effect that fixes a weird bug on a single platform is a plus. It is well documented thanks to your work and the discussion here and on the JIRA issue. I'd just make the patch and be done with it. If it bites us in the ass in the future we can revisit. Ross

Re: deploying pdf plugin (Was: r722698 ...output.pdf)

Thorsten Scherler — 2008-12-03T13:36:09

El mié, 03-12-2008 a las 08:55 +0100, Thorsten Scherler escribió: Did that now Commit de la revisión 722880. The version of the plugin already had been changed (as I could see from the merging div) leaves us to deploy to 0.9 and not 08, right? - 0.3-dev + 0.2-dev salu2

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Gavin — 2008-12-03T11:52:56

Hmm, I'll expand on that. In the pluginTemplate we can add commented out example code to locationmap.xml like :- Currently the is empty. Then once a stylesheet has been created the dev can uncomment out the example. Gav...

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Gavin — 2008-12-03T11:30:38

I was thinking if they are required lines we could just add them in to the template directly so that they are there already, does that sound ok? If so I'll do all this tomorrow. Gav...

[jira] Created: (FOR-1133) PDF don't display images in deployed WAR file on Tomcat

Antoine ROBERT (JIRA — 2008-12-03T08:37:44

PDF don't display images in deployed WAR file on Tomcat ------------------------------------------------------- Key: FOR-1133 URL: https://issues.apache.org/jira/browse/FOR-1133 Project: Forrest Issue Type: Bug Components: Plugin: output.pdf Affects Versions: 0.8 Reporter: Antoine ROBERT Priority: Critical Hi, In order to make this discussion as an official issue (http://www.nabble.com/PDF-not-working-correctly-in-deployed-WAR-file-on-Tomcat-td15295911.html) i post a JIRA. Bug information : Tools : apache-tomcat-6.0.18 + apache-forrest-0.8 + java-1.6 OS : Windows XP and CentOs (a RedHat) Step to reproduce 1/ Download apache-forrest-0.8 (Actual release) 2/ Downlaod apache-tomcat-6-0.18 (Actual release) 3/ Use java 1.6 (Actual release) 4/ forrest seed (To create sample forrest site) 5/ forrest war (to create WAR sample forrest site) 6/ put the .war in the tomcat webapps folder 7/ Launch sample forrest application from tomcat 8/ Go to any page with any image of this war sample forrest site 9/ Try to see it in PDF version 10/ See that you don't have image displayed The issue is that, images are not displayed .. Any image (gif, png, jpg). This issue is only in case of a deployed WAR, that works fine in jetty. Here are some clues about the issue : When i take a look in the graphical section of the .fo file I can see that : fo:external-graphic src="context:///project/src/documentation/content/xdocs/mySpecificProject/conception/specificModule/fonctionnal/../resource/anImage.jpg" And when I take a look in my WEB-INF/logs/core.log i can see that : http-8080-1/ExternalGraphic: Error while creating area : Error with image URL: context:/project/src/documentation/content/xdocs/mySpecificProject/conception/specificModule/fonctionnal/../resource/anImage.jpg (No such file or directory) and no base URL is specified I think that is a serious issue, and I would like your opinion about it. Thanks

Re: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Thorsten Scherler — 2008-12-03T08:03:45

El mié, 03-12-2008 a las 12:02 +1100, David Crossley escribió: ... Not sure I understand since the create target only will create one time the matches and then the plugin dev has to implement all custom ones. However picking up this idea the following can be implemented very easy with the target David just mentioned. and then we can use {lm:output.Text.home} later on. salu2

Re: deploying pdf plugin (Was: r722698 ...output.pdf)

Thorsten Scherler — 2008-12-03T07:55:34

El mié, 03-12-2008 a las 12:24 +1100, David Crossley escribió: Hmm, rats I thought the 'deploy-docs' will pick up my local version and publish correspondingly. I will revert the commit. salu2

deploying pdf plugin (Was: r722698 ...output.pdf)

David Crossley — 2008-12-03T01:24:52

That just deployed the docs. However it refers to changes to the plugin that have not yet been deployed. There was past discussion about this but not yet done. It refers to the instructions about plugin management. The plugins version number would need to incremented. Also the new features require 0.9 forrest version. So need to deploy the old 0.8 based plugin one more time, then deploy the 0.9 version. -David

Re: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

David Crossley — 2008-12-03T01:02:41

Don't forget that this would need to be handled by the Ant target that creates a new plugin from the template: http://forrest.apache.org/docs/dev/howto/howto-buildPlugin.html#seed -David

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Thorsten Scherler — 2008-12-03T00:38:33

... Actually it maybe our bug after all. Looking at my commit you pointed out it feels right to have a non relative match as fallback. I mean the relative match in the lm is for the rare case that one is requesting the plugin directly or one needs a custom implementation of the match. However relative path for plugins means: one cannot reuse the lm match from a project or plugin without implementing the match. ...and that does not feel right and more like a bug. The above discussed is not a hack but a clear enhancement. Well e.g. {forrest:forrest.plugins}/org.apache.forrest.plugin.output.Text/ should be replaced by something shorter. Awesome would be {this} but not sure whether that is easily to implement. salu2

Re: dev-changes: documentation?

Thorsten Scherler — 2008-12-03T00:22:34

http://forrest.apache.org/docs_0_90/changes.html#version_0.9-dev However each plugin should provide its own changes file. That sounds like http://forrest.apache.org/pluginDocs/plugins_0_80/org.apache.forrest.plugin.output.pdf/changes.html However seems that is not updated (yet I am trying to do so ATM) However there have been a lot discussion about this on the dev list and on the user list Ferdinand made some examples on it. There is always "svn log". ... but see the archives first since there is some good starting points there. HTH salu2

dev-changes: documentation?

EMMEL Thomas — 2008-12-02T13:55:09

Hi, where can I see documented changes to the code-base (0.9dev)? For example, it seems that there was a change in the colors used for creating pdf-files: (skinconf.xml) old: pdfbody, new: body (which was previously available without meaning?) However, I can't find the change anywhere documented... Any hint? Regards Thomas

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Gavin — 2008-12-02T11:52:37

Thanks, it also happens to be a (not necessarily the) fix for getting trunk working again for Windows Devs. We need to look a bit higher up in the chain as to what makes this work and if we can find a solution without having to have this fallback permanently in all plugins, current and future. I don't know why, I just have the niggling feeling that because it works without this fix for Linux/MAC then applying the above fix for Windows feels to me like a hack. However, if the above fix is useful in general for making reusable resources available by default then it doesn't feel so bad. Combine that with talk of future and markably different direction(s) for Forrest as a whole then it might just be acceptable. I will spend some more time tomorrow delving a bit deeper and see what I can find as a better solution if there is one, any hints as to where to look would be great. If I or someone else doesn't come up with one soon, then as I've mentioned before, I'll commit what I've got. If any other Windows Devs are able to confirm trunk also works for them with these fixes that would be good also, and if there are any objections ... Gav...

FOR-1102: may happen for a normal html-table too

EMMEL Thomas — 2008-12-02T11:42:36

Hi, I observed this problem: ERROR - Ignoring property: number-columns-repeated="NaN" (No conversion defined NaN; property:'number-columns-repeated') X [0] reference/config/foo.pdf BROKEN: Error(Unknown location): fo:table-body is missing child elements. Required Content Model: marker* (table-row+|table-cell+) using a default html-file as source including a table with ... ...

as soon as I remove and just leave the content it works. IMHO, this is problem of the odt plugin as described in FOR-1102 Kind regards Thomas

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Thorsten Scherler — 2008-12-02T11:42:52

El lun, 01-12-2008 a las 12:04 +1000, Gavin escribió: ... ... Yeah, actually if we want to reuse resources from other plugins the relative path does not work in the lm for plugins. The solution to add as fallback the absolute location will work for all plugin as I understand it and brings the benefit of usability of the resources. salu2

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Gavin — 2008-12-01T04:46:44

Cool, thanks Brian, so that's Dispatcher working again. And I've tested more with more plugins/whiteboard plugins both without and with the dispatcher enabled. All the altered ones work fine in both. I've not come up with anything else yet, and have gone through every diff of every commit of the branch that David merged and am none the wiser, but then again there are a few jar files that are different/new and I haven't touched those. I think now that we have a solution and that it works for me, I'll carry on using it for a couple of days and see how it goes, if no other solution presents itself then I'll probably commit our fix as is across all plugins. Cheers Gav...

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Gavin — 2008-12-01T02:26:03

The only things I can see so far is David changing from ServiceManager to ComponentManager in various areas such as XPathTransformer.java, LocationMap.java and things like like [2] , but I have no clue whether this would affect Windows in any way. Just thought I'd throw that in, in case anyone wants to discount those from our search. [2] - http://svn.apache.org/viewvc/forrest/trunk/main/java/org/apache/forrest/?pat hrev=694101

RE: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Gavin — 2008-12-01T02:04:34

False alarm there, I just tried it again and the entries are placed there correctly. They come from the /var/pluginMountSnippet.xml and pluginLmMountSnippet.xml files. So even an entry for an unaltered plugin does appear, but those matches are looking for entries containing the full path and so when we alter a plugin to suit, it works. I checked the PDF plugin again as this was never broken on Windows and found that the exact same fix we recently found we needed to do to other plugins was already present in the PDF plugin. Thorsten committed this change back in February 18th [1] with the log message of 'making resources usable from other plugins' . I have yet to find out why this change makes things work again on Windows but is not needed for Linux/MAC. Gav... [1] - http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin .output.pdf/locationmap.xml?r1=628558&r2=628586&diff_format=h

[jira] Subscription: FOR-open-with-patch

2008-11-30T20:31:46

Issue Subscription Filter: FOR-open-with-patch (12 issues) Subscriber: rgardler Key Summary FOR-211 whole-site html and pdf: broken ext links https://issues.apache.org/jira/browse/FOR-211 FOR-969 Add sensible site navigation in DOAP plugin https://issues.apache.org/jira/browse/FOR-969 FOR-355 Improved PDF configurability (e.g., TOC, Page Numbers, logo) https://issues.apache.org/jira/browse/FOR-355 FOR-652 CSS Style Sheets need cleanup, optimization and better naming of elements https://issues.apache.org/jira/browse/FOR-652 FOR-998 [PATCH] Resolve empty cells. https://issues.apache.org/jira/browse/FOR-998 FOR-707 Document i18n features of Forrest https://issues.apache.org/jira/browse/FOR-707 FOR-412 use CSS for displaying list of Changes https://issues.apache.org/jira/browse/FOR-412 FOR-311 OOo Headings bug causes Forrest to fail https://issues.apache.org/jira/browse/FOR-311 FOR-934 i18n language override menu https://issues.apache.org/jira/browse/FOR-934 FOR-280 gather index terms from documents to create index page with links https://issues.apache.org/jira/browse/FOR-280 FOR-752 Forrestbot "build" workstage creates spurious "build/webapp/WEB-INF/logs" directory https://issues.apache.org/jira/browse/FOR-752 FOR-795 Navigation bars for easy access in long documents https://issues.apache.org/jira/browse/FOR-795

Re: [jira] Commented: (FOR-1108) Dispatcher, Cocoon 2.1 and Windows

Brian M Dube — 2008-11-30T20:05:59

I think you found something. On Windows, these two files are not updated to reflect the chosen plugins, contrary to Linux. Brian