http://blog.gmane.org/gmane.text.xml.fop.devel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.text.xml.fop.devel/21696 https://issues.apache.org/bugzilla/show_bug.cgi?id=45705 Andreas L. Delmelle <adelmelle< at >apache.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID --- Comment #2 from Andreas L. Delmelle <adelmelle< at >apache.org> 2008-08-29 11:02:04 PST --- Reference found: http://www.w3.org/TR/xsl/#spacecond (a bit esoteric, but if you read closely, you'll see that FOP actually tries to be compliant, where XEP doesn't seem to care that much :-)) As to answer my own question-mark: yes, .conditionality does explain why the margin-top is dropped, since the block in question has no borders/padding (= no fence preceding) and leads in a reference area. To conclude: definitely not a bug in FOP. The behavior, as unexpected as it may be, is entirely correct. bugzilla< at >apache.org 2008-08-29T18:02:04 http://permalink.gmane.org/gmane.text.xml.fop.devel/21695 https://issues.apache.org/bugzilla/show_bug.cgi?id=45705 --- Comment #1 from Andreas L. Delmelle <adelmelle< at >apache.org> 2008-08-29 10:47:36 PST --- (In reply to comment #0) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22493) [details] Very unexpected result indeed, but also entirely wrong? There is definitely something 'off', but I'm wondering whether FOP gets it half right, and XEP is actually more at fault for not collapsing the space-before and space-after with the margins of the nested blocks. As for the difference between the cases with and without additional borders, I'm still looking for the reference, but I seem to remember that borders act as a fence for space-resolution, so I guess there should at least be /some/ difference between the two. XEP seems to miss the ball there (and, of course, FOP's dashed borders are much nicer ;-)) A workaround, if you want to guarantee that all spaces are preserved under all conditions, would be to abandon the "margin" shorthand, and use the more verbose native XSL-FO properties, like so: <block space-after.optimum="5mm" space-after.conditionality="retain" space-after.precedence="force" ...> <block space-before.optimum="2mm" space-before.conditionality="retain" space-before.precedence="force" ...> You can still use the margin shorthand to set space-start and space-end, but if you want control over precedence and conditionality, you also have to set the length component through the native property. Precedence explains why the margin-bottom of the first nested block seems to disappear. It is collapsed, because the 5mm space-after wins ( 5 > 2 ). Conditionality may explain why the margin-top for that very same block is dropped (?) bugzilla< at >apache.org 2008-08-29T17:47:38 http://permalink.gmane.org/gmane.text.xml.fop.devel/21694 https://issues.apache.org/bugzilla/show_bug.cgi?id=45702 --- Comment #1 from Patrice ROSNET <patrice.rosnet< at >free.fr> 2008-08-28 00:40:38 PST --- Created an attachment (id=22490) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22490) For testing Testing file that generates those warning messages bugzilla< at >apache.org 2008-08-28T07:40:38 http://permalink.gmane.org/gmane.text.xml.fop.devel/21693 https://issues.apache.org/bugzilla/show_bug.cgi?id=45702 Summary: Unresolved ID with fo:page-number-citation-last Product: Fop Version: 1.0dev Platform: PC OS/Version: Windows 2000 Status: NEW Severity: normal Priority: P2 Component: page-master/layout AssignedTo: fop-dev< at >xmlgraphics.apache.org ReportedBy: patrice.rosnet< at >free.fr Some ID cannot be resolved by fo:page-number-citation-last With FOP-trunk_svn689406 WARN: Page 1: Unresolved ID reference "space-after" found. WARN: Page 1: Unresolved ID reference "margin-bottom" found. WARN: Page 1: Unresolved ID reference "margin" found. WARN: Page 1: Unresolved ID reference "padding" found. WARN: Page 1: Unresolved ID reference "padding-bottom" found. With FOP 0.95: WARN: Page 1: Unresolved id reference "inline" found. bugzilla< at >apache.org 2008-08-28T07:36:08 http://permalink.gmane.org/gmane.text.xml.fop.devel/21692 https://issues.apache.org/bugzilla/show_bug.cgi?id=45705 Summary: margin on blocks does not work as expected Product: Fop Version: 0.95 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: fop-dev< at >xmlgraphics.apache.org ReportedBy: sam< at >4tek.de Created an attachment (id=22493) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22493) test source and example pdfs the margins of blocks are displayed different, whether the block has a border or not. Additionaly it isn´t displayed as expected compared to xep 4.11. Just see attached example. bugzilla< at >apache.org 2008-08-28T12:55:59 http://permalink.gmane.org/gmane.text.xml.fop.devel/21691 https://issues.apache.org/bugzilla/show_bug.cgi?id=45702 --- Comment #2 from Patrice ROSNET <patrice.rosnet< at >free.fr> 2008-08-28 05:26:07 PST --- Created an attachment (id=22492) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22492) Test file with several pages for each ID The preceding test has one page for each ID (PNC=PNCL) In this test page breaks have been added in each element with ID, so PNCL is different from PNC The result is NOT correct: With FOP-trunk_svn689406 NO ID is resolved With FOP-0.95 IDs are resolved but PNCL is wrong (equals to PNC) bugzilla< at >apache.org 2008-08-28T12:26:08 http://permalink.gmane.org/gmane.text.xml.fop.devel/21690 I don't think it's disabled. I rather think it was never added to the TestSuite in the first place. Feel free to add it. On 26.08.2008 13:12:58 Max Berger wrote: Jeremias Maerki Jeremias Maerki 2008-08-26T11:40:40 http://permalink.gmane.org/gmane.text.xml.fop.devel/21689 Hi Max, I don't know of any reason, I guess maybe it was broken at some point in time? It certainly makes sense that we have a working and enabled unit test for this. So please do so by all means, +1 from me. Adrian. Max Berger wrote: Adrian Cumiskey 2008-08-26T11:27:27 http://permalink.gmane.org/gmane.text.xml.fop.devel/21688 Dear Fop-devs, is there a specific reason why URIResolutionTestCase is disabled? May I re-enable it (as in the attached patch)? Background: Before I do further URI-Resolver patching / moving I would like to test the current behavior as not to break anything. Max Max Berger 2008-08-26T11:12:58 http://permalink.gmane.org/gmane.text.xml.fop.devel/21687 Jeremias, My intentions and motivations were simple really, I was making use of the FOP UnitConv class in the branch work and noticed an identical class (in every way apart from package name) existing in xmlgraphics commons. So I simply spent 10 mins removing the duplication. I have now provided a deprecated UnitConv class in FOP to cater for the possibility that someone may have been using it. Adrian. Jeremias Maerki wrote: Adrian Cumiskey 2008-08-26T08:42:06 http://permalink.gmane.org/gmane.text.xml.fop.devel/21686 https://issues.apache.org/bugzilla/show_bug.cgi?id=45667 Marco <mercuron< at >gmx.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mercuron< at >gmx.ch bugzilla< at >apache.org 2008-08-25T13:43:43 http://permalink.gmane.org/gmane.text.xml.fop.devel/21685 Oops. Thanks for noticing, Pascal. Fixed now: http://svn.apache.org/viewvc?rev=688660&view=rev On 25.08.2008 10:35:23 Pascal Sancho wrote: Jeremias Maerki Jeremias Maerki 2008-08-25T08:44:41 http://permalink.gmane.org/gmane.text.xml.fop.devel/21684 Hi Jeremiah, There is an ommited copy/paste, isn't? Pascal Pascal Sancho 2008-08-25T08:35:23 http://permalink.gmane.org/gmane.text.xml.fop.devel/21683 (Moving to general as we're talking about code in Commons, not FOP) Thanks for sharing. I have two observations here: 1. CommonURIResolver is final and designed as a Singleton. In my past experience that restricts its usefulness too much. If you look at all the "registries" in FOP you'll see that they are not singletons but attached to the FopFactory (which isn't a singleton either). That allows to have multiple "environments" inside the same JVM/classloader setup if someone desires that. If someone wants a singleton for a particular purpose he can always do so easily. But if it's already a singleton you are locked in. Anyway, I've made it a habit of avoiding singletons whenever possible. 2. It should be noted that this approach here only allows "general" resolvers. There's no access to "local" configuration or context information that allows customizing the behaviour. Such URI resolver will still have to be set up by the users. I'm curious: what kind of URI resolver do you want to add here from a plug-in that motivated you to do this? On 25.08.2008 08:47:39 Max Berger wrote: Jeremias Maerki Jeremias Maerki 2008-08-25T07:23:22 http://permalink.gmane.org/gmane.text.xml.fop.devel/21682 Jeremias, my fault again. You are absolutely right, I should provide a "deprecated" version of the old classes in all cases, and probably discuss the idea. I'll do the later today, and here's the second one: Background is this thread [1] which showed a flaw in the way FOP resolves URIs. Current Situation: * FOP provides support for 1 Custom Resolver * It also adds the data: URI resolver * and has a sophisticated resolving method for other URIs which are openable through URL.open (better than the JDK default) Problem: A plugin cannot add a URIResolver to FOP, as there is only 1 custom resolver, and it is defined by the user. Main Idea: Support a generic "chain" of URIResolvers. All URI resolvers are called in order, if one of them can resolve the URI it will return a source, otherwise null. Implementation Idea: Need a URIResolver registry, like the ImageLoader registry. It should automatically load all URIResolvers declared as service, and provide register() and unregister() functionality. A Generic URI resolver will then try all registered resolvers first, and then fall back to the default (which would be the functionality as it is in FOP now). Plugins can then register their own URI resolver, which could either add URIs (there are some examples of a XML: URI in commons, which would be interesting), or provide mapping for well-known URIs, such as the ones of DTDs and entities. [1] http://www.nabble.com/Getting-Batik-to-read-SVG-DTDs-via-catalog-resolver-td18169780.html Hope this makes sense Max Jeremias Maerki schrieb: Max Berger 2008-08-25T06:47:39 http://permalink.gmane.org/gmane.text.xml.fop.devel/21681 I'm seeing a new pattern here and I'm not entirely happy about it. I'd prefer at least a short deprecation time (one release) before final removal. Also a short discussion or at least an advance notice about someone's intentions and motivations would be appreciated. But maybe that's only me. On 24.08.2008 15:12:02 maxberger wrote: On 20.08.2008 17:13:56 acumiskey wrote: Jeremias Maerki Jeremias Maerki 2008-08-25T06:25:26 http://permalink.gmane.org/gmane.text.xml.fop.devel/21680 +---------------------------------------------------------------------------+ | Bugzilla Bug ID | | +---------------------------------------------------------------------+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned | | | OPN=Reopened VER=Verified (Skipped Closed/Resolved) | | | +-----------------------------------------------------------------+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement TRV=Trivial | | | | +-------------------------------------------------------------+ | | | | Date Posted | | | | | +--------------------------------------------------+ | | | | | Description | | | | | | | | 1063|New|Nor|2001-03-21|fop does not handle large fo files | | 3280|New|Nor|2001-08-27|PCL Renderer doesn't work | | 3824|New|Blk|2001-09-25|MIF option with tables | | 4030|New|Nor|2001-10-08|IOException creating Postscript with graphics on S| | 4535|New|Maj|2001-10-31|PCL renderer 1.13 not rendering SVG | | 5010|New|Enh|2001-11-21|Better error reporting needed | | 5124|New|Maj|2001-11-27|fo:block-container is not rendered properly using | | 6305|New|Nor|2002-02-07|Using fo:table-and-caption results in empty output| | 6427|New|Enh|2002-02-13|Adding additional Type 1 fonts problem | | 6997|New|Nor|2002-03-09|[PATCH] Row-spanned row data breaks over a page wi| | 7241|New|Nor|2002-03-19|keep-with-previous, keep-with-next only working on| | 8003|Ass|Maj|2002-04-12|FopImageFactory never releases cached images | | 8463|New|Nor|2002-04-24|SVG clipping in external.fo example doc when rende| | 8767|Ass|Min|2002-05-03|Image and solid colour background rectangle sizes | | 9379|New|Nor|2002-05-24|MIF Renderer generates incorrect MIF code | |10379|New|Enh|2002-07-01|Improvement to FOP Classloader | |12494|New|Nor|2002-09-10|fop produces pdf file which Acrobat Reader refuses| |12610|New|Enh|2002-09-13|[PATCH] onLoad Action for PDF documents or how to | |13586|New|Blk|2002-10-13|fop will not work on linux alpha because jre is br| |13734|New|Nor|2002-10-17|Hyphenation does not work correctly on long string| |14248|New|Enh|2002-11-05|51-page FO example, could be added to the samples | |14352|New|Enh|2002-11-07|It would be nice if FOP could be plugged into popu| |14356|New|Nor|2002-11-07|*NOT* embedding TrueTypeFont in PDF causes Acrobat| |14419|New|Enh|2002-11-10|Implement SourceResolver, Image Resolver | |14529|New|Nor|2002-11-13|SVG url references do not work | |14679|New|Enh|2002-11-19|Pluggable renderers | |14924|New|Nor|2002-11-28|Table disappears when it ends when the page ends | |15020|New|Enh|2002-12-03|Reuse of fo-tree | |16017|Opn|Nor|2003-01-13|Jpeg's and the PDF Serializer | |16130|New|Nor|2003-01-15|PS-Renderer emits lots of redundant moveto's | |16156|New|Nor|2003-01-16|0.20.5rc SVG example does not work | |16713|New|Nor|2003-02-03|Hyphenation error in tables | |17369|New|Nor|2003-02-25|Footnote duplication | |17380|New|Nor|2003-02-25|Batik Component will not recognize feXXXX SVG elem| |17921|New|Nor|2003-03-12|Kerning is broken for standard fonts | |18292|New|Nor|2003-03-24|24 bit PNG not displayed correctly | |18801|New|Nor|2003-04-08|"visibility" property is not implemented | |19228|New|Blk|2003-04-22|[PATCH] Child LayoutContext is null in certain cir| |19341|Ver|Nor|2003-04-26|leader doesn't work since 0.20.5.rc2 | |19695|New|Enh|2003-05-06|[PATCH] Allow fox:destination as child of fox:outl| |19717|New|Enh|2003-05-07|Lets add support for JimiClassesPro.zip to build.x| |19769|Ass|Enh|2003-05-08|Indefinite page size is not implemented | |20280|Ass|Enh|2003-05-27|text-align and text-align-last only partially impl| |20407|New|Enh|2003-06-02|[PATCH] Configure image caching using the configur| |20827|New|Enh|2003-06-17|Derive other font styles and weights from normal T| |21265|Opn|Nor|2003-07-02|referencing a custom font (TTF or Adobe Type 1) fo| |21905|New|Nor|2003-07-26|large list-item-label bleeds into following block | |21982|New|Maj|2003-07-30|NullPointer Exception in LazyFont with embedded fo| |22450|New|Maj|2003-08-15|Unterminated iteration in JPEGReader class | |22627|Opn|Nor|2003-08-21|Update mirror/download page HEADER & README (was [| |24148|New|Nor|2003-10-27|Kerning upsets text-align="end" | |24171|New|Nor|2003-10-28|[PATCH] 1st Attempt at Whole Site PDF | |24378|New|Nor|2003-11-04|Minor problem in sample code for embedding | |24663|New|Nor|2003-11-12|fo:block space-after property needs fixing | |24804|New|Nor|2003-11-18|SVG Text to PS Output generates incorrect outlines| |25022|New|Nor|2003-11-26|XSL-FO to PCL : images not included | |25341|New|Nor|2003-12-08|percentage resolution not being recalculated on di| |25411|New|Nor|2003-12-10|[WARNING] Error while constructing image from XML | |25432|Ass|Maj|2003-12-11|Cannot embed the User Defined Characters into the | |26047|New|Nor|2004-01-11|Space-after value remembered and used on second do| |26590|New|Nor|2004-02-02|last character width in winansi font is missed | |26848|New|Nor|2004-02-11|PNG images using JIMI instead JAI | |27107|New|Maj|2004-02-20|TTF Reader fails | |27727|New|Maj|2004-03-17|problem displaying Japanese fonts in PDF. | |27890|New|Min|2004-03-24|fop.sh doesn't set exit status | |29632|New|Maj|2004-06-17|Rendered reads fonts from disk everytime it render| |29711|New|Maj|2004-06-21|[PATCH] LineArea.canBreakMidWord() RFC3066 fix | |30006|New|Nor|2004-07-09|eps doesn't show up in recent GhostScript versions| |30214|New|Nor|2004-07-20|PSGraphics2D.drawImage incorrect matrix generated | |31039|New|Nor|2004-09-03|URL in basic-link is scrambled by encryption | |31225|New|Nor|2004-09-14|Need embedded page sequence functionality | |31301|New|Nor|2004-09-19|FOP limitation-Summary of columns value at Table F| |31674|New|Enh|2004-10-12|Allow Print Renderer to select Printer and Tray. | |31796|New|Cri|2004-10-20|Fop: Pdf generation dowsn`t work with j2sdk 1.5 | |32054|New|Enh|2004-11-04|Pluggable area creation: AreaFactory | |32100|Ass|Enh|2004-11-07|FOP "Starter Documents" | |32107|New|Cri|2004-11-07|Move FOP wiki to secure | |32201|Opn|Enh|2004-11-12|please, provide a manpage | |32789|New|Cri|2004-12-21|Arabic words are broken for rendering PDF from FOP| |32970|New|Cri|2005-01-06|Sticking words in generated PDF document | |33174|New|Nor|2005-01-20|An unrecognized token'NaN' was found when opening | |34355|New|Cri|2005-04-07|BufferOverflowException when running SVG2PDF on hu| |35184|New|Trv|2005-06-02|Error while loading image http://xxx.xx.x/yyyy.tif| |35500|New|Nor|2005-06-24|Missing .close() call on stream opened for JPEG im| |35939|New|Nor|2005-07-30|[PATCH] Port of 0.20.5 Driver.java class | |35948|New|Enh|2005-07-31|pre-patch for FOrayFont adaptation to Fop | |36000|Ver|Maj|2005-08-03|PDF page margins larger, different than PS renderi| |36011|New|Nor|2005-08-04|Setting word-spacing on justified blocks removes j| |36238|Ass|Nor|2005-08-18|text-align="justify" doesn't work on custom fonts | |36395|New|Nor|2005-08-27|Common Border and Background Properties not suppor| |36408|Opn|Min|2005-08-29|FOP hyphenation splits consecutive digits onto sep| |36533|Opn|Nor|2005-09-07|Incorrect ipd and twsadjust settings | |36935|New|Blk|2005-10-05|table-layout="fixed" and width="auto", but auto-la| |36977|New|Nor|2005-10-09|[PATCH]TextLayoutManager CJK line break | |37108|New|Nor|2005-10-16|Patch for 0.20.5 to work with jdk1.5 | |37114|New|Min|2005-10-17|No error message on illegal/unknown values on a pr| |37116|New|Enh|2005-10-17|ESC POS Renderer | |37136|Opn|Nor|2005-10-18|external-graphic dimensions and rendering | |37236|Ass|Nor|2005-10-25|[PATCH] Fix gradients and patterns | |37305|Ass|Nor|2005-10-30|Added deviceDPI to PDFDocumentGraphics2D | |37505|New|Cri|2005-11-15|SEVERE FOP Exceptions should be thrown! | |37579|Ass|Nor|2005-11-21|footnotes within tables and listsl get lost | |38121|New|Nor|2006-01-04|border-separation disturbs table layout | |38244|New|Nor|2006-01-12|table-column and number-columns-spanned (prepatch)| |38264|Ass|Nor|2006-01-13|Hyphenation does not play well with preserved line| |38639|Inf|Maj|2006-02-14|PDF not opening | |38821|Opn|Nor|2006-03-01|The manifest file no longer has a Class-Path entry| |38862|New|Maj|2006-03-06|No ImageReader for this type of image | |38880|Ass|Nor|2006-03-07|Right border on fo:inline missing when hyphenate=t| |39034|New|Nor|2006-03-20|page-number-citation : the text after overlaps the| |39118|Ass|Nor|2006-03-27|[PATCH] Handling of page-number-citation-last | |39184|New|Nor|2006-04-03|soft page break on new line | |39215|New|Nor|2006-04-05|[PATCH] To render GIF external images in RTF outpu| |39261|New|Min|2006-04-10|Rasterized paints upside down if coordinate system| |39293|New|Enh|2006-04-13|FOP can't support bold,italic for chinese/other mu| |39412|Ass|Nor|2006-04-26|wrong URL referred from FOP: Bugs and Other Tracka| |39422|New|Nor|2006-04-27|[PATCH] Fop fails to render non-ascii characters i| |39725|New|Maj|2006-06-05|page-position="last" and spans doesn't output all | |39777|Ass|Enh|2006-06-11|[PATCH] GSoC: floats implementation | |39840|Ass|Cri|2006-06-20|Multi page table fails with an endless loop error | |39927|Ass|Nor|2006-06-28|Building FOP with GCJ | |39968|New|Nor|2006-07-05|Absolutely positioned block-container affects the | |40112|New|Nor|2006-07-26|keep-with-previous.within-page not working | |40271|Ass|Nor|2006-08-17|[PATCH] auto table layout -- dirty draft | |40288|Opn|Nor|2006-08-18|<base> url requires "/", failes otherwise | |40464|New|Nor|2006-09-11|Improve handling of OpenType fonts | |40465|New|Nor|2006-09-11|Obtain some OpenType fonts for testing | |40468|New|Nor|2006-09-11|Use OpenType fonts from the STIX fonts project? | |40529|New|Nor|2006-09-17|[PATCH] Possible bug in PSTextRenderer | |40557|Ass|Nor|2006-09-20|PDF encryption and Acrobat 5 | |40676|Ass|Enh|2006-10-04|png graphics are expanded/uncompressed in pdf caus| |40699|New|Nor|2006-10-06|Invalid PDF for certain numerical values in SVG li| |40798|New|Maj|2006-10-19|page-position="last" doesn't work for 1 page docum| |40830|Inf|Nor|2006-10-27|Pb rendering SVG in fo:instream-foreign-object wit| |41062|New|Nor|2006-11-28|Defect reading hyphenation patterns | |41122|New|Nor|2006-12-07|[PATCH] flow-map 1.1 support | |41149|Ass|Nor|2006-12-11|PNG causes NPE for RTF output | |41251|Opn|Nor|2006-12-28|ArrayIndexOutOfBoundsException in multithreading e| |41272|Opn|Nor|2006-12-31|Memory problem in 0.93 | |41295|New|Min|2007-01-04|Examples cause fatals and excessive warnings | |41300|New|Min|2007-01-05|FATAL error raised for proportional-column-width()| |41377|Ver|Blk|2007-01-16|Alignment (end, right) does not work in table-cell| |41379|New|Maj|2007-01-16|VerifyError on FopFactory.newInstance() using Tomc| |41380|New|Min|2007-01-16|Content in tables affecting conditional spacing of| |41389|New|Maj|2007-01-17|Rtf numbered lists without numbers | |41440|Ass|Nor|2007-01-23|PDFSVGHandler causes missing resource bundle | |41443|New|Nor|2007-01-23|[PATCH] FOP can't handle mixed-case hyphenation ex| |41445|Inf|Nor|2007-01-23|no searchable text in pdf for <image xlink:href to| |41633|New|Nor|2007-02-16|*-progression-dimension on inlines not implemented| |41637|New|Nor|2007-02-16|in-line border-end does not always get rendered | |41649|New|Cri|2007-02-16|fop0.93 - Does not generate svg line or svg rectab| |41657|New|Nor|2007-02-19|No support for SVG 1.2 in instream-foreign-object | |41667|New|Nor|2007-02-21|ImageProvider should be overridable in ImageFactor| |41812|New|Trv|2007-03-11|fillRect writes wrong command | |41822|New|Nor|2007-03-12|Generated example from \examples\fo\basic\list.fo | |41894|New|Nor|2007-03-19|fo:block-container: percentage-lengths + width/hei| |41918|New|Nor|2007-03-21|Thin Lines in AWTRenderer are not drawn | |41942|New|Nor|2007-03-25|fo:leader elements are ignored when converted to R| |41951|New|Nor|2007-03-26|External graphic doesnt size properly with height | |41959|New|Nor|2007-03-27|External links are broken if pdf is encryped | |41978|New|Maj|2007-03-28|Rogue entries on a blank page | |41995|New|Enh|2007-03-30|[PATCH] Barcode Support for AFP Renderer | |41999|New|Nor|2007-03-30|Unassigned code points cause ArrayIndexOutOfBounds| |42028|New|Nor|2007-04-02|Incorrect rendering of GIF images | |42034|New|Nor|2007-04-03|basic-link doesn't cover all text inside | |42049|New|Nor|2007-04-04|RTF (and PDF) tables incorrectly handle margin-lef| |42136|New|Nor|2007-04-16|PDFDocumentGraphics2D.translate() does not work co| |42162|New|Nor|2007-04-18|hyphenation inside block in FOP works only for pur| |42306|New|Nor|2007-05-01|[PATCH] AWT Viewer does not track page numbers in | |42307|New|Cri|2007-05-01|[PATCH] Java2d renderers render arabic text incorr| |42330|New|Nor|2007-05-03|Tibetan characters not rendered correctly in PDF | |42352|New|Nor|2007-05-08|Problem with tiff gray render | |42374|New|Nor|2007-05-09|List label and bodyindentation incorrect in RTF | |42380|New|Nor|2007-05-10|FOP chokes on jar-embedded class path | |42501|New|Nor|2007-05-23|basic-link not sizing correctly for external-graph| |42577|Ass|Nor|2007-06-04|font-stretch [PATCH] | |42600|New|Nor|2007-06-06|can not create page break in RTF | |42601|New|Nor|2007-06-06|Image/text misalignment inside before-region table| |42616|Opn|Nor|2007-06-08|fop bash script still broken under cygwin when cur| |42617|New|Nor|2007-06-08|DOM tree cannot be built for a SVG graphic embedde| |42685|Ass|Nor|2007-06-17|Printer restarts after sucessfull printing Postscr| |42769|New|Nor|2007-06-28|Wrong border resolution in a table when there are | |42779|Ass|Nor|2007-06-29|page-position and force-page-count with different | |42808|New|Nor|2007-07-04|table footer overflows region-body area without wa| |42845|Inf|Nor|2007-07-10|Printing error. Prints charater+1. | |42861|Ass|Nor|2007-07-11|[PATCH] Font detection only works for first docume| |42868|New|Nor|2007-07-12|font-weight on custom fonts | |43166|New|Nor|2007-08-20|unclosed border on nested inlines | |43226|Inf|Maj|2007-08-28|images in pdf are not displayed correctly with 0.9| |43237|New|Nor|2007-08-29|IndexOutOfBoundsException | |43357|New|Min|2007-09-11|PDFGraphics2D addImage method: image in PDF look a| |43416|New|Nor|2007-09-18|content not rendered after a break-before="column"| |43474|Ass|Nor|2007-09-25|wrap-option="wrap" doesn't work | |43506|New|Nor|2007-09-28|NPE using a Tiff Image | |43525|New|Nor|2007-10-01|"background-position" shorthand is not processed p| |43570|New|Cri|2007-10-08|field ATTRIB_ROW_PADDING not found | |43651|New|Nor|2007-10-18|NPE without manually clearing image cache | |43722|New|Nor|2007-10-29|arabic character isssue | |43739|New|Nor|2007-10-30|PDF table of contents generated with incorrect pag| |43808|New|Cri|2007-11-07|Apache FOP in a Servlet fails to work after upgrad| |43844|New|Maj|2007-11-12|Extra blank lines added upon weird combinations of| |43940|New|Min|2007-11-22|Faster method for double formatting | |43962|New|Nor|2007-11-26|OutOfMemoryError while auto-detecting fonts | |44023|New|Nor|2007-12-05|An empty fo:block artificially breaks a block-stac| |44024|Ass|Nor|2007-12-05|About AFP renderer Issues when i try to using Aria| |44160|Ass|Cri|2008-01-02|IndexOutOfBoundsException when creating pdf | |44190|New|Cri|2008-01-09|<fo:block span="none"> : textblock is missing on l| |44320|New|Nor|2008-01-29|Missing before/after border when break set on a ta| |44324|New|Nor|2008-01-29|vertical-align or baseline-shift In table-cells ca| |44328|New|Nor|2008-01-30|widows not respected when linefeed-treatment="pres| |44358|New|Maj|2008-02-05|OufOfMem | |44393|Opn|Nor|2008-02-11|Wrong fo.Constant values used for break class | |44412|Inf|Nor|2008-02-13|Missing border-after when break-after set on a blo| |44434|New|Cri|2008-02-15|FO java Memory Error | |44452|New|Cri|2008-02-19|last upgrades don't render older fop xml files | |44460|Ass|Enh|2008-02-21|[PATCH] PDF Embedded files implementation | |44489|Ass|Enh|2008-02-26|AFP Renderer: Implement break-out mechanism to sup| |44490|Ass|Nor|2008-02-26|AFP Renderer: Support for clipping is missing | |44507|New|Nor|2008-02-29|PCL Renderer doesn't clip background images | |44545|Inf|Nor|2008-03-06|Keep together do not work correctly on spanning ta| |44616|New|Nor|2008-03-17|Merging algorithm for tables properly works only f| |44634|Ass|Enh|2008-03-19|implement show-destination for fo:basic-link | |44744|New|Nor|2008-04-03|PDFGraphics2D.drawString(AttributedCharacterIterat| |44826|New|Nor|2008-04-15|last-page master reference interfered with span al| |44885|Ass|Enh|2008-04-27|fo:inline-container implementation | |44920|Ass|Nor|2008-05-02|nested, multi-page tables and keep-with-previous | |45027|Inf|Nor|2008-05-18|Color 'blue' does not render correctly when 'fo:ex| |45047|Ass|Nor|2008-05-20|Fixed row height not taken into account if the row| |45070|Ass|Nor|2008-05-23|Spurious WARNING on span="inherit" | |45079|Ass|Nor|2008-05-27|multi page table with marker | |45097|Ass|Nor|2008-05-29|Questionable white-space-treatment behavior | |45104|New|Nor|2008-05-30|Possible Thread Safety Problem in FOP 0.93 | |45113|Ass|Enh|2008-06-01|[PATCH] Adding PDF Launch Action | |45134|Ass|Nor|2008-06-05|FOP unwarranted page split on table with numbre-ro| |45159|New|Nor|2008-06-07|fop buzzed on footnotes near page break | |45237|Ass|Nor|2008-06-19|Call order of FOEventHandler method is incorrect | |45306|Ass|Nor|2008-06-29|fo:instream-foreign-object in fo:marker does not w| |45307|New|Nor|2008-06-29|fo:block-container height issue | |45342|New|Nor|2008-07-04|AFP Renderer does not properly handle AFP fonts wi| |45351|Ass|Nor|2008-07-07|Unnecessary hyphenation, swallowed characters | |45366|New|Enh|2008-07-08|Unable to create column break in RTF using FOP | |45390|New|Nor|2008-07-13|PDF Extensions - Prototype | |45454|New|Nor|2008-07-22|Investigate the adoption of Apache Commons CLI | |45503|New|Maj|2008-07-30|Cannot find font if font family name contains spac| |45604|Inf|Nor|2008-08-08|Duplicate prints | |45616|New|Nor|2008-08-11|OpenOffice.org display table incorrectly | |45667|New|Cri|2008-08-21|NPE when having an empty <fo:inline>-element with | +-----+---+---+----------+--------------------------------------------------+ | Total 247 bugs | +---------------------------------------------------------------------------+ bugzilla< at >apache.org 2008-08-25T06:08:12 http://permalink.gmane.org/gmane.text.xml.fop.devel/21679 Hmm... safer? I do agree that this better reflects what is happening in this case, but in general... For a power as low as 5, there is only little difference, except that bit-shifting may just be a tad faster; it used to be on older hardware, and may still be so, due to the lack of bounds checking, which brings us to the case of larger powers ( >= 32, or 64 ). For larger exponents, using a mathematical rather than a bitwise operator, if the result would be too large, one would at least get an overflow error. With a bitwise operator, the leftmost bits will be shifted into oblivion. No warning/error will be issued whatsoever. Writing it in Hex, as 0x1F or (0x20 - 1) seems to be as common a practice as any. Of course, if Java would allow one to express the value in binary, that would make it even clearer... But, now that you mention it, I think the relationship is turned upside-down in the latest patch. Actually, the SEGMENT_COUNT should depend on the SEGMENT_MASK (instead of the other way around). Talking safety, maybe the following: int SEGMENT_MASK = 0x1F; //binary ( 0000 0000 0000 0000 0000 0000 0001 1111 ) ... int SEGMENT_COUNT = SEGMENT_MASK + 1; //will cause an overflow error if SEGMENT_MASK is set to Integer.MAX_VALUE or greater Cheers Andreas Andreas Delmelle 2008-08-23T11:04:59 http://permalink.gmane.org/gmane.text.xml.fop.devel/21678 That was my assumption when I saw 'MASK', in which case is it not safer to ensure that your value is in fact all ones? MASK_BIT_COUNT = 5 SEGMENT_COUNT = 1<<MASK_BIT_COUNT or some such. Peter B. West 2008-08-22T22:59:59 http://permalink.gmane.org/gmane.text.xml.fop.devel/21677 Now I suddenly see it... Due to what you point out below, some entries in bucket #0 will be distributed over the reference queueS (plural) for segments #0, #8, #16 and #24, but each cleanup only takes care of one of those 4 segments (the one where the entry ended up that was last added in put()). Correct. No idea why I never saw that... :/ The effect of the count going into the negative follows from the fact that some stale entries will actually belong to another segment. The only other way around that would have been to always limit the number of segments to table.length [i.e. the segmentIndex for a lower number of buckets should actually have been something like: hash(o) & ((SEGMENT_COUNT - 1) & (table.length - 1))], so that all entries for one bucket always belong to the same segment. My patch unconditionally cleared the whole bucket, decreasing the count for the wrong segment. Darn', I thought I had modified the constructor to not register the entry with the queue. Seems I undid that change at some point... Cheers Andreas Andreas Delmelle 2008-08-22T16:43:53 http://permalink.gmane.org/gmane.text.xml.fop.devel/21676 FWIW: Just had a (admittedly rather quick) look at the patch, and it seems fine to me. Cheers Andreas Andreas Delmelle 2008-08-22T16:12:38 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.text.xml.fop.devel