gmane.os.freebsd.devel.cvs.src

svn commit: r250903 - head/share/man/man5

Xin LI — 2013-05-22T05:21:19

Author: delphij
Date: Wed May 22 05:21:19 2013
New Revision: 250903
URL: http://svnweb.freebsd.org/changeset/base/250903

Log:
  Fix a copy-and-paste typo.

Modified:
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/src.conf.5
==============================================================================
--- head/share/man/man5/src.conf.5Wed May 22 05:16:07 2013(r250902)
+++ head/share/man/man5/src.conf.5Wed May 22 05:21:19 2013(r250903)
< at >< at > -677,7 +677,7 < at >< at > Setting this variable will enable the LD
 .Xr dig 1
 and
 .Xr host 1 .
--When set, the following options are also in effect:
+When set, the following options are also in effect:
 .Pp
 .Bl -inset -compact
 .It Va WITHOUT_BIND_UTILS
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250902 - head/share/man/man5

Xin LI — 2013-05-22T05:16:08

Author: delphij
Date: Wed May 22 05:16:07 2013
New Revision: 250902
URL: http://svnweb.freebsd.org/changeset/base/250902

Log:
  Regenerate with manual fixup for WITH_LDNS_UTILS inheriting WITHOUT_BIND_UTILS.

Modified:
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/src.conf.5
==============================================================================
--- head/share/man/man5/src.conf.5Wed May 22 05:07:55 2013(r250901)
+++ head/share/man/man5/src.conf.5Wed May 22 05:16:07 2013(r250902)
< at >< at > -1,7 +1,7 < at >< at >
 .\" DO NOT EDIT-- this file is automatically generated.
 .\" from FreeBSD: head/tools/build/options/makeman 236279 2012-05-30 02:37:20Z gjb
 .\" $FreeBSD$
-.Dd February 15, 2013
+.Dd May 21, 2013
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
< at >< at > -223,9 +223,9 < at >< at > toolchain is enabled.
 .It Va WITHOUT_BLUETOOTH
 .\" from FreeBSD: head/tools/build/options/WITHOUT_BLUETOOTH 156932 2006-03-21 07:50:50Z ru
 Set to not build Bluetooth related kernel modules, programs and libraries.
-.It Va WITH_BMAKE
-.\" from FreeBSD: head/tools/build/options/WITH_BMAKE 241279 2012-10-06 19:19:21Z marcel
-Build and install the portable BSD make (bmake) as
+.It Va WITHOUT_BMAKE
+.\" from FreeBSD: head/tools/build/options/WITHOUT_BMAKE 250839 2013-05-21 00:41:49Z delphij
+Set to not build and install the portable BSD make (bmake) as
 .Xr make 1
 instead of the traditional FreeBSD make.
 This build option is temporary.
< at >< at > -302,6 +302,12 < at >< at > When set, it also enforces the following
 .It
 .Va WITHOUT_CLANG_IS_CC
 .El
+.It Va WITH_CLANG
+.\" from FreeBSD: head/tools/build/options/WITH_CLANG 221730 2011-05-10 11:14:40Z ru
+Set to build the Clang C/C++ compiler.
+.Pp
+It is a default setting on
+amd64/amd64, arm/arm, arm/armv6, i386/i386, pc98/i386, powerpc/powerpc and powerpc/powerpc64.
 .It Va WITH_CLANG_EXTRAS
 .\" from FreeBSD: head/tools/build/options/WITH_CLANG_EXTRAS 231057 2012-02-05 23:56:22Z dim
 Set to build additional clang and llvm tools, such as bugpoint.
< at >< at > -328,7 +334,7 < at >< at > and
 .Pa /usr/bin/cpp .
 .Pp
 It is a default setting on
-arm/arm, arm/armeb, arm/armv6, arm/armv6eb, ia64/ia64, mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, powerpc/powerpc, powerpc/powerpc64 and sparc64/sparc64.
+arm/armeb, arm/armv6eb, ia64/ia64, mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, powerpc/powerpc, powerpc/powerpc64 and sparc64/sparc64.
 .It Va WITH_CLANG_IS_CC
 .\" from FreeBSD: head/tools/build/options/WITH_CLANG_IS_CC 235342 2012-05-12 16:12:36Z gjb
 Set to install the Clang C/C++ compiler as
< at >< at > -338,7 +344,7 < at >< at > and
 .Pa /usr/bin/cpp .
 .Pp
 It is a default setting on
-amd64/amd64, i386/i386 and pc98/i386.
+amd64/amd64, arm/arm, arm/armv6, i386/i386 and pc98/i386.
 .It Va WITHOUT_CPP
 .\" from FreeBSD: head/tools/build/options/WITHOUT_CPP 156932 2006-03-21 07:50:50Z ru
 Set to not build
< at >< at > -433,6 +439,13 < at >< at > This includes the device tree compiler (
 .Pp
 It is a default setting on
 amd64/amd64, i386/i386, ia64/ia64, pc98/i386 and sparc64/sparc64.
+.It Va WITH_FDT
+.\" from FreeBSD: head/tools/build/options/WITH_FDT 221730 2011-05-10 11:14:40Z ru
+Set to build Flattened Device Tree support as part of the base system.
+This includes the device tree compiler (dtc) and libfdt support library.
+.Pp
+It is a default setting on
+arm/arm, arm/armeb, arm/armv6, arm/armv6eb, mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, powerpc/powerpc and powerpc/powerpc64.
 .It Va WITHOUT_FLOPPY
 .\" from FreeBSD: head/tools/build/options/WITHOUT_FLOPPY 221540 2011-05-06 19:13:03Z ru
 Set to not build or install programs
< at >< at > -523,13 +536,6 < at >< at > Set to not build HTML docs.
 .It Va WITH_ICONV
 .\" from FreeBSD: head/tools/build/options/WITH_ICONV 219020 2011-02-25 00:10:26Z gabor
 Set to build iconv as part of libc.
-.It Va WITH_IDEA
-.\" from FreeBSD: head/tools/build/options/WITH_IDEA 156932 2006-03-21 07:50:50Z ru
-Set to build the IDEA encryption code.
-This code is patented in the USA and many European countries.
-It is
-.Em "YOUR RESPONSIBILITY"
-to determine if you can legally use IDEA.
 .It Va WITHOUT_INET
 .\" from FreeBSD: head/tools/build/options/WITHOUT_INET 221266 2011-04-30 17:58:28Z bz
 Set to not build programs and libraries related to IPv4 networking.
< at >< at > -595,8 +601,8 < at >< at > When set, it also enforces the following
 .\" from FreeBSD: head/tools/build/options/WITHOUT_IPX_SUPPORT 156932 2006-03-21 07:50:50Z ru
 Set to build some programs without IPX support.
 .It Va WITHOUT_JAIL
-.\" from FreeBSD: head/tools/build/options/WITHOUT_JAIL 183242 2008-09-21 22:02:26Z sam
-Set to not build tools for the support of jails; e.g.
+.\" from FreeBSD: head/tools/build/options/WITHOUT_JAIL 249966 2013-04-27 04:09:09Z eadler
+Set to not build tools for the support of jails; e.g.,
 .Xr jail 8 .
 .It Va WITHOUT_KDUMP
 .\" from FreeBSD: head/tools/build/options/WITHOUT_KDUMP 240690 2012-09-19 11:38:37Z zeising
< at >< at > -671,14 +677,14 < at >< at > Setting this variable will enable the LD
 .Xr dig 1
 and
 .Xr host 1 .
-When set, the following options are also in effect:
+-When set, the following options are also in effect:
 .Pp
 .Bl -inset -compact
 .It Va WITHOUT_BIND_UTILS
 .El
 .It Va WITHOUT_LEGACY_CONSOLE
-.\" from FreeBSD: head/tools/build/options/WITHOUT_LEGACY_CONSOLE 183242 2008-09-21 22:02:26Z sam
-Set to not build programs that support a legacy PC console; e.g.
+.\" from FreeBSD: head/tools/build/options/WITHOUT_LEGACY_CONSOLE 249966 2013-04-27 04:09:09Z eadler
+Set to not build programs that support a legacy PC console; e.g.,
 .Xr kbdcontrol 8
 and
 .Xr vidcontrol 8 .
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250901 - head/sys/ufs/ffs

Kirk McKusick — 2013-05-22T05:07:55

Author: mckusick
Date: Wed May 22 05:07:55 2013
New Revision: 250901
URL: http://svnweb.freebsd.org/changeset/base/250901

Log:
  Properly spell sentinel (missed in 250891)
  No functional changes.
  
  Spotted by:  Navdeep Parhar and Alexey Dokuchaev
  MFC after:   2 weeks

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.cWed May 22 02:15:07 2013(r250900)
+++ head/sys/ufs/ffs/ffs_softdep.cWed May 22 05:07:55 2013(r250901)
< at >< at > -711,7 +711,7 < at >< at > SOFTDEP_TYPE(SBDEP, sbdep, "Superblock w
 SOFTDEP_TYPE(JTRUNC, jtrunc, "Journal inode truncation");
 SOFTDEP_TYPE(JFSYNC, jfsync, "Journal fsync complete");
 
-static MALLOC_DEFINE(M_SENTINEL, "sentinal", "Worklist sentinal");
+static MALLOC_DEFINE(M_SENTINEL, "sentinel", "Worklist sentinel");
 
 static MALLOC_DEFINE(M_SAVEDINO, "savedino", "Saved inodes");
 static MALLOC_DEFINE(M_JBLOCKS, "jblocks", "Journal block locations");
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250883 - in head: include include/xlocale lib/libc/locale sys/sys tools/regression/lib/libc/locale

Andrey Chernov — 2013-05-22T03:43:35

Yes, non UTF-8 and its subsets locales are not encoded in ISO 10646
internally but have their own internal encoding. Returning EILSEQ will
broke them all at once, so I see no point to add new functions such way,
because GNU configure will sense them, and then they doesn't work.
Proper way is ether to not add them or use lib/libc/iconv for them
(adding a lot of missing locales into lib/libiconv_modules).

svn commit: r250900 - head/sys/dev/mps

Alexander Motin — 2013-05-22T02:15:08

Author: mav
Date: Wed May 22 02:15:07 2013
New Revision: 250900
URL: http://svnweb.freebsd.org/changeset/base/250900

Log:
  Fix NULL-dereference kernel panic in case of mps_attach() failure.
  
  MFC after:1 week

Modified:
  head/sys/dev/mps/mps_user.c

Modified: head/sys/dev/mps/mps_user.c
==============================================================================
--- head/sys/dev/mps/mps_user.cWed May 22 01:03:41 2013(r250899)
+++ head/sys/dev/mps/mps_user.cWed May 22 02:15:07 2013(r250900)
< at >< at > -208,8 +208,8 < at >< at > mps_detach_user(struct mps_softc *sc)
 {
 
 /* XXX: do a purge of pending requests? */
-destroy_dev(sc->mps_cdev);
-
+if (sc->mps_cdev != NULL)
+destroy_dev(sc->mps_cdev);
 }
 
 static int
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250899 - head/tools/tools/ath/athalq

Adrian Chadd — 2013-05-22T01:03:42

Author: adrian
Date: Wed May 22 01:03:41 2013
New Revision: 250899
URL: http://svnweb.freebsd.org/changeset/base/250899

Log:
  Implement beacon event debugging in athalq.

Modified:
  head/tools/tools/ath/athalq/main.c

Modified: head/tools/tools/ath/athalq/main.c
==============================================================================
--- head/tools/tools/ath/athalq/main.cWed May 22 00:58:03 2013(r250898)
+++ head/tools/tools/ath/athalq/main.cWed May 22 01:03:41 2013(r250899)
< at >< at > -75,6 +75,36 < at >< at > ath_alq_print_intr_status(struct if_ath_
     be32toh(is.intr_status));
 }
 
+static void
+ath_alq_print_beacon_miss(struct if_ath_alq_payload *a)
+{
+
+printf("[%u.%06u] [%llu] BMISS\n",
+    (unsigned int) be32toh(a->hdr.tstamp_sec),
+    (unsigned int) be32toh(a->hdr.tstamp_usec),
+    (unsigned long long) be64toh(a->hdr.threadid));
+}
+
+static void
+ath_alq_print_beacon_stuck(struct if_ath_alq_payload *a)
+{
+
+printf("[%u.%06u] [%llu] BSTUCK\n",
+    (unsigned int) be32toh(a->hdr.tstamp_sec),
+    (unsigned int) be32toh(a->hdr.tstamp_usec),
+    (unsigned long long) be64toh(a->hdr.threadid));
+}
+
+static void
+ath_alq_print_beacon_resume(struct if_ath_alq_payload *a)
+{
+
+printf("[%u.%06u] [%llu] BRESUME\n",
+    (unsigned int) be32toh(a->hdr.tstamp_sec),
+    (unsigned int) be32toh(a->hdr.tstamp_usec),
+    (unsigned long long) be64toh(a->hdr.threadid));
+}
+
 int
 main(int argc, const char *argv[])
 {
< at >< at > -147,6 +177,15 < at >< at > main(int argc, const char *argv[])
 case ATH_ALQ_INTR_STATUS:
 ath_alq_print_intr_status(a);
 break;
+case ATH_ALQ_MISSED_BEACON:
+ath_alq_print_beacon_miss(a);
+break;
+case ATH_ALQ_STUCK_BEACON:
+ath_alq_print_beacon_stuck(a);
+break;
+case ATH_ALQ_RESUME_BEACON:
+ath_alq_print_beacon_resume(a);
+break;
 default:
 if (be32toh(hdr.sc_hal_magic) == AR5210_MAGIC)
 ar5210_alq_payload(a);
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250897 - head/sys/ufs/ffs

Kirk McKusick — 2013-05-22T00:57:23

Author: mckusick
Date: Wed May 22 00:57:22 2013
New Revision: 250897
URL: http://svnweb.freebsd.org/changeset/base/250897

Log:
  Add missing buffer releases (brelse) after bread calls that return
  an error. One could argue that returning a buffer even when it is
  not valid is incorrect, but bread has always returned a buffer
  valid or not.
  
  Reviewed by: kib
  MFC after:   2 weeks

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:54:57 2013(r250896)
+++ head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:57:22 2013(r250897)
< at >< at > -9362,13 +9362,16 < at >< at > clear_unlinked_inodedep(inodedep)
 if (idp && (idp->id_state & UNLINKNEXT))
 pino = idp->id_ino;
 FREE_LOCK(&lk);
-if (pino == 0)
+if (pino == 0) {
 bp = getblk(ump->um_devvp, btodb(fs->fs_sblockloc),
     (int)fs->fs_sbsize, 0, 0, 0);
-else
+} else {
 error = bread(ump->um_devvp,
     fsbtodb(fs, ino_to_fsba(fs, pino)),
     (int)fs->fs_bsize, NOCRED, &bp);
+if (error)
+brelse(bp);
+}
 ACQUIRE_LOCK(&lk);
 if (error)
 break;
< at >< at > -13183,6 +13186,7 < at >< at > softdep_inode_append(ip, cred, wkhd)
 error = bread(ip->i_devvp, fsbtodb(fs, ino_to_fsba(fs, ip->i_number)),
     (int)fs->fs_bsize, cred, &bp);
 if (error) {
+bqrelse(bp);
 softdep_freework(wkhd);
 return;
 }
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250895 - head/sys/ufs/ffs

Kirk McKusick — 2013-05-22T00:48:24

Author: mckusick
Date: Wed May 22 00:48:24 2013
New Revision: 250895
URL: http://svnweb.freebsd.org/changeset/base/250895

Log:
  Add missing 28th element to softdep types name array.
  
  Found by:    Coverity Scan, CID 1007621
  Reviewed by: kib
  MFC after:   2 weeks

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:40:26 2013(r250894)
+++ head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:48:24 2013(r250895)
< at >< at > -711,6 +711,8 < at >< at > SOFTDEP_TYPE(SBDEP, sbdep, "Superblock w
 SOFTDEP_TYPE(JTRUNC, jtrunc, "Journal inode truncation");
 SOFTDEP_TYPE(JFSYNC, jfsync, "Journal fsync complete");
 
+static MALLOC_DEFINE(M_SENTINEL, "sentinal", "Worklist sentinal");
+
 static MALLOC_DEFINE(M_SAVEDINO, "savedino", "Saved inodes");
 static MALLOC_DEFINE(M_JBLOCKS, "jblocks", "Journal block locations");
 
< at >< at > -745,7 +747,8 < at >< at > static struct malloc_type *memtype[] = {
 M_JSEGDEP,
 M_SBDEP,
 M_JTRUNC,
-M_JFSYNC
+M_JFSYNC,
+M_SENTINEL
 };
 
 static LIST_HEAD(mkdirlist, mkdir) mkdirlisthd;
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250894 - head/sys/ufs/ffs

Kirk McKusick — 2013-05-22T00:40:27

Author: mckusick
Date: Wed May 22 00:40:26 2013
New Revision: 250894
URL: http://svnweb.freebsd.org/changeset/base/250894

Log:
  Null a pointer after it is freed so that when it is returned
  the return value is NULL. Based on the returned flags, the
  return value should never be inspected in the case where NULL
  is returned, but it is good coding practice not to return a
  pointer to freed memory.
  
  Found by:    Coverity Scan, CID 1006096
  Reviewed by: kib
  MFC after:   2 weeks

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:31:33 2013(r250893)
+++ head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:40:26 2013(r250894)
< at >< at > -8150,6 +8150,7 < at >< at > setup_newdir(dap, newinum, dinum, newdir
     (inodedep->id_state & ALLCOMPLETE) == ALLCOMPLETE) {
 dap->da_state &= ~MKDIR_PARENT;
 WORKITEM_FREE(mkdir2, D_MKDIR);
+mkdir2 = NULL;
 } else {
 LIST_INSERT_HEAD(&mkdirlisthd, mkdir2, md_mkdirs);
 WORKLIST_INSERT(&inodedep->id_bufwait, &mkdir2->md_list);
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250893 - stable/9/sys/ofed/include/linux

Xin LI — 2013-05-22T00:31:33

Author: delphij
Date: Wed May 22 00:31:33 2013
New Revision: 250893
URL: http://svnweb.freebsd.org/changeset/base/250893

Log:
  MFC r250374:
  
  According to the documentation, on Linux, cancel_delayed_work() does not
  do drain (flush_workqueue() in Linux terms) but instead returns true if
  the work was removed before it is run, or false otherwise.
  
  Simulate this by removing the taskqueue_drain() and return the value
  derived from taskqueue_cancel()'s return value.
  
  This would solve a witness warning caused by calling taskqueue_drain()
  with a non-sleepable lock held, like:
  
  taskqueue_drain with the following non-sleepable locks held:
  exclusive rw lle (lle) r = 0 (0xfffffe001450b410) locked < at >
  /usr/src/sys/netinet/in.c:1484
  KDB: stack backtrace:
  db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffff848d4f7690
  kdb_backtrace() at kdb_backtrace+0x39/frame 0xffffff848d4f7740
  witness_warn() at witness_warn+0x4a8/frame 0xffffff848d4f7800
  taskqueue_drain() at taskqueue_drain+0x3a/frame 0xffffff848d4f7840
  set_timeout() at set_timeout+0x4a/frame 0xffffff848d4f7860
  netevent_callback() at netevent_callback+0x16/frame 0xffffff848d4f7870
  arpintr() at arpintr+0x9b5/frame 0xffffff848d4f7930
  
  This do not affect kernel without OFED compiled in.
  
  Reported by:Garrett Cooper <yaneurabeya gmail com>

Modified:
  stable/9/sys/ofed/include/linux/workqueue.h
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/ofed/include/linux/workqueue.h
==============================================================================
--- stable/9/sys/ofed/include/linux/workqueue.hWed May 22 00:30:34 2013(r250892)
+++ stable/9/sys/ofed/include/linux/workqueue.hWed May 22 00:31:33 2013(r250893)
< at >< at > -184,9 +184,9 < at >< at > cancel_delayed_work(struct delayed_work 
 {
 
 callout_stop(&work->timer);
-if (work->work.taskqueue &&
-    taskqueue_cancel(work->work.taskqueue, &work->work.work_task, NULL))
-taskqueue_drain(work->work.taskqueue, &work->work.work_task);
+if (work->work.taskqueue)
+return (taskqueue_cancel(work->work.taskqueue,
+    &work->work.work_task, NULL) == 0);
 return 0;
 }
 
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250892 - head/sys/ufs/ffs

Kirk McKusick — 2013-05-22T00:30:34

Author: mckusick
Date: Wed May 22 00:30:34 2013
New Revision: 250892
URL: http://svnweb.freebsd.org/changeset/base/250892

Log:
  Remove a bogus check for a NULL buffer pointer.
  Add a KASSERT that it is not NULL.
  
  Found by:    Coverity Scan, CID 1009114
  Reviewed by: kib
  MFC after:   2 weeks

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:17:50 2013(r250891)
+++ head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:30:34 2013(r250892)
< at >< at > -4984,13 +4984,14 < at >< at > bmsafemap_lookup(mp, bp, cg, newbmsafema
 struct fs *fs;
 
 mtx_assert(&lk, MA_OWNED);
-if (bp)
-LIST_FOREACH(wk, &bp->b_dep, wk_list)
-if (wk->wk_type == D_BMSAFEMAP) {
-if (newbmsafemap)
-WORKITEM_FREE(newbmsafemap,D_BMSAFEMAP);
-return (WK_BMSAFEMAP(wk));
-}
+KASSERT(bp != NULL, ("bmsafemap_lookup: missing buffer"));
+LIST_FOREACH(wk, &bp->b_dep, wk_list) {
+if (wk->wk_type == D_BMSAFEMAP) {
+if (newbmsafemap)
+WORKITEM_FREE(newbmsafemap, D_BMSAFEMAP);
+return (WK_BMSAFEMAP(wk));
+}
+}
 fs = VFSTOUFS(mp)->um_fs;
 bmsafemaphd = BMSAFEMAP_HASH(fs, cg);
 if (bmsafemap_find(bmsafemaphd, mp, cg, &bmsafemap) == 1) {
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250891 - head/sys/ufs/ffs

Kirk McKusick — 2013-05-22T00:17:50

Author: mckusick
Date: Wed May 22 00:17:50 2013
New Revision: 250891
URL: http://svnweb.freebsd.org/changeset/base/250891

Log:
  Properly spell sentinel (not sintenel or sentinal).
  No functional changes.
  
  Spotted by:  kib
  MFC after:   2 weeks

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.cTue May 21 21:58:00 2013(r250890)
+++ head/sys/ufs/ffs/ffs_softdep.cWed May 22 00:17:50 2013(r250891)
< at >< at > -656,8 +656,8 < at >< at > FEATURE(softupdates, "FFS soft-updates s
 #defineD_SBDEP24
 #defineD_JTRUNC25
 #defineD_JFSYNC26
-#defineD_SENTINAL27
-#defineD_LASTD_SENTINAL
+#defineD_SENTINEL27
+#defineD_LASTD_SENTINEL
 
 unsigned long dep_current[D_LAST + 1];
 unsigned long dep_total[D_LAST + 1];
< at >< at > -1718,7 +1718,7 < at >< at > process_worklist_item(mp, target, flags)
 int target;
 int flags;
 {
-struct worklist sintenel;
+struct worklist sentinel;
 struct worklist *wk;
 struct ufsmount *ump;
 int matchcnt;
< at >< at > -1736,14 +1736,14 < at >< at > process_worklist_item(mp, target, flags)
 PHOLD(curproc);/* Don't let the stack go away. */
 ump = VFSTOUFS(mp);
 matchcnt = 0;
-sintenel.wk_mp = NULL;
-sintenel.wk_type = D_SENTINAL;
-LIST_INSERT_HEAD(&ump->softdep_workitem_pending, &sintenel, wk_list);
-for (wk = LIST_NEXT(&sintenel, wk_list); wk != NULL;
-    wk = LIST_NEXT(&sintenel, wk_list)) {
-if (wk->wk_type == D_SENTINAL) {
-LIST_REMOVE(&sintenel, wk_list);
-LIST_INSERT_AFTER(wk, &sintenel, wk_list);
+sentinel.wk_mp = NULL;
+sentinel.wk_type = D_SENTINEL;
+LIST_INSERT_HEAD(&ump->softdep_workitem_pending, &sentinel, wk_list);
+for (wk = LIST_NEXT(&sentinel, wk_list); wk != NULL;
+    wk = LIST_NEXT(&sentinel, wk_list)) {
+if (wk->wk_type == D_SENTINEL) {
+LIST_REMOVE(&sentinel, wk_list);
+LIST_INSERT_AFTER(wk, &sentinel, wk_list);
 continue;
 }
 if (wk->wk_state & INPROGRESS)
< at >< at > -1800,11 +1800,11 < at >< at > process_worklist_item(mp, target, flags)
 wake_worklist(wk);
 add_to_worklist(wk, WK_HEAD);
 }
-LIST_REMOVE(&sintenel, wk_list);
+LIST_REMOVE(&sentinel, wk_list);
 /* Sentinal could've become the tail from remove_from_worklist. */
-if (ump->softdep_worklist_tail == &sintenel)
+if (ump->softdep_worklist_tail == &sentinel)
 ump->softdep_worklist_tail =
-    (struct worklist *)sintenel.wk_list.le_prev;
+    (struct worklist *)sentinel.wk_list.le_prev;
 PRELE(curproc);
 return (matchcnt);
 }
< at >< at > -12127,7 +12127,7 < at >< at > restart:
 
 /*
  * Sync all cylinder groups that were dirty at the time this function is
- * called.  Newly dirtied cgs will be inserted before the sintenel.  This
+ * called.  Newly dirtied cgs will be inserted before the sentinel.  This
  * is used to flush freedep activity that may be holding up writes to a
  * indirect block.
  */
< at >< at > -12137,25 +12137,25 < at >< at > sync_cgs(mp, waitfor)
 int waitfor;
 {
 struct bmsafemap *bmsafemap;
-struct bmsafemap *sintenel;
+struct bmsafemap *sentinel;
 struct ufsmount *ump;
 struct buf *bp;
 int error;
 
-sintenel = malloc(sizeof(*sintenel), M_BMSAFEMAP, M_ZERO | M_WAITOK);
-sintenel->sm_cg = -1;
+sentinel = malloc(sizeof(*sentinel), M_BMSAFEMAP, M_ZERO | M_WAITOK);
+sentinel->sm_cg = -1;
 ump = VFSTOUFS(mp);
 error = 0;
 ACQUIRE_LOCK(&lk);
-LIST_INSERT_HEAD(&ump->softdep_dirtycg, sintenel, sm_next);
-for (bmsafemap = LIST_NEXT(sintenel, sm_next); bmsafemap != NULL;
-    bmsafemap = LIST_NEXT(sintenel, sm_next)) {
-/* Skip sintenels and cgs with no work to release. */
+LIST_INSERT_HEAD(&ump->softdep_dirtycg, sentinel, sm_next);
+for (bmsafemap = LIST_NEXT(sentinel, sm_next); bmsafemap != NULL;
+    bmsafemap = LIST_NEXT(sentinel, sm_next)) {
+/* Skip sentinels and cgs with no work to release. */
 if (bmsafemap->sm_cg == -1 ||
     (LIST_EMPTY(&bmsafemap->sm_freehd) &&
     LIST_EMPTY(&bmsafemap->sm_freewr))) {
-LIST_REMOVE(sintenel, sm_next);
-LIST_INSERT_AFTER(bmsafemap, sintenel, sm_next);
+LIST_REMOVE(sentinel, sm_next);
+LIST_INSERT_AFTER(bmsafemap, sentinel, sm_next);
 continue;
 }
 /*
< at >< at > -12165,8 +12165,8 < at >< at > sync_cgs(mp, waitfor)
 bp = getdirtybuf(bmsafemap->sm_buf, &lk, waitfor);
 if (bp == NULL && waitfor == MNT_WAIT)
 continue;
-LIST_REMOVE(sintenel, sm_next);
-LIST_INSERT_AFTER(bmsafemap, sintenel, sm_next);
+LIST_REMOVE(sentinel, sm_next);
+LIST_INSERT_AFTER(bmsafemap, sentinel, sm_next);
 if (bp == NULL)
 continue;
 FREE_LOCK(&lk);
< at >< at > -12178,9 +12178,9 < at >< at > sync_cgs(mp, waitfor)
 if (error)
 break;
 }
-LIST_REMOVE(sintenel, sm_next);
+LIST_REMOVE(sentinel, sm_next);
 FREE_LOCK(&lk);
-free(sintenel, M_BMSAFEMAP);
+free(sentinel, M_BMSAFEMAP);
 return (error);
 }
 
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250883 - in head: include include/xlocale lib/libc/locale sys/sys tools/regression/lib/libc/locale

Ed Schouten — 2013-05-21T22:20:15

2013/5/22 Jilles Tjoelker <jilles< at >stack.nl>:

Oh, the horror! I thought on FreeBSD, we used the LC_CTYPE files to do
a mapping to ISO 10646. Unfortunately, it seems to be the case that
these files are only used to do mappings to
uppercase/lowercase/runetype. Bummer.

I'll see what I can do to fix this. I'll likely implement something
like you suggested, that we return EILSEQ if the locale is not ASCII,
ISO8859-1 or UTF-8.

--
Ed Schouten <ed< at >80386.nl>
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250883 - in head: include include/xlocale lib/libc/locale sys/sys tools/regression/lib/libc/locale

Jilles Tjoelker — 2013-05-21T22:00:03


Looks like an interesting approach to make applications LC_CTYPE locale
aware.


Our wchar_t is only ISO 10646 for UTF-8 and possibly US-ASCII and
ISO8859-1 (subset) locales. However, we support various other charsets
such as ISO8859-2 and even some non-Unicode multibyte encodings
(although I have no idea how complete the support for the latter is).
Using the new functions with such locales is likely to produce garbage.
Some sort of iconv is necessary to avoid this mojibake and we do not
have it in base.

I encountered the same issue when implementing $'\uXXXX' and
$'\UXXXXXXXX' for /bin/sh. I decided to implement full support only for
UTF-8 locales and restrict the rest to US-ASCII, converting all other
(valid) characters to question marks. I did not see a reason to treat
Western Europe preferentially by adding a simple ISO8859-1 mapping.

For these functions, it is probably best to fail (such as with [EILSEQ])
when a character is encountered for which the conversion is not
implemented.


This makes sense.


You can probably avoid the potential buffer overflow by copying the
trailing 126 bytes of the _Char16State into a new mbstate_t object, and
back after calling c32rtomb_l(). Likewise for mbrtoc16_l(). (The
committed code allows using 120 bytes which should still be more than
enough.)

There may also be a strict-aliasing violation if ps == NULL, as the
mbstate_t objects in __xlocale_C_locale and __xlocale_global_locale have
a declared type. If ps != NULL, it is OK as long as the object is a
separate compilation unit.

svn commit: r250890 - head/sys/kern

Mateusz Guzik — 2013-05-21T21:58:01

Author: mjg
Date: Tue May 21 21:58:00 2013
New Revision: 250890
URL: http://svnweb.freebsd.org/changeset/base/250890

Log:
  passing fd over unix socket: fix a corner case where caller
  wants to pass no descriptors.
  
  Previously the kernel would leak memory and try to free a potentially
  arbitrary pointer.
  
  Reviewed by:pjd

Modified:
  head/sys/kern/uipc_usrreq.c

Modified: head/sys/kern/uipc_usrreq.c
==============================================================================
--- head/sys/kern/uipc_usrreq.cTue May 21 21:50:11 2013(r250889)
+++ head/sys/kern/uipc_usrreq.cTue May 21 21:58:00 2013(r250890)
< at >< at > -1686,6 +1686,8 < at >< at > unp_freerights(struct filedescent **fdep
 struct file *fp;
 int i;
 
+if (fdcount == 0)
+return;
 for (i = 0; i < fdcount; i++) {
 fp = fdep[i]->fde_file;
 filecaps_free(&fdep[i]->fde_caps);
< at >< at > -1768,7 +1770,8 < at >< at > unp_externalize(struct mbuf *control, st
 unp_externalize_fp(fde->fde_file);
 }
 FILEDESC_XUNLOCK(fdesc);
-free(fdep[0], M_FILECAPS);
+if (newfds != 0)
+free(fdep[0], M_FILECAPS);
 } else {
 /* We can just copy anything else across. */
 if (error || controlp == NULL)
< at >< at > -1925,6 +1928,10 < at >< at > unp_internalize(struct mbuf **controlp, 
 error = E2BIG;
 goto out;
 }
+if (oldfds == 0) {
+FILEDESC_SUNLOCK(fdesc);
+break;
+}
 fdp = data;
 fdep = (struct filedescent **)
     CMSG_DATA(mtod(*controlp, struct cmsghdr *));
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250889 - in head: include/protocols sys/sys

Ed Schouten — 2013-05-21T21:50:12

Author: ed
Date: Tue May 21 21:50:11 2013
New Revision: 250889
URL: http://svnweb.freebsd.org/changeset/base/250889

Log:
  Add proper prerequisites for even two more headers.
  
  Spotted by:   http://hacks.owlfolio.org/header-survey/

Modified:
  head/include/protocols/rwhod.h
  head/sys/sys/timex.h

Modified: head/include/protocols/rwhod.h
==============================================================================
--- head/include/protocols/rwhod.hTue May 21 21:39:18 2013(r250888)
+++ head/include/protocols/rwhod.hTue May 21 21:50:11 2013(r250889)
< at >< at > -34,13 +34,15 < at >< at >
 #ifndef _PROTOCOLS_RWHOD_H_
 #define_PROTOCOLS_RWHOD_H_
 
+#include <sys/_types.h>
+
 /*
  * rwho protocol packet format.
  */
 structoutmp {
 charout_line[8];/* tty name */
 charout_name[8];/* user id */
-int32_tout_time;/* time on */
+__int32_t out_time;/* time on */
 };
 
 structwhod {

Modified: head/sys/sys/timex.h
==============================================================================
--- head/sys/sys/timex.hTue May 21 21:39:18 2013(r250888)
+++ head/sys/sys/timex.hTue May 21 21:50:11 2013(r250889)
< at >< at > -97,6 +97,9 < at >< at >
 #define _SYS_TIMEX_H_ 1
 #define NTP_API4/* NTP API version */
 
+#ifdef __FreeBSD__
+#include <sys/_timespec.h>
+#endif /* __FreeBSD__ */
 #ifndef MSDOS/* Microsoft specific */
 #include <sys/syscall.h>
 #endif /* MSDOS */
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250887 - in head: include include/arpa sys/net

Ed Schouten — 2013-05-21T21:39:48

2013/5/21 Eitan Adler <eadler< at >freebsd.org>:

Sure. I've updated the manpages for the functions listed in these header files.

--
Ed Schouten <ed< at >80386.nl>
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250888 - in head/lib/libc: gen net

Ed Schouten — 2013-05-21T21:39:19

Author: ed
Date: Tue May 21 21:39:18 2013
New Revision: 250888
URL: http://svnweb.freebsd.org/changeset/base/250888

Log:
  Update manpages for r250887.
  
  Remove the lists of unneeded header files.
  
  Requested by:eadler

Modified:
  head/lib/libc/gen/fts.3
  head/lib/libc/net/getifaddrs.3
  head/lib/libc/net/getifmaddrs.3

Modified: head/lib/libc/gen/fts.3
==============================================================================
--- head/lib/libc/gen/fts.3Tue May 21 21:20:10 2013(r250887)
+++ head/lib/libc/gen/fts.3Tue May 21 21:39:18 2013(r250888)
< at >< at > -28,7 +28,7 < at >< at >
 .\"     < at >(#)fts.38.5 (Berkeley) 4/16/94
 .\" $FreeBSD$
 .\"
-.Dd March 18, 2012
+.Dd May 21, 2013
 .Dt FTS 3
 .Os
 .Sh NAME
< at >< at > -37,8 +37,6 < at >< at >
 .Sh LIBRARY
 .Lb libc
 .Sh SYNOPSIS
-.In sys/types.h
-.In sys/stat.h
 .In fts.h
 .Ft FTS *
 .Fn fts_open "char * const *path_argv" "int options" "int (*compar)(const FTSENT * const *, const FTSENT * const *)"

Modified: head/lib/libc/net/getifaddrs.3
==============================================================================
--- head/lib/libc/net/getifaddrs.3Tue May 21 21:20:10 2013(r250887)
+++ head/lib/libc/net/getifaddrs.3Tue May 21 21:39:18 2013(r250888)
< at >< at > -24,15 +24,13 < at >< at >
 .\"
 .\" $FreeBSD$
 .\"
-.Dd October 12, 1995
+.Dd May 21, 2013
 .Dt GETIFADDRS 3
 .Os
 .Sh NAME
 .Nm getifaddrs
 .Nd get interface addresses
 .Sh SYNOPSIS
-.In sys/types.h
-.In sys/socket.h
 .In ifaddrs.h
 .Ft int
 .Fn getifaddrs "struct ifaddrs **ifap"

Modified: head/lib/libc/net/getifmaddrs.3
==============================================================================
--- head/lib/libc/net/getifmaddrs.3Tue May 21 21:20:10 2013(r250887)
+++ head/lib/libc/net/getifmaddrs.3Tue May 21 21:39:18 2013(r250888)
< at >< at > -20,15 +20,13 < at >< at >
 .\"
 .\" $FreeBSD$
 .\"
-.Dd November 14, 2003
+.Dd May 21, 2013
 .Dt GETIFMADDRS 3
 .Os
 .Sh NAME
 .Nm getifmaddrs
 .Nd get multicast group memberships
 .Sh SYNOPSIS
-.In sys/types.h
-.In sys/socket.h
 .In ifaddrs.h
 .Ft int
 .Fn getifmaddrs "struct ifmaddrs **ifmap"
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250887 - in head: include include/arpa sys/net

Eitan Adler — 2013-05-21T21:31:23

Thank you.

Do the man pages need to be updated as well?

svn commit: r250887 - in head: include include/arpa sys/net

Ed Schouten — 2013-05-21T21:20:10

Author: ed
Date: Tue May 21 21:20:10 2013
New Revision: 250887
URL: http://svnweb.freebsd.org/changeset/base/250887

Log:
  Allow certain headers to be included more easily.
  
  Spotted by:http://hacks.owlfolio.org/header-survey/

Modified:
  head/include/arpa/tftp.h
  head/include/fts.h
  head/include/ifaddrs.h
  head/sys/net/ppp_defs.h

Modified: head/include/arpa/tftp.h
==============================================================================
--- head/include/arpa/tftp.hTue May 21 20:56:27 2013(r250886)
+++ head/include/arpa/tftp.hTue May 21 21:20:10 2013(r250887)
< at >< at > -33,6 +33,8 < at >< at >
 #ifndef _ARPA_TFTP_H_
 #define_ARPA_TFTP_H_
 
+#include <sys/cdefs.h>
+
 /*
  * Trivial File Transfer Protocol (IEN-133)
  */

Modified: head/include/fts.h
==============================================================================
--- head/include/fts.hTue May 21 20:56:27 2013(r250886)
+++ head/include/fts.hTue May 21 21:20:10 2013(r250887)
< at >< at > -33,15 +33,17 < at >< at >
 #ifndef_FTS_H_
 #define_FTS_H_
 
+#include <sys/_types.h>
+
 typedef struct {
 struct _ftsent *fts_cur;/* current node */
 struct _ftsent *fts_child;/* linked list of children */
 struct _ftsent **fts_array;/* sort array */
-dev_t fts_dev;/* starting device # */
+__dev_t fts_dev;/* starting device # */
 char *fts_path;/* path for this descent */
 int fts_rfd;/* fd for root */
-size_t fts_pathlen;/* sizeof(path) */
-size_t fts_nitems;/* elements in the sort array */
+__size_t fts_pathlen;/* sizeof(path) */
+__size_t fts_nitems;/* elements in the sort array */
 int (*fts_compar)/* compare function */
     (const struct _ftsent * const *, const struct _ftsent * const *);
 
< at >< at > -72,12 +74,12 < at >< at > typedef struct _ftsent {
 char *fts_path;/* root path */
 int fts_errno;/* errno for this node */
 int fts_symfd;/* fd for symlink */
-size_t fts_pathlen;/* strlen(fts_path) */
-size_t fts_namelen;/* strlen(fts_name) */
+__size_t fts_pathlen;/* strlen(fts_path) */
+__size_t fts_namelen;/* strlen(fts_name) */
 
-ino_t fts_ino;/* inode */
-dev_t fts_dev;/* device */
-nlink_t fts_nlink;/* link count */
+__ino_t fts_ino;/* inode */
+__dev_t fts_dev;/* device */
+__nlink_t fts_nlink;/* link count */
 
 #defineFTS_ROOTPARENTLEVEL-1
 #defineFTS_ROOTLEVEL 0

Modified: head/include/ifaddrs.h
==============================================================================
--- head/include/ifaddrs.hTue May 21 20:56:27 2013(r250886)
+++ head/include/ifaddrs.hTue May 21 21:20:10 2013(r250887)
< at >< at > -31,7 +31,7 < at >< at >
 struct ifaddrs {
 struct ifaddrs  *ifa_next;
 char*ifa_name;
-u_int ifa_flags;
+unsigned int ifa_flags;
 struct sockaddr*ifa_addr;
 struct sockaddr*ifa_netmask;
 struct sockaddr*ifa_dstaddr;

Modified: head/sys/net/ppp_defs.h
==============================================================================
--- head/sys/net/ppp_defs.hTue May 21 20:56:27 2013(r250886)
+++ head/sys/net/ppp_defs.hTue May 21 21:20:10 2013(r250887)
< at >< at > -31,6 +31,8 < at >< at >
 #ifndef _PPP_DEFS_H_
 #define _PPP_DEFS_H_
 
+#include <sys/_types.h>
+
 /*
  * The basic PPP frame.
  */
< at >< at > -83,7 +85,7 < at >< at >
 /*
  * Extended asyncmap - allows any character to be escaped.
  */
-typedef u_int32_text_accm[8];
+typedef __uint32_text_accm[8];
 
 /*
  * What to do with network protocol (NP) packets.
< at >< at > -143,8 +145,8 < at >< at > struct ppp_comp_stats {
  * the last NP packet was sent or received.
  */
 struct ppp_idle {
-    time_t xmit_idle;/* time since last NP packet sent */
-    time_t recv_idle;/* time since last NP packet received */
+    __time_t xmit_idle;/* time since last NP packet sent */
+    __time_t recv_idle;/* time since last NP packet received */
 };
 
 #ifndef __P
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250885 - head/sys/kern

Attilio Rao — 2013-05-21T20:54:03

Author: attilio
Date: Tue May 21 20:54:03 2013
New Revision: 250885
URL: http://svnweb.freebsd.org/changeset/base/250885

Log:
  vm_object locking is not needed there as pages are already wired.
  
  Sponsored by:EMC / Isilon storage division
  Submitted by:alc

Modified:
  head/sys/kern/vfs_bio.c

Modified: head/sys/kern/vfs_bio.c
==============================================================================
--- head/sys/kern/vfs_bio.cTue May 21 20:38:19 2013(r250884)
+++ head/sys/kern/vfs_bio.cTue May 21 20:54:03 2013(r250885)
< at >< at > -4211,7 +4211,6 < at >< at > vfs_bio_bzero_buf(struct buf *bp, int ba
 } else {
 BUF_CHECK_UNMAPPED(bp);
 n = PAGE_SIZE - (base & PAGE_MASK);
-VM_OBJECT_WLOCK(bp->b_bufobj->bo_object);
 for (i = base / PAGE_SIZE; size > 0 && i < bp->b_npages; ++i) {
 m = bp->b_pages[i];
 if (n > size)
< at >< at > -4221,7 +4220,6 < at >< at > vfs_bio_bzero_buf(struct buf *bp, int ba
 size -= n;
 n = PAGE_SIZE;
 }
-VM_OBJECT_WUNLOCK(bp->b_bufobj->bo_object);
 }
 }
 
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"