gmane.org.wikimedia.mediawiki.codereview

[MediaWiki r102566]: New comment added

MediaWiki Mail — 2012-05-25T14:05:31

"Mormegil" posted a comment on MediaWiki.r102566.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102566#c32826

Commit summary for MediaWiki.r102566:

Adding bt-button and rt-button to interface messages.

Mormegil's comment:

The more interesting thing is that the “donate_interface-rt-button” message is unterminated – it has mismatched quotation characters, beginning with a double quote, ending with a single quote. But then, “donate_interface-donor-legend” has the opposite problem, meaning to wrongs make a right, and everything is quite fine. :-)

(The message documentation has already been fixed using TranslateWiki.net.)

_______________________________________________
MediaWiki-CodeReview mailing list
MediaWiki-CodeReview< at >lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T14:05:27

"Petrb" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32825

Commit summary for MediaWiki.r115429:

style of code

Petrb's comment:

ah, I see, from guideline this isn't clear, the example there has lines so short that it actually seems to be aligned just as I did.

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T11:57:37

"Krinkle" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32824

Commit summary for MediaWiki.r115429:

style of code

Krinkle's comment:

[[CC|.. and the closing bracket should align]] with the opening statement.

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T11:56:21

"Krinkle" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32823

Commit summary for MediaWiki.r115429:

style of code

Krinkle's comment:

Nearly every line, actually.

I think the problem is that it appears you start counting the extra tab from roughly where the contents of the previous line ends (rather than where the indention of the previous line ends).

<pre>
+$foo = $bar->getOption(
+→→→→'Test',
+→→→→$example
+→→);
+$foo = $bar->baz->quux->getOption(
+→→→→→'Test',
+→→→→→$example
+→→);
</pre>

vs.
<pre>
+$foo = $bar->getOption(
+→'Test',
+→$example
+);
+$foo = $bar->baz->quux->getOption(
+→'Test',
+→$example
+);
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
MediaWiki-CodeReview< at >lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki r115429]: New comment added

MediaWiki Mail — 2012-05-25T09:06:03

"Petrb" posted a comment on MediaWiki.r115429.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32822

Commit summary for MediaWiki.r115429:

style of code

Petrb's comment:

line?

[MediaWiki r115429]: New comment added,and revision status changed

MediaWiki Mail — 2012-05-25T07:45:36

"Nikerabbit" changed the status of MediaWiki.r115429 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115429#c32821

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r115429:

style of code

Nikerabbit's comment:

I think style guideline says to use one tab for one level of indentation, not six.

[MediaWiki r105406]: Revision status changed

MediaWiki Mail — 2012-05-25T01:07:27

"Krinkle" changed the status of MediaWiki.r105406 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105406

Old status:  deferred
New status: ok

Commit summary for MediaWiki.r105406:

fix for onlinestatusbar ajax loader:
* since we're building HTML text, use mw.html.element() to build source instead of $('<img>') to build a DOM element
* break a couple things up into multiple lines to make them easier to read/maintain
* use wgExtensionAssetsPath rather than wgScriptPath to ensure this'll work on configs like Wikimedia's where the assets are loaded from another domain

[Wikimedia r1763]: Revision status changed

MediaWiki Mail — 2012-05-24T21:48:24

"Khorn (WMF)" changed the status of Wikimedia.r1763 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1763

Old status:  new
New status: ok

Commit summary for Wikimedia.r1763:

Updated parser to handle new log format. Added $customFilterScores handling.

[Wikimedia r1764]: Revision status changed

MediaWiki Mail — 2012-05-24T21:48:08

"Khorn (WMF)" changed the status of Wikimedia.r1764 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1764

Old status:  new
New status: ok

Commit summary for Wikimedia.r1764:

Updated error handling. See r1763.

[Wikimedia r1765]: New comment added

MediaWiki Mail — 2012-05-24T21:46:28

"Khorn (WMF)" posted a comment on Wikimedia.r1765.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1765#c32820

Commit summary for Wikimedia.r1765:

Adding a sed fix for trailing whitespaces. Added ignore flow handling. See r1764.

Khorn (WMF)'s comment:

This will work until we remove sed completely.

[Wikimedia r1765]: Revision status changed

MediaWiki Mail — 2012-05-24T21:46:33

"Khorn (WMF)" changed the status of Wikimedia.r1765 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1765

Old status:  new
New status: ok

Commit summary for Wikimedia.r1765:

Adding a sed fix for trailing whitespaces. Added ignore flow handling. See r1764.

[Wikimedia r1766]: Revision status changed

MediaWiki Mail — 2012-05-24T21:33:54

"Khorn (WMF)" changed the status of Wikimedia.r1766 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1766

Old status:  new
New status: ok

Commit summary for Wikimedia.r1766:

Adding utm fields to csv. See r1765.

[Wikimedia r1769]: Revision status changed

MediaWiki Mail — 2012-05-24T21:32:55

"Khorn (WMF)" changed the status of Wikimedia.r1769 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1769

Old status:  new
New status: ok

Commit summary for Wikimedia.r1769:

Adding utm handling. Fixed order of fields. See r1766.

[Wikimedia r1766]: New comment added,and revision status changed

MediaWiki Mail — 2012-05-24T21:04:07

"Jpostlethwaite" changed the status of Wikimedia.r1766 to "new" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1766#c32819

Old Status: fixme
New Status: new

Commit summary for Wikimedia.r1766:

Adding utm fields to csv. See r1765.

Jpostlethwaite's comment:

The script is fixed in r1769 and in the Gerrit patch for DonationInterface:

https://gerrit.wikimedia.org/r/#/c/8867/

[Wikimedia r1766]: Revision status changed

MediaWiki Mail — 2012-05-24T20:33:04

"Jpostlethwaite" changed the status of Wikimedia.r1766 to "fixme"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1766

Old status:  new
New status: fixme

Commit summary for Wikimedia.r1766:

Adding utm fields to csv. See r1765.

[Wikimedia r1766]: New comment added

MediaWiki Mail — 2012-05-24T20:32:59

"Jpostlethwaite" posted a comment on Wikimedia.r1766.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1766#c32818

Commit summary for Wikimedia.r1766:

Adding utm fields to csv. See r1765.

Jpostlethwaite's comment:

This is not complete.

The fields are not yet populated.

This may require modifying DonationInterface.

[MediaWiki r115425]: Revision status changed

MediaWiki Mail — 2012-05-24T13:28:52

"Hashar" changed the status of MediaWiki.r115425 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115425

Old status:  new
New status: ok

Commit summary for MediaWiki.r115425:

Migrated to git: operations/debs/pybal

[Wikimedia r1762]: New comment added

MediaWiki Mail — 2012-05-23T20:14:28

"Khorn (WMF)" posted a comment on Wikimedia.r1762.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1762#c32817

Commit summary for Wikimedia.r1762:

Setting a dynamically generated variable to prevent notices. See r1761.

Khorn (WMF)'s comment:

Where is this used?

[Wikimedia r1764]: New comment added

MediaWiki Mail — 2012-05-23T18:40:25

"Jpostlethwaite" posted a comment on Wikimedia.r1764.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1764#c32816

Commit summary for Wikimedia.r1764:

Updated error handling. See r1763.

Jpostlethwaite's comment:

This is not really error handling.

I changed the variables to pull the default value from the assigned value at instantiation.

[Wikimedia r1763]: New comment added

MediaWiki Mail — 2012-05-23T18:29:54

"Jpostlethwaite" posted a comment on Wikimedia.r1763.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1763#c32815

Commit summary for Wikimedia.r1763:

Updated parser to handle new log format. Added $customFilterScores handling.

Jpostlethwaite's comment:

I am going to update how the default variables are set on this.

[MediaWiki r115377]: New comment added

MediaWiki Mail — 2012-05-23T15:46:38

"Aaron Schulz" posted a comment on MediaWiki.r115377.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/115377#c32814

Commit summary for MediaWiki.r115377:

dir_exists isn't a php function!!

Aaron Schulz's comment:

Should have replaced it with is_dir() :)