gmane.network.wireshark.bugs

[Bug 8387] ZigBee ZCL OnOff cluster not recognized.

2013-05-25T12:26:20

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387

--- Comment #13 from Evan Huus <eapache< at >gmail.com> ---
Fixed in r49575.

[Bug 8715] New: CRASH when close Statistics => Summary windows after close capture

2013-05-25T09:49:13

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8715

            Bug ID: 8715
           Summary: CRASH when close Statistics => Summary windows after
                    close capture
    Classification: Unclassified
           Product: Wireshark
           Version: 1.8.7
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: Major
          Priority: Low
         Component: Wireshark
          Assignee: bugzilla-admin< at >wireshark.org
          Reporter: alexis.lagoutte< at >gmail.com

Build Information:

--
Hi,

Working on (technical) proposals from GSOC students (for Qtshark projet), i
found a (stupid) crash.

To reproduce this crash, it is easy
1) Open a file
2) Launch Summary (Statistics => Summary)
3) Close file (File => Close)
4) Apply in Summary windows
5) Crash

The gdb output
Program received signal SIGSEGV, Segmentation fault.
wtap_write_shb_comment (wth=0x0, comment=comment< at >entry=0x1eeec60 "")
    at wtap.c:125
125        g_free(wth->shb_hdr.opt_comment);

the backstrace :
#0  wtap_write_shb_comment (wth=0x0, comment=comment< at >entry=0x1eeec60 "")
    at wtap.c:125
#1  0x0000000000436bb9 in cf_update_capture_comment (cf=0x823940 <cfile>, 
    comment=0x1eeec60 "") at file.c:3861
#2  0x00000000004737e2 in summary_ok_cb (w=<optimized out>, 
    view=<optimized out>) at summary_dlg.c:157
#3  0x00007ffff201d8e7 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4  0x00007ffff20362df in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5  0x00007ffff2036f92 in g_signal_emit ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6  0x00007ffff2f189ee in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#7  0x00007ffff2fc0929 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#8  0x00007ffff201d620 in g_closure_invoke ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#9  0x00007ffff202eaf8 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#10 0x00007ffff2036996 in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#11 0x00007ffff2036f92 in g_signal_emit () 
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#12 0x00007ffff30d9d9e in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#13 0x00007ffff2fbed56 in gtk_propagate_event ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#14 0x00007ffff2fbf00b in gtk_main_do_event ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#15 0x00007ffff2c33ccc in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0
#16 0x00007ffff1b55f05 in g_main_context_dispatch ()
   from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#17 0x00007ffff1b56248 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#18 0x00007ffff1b566ba in g_main_loop_run ()
   from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#19 0x00007ffff2fbdfe7 in gtk_main ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#20 0x0000000000421d25 in main (argc=0, argv=0x7fffffffe1b0) at main.c:3190

the crash is reproduced in 1.8.x/1.10.x/trunk

A solution for fix the crash is set Summary dialog windows modal but there is a
better fix... (and this issue it is may be in other dialog windows... (Add/Edit
comment ?)

[Bug 8713] Add comments to multiple packets based on marked instead of current selection.

2013-05-25T09:23:51

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8713

Alexis La Goutte <alexis.lagoutte< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte< at >gmail.com

[Bug 8387] ZigBee ZCL OnOff cluster not recognized.

2013-05-25T09:08:47

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387

--- Comment #12 from Fabio Tarabelloni <fabio.tarabelloni< at >reloc.it> ---
Hi, I have one small note about last patch that I uploaded. There is a wrong
comment in the proto_reg_handoff_zbee_zcl_on_off description.
Than the "Hands off the Zcl Power Profile cluster dissector." shall be replaced
to "Hands off the Zcl OnOff cluster dissector."

Fabio.

[Bug 8713] Add comments to multiple packets based on marked instead of current selection.

2013-05-25T02:04:58

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8713

Evan Huus <eapache< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|x86                         |All
            Version|1.8.7                       |SVN
                 OS|Ubuntu                      |All
           Severity|Minor                       |Enhancement

[Bug 8713] Add comments to multiple packets based on marked instead of current selection.

2013-05-25T02:04:39

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8713

Evan Huus <eapache< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eapache< at >gmail.com

[Bug 8713] Add comments to multiple packets based on marked instead of current selection.

2013-05-25T02:03:16

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8713

Evan Huus <eapache< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10835|0                           |1
           is patch|                            |
  Attachment #10835|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #10835|                            |review_for_checkin?
              Flags|                            |

--- Comment #4 from Evan Huus <eapache< at >gmail.com> ---
Comment on attachment 10835
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=10835
Patch to add comment from selection to marked packet.

It sounds like we should probably just add tags then, though that would be
somewhat more work - what's the process for adding a 'tags' option to the
enhanced packet block in pcap-ng?

If we want to do that, it might be worth committing this feature in the
mean-time as a stop-gap until tags are ready...

[Bug 8387] ZigBee ZCL OnOff cluster not recognized.

2013-05-25T01:47:26

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387

Evan Huus <eapache< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|INCOMPLETE                  |RESOLVED
         Resolution|---                         |FIXED

[Bug 8387] ZigBee ZCL OnOff cluster not recognized.

2013-05-25T01:46:00

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387

Evan Huus <eapache< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10827|review_for_checkin?         |review_for_checkin+
              Flags|                            |

--- Comment #11 from Evan Huus <eapache< at >gmail.com> ---
Comment on attachment 10827
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=10827
Improved patch with fix

Thanks for the updated patch. Committed (with a few minor modifications) in
r49571.

[Bug 8633] New Dissector for Common Address Redundancy Protocol (CARP)

2013-05-24T22:27:01

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633

--- Comment #10 from Anders Broman <anders.broman< at >ericsson.com> ---
(In reply to comment #9)

There is half baked code to dissable heuristics the same way as other protocol
#if 0:ed out.

[Bug 8708] [PATCH] Add MAC-DATA support to TETRA dissector and other minor improvements

2013-05-24T20:56:07

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708

Pascal Quantin <pascal.quantin< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10833|review_for_checkin?         |review_for_checkin+
              Flags|                            |

[Bug 8708] [PATCH] Add MAC-DATA support to TETRA dissector and other minor improvements

2013-05-24T20:56:42

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708

Pascal Quantin <pascal.quantin< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|IN_PROGRESS                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Pascal Quantin <pascal.quantin< at >gmail.com> ---
Patch committed in revision 49567.

[Bug 8711] Wi-Fi Display dissector

2013-05-24T20:11:54

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8711

Alexis La Goutte <alexis.lagoutte< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10831|review_for_checkin?         |review_for_checkin-
              Flags|                            |

--- Comment #5 from Alexis La Goutte <alexis.lagoutte< at >gmail.com> ---
Comment on attachment 10831
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=10831
Add Wi-Fi Display dissector

Hi,

Also missing modification for Cmake (epan/CMakeList.txt)

About 
+    tvb_memcpy(tvb, addr, offset, 6);
+    proto_item_append_text(descr, ": %s", ether_to_str(addr));
There is a tvb_ether_to_str function :)

Also about .h file why no rename packet-wifi-p2p.h to packet-wifi.h(
packet-wfa.h ? or packet-ieee80211.h ? ) and include declaration of p2p and
display function ?

[Bug 8708] [PATCH] Add MAC-DATA support to TETRA dissector and other minor improvements

2013-05-24T20:09:16

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708

Pascal Quantin <pascal.quantin< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|INCOMPLETE                  |IN_PROGRESS

[Bug 8633] New Dissector for Common Address Redundancy Protocol (CARP)

2013-05-24T19:45:39

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633

--- Comment #9 from Alexis La Goutte <alexis.lagoutte< at >gmail.com> ---
(In reply to comment #8)

My idea is add a pref to disable heuristics... but yes it is very similar
feature with disabling dissector !

[Bug 8708] [PATCH] Add MAC-DATA support to TETRA dissector and other minor improvements

2013-05-24T19:45:25

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708

Pascal Quantin <pascal.quantin< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10828|0                           |1
        is obsolete|                            |
  Attachment #10828|review_for_checkin?         |
              Flags|                            |

[Bug 8708] [PATCH] Add MAC-DATA support to TETRA dissector and other minor improvements

2013-05-24T19:45:06

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708

Pascal Quantin <pascal.quantin< at >gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10833|                            |review_for_checkin?
              Flags|                            |

[Bug 8700] Bluetooth: Highlight correct bytes insome SDP trees

2013-05-24T19:42:04

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700

Michael Mann <mmann78< at >netscape.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|INCOMPLETE                  |RESOLVED
         Resolution|---                         |FIXED

[Bug 8700] Bluetooth: Highlight correct bytes insome SDP trees

2013-05-24T19:41:53

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700

Michael Mann <mmann78< at >netscape.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10824|review_for_checkin?         |review_for_checkin+
              Flags|                            |

--- Comment #4 from Michael Mann <mmann78< at >netscape.net> ---
Comment on attachment 10824
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=10824
[PATCH 2] Bluetooth: Highlight correct bytes in some SDP trees

Comitted to rev 49566.

[Bug 7733] Multiple expert info in a packet does not cause the most "severe" to be displayed in expert column

2013-05-24T19:27:24

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7733

Michael Mann <mmann78< at >netscape.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
                 CC|                            |mmann78< at >netscape.net
         Resolution|---                         |FIXED

--- Comment #4 from Michael Mann <mmann78< at >netscape.net> ---
Fixed in rev 49565. Scheduled for backporting.

[Bug 8444] Site Error - Uploading images notpossible

2013-05-24T18:27:50

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8444

Gerald Combs <gerald< at >wireshark.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Gerald Combs <gerald< at >wireshark.org> ---
This should be fixed now. Sorry it took so long.