gmane.network.samba-tng.cvs

cvs commit: tng/source/smbd connection.c server.c

2011-04-30T13:30:51

elrond      2011/04/30 15:30:51 CEST

Modified files:
   source/smbd            connection.c server.c 
Log:
connections-db: Handle disconnects better

smbd keeps a db of the currently connected
hosts/shares/users. If people disconnect from a share, this
is handled. But if the host finally closes the connection
and the smbd shuts down, this is not handled. Fix this.

Also minimal update to the sqlite backend version (not yet
ready for prime time).


Revision  Changes                              Path
1.19      +6 -3;  commitid: onOUio7QdHaxiRhv;  tng/source/smbd/connection.c
1.51      +1 -0;  commitid: onOUio7QdHaxiRhv;  tng/source/smbd/server.c

cvs commit: tng/source/smbd pipe-proxy.c

2011-04-30T13:24:04

elrond      2011/04/30 15:24:04 CEST

Modified files:
   source/smbd            pipe-proxy.c 
Log:
Fix dereference before check for NULL

Found in a usual audit session.


Revision  Changes                              Path
1.11      +4 -4;  commitid: d9FoNnC7IaaPgRhv;  tng/source/smbd/pipe-proxy.c

cvs commit: tng/source/groupdb groupdb.c tng/source/lib charcnv.cdaemon.c messages.c time.c util_sock.c tng/source/libsmb smbencrypt.cutil_smb_packet.c tng/source/locking locking.c tng/source/passdb ldap.csampassdb.c tng/source/rpc_server srv_pipe_netsec.ctng/source/rpcclient ...

2011-02-12T17:44:13

elrond      2011/02/12 18:44:13 CET

Modified files:
   source/groupdb         groupdb.c 
   source/lib             charcnv.c daemon.c messages.c time.c 
                          util_sock.c 
   source/libsmb          smbencrypt.c util_smb_packet.c 
   source/locking         locking.c 
   source/passdb          ldap.c sampassdb.c 
   source/rpc_server      srv_pipe_netsec.c 
   source/rpcclient       cmd_reg.c 
   source/smbd            filename.c vfs.c 
Log:
Lots of doxygen related comment updates

From time to time I have enhanced the comments to be more
doxygen friendly, or even added new comments to document
existing stuff. I do this mostly in a private tree. So I'm
now commiting a big bunch of this stuff.


Revision  Changes                               Path
1.23      +1 -1;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/groupdb/groupdb.c
1.33      +24 -0;  commitid: ToaXr8D0GQFoaZ7v;  tng/source/lib/charcnv.c
1.5       +6 -2;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/daemon.c
1.15      +1 -1;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/messages.c
1.17      +3 -4;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/time.c
1.43      +5 -3;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/util_sock.c
1.30      +3 -5;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/libsmb/smbencrypt.c
1.24      +1 -0;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/libsmb/util_smb_packet.c
1.35      +15 -6;  commitid: ToaXr8D0GQFoaZ7v;  tng/source/locking/locking.c
1.55      +3 -3;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/passdb/ldap.c
1.50      +0 -2;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/passdb/sampassdb.c
1.24      +5 -0;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/rpc_server/srv_pipe_netsec.c
1.31      +7 -6;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/rpcclient/cmd_reg.c
1.39      +1 -1;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/smbd/filename.c
1.48      +1 -0;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/smbd/vfs.c

cvs commit: tng/source configure.in

2011-02-12T18:29:35

elrond      2011/02/12 19:29:35 CET

Modified files:
   source                 configure.in 
Log:
Fix ldap deprecation warnings

openldap in its current version deprecates a bunch of
functions by just not declaring them by default. This
includes standard functions like ldap_open and some
functions that really might be replaced by better ones. We
still use a bunch of those functions. To get the
declarations back, add -DLDAP_DEPRECATED to CPPFLAGS, if
needed.


Revision  Changes                              Path
1.110     +5 -1;  commitid: zIIHKBtwHRcuqZ7v;  tng/source/configure.in

cvs commit: tng/source/include byteorder.h tng_misc.h

2011-02-12T17:33:35

elrond      2011/02/12 18:33:35 CET

Modified files:
   source/include         byteorder.h tng_misc.h 
Log:
Fix strict aliasing warnings: STRIP_CONST and byteorder macros

gcc 4.4 gives us a lot of warnings about strict aliasing
issues. Most of them are due to two things:

1) the byteorder macros (SIVAL for example), which partly
   use very tricky casts to create optimized code on i386.
   Until we have new optimized code, we'll use the generic
   code everywhere.

2) STRIP_CONST needs to do tricky casts anyway.
   I have rewritten it to use uintptr_t (an integer large
   enough to hold a pointer).

   It's not yet exactly clear, where we want to go with
   stdint.h portability (which is needed for uintptr_t).
   Currently we use a gnulib autoconf library to create a
   local wrapping "sambatng-int.h".

This fixes most of the new warnings.


Revision  Changes                              Path
1.7       +0 -6;  commitid: INiJDFpH5QzY5Z7v;  tng/source/include/byteorder.h
1.11      +4 -9;  commitid: INiJDFpH5QzY5Z7v;  tng/source/include/tng_misc.h

cvs commit: tng/source/lib passcheck.c tng/source/libsmbsmbencrypt.c tng/source/rpc_client cli_login.c msrpc_samr.ctng/source/rpc_parse parse_samr.c tng/source/rpcclient cmd_samr.c

2010-07-25T19:36:58

elrond      2010/07/25 21:36:57 CEST

Modified files:
   source/lib             passcheck.c 
   source/libsmb          smbencrypt.c 
   source/rpc_client      cli_login.c msrpc_samr.c 
   source/rpc_parse       parse_samr.c 
   source/rpcclient       cmd_samr.c 
Log:
DEBUG: netlogon; Signedness: samr, netlogon

Enhance some DBEUGs:
- smb_password_ok()
- cli_net_req_chal()

Fix up signedness in some places:
- decode_pw_buffer(), encode_pw_buffer()
  and some callers
- make_sam_user_info24()
- cli_nt_login_network()


Revision  Changes                              Path
1.8       +3 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/lib/passcheck.c
1.29      +2 -2;  commitid: jF4JCp31ybrTh2Iu;  tng/source/libsmb/smbencrypt.c
1.17      +7 -4;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpc_client/cli_login.c
1.18      +1 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpc_client/msrpc_samr.c
1.52      +1 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpc_parse/parse_samr.c
1.44      +1 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpcclient/cmd_samr.c

cvs commit: tng NEWS

2010-07-25T12:50:22

elrond      2010/07/25 14:50:22 CEST

Modified files:
   .                      NEWS 
Log:
Little update to NEWS file for 0.5

+ "Invalid packet length!" issue
+ 'max xmit': Obsolete, will be removed soon


Revision  Changes                              Path
1.28      +3 -0;  commitid: HPcAiqr6Wnl030Iu;  tng/NEWS

cvs commit: tng/source/include smbd.h tng/source/libsmbutil_smb_packet.c tng/source/param loadparm.c tng/source/smbd negprot.cprocess.c reply.c

2010-07-25T12:45:48

elrond      2010/07/25 14:45:37 CEST

Modified files:
   source/include         smbd.h 
   source/libsmb          util_smb_packet.c 
   source/param           loadparm.c 
   source/smbd            negprot.c process.c reply.c 
Log:
Fix "Invalid packet length!" issue

When Windows sends a very large packet (writing a large
file on the file server), sometimes the "Invalid packet
length!" could happen.

Problem was: We announced 4 bytes too much space to the
client for the receive buffer. This only turned up lately,
because we now have much better buffer overflow checks in
place.

Announce the correct space.

In this change, I dropped the complete support for "max
xmit". So this parameter is now officially "obsolete".

Thanks to Simon for reporting and testing!

Internal-Name: smbd_invalid_packet_size-1.diff


Revision  Changes                              Path
1.23      +2 -0;  commitid: TEMtQSRISjNh00Iu;  tng/source/include/smbd.h
1.23      +2 -1;  commitid: TEMtQSRISjNh00Iu;  tng/source/libsmb/util_smb_packet.c
1.88      +0 -1;  commitid: TEMtQSRISjNh00Iu;  tng/source/param/loadparm.c
1.23      +3 -4;  commitid: TEMtQSRISjNh00Iu;  tng/source/smbd/negprot.c
1.42      +0 -7;  commitid: TEMtQSRISjNh00Iu;  tng/source/smbd/process.c
1.142     +1 -2;  commitid: TEMtQSRISjNh00Iu;  tng/source/smbd/reply.c

cvs commit: tng/source/lib passcheck.c tng/source/libsmb credentials.c

2010-07-11T17:37:17

elrond      2010/07/11 19:37:17 CEST

Modified files:
   source/lib             passcheck.c 
   source/libsmb          credentials.c 
Log:
DEBUG; Signess: cred_session_key, smb_pwd_check_ntlmv2

Use "BYTE" more in cred_session_key and
smb_pwd_check_ntlmv2.

And put lib/passcheck.c in the "AUTH" debug class.


Revision  Changes                              Path
1.7       +4 -1;  commitid: Tv0L1crKfwxq5eGu;  tng/source/lib/passcheck.c
1.12      +2 -2;  commitid: Tv0L1crKfwxq5eGu;  tng/source/libsmb/credentials.c

cvs commit: tng/source/netlogond netlogond.c tng/source/rpc_clientmsrpc_netlogon.c tng/source/samrd samrd.c tng/source/smbd server.ctng/source/tdb tdbutil.c

2010-07-11T17:12:22

elrond      2010/07/11 19:12:22 CEST

Modified files:
   source/netlogond       netlogond.c 
   source/rpc_client      msrpc_netlogon.c 
   source/samrd           samrd.c 
   source/smbd            server.c 
   source/tdb             tdbutil.c 
Log:
netlogon client serialization

Our netlogon client code needs to talk serialized to one
server. This is mostly important when talking to our own
netlogond: If two smbds want to authenticate users at the
same time, they need to wait on each other. Reason: the
netlogon credentials are "per client", not "per
connection".

The current implementation uses a tdb as backend, but this
is all contained in a few lines of code and can quickly be
replaced with something better.

Internal-Name: netlogon-lock-1.diff


Revision  Changes                                Path
1.17      +3 -0;  commitid: wlkiADUG6gFWUdGu;    tng/source/netlogond/netlogond.c
1.15      +41 -0;  commitid: wlkiADUG6gFWUdGu;   tng/source/rpc_client/msrpc_netlogon.c
1.16      +3 -0;  commitid: wlkiADUG6gFWUdGu;    tng/source/samrd/samrd.c
1.50      +2 -0;  commitid: wlkiADUG6gFWUdGu;    tng/source/smbd/server.c
1.19      +13 -12;  commitid: wlkiADUG6gFWUdGu;  tng/source/tdb/tdbutil.c

cvs commit: tng/source/lib util_sid.c tng/source/rpcclientcmd_lsarpc.c

2010-03-09T21:35:51

elrond      2010/03/09 22:35:51 CET

Modified files:
   source/lib             util_sid.c 
   source/rpcclient       cmd_lsarpc.c 
Log:
valgrind: memleak in enumprivs, nicer sid_equal

rpcclient's enumprivs had a memleak. Fixed it.

sid_equal sometimes reads unset mem. It's not a bug,
because the final "fail" would have happened later anyway.
Just reordered things a little to calm down valgrind.


Revision  Changes                              Path
1.15      +7 -7;  commitid: t8c5LCXfWyI1ojqu;  tng/source/lib/util_sid.c
1.22      +3 -0;  commitid: t8c5LCXfWyI1ojqu;  tng/source/rpcclient/cmd_lsarpc.c

cvs commit: tng/source/lib charcnv.c charset.c tss.c util.ctng/source/rpc_client cli_pipe_ntlmssp.c tng/source/tdb tdbtool.c

2010-03-07T14:18:25

elrond      2010/03/07 15:18:25 CET

Modified files:
   source/lib             charcnv.c charset.c tss.c util.c 
   source/rpc_client      cli_pipe_ntlmssp.c 
   source/tdb             tdbtool.c 
Log:
64bit issues: Some smaller stuff and some printf

I left out a few things from the important 64bit fixes.
This is now another bunch of those.

Also start to address a bunch of the printf formats for
size_t.


Revision  Changes                              Path
1.32      +1 -1;  commitid: 2ZAOAllLCTON11qu;  tng/source/lib/charcnv.c
1.17      +1 -1;  commitid: 2ZAOAllLCTON11qu;  tng/source/lib/charset.c
1.4       +1 -1;  commitid: 2ZAOAllLCTON11qu;  tng/source/lib/tss.c
1.69      +5 -5;  commitid: 2ZAOAllLCTON11qu;  tng/source/lib/util.c
1.28      +4 -4;  commitid: 2ZAOAllLCTON11qu;  tng/source/rpc_client/cli_pipe_ntlmssp.c
1.10      +2 -2;  commitid: 2ZAOAllLCTON11qu;  tng/source/tdb/tdbtool.c

cvs commit: tng/source/include smbd.h tng/source/smbd ipc.cnttrans.c process.c sesssetup.c trans2.c

2010-03-05T21:38:24

elrond      2010/03/05 22:38:24 CET

Modified files:
   source/include         smbd.h 
   source/smbd            ipc.c nttrans.c process.c sesssetup.c 
                          trans2.c 
Log:
smbd.h: extern int max_send;

Move "extern int max_send;" from individual files to the
shared smbd.h.

Also some other little changes in smbd/: Move some decl
around and make a comment more doxygen friendly.


Revision  Changes                              Path
1.22      +1 -0;  commitid: Y1V6FfwF4pc3xNpu;  tng/source/include/smbd.h
1.30      +0 -2;  commitid: Y1V6FfwF4pc3xNpu;  tng/source/smbd/ipc.c
1.75      +0 -1;  commitid: Y1V6FfwF4pc3xNpu;  tng/source/smbd/nttrans.c
1.41      +0 -1;  commitid: Y1V6FfwF4pc3xNpu;  tng/source/smbd/process.c
1.22      +5 -7;  commitid: Y1V6FfwF4pc3xNpu;  tng/source/smbd/sesssetup.c
1.103     +0 -1;  commitid: Y1V6FfwF4pc3xNpu;  tng/source/smbd/trans2.c

cvs commit: tng/source configure.in tng/source/include includes.hsmb.h tng/source/lib username.c vuser.c tng/source/libsmb clirap.ctng/source/passdb secrets.c tng/source/rpc_client cli_connect.ctng/source/rpc_server srv_pipe_srv.c tng/source/samrd srv_samr_passdb.c...

2010-02-26T20:54:15

elrond      2010/02/26 21:54:15 CET

Modified files:
   source                 configure.in 
   source/include         includes.h smb.h 
   source/lib             username.c vuser.c 
   source/libsmb          clirap.c 
   source/passdb          secrets.c 
   source/rpc_client      cli_connect.c 
   source/rpc_server      srv_pipe_srv.c 
   source/samrd           srv_samr_passdb.c srv_samr_usr_tdb.c 
   source/smbd            service.c 
Log:
64bit issues: Most of the import fixes

We haven't checked TNG for ages on 64bit. Now we did. Most
of TNG is clean and we're happy. Just a few mixups of
uint32, size_t and (unsigned) int.

This commit includes most of the really important changes,
where real types were mixed up. Some very few things in
this area are missing, we need to investigate them
properly.

The big part, that is missing, are printf-fixes for size_t.
This is coming soon in a repository near you.


Revision  Changes                               Path
1.109     +6 -5;  commitid: 7mDyLSRgY0N3vTou;   tng/source/configure.in
1.56      +11 -0;  commitid: 7mDyLSRgY0N3vTou;  tng/source/include/includes.h
1.82      +2 -2;  commitid: 7mDyLSRgY0N3vTou;   tng/source/include/smb.h
1.20      +5 -5;  commitid: 7mDyLSRgY0N3vTou;   tng/source/lib/username.c
1.28      +1 -1;  commitid: 7mDyLSRgY0N3vTou;   tng/source/lib/vuser.c
1.22      +2 -2;  commitid: 7mDyLSRgY0N3vTou;   tng/source/libsmb/clirap.c
1.7       +1 -1;  commitid: 7mDyLSRgY0N3vTou;   tng/source/passdb/secrets.c
1.23      +3 -3;  commitid: 7mDyLSRgY0N3vTou;   tng/source/rpc_client/cli_connect.c
1.32      +5 -5;  commitid: 7mDyLSRgY0N3vTou;   tng/source/rpc_server/srv_pipe_srv.c
1.82      +12 -8;  commitid: 7mDyLSRgY0N3vTou;  tng/source/samrd/srv_samr_passdb.c
1.13      +1 -1;  commitid: 7mDyLSRgY0N3vTou;   tng/source/samrd/srv_samr_usr_tdb.c
1.38      +1 -1;  commitid: 7mDyLSRgY0N3vTou;   tng/source/smbd/service.c

cvs commit: tng/source/lib util_sock.c tng/source/libsmbnamequery.c tng/source/m4 type_socklen_t.m4

2010-02-25T21:31:54

elrond      2010/02/25 22:31:54 CET

Modified files:
   source/lib             util_sock.c 
   source/libsmb          namequery.c 
   source/m4              type_socklen_t.m4 
Log:
win32: ws2tcpip.h and socklen_t

Never win32 headers finally have socklen_t in ws2tcpip.h,
so search there for it.

Include ws2tcpip.h where needed.


Revision  Changes                              Path
1.42      +3 -0;  commitid: sI4vBdB8PeWAKLou;  tng/source/lib/util_sock.c
1.21      +3 -0;  commitid: sI4vBdB8PeWAKLou;  tng/source/libsmb/namequery.c
1.2       +7 -1;  commitid: sI4vBdB8PeWAKLou;  tng/source/m4/type_socklen_t.m4

cvs commit: tng/source/include rpc_lsa.h rpc_parse.htng/source/lsarpcd srv_lsa.c srv_lsa_samdb.c tng/source/rpc_clientcli_lsarpc.c msrpc_lsarpc.c tng/source/rpc_parse parse_lsa.ctng/source/rpcclient cmd_lsarpc.c display_sec.c

2010-02-25T20:59:21

elrond      2010/02/25 21:59:21 CET

Modified files:
   source/include         rpc_lsa.h rpc_parse.h 
   source/lsarpcd         srv_lsa.c srv_lsa_samdb.c 
   source/rpc_client      cli_lsarpc.c msrpc_lsarpc.c 
   source/rpc_parse       parse_lsa.c 
   source/rpcclient       cmd_lsarpc.c display_sec.c 
Log:
Make SID_ENUM, and LSA_TRANS_NAME_ENUM dynamic

Some clients tend to ask for more than 30 SIDs in an
lsa_lookup_sids(). We didn't like this. So changed this RPC
to use dynamic allocation.

While there added another one of my BMs (big macros):
RPC_ALLOC_ARRAY. It does most of the job of allocating an
array in a marshaller.


Revision  Changes                                Path
1.18      +4 -4;  commitid: 76hGZ9G6noEjzLou;    tng/source/include/rpc_lsa.h
1.14      +18 -0;  commitid: 76hGZ9G6noEjzLou;   tng/source/include/rpc_parse.h
1.17      +8 -2;  commitid: 76hGZ9G6noEjzLou;    tng/source/lsarpcd/srv_lsa.c
1.26      +15 -9;  commitid: 76hGZ9G6noEjzLou;   tng/source/lsarpcd/srv_lsa_samdb.c
1.32      +18 -13;  commitid: 76hGZ9G6noEjzLou;  tng/source/rpc_client/cli_lsarpc.c
1.12      +1 -1;  commitid: 76hGZ9G6noEjzLou;    tng/source/rpc_client/msrpc_lsarpc.c
1.25      +69 -12;  commitid: 76hGZ9G6noEjzLou;  tng/source/rpc_parse/parse_lsa.c
1.21      +1 -1;  commitid: 76hGZ9G6noEjzLou;    tng/source/rpcclient/cmd_lsarpc.c
1.9       +1 -1;  commitid: 76hGZ9G6noEjzLou;    tng/source/rpcclient/display_sec.c

cvs commit: tng/source/netlogond srv_netlogon_nt.c

2010-02-22T21:06:24

elrond      2010/02/22 22:06:24 CET

Modified files:
   source/netlogond       srv_netlogon_nt.c 
Log:
_net_auth*: Return STATUS_NO_TRUST_SAM_ACCOUNT if needed

In _net_auth and _net_auth_2 we now return
STATUS_NO_TRUST_SAM_ACCOUNT if the trust account does not
exist. This is per the spec by MS.

See: http://forum.samba-tng.org/viewtopic.php?id=354


Revision  Changes                                Path
1.41      +20 -13;  commitid: Eo0i4MO7YpDeHnou;  tng/source/netlogond/srv_netlogon_nt.c

cvs commit: tng/source/passdb sampassldap.c

2010-02-19T19:25:12

elrond      2010/02/19 20:25:12 CET

Modified files:
   source/passdb          sampassldap.c 
Log:
Ignore errors from ldap-increment-seqnum

We're incrementing the sequence number after having done
everything else in ldap. Meaning: The other data HAS been
changed.
We used to throw an error when incrementing the sequence
number fails. But this isn't a good idea, because the upper
level then thinks, that everything has failed. Which is
wrong.
This is can be fatal on password changes: The password WAS
changed in ldap, but the client gets a "failed".

Tested by Simon, thanks!

Internal-Name: inc-seq-ignore.diff


Revision  Changes                               Path
1.33      +23 -2;  commitid: qSHoDreDmC7neZnu;  tng/source/passdb/sampassldap.c

cvs commit: tng/source configure.in

2009-12-09T15:22:35

elrond      2009/12/09 16:22:35 CET

Modified files:
   source                 configure.in 
Log:
Update Version to 0.5-rc1.

This is the final step to the RC tarball I created about a
week ago.


Revision  Changes                              Path
1.108     +2 -2;  commitid: FE7NYfYP8qNVcIeu;  tng/source/configure.in

cvs commit: tng/docs/htmldocs smb.conf.5.html tng/docs/manpagessmb.conf.5

2009-12-09T14:46:36

elrond      2009/12/09 15:46:36 CET

Modified files:
   docs/htmldocs          smb.conf.5.html 
   docs/manpages          smb.conf.5 
Log:
Little yodldocs update: smb.conf*

Running yodldocs as part of the RC creation.


Revision  Changes                                Path
1.13      +12 -18;  commitid: puvRq1MXELWa1Ieu;  tng/docs/htmldocs/smb.conf.5.html
1.14      +19 -28;  commitid: puvRq1MXELWa1Ieu;  tng/docs/manpages/smb.conf.5

cvs commit: tng/source config.guess config.sub ltmain.shtng/source/m4 libtool.m4

2009-12-09T14:23:51

elrond      2009/12/09 15:23:51 CET

Modified files:
   source                 config.guess config.sub ltmain.sh 
   source/m4              libtool.m4 
Log:
Update to libtool 1.5.26-4, autotools-dev 20080123.1

These are basicly the versions from current Debian stable.
I hope they're really stable. They seem to work nicely for
me.

Internal-Name: lt_1.5.26-4_20080123.1.diff


Revision  Changes                                   Path
1.4       +541 -336;  commitid: r2RVmgOwfsffRHeu;   tng/source/config.guess
1.4       +314 -99;  commitid: r2RVmgOwfsffRHeu;    tng/source/config.sub
1.7       +1012 -474;  commitid: r2RVmgOwfsffRHeu;  tng/source/ltmain.sh
1.7       +1433 -712;  commitid: r2RVmgOwfsffRHeu;  tng/source/m4/libtool.m4