gmane.linux.serial http://blog.gmane.org/gmane.linux.serial hourly 1 1901-01-01T00:00+00:00 Gmane http://gmane.org/img/gmane-25t.png http://gmane.org Re: [PATCH] serial/amba-pl011: move custom pin control to driver http://permalink.gmane.org/gmane.linux.serial/7869 <pre> On imx28: Tested-by: Shawn Guo &lt;shawn.guo&lt; at &gt;linaro.org&gt; -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Shawn Guo 2012-05-25T06:26:09 Re: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7868 <pre>On Thu, 24 May 2012 08:05:12 -0700 (PDT) Dmitriy Alekseev &lt;alexeev6&lt; at &gt;yahoo.com&gt; wrote: You may have to stick some traces into drivers/tty/8250.c at this point and see what is going on. It's clearly trying to do the set up right, and created the ports but didn't believe the hardware. That usually implies that a parameter is wrong somewhere. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Alan Cox 2012-05-24T16:00:25 Re: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7867 <pre>The link I gave is original source, which I afterwards changed according to my parameters - clock and processor memory map. You right about offset 0x8, this is offset between ports in my 68 mode, I corrected, but it doesn't give any result.   Best regards, Dmitriy Alekseev ----- Original Message ----- From: Alan Cox &lt;alan&lt; at &gt;lxorguk.ukuu.org.uk&gt; To: Dmitriy Alekseev &lt;alexeev6&lt; at &gt;yahoo.com&gt; Cc: Sent: Thursday, May 24, 2012 5:22 PM Subject: Re: struct tty_flip_buffer replacement in newer kernels On Thu, 24 May 2012 03:38:42 -0700 (PDT) Dmitriy Alekseev &lt;alexeev6&lt; at &gt;yahoo.com&gt; wrote: That looks reasonable - UPF_IOREMAP tells the kernel to do the ioremap for you, UPF_BOOT_AUTOCONF tries to autoconfigure the chip type And this guides the register spacing (1 = byte spaced, 2 = word spaced, 3 = dword spaced etc) UPIO_MEM is for MMIO, UPIO_PORT for port I/O However the values don't look the same as the old driver you linked to - that seems to be using 0x2800000 and then 8 byte spacing plus a 1843200 clock. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Dmitriy Alekseev 2012-05-24T15:05:12 Fw: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7866 <pre>Hi, Alan. Thank You very much for the answer! So, if I understand correctly, I took for example this: arch/arm/mach-omap1/board-voiceblue.c And made in my board specific file: static struct plat_serial8250_port exar_ports[] = {         {                 .mapbase        = (unsigned long)(0x30000300), // according to at91rm9200 CS2 memory map                 .flags          = UPF_BOOT_AUTOCONF | UPF_IOREMAP, // I don't know, what kind of flags is suitable for me                 .iotype         = UPIO_MEM, // similar problem                 .regshift       = 1,                  .uartclk        = 14745600, // Our chip clock frequency         },         {                 .mapbase        = (unsigned long)(0x30000200),                 .flags          = UPF_BOOT_AUTOCONF | UPF_IOREMAP,                 .iotype         = UPIO_MEM,                 .regshift       = 1,                 .uartclk        = 14745600,         },         {                 .mapbase        = (unsigned long)(0x30000100),                 .flags          = UPF_BOOT_AUTOCONF | UPF_IOREMAP,                 .iotype         = UPIO_MEM,                 .regshift       = 1,                 .uartclk        = 14745600,         },         {                 .mapbase        = (unsigned long)(0x30000000),                 .flags          = UPF_BOOT_AUTOCONF | UPF_IOREMAP,                 .iotype         = UPIO_MEM,                 .regshift       = 1,                 .uartclk        = 14745600,         },         { }, }; static struct platform_device serial_device = { .name                   = "serial8250",         .id                     = PLAT8250_DEV_EXAR_ST16C554,         .dev                    = {                  .platform_data  = exar_ports,          }, }; in my board __init func: platform_device_register(&amp;serial_device); at .config I made: # # Serial drivers # CONFIG_SERIAL_8250=y # CONFIG_SERIAL_8250_CONSOLE is not set CONFIG_SERIAL_8250_NR_UARTS=4 CONFIG_SERIAL_8250_RUNTIME_UARTS=4 CONFIG_SERIAL_8250_EXTENDED=y CONFIG_SERIAL_8250_MANY_PORTS=y # CONFIG_SERIAL_8250_SHARE_IRQ is not set # CONFIG_SERIAL_8250_DETECT_IRQ is not set # CONFIG_SERIAL_8250_RSA is not set dmesg gives: [    0.695312] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled          New devices in filesystem has been registered, but they didn't related with hardware chip yet. #cat /proc/tty/driver/serial                                  serinfo:1.0 driver revision:                                                     0: uart:unknown mmio:0x30000000 irq:0                                            1: uart:unknown port:00000000 irq:0                                              2: uart:unknown port:00000000 irq:0                                              3: uart:unknown port:00000000 irq:0     What shoud I check, learn, do for solving this problem? Very grateful, Dmitriy Alekseev ----- Original Message ----- From: Alan Cox &lt;alan&lt; at &gt;lxorguk.ukuu.org.uk&gt; To: Dmitriy Alekseev &lt;alexeev6&lt; at &gt;yahoo.com&gt; Cc: "linux-serial&lt; at &gt;vger.kernel.org" &lt;linux-serial&lt; at &gt;vger.kernel.org&gt; Sent: Tuesday, May 22, 2012 8:27 PM Subject: Re: struct tty_flip_buffer replacement in newer kernels On Tue, 22 May 2012 07:38:28 -0700 (PDT) Dmitriy Alekseev &lt;alexeev6&lt; at &gt;yahoo.com&gt; wrote: Why not use the in kernel 8250 driver (which will drive a stamdard 16540/550/554 as well ?) To ressurect one you'll need to add kref handling, rework the termios code and maybe some other bits too. Take a look how other arm boards use struct plat_serial8250_port and the serial8250 platform driver. You should just be able to declare the structures and register the platform device. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Dmitriy Alekseev 2012-05-24T10:38:42 RE: [PATCH 1/2] serial: samsung: Remove NULL checking for baud clock http://permalink.gmane.org/gmane.linux.serial/7865 <pre> I missed following. Russell King suggested: As I said, drivers have no business interpreting anything but IS_ERR(clk) as being an error. They should not make any other assumptions. Suggested-by: Russell King &lt;rmk+kernel&lt; at &gt;arm.linux.org.uk&gt; -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Kyoungil Kim 2012-05-24T08:39:37 [PATCH] serial/amba-pl011: move custom pin control to driver http://permalink.gmane.org/gmane.linux.serial/7864 <pre>From: Linus Walleij &lt;linus.walleij&lt; at &gt;linaro.org&gt; We had a boot regression in Ux500 in the merge window because two orthogonal pin control schemes for the PL011 were merged at the same time: - One using the .init() and .exit() hooks into the platform for Ux500 putting the pins into default vs sleep state respectively as the port was started/stopped. commit a09806607fd20bed2f8c41fe22793386790a14aa "ARM: ux500: switch to using pinctrl for uart0" - One hogging the default setting at PL011 probe() commit 258e055111d3cde2607e0d04eb91da2f7a59b591 "serial: amba-pl011: adopt pinctrl support" To get a solution that works for both let's scrap the stuff in the platform callbacks, instead have the driver itself select default and sleep states when the port is started/stopped. Hopefully this works for all clients. Platform callbacks are bad for device tree migration anyway, so this rids us of another problem in Ux500. Cc: linux-serial&lt; at &gt;vger.kernel.org Cc: Greg Kroah-Hartman &lt;gregkh&lt; at &gt;linuxfoundation.org&gt; Cc: Shawn Guo &lt;shawn.guo&lt; at &gt;linaro.org&gt; Cc: Russell King &lt;rmk+kernel&lt; at &gt;arm.linux.org.uk&gt; Reported-by: Lee Jones &lt;lee.jones&lt; at &gt;linaro.org&gt; Signed-off-by: Linus Walleij &lt;linus.walleij&lt; at &gt;linaro.org&gt; --- arch/arm/mach-ux500/board-mop500.c | 54 +----------------------------------- drivers/tty/serial/amba-pl011.c | 45 +++++++++++++++++++++++++++--- 2 files changed, 42 insertions(+), 57 deletions(-) diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c index 4bc0cbc..e7af625 100644 --- a/arch/arm/mach-ux500/board-mop500.c +++ b/arch/arm/mach-ux500/board-mop500.c &lt; at &gt;&lt; at &gt; -540,43 +540,12 &lt; at &gt;&lt; at &gt; static void ux500_uart0_reset(void) udelay(1); } -/* This needs to be referenced by callbacks */ -struct pinctrl *u0_p; -struct pinctrl_state *u0_def; -struct pinctrl_state *u0_sleep; - -static void ux500_uart0_init(void) -{ -int ret; - -if (IS_ERR(u0_p) || IS_ERR(u0_def)) -return; - -ret = pinctrl_select_state(u0_p, u0_def); -if (ret) -pr_err("could not set UART0 defstate\n"); -} - -static void ux500_uart0_exit(void) -{ -int ret; - -if (IS_ERR(u0_p) || IS_ERR(u0_sleep)) -return; - -ret = pinctrl_select_state(u0_p, u0_sleep); -if (ret) -pr_err("could not set UART0 idlestate\n"); -} - static struct amba_pl011_data uart0_plat = { #ifdef CONFIG_STE_DMA40 .dma_filter = stedma40_filter, .dma_rx_param = &amp;uart0_dma_cfg_rx, .dma_tx_param = &amp;uart0_dma_cfg_tx, #endif -.init = ux500_uart0_init, -.exit = ux500_uart0_exit, .reset = ux500_uart0_reset, }; &lt; at &gt;&lt; at &gt; -598,28 +567,7 &lt; at &gt;&lt; at &gt; static struct amba_pl011_data uart2_plat = { static void __init mop500_uart_init(struct device *parent) { -struct amba_device *uart0_device; - -uart0_device = db8500_add_uart0(parent, &amp;uart0_plat); -if (uart0_device) { -u0_p = pinctrl_get(&amp;uart0_device-&gt;dev); -if (IS_ERR(u0_p)) -dev_err(&amp;uart0_device-&gt;dev, -"could not get UART0 pinctrl\n"); -else { -u0_def = pinctrl_lookup_state(u0_p, - PINCTRL_STATE_DEFAULT); -if (IS_ERR(u0_def)) { -dev_err(&amp;uart0_device-&gt;dev, -"could not get UART0 defstate\n"); -} -u0_sleep = pinctrl_lookup_state(u0_p, -PINCTRL_STATE_SLEEP); -if (IS_ERR(u0_sleep)) -dev_err(&amp;uart0_device-&gt;dev, -"could not get UART0 idlestate\n"); -} -} +db8500_add_uart0(parent, &amp;uart0_plat); db8500_add_uart1(parent, &amp;uart1_plat); db8500_add_uart2(parent, &amp;uart2_plat); } diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 4ad721f..c17923e 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c &lt; at &gt;&lt; at &gt; -133,6 +133,10 &lt; at &gt;&lt; at &gt; struct pl011_dmatx_data { struct uart_amba_port { struct uart_portport; struct clk*clk; +/* Two optional pin states - default &amp; sleep */ +struct pinctrl*pinctrl; +struct pinctrl_state*pins_default; +struct pinctrl_state*pins_sleep; const struct vendor_data *vendor; unsigned intdmacr;/* dma control reg */ unsigned intim;/* interrupt mask */ &lt; at &gt;&lt; at &gt; -1312,6 +1316,14 &lt; at &gt;&lt; at &gt; static int pl011_startup(struct uart_port *port) unsigned int cr; int retval; +/* Optionaly enable pins to be muxed in and configured */ +if (!IS_ERR(uap-&gt;pins_default)) { +retval = pinctrl_select_state(uap-&gt;pinctrl, uap-&gt;pins_default); +if (retval) +dev_err(port-&gt;dev, +"could not set default pins\n"); +} + retval = clk_prepare(uap-&gt;clk); if (retval) goto out; &lt; at &gt;&lt; at &gt; -1420,6 +1432,7 &lt; at &gt;&lt; at &gt; static void pl011_shutdown(struct uart_port *port) { struct uart_amba_port *uap = (struct uart_amba_port *)port; unsigned int cr; +int retval; /* * disable all interrupts &lt; at &gt;&lt; at &gt; -1462,6 +1475,14 &lt; at &gt;&lt; at &gt; static void pl011_shutdown(struct uart_port *port) */ clk_disable(uap-&gt;clk); clk_unprepare(uap-&gt;clk); +/* Optionally let pins go into sleep states */ +if (!IS_ERR(uap-&gt;pins_sleep)) { +retval = pinctrl_select_state(uap-&gt;pinctrl, uap-&gt;pins_sleep); +if (retval) +dev_err(port-&gt;dev, +"could not set pins to sleep state\n"); +} + if (uap-&gt;port.dev-&gt;platform_data) { struct amba_pl011_data *plat; &lt; at &gt;&lt; at &gt; -1792,6 +1813,14 &lt; at &gt;&lt; at &gt; static int __init pl011_console_setup(struct console *co, char *options) if (!uap) return -ENODEV; +/* Allow pins to be muxed in and configured */ +if (!IS_ERR(uap-&gt;pins_default)) { +ret = pinctrl_select_state(uap-&gt;pinctrl, uap-&gt;pins_default); +if (ret) +dev_err(uap-&gt;port.dev, +"could not set default pins\n"); +} + ret = clk_prepare(uap-&gt;clk); if (ret) return ret; &lt; at &gt;&lt; at &gt; -1844,7 +1873,6 &lt; at &gt;&lt; at &gt; static int pl011_probe(struct amba_device *dev, const struct amba_id *id) { struct uart_amba_port *uap; struct vendor_data *vendor = id-&gt;data; -struct pinctrl *pinctrl; void __iomem *base; int i, ret; &lt; at &gt;&lt; at &gt; -1869,11 +1897,20 &lt; at &gt;&lt; at &gt; static int pl011_probe(struct amba_device *dev, const struct amba_id *id) goto free; } -pinctrl = devm_pinctrl_get_select_default(&amp;dev-&gt;dev); -if (IS_ERR(pinctrl)) { -ret = PTR_ERR(pinctrl); +uap-&gt;pinctrl = devm_pinctrl_get(&amp;dev-&gt;dev); +if (IS_ERR(uap-&gt;pinctrl)) { +ret = PTR_ERR(uap-&gt;pinctrl); goto unmap; } +uap-&gt;pins_default = pinctrl_lookup_state(uap-&gt;pinctrl, + PINCTRL_STATE_DEFAULT); +if (IS_ERR(uap-&gt;pins_default)) +dev_err(&amp;dev-&gt;dev, "could not get default pinstate\n"); + +uap-&gt;pins_sleep = pinctrl_lookup_state(uap-&gt;pinctrl, + PINCTRL_STATE_SLEEP); +if (IS_ERR(uap-&gt;pins_sleep)) +dev_dbg(&amp;dev-&gt;dev, "could not get sleep pinstate\n"); uap-&gt;clk = clk_get(&amp;dev-&gt;dev, NULL); if (IS_ERR(uap-&gt;clk)) { </pre> Linus Walleij 2012-05-23T19:18:46 Re: [PATCH 1/1] serial_core: Update buffer overrun statistics. http://permalink.gmane.org/gmane.linux.serial/7863 <pre> Oh, sorry about that. Here is an archived version of the email thread: http://www.spinics.net/lists/linux-serial/msg06104.html I'll also copy and paste my patch here: Currently, serial drivers don't report buffer overruns. When a buffer overrun occurs, tty_insert_flip_char returns 0, and no attempt is made to insert that same character again (i.e. it is lost). This patch reports buffer overruns via the buf_overrun field in the port's icount structure. Signed-off-by: Corbin Atkinson &lt;corbin.atkinson&lt; at &gt;xxxxxx&gt; --- drivers/tty/serial/serial_core.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 9c4c05b..59fb3ba 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c &lt; at &gt;&lt; at &gt; -2526,14 +2526,16 &lt; at &gt;&lt; at &gt; void uart_insert_char(struct uart_port *port, unsigned int status, struct tty_struct *tty = port-&gt;state-&gt;port.tty; if ((status &amp; port-&gt;ignore_status_mask &amp; ~overrun) == 0) -tty_insert_flip_char(tty, ch, flag); +if (tty_insert_flip_char(tty, ch, flag) == 0) +++port-&gt;icount.buf_overrun; /* * Overrun is special. Since it's reported immediately, * it doesn't affect the current character. */ if (status &amp; ~port-&gt;ignore_status_mask &amp; overrun) -tty_insert_flip_char(tty, 0, TTY_OVERRUN); +if (tty_insert_flip_char(tty, 0, TTY_OVERRUN) == 0) +++port-&gt;icount.buf_overrun; } EXPORT_SYMBOL_GPL(uart_insert_char); </pre> Corbin 2012-05-23T14:37:31 Re: [PATCH 1/1] serial_core: Update buffer overrun statistics. http://permalink.gmane.org/gmane.linux.serial/7862 <pre> That it is perfectly concealed. (I'm not subscribed to linux-serial and cannot find it anywhere. A link would be appreciated...) thanks, </pre> Jiri Slaby 2012-05-22T20:38:19 Re: [PATCH 1/1] serial_core: Update buffer overrun statistics. http://permalink.gmane.org/gmane.linux.serial/7861 <pre> Jiri, What do you think of my patch? -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Corbin 2012-05-22T20:31:15 Re: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7859 <pre>On Tue, 22 May 2012 07:38:28 -0700 (PDT) Dmitriy Alekseev &lt;alexeev6&lt; at &gt;yahoo.com&gt; wrote: Why not use the in kernel 8250 driver (which will drive a stamdard 16540/550/554 as well ?) To ressurect one you'll need to add kref handling, rework the termios code and maybe some other bits too. Take a look how other arm boards use struct plat_serial8250_port and the serial8250 platform driver. You should just be able to declare the structures and register the platform device. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Alan Cox 2012-05-22T16:27:00 [GIT PATCH] TTY/serial patches for 3.5-rc1 - try 2 http://permalink.gmane.org/gmane.linux.serial/7858 <pre>The following changes since commit 66f75a5d028beaf67c931435fdc3e7823125730c: Linux 3.4-rc4 (2012-04-21 14:47:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-3.5-rc1 for you to fetch changes up to 59bd234b72fc29887839d792b7d6c7e8d2a577a6: serial: bfin_uart: Make MMR access compatible with 32 bits bf609 style controller. (2012-05-17 13:25:56 -0700) ---------------------------------------------------------------- TTY pull request for 3.5-rc1 Here's the big TTY/serial driver pull request for the 3.5-rc1 merge window. Nothing major in here, just lots of incremental changes from Alan and Jiri reworking some tty core things to behave better and to get a more solid grasp on some of the nasty tty locking issues. There are a few tty and serial driver updates in here as well. All of this has been in the linux-next releases for a while with no problems. Signed-off-by: Greg Kroah-Hartman &lt;gregkh&lt; at &gt;linuxfoundation.org&gt; ---------------------------------------------------------------- Alan Cox (7): vt: push the tty_lock down into the map handling tty_lock: undo the old tty_lock use on the ctty pty: Lock the devpts bits privately tty_lock: Localise the lock tty: drop the pty lock during hangup tty: Allow uart_register/unregister/register tty: Fix LED error return Arnaud Patard (1): 8250_pci: fix pch uart matching Christian Melki (1): 8250.c: less than 2400 baud fix. Corbin Atkinson (1): serial_core: Update buffer overrun statistics. Dan Carpenter (1): tty: hvc_xen: NULL dereference on allocation failure Dan Williams (2): tegra, serial8250: add -&gt;handle_break() uart_port op serial/8250_pci: fix suspend/resume vs init/exit quirks Geert Uytterhoeven (1): tty/amiserial: Add missing argument for tty_unlock() Govindraj.R (1): OMAP2+: UART: Remove cpu checks for populating errata flags Greg Kroah-Hartman (3): Merge 3.4-rc3 into tty-next Merge 3.4-rc4 into tty-next Revert "serial_core: Update buffer overrun statistics." H Hartley Sweeten (1): tty: mxser: local variables should not be exposed globally Heiko Carstens (1): tty: add missing tty_port_tty_get() call to raw3215_wakeup Ivo Sieben (1): tty: move global ldisc idle waitqueue to the individual ldisc Jiri Slaby (71): TTY: crisv10, remove unused tmp_buf TTY: crisv10, initialize tty_port TTY: deprecate linux/generic_serial.h ISDN: i4l, remove cvs crap TTY: isdn, remove callout TTY: isdn, remove ISDN_ASYNC_* flags TTY: isdn, do not play with module refcounts TTY: isdn, make some functions readable TTY: isdn, remove unused members from modem_info TTY: isdn, add tty_port TTY: isdn, use open/close_wait from tty_port TTY: isdn, use counts from tty_port TTY: isdn, use tty from tty_port TTY: isdn, use xmit_buf from tty_port TTY: isdn, define local tty_port TTY: isdn, use tty_port_close_end helper TTY: isdn, define tty_port_operations TTY: isdn, use tty_port_block_til_ready helper TTY: hso, do not set TTY MAGIC TTY: hso, free tty_driver TTY: hso, add tty_port TTY: hso, remove tty NULL checks fro tty-&gt;ops TTY: hso, use tty from tty_port TTY: con3215, centralize allocation TTY: sclp_tty, add tty_port TTY: sclp_vt220, add tty_port TTY: sclp_vt220, remove unused allocation TTY: tty3270, move initialization to allocation TTY: tty3270, get rid of ugly aliasing TTY: tty3270, push tty down to tty3270_do_write TTY: tty3270, add tty_port TTY: bfin_jtag_comm, add tty_port TTY: bfin_jtag_comm, use tty from tty_port TTY: HVC, add tty_port TTY: HVC, use tty from tty_port TTY: HVC, use count from tty_port TTY: hvcs, add tty_port TTY: hvcs, use kref from tty_port TTY: hvcs, use tty from tty_port TTY: hvsi, CLOCAL is not in tty-&gt;flags TTY: hvsi, add tty_port TTY: hvsi, sanitize uses of tty TTY: hvsi, use tty from tty_port TTY: ipwireless, use synchronous hangup TTY: ipwireless, move prints to appropriate places TTY: ipwireless, add tty_port TTY: ipwireless, use tty from tty_port TTY: 68328serial, remove serial_state and friends TTY: 68328serial, remove unused stuff from m68k_serial TTY: 68328serial, remove garbage TTY: 68328serial, use ulong flags for interrupts status TTY: 68328serial, remove 68328serial.h TTY: 68328serial, add tty_port TTY: 68328serial, use open/close_wait from tty_port TTY: 68328serial, use close_delay/closing_wait from tty_port TTY: 68328serial, use flags from tty_port TTY: 68328serial, propagate tty TTY: 68328serial, use tty from tty_port TTY: 68328serial, use tty_port_block_til_ready TTY: usb/u_serial, add tty_port TTY: usb/u_serial, use tty from tty_port TTY: usb/u_serial use close_wait from tty_port TTY: rfcomm/tty, add tty_port TTY: rfcomm/tty, use tty_port refcounting TTY: rfcomm/tty, remove work for tty_wakeup TTY: rfcomm/tty, use count from tty_port ISDN: remove uses of isdn_tty_revision TTY: hvc, fix TTY refcounting TTY: con3215, add tty_port TTY: con3215, use tty from tty_port TTY: n_tty, do not dereference user buffer Lothar Waßmann (1): Add missing call to uart_update_timeout() Magnus Damm (8): serial8250: Add dl_read()/dl_write() callbacks serial8250: Use dl_read()/dl_write() on Alchemy serial8250: Use dl_read()/dl_write() on RM9K serial8250: Clean up default map and dl code serial8250: Introduce serial8250_register_8250_port() serial8250-em: Emma Mobile UART driver V2 serial8250-em: clk_get() IS_ERR() error handling fix serial8250-em: Add DT support Michael Gehring (1): tty/vt: handle bad user buffer in {G,P}IO_CMAP ioctl Paul Gortmaker (1): cris: fix missing tty arg in wait_event_interruptible_tty call Rajanikanth H.V (1): serial: pl011: implement workaround for CTS clear event issue Sonic Zhang (4): serial: bfin_uart: Adapt bf5xx serial driver to bf60x serial4 controller. serial: bfin_uart: narrow the reboot condition in DMA tx interrupt serial: bfin_uart: RTS and CTS MMRs can be either 16-bit width or 32-bit width. serial: bfin_uart: Make MMR access compatible with 32 bits bf609 style controller. Sudhakar Mamillapalli (1): serial/8250_pci: Clear FIFOs for Intel ME Serial Over Lan device on BI Tomoya MORINAGA (7): pch_uart: Delete unused structure member pch_uart: change type to u8 pch_uart: change type to %d to %02x pch_uart: Support modem status interrupt pch_uart: delete unused data structure pch_uart: Fix return value issue pch_uart: Fix duplicate memory release issue Xiaobing Tu (1): tty: hold lock across tty buffer finding and buffer filling arch/arm/mach-omap2/serial.c | 8 - arch/arm/mach-tegra/board-harmony.c | 2 + arch/arm/mach-tegra/board-paz00.c | 3 + arch/arm/mach-tegra/board-seaboard.c | 2 + arch/arm/mach-tegra/board-trimslice.c | 2 + arch/arm/plat-omap/include/plat/omap-serial.h | 1 - drivers/isdn/i4l/isdn_common.c | 5 - drivers/isdn/i4l/isdn_tty.c | 466 ++++++++++--------------- drivers/net/usb/hso.c | 105 +++--- drivers/s390/char/con3215.c | 142 ++++---- drivers/s390/char/keyboard.c | 30 +- drivers/s390/char/keyboard.h | 14 +- drivers/s390/char/sclp_tty.c | 33 +- drivers/s390/char/sclp_vt220.c | 33 +- drivers/s390/char/tty3270.c | 121 +++---- drivers/staging/serial/68360serial.c | 4 +- drivers/tty/amiserial.c | 14 +- drivers/tty/bfin_jtag_comm.c | 44 +-- drivers/tty/cyclades.c | 2 +- drivers/tty/hvc/hvc_console.c | 96 +++-- drivers/tty/hvc/hvc_console.h | 4 +- drivers/tty/hvc/hvc_xen.c | 4 +- drivers/tty/hvc/hvcs.c | 74 ++-- drivers/tty/hvc/hvsi.c | 128 +++---- drivers/tty/hvc/hvsi_lib.c | 2 +- drivers/tty/ipwireless/tty.c | 81 ++--- drivers/tty/mxser.c | 2 +- drivers/tty/n_r3964.c | 11 +- drivers/tty/n_tty.c | 9 +- drivers/tty/pty.c | 40 ++- drivers/tty/serial/68328serial.c | 383 ++++++++------------ drivers/tty/serial/68328serial.h | 186 ---------- drivers/tty/serial/8250/8250.c | 312 ++++++++--------- drivers/tty/serial/8250/8250.h | 16 + drivers/tty/serial/8250/8250_em.c | 186 ++++++++++ drivers/tty/serial/8250/8250_pci.c | 63 ++++ drivers/tty/serial/8250/Kconfig | 8 + drivers/tty/serial/8250/Makefile | 1 + drivers/tty/serial/amba-pl011.c | 109 +----- drivers/tty/serial/bfin_uart.c | 74 ++-- drivers/tty/serial/crisv10.c | 36 +- drivers/tty/serial/mxs-auart.c | 2 + drivers/tty/serial/of_serial.c | 26 ++ drivers/tty/serial/omap-serial.c | 74 +++- drivers/tty/serial/pch_uart.c | 53 +-- drivers/tty/serial/serial_core.c | 1 + drivers/tty/synclink.c | 4 +- drivers/tty/synclink_gt.c | 4 +- drivers/tty/synclinkmp.c | 4 +- drivers/tty/tty_buffer.c | 85 +++-- drivers/tty/tty_io.c | 76 ++-- drivers/tty/tty_ldisc.c | 37 +- drivers/tty/tty_mutex.c | 60 +++- drivers/tty/tty_port.c | 6 +- drivers/tty/vt/consolemap.c | 123 +++++-- drivers/tty/vt/keyboard.c | 2 +- drivers/tty/vt/vt.c | 68 ++-- drivers/tty/vt/vt_ioctl.c | 25 +- drivers/usb/gadget/u_serial.c | 51 ++- include/linux/generic_serial.h | 64 +--- include/linux/isdn.h | 26 +- include/linux/of_serial.h | 17 + include/linux/serial_8250.h | 2 + include/linux/serial_core.h | 5 + include/linux/tty.h | 23 +- include/linux/tty_ldisc.h | 2 + include/linux/vt_kern.h | 1 - net/bluetooth/rfcomm/tty.c | 137 ++++---- 68 files changed, 1877 insertions(+), 1957 deletions(-) delete mode 100644 drivers/tty/serial/68328serial.h create mode 100644 drivers/tty/serial/8250/8250_em.c create mode 100644 include/linux/of_serial.h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Greg KH 2012-05-22T15:15:27 Re: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7857 <pre>[Re-adding original poster an LKML after I accidentally dropped them. Sorry about that] On 05/22/2012 03:10 PM, Alan Cox wrote: -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Jack Stone 2012-05-22T14:44:15 Re: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7856 <pre>This is driver source I found: http://www.codeforge.com/read/118181/st16c554_serial.c__html It was written for quad uart st16c554 for arm chip s3c2410, which I tried to adapt for at91rm9200 board and newer kernel version. Best regards, Dmitriy Alekseev ----- Original Message ----- From: Alan Cox &lt;alan&lt; at &gt;lxorguk.ukuu.org.uk&gt; To: Jack Stone &lt;jwjstone&lt; at &gt;fastmail.fm&gt; Cc: gregkh&lt; at &gt;linuxfoundation.org; alan&lt; at &gt;linux.intel.com; linux-serial&lt; at &gt;vger.kernel.org Sent: Tuesday, May 22, 2012 6:10 PM Subject: Re: struct tty_flip_buffer replacement in newer kernels Your driver shouldn't be looking in those areas. There isn't a correct replacement. You will need to update it to use the flip buffers properly not poke its nose in places it shouldn't have. Perhaps the best thing would be to post a link to the driver ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Dmitriy Alekseev 2012-05-22T14:38:28 Re: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7855 <pre> Your driver shouldn't be looking in those areas. There isn't a correct replacement. You will need to update it to use the flip buffers properly not poke its nose in places it shouldn't have. Perhaps the best thing would be to post a link to the driver ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Alan Cox 2012-05-22T14:10:33 [GIT PATCH] TTY/serial patches for 3.5-rc1 http://permalink.gmane.org/gmane.linux.serial/7854 <pre>The following changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3: Linux 3.4-rc6 (2012-05-06 15:07:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-3.5-rc1 for you to fetch changes up to d48b97b403d23f6df0b990cee652bdf9a52337a3: Linux 3.4-rc6 (2012-05-06 15:07:32 -0700) ---------------------------------------------------------------- TTY pull request for 3.5-rc1 Here's the big TTY/serial driver pull request for the 3.5-rc1 merge window. Nothing major in here, just lots of incremental changes from Alan and Jiri reworking some tty core things to behave better and to get a more solid grasp on some of the nasty tty locking issues. There are a few tty and serial driver updates in here as well. All of this has been in the linux-next releases for a while with no problems. Signed-off-by: Greg Kroah-Hartman &lt;gregkh&lt; at &gt;linuxfoundation.org&gt; ---------------------------------------------------------------- Documentation/ABI/testing/sysfs-bus-hsi | 19 - .../ata/{ahci-platform.txt =&gt; calxeda-sata.txt} | 5 +- .../devicetree/bindings/sound/sgtl5000.txt | 2 - Documentation/networking/ip-sysctl.txt | 4 +- Documentation/power/freezing-of-tasks.txt | 37 +- Documentation/security/keys.txt | 14 +- MAINTAINERS | 12 +- Makefile | 2 +- arch/alpha/Kconfig | 2 +- arch/alpha/include/asm/rtc.h | 8 +- arch/alpha/kernel/core_tsunami.c | 1 - arch/alpha/kernel/sys_marvel.c | 2 +- arch/arm/Kconfig | 9 - arch/arm/boot/dts/msm8660-surf.dts | 4 +- arch/arm/boot/dts/versatile-ab.dts | 2 +- arch/arm/boot/dts/versatile-pb.dts | 2 +- arch/arm/configs/mini2440_defconfig | 2 - arch/arm/include/asm/thread_info.h | 7 - arch/arm/include/asm/tls.h | 4 - arch/arm/kernel/irq.c | 6 +- arch/arm/kernel/signal.c | 55 ++- arch/arm/kernel/smp.c | 28 +- arch/arm/kernel/smp_twd.c | 6 +- arch/arm/mach-exynos/clock-exynos4.c | 24 +- arch/arm/mach-exynos/clock-exynos5.c | 24 +- arch/arm/mach-exynos/common.c | 14 +- arch/arm/mach-exynos/dev-dwmci.c | 13 +- arch/arm/mach-exynos/mach-nuri.c | 1 - arch/arm/mach-exynos/mach-universal_c210.c | 1 - arch/arm/mach-msm/board-msm8x60.c | 25 +- arch/arm/mach-omap2/serial.c | 8 - arch/arm/mach-pxa/include/mach/mfp-pxa2xx.h | 7 - arch/arm/mach-pxa/mfp-pxa2xx.c | 21 +- arch/arm/mach-pxa/pxa27x.c | 6 +- arch/arm/mach-s3c24xx/Kconfig | 8 +- arch/arm/mach-s5pv210/mach-goni.c | 2 - arch/arm/mach-sa1100/generic.c | 2 +- arch/arm/mach-tegra/board-harmony.c | 2 + arch/arm/mach-tegra/board-paz00.c | 3 + arch/arm/mach-tegra/board-seaboard.c | 2 + arch/arm/mach-tegra/board-trimslice.c | 2 + arch/arm/mach-u300/core.c | 6 +- arch/arm/mach-u300/i2c.c | 9 +- arch/arm/mach-u300/include/mach/irqs.h | 150 +++---- arch/arm/mach-ux500/mbox-db5500.c | 2 +- arch/arm/mm/abort-ev6.S | 17 +- arch/arm/mm/cache-l2x0.c | 25 +- arch/arm/mm/init.c | 4 +- arch/arm/mm/mmu.c | 4 +- arch/arm/plat-omap/dma.c | 14 - arch/arm/plat-omap/include/plat/omap-serial.h | 1 - arch/arm/plat-samsung/include/plat/sdhci.h | 28 -- arch/arm/vfp/vfpmodule.c | 99 ----- arch/blackfin/mach-bf538/boards/ezkit.c | 53 +-- arch/hexagon/kernel/dma.c | 1 - arch/hexagon/kernel/process.c | 6 +- arch/hexagon/kernel/ptrace.c | 1 - arch/hexagon/kernel/smp.c | 8 +- arch/hexagon/kernel/time.c | 1 - arch/hexagon/kernel/vdso.c | 1 - arch/mips/ath79/dev-wmac.c | 2 +- arch/mips/include/asm/mach-jz4740/irq.h | 2 +- arch/mips/include/asm/mmu_context.h | 6 + arch/mips/kernel/signal.c | 27 +- arch/mips/kernel/signal32.c | 20 +- arch/mips/kernel/signal_n32.c | 10 +- arch/parisc/kernel/pdc_cons.c | 2 +- arch/powerpc/boot/dts/fsl/pq3-mpic-message-B.dtsi | 43 -- arch/powerpc/boot/dts/fsl/pq3-mpic.dtsi | 10 - arch/powerpc/include/asm/irq.h | 4 + arch/powerpc/include/asm/mpic.h | 18 + arch/powerpc/include/asm/mpic_msgr.h | 1 - arch/powerpc/include/asm/reg_booke.h | 5 + arch/powerpc/kernel/irq.c | 6 +- arch/powerpc/kernel/machine_kexec.c | 7 +- arch/powerpc/kernel/setup_32.c | 3 - arch/powerpc/net/bpf_jit.h | 8 +- arch/powerpc/net/bpf_jit_64.S | 108 +---- arch/powerpc/net/bpf_jit_comp.c | 26 +- arch/powerpc/platforms/85xx/common.c | 6 - arch/powerpc/platforms/85xx/mpc85xx_mds.c | 11 +- arch/powerpc/platforms/85xx/p1022_ds.c | 13 +- arch/powerpc/platforms/cell/axon_msi.c | 8 +- arch/powerpc/platforms/cell/beat_interrupt.c | 2 +- arch/powerpc/platforms/powermac/low_i2c.c | 9 - arch/powerpc/platforms/powermac/pic.c | 6 +- arch/powerpc/platforms/pseries/Kconfig | 4 +- arch/powerpc/platforms/pseries/eeh.c | 2 +- arch/powerpc/sysdev/cpm2_pic.c | 3 +- arch/powerpc/sysdev/mpc8xx_pic.c | 61 ++- arch/powerpc/sysdev/mpic.c | 54 +-- arch/powerpc/sysdev/mpic_msgr.c | 12 +- arch/powerpc/sysdev/scom.c | 1 - arch/powerpc/sysdev/xics/xics-common.c | 7 +- arch/sh/include/asm/atomic.h | 2 +- arch/sh/mm/fault_32.c | 2 +- arch/tile/include/asm/pci.h | 4 +- arch/tile/kernel/pci.c | 4 +- arch/x86/Kconfig | 2 +- arch/x86/boot/compressed/head_32.S | 14 +- arch/x86/boot/compressed/head_64.S | 22 +- arch/x86/boot/compressed/relocs.c | 2 + arch/x86/boot/tools/build.c | 15 +- arch/x86/ia32/ia32_aout.c | 3 +- arch/x86/include/asm/posix_types.h | 6 +- arch/x86/include/asm/sigcontext.h | 2 +- arch/x86/include/asm/siginfo.h | 8 +- arch/x86/include/asm/unistd.h | 6 +- arch/x86/include/asm/word-at-a-time.h | 33 -- arch/x86/include/asm/x86_init.h | 1 + arch/x86/kernel/acpi/sleep.c | 4 - arch/x86/kernel/acpi/sleep.h | 4 - arch/x86/kernel/acpi/wakeup_32.S | 4 +- arch/x86/kernel/acpi/wakeup_64.S | 4 +- arch/x86/kernel/apic/apic.c | 34 +- arch/x86/kernel/apic/apic_numachip.c | 7 +- arch/x86/kernel/apic/x2apic_phys.c | 6 - arch/x86/kernel/cpu/amd.c | 29 +- arch/x86/kernel/cpu/common.c | 9 + arch/x86/kernel/cpu/intel_cacheinfo.c | 8 +- arch/x86/kernel/i387.c | 1 - arch/x86/kernel/microcode_amd.c | 12 +- arch/x86/kernel/microcode_core.c | 10 +- arch/x86/kernel/x86_init.c | 1 + arch/x86/platform/geode/net5501.c | 2 +- arch/x86/platform/mrst/mrst.c | 4 +- arch/x86/xen/enlighten.c | 4 +- arch/x86/xen/smp.c | 15 - arch/x86/xen/xen-asm.S | 2 +- arch/xtensa/include/asm/hardirq.h | 3 + arch/xtensa/include/asm/io.h | 1 - arch/xtensa/kernel/signal.c | 1 - drivers/acpi/power.c | 2 +- drivers/acpi/scan.c | 17 +- drivers/acpi/sleep.c | 52 +-- drivers/ata/ahci.c | 2 - drivers/ata/ahci_platform.c | 1 - drivers/ata/libata-core.c | 2 +- drivers/ata/libata-eh.c | 3 +- drivers/ata/libata-scsi.c | 38 +- drivers/ata/pata_arasan_cf.c | 4 +- drivers/bcma/sprom.c | 7 +- drivers/bluetooth/ath3k.c | 4 - drivers/bluetooth/btusb.c | 6 - drivers/dma/amba-pl08x.c | 1 - drivers/dma/at_hdmac.c | 4 + drivers/dma/imx-dma.c | 9 +- drivers/dma/mxs-dma.c | 10 +- drivers/dma/pl330.c | 25 +- drivers/dma/ste_dma40.c | 323 +++++--------- drivers/dma/ste_dma40_ll.h | 2 + drivers/firmware/efivars.c | 196 -------- drivers/gpio/gpio-pxa.c | 21 +- drivers/gpu/drm/exynos/exynos_drm_gem.c | 30 +- drivers/gpu/drm/i915/i915_debugfs.c | 3 - drivers/gpu/drm/i915/i915_dma.c | 15 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 8 +- drivers/gpu/drm/i915/i915_reg.h | 1 - drivers/gpu/drm/i915/intel_crt.c | 29 +- drivers/gpu/drm/i915/intel_display.c | 9 +- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_lvds.c | 4 +- drivers/gpu/drm/i915/intel_ringbuffer.c | 8 - drivers/gpu/drm/i915/intel_sdvo.c | 34 +- drivers/gpu/drm/nouveau/nouveau_acpi.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bios.c | 10 +- drivers/gpu/drm/nouveau/nouveau_hdmi.c | 4 +- drivers/gpu/drm/nouveau/nv10_gpio.c | 2 +- drivers/gpu/drm/nouveau/nvc0_fb.c | 5 - drivers/gpu/drm/radeon/atombios_crtc.c | 7 +- drivers/gpu/drm/radeon/radeon_device.c | 4 +- drivers/gpu/drm/radeon/radeon_display.c | 3 +- drivers/hsi/clients/hsi_char.c | 2 +- drivers/hsi/hsi.c | 223 +++++----- drivers/hwmon/ad7314.c | 12 +- drivers/hwmon/coretemp.c | 6 +- drivers/hwmon/fam15h_power.c | 9 +- drivers/i2c/busses/i2c-eg20t.c | 4 +- drivers/i2c/busses/i2c-mxs.c | 8 +- drivers/i2c/busses/i2c-pnx.c | 3 +- drivers/i2c/busses/i2c-tegra.c | 8 - drivers/infiniband/core/mad.c | 8 +- drivers/infiniband/hw/mlx4/main.c | 2 +- drivers/input/mouse/synaptics.c | 3 +- drivers/isdn/i4l/isdn_common.c | 5 - drivers/isdn/i4l/isdn_tty.c | 466 ++++++++------------ drivers/md/bitmap.c | 3 +- drivers/md/bitmap.h | 3 + drivers/md/dm-raid.c | 4 +- drivers/md/md.c | 7 +- drivers/mfd/omap-usb-host.c | 1 - drivers/mmc/host/mxs-mmc.c | 3 - drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 - drivers/net/arcnet/arc-rimi.c | 8 +- drivers/net/caif/caif_hsi.c | 9 +- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 - drivers/net/dummy.c | 6 +- drivers/net/ethernet/atheros/atlx/atl1.c | 12 +- drivers/net/ethernet/atheros/atlx/atl1.h | 3 +- drivers/net/ethernet/atheros/atlx/atlx.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 12 +- drivers/net/ethernet/broadcom/tg3.c | 18 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 92 ++-- drivers/net/ethernet/dlink/dl2k.c | 52 ++- drivers/net/ethernet/dlink/dl2k.h | 7 + drivers/net/ethernet/freescale/ucc_geth.c | 6 +- drivers/net/ethernet/freescale/ucc_geth.h | 2 +- drivers/net/ethernet/ibm/ehea/ehea_main.c | 60 ++- drivers/net/ethernet/ibm/ehea/ehea_phyp.h | 2 +- drivers/net/ethernet/intel/e1000e/ich8lan.c | 15 +- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- drivers/net/ethernet/intel/e1000e/param.c | 99 ++--- drivers/net/ethernet/intel/igbvf/netdev.c | 4 +- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 1 - drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 10 - drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 29 +- drivers/net/ethernet/marvell/sky2.c | 31 +- drivers/net/ethernet/marvell/sky2.h | 1 + drivers/net/ethernet/micrel/ks8851.c | 21 +- drivers/net/ethernet/micrel/ks8851_mll.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 2 +- drivers/net/ethernet/realtek/8139cp.c | 10 +- drivers/net/ethernet/smsc/smsc911x.c | 17 +- drivers/net/ethernet/sun/sungem.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 2 +- drivers/net/ethernet/ti/davinci_mdio.c | 5 - drivers/net/ethernet/ti/tlan.c | 2 +- drivers/net/ethernet/xilinx/xilinx_axienet.h | 4 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +- drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 6 +- drivers/net/hyperv/netvsc_drv.c | 38 +- drivers/net/phy/icplus.c | 12 +- drivers/net/ppp/ppp_generic.c | 15 +- drivers/net/usb/asix.c | 4 +- drivers/net/usb/hso.c | 105 ++--- drivers/net/usb/qmi_wwan.c | 30 -- drivers/net/usb/smsc75xx.c | 36 +- drivers/net/usb/smsc95xx.c | 3 +- drivers/net/usb/usbnet.c | 5 +- drivers/net/virtio_net.c | 5 +- drivers/net/wan/farsync.c | 1 - drivers/net/wireless/ath/ath5k/ahb.c | 8 +- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 2 +- drivers/net/wireless/ath/ath9k/ar9003_paprd.c | 2 +- drivers/net/wireless/ath/ath9k/ar9003_phy.c | 2 +- drivers/net/wireless/ath/ath9k/eeprom_9287.c | 2 - drivers/net/wireless/ath/ath9k/hw.c | 9 +- drivers/net/wireless/ath/ath9k/hw.h | 3 +- drivers/net/wireless/ath/ath9k/main.c | 9 +- drivers/net/wireless/ath/ath9k/xmit.c | 10 +- drivers/net/wireless/b43/main.c | 10 +- .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 8 +- drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 63 +-- drivers/net/wireless/brcm80211/brcmsmac/main.c | 11 +- drivers/net/wireless/ipw2x00/ipw2200.c | 13 +- drivers/net/wireless/iwlwifi/iwl-1000.c | 8 +- drivers/net/wireless/iwlwifi/iwl-2000.c | 16 +- drivers/net/wireless/iwlwifi/iwl-5000.c | 11 +- drivers/net/wireless/iwlwifi/iwl-6000.c | 10 +- drivers/net/wireless/iwlwifi/iwl-agn.c | 3 + drivers/net/wireless/iwlwifi/iwl-fh.h | 24 +- drivers/net/wireless/iwlwifi/iwl-mac80211.c | 10 +- drivers/net/wireless/iwlwifi/iwl-prph.h | 27 +- drivers/net/wireless/libertas/cfg.c | 9 +- drivers/net/wireless/mwifiex/pcie.h | 18 +- drivers/net/wireless/rtlwifi/pci.c | 1 - drivers/net/wireless/wl1251/main.c | 1 - drivers/net/wireless/wl1251/sdio.c | 2 +- drivers/pci/Makefile | 1 - drivers/pci/pci-acpi.c | 4 +- drivers/platform/x86/acerhdf.c | 67 +-- drivers/platform/x86/dell-laptop.c | 1 - drivers/platform/x86/intel_ips.c | 2 +- drivers/platform/x86/intel_mid_powerbtn.c | 2 +- drivers/rtc/rtc-ds1307.c | 1 - drivers/rtc/rtc-mpc5121.c | 3 +- drivers/s390/char/con3215.c | 142 +++--- drivers/s390/char/keyboard.c | 30 +- drivers/s390/char/keyboard.h | 14 +- drivers/s390/char/sclp_tty.c | 33 +- drivers/s390/char/sclp_vt220.c | 33 +- drivers/s390/char/tty3270.c | 121 +++-- drivers/s390/net/qeth_core_main.c | 6 +- drivers/scsi/ipr.c | 6 +- drivers/scsi/libfc/fc_lport.c | 12 +- drivers/scsi/libsas/sas_ata.c | 33 +- drivers/scsi/libsas/sas_discover.c | 61 ++- drivers/scsi/libsas/sas_event.c | 24 +- drivers/scsi/libsas/sas_expander.c | 56 +-- drivers/scsi/libsas/sas_init.c | 11 +- drivers/scsi/libsas/sas_internal.h | 6 +- drivers/scsi/libsas/sas_phy.c | 21 +- drivers/scsi/libsas/sas_port.c | 17 +- drivers/scsi/scsi_lib.c | 2 +- drivers/spi/Kconfig | 2 +- drivers/spi/Makefile | 2 +- drivers/spi/spi-bcm63xx.c | 163 +++---- drivers/spi/spi-bfin-sport.c | 21 +- drivers/spi/spi-bfin5xx.c | 14 +- drivers/spi/spi-ep93xx.c | 24 +- drivers/spi/spi-pl022.c | 58 +-- drivers/staging/octeon/ethernet-rx.c | 1 - drivers/staging/octeon/ethernet-tx.c | 1 - drivers/staging/octeon/ethernet.c | 1 - drivers/staging/ozwpan/ozpd.c | 2 + drivers/staging/serial/68360serial.c | 4 +- drivers/staging/tidspbridge/core/tiomap3430.c | 20 +- drivers/staging/tidspbridge/core/wdt.c | 8 +- drivers/staging/zcache/Kconfig | 2 +- drivers/tty/amiserial.c | 14 +- drivers/tty/bfin_jtag_comm.c | 44 +- drivers/tty/cyclades.c | 2 +- drivers/tty/hvc/hvc_console.c | 96 ++-- drivers/tty/hvc/hvc_console.h | 4 +- drivers/tty/hvc/hvc_xen.c | 4 +- drivers/tty/hvc/hvcs.c | 74 ++-- drivers/tty/hvc/hvsi.c | 128 +++--- drivers/tty/hvc/hvsi_lib.c | 2 +- drivers/tty/ipwireless/tty.c | 81 ++-- drivers/tty/mxser.c | 2 +- drivers/tty/n_r3964.c | 11 +- drivers/tty/n_tty.c | 9 +- drivers/tty/pty.c | 40 +- drivers/tty/serial/68328serial.c | 383 +++++++--------- drivers/tty/serial/68328serial.h | 186 -------- drivers/tty/serial/8250/8250.c | 312 +++++++------ drivers/tty/serial/8250/8250.h | 16 + drivers/tty/serial/8250/8250_em.c | 186 ++++++++ drivers/tty/serial/8250/8250_pci.c | 63 +++ drivers/tty/serial/8250/Kconfig | 8 + drivers/tty/serial/8250/Makefile | 1 + drivers/tty/serial/amba-pl011.c | 109 +---- drivers/tty/serial/bfin_uart.c | 74 ++-- drivers/tty/serial/crisv10.c | 36 +- drivers/tty/serial/mxs-auart.c | 2 + drivers/tty/serial/of_serial.c | 26 ++ drivers/tty/serial/omap-serial.c | 74 +++- drivers/tty/serial/pch_uart.c | 53 ++- drivers/tty/serial/pmac_zilog.c | 6 +- drivers/tty/serial/serial_core.c | 1 + drivers/tty/synclink.c | 4 +- drivers/tty/synclink_gt.c | 4 +- drivers/tty/synclinkmp.c | 4 +- drivers/tty/tty_buffer.c | 85 +++- drivers/tty/tty_io.c | 76 ++-- drivers/tty/tty_ldisc.c | 37 +- drivers/tty/tty_mutex.c | 60 ++- drivers/tty/tty_port.c | 6 +- drivers/tty/vt/consolemap.c | 123 ++++-- drivers/tty/vt/keyboard.c | 28 +- drivers/tty/vt/vt.c | 68 ++- drivers/tty/vt/vt_ioctl.c | 25 +- drivers/usb/class/cdc-wdm.c | 7 +- drivers/usb/core/hcd-pci.c | 9 - drivers/usb/gadget/dummy_hcd.c | 1 + drivers/usb/gadget/f_mass_storage.c | 2 +- drivers/usb/gadget/file_storage.c | 2 +- drivers/usb/gadget/u_serial.c | 51 +-- drivers/usb/gadget/udc-core.c | 4 +- drivers/usb/gadget/uvc.h | 2 +- drivers/usb/gadget/uvc_v4l2.c | 2 +- drivers/usb/host/ehci-pci.c | 8 - drivers/usb/host/ehci-tegra.c | 376 ++++++++-------- drivers/usb/musb/davinci.c | 3 +- drivers/usb/musb/musb_core.h | 2 +- drivers/usb/otg/gpio_vbus.c | 15 +- drivers/vhost/net.c | 2 +- drivers/vhost/vhost.c | 5 +- drivers/vhost/vhost.h | 2 +- drivers/video/bfin-lq035q1-fb.c | 1 - drivers/watchdog/hpwdt.c | 6 +- drivers/xen/events.c | 2 +- drivers/xen/xen-acpi-processor.c | 5 +- fs/autofs4/autofs_i.h | 12 +- fs/autofs4/dev-ioctl.c | 3 +- fs/autofs4/inode.c | 4 +- fs/autofs4/waitq.c | 22 +- fs/btrfs/backref.c | 27 +- fs/btrfs/ctree.c | 28 +- fs/btrfs/ctree.h | 2 +- fs/btrfs/disk-io.c | 40 +- fs/btrfs/disk-io.h | 3 +- fs/btrfs/extent-tree.c | 17 +- fs/btrfs/extent_io.c | 60 +-- fs/btrfs/extent_io.h | 4 +- fs/btrfs/file.c | 9 +- fs/btrfs/inode.c | 54 ++- fs/btrfs/ioctl.c | 5 +- fs/btrfs/ioctl.h | 4 +- fs/btrfs/reada.c | 48 +- fs/btrfs/relocation.c | 4 +- fs/btrfs/scrub.c | 22 +- fs/btrfs/super.c | 7 +- fs/btrfs/transaction.c | 6 +- fs/btrfs/tree-log.c | 2 +- fs/btrfs/volumes.c | 13 +- fs/buffer.c | 1 + fs/cifs/cifsfs.c | 14 +- fs/cifs/cifsfs.h | 2 +- fs/cifs/cifssmb.c | 6 +- fs/cifs/connect.c | 33 +- fs/cifs/dir.c | 17 +- fs/cifs/file.c | 3 +- fs/dcache.c | 26 +- fs/dlm/lock.c | 12 - fs/eventpoll.c | 4 +- fs/ext4/super.c | 2 - fs/gfs2/lock_dlm.c | 10 +- fs/hfsplus/catalog.c | 4 - fs/hfsplus/dir.c | 11 - fs/hugetlbfs/inode.c | 1 - fs/jbd2/commit.c | 4 +- fs/namei.c | 4 +- fs/nfs/blocklayout/blocklayout.c | 4 +- fs/nfs/client.c | 5 +- fs/nfs/dir.c | 4 +- fs/nfs/idmap.c | 4 - fs/nfs/internal.h | 8 +- fs/nfs/namespace.c | 93 ++-- fs/nfs/nfs4_fs.h | 11 +- fs/nfs/nfs4filelayoutdev.c | 2 +- fs/nfs/nfs4namespace.c | 86 +--- fs/nfs/nfs4proc.c | 186 ++------ fs/nfs/nfs4state.c | 31 +- fs/nfs/nfs4xdr.c | 53 +-- fs/nfs/objlayout/objlayout.c | 2 + fs/nfs/pnfs.c | 2 +- fs/nfs/read.c | 2 +- fs/nfs/super.c | 12 +- fs/nfs/write.c | 5 +- fs/nfsd/nfs4recover.c | 2 +- fs/pipe.c | 31 +- fs/proc/task_mmu.c | 3 + include/acpi/actypes.h | 7 +- include/asm-generic/siginfo.h | 14 +- include/asm-generic/statfs.h | 2 +- include/linux/efi.h | 13 +- include/linux/generic_serial.h | 64 +-- include/linux/gpio-pxa.h | 4 - include/linux/hsi/hsi.h | 31 +- include/linux/irq.h | 7 - include/linux/isdn.h | 26 +- include/linux/libata.h | 3 +- include/linux/netfilter_bridge.h | 9 - include/linux/nfs_xdr.h | 7 +- include/linux/of_serial.h | 17 + include/linux/pipe_fs_i.h | 1 - include/linux/seqlock.h | 23 +- include/linux/serial_8250.h | 2 + include/linux/serial_core.h | 5 + include/linux/skbuff.h | 11 +- include/linux/spi/spi.h | 2 +- include/linux/tty.h | 23 +- include/linux/tty_ldisc.h | 2 + include/linux/usb/hcd.h | 2 - include/linux/vm_event_item.h | 5 +- include/linux/vt_kern.h | 1 - include/net/bluetooth/hci_core.h | 3 +- include/net/dst.h | 7 +- include/net/ip6_fib.h | 48 -- include/net/ip_vs.h | 4 +- include/net/red.h | 6 +- include/net/sock.h | 5 +- include/scsi/libsas.h | 40 +- include/scsi/sas_ata.h | 4 +- init/do_mounts.c | 2 +- init/main.c | 25 +- kernel/events/core.c | 2 +- kernel/irq/debug.h | 38 +- kernel/power/swap.c | 28 +- kernel/rcutree.c | 1 + kernel/sched/core.c | 22 +- kernel/sched/fair.c | 18 +- kernel/sched/features.h | 1 - kernel/time/tick-broadcast.c | 13 +- kernel/trace/trace.c | 8 +- kernel/trace/trace.h | 4 +- kernel/trace/trace_output.c | 5 - mm/hugetlb.c | 2 +- mm/memcontrol.c | 17 +- mm/mempolicy.c | 11 +- mm/migrate.c | 16 +- mm/nobootmem.c | 10 +- mm/swap_state.c | 2 +- mm/vmscan.c | 11 +- mm/vmstat.c | 4 +- net/ax25/af_ax25.c | 9 +- net/bluetooth/hci_core.c | 27 +- net/bluetooth/hci_event.c | 3 - net/bluetooth/mgmt.c | 2 +- net/bluetooth/rfcomm/tty.c | 137 +++--- net/bridge/br_forward.c | 1 - net/bridge/br_netfilter.c | 8 +- net/caif/chnl_net.c | 9 +- net/core/dev.c | 20 - net/core/drop_monitor.c | 89 +--- net/core/net_namespace.c | 33 +- net/ieee802154/6lowpan.c | 40 +- net/ipv4/inet_diag.c | 2 +- net/ipv4/tcp.c | 9 +- net/ipv4/tcp_input.c | 14 +- net/ipv4/tcp_output.c | 1 - net/ipv4/udp_diag.c | 9 - net/ipv6/addrconf.c | 9 +- net/ipv6/ip6_fib.c | 9 +- net/ipv6/ndisc.c | 3 +- net/ipv6/route.c | 71 ++- net/ipv6/tcp_ipv6.c | 4 - net/key/af_key.c | 2 +- net/l2tp/l2tp_ip.c | 8 +- net/mac80211/ibss.c | 4 +- net/mac80211/ieee80211_i.h | 2 +- net/mac80211/iface.c | 4 +- net/mac80211/mlme.c | 2 +- net/mac80211/rx.c | 10 +- net/mac80211/tx.c | 3 +- net/netfilter/ipvs/ip_vs_core.c | 11 - net/netfilter/ipvs/ip_vs_ctl.c | 56 +-- net/netfilter/ipvs/ip_vs_ftp.c | 2 - net/netfilter/ipvs/ip_vs_lblc.c | 3 - net/netfilter/ipvs/ip_vs_lblcr.c | 3 - net/netfilter/ipvs/ip_vs_proto.c | 38 +- net/netfilter/ipvs/ip_vs_proto_sctp.c | 5 +- net/netfilter/ipvs/ip_vs_proto_tcp.c | 5 +- net/netfilter/ipvs/ip_vs_proto_udp.c | 5 +- net/netfilter/xt_CT.c | 2 +- net/phonet/pn_dev.c | 21 +- net/sched/sch_gred.c | 7 +- net/sched/sch_netem.c | 6 +- net/sunrpc/clnt.c | 50 +-- net/sunrpc/rpc_pipe.c | 3 +- net/sunrpc/sunrpc_syms.c | 17 +- net/wireless/util.c | 2 +- scripts/mod/file2alias.c | 4 - sound/pci/hda/patch_realtek.c | 1 - sound/soc/blackfin/bf5xx-ssm2602.c | 2 - sound/soc/codecs/cs42l73.c | 2 - sound/soc/codecs/tlv320aic23.c | 4 +- sound/soc/codecs/wm8350.c | 11 +- sound/soc/codecs/wm8994.c | 276 +++--------- sound/soc/codecs/wm_hubs.c | 15 +- sound/soc/omap/omap-pcm.c | 4 - sound/soc/samsung/s3c2412-i2s.c | 2 +- sound/soc/sh/fsi.c | 7 +- sound/soc/soc-core.c | 7 +- sound/soc/soc-dapm.c | 2 - tools/perf/Makefile | 4 +- tools/perf/builtin-report.c | 17 +- tools/perf/builtin-test.c | 30 -- tools/perf/util/parse-events.l | 2 +- tools/perf/util/symbol.c | 13 +- tools/testing/ktest/ktest.pl | 12 +- 552 files changed, 4698 insertions(+), 6763 deletions(-) delete mode 100644 Documentation/ABI/testing/sysfs-bus-hsi rename Documentation/devicetree/bindings/ata/{ahci-platform.txt =&gt; calxeda-sata.txt} (90%) delete mode 100644 arch/powerpc/boot/dts/fsl/pq3-mpic-message-B.dtsi delete mode 100644 drivers/tty/serial/68328serial.h create mode 100644 drivers/tty/serial/8250/8250_em.c create mode 100644 include/linux/of_serial.h --------------- Alan Cox (7): vt: push the tty_lock down into the map handling tty_lock: undo the old tty_lock use on the ctty pty: Lock the devpts bits privately tty_lock: Localise the lock tty: drop the pty lock during hangup tty: Allow uart_register/unregister/register tty: Fix LED error return Arnaud Patard (1): 8250_pci: fix pch uart matching Christian Melki (1): 8250.c: less than 2400 baud fix. Corbin Atkinson (1): serial_core: Update buffer overrun statistics. Dan Carpenter (1): tty: hvc_xen: NULL dereference on allocation failure Dan Williams (2): tegra, serial8250: add -&gt;handle_break() uart_port op serial/8250_pci: fix suspend/resume vs init/exit quirks Geert Uytterhoeven (1): tty/amiserial: Add missing argument for tty_unlock() Govindraj.R (1): OMAP2+: UART: Remove cpu checks for populating errata flags Greg Kroah-Hartman (1): Revert "serial_core: Update buffer overrun statistics." H Hartley Sweeten (1): tty: mxser: local variables should not be exposed globally Heiko Carstens (1): tty: add missing tty_port_tty_get() call to raw3215_wakeup Ivo Sieben (1): tty: move global ldisc idle waitqueue to the individual ldisc Jiri Slaby (71): TTY: crisv10, remove unused tmp_buf TTY: crisv10, initialize tty_port TTY: deprecate linux/generic_serial.h ISDN: i4l, remove cvs crap TTY: isdn, remove callout TTY: isdn, remove ISDN_ASYNC_* flags TTY: isdn, do not play with module refcounts TTY: isdn, make some functions readable TTY: isdn, remove unused members from modem_info TTY: isdn, add tty_port TTY: isdn, use open/close_wait from tty_port TTY: isdn, use counts from tty_port TTY: isdn, use tty from tty_port TTY: isdn, use xmit_buf from tty_port TTY: isdn, define local tty_port TTY: isdn, use tty_port_close_end helper TTY: isdn, define tty_port_operations TTY: isdn, use tty_port_block_til_ready helper TTY: hso, do not set TTY MAGIC TTY: hso, free tty_driver TTY: hso, add tty_port TTY: hso, remove tty NULL checks fro tty-&gt;ops TTY: hso, use tty from tty_port TTY: con3215, centralize allocation TTY: sclp_tty, add tty_port TTY: sclp_vt220, add tty_port TTY: sclp_vt220, remove unused allocation TTY: tty3270, move initialization to allocation TTY: tty3270, get rid of ugly aliasing TTY: tty3270, push tty down to tty3270_do_write TTY: tty3270, add tty_port TTY: bfin_jtag_comm, add tty_port TTY: bfin_jtag_comm, use tty from tty_port TTY: HVC, add tty_port TTY: HVC, use tty from tty_port TTY: HVC, use count from tty_port TTY: hvcs, add tty_port TTY: hvcs, use kref from tty_port TTY: hvcs, use tty from tty_port TTY: hvsi, CLOCAL is not in tty-&gt;flags TTY: hvsi, add tty_port TTY: hvsi, sanitize uses of tty TTY: hvsi, use tty from tty_port TTY: ipwireless, use synchronous hangup TTY: ipwireless, move prints to appropriate places TTY: ipwireless, add tty_port TTY: ipwireless, use tty from tty_port TTY: 68328serial, remove serial_state and friends TTY: 68328serial, remove unused stuff from m68k_serial TTY: 68328serial, remove garbage TTY: 68328serial, use ulong flags for interrupts status TTY: 68328serial, remove 68328serial.h TTY: 68328serial, add tty_port TTY: 68328serial, use open/close_wait from tty_port TTY: 68328serial, use close_delay/closing_wait from tty_port TTY: 68328serial, use flags from tty_port TTY: 68328serial, propagate tty TTY: 68328serial, use tty from tty_port TTY: 68328serial, use tty_port_block_til_ready TTY: usb/u_serial, add tty_port TTY: usb/u_serial, use tty from tty_port TTY: usb/u_serial use close_wait from tty_port TTY: rfcomm/tty, add tty_port TTY: rfcomm/tty, use tty_port refcounting TTY: rfcomm/tty, remove work for tty_wakeup TTY: rfcomm/tty, use count from tty_port ISDN: remove uses of isdn_tty_revision TTY: hvc, fix TTY refcounting TTY: con3215, add tty_port TTY: con3215, use tty from tty_port TTY: n_tty, do not dereference user buffer Lothar Waßmann (1): Add missing call to uart_update_timeout() Magnus Damm (8): serial8250: Add dl_read()/dl_write() callbacks serial8250: Use dl_read()/dl_write() on Alchemy serial8250: Use dl_read()/dl_write() on RM9K serial8250: Clean up default map and dl code serial8250: Introduce serial8250_register_8250_port() serial8250-em: Emma Mobile UART driver V2 serial8250-em: clk_get() IS_ERR() error handling fix serial8250-em: Add DT support Michael Gehring (1): tty/vt: handle bad user buffer in {G,P}IO_CMAP ioctl Paul Gortmaker (1): cris: fix missing tty arg in wait_event_interruptible_tty call Rajanikanth H.V (1): serial: pl011: implement workaround for CTS clear event issue Sonic Zhang (4): serial: bfin_uart: Adapt bf5xx serial driver to bf60x serial4 controller. serial: bfin_uart: narrow the reboot condition in DMA tx interrupt serial: bfin_uart: RTS and CTS MMRs can be either 16-bit width or 32-bit width. serial: bfin_uart: Make MMR access compatible with 32 bits bf609 style controller. Sudhakar Mamillapalli (1): serial/8250_pci: Clear FIFOs for Intel ME Serial Over Lan device on BI Tomoya MORINAGA (7): pch_uart: Delete unused structure member pch_uart: change type to u8 pch_uart: change type to %d to %02x pch_uart: Support modem status interrupt pch_uart: delete unused data structure pch_uart: Fix return value issue pch_uart: Fix duplicate memory release issue Xiaobing Tu (1): tty: hold lock across tty buffer finding and buffer filling -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Greg KH 2012-05-22T13:20:06 Fwd: struct tty_flip_buffer replacement in newer kernels http://permalink.gmane.org/gmane.linux.serial/7853 <pre>[Add CCs] -------- Original Message -------- Subject: struct tty_flip_buffer replacement in newer kernels Date: Tue, 22 May 2012 16:17:02 +0400 From: Dmitriy Alekseev &lt;deathonfuneral&lt; at &gt;gmail.com&gt; To: linux-kernel&lt; at &gt;vger.kernel.org Hello I'm newbie, working under existed serial driver, adapting it for 2.6.32. During the compilation I have had several problems, which I succesfully solved except this one: error: 'struct tty_struct' has no member named 'flip' In particular, cound you advice correct replacement of "tty-&gt;flip.count" Thanks </pre> Jack Stone 2012-05-22T12:32:02 [PATCH V2] serial: pxa: add spin lock for console write http://permalink.gmane.org/gmane.linux.serial/7852 <pre>at UP mode, when cpu want to print message in kernel, it will invoke peempt_disable and disable irq. So it is safe for UP mode. For SMP mode, it is not safe to protect the HW reigsters. one CPU will run a program which will invoke printf. another CPU will run a program in kernel that invoke printk. So when second CPU is trying to printk, it will do 1. save ier register 2. enable uue bit of ier register 3. push buffer to uart fifo 4 .restore ier register when first CPU want to printf, and it happens between 1 and 4, it will enable thre bit of ier, and waiting for transmit intterupt. while step 4 will make the ier lost thre bit. add spin lock here to protect the ier register for console write. Signed-off-by: Chao Xie &lt;chao.xie&lt; at &gt;marvell.com&gt; --- drivers/tty/serial/pxa.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c index 5847a4b..aca62f6 100644 --- a/drivers/tty/serial/pxa.c +++ b/drivers/tty/serial/pxa.c &lt; at &gt;&lt; at &gt; -670,9 +670,19 &lt; at &gt;&lt; at &gt; serial_pxa_console_write(struct console *co, const char *s, unsigned int count) { struct uart_pxa_port *up = serial_pxa_ports[co-&gt;index]; unsigned int ier; +unsigned long flags; +int locked = 1; clk_prepare_enable(up-&gt;clk); +local_irq_save(flags); +if (up-&gt;port.sysrq) +locked = 0; +else if (oops_in_progress) +locked = spin_trylock(&amp;up-&gt;port.lock); +else +spin_lock(&amp;up-&gt;port.lock); + /* *First save the IER then disable the interrupts */ &lt; at &gt;&lt; at &gt; -688,7 +698,12 &lt; at &gt;&lt; at &gt; serial_pxa_console_write(struct console *co, const char *s, unsigned int count) wait_for_xmitr(up); serial_out(up, UART_IER, ier); +if (locked) +spin_unlock(&amp;up-&gt;port.lock); +local_irq_restore(flags); + clk_disable_unprepare(up-&gt;clk); + } static int __init </pre> Chao Xie 2012-05-22T04:43:00 RE: [PATCH] serial: pxa: add spin lock for console write http://permalink.gmane.org/gmane.linux.serial/7851 <pre>int clk_prepare(struct clk *clk) { int ret; mutex_lock(&amp;prepare_lock); ret = __clk_prepare(clk); mutex_unlock(&amp;prepare_lock); return ret; } EXPORT_SYMBOL_GPL(clk_prepare); So invoking local_irq_save() before clk_prepare_enable() is wrong behavior. Regards Haojian ________________________________________ From: Chao Xie [chao.xie&lt; at &gt;marvell.com] Sent: Monday, May 21, 2012 10:33 AM To: linux-serial&lt; at &gt;vger.kernel.org; Haojian Zhuang Cc: Chao Xie Subject: [PATCH] serial: pxa: add spin lock for console write at UP mode, when cpu want to print message in kernel, it will invoke peempt_disable and disable irq. So it is safe for UP mode. For SMP mode, it is not safe to protect the HW reigsters. one CPU will run a program which will invoke printf. another CPU will run a program in kernel that invoke printk. So when second CPU is trying to printk, it will do 1. save ier register 2. enable uue bit of ier register 3. push buffer to uart fifo 4 .restore ier register when first CPU want to printf, and it happens between 1 and 4, it will enable thre bit of ier, and waiting for transmit intterupt. while step 4 will make the ier lost thre bit. add spin lock here to protect the ier register for console write. Signed-off-by: Chao Xie &lt;chao.xie&lt; at &gt;marvell.com&gt; --- drivers/tty/serial/pxa.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/tty/serial/pxa.c b/drivers/tty/serial/pxa.c index 5847a4b..d94387f 100644 --- a/drivers/tty/serial/pxa.c +++ b/drivers/tty/serial/pxa.c &lt; at &gt;&lt; at &gt; -670,6 +670,16 &lt; at &gt;&lt; at &gt; serial_pxa_console_write(struct console *co, const char *s, unsigned int count) { struct uart_pxa_port *up = serial_pxa_ports[co-&gt;index]; unsigned int ier; + unsigned long flags; + int locked = 1; + + local_irq_save(flags); + if (up-&gt;port.sysrq) + locked = 0; + else if (oops_in_progress) + locked = spin_trylock(&amp;up-&gt;port.lock); + else + spin_lock(&amp;up-&gt;port.lock); clk_prepare_enable(up-&gt;clk); &lt; at &gt;&lt; at &gt; -689,6 +699,11 &lt; at &gt;&lt; at &gt; serial_pxa_console_write(struct console *co, const char *s, unsigned int count) serial_out(up, UART_IER, ier); clk_disable_unprepare(up-&gt;clk); + + if (locked) + spin_unlock(&amp;up-&gt;port.lock); + local_irq_restore(flags); + } static int __init -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Haojian Zhuang 2012-05-22T03:07:16 [PATCH] serial/imx: make devdata member point to const data http://permalink.gmane.org/gmane.linux.serial/7850 <pre>This is only cosmetic for now. In case that http://mid.gmane.org/1335171381-24869-1-git-send-email-u.kleine-koenig&lt; at &gt;pengutronix.de will be applied, it fixes a warning drivers/tty/serial/imx.c: In function 'serial_imx_probe_dt': drivers/tty/serial/imx.c:1430:17: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] though. Signed-off-by: Uwe Kleine-König &lt;u.kleine-koenig&lt; at &gt;pengutronix.de&gt; --- drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index e7fecee..d409bbb 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c &lt; at &gt;&lt; at &gt; -205,7 +205,7 &lt; at &gt;&lt; at &gt; struct imx_port { unsigned intirda_inv_tx:1; unsigned shorttrcv_delay; /* transceiver delay */ struct clk*clk; -struct imx_uart_data*devdata; +const struct imx_uart_data *devdata; }; struct imx_port_ucrs { </pre> Uwe Kleine-König 2012-05-21T19:57:39 Re: [PATCH 1/1] serial_core: Update buffer overrun statistics. http://permalink.gmane.org/gmane.linux.serial/7849 <pre> I was hopng Jiri would chip in. If you think its important and want to argue for it, I'm not going to fight against it. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Alan Cox 2012-05-21T16:05:53 Re: [PATCH 1/1] serial_core: Update buffer overrun statistics. http://permalink.gmane.org/gmane.linux.serial/7848 <pre>meaning. Has anyone had a chance to think about this anymore? We would really like the capability to recognize that data has been discarded, even if it is because no flow control is used and the user is ignoring the port. There are cases, such as with RS-485, where there is no real flow control mechanism is available, so we should not depend on flow-control as always being an option. As Corbin mentioned, there are some other drivers using buf_overrun (as opposed to overrun, which indicates FIFO overruns) for this purpose, but we don't know if this was the original intention of this field. -Jason -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo&lt; at &gt;vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html </pre> Jason Smith 2012-05-21T15:12:01 Search Engine Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.serial