http://blog.gmane.org/gmane.linux.kernel.cryptoapi hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8913 <pre>On Wed, May 15, 2013 at 10:14 PM, Fabio Baltieri &lt;fabio.baltieri&lt; at &gt;linaro.org&gt; wrote: OK so Felipe can merge these smallish patches to musb, fine... The other (DMA) stuff needs to be merged together with the rest of the DMA40 series, so here basically Felipe needs an indication if he can ACK it so I merge it through ARM SoC without colissions and it sounds like we can make the assumption that this will work. Yours, Linus Walleij </pre> Linus Walleij 2013-05-17T06:35:04 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8912 <pre>2013/5/17 Tim Chen &lt;tim.c.chen&lt; at &gt;linux.intel.com&gt;: cool. </pre> Xiong Zhou 2013-05-17T03:09:54 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8911 <pre>2013/5/16 Geert Uytterhoeven &lt;geert&lt; at &gt;linux-m68k.org&gt;: En.. make sense, Thanks. Xiong </pre> Xiong Zhou 2013-05-17T03:06:06 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8909 <pre> This is the fix I think that will resolve the build issues. The generic crc-t10dif transform depends on the library function crc_t10dif_generic in lib/crc-t10dif.c, so "depends on CRC_T10DIF" for CRYPTO_CRCT10DIF is needed. Now for CRC_T10DIF, we should use select CRYPTO_HASH, so it can try to allocate a T10DIF transform if it is available. If not, it will simply use the crc_t10dif_generic function. Loading the generic t10dif crypto transform is not mandatory for the library function crc_t10dif. Thanks for catching the issues. Tim Signed-off-by: Tim Chen &lt;tim.c.chen&lt; at &gt;linux.intel.com&gt; --- diff --git a/crypto/Kconfig b/crypto/Kconfig index d1ca631..015df24 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig &lt; at &gt;&lt; at &gt; -379,6 +379,7 &lt; at &gt;&lt; at &gt; config CRYPTO_CRC32_PCLMUL config CRYPTO_CRCT10DIF tristate "CRCT10DIF algorithm" select CRYPTO_HASH +depends on CRC_T10DIF help CRC T10 Data Integrity Field computation is being cast as a crypto transform. This allows for faster crc t10 diff diff --git a/lib/Kconfig b/lib/Kconfig index 0cee056..e6ad2e4 100644 --- a/lib/Kconfig +++ b/lib/Kconfig &lt; at &gt;&lt; at &gt; -63,7 +63,7 &lt; at &gt;&lt; at &gt; config CRC16 config CRC_T10DIF tristate "CRC calculation for the T10 Data Integrity Field" -select CRYPTO_CRCT10DIF +select CRYPTO_HASH help This option is only needed if a module that's not in the kernel tree needs to calculate CRC checks for use with the </pre> Tim Chen 2013-05-16T16:59:12 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8908 <pre> I think "depends on" CRC_T10DIF is okay. This generic transform is not needed if we are not using the T10-DIF library. It is meant for wrapping the library call to t10-dif as a crypto transform. </pre> Tim Chen 2013-05-16T16:09:54 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8907 <pre>Hello, I have an encrypted disc (dm-crypt, type LUKS1, ssh256 as hash algorithm). I have an Intel Core i5 M450 that supports ssse3. Find below the output from netconsole with the oops. The last warning appeared when I restart the pc using the magic sysrq key combination REISUB. I have the same problem with a different laptop with an AMD E-450 APU. If you need further information, feel free to ask. Best regards, Julian Wollrath [ 3.647071] device-mapper: uevent: version 1.0.3 [ 3.647245] device-mapper: ioctl: 4.24.0-ioctl (2013-01-15) initialised: dm-devel&lt; at &gt;redhat.com [ 11.619603] sha256_ssse3: Using SSSE3 optimized SHA-256 implementation [ 12.131483] BUG: unable to handle kernel paging request at ffff8800bb593000 [ 12.131848] IP: [&lt;ffffffffa016b083&gt;] loop0+0x27/0x44 [sha256_ssse3] [ 12.132032] PGD 1a32067 PUD 1a35067 PMD 1a36067 PTE 0 [ 12.132427] Oops: 0000 [#1] SMP [ 12.132670] Modules linked in: sha256_ssse3(+) sha256_generic twofish_generic twofish_x86_64_3way xts lrw gf128mul glue_helper twofish_x86_64 twofish_common cbc dm_crypt dm_mod netconsole sg sr_mod sd_mod cdrom crc_t10dif crc32c_intel microcode ahci libahci ehci_pci ehci_hcd libata scsi_mod r8169 mii usbcore usb_common thermal thermal_sys [ 12.135396] CPU: 3 PID: 276 Comm: cryptomgr_test Not tainted 3.10.0-rc1+ #2 [ 12.135559] Hardware name: Dell Inc. Vostro 3500/0NVXFV, BIOS A10 10/25/2010 [ 12.135720] task: ffff880037572090 ti: ffff8800b66b6000 task.ti: ffff8800b66b6000 [ 12.135836] RIP: 0010:[&lt;ffffffffa016b083&gt;] [&lt;ffffffffa016b083&gt;] loop0+0x27/0x44 [sha256_ssse3] [ 12.136032] RSP: 0018:ffff8800b66b7af0 EFLAGS: 00010287 [ 12.136130] RAX: 00000000a186fc15 RBX: 00000000704bb939 RCX: 00000000d1b791ec [ 12.136232] RDX: 000000001fd2088a RSI: ffff880037a97ee8 RDI: ffff8800bb592fc8 [ 12.136334] RBP: ffffffffa016f000 R08: 0000000052a5c3c8 R09: 000000005db427ef [ 12.136439] R10: 00000000b80a833e R11: 0000000029c53567 R12: ffff8800b66b7b08 [ 12.136543] R13: 000000003158a213 R14: 00000000c7fc368e R15: 0000000001008012 [ 12.136647] FS: 0000000000000000(0000) GS:ffff8800bb180000(0000) knlGS:0000000000000000 [ 12.136763] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 12.136863] CR2: ffff8800bb593000 CR3: 000000000180b000 CR4: 00000000000007e0 [ 12.136964] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 12.137066] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 12.137167] Stack: [ 12.137257] ffff880108c634c8 ffff8800bb592f88 6033fb357b8c96fd c5e119eaebeb38a3 [ 12.137668] ffff880037a97f08 ffff8800b66b7b80 0000000000000008 0000000000000008 [ 12.138077] ffff880037a97ed0 ffffffffa016dc4e ffff880001496ae5 ffff880037a97ee0 [ 12.138484] Call Trace: [ 12.138580] [&lt;ffffffffa016dc4e&gt;] ? __sha256_ssse3_update+0x5e/0xe0 [sha256_ssse3] [ 12.138701] [&lt;ffffffffa016df15&gt;] ? sha256_ssse3_final+0x145/0x1ec [sha256_ssse3] [ 12.138825] [&lt;ffffffff81214362&gt;] ? shash_ahash_finup+0x32/0x80 [ 12.138931] [&lt;ffffffff81217523&gt;] ? test_hash+0x383/0x6b0 [ 12.139034] [&lt;ffffffff8120c8a0&gt;] ? crypto_mod_get+0x10/0x30 [ 12.139141] [&lt;ffffffff811186d6&gt;] ? __kmalloc+0x1c6/0x1f0 [ 12.139243] [&lt;ffffffff8120cdfc&gt;] ? __crypto_alg_lookup+0xac/0xf0 [ 12.139344] [&lt;ffffffff8120ca48&gt;] ? crypto_create_tfm+0x48/0xd0 [ 12.139445] [&lt;ffffffff812146cd&gt;] ? crypto_init_shash_ops_async+0x2d/0xd0 [ 12.139548] [&lt;ffffffff81217893&gt;] ? alg_test_hash+0x43/0xa0 [ 12.139650] [&lt;ffffffff81215b9b&gt;] ? alg_test+0x9b/0x230 [ 12.139753] [&lt;ffffffff81421351&gt;] ? __schedule+0x271/0x650 [ 12.139856] [&lt;ffffffff81214940&gt;] ? cryptomgr_probe+0xb0/0xb0 [ 12.139954] [&lt;ffffffff81214978&gt;] ? cryptomgr_test+0x38/0x40 [ 12.140058] [&lt;ffffffff8105c53f&gt;] ? kthread+0xaf/0xc0 [ 12.140219] [&lt;ffffffff8105c490&gt;] ? kthread_create_on_node+0x110/0x110 [ 12.140382] [&lt;ffffffff814237ac&gt;] ? ret_from_fork+0x7c/0xb0 [ 12.140482] [&lt;ffffffff8105c490&gt;] ? kthread_create_on_node+0x110/0x110 [ 12.140585] Code: c4 40 00 00 48 8d 2d 9d 3f 00 00 f3 0f 6f 27 66 41 0f 38 00 e4 f3 0f 6f 6f 10 66 41 0f 38 00 ec f3 0f 6f 77 20 66 41 0f 38 00 f4 &lt;f3&gt; 0f 6f 7f 30 66 41 0f 38 00 fc 48 89 7c 24 08 48 c7 c7 03 00 [ 12.145708] RIP [&lt;ffffffffa016b083&gt;] loop0+0x27/0x44 [sha256_ssse3] [ 12.145885] RSP &lt;ffff8800b66b7af0&gt; [ 12.145979] CR2: ffff8800bb593000 [ 12.146075] ---[ end trace 0382cf30f3465fd1 ]--- [ 12.146173] note: cryptomgr_test[276] exited with preempt_count 1 [ 12.146347] BUG: scheduling while atomic: cryptomgr_test/276/0x10000001 [ 12.146485] Modules linked in: sha256_ssse3(+) sha256_generic twofish_generic twofish_x86_64_3way xts lrw gf128mul glue_helper twofish_x86_64 twofish_common cbc dm_crypt dm_mod netconsole sg sr_mod sd_mod cdrom crc_t10dif crc32c_intel microcode ahci libahci ehci_pci ehci_hcd libata scsi_mod r8169 mii usbcore usb_common thermal thermal_sys [ 12.150126] CPU: 3 PID: 276 Comm: cryptomgr_test Tainted: G D 3.10.0-rc1+ #2 [ 12.150282] Hardware name: Dell Inc. Vostro 3500/0NVXFV, BIOS A10 10/25/2010 [ 12.150428] ffffffff8141eaf7 ffffffff8141bca7 ffffffff8142167a 0000000000000035 [ 12.151034] 0000000000000046 ffff8800b66b7fd8 ffff8800b66b7fd8 ffff8800b66b7fd8 [ 12.151610] ffff880037572090 ffff8800b66b6000 ffff8800375725d0 0000000000000046 [ 12.152215] Call Trace: [ 12.152352] [&lt;ffffffff8141eaf7&gt;] ? dump_stack+0xc/0x15 [ 12.152496] [&lt;ffffffff8141bca7&gt;] ? __schedule_bug+0x3f/0x4c [ 12.152637] [&lt;ffffffff8142167a&gt;] ? __schedule+0x59a/0x650 [ 12.152764] [&lt;ffffffff81067ccd&gt;] ? __cond_resched+0x1d/0x30 [ 12.152898] [&lt;ffffffff814217a6&gt;] ? _cond_resched+0x26/0x30 [ 12.153033] [&lt;ffffffff81420405&gt;] ? mutex_lock+0x15/0x40 [ 12.153169] [&lt;ffffffff810cfba0&gt;] ? perf_event_exit_task+0x20/0x1e0 [ 12.153277] [&lt;ffffffff8103e24f&gt;] ? do_exit+0x29f/0xa10 [ 12.153414] [&lt;ffffffff81005ca6&gt;] ? oops_end+0x96/0xe0 [ 12.153550] [&lt;ffffffff8141afd9&gt;] ? no_context+0x24c/0x275 [ 12.153692] [&lt;ffffffff8102d51e&gt;] ? __do_page_fault+0x2ee/0x480 [ 12.153834] [&lt;ffffffff810db066&gt;] ? __alloc_pages_nodemask+0x106/0x8f0 [ 12.153962] [&lt;ffffffff81423332&gt;] ? page_fault+0x22/0x30 [ 12.154102] [&lt;ffffffffa016b083&gt;] ? loop0+0x27/0x44 [sha256_ssse3] [ 12.154232] [&lt;ffffffffa016dc4e&gt;] ? __sha256_ssse3_update+0x5e/0xe0 [sha256_ssse3] [ 12.154380] [&lt;ffffffffa016df15&gt;] ? sha256_ssse3_final+0x145/0x1ec [sha256_ssse3] [ 12.154532] [&lt;ffffffff81214362&gt;] ? shash_ahash_finup+0x32/0x80 [ 12.154660] [&lt;ffffffff81217523&gt;] ? test_hash+0x383/0x6b0 [ 12.154800] [&lt;ffffffff8120c8a0&gt;] ? crypto_mod_get+0x10/0x30 [ 12.154940] [&lt;ffffffff811186d6&gt;] ? __kmalloc+0x1c6/0x1f0 [ 12.155042] [&lt;ffffffff8120cdfc&gt;] ? __crypto_alg_lookup+0xac/0xf0 [ 12.155183] [&lt;ffffffff8120ca48&gt;] ? crypto_create_tfm+0x48/0xd0 [ 12.155327] [&lt;ffffffff812146cd&gt;] ? crypto_init_shash_ops_async+0x2d/0xd0 [ 12.155466] [&lt;ffffffff81217893&gt;] ? alg_test_hash+0x43/0xa0 [ 12.155609] [&lt;ffffffff81215b9b&gt;] ? alg_test+0x9b/0x230 [ 12.155746] [&lt;ffffffff81421351&gt;] ? __schedule+0x271/0x650 [ 12.155886] [&lt;ffffffff81214940&gt;] ? cryptomgr_probe+0xb0/0xb0 [ 12.156018] [&lt;ffffffff81214978&gt;] ? cryptomgr_test+0x38/0x40 [ 12.156150] [&lt;ffffffff8105c53f&gt;] ? kthread+0xaf/0xc0 [ 12.156275] [&lt;ffffffff8105c490&gt;] ? kthread_create_on_node+0x110/0x110 [ 12.156408] [&lt;ffffffff814237ac&gt;] ? ret_from_fork+0x7c/0xb0 [ 12.156542] [&lt;ffffffff8105c490&gt;] ? kthread_create_on_node+0x110/0x110 [ 16.822251] SysRq : Keyboard mode set to system default [ 18.165412] SysRq : Terminate All Tasks [ 18.165722] ------------[ cut here ]------------ [ 18.165825] WARNING: at crypto/algapi.c:329 crypto_wait_for_test+0x55/0x70() [ 18.165846] Modules linked in: sha256_ssse3(+) sha256_generic twofish_generic twofish_x86_64_3way xts lrw gf128mul glue_helper twofish_x86_64 twofish_common cbc dm_crypt dm_mod netconsole sg sr_mod sd_mod cdrom crc_t10dif crc32c_intel microcode ahci libahci ehci_pci ehci_hcd libata scsi_mod r8169 mii usbcore usb_common thermal thermal_sys [ 18.165847] CPU: 3 PID: 273 Comm: modprobe Tainted: G D W 3.10.0-rc1+ #2 [ 18.165849] Hardware name: Dell Inc. Vostro 3500/0NVXFV, BIOS A10 10/25/2010 [ 18.165851] ffffffff8141eaf7 ffffffff810390fa ffff8800b669b400 ffff8800b669b400 [ 18.165853] ffffffffa016f660 ffffffffa016f6b0 0000000000000001 ffffffff8120e4d5 [ 18.165854] 0000000000000000 ffffffff8120e634 ffffffffa0046000 0000000000000000 [ 18.165855] Call Trace: [ 18.165858] [&lt;ffffffff8141eaf7&gt;] ? dump_stack+0xc/0x15 [ 18.165861] [&lt;ffffffff810390fa&gt;] ? warn_slowpath_common+0x6a/0xa0 [ 18.165863] [&lt;ffffffff8120e4d5&gt;] ? crypto_wait_for_test+0x55/0x70 [ 18.165864] [&lt;ffffffff8120e634&gt;] ? crypto_register_alg+0x64/0x80 [ 18.165867] [&lt;ffffffffa0046000&gt;] ? 0xffffffffa0045fff [ 18.165868] [&lt;ffffffff810002fa&gt;] ? do_one_initcall+0x10a/0x160 [ 18.165873] [&lt;ffffffff81090a57&gt;] ? load_module+0x1b37/0x2450 [ 18.165875] [&lt;ffffffff8108ca90&gt;] ? unset_module_init_ro_nx+0x80/0x80 [ 18.165877] [&lt;ffffffff81091430&gt;] ? SyS_init_module+0xc0/0xf0 [ 18.165879] [&lt;ffffffff81423852&gt;] ? system_call_fastpath+0x16/0x1b [ 18.165880] ---[ end trace 0382cf30f3465fd2 ]--- [ 18.166140] bio: create slab &lt;bio-1&gt; at 1 [ 20.123114] SysRq : Kill All Tasks [ 20.882858] SysRq : Emergency Sync [ 20.883148] Emergency Sync complete [ 22.531845] SysRq : Emergency Remount R/O [ 22.532141] Emergency Remount complete [ 23.386434] SysRq : Resetting [ 23.386663] ACPI MEMORY or I/O RESET_REG. </pre> Julian Wollrath 2013-05-16T13:41:35 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8905 <pre>By providing an OF match table with a suitable compatible string, we can ensure the ux500-hasht driver is probed by supplying an associated DT node in a given platform's Device Tree. Cc: Herbert Xu &lt;herbert&lt; at &gt;gondor.apana.org.au&gt; Cc: linux-crypto&lt; at &gt;vger.kernel.org Signed-off-by: Lee Jones &lt;lee.jones&lt; at &gt;linaro.org&gt; --- drivers/crypto/ux500/hash/hash_core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index 9ca6fbb..f89fe8a 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c &lt; at &gt;&lt; at &gt; -1981,6 +1981,11 &lt; at &gt;&lt; at &gt; static int ux500_hash_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(ux500_hash_pm, ux500_hash_suspend, ux500_hash_resume); +static const struct of_device_id ux500_hash_match[] = { + { .compatible = "stericsson,ux500-hash" }, + { }, +}; + static struct platform_driver hash_driver = { .probe = ux500_hash_probe, .remove = ux500_hash_remove, &lt; at &gt;&lt; at &gt; -1988,6 +1993,7 &lt; at &gt;&lt; at &gt; static struct platform_driver hash_driver = { .driver = { .owner = THIS_MODULE, .name = "hash1", +.of_match_table = ux500_hash_match, .pm = &amp;ux500_hash_pm, } }; </pre> Lee Jones 2013-05-16T11:27:26 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8903 <pre>Okay... -- ~Vinod </pre> Vinod Koul 2013-05-16T09:41:57 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8902 <pre>Certainly not in MAINTAINERS file :) -- ~Vinod </pre> Vinod Koul 2013-05-16T09:40:14 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8894 <pre>Acked-by: Vinod Koul &lt;vinod.koul&lt; at &gt;intel.com&gt; -- ~Vinod </pre> Vinod Koul 2013-05-16T06:41:09 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8893 <pre>Acked-by: Vinod Koul &lt;vinod.koul&lt; at &gt;intel.com&gt; -- ~Vinod </pre> Vinod Koul 2013-05-16T06:36:40 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8891 <pre>Acked-by: Vinod Koul &lt;vinod.koul&lt; at &gt;intel.com&gt; Wip ... :) </pre> Vinod Koul 2013-05-16T06:35:13 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8890 <pre>Acked-by: Vinod Koul &lt;vinod.koul&lt; at &gt;intel.com&gt; </pre> Vinod Koul 2013-05-16T06:34:14 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8889 <pre> how about a simple macro to check above.. Switch looks better for this and how about return fls(width); as your defines are 0...3 and dmaengine define 1,2,..8 for same thing then you can also get rid of STEDMA40_XXX_WIDTH macros! nice -- ~Vinod </pre> Vinod Koul 2013-05-16T06:32:44 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8887 <pre> Acked-by: Herbert Xu &lt;herbert&lt; at &gt;gondor.apana.org.au&gt; </pre> Herbert Xu 2013-05-16T07:02:17 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8885 <pre> Acked-by: Herbert Xu &lt;herbert&lt; at &gt;gondor.apana.org.au&gt; </pre> Herbert Xu 2013-05-16T07:01:44 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8884 <pre> Acked-by: Herbert Xu &lt;herbert&lt; at &gt;gondor.apana.org.au&gt; </pre> Herbert Xu 2013-05-16T07:01:33 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8883 <pre> Acked-by: Herbert Xu &lt;herbert&lt; at &gt;gondor.apana.org.au&gt; Thanks, </pre> Herbert Xu 2013-05-16T07:00:03 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8880 <pre>Acked-by: Vinod Koul &lt;vinod.koul&lt; at &gt;intel.com&gt; </pre> Vinod Koul 2013-05-16T06:08:50 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8878 <pre>Nice :) 1) I dont see the STE macro getting removed, why do we need it 2) last i checked the direction values had a bit idfference b/w what you are using and what dmaengine defines, so hopefully that is taken care of.. -- ~Vinod </pre> Vinod Koul 2013-05-16T05:17:01 http://permalink.gmane.org/gmane.linux.kernel.cryptoapi/8877 <pre>Acked-by: Vinod Koul &lt;vinod.koul&lt; at &gt;intel.com&gt; Hopefully all the BIT conversion in the driver are done in this -- ~Vinod </pre> Vinod Koul 2013-05-16T05:13:57 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.linux.kernel.cryptoapi