gmane.linux.fbdev.devel

Re: [PATCH] [#7001] framebuffer: old image oflast app would retain for a while after starting new app

Mike Frysinger — 2012-03-16T05:21:37

why does it need to be before open ?  if the kernel does the memset or 
userspace does the memset, the frame still gets cleared.

in looking at the blackfin framebuffer drivers, i'm not sure they're correct.  i 
don't think the PPI/DMA should be shutdown when the last user space client 
closes it.  fb_release is for releasing all resources when tearing down the 
driver, and fb_blank is runtime management (turning off vsync/hsync and 
powering down the screen).
-mike
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: [PATCH] [#7001] framebuffer: old image oflast app would retain for a while after starting new app

Mike Frysinger — 2012-03-16T03:54:31

sure it is.  if the app wants to clear the screen, it can do so.  generally 
it's going to anyways by drawing an entire frame.  having the frame buffer 
driver always clear the screen introduces wasted memory overhead as it does 
the memset(), and user-visible jank as the device transitions from an initial 
splash screen to the main userspace app.

this is a policy decision that doesn't really belong in kernel space.  and if 
it did, it should be agreed upon by all frame buffer users and not just 
changing a few drivers.
-mike
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: [uclinux-dist-devel] [PATCH] [#7001]framebuffer: old image of last app would retain for a whileafter starting new app

Mike Frysinger — 2012-03-15T19:08:03

i'm not sure the behavior you describe is wrong.  in fact, i'm pretty sure it 
sounds correct.  if an app writes an image to the framebuffer and then quits, 
that image should stay there indefinitely until something else opens the 
framebuffer and draws their own image.
-mike
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: [Bugme-new] [Bug 18912] New: BUG: unable to handle kernel NULL pointer dereference at (null)

Andrew Morton — 2010-09-20T23:18:40

(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Mon, 20 Sep 2010 22:34:17 GMT bugzilla-daemon< at >bugzilla.kernel.org wrote:


This is a bit strange.  We dereferenced a NULL pointer in
__mutex_lock_slowpath(), but where did it come from?  fb_release() does

mutex_lock(&info->lock);

but for that to be exactly zero, `info' must have been a small negative
number.




------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev

Re: [PATCH] fix Kconfig breakage indrivers/video

Andrew Morton — 2010-04-27T22:57:51

On Tue, 23 Mar 2010 12:11:37 -0700
Andrew Morton <akpm< at >linux-foundation.org> wrote:


<a month passes>

Krzysztof?

------------------------------------------------------------------------------

Re: [PATCH] fix Kconfig breakage indrivers/video

Andrew Morton — 2010-03-23T19:11:37

On Mon, 15 Mar 2010 08:39:20 +0200
Baruch Siach <baruch< at >tkos.co.il> wrote:


Did this question get addressed?

Thanks.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Re: drm_fb_helper: Impossible to change video mode

James Simmons — 2010-03-15T18:22:03


Yeap, some how userland has to tell which buffer is which. I also noticed 
their is a ttm_base_object_lookup which does the same thing :-) 


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Re: [PATCH] fix Kconfig breakage indrivers/video

David Miller — 2010-03-14T22:19:41

From: Krzysztof Helt <krzysztof.h1< at >poczta.fm>
Date: Sun, 14 Mar 2010 22:53:29 +0100


Acked-by: David S. Miller <davem< at >davemloft.net>

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Re: drm_fb_helper: Impossible to change video mode

James Simmons — 2010-03-13T14:40:10


 

Searching the TTM code I couldn't find the handle code so easily. I see 
that the vmwgfx driver provides a example of using ttm.
 

Sorry I should of stated what I was planing to do. I like to see drmfb 
have the ablitiy to change the resolution via fbset. To do that we need to 
be able to create and destory the framebuffer memory if the memory doesn't 
fit the size of the new resolution. Plus it gives us the bonus of being 
able to unpin the memory when the VT is in KD_GRAPHICS mode. The problem 
is that the functions like fb_create are tied to a handle which is not 
present for the internal framebuffer used by fbdev. Sorry for the junk 
above. It just took me awhile to figure out the code. Their is steep 
learning curve. I have patches that should address this coming soon.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: drm_fb_helper: Impossible to change video mode

James Simmons — 2010-03-11T15:17:36


I'm looking into the details for this. It will require some changes to 
internal apis to make it to work.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

Re: drm_fb_helper: Impossible to change video mode

James Simmons — 2010-03-11T03:41:19


I agree. The mode setting should be done in one layer. Its a matter of 
doing the proper emulation of the fbdev layer.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Re: drm_fb_helper: Impossible to change video mode

James Simmons — 2010-03-10T18:47:28


Ah, the power of flags. We had the same issue with user requesting a mode
change or fbcon asking for a different mode. We handled it with the flag 
FBINFO_MISC_USEREVENT. Since you are using KMS as the backend for fbcon you will
have to deal also with the ability to change the resolution with tools like stty.
I can easily see how to do this plus give you more memory like you want :-) 
For the oops are you talking about printing oops to the screen 
while X is running ? Otherwise if you experience a oops and go back to 
console mode you should be able to view it. The console text buffer is 
independent of the graphics card memory system.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Re: [PATCH] x86: allow fbdev primary video codeon 64-bit.

H. Peter Anvin — 2010-01-07T23:06:31

Looks good... I presume this is for .34, though?

-hpa

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev

Re: [PATCH 2/4] da850/omap-l138: Add callback to control LCD panel power

Andrew Morton — 2009-12-08T20:25:51

On Tue, 08 Dec 2009 09:53:46 -0800
Kevin Hilman <khilman< at >deeprootsystems.com> wrote:


I autodrop patches when they turn up in linux-next.  So if you want to
merge something then please just merge away, then I'll drop my copy.

This way patches don't get lost, and I get to check whether the patch
which was in linux-next matches the version I had, and whether the patch
which was merged into linux-next is missing any followup patches which
I had accumulated against the original.


------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev

[PATCH 4/4] fbcon: Replace vc_cursor_type mask0x10 with CUR_USE_SW

Henry Nestler — 2009-12-02T02:59:43

from: Henry Nestler <henry.nestler< at >gmail.com>

Replace hard coded vc_cursor_type mask 0x10 with macro CUR_USE_SW.

Signed-off-by: Henry Nestler <henry.nestler< at >gmail.com>
---

This patch depends on [patch 3/4], because it used new macro CUR_USE_SW 0x10.

Kernel version 2.6.32-rc8

 drivers/video/console/tileblit.c        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/tileblit.c b/drivers/video/console/tileblit.c
--- a/drivers/video/console/tileblit.c
+++ b/drivers/video/console/tileblit.c
< at >< at > -83,7 +83,7 < at >< at > static void tile_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 int softback_lines, int fg, int bg)
 {
 struct fb_tilecursor cursor;
-int use_sw = (vc->vc_cursor_type & 0x10);
+int use_sw = (vc->vc_cursor_type & CUR_USE_SW);

 cursor.sx = vc->vc_x;
 cursor.sy = vc->vc_y;
===

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

[PATCH 3/4] fbcon: Bugfix soft cursor detectionin Tile Blitting

Henry Nestler — 2009-12-02T02:52:56

from: Henry Nestler <henry.nestler< at >gmail.com>

Use mask 0x10 for "soft cursor" detection on in function tile_cursor.
(Tile Blitting Operation in framebuffer console).

The old mask 0x01 for vc_cursor_type detects CUR_NONE, CUR_LOWER_THIRD
and every second mode value as "software cursor". This hides the cursor
for these modes (cursor.mode = 0). But, only CUR_NONE or "software cursor"
should hide the cursor.

Signed-off-by: Henry Nestler <henry.nestler< at >gmail.com>
---
Kernel version 2.6.32-rc8

 drivers/video/console/tileblit.c        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/tileblit.c b/drivers/video/console/tileblit.c
index 0056a41..15e8e1a 100644
--- a/drivers/video/console/tileblit.c
+++ b/drivers/video/console/tileblit.c
< at >< at > -83,7 +83,7 < at >< at > static void tile_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 int softback_lines, int fg, int bg)
 {
 struct fb_tilecursor cursor;
-int use_sw = (vc->vc_cursor_type & 0x01);
+int use_sw = (vc->vc_cursor_type & 0x10);

 cursor.sx = vc->vc_x;
 cursor.sy = vc->vc_y;
===

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

[PATCH 2/4] fbcon: Macro CUR_USE_SW forvc_cursor_type mask 0x10

Henry Nestler — 2009-12-02T02:50:09

from: Henry Nestler <henry.nestler< at >gmail.com>

Replace hard coded 0x10 mask for vc_cursor_type with new macro CUR_USE_SW.

Signed-off-by: Henry Nestler <henry.nestler< at >gmail.com>
---
Kernel version 2.6.32-rc8

 drivers/char/vt.c                       |    2 +-
 drivers/video/console/bitblit.c         |    2 +-
 drivers/video/console/fbcon.c           |    2 +-
 drivers/video/console/fbcon_ccw.c       |    2 +-
 drivers/video/console/fbcon_cw.c        |    2 +-
 drivers/video/console/fbcon_ud.c        |    2 +-
 include/linux/console_struct.h          |    1 +
 7 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 0c80c68..f8b0f58 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
< at >< at > -566,7 +566,7 < at >< at > static void add_softcursor(struct vc_data *vc)
 int i = scr_readw((u16 *) vc->vc_pos);
 u32 type = vc->vc_cursor_type;

-if (! (type & 0x10)) return;
+if (! (type & CUR_USE_SW)) return;
 if (softcursor_original != -1) return;
 softcursor_original = i;
 i |= ((type >> 8) & 0xff00 );
diff --git a/drivers/usb/misc/sisusbvga/sisusb_con.c
b/drivers/usb/misc/sisusbvga/sisusb_con.c
diff --git a/drivers/video/console/bitblit.c b/drivers/video/console/bitblit.c
index 6b7c8fb..5858863 100644
--- a/drivers/video/console/bitblit.c
+++ b/drivers/video/console/bitblit.c
< at >< at > -241,7 +241,7 < at >< at > static void bit_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 unsigned short charmask = vc->vc_hi_font_mask ? 0x1ff : 0xff;
 int w = DIV_ROUND_UP(vc->vc_font.width, 8), c;
 int y = real_y(ops->p, vc->vc_y);
-int attribute, use_sw = (vc->vc_cursor_type & 0x10);
+int attribute, use_sw = (vc->vc_cursor_type & CUR_USE_SW);
 int err = 1;
 char *src;

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 3681c6a..d1074ec 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
< at >< at > -1291,7 +1291,7 < at >< at > static void fbcon_cursor(struct vc_data *vc, int mode)
 if (fbcon_is_inactive(vc, info) || vc->vc_deccm != 1)
 return;

-if (vc->vc_cursor_type & 0x10)
+if (vc->vc_cursor_type & CUR_USE_SW)
 fbcon_del_cursor_timer(info);
 else
 fbcon_add_cursor_timer(info);
diff --git a/drivers/video/console/fbcon_ccw.c
b/drivers/video/console/fbcon_ccw.c
index bdf913e..c6fd4a9 100644
--- a/drivers/video/console/fbcon_ccw.c
+++ b/drivers/video/console/fbcon_ccw.c
< at >< at > -226,7 +226,7 < at >< at > static void ccw_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 unsigned short charmask = vc->vc_hi_font_mask ? 0x1ff : 0xff;
 int w = (vc->vc_font.height + 7) >> 3, c;
 int y = real_y(ops->p, vc->vc_y);
-int attribute, use_sw = (vc->vc_cursor_type & 0x10);
+int attribute, use_sw = (vc->vc_cursor_type & CUR_USE_SW);
 int err = 1, dx, dy;
 char *src;
 u32 vyres = GETVYRES(ops->p->scrollmode, info);
diff --git a/drivers/video/console/fbcon_cw.c b/drivers/video/console/fbcon_cw.c
index a6819b9..00ac747 100644
--- a/drivers/video/console/fbcon_cw.c
+++ b/drivers/video/console/fbcon_cw.c
< at >< at > -210,7 +210,7 < at >< at > static void cw_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 unsigned short charmask = vc->vc_hi_font_mask ? 0x1ff : 0xff;
 int w = (vc->vc_font.height + 7) >> 3, c;
 int y = real_y(ops->p, vc->vc_y);
-int attribute, use_sw = (vc->vc_cursor_type & 0x10);
+int attribute, use_sw = (vc->vc_cursor_type & CUR_USE_SW);
 int err = 1, dx, dy;
 char *src;
 u32 vxres = GETVXRES(ops->p->scrollmode, info);
diff --git a/drivers/video/console/fbcon_ud.c b/drivers/video/console/fbcon_ud.c
index d9b5d6e..ee740e1 100644
--- a/drivers/video/console/fbcon_ud.c
+++ b/drivers/video/console/fbcon_ud.c
< at >< at > -256,7 +256,7 < at >< at > static void ud_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 unsigned short charmask = vc->vc_hi_font_mask ? 0x1ff : 0xff;
 int w = (vc->vc_font.width + 7) >> 3, c;
 int y = real_y(ops->p, vc->vc_y);
-int attribute, use_sw = (vc->vc_cursor_type & 0x10);
+int attribute, use_sw = (vc->vc_cursor_type & CUR_USE_SW);
 int err = 1, dx, dy;
 char *src;
 u32 vyres = GETVYRES(ops->p->scrollmode, info);
diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h
index 38fe59d..c12b3b1 100644
--- a/include/linux/console_struct.h
+++ b/include/linux/console_struct.h
< at >< at > -129,6 +129,7 < at >< at > extern void vc_SAK(struct work_struct *work);
 #define CUR_BLOCK6
 #define CUR_HWMASK0x0f
 #define CUR_SWMASK0xfff0
+#define CUR_USE_SW0x10

 #define CUR_DEFAULT CUR_UNDERLINE

===

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

[PATCH 1/4] vt: Replace mask 0x0f with macroCUR_HWMASK

Henry Nestler — 2009-12-02T02:45:20

from: Henry Nestler <henry.nestler< at >gmail.com>

Replace hard coded 0x0f with pre-defined macro CUR_HWMASK
to mask vc_cursor_type, and replace hard coded 1 with CUR_NONE.

Signed-off-by: Henry Nestler <henry.nestler< at >gmail.com>
---
Kernel version 2.6.32-rc8

 drivers/char/vt.c                       |    2 +-
 drivers/usb/misc/sisusbvga/sisusb_con.c |    2 +-
 drivers/video/console/mdacon.c          |    2 +-
 drivers/video/console/sticon.c          |    2 +-
 drivers/video/console/tileblit.c        |    2 +-
 drivers/video/console/vgacon.c          |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 0c80c68..26cf397 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
< at >< at > -606,7 +606,7 < at >< at > static void set_cursor(struct vc_data *vc)
 if (vc == sel_cons)
 clear_selection();
 add_softcursor(vc);
-if ((vc->vc_cursor_type & 0x0f) != 1)
+if ((vc->vc_cursor_type & CUR_HWMASK) != CUR_NONE)
 vc->vc_sw->con_cursor(vc, CM_DRAW);
 } else
 hide_cursor(vc);
diff --git a/drivers/usb/misc/sisusbvga/sisusb_con.c
b/drivers/usb/misc/sisusbvga/sisusb_con.c
index b624320..7599765 100644
--- a/drivers/usb/misc/sisusbvga/sisusb_con.c
+++ b/drivers/usb/misc/sisusbvga/sisusb_con.c
< at >< at > -806,7 +806,7 < at >< at > sisusbcon_cursor(struct vc_data *c, int mode)

 baseline = c->vc_font.height - (c->vc_font.height < 10 ? 1 : 2);

-switch (c->vc_cursor_type & 0x0f) {
+switch (c->vc_cursor_type & CUR_HWMASK) {
 case CUR_BLOCK:from = 1;
 to   = c->vc_font.height;
 break;
diff --git a/drivers/video/console/mdacon.c b/drivers/video/console/mdacon.c
index dd3eaaa..688837d 100644
--- a/drivers/video/console/mdacon.c
+++ b/drivers/video/console/mdacon.c
< at >< at > -520,7 +520,7 < at >< at > static void mdacon_cursor(struct vc_data *c, int mode)

 mda_set_cursor(c->vc_y*mda_num_columns*2 + c->vc_x*2);

-switch (c->vc_cursor_type & 0x0f) {
+switch (c->vc_cursor_type & CUR_HWMASK) {

 case CUR_LOWER_THIRD:mda_set_cursor_size(10, 13); break;
 case CUR_LOWER_HALF:mda_set_cursor_size(7,  13); break;
diff --git a/drivers/video/console/sticon.c b/drivers/video/console/sticon.c
index 491c1c1..b7c3262 100644
--- a/drivers/video/console/sticon.c
+++ b/drivers/video/console/sticon.c
< at >< at > -144,7 +144,7 < at >< at > static void sticon_cursor(struct vc_data *conp, int mode)
 break;
     case CM_MOVE:
     case CM_DRAW:
-switch (conp->vc_cursor_type & 0x0f) {
+switch (conp->vc_cursor_type & CUR_HWMASK) {
 case CUR_UNDERLINE:
 case CUR_LOWER_THIRD:
 case CUR_LOWER_HALF:
diff --git a/drivers/video/console/tileblit.c b/drivers/video/console/tileblit.c
index 0056a41..33bb70d 100644
--- a/drivers/video/console/tileblit.c
+++ b/drivers/video/console/tileblit.c
< at >< at > -91,7 +91,7 < at >< at > static void tile_cursor(struct vc_data *vc, struct
fb_info *info, int mode,
 cursor.fg = fg;
 cursor.bg = bg;

-switch (vc->vc_cursor_type & 0x0f) {
+switch (vc->vc_cursor_type & CUR_HWMASK) {
 case CUR_NONE:
 cursor.shape = FB_TILE_CURSOR_NONE;
 break;
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index da55cca..40bd8f8 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
< at >< at > -703,7 +703,7 < at >< at > static void vgacon_cursor(struct vc_data *c, int mode)
 case CM_MOVE:
 case CM_DRAW:
 write_vga(14, (c->vc_pos - vga_vram_base) / 2);
-switch (c->vc_cursor_type & 0x0f) {
+switch (c->vc_cursor_type & CUR_HWMASK) {
 case CUR_UNDERLINE:
 vgacon_set_cursor_size(c->vc_x,
        c->vc_font.height -
===

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

Re: [patch] fix oops with no /proc

Florian Tobias Schandinat — 2009-11-25T17:46:41

Hi,

nice catch. Your patch is obviously correct.
Please send it to Andrew Morton <akpm< at >linux-foundation.org> to get it 
into mainline.

Dan Carpenter schrieb:
Acked-by: Florian Tobias Schandinat <FlorianSchandinat< at >gmx.de>

Thanks,

Florian Tobias Schandinat

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[patch] fix oops with no /proc

Dan Carpenter — 2009-11-22T14:21:11

Fixed a typo:  missing *.  This would lead to a kernel oops if the kernel
was compiled without support for the /proc file system.

Found with a static checker.  Compile tested.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27< at >gmail.com>

--- orig/drivers/video/via/viafbdev.c2009-11-21 14:44:33.000000000 +0200
+++ devel/drivers/video/via/viafbdev.c2009-11-21 14:44:43.000000000 +0200
< at >< at > -1797,7 +1797,7 < at >< at > static const struct file_operations viaf
 static void viafb_init_proc(struct proc_dir_entry **viafb_entry)
 {
 *viafb_entry = proc_mkdir("viafb", NULL);
-if (viafb_entry) {
+if (*viafb_entry) {
 proc_create("dvp0", 0, *viafb_entry, &viafb_dvp0_proc_fops);
 proc_create("dvp1", 0, *viafb_entry, &viafb_dvp1_proc_fops);
 proc_create("dfph", 0, *viafb_entry, &viafb_dfph_proc_fops);

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[PATCH 30/38] move mipid_spi_remove to.devexit.text

Uwe Kleine-König — 2009-11-24T21:07:25

The function mipid_spi_remove is used only wrapped by __devexit_p so
define it using __devexit.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig< at >pengutronix.de>
Cc: Arnaud Patard <arnaud.patard< at >rtp-net.org>
Cc: Andrew Morton <akpm< at >linux-foundation.org>
Cc: Mike Wege <ext-mike.wege< at >nokia.com>
Cc: Imre Deak <imre.deak< at >solidboot.com>
Cc: Hiroshi DOYU <Hiroshi.DOYU< at >nokia.com>
Cc: linux-kernel< at >vger.kernel.org
Cc: Imre Deak <imre.deak< at >nokia.com>
Cc: linux-fbdev-devel< at >lists.sourceforge.net
Cc: linux-omap< at >vger.kernel.org
---
 drivers/video/omap/lcd_mipid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
index 918ee89..24889ca 100644
--- a/drivers/video/omap/lcd_mipid.c
+++ b/drivers/video/omap/lcd_mipid.c
< at >< at > -587,7 +587,7 < at >< at > static int mipid_spi_probe(struct spi_device *spi)
 return 0;
 }
 
-static int mipid_spi_remove(struct spi_device *spi)
+static int __devexit mipid_spi_remove(struct spi_device *spi)
 {
 struct mipid_device *md = dev_get_drvdata(&spi->dev);