gmane.linux.drivers.video-input-infrastructure

Re: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver

2013-05-20T07:31:17

Hi Sergei, Vladimir,


I've seen old patches that add VIN to the Marzen board, do you have an 
updated version?

Thanks
Phil

Re: InstantFM

Hans de Goede — 2013-05-20T06:55:54

Hi,

On 05/19/2013 10:18 PM, Ted To wrote:

Can you try with the (console-based) radio app from the latest xawtv release,
xawtv-3.103 ?

gnomeradio is not being actively maintained, so it could be your just hitting
a gnomeradio issue.

Regards,

Hans

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-20T00:45:02

----- Original Message -----


This patch seems to "do the right thing"... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-).

--- linux-3.9/drivers/media/usb/em28xx/em28xx-input.c.orig    2013-05-19 21:18:39.000000000 +0100
+++ linux-3.9/drivers/media/usb/em28xx/em28xx-input.c    2013-05-20 01:36:51.000000000 +0100
< at >< at > -417,6 +417,7 < at >< at >
         *rc_type = RC_BIT_RC6_0;
     } else if (*rc_type & RC_BIT_UNKNOWN) {
         *rc_type = RC_BIT_UNKNOWN;
+                return 0;
     } else {
         *rc_type = ir->rc_type;
         return -EINVAL;

This is against 3.9.3.

Signed-off-by: Chris Rankin <rankincj< at >yahoo.com>

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-19T23:04:19

----- Original Message -----


This is the dmesg output from 3.8, with an extra ex28xx_info() call at the start of em28xx_ir_change_protocol():

[ 2149.668729] Em28xx: Initialized (Em28xx dvb Extension) extension
[ 2149.674447] em28xx #0: Changing protocol: rc_type=1
[ 2149.700087] Registered IR keymap rc-pinnacle-pctv-hd
[ 2149.700444] input: em28xx IR (em28xx #0) as /devices/pci0000:00/0000:00:1d.7/usb5/5-1/rc/rc0/input15
[ 2149.700655] rc0: em28xx IR (em28xx #0) as /devices/pci0000:00/0000:00:1d.7/usb5/5-1/rc/rc0
[ 2149.700660] em28xx #0: Changing protocol: rc_type=8
[ 2149.702337] Em28xx: Initialized (Em28xx Input Extension) extension
[ 2149.704204] em28xx #0: Changing protocol: rc_type=1

And this is me calling ir-keytable:

[ 2183.812407] em28xx #0: Changing protocol: rc_type=1

The point is that 3.8 ignores rc_type=1, whereas 3.9 uses it to update a new ir->rc_type field - which in turn controls how em2874_polling_getkey() encodes its scancode.

Cheers,
Chris

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-19T22:36:17

----- Original Message -----



Possibly the significant difference between 3.8 and 3.9 is that the em2874_polling_getkey() function in 3.8 can only do one thing, whereas in 3.9 its behaviour switches on ir->rc_type.

The 3.9 version of em28xx_ir_change_protocol() also sets ir->rc_type to *rc_type before it exits, which means that the RC framework will "unconfigure" the em28xx remote control if it were to send RC_BIT_UNKNOWN for any reason.

And "yes", the 3.8 kernel does seem to call em28xx_ir_change_protocol() with *rc_type = RC_BIT_UNKNOWN occasionally too. It's just that under 3.8, the em28xx neither noticed nor cared.

Cheers,
Chris

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Frank Schäfer — 2013-05-19T21:02:22

Am 19.05.2013 21:59, schrieb Chris Rankin:
Ok, then it seems to be no em28xx issue.
What happens with kernel 3.8 ? Does ir-keytable trigger an
em28xx_ir_change_protocol() call there, too, but with type=8 ? Or is
this call missing ?

I'm not familar with ir-keytable and the RC core.
Mauro ? Can you take over ? ;)

Regards,
Frank

InstantFM

Ted To — 2013-05-19T20:18:24

Hi,

I purchased this device and while the device driver loads and I can set
up gnomeradio to access it, it picks up no radio stations, despite being
the model with an external antenna.  The log output says "software
version 0, hardware version 7".  I'm running Debian Wheezy and the
output from dmesg is:

[66842.724036] usb 2-3: new full-speed USB device number 3 using ohci_hcd
[66842.936144] usb 2-3: New USB device found, idVendor=06e1, idProduct=a155
[66842.936150] usb 2-3: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[66842.936154] usb 2-3: Product: ADS InstantFM Music
[66842.936156] usb 2-3: Manufacturer: ADS TECH
[66843.275730] Linux media interface: v0.10
[66843.296811] Linux video capture interface: v2.00
[66843.321815] USB radio driver for Si470x FM Radio Receivers, Version
1.0.10
[66843.323136] radio-si470x 2-3:1.2: DeviceID=0xffff ChipID=0xffff
[66843.326127] radio-si470x 2-3:1.2: software version 0, hardware version 7
[66843.326131] radio-si470x 2-3:1.2: This driver is known to work with
software version 7,
[66843.326135] radio-si470x 2-3:1.2: but the device has software version 0.
[66843.326138] radio-si470x 2-3:1.2: If you have some trouble using this
driver,
[66843.326141] radio-si470x 2-3:1.2: please report to V4L ML at
linux-media< at >vger.kernel.org
[66843.338247] usbcore: registered new interface driver radio-si470x
[66843.407477] usbcore: registered new interface driver snd-usb-audio

Any help on what I need to do to get this working would be much appreciated.

Cheers,
Ted To

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-19T19:59:51

----- Original Message -----


Quite sure, although it turns out that there's a bit more to it. Here is the dmesg output with my debugging messages in:

[ 6263.496794] em28174 #0: Calling em28xx_ir_change_protocol...
[ 6263.533332] em28174 #0: Calling em2874_ir_change_protocol...(type=1)
[ 6263.576099] Registered IR keymap rc-pinnacle-pctv-hd
[ 6263.607181] input: em28xx IR (em28174 #0) as /devices/pci0000:00/0000:00:1d.7/usb10/10-4/rc/rc6/input22
[ 6263.608329] ir-keytable[30882]: segfault at 0 ip 0000000000401cc0 sp 00007fff7ca22dd0 error 4 in ir-keytable[400000+8000]
[ 6263.756019] rc6: em28xx IR (em28174 #0) as /devices/pci0000:00/0000:00:1d.7/usb10/10-4/rc/rc6
[ 6263.816551] em28174 #0: Calling em28xx_ir_change_protocol...
[ 6263.853024] em28174 #0: Calling em2874_ir_change_protocol...(type=8)
[ 6263.895796] Em28xx: Initialized (Em28xx Input Extension) extension

This is the state after I have loaded my em28xx_rc modue. But then I need to call ir-keytable:

# ir-keytable -a /etc/rc_maps.cfg -s rc6

[ 6284.491992] em28174 #0: Calling em28xx_ir_change_protocol...
[ 6284.528492] em28174 #0: Calling em2874_ir_change_protocol...(type=1)

And this seems to reset the protocol back to "unknown". (But I need to use this other remote control to use VDR - the PCTV one just doesn't have enough buttons).

Cheers,
Chris

cron job: media_tree daily build: ERRORS

Hans Verkuil — 2013-05-19T18:28:15

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:Sun May 19 19:00:20 CEST 2013
git branch:test
git hash:4237c09a63906b980741725da63f85e454caec02
gcc version:i686-linux-gcc (GCC) 4.8.0
host hardware:x86_64
host os:3.8-3.slh.2-amd64

linux-git-arm-davinci: OK
linux-git-arm-exynos: WARNINGS
linux-git-arm-omap: WARNINGS
linux-git-blackfin: WARNINGS
linux-git-i686: OK
linux-git-m32r: OK
linux-git-mips: OK
linux-git-powerpc64: OK
linux-git-sh: OK
linux-git-x86_64: OK
linux-2.6.31.14-i686: WARNINGS
linux-2.6.32.27-i686: WARNINGS
linux-2.6.33.7-i686: WARNINGS
linux-2.6.34.7-i686: WARNINGS
linux-2.6.35.9-i686: WARNINGS
linux-2.6.36.4-i686: WARNINGS
linux-2.6.37.6-i686: WARNINGS
linux-2.6.38.8-i686: WARNINGS
linux-2.6.39.4-i686: WARNINGS
linux-3.0.60-i686: WARNINGS
linux-3.10-rc1-i686: WARNINGS
linux-3.1.10-i686: WARNINGS
linux-3.2.37-i686: WARNINGS
linux-3.3.8-i686: WARNINGS
linux-3.4.27-i686: WARNINGS
linux-3.5.7-i686: WARNINGS
linux-3.6.11-i686: WARNINGS
linux-3.7.4-i686: WARNINGS
linux-3.8-i686: OK
linux-3.9.2-i686: OK
linux-2.6.31.14-x86_64: WARNINGS
linux-2.6.32.27-x86_64: WARNINGS
linux-2.6.33.7-x86_64: WARNINGS
linux-2.6.34.7-x86_64: WARNINGS
linux-2.6.35.9-x86_64: WARNINGS
linux-2.6.36.4-x86_64: WARNINGS
linux-2.6.37.6-x86_64: WARNINGS
linux-2.6.38.8-x86_64: WARNINGS
linux-2.6.39.4-x86_64: WARNINGS
linux-3.0.60-x86_64: WARNINGS
linux-3.10-rc1-x86_64: WARNINGS
linux-3.1.10-x86_64: WARNINGS
linux-3.2.37-x86_64: WARNINGS
linux-3.3.8-x86_64: WARNINGS
linux-3.4.27-x86_64: WARNINGS
linux-3.5.7-x86_64: WARNINGS
linux-3.6.11-x86_64: WARNINGS
linux-3.7.4-x86_64: WARNINGS
linux-3.8-x86_64: OK
linux-3.9.2-x86_64: OK
apps: ERRORS
spec-git: OK
sparse: ERRORS

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Sunday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2

The Media Infrastructure API from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Frank Schäfer — 2013-05-19T17:26:59

Am 19.05.2013 16:11, schrieb Chris Rankin:

Good, that's how it should be.


Hmm... that's weird. Are you sure about that ? Is this really a 3.9.2
vanilla kernel ?
The code looks good, ir->rc_type is updated by
em2874_ir_change_protocol() when the protocol is changed.
I also tried to reproduce your problem with a em2884 device with a RC5
remote control a few minutes ago, but everything works as expected...

One thing I noticed is that in em28xx_ir_handle_key() ir->last_readcount
is reset to 0 for the em2874 and em2884.
I assume the same should be done for em28174, too...
Anyway, that's a separate issue and older kernels did the same.

Regards,
Frank

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-19T14:11:32

----- Original Message -----


Yes, it does appear to be called twice: first with *rc_type=1 and then later with *rc_type=8. But that still doesn't seem to stop ir->rc_type being RC_BIT_UNKNOWN in em2874_polling_getkey().

Cheers,
Chris

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Frank Schäfer — 2013-05-19T13:40:57

Am 18.05.2013 23:02, schrieb Chris Rankin:
em28xx_ir_change_protocol() should be called at least twice:
First from em28xx_ir_init() with RC_BIT_UNKNOWN (initial configuration) 
and later from the RC core with RC_BIT_RC5.
Can you confirm that ?

Regards,
Frank

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-18T21:11:50

----- Original Message -----


Confirmed: em28xx is failing to set the protocol to RC5, which means that em2874_polling_getkey() is using the "default" (UNKNOWN) case to interpret the scan codes.

Forcing em2874_polling_getkey() to use RC5 fixes the remote control for this device.

Cheers,
Chris

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-18T21:02:29

----- Original Message -----


By the looks of things, it's not recognising the protocol: em2874_ir_change_protocol() is setting ir->rc_type to RC_BIT_UNKNOWN. Shouldn't it be using RC5 instead?

Cheers,
Chris

cron job: media_tree daily build: ERRORS

Hans Verkuil — 2013-05-18T18:28:07

This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.

Results of the daily build of media_tree:

date:Sat May 18 19:00:19 CEST 2013
git branch:test
git hash:4237c09a63906b980741725da63f85e454caec02
gcc version:i686-linux-gcc (GCC) 4.8.0
host hardware:x86_64
host os:3.8-3.slh.2-amd64

linux-git-arm-davinci: OK
linux-git-arm-exynos: WARNINGS
linux-git-arm-omap: WARNINGS
linux-git-blackfin: WARNINGS
linux-git-i686: OK
linux-git-m32r: OK
linux-git-mips: OK
linux-git-powerpc64: OK
linux-git-sh: OK
linux-git-x86_64: OK
linux-2.6.31.14-i686: WARNINGS
linux-2.6.32.27-i686: WARNINGS
linux-2.6.33.7-i686: WARNINGS
linux-2.6.34.7-i686: WARNINGS
linux-2.6.35.9-i686: WARNINGS
linux-2.6.36.4-i686: WARNINGS
linux-2.6.37.6-i686: WARNINGS
linux-2.6.38.8-i686: WARNINGS
linux-2.6.39.4-i686: WARNINGS
linux-3.0.60-i686: WARNINGS
linux-3.10-rc1-i686: WARNINGS
linux-3.1.10-i686: WARNINGS
linux-3.2.37-i686: WARNINGS
linux-3.3.8-i686: WARNINGS
linux-3.4.27-i686: WARNINGS
linux-3.5.7-i686: WARNINGS
linux-3.6.11-i686: WARNINGS
linux-3.7.4-i686: WARNINGS
linux-3.8-i686: OK
linux-3.9.2-i686: OK
linux-2.6.31.14-x86_64: WARNINGS
linux-2.6.32.27-x86_64: WARNINGS
linux-2.6.33.7-x86_64: WARNINGS
linux-2.6.34.7-x86_64: WARNINGS
linux-2.6.35.9-x86_64: WARNINGS
linux-2.6.36.4-x86_64: WARNINGS
linux-2.6.37.6-x86_64: WARNINGS
linux-2.6.38.8-x86_64: WARNINGS
linux-2.6.39.4-x86_64: WARNINGS
linux-3.0.60-x86_64: WARNINGS
linux-3.10-rc1-x86_64: WARNINGS
linux-3.1.10-x86_64: WARNINGS
linux-3.2.37-x86_64: WARNINGS
linux-3.3.8-x86_64: WARNINGS
linux-3.4.27-x86_64: WARNINGS
linux-3.5.7-x86_64: WARNINGS
linux-3.6.11-x86_64: WARNINGS
linux-3.7.4-x86_64: WARNINGS
linux-3.8-x86_64: OK
linux-3.9.2-x86_64: OK
apps: ERRORS
spec-git: OK
sparse: ERRORS

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Saturday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Saturday.tar.bz2

The Media Infrastructure API from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Frank Schäfer — 2013-05-18T16:58:50

Am 18.05.2013 17:17, schrieb Chris Rankin:

For the em28xx driver: em28xx-input.c:
em28xx_ir_work() is called every 100ms
     calls em28xx_ir_handle_key()
         - calls ir->get_key() which is em2874_polling_getkey() in case 
of your device
         - reports the detected key via rc_keydown() through the RC core

HTH,
Frank

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-18T15:17:10

----- Original Message -----



Unfortunately, no I can't. (No git tree here - just a tarball downloaded via FTP). However, maybe I could out some printk() statements into the code if you could point out where the "hot-spots" might be, please?

Cheers,
Chris

Re: 3.9.2 kernel - IR / em28xx_rc broken?

Frank Schäfer — 2013-05-18T14:36:18

Am 18.05.2013 15:57, schrieb Chris Rankin:

Great. :( :( :(
There have been several changes in the em28xx and core RC code between 
3.8 and 3.9...
I can't see anything obvious, the RC device seems to be registered 
correctly.
Could you please bisect ?

Regards,
Frank

[3.9.2] Broken IR with em28xx?

Chris Rankin — 2013-05-18T14:03:12

Hi,

Further to my original email, here is the dmesg log from 3.9.2 when inserting my 290e adapter:


[ 1273.581835] usb 10-4: new high-speed USB device number 6 using ehci-pci
[ 1273.704508] em28xx: New device PCTV Systems PCTV 290e < at > 480 Mbps (2013:024f, interface 0, class 0)
[ 1273.712167] em28xx: DVB interface 0 found: isoc
[ 1273.715540] em28xx: chip ID is em28174
[ 1274.011883] em28174 #0: Identified as PCTV nanoStick T2 290e (card=78)
[ 1274.017111] em28174 #0: v4l2 driver version 0.1.3
[ 1274.025554] em28174 #0: V4L2 video device registered as video0
[ 1274.030093] em28174 #0: dvb set to isoc mode.
[ 1274.037116] tda18271 6-0060: creating new instance
[ 1274.045237] TDA18271HD/C2 detected < at > 6-0060
[ 1274.216011] DVB: registering new adapter (em28174 #0)
[ 1274.219769] usb 10-4: DVB: registering adapter 0 frontend 0 (Sony CXD2820R)...
[ 1274.226240] em28174 #0: Successfully loaded em28xx-dvb
[ 1274.230632] Registered IR keymap rc-pinnacle-pctv-hd
[ 1274.234529] input: em28xx IR (em28174 #0) as /devices/pci0000:00/0000:00:1d.7/usb10/10-4/rc/rc1/input18
[ 1274.235704] ir-keytable[4661]: segfault at 0 ip 0000000000401cc0 sp 00007fff26dae550 error 4 in ir-keytable[400000+8000]
[ 1274.252304] rc1: em28xx IR (em28174 #0) as /devices/pci0000:00/0000:00:1d.7/usb10/10-4/rc/rc1
[ 1334.876948] tda18271: performing RF tracking filter calibration
[ 1337.231439] tda18271: RF tracking filter calibration complete

The ir-keytable segfault is a userspace error that predates the 3.9.x kernel. Reloading the IR keys manually seems OK:

# ir-keytable --auto-load /etc/rc_maps.cfg  --sysdev=rc1
Old keytable cleared
Wrote 45 keycode(s) to driver
Protocols changed to other 


VDR behaves as if it's just not receiving any events, although as I said, the 3.8.x kernels are OK.


Cheers,
Chris

3.9.2 kernel - IR / em28xx_rc broken?

Chris Rankin — 2013-05-18T13:57:30


Hi,

I have a PCTV 290e DVB2 adapter (em28xx, em28xx_dvb, em28xx_rc, cxd2820r), and I have just discovered that the IR remote control has stopped working with VDR when using a vanilla 3.9.2 kernel. Downgrading the kernel to 3.8.12 fixes things again. (Switching to my old DVB NOVA-T2 device fixes things too, although it cannot receive HDTV channels, of course).

Has anyone else noticed problems like this, please?

Thanks,
Chris

(unknown)

santoshpavan D — 2013-05-18T10:30:40

Hi All,

I have a query regarding Demux driver. I am seeing the Linux dvb and
V4L2. Where exactly this driver should go V4L2 or dvb