gmane.linux.alsa.devel

Re: get rid of controls with snd_ctl_remove

Harald Radke — 2008-08-29T22:19:05

hm.... I added the function and the declaration to our 2.6.26 tree, compiling gives: sound/core/control.c: In function `snd_ctl_activate_id': sound/core/control.c:435: error: `control' undeclared (first use in this function) is it essential to use your devel tree? Harry PS: Liam: thanks for the offer, I am sure I will bug u with unqualified questions till the sound support on our Loox works as wanted (; And nice work on the 8750 codec!

Re: ALSA, select() question.

William Estrada — 2008-08-29T20:16:24

Jaroslav, I got you Email address from http://www.mail-archive.com/alsa-devel< at >lists.sourceforge.net/msg09605.html. lists.sourceforge.net/msg09605.html> I am trying to write a C program that simply reads from a ALSA device and then writes back to it. The program work with one major problem, there is a 4.1 second delay between the read and the write. This delay is caused by the select() not returning at the right time. In you post you said to use: Do you have some sample code that I could look at so that I could fix my problem?

Re: get rid of controls with snd_ctl_remove

Liam Girdwood — 2008-08-29T20:10:58

I agree, although I'm now not is a position to test anything atm (no hardware until later next week). Harald, could you give this a try with your WM8750 based device. Please feel free to mail with any questions you may have re WM8750 mixers. Thanks Liam

Re: Issues with alsa-info.sh - Trying to track downthe problem.

Travis Place — 2008-08-29T18:52:20

Thanks. Understood. Just wanted to sort it out :) Thanks, Travis Place (wishie)

[PATCH] Automatically use ALC268_TOSHIBA for ToshibaL305 Laptop

Travis Place — 2008-08-29T18:51:04

Changelog: Added Subsystem IDs (0x1179, 0xff64) for the Toshiba Satellite L305 laptop, so it automatically uses the ALC268_TOSHIBA quirk. Signed-off-by: Travis Place wishie.net> Patch Attached. Thanks, Travis Place (wishie) _______________________________________________ Alsa-devel mailing list Alsa-devel< at >alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Issues with alsa-info.sh - Trying to track down the problem.

Jaroslav Kysela — 2008-08-29T18:43:38

Thanks for this file. Fixed now. I would like to keep this code private for security reasons. Jaroslav ----- Jaroslav Kysela perex.cz> Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.

Re: Issues with alsa-info.sh - Trying to track downthe problem.

Travis Place — 2008-08-29T18:29:36

Ok, the file from a failed post can be found at: http://pastebin.ca/1188698 and the wget.tmp contents (that prove it failed) can be found at: http://pastebin.ca/1188699 What i cant work out, is why its telling me the file is "Unknown file format".. Can i see the sites code that validates the uploaded files ? Thanks, Travis Place (wishie)

Re: [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28 anda few minor fixes

Takashi Iwai — 2008-08-29T18:21:26

At Fri, 29 Aug 2008 19:23:15 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote: OK, merged now. Let's see whether we have any broken issues although I don't expect much. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel< at >alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ice1724: enable MIDI on Terratec Aureon7.1 Universe

Takashi Iwai — 2008-08-29T18:20:42

At Fri, 29 Aug 2008 18:39:26 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote: Well, it's a Wiki for everyone. Feel free to add any good contents by yourself, too ;) thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel< at >alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28 anda few minor fixes

Vedran Miletić — 2008-08-29T17:23:15

It indeed does fix it. Doesn't seem to break anything along the way. Can you check it in? 2008/8/29 Takashi Iwai suse.de>:

Re: [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28 anda few minor fixes

Takashi Iwai — 2008-08-29T16:50:36

At Fri, 29 Aug 2008 18:44:30 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote: OK, I applied this now. Thanks! Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel< at >alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28 anda few minor fixes

Vedran Miletić — 2008-08-29T16:44:30

Wait, this isn't the one, my first mail is wrong. Need to figure out how git generates my mail and how to change that, take this one instead. 2008/8/29 Vedran Miletić gmail.com>:

Re: get rid of controls with snd_ctl_remove

Takashi Iwai — 2008-08-29T16:42:08

At Fri, 29 Aug 2008 14:56:33 +0100, Liam Girdwood wrote: Good to hear that. Just let me know if you need this in the upstream. I don't want to push such an API addition too early before any use. FWIW, below is the latest version, found in my sound-unstable tree. thanks, Takashi From c4ef566498f37140bcef852109e44bea580f4bc8 Mon Sep 17 00:00:00 2001 From: Takashi Iwai suse.de> Date: Fri, 29 Aug 2008 16:09:01 +0200 Subject: [PATCH] ALSA: Add snd_ctl_activate_id() Added a new API function snd_ctl_activate_id() for activate / inactivate the control element dynamically. Signed-off-by: Takashi Iwai suse.de> diff --git a/include/sound/control.h b/include/sound/control.h index 4721b4b..6c0002a 100644 --- a/include/sound/control.h +++ b/include/sound/control.h < at >< at > -114,6 +114,8 < at >< at > int snd_ctl_add(struct snd_card * card, struct snd_kcontrol * kcontrol); int snd_ctl_remove(struct snd_card * card, struct snd_kcontrol * kcontrol); int snd_ctl_remove_id(struct snd_card * card, struct snd_ctl_elem_id *id); int snd_ctl_rename_id(struct snd_card * card, struct snd_ctl_elem_id *src_id, struct snd_ctl_elem_id *dst_id); +int snd_ctl_activate_id(struct snd_card * card, struct snd_ctl_elem_id *id, +int active); struct snd_kcontrol *snd_ctl_find_numid(struct snd_card * card, unsigned int numid); struct snd_kcontrol *snd_ctl_find_id(struct snd_card * card, struct snd_ctl_elem_id *id); diff --git a/sound/core/control.c b/sound/core/control.c index 3c5e746..c6f7062 100644 --- a/sound/core/control.c +++ b/sound/core/control.c < at >< at > -410,6 +410,52 < at >< at > int snd_ctl_remove_id(struct snd_card *card, struct snd_ctl_elem_id *id) EXPORT_SYMBOL(snd_ctl_remove_id); /** + * snd_ctl_activate_id - activate/inactivate the control of the given id + * < at >card: the card instance + * < at >id: the control id to activate/inactivate + * < at >active: non-zero to activate + * + * Finds the control instance with the given id, and activate or + * inactivate the control together with notification, if changed. + * + * Returns 0 if unchanged, 1 if changed, or a negative error code on failure. + */ +int snd_ctl_activate_id(struct snd_card *card, struct snd_ctl_elem_id *id, +int active) +{ +struct snd_kcontrol *kctl; +struct snd_kcontrol_volatile *vd; +unsigned int index_offset; +int ret; + +down_write(&card->controls_rwsem); +kctl = snd_ctl_find_id(card, id); +if (kctl == NULL) { +up_write(&card->controls_rwsem); +return -ENOENT; +} +index_offset = snd_ctl_get_ioff(kctl, &control->id); +vd = &kctl->vd[index_offset]; +ret = 0; +if (active) { +if (!(vd->access & SNDRV_CTL_ELEM_ACCESS_INACTIVE)) +goto unlock; +vd->access &= ~SNDRV_CTL_ELEM_ACCESS_INACTIVE; +} else { +if (vd->access & SNDRV_CTL_ELEM_ACCESS_INACTIVE) +goto unlock; +vd->access |= SNDRV_CTL_ELEM_ACCESS_INACTIVE; +} +ret = 1; + unlock: +up_write(&card->controls_rwsem); +if (ret) +snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_INFO, id); +return ret; +} +EXPORT_SYMBOL(snd_ctl_activate_id); + +/** * snd_ctl_remove_unlocked_id - remove the unlocked control of the given id and release it * < at >file: active control handle * < at >id: the control id to remove

Re: [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28 anda few minor fixes

Vedran Miletić — 2008-08-29T16:41:02

You guessed right :)) Well, this time... I also fixed lines longer than 80 chars along the way. 2008/8/29 Takashi Iwai suse.de>:

Re: [PATCH] ice1724: enable MIDI on Terratec Aureon7.1 Universe

Vedran Miletić — 2008-08-29T16:39:26

Thank you for this guide, it helped me a lot. Perhaps it should be added to wiki as "10 second introduction to git for new contributors", as I believe that most people would like to know this. 2008/8/29 Takashi Iwai suse.de>:

Re: get rid of controls with snd_ctl_remove

Liam Girdwood — 2008-08-29T13:56:33

Wow - that was quick ! Yes, exactly :) We can now add this to our machine drivers to disable never used controls (for each machine) and also call this when scenario changes too. Even more interestingly, it could also be called by DAPM...... Cheers Liam

Re: [PATCH] ice1724 MIDI on PHASE 22 and PHASE 28anda few minor fixes

Takashi Iwai — 2008-08-29T13:54:26

At Fri, 29 Aug 2008 13:04:06 +0200, I wrote: More to follow, the patch below might fix the problem. Takashi diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c index 60119d2..7bb99df 100644 --- a/sound/pci/ice1712/ice1724.c +++ b/sound/pci/ice1712/ice1724.c < at >< at > -942,7 +942,7 < at >< at > static int snd_vt1724_playback_pro_open(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; struct snd_ice1712 *ice = snd_pcm_substream_chip(substream); -int chs; +int chs, num_indeps; runtime->private_data = (void *)&vt1724_playback_pro_reg; ice->playback_pro_substream = substream; < at >< at > -952,7 +952,8 < at >< at > static int snd_vt1724_playback_pro_open(struct snd_pcm_substream *substream) set_rate_constraints(ice, substream); mutex_lock(&ice->open_mutex); /* calculate the currently available channels */ -for (chs = 0; chs < 3; chs++) { +num_indeps = ice->num_total_dacs / 2 - 1; +for (chs = 0; chs < num_indeps; chs++) { if (ice->pcm_reserved[chs]) break; }

Re: get rid of controls with snd_ctl_remove

Takashi Iwai — 2008-08-29T13:41:21

At Fri, 29 Aug 2008 14:16:52 +0100, Liam Girdwood wrote: Something like below? Takashi diff --git a/sound/core/control.c b/sound/core/control.c index 3c5e746..c6f7062 100644 --- a/sound/core/control.c +++ b/sound/core/control.c < at >< at > -410,6 +410,52 < at >< at > int snd_ctl_remove_id(struct snd_card *card, struct snd_ctl_elem_id *id) EXPORT_SYMBOL(snd_ctl_remove_id); /** + * snd_ctl_activate_id - activate/inactivate the control of the given id + * < at >card: the card instance + * < at >id: the control id to activate/inactivate + * < at >active: non-zero to activate + * + * Finds the control instance with the given id, and activate or + * inactivate the control together with notification, if changed. + * + * Returns 0 if unchanged, 1 if changed, or a negative error code on failure. + */ +int snd_ctl_activate_id(struct snd_card *card, struct snd_ctl_elem_id *id, +int active) +{ +struct snd_kcontrol *kctl; +struct snd_kcontrol_volatile *vd; +unsigned int index_offset; +int ret; + +down_write(&card->controls_rwsem); +kctl = snd_ctl_find_id(card, id); +if (kctl == NULL) { +up_write(&card->controls_rwsem); +return -ENOENT; +} +index_offset = snd_ctl_get_ioff(kctl, &control->id); +vd = &kctl->vd[index_offset]; +ret = 0; +if (active) { +if (!(vd->access & SNDRV_CTL_ELEM_ACCESS_INACTIVE)) +goto unlock; +vd->access &= ~SNDRV_CTL_ELEM_ACCESS_INACTIVE; +} else { +if (vd->access & SNDRV_CTL_ELEM_ACCESS_INACTIVE) +goto unlock; +vd->access |= SNDRV_CTL_ELEM_ACCESS_INACTIVE; +} +ret = 1; + unlock: +up_write(&card->controls_rwsem); +if (ret) +snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_INFO, id); +return ret; +} +EXPORT_SYMBOL(snd_ctl_activate_id); + +/** * snd_ctl_remove_unlocked_id - remove the unlocked control of the given id and release it * < at >file: active control handle * < at >id: the control id to remove

Re: Issues with alsa-info.sh - Trying to track downthe problem.

Travis Place — 2008-08-29T13:18:11

When running with --debug, and checking the contents of /tmp/alsainfo/wget.tmp , i see the following.. http://pastebin.com/d6bfd601e So it appears the alsa-project.org site is saying "Invalid file format".. thats a part of the puzzle. Looking into the rest now. Thanks, Travis Place (wishie)

Re: get rid of controls with snd_ctl_remove

Liam Girdwood — 2008-08-29T13:16:52

I'd prefer an addition to our API to handle this more _common_ case rather than just removing controls. Something where we can mark controls as "disabled" so alsamixer and friends wont render/get them. This would also allow scenario code to disable relevant mixers and then re-enable when required. Liam

Re: get rid of controls with snd_ctl_remove

Takashi Iwai — 2008-08-29T13:01:27

At Fri, 29 Aug 2008 14:54:42 +0200, Harald Radke wrote: You can't use list_for_each_entry() together with removal. Use list_for_each_entry_safe() for such a purpose. But... It'd be easier like the following: for (i = 0; i < ARRAY_SIZE(unused_controls); i++) { struct snd_ctl_elem_id id; memset(&id, 0, sizeof(id)); strcpy(id.name, unused_controls[i]); id.iface = SNDRV_CTL_ELEM_IFACE_MIXER; snd_ctl_remove_id(card, &id); } Takashi