http://blog.gmane.org/gmane.comp.window-managers.dwm hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.window-managers.dwm/6798 It had a bug. We don't want to set as urgent the sel client. Sorry for the noise. yy 2008-11-29T20:23:56 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6797 The attached patch set a different border color for windows with the urgency hint flag set. The flag will be removed when the client is focused (instead of when it is visible). It saves some lines of code (and can save some more moving clearurgent() to focus(), since it is used only there). have fun, yy 2008-11-29T20:17:17 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6796 I tested your patch a bit and it seems to work properly. Does it will going in upstream? Thanks for your help and time. Claudio M. Alessi Claudio M. Alessi 2008-11-29T20:12:20 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6795 Hello, It seems as though some variation of a previous dialog bug ( http://lists.suckless.org/dwm/0711/4361.html) still exists. I was able to reproduce the behavior with dwm and twm. In the first case I am able to regain control to the window manager, but in the second case X must be restarted. #!/bin/bash firefox & PID=$! sleep 3 kill -9 $PID # 1. slock drops back to wm and all windows are visible until an input event # (key press/mouse event) in which case it blanks again and it behaves as # normal slock & firefox & # 2. just flashes to wm on an input event but doesn't allow entering password # Warning! I was unable to unlock the display and had to restart X :<<EOF while :; do [[ `xlsclients | grep firefox` ]] && slock done EOF Thanks list subscriber 2008-11-29T16:37:32 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6794 If I start some applications inside dvtm, sometimes I've got troubles with cyrillic input. Sometimes letters enter, sometimes not. I have to press a key for a long time to get it entered. 1. mcabber reports following error: (keycode may vary) 2. aptitude crashes with a report: 3. htop just closes the search prompt when I try to enter some cyrillic symbols But some applications always work pretty good with cyrillic input, e.g. bash, ncmpc, vim I tested it on: - dvtm 0.4.1-1 from ubuntu repos, - dvtm 0.4.1 compiled from source (tarball from http://www.brain-dump.org/projects/dvtm/dvtm-0.4.1.tar.gz) - dvtm 0.4.1 from git repository (fetched on November, 29) The bug appears in all versions. Is there any way to fix it? SIO 2008-11-29T14:40:13 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6793 I also had to RTFM and as I am very tired right now I wouldn't be surprised if there is a simpler way to accomplish it. Anyway attached is a patch which seems to work for my limited test case. Please test, review and post possible simplifications. Thanks, Marc Marc Andre Tanner 2008-11-26T23:29:50 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6792 You could do something very similar just caling unmanage. The problem is you can't call functions from the rules definition (though you could use a keybinding to unmanage windows). It could be interesting to modify applyrules and the Rule definition in order to call functions, like buttons and keys: typedef struct { const char *class; const char *instance; const char *title; void (*func)(const Arg *); const Arg arg; } Rule; Of course, you would also have to tweak manage in order to make it work. I'm not sure it would be a very good idea, but it probably is not difficult to try. As a side effect, somebody could control dwm creating windows with well chosen names (and probably somebody would write a program to do it), I would find such a hack very unelegant... yy 2008-11-25T20:43:49 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6791 Small bug-fix - cycling through visible windows was broken (in focusstack())... This is the cumulative patch, but the only differences from the last one are the few lines in focusstack() Jeremy diff -r f6c3491c41f1 config.def.h --- a/config.def.hSun Nov 16 13:22:24 2008 +0000 +++ b/config.def.hTue Nov 25 13:32:05 2008 -0500 < at >< at > -21,9 +21,9 < at >< at > static unsigned int tagset[] = {1, 1}; /* after start, first tag is selected */ static Rule rules[] = { -/* class instance title tags mask isfloating */ -{ "Gimp", NULL, NULL, 0, True }, -{ "Firefox", NULL, NULL, 1 << 8, True }, +/* class instance title tags mask flags */ +{ "Gimp", NULL, NULL, 0, Floating }, +{ "Firefox", NULL, NULL, 1 << 8, Floating }, }; /* layout(s) */ diff -r f6c3491c41f1 dwm.c --- a/dwm.cSun Nov 16 13:22:24 2008 +0000 +++ b/dwm.cTue Nov 25 13:32:05 2008 -0500 < at >< at > -65,6 +65,7 < at >< at > enum { WMProtocols, WMDelete, WMState, WMLast }; /* default atoms */ enum { ClkTagBar, ClkLtSymbol, ClkStatusText, ClkWinTitle, ClkClientWin, ClkRootWin, ClkLast }; /* clicks */ +enum { Normal, Floating, NoFocus=2 }; /* Client flags for Rules */ typedef union { int i; < at >< at > -89,7 +90,7 < at >< at > int basew, baseh, incw, inch, maxw, maxh, minw, minh; int bw, oldbw; unsigned int tags; -Bool isfixed, isfloating, isurgent; +Bool isfixed, isfloating, isurgent, nofocus; Client *next; Client *snext; Window win; < at >< at > -127,7 +128,7 < at >< at > const char *instance; const char *title; unsigned int tags; -Bool isfloating; +unsigned int flags; } Rule; /* function declarations */ < at >< at > -258,7 +259,8 < at >< at > if((!r->title || strstr(c->name, r->title)) && (!r->class || (ch.res_class && strstr(ch.res_class, r->class))) && (!r->instance || (ch.res_name && strstr(ch.res_name, r->instance)))) { -c->isfloating = r->isfloating; +c->isfloating = (r->flags&Floating)!=0; +c->nofocus = (r->flags&NoFocus)!=0; c->tags |= r->tags & TAGMASK; } } < at >< at > -498,7 +500,8 < at >< at > Client *c; for(c = clients; c; c = c->next) { -occ |= c->tags; +if(c->tags!=TAGMASK) +occ |= c->tags; if(c->isurgent) urg |= c->tags; } < at >< at > -508,7 +511,7 < at >< at > dc.w = TEXTW(tags[i]); col = tagset[seltags] & 1 << i ? dc.sel : dc.norm; drawtext(tags[i], col, urg & 1 << i); -drawsquare(sel && sel->tags & 1 << i, occ & 1 << i, urg & 1 << i, col); +drawsquare(sel && tagset[seltags] & sel->tags & 1 << i, occ & 1 << i, urg & 1 << i, col); dc.x += dc.w; } if(blw > 0) { < at >< at > -610,6 +613,7 < at >< at > void focus(Client *c) { +Client *inc=c; if(!c || !ISVISIBLE(c)) for(c = stack; c && !ISVISIBLE(c); c = c->snext); if(sel && sel != c) { < at >< at > -619,6 +623,9 < at >< at > if(c) { detachstack(c); attachstack(c); +} +while( !inc && c && c->nofocus ) c=c->next; +if(c) { grabbuttons(c, True); XSetWindowBorder(dpy, c->win, dc.sel[ColBorder]); XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime); < at >< at > -644,17 +651,17 < at >< at > if(!sel) return; if (arg->i > 0) { -for(c = sel->next; c && !ISVISIBLE(c); c = c->next); +for(c = sel->next; c && (!ISVISIBLE(c) || c->nofocus); c = c->next); if(!c) -for(c = clients; c && !ISVISIBLE(c); c = c->next); +for(c = clients; c && (!ISVISIBLE(c) || c->nofocus); c = c->next); } else { for(i = clients; i != sel; i = i->next) -if(ISVISIBLE(i)) +if(ISVISIBLE(i) && !i->nofocus) c = i; if(!c) for(; i; i = i->next) -if(ISVISIBLE(i)) +if(ISVISIBLE(i) && !i->nofocus) c = i; } if(c) { Jeremy Jay 2008-11-25T18:46:13 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6790 I don't think i have the skills to fully solve the problem. I guess it would be useful a code like the following into the drawbar() function (replacing the strlen(3) call): l = mbstowcs(trash, stext, sizeof trash); This works properly with the right alignment but not with the left one. I'll RTFM and try to solve the problem, however if anyone is able to do the work it would be faster (better?) than me. Regards, Claudio M. Alessi Claudio M. Alessi 2008-11-24T23:21:53 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6789 On 11/20/08, Christoph Lohmann <20h-hp7/j35RrEI< at >public.gmane.org> wrote: The 9p idea made me think that there may be some simple way of doing it in plan9. I wrote a plumber interface. Its probably suboptimal, but it seems to work. plumber will even loads the handler :) Doing it this seems to suggest a removal of some of the stuff from the interpreter itself, because you only file io. Another way is to use plumber code to write a dedicated ffi server mount it into the file system, but I dont know if it's any better. I guess doing it this way is very close to the system() call approach. sorry about the OT. but thanks a lot. Fernan Bolando 2008-11-23T12:02:53 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6788 Awesome, I use trayer and would like a nofocus feature as well. I'll try this out when I get a chance. Thanks! Thayer Williams 2008-11-21T18:58:51 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6787 I do a lot of roaming, and long story short, nm-applet is nearly a requirement for me. No biggie, I just run it in stalonetray and set it to all tags, shoved up in the corner, only I've ran into two little issues: 1) sticky windows put an indicator on every tag in the bar. I know it's on every tag, I put it there, tell me something I don't know. The patch hides any window which has tags=~0 from the indicators. ( this is simply the 2 lines in drawbar() ) 2) since it's on every tag, every time i switch tags, it is the first thing focused. I dont need to type into a system tray, so the patch also adds a flag to designate a window as "nofocus" which tells dwm to skip it when trying to find a window to focus. To do this, I had to add a way to designate a window as nofocus, so Rule.isfloating is now a bitmask Rule.flags, with enums for the 3 settings right now: Normal, Floating, NoFocus. So my config.h, for example, has this Rule: { "stalonetray", NULL, NULL, ~0, Floating|NoFocus }, Patch against tip attached, if anyone else is interested - it only adds 7 lines so its still nice and small. =) Jeremy # HG changeset patch # User dinkumator-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org # Date 1227289871 18000 # Node ID 811a88242229049dfd367487ae7312f238972179 # Parent f6c3491c41f1a5e149eaa0e28d59e5b69d7682c1 hide sticky(tags=~0) windows from tag-bar indicators also add ability to designate windows as "nofocus" ie, switching tags will never auto-focus "nofocus" windows, but will skip to next window. Rules now have a bitmask for the 4th parameter instead of the boolean isfloating. You can now use the list of enums: Normal, Floating, NoFocus. For example: { "stalonetray", NULL, NULL, ~0, Floating|NoFocus }, will make stalonetray never automatically recieve focus, it will always be floating, and it will be on every tag, yet not put an indicator in the bar. diff -r f6c3491c41f1 -r 811a88242229 config.def.h --- a/config.def.hSun Nov 16 13:22:24 2008 +0000 +++ b/config.def.hFri Nov 21 12:51:11 2008 -0500 < at >< at > -21,9 +21,9 < at >< at > static unsigned int tagset[] = {1, 1}; /* after start, first tag is selected */ static Rule rules[] = { -/* class instance title tags mask isfloating */ -{ "Gimp", NULL, NULL, 0, True }, -{ "Firefox", NULL, NULL, 1 << 8, True }, +/* class instance title tags mask flags */ +{ "Gimp", NULL, NULL, 0, Floating }, +{ "Firefox", NULL, NULL, 1 << 8, Floating }, }; /* layout(s) */ diff -r f6c3491c41f1 -r 811a88242229 dwm.c --- a/dwm.cSun Nov 16 13:22:24 2008 +0000 +++ b/dwm.cFri Nov 21 12:51:11 2008 -0500 < at >< at > -65,6 +65,7 < at >< at > enum { WMProtocols, WMDelete, WMState, WMLast }; /* default atoms */ enum { ClkTagBar, ClkLtSymbol, ClkStatusText, ClkWinTitle, ClkClientWin, ClkRootWin, ClkLast }; /* clicks */ +enum { Normal, Floating, NoFocus=2 }; /* Client flags for Rules */ typedef union { int i; < at >< at > -89,7 +90,7 < at >< at > int basew, baseh, incw, inch, maxw, maxh, minw, minh; int bw, oldbw; unsigned int tags; -Bool isfixed, isfloating, isurgent; +Bool isfixed, isfloating, isurgent, nofocus; Client *next; Client *snext; Window win; < at >< at > -127,7 +128,7 < at >< at > const char *instance; const char *title; unsigned int tags; -Bool isfloating; +unsigned int flags; } Rule; /* function declarations */ < at >< at > -258,7 +259,8 < at >< at > if((!r->title || strstr(c->name, r->title)) && (!r->class || (ch.res_class && strstr(ch.res_class, r->class))) && (!r->instance || (ch.res_name && strstr(ch.res_name, r->instance)))) { -c->isfloating = r->isfloating; +c->isfloating = (r->flags&Floating)!=0; +c->nofocus = (r->flags&NoFocus)!=0; c->tags |= r->tags & TAGMASK; } } < at >< at > -498,7 +500,8 < at >< at > Client *c; for(c = clients; c; c = c->next) { -occ |= c->tags; +if(c->tags!=TAGMASK) +occ |= c->tags; if(c->isurgent) urg |= c->tags; } < at >< at > -508,7 +511,7 < at >< at > dc.w = TEXTW(tags[i]); col = tagset[seltags] & 1 << i ? dc.sel : dc.norm; drawtext(tags[i], col, urg & 1 << i); -drawsquare(sel && sel->tags & 1 << i, occ & 1 << i, urg & 1 << i, col); +drawsquare(sel && tagset[seltags] & sel->tags & 1 << i, occ & 1 << i, urg & 1 << i, col); dc.x += dc.w; } if(blw > 0) { < at >< at > -610,6 +613,7 < at >< at > void focus(Client *c) { +Client *inc=c; if(!c || !ISVISIBLE(c)) for(c = stack; c && !ISVISIBLE(c); c = c->snext); if(sel && sel != c) { < at >< at > -619,6 +623,9 < at >< at > if(c) { detachstack(c); attachstack(c); +} +while( !inc && c && c->nofocus ) c=c->next; +if(c) { grabbuttons(c, True); XSetWindowBorder(dpy, c->win, dc.sel[ColBorder]); XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime); < at >< at > -644,17 +651,17 < at >< at > if(!sel) return; if (arg->i > 0) { -for(c = sel->next; c && !ISVISIBLE(c); c = c->next); +for(c = sel->next; c && !ISVISIBLE(c) && c->nofocus; c = c->next); if(!c) -for(c = clients; c && !ISVISIBLE(c); c = c->next); +for(c = clients; c && !ISVISIBLE(c) && c->nofocus; c = c->next); } else { for(i = clients; i != sel; i = i->next) -if(ISVISIBLE(i)) +if(ISVISIBLE(i) && i->nofocus) c = i; if(!c) for(; i; i = i->next) -if(ISVISIBLE(i)) +if(ISVISIBLE(i) && i->nofocus) c = i; } if(c) { Jeremy Jay 2008-11-21T18:38:29 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6786 Problem is that strlen is used to calculate character width, which doesn't work for utf8 therefore the statusbar content is not properly aligned. http://www.brain-dump.org/tmp/statusbar.png Cheers, Marc Marc Andre Tanner 2008-11-20T21:48:30 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6785 Sweet! For the record, I've never had to work so hard to justify such a small patch to a FOSS project. It was a pleasant experience that makes me feel better about the larger codebase! Also for the record, I couldn't care less whether my toggleable setlayout patch goes in upstream. You can put the patch's author down in the "apathy" column. Neale Neale Pickett 2008-11-20T20:36:23 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6784 Definitively i do _not_ want to add such code in upstream. Claudio M. Alessi Claudio M. Alessi 2008-11-20T19:34:12 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6783 2008/11/20 Neale Pickett <neale-qIOhqoGMB3Idnm+yROfE0A< at >public.gmane.org>: I'm fine to add it in 5.3, since it seems to work quite well. Kind regards, Anselm Anselm R Garbe 2008-11-20T18:01:06 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6782 So what's the verdict on this? Neale Neale Pickett 2008-11-20T17:57:17 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6781 2008/11/20 Claudio M. Alessi <smoppy-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>: Am I right that you are against re-adding the toggle? Kind regards, Anselm Anselm R Garbe 2008-11-20T17:56:42 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6780 You shouldn't care about the previous layout, it's not a memory game. Users change layouts once they need it, then use another layout in order to fit their new needs and so forth. Changing the layout is not an hard task, i think. I already have some feature i never use but i wouldn't make a dwm-lite release. Please add only real useful code :-) Regards, Claudio M. Alessi Claudio M. Alessi 2008-11-20T17:51:11 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6779 You're welcome! I always use that script with dvtm without any problem. Can you tell me what's wrong (maybe attaching screenshot)? I have more time now to work on it. Regards, Claudio M. Alessi Claudio M. Alessi 2008-11-20T17:22:34 http://permalink.gmane.org/gmane.comp.window-managers.dwm/6778 Am Tue, 18 Nov 2008 19:35:36 +0000 schrieb "Anselm R Garbe" <garbeam-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>: Yes, I at least found: # WindowSizer (shareware, closed source) # WinSplit (freeware, closed source) # DockBox (NOW GPL) # GridMove (donationware, not closed source) - Actually GridMove was the inspiration for bug.n. But as you stated before, all those projects were not satisfying the needs of dynamic window management; thus I looked for an open source project, which I possibly could adapt. Now (since 20080910) DockBox - or maybe even better: HashTWM (same author) - is under GPL, so I will take a closer look. Are you wainting for a stabilized API (since GINA already has gone in Vista)? Are you still heading for a shell replacement? Kind regards, joten joten-KuiJ5kEpwI6ELgA04lAiVw< at >public.gmane.org 2008-11-20T12:38:29 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.window-managers.dwm