gmane.comp.web.netsurf.devel

Re: [Patch] Add support for parsing writing-mode property v1

Caitlin Potter — 2013-06-11T13:56:37

I just realized I've forgotten to attach the current version of the writing-mode property patch, so here :>


On 2013-06-11, at 9:54 AM, Caitlin Potter <snowball-s/oemEvlk0tWk0Htik3J/w< at >public.gmane.org> wrote:

Re: [Patch] Add support for parsing writing-mode property v1

Caitlin Potter — 2013-06-11T13:54:57

I still have not added any tests explicitly regarding the writing-mode property, however I have gotten everything to a stage where all tests are passing, which previously was not the case.

I could use some guidance writing parse/select tests for the property because even after studying the test programs and data files, it's not really obvious what the system is -- And beyond that, since I'm not really a CSS guru by any means, it is likely that I would write incorrect expectations when e.g. important is used.

It seems that there will also be a few more properties to add, including 'text-orientation' and 'direction', I'm not sure if I should add those as part of this patch or perhaps add those in subsequent chunks.

You're all busy people so when you have some time just give me a nod and I'll see what I can do.

On 2013-06-07, at 5:12 AM, John-Mark Bell <jmb-DgXf7JAplXVbejMqVEbnxkB+6BGkLq7r< at >public.gmane.org> wrote:

Re: value of length in css properties

Michael Drake — 2013-06-07T15:07:35

In article
<OFC4CFBE13.FF734988-ONC1257B83.004C479D-C1257B83.004C479F-NuEXXdsWwZReoWH0uzbU5w< at >public.gmane.org>,
   <Valentin.Coudert-NuEXXdsWwZReoWH0uzbU5w< at >public.gmane.org> wrote:


For letter spacing I'd expect percentage values to be rejected as
invalid.  Also, note that values will be in css_fixed format.  You can use
libcss/fpmath.h to convert.  e.g. FIXTOINT or FIXTOFLT.

value of length in css properties

2013-06-07T13:53:10

Re: [Patch] Add support for parsing writing-mode property v1

John-Mark Bell — 2013-06-07T09:12:27

Excellent. Thanks for your work on this.

[...]


You're using a Mac, right? I've no current idea why make test isn't
working for you on that platform, as the test infrastructure is pretty
trivial. We're investigating that now.


In general, this looks fine to me (modulo the lack of test data, which
you've mentioned above). There are a few minor whitespace nits, which
can be fixed when we merge the change in. Additionally, there's a stray
commented-out chunk in css__set_writing_mode_from_hint. This, too is
trivially fixed, so I'm not concerned by it.


J.

[Patch] Add support for parsing writing-mode property v1

Caitlin Potter — 2013-06-07T08:09:59

This patch is intended to support the parsing and storage of the "writing-mode" property, which is one of the building blocks for vertical text in css (support for which is currently required by the HTML5 track element and obviously is a pretty important localization feature -- and just simply looks cool, too).

The layout side of things can be dealt with elsewhere, but first and foremost is getting libcss to support the property.

A link to the current draft is here http://dev.w3.org/csswg/css-writing-modes/ with the writing-mode property in particular described in http://dev.w3.org/csswg/css-writing-modes/#writing-mode

===

It is quite likely that there are things substantially wrong, including the lack of test data (I haven't figured out how to get the test suite to even build and run yet, `make test` seems to fail substantially here.)

So some review would be good, I'd like to get this approved by netsurf devs before trying to squeeze it into mozilla-servo.

Any and all feedback is much appreciated, thanks a bunch.

Re: description of css_select_handler functions

Michael Drake — 2013-06-04T12:04:03

In article
<OFBC71A18E.7E474887-ONC1257B80.00401579-C1257B80.0040157A-NuEXXdsWwZReoWH0uzbU5w< at >public.gmane.org>,
   <Valentin.Coudert-NuEXXdsWwZReoWH0uzbU5w< at >public.gmane.org> wrote:


You could have a look at the implementations in NetSurf.

See css/select.c:

  http://source.netsurf-browser.org/netsurf.git/tree/css/select.c

description of css_select_handler functions

2013-06-04T11:39:58

Re: Options/Choices refactor

Chris Young — 2013-06-01T14:15:34


Ah, I see why - the user option needs updating manually if it is the
same as the default.  I've fixed it (and added some macros to do this
for non-string values).

The treeviews seem to create themselves using old colours though.
Maybe it was always like that and I didn't notice.

Chris

Re: Options/Choices refactor

Chris Young — 2013-05-31T22:11:27


Sort of I guess, but I want them all set, but then I want to change
the defaults so any that aren't set get the new defaults instead of
the old ones (not sure that is any cleaerer actually)


The primary example are the system colours settings.  At the moment
they aren't being set because the screen my code looks at to pick the
colours off of, hasn't been opened by the time the options are
initialised.

What I need is something like:
1. Options initialised and read
This gives my screen_modeid and a couple of other options required for
opening NetSurf on the correct screen.

2. Open screen

3. Set default options relating to the screen being used
This includes system colours, window size etc.  They should not be
overriding any user specified options.

4. Optionally support re-doing step 3 if the screen being used changes
during program execution (actually the frontend doesn't support this
yet but may do one day)

btw a "screen" in AmigaOS terms is more like a "desktop" in X11, but
can be a different resolution and theme to what is being used for the
desktop (hence the requirement to set the default system colours and
window size after the screen has been determined)


I did try running the colour_option_from_pen functions through with
nsoptions_default parameter, but about:config shows the system colours
options are then "user" settings (for some reason).  That's no good as
they get written back to Choices, which puts us back to square 1.


I don't think I need to deal with any strings at the moment.  I'll
have a look at it.

Thanks
Chris

Re: Options/Choices refactor

Vincent Sanders — 2013-05-31T20:29:16

this does sound ass backwards? like you want only some user options
set and then to initialise some defaults then to apply the rest of the
user options?

Perhaps a clearer idea of what you are trying to achive might be
useful? you may have to do a second initialisation after the first
user option load and have ther second init use the info from the
first?

The new API is designed to be flexible. The original aim was to
completely abstract access to the options. Due to practical
constraints outlined in utils/nsoption.h this has not been possible.

For now there are no accessor functions for the default values (yeah i
know the current implementation for active options is with macros) but
you can simply use nsoptions_default[NSOPTION_option_name].value.i
directly from within your own code (or perhaps better still crate some
accessor functions(macros) in nsoption.h)

The gtk frontend has a verify_options() function in its main() that
does something similar, just remember that strings must be handled
carefully as defaults may be const and not require freeing (active
options are always allocated from heap) and only options that differ
between the default and active table will be saved.

Re: Options/Choices refactor

Chris Young — 2013-05-31T18:27:42


Is there any way to modify the defaults outside of nsoption_init?

I have to open a screen before I can set some of the values, but I
can't open the screen until options are initialised (as the parameters
are in there).  So I'd like to set some defaults at a later time which
then get applied, unless of course the user has already set their own
preferences.

Chris

Re: Bizarre emails to help< at > and webmaster< at >

Chris Young — 2013-05-23T10:34:40

Sorry for re-quoting all those emails, typing on a phone and hadn't realised it picked up the entire message for quoting.

Re: Bizarre emails to help< at > and webmaster< at >

Chris Young — 2013-05-23T10:30:44


Their website is labsvisual.com perhaps an email asking them to rename their product (which i'm guessing is newer than ours - but their website products page isn't working here) is in order?

Re: Bizarre emails to help< at > and webmaster< at >

Chris Young — 2013-05-23T10:23:35


If you search "netsurf cnet" on google the top result is something called "NetSURF web browser", version 3.2-something. I haven't downloaded it but the scant description and version number indicates it's something else with the same name. Odd.

Bizarre emails to help< at > and webmaster< at >

Rob Kendrick — 2013-05-23T09:17:56

So, recently we've had a flurry of bizarre emails to our help< at > and
webmaster< at > addresses, of which I have attached a selection.       
                                                                  
Anybody know what's going on?  Somebody posted a misleading review
somewhere or something?                                           

B.

Re: extending libcss through properties.gen

Michael Drake — 2013-05-21T11:37:46

In article <6E64952A914E43E6B743E3CBCDF54ADA-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>,
HoÃ V. Dinh <dinh.viet.hoa-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

The first thing to do is to define the byte code for the properties you
want to add. See docs/Bytecode:

http://source.netsurf-browser.org/libcss.git/tree/docs/Bytecode

Then there's two parts to adding support for a property. You need the
code to parse the property into bytecode, in src/parse/, and the code to
handle selection (cascade, computed value calculation, etc of the
property), in src/select/.

Here are some examples:

Adding new properties to the parser:

http://source.netsurf-browser.org/libcss.git/commit/?id=32ed7d0984f0dd872b4aaac0ac12c18471f291a0

Adding new shorthand properties to the parser:

http://source.netsurf-browser.org/libcss.git/commit/?id=bd8ef0f5e2ec383b528b825eba4724b90643cbef

Note that the shorthand properties just set the values for other
properties, so they don't have their own bytecode.

Adding new properties to the selection engine:

http://source.netsurf-browser.org/libcss.git/commit/?id=89ef7a8acf13143ac0283aa1cfa5ea504b92324b

You need to know and understand the spec. Note that the overflow-x and -y
properties are still at an early draft stage. Also, the overflow property
has to change from an actual property to a shorthand property that sets
the values for both overflow-x and -y.

Sure. It's easier to follow once you come up with the byte code.

Taking the overflow one as an example:

overflow:CSS_PROP_OVERFLOW IDENT:( INHERIT: VISIBLE:0,OVERFLOW_VISIBLE
HIDDEN:0,OVERFLOW_HIDDEN SCROLL:0,OVERFLOW_SCROLL AUTO:0,OVERFLOW_AUTO
IDENT:)

"overflow" is the property, which is used for the file/function name of
the generated parser.

"CSS_PROP_OVERFLOW" is the css_properties_e enum value from
include/libcss/properties.h Note enum the value is the number of the
bytecode for the property.

Then in the brackets, you have INHERIT: because the property may be
inherited.

And then a list of the other values the property may take.

So VISIBLE:0,OVERFLOW_VISIBLE means if the value matches the VISIBLE
string defined in parser/propstrings.{c|h}, then set the property to the
enum value OVERFLOW_VISIBLE which is in src/bytecode/opcodes.h. That
opcodes enum is set up according to the bytecode design in docs/Bytecode.
The 0 is for the flags, a part of the bytecode. That's always 0.

Anyway, given the state of the spec, especially ISSUE 1, I'd be tempted
not to add supprt for the paged-* and fragments values at this stage. So
in that case, you just need to rename the overflow property handler to
overflow-x, add an overflow-y which behaves the same, add a parser for the
shorthand overflow property, and update the selection code to handle the
two overflow-x and overflow-y properties instead of overflow.

Mac OS X

Vincent Sanders — 2013-05-19T09:16:44

We continue to compile for the Mac OS X cocoa frontend on both PowerPC
(OS 10.5 leopard) and x86 (OS 10.6 snow leopard). The Continuous
Integration (CI) system uses two real mac mini computers[1] as build
slaves as Mac OS X cannot currently be reliably cross compiled for.

Recently the PPC CI system build slave (chimera) had a catastrophic
hard drive failure and required a complete OS and development tools
reinstall. This re-install took an extended period of time as the PPC
system is somewhat slow compared to other targets.

Generally we use SSD in our build slaves, however I was unwilling to
bear the cost of a 2.5inch PATA SSD for this system so its been
reinstalled with a reconditioned Seagate 5200 RPM drive.

The cocoa frontend currently has no maintainer and I am interested in
hearing from any actual users to give an indication as to whether it is
worth investing any additional resources on this platform. 

So any actual users or developers, please speak up now!

Note I am not asking for opinion about other considerations such as
diversity and how nice it is to have a wide range of platforms
supported, purely if there are any actual users.

If there are none I shall simply remove these targets from the CI
system on the next occasion this rather old and *very* slow hardware
fails.

[1] http://www.flickr.com/photos/29254252< at >N06/8519229958/in/set-72157626712232414

Internationalisation

Vincent Sanders — 2013-05-19T08:14:43

I recently had opportunity to integrate a translation platform into
the NetSurf workflow[1]. 

This integration has been performed on the transifex platform, is
complete, and does work reasonably. However without real actual
translations it is not useful.

I would like to invite anyone with translation skills to improve the
netsurf project by using this web interface to enter translations[2].

I am especially interested in any of our current developers providing
translatiopns who wish to become translation reviewers to ensure we
maintain a high quality.

The current number of translated/reviewed strings by language is:

English: 100%/100%
French: 93%/93%
Dutch: 92%/92%
German: 92%/92%
Italian: 92%/92%
Spanish: 87%/0%
Chinese: 0%/0%

The review status is purely based on the existing corpus (i.e. if it
is in the current set of translations it is considered reviwed)

The spanish translation is currently a pure machine translation
althouh we already have some volunteers from the translation community
to whom I am grateful for their input.


[1] http://vincentsanders.blogspot.co.uk/2013/05/true-art-selects-and-paraphrases-but.html
[2] https://www.transifex.com/projects/p/netsurf/

Re: CI builds stuck

Vincent Sanders — 2013-05-19T07:16:33

on this occasion it is because the building where the two mac os x
boxes are colocated is having a mains power upgrade and there will be
no power untill tomorrow morning at 08:00. Sorry for the
inconveniance.

extending libcss through properties.gen

Hoà V. Dinh — 2013-05-19T02:09:38

Hi Netsurf dev,  

I'd like to extend libcss to parse additional CSS properties such as border-radius.
I'd also like to add overflow-x, overflow-y. "overflow" is implemented but not -x, -y variants.

I had a quick look at the following file:
libcss/src/parse/properties/properties.gen
But I couldn't figure quite right what was the syntax of this file even with the whole list of examples.
Could you help me figure out?

Thanks.