gmane.comp.mozilla.conkeror

Re: [PATCH] add super modifier

John J. Foerch — 2013-02-14T23:42:21

Thank you.  I hadn't noticed the patch that you posted to issue410, but I
have now responded there on the bug tracker.  This patch does not exactly
solve that issue, but once we decide what we want to do about it, this
patch with some modifications will.  Let's continue the discussion on the
tracker now.

C-x-b on Twitter page blocks people

aditya siram — 2013-02-14T16:00:44

Hi all,
I've had this happen 3 times over the past 2 weeks where if I am reading a
conversation on Twitter and I do a C-x-b to switch to the previous buffer,
Twitter interprets the `b` as `Block` and automatically blocks the
conversation starter. This is somewhat embarrassing and I only knew about
it when someone asked me why I had blocked them.

Does Twitter mode fix this?

Thanks!
-deech
_______________________________________________
Conkeror mailing list
Conkeror< at >mozdev.org
https://www.mozdev.org/mailman/listinfo/conkeror

Re: C-x-b on Twitter page blocks people

John J. Foerch — 2013-02-14T20:37:27

Try using key-kill-mode.  I haven't added the mode to Conkeror yet, so
here it is and you can just put it in your rc, and add a test for twitter.

  function key_kill_event_kill (event) {
      var elem = event.target;
      if (elem instanceof Ci.nsIDOMHTMLInputElement ||
          elem instanceof Ci.nsIDOMHTMLTextAreaElement)
      {
          return;
      }
      event_kill(event);
  }

  define_page_mode("key-kill-mode",
      [],
      function enable (buffer) {
          buffer.browser.addEventListener("keyup", key_kill_event_kill, true);
          buffer.browser.addEventListener("keydown", key_kill_event_kill, true);
      },
      function disable (buffer) {
          buffer.browser.removeEventListener("keyup", key_kill_event_kill, true);
          buffer.browser.removeEventListener("keydown", key_kill_event_kill, true);
      },
      $display_name = "Key-kill");

  page_mode_activate(key_kill_mode);

  key_kill_mode.test.push(build_url_regexp($domain = "www.smbc-comics"));
  key_kill_mode.test.push(build_url_regexp($domain = "github"));
  key_kill_mode.test.push(/\/\/.*slashdot\.org\//);

[PATCH] add super modifier

Nguyễn Tuấn Anh — 2013-02-14T15:14:10

This allows using the Windows-logo key as a modifier. It used to
trigger meta modifier, but changed to os modifier in recent xulrunner
versions (probably from 12).

See http://bugs.conkeror.org/issue410
---
 modules/commands.js |    1 +
 modules/input.js    |    2 ++
 modules/keymap.js   |   23 ++++++++++++++++++++++-
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/modules/commands.js b/modules/commands.js
index 379b50f..d1921a6 100644
--- a/modules/commands.js
+++ b/modules/commands.js
< at >< at > -336,6 +336,7 < at >< at > function send_key_as_event (window, element, combo) {
         split.metaKey,
         split.keyCode,
         split.charCode);
+    event.osKey = split.osKey;
     if (element) {
         return element.dispatchEvent(event);
     } else {
diff --git a/modules/input.js b/modules/input.js
index 6adbec1..327917e 100644
--- a/modules/input.js
+++ b/modules/input.js
< at >< at > -42,6 +42,8 < at >< at > function event_clone (event) {
     this.altKey = event.altKey;
     this.shiftKey = event.shiftKey;
     this.sticky_modifiers = event.sticky_modifiers;
+
+    this.osKey = osKey(event);
 }
 
 
diff --git a/modules/keymap.js b/modules/keymap.js
index ee02f22..2b0b9d4 100644
--- a/modules/keymap.js
+++ b/modules/keymap.js
< at >< at > -33,6 +33,18 < at >< at > function modifier (in_event_p, set_in_event) {
     this.set_in_event = set_in_event;
 }
 
+// xulrunner os-key modifier (version >= 15)
+function osKey (event) {
+    // For events cloned by event_clone, or faked by
+    // send_key_as_event
+    if (event.osKey)
+        return true;
+    // For original/real events
+    if (typeof event.getModifierState == "function")
+        return event.getModifierState("OS");
+    return false;
+}
+
 var modifiers = {
     A: new modifier(function (event) { return event.altKey; },
                     function (event) { event.altKey = true; }),
< at >< at > -75,6 +87,10 < at >< at > if (get_os() == 'Darwin') {
     modifier_order = ['C', 'M', 'A', 'S'];
 } else {
     modifiers.M = modifiers.A;
+    // https://developer.mozilla.org/en-US/docs/DOM/KeyboardEvent#getModifierState()
+    modifiers.s = new modifier(function(event) { return osKey(event); },
+                               function(event) { event.osKey = true; });
+    modifier_order = ['C', 'M', 'S', 's'];
 }
 
 
< at >< at > -117,7 +133,8 < at >< at > function unformat_key_combo (combo) {
         altKey: false,
         ctrlKey: false,
         metaKey: false,
-        shiftKey: false
+        shiftKey: false,
+        osKey: false
     };
     var M;
     var i = 0;
< at >< at > -199,6 +216,7 < at >< at > define_key_match_predicate('match_any_unmodified_character', 'any unmodified cha
                     || event.keyCode > 31)
                 && !modifiers.A.in_event_p(event)
                 && !event.metaKey
+                && !osKey(event)
                 && !event.ctrlKey
                 && !event.sticky_modifiers;
         } catch (e) { return false; }
< at >< at > -209,6 +227,7 < at >< at > define_key_match_predicate('match_checkbox_keys', 'checkbox keys',
         return event.keyCode == 32
             && !event.shiftKey
             && !event.metaKey
+            && !osKey(event)
             && !event.altKey
             && !event.ctrlKey;
         //XXX: keycode fallthroughs don't support sticky modifiers
< at >< at > -220,6 +239,7 < at >< at > define_key_match_predicate('match_text_keys', 'text editing keys',
                 || event.keyCode == 13 || event.keyCode > 31)
             && !event.ctrlKey
             && !event.metaKey
+            && !osKey(event)
             && !modifiers.A.in_event_p(event);
         //XXX: keycode fallthroughs don't support sticky modifiers
     });
< at >< at > -229,6 +249,7 < at >< at > define_key_match_predicate('match_not_escape_key', 'any key but escape',
         return event.keyCode != 27 ||
              event.shiftKey ||
              event.altKey ||
+             osKey(event) ||
              event.metaKey || // M-escape can also leave this mode, so we
                               // need to use an accurate determination of
                               // whether the "M" modifier was pressed,

Re: [PATCH] reddit.js: add support for comments

John J. Foerch — 2013-02-13T02:38:55

For a large patch like this, we should update the legalese of reddit.js.
Do you want copyright on your patch, or to assign it to someone else?

Re: [PATCH] reddit.js: add support for comments

Joren Van Onder — 2013-02-13T03:11:11

Okay, I'd like copyright on my patch. Will you update it? Or should I do it
and send it again?

Re: [PATCH] reddit.js: add support for comments

John J. Foerch — 2013-02-13T03:15:00

I'll do that.  Can you stop by the #conkeror irc channel some time to chat
about the patch?

Re: [PATCH] minibuffer: do not assume saved_focused_frame is alive

Jeremy Maitin-Shepard — 2013-02-10T00:10:53

A larger change based on this patch has now been committed.

On Wed, Feb 6, 2013 at 2:37 AM, Joren Van Onder <joren.vanonder< at >gmail.com>wrote:

_______________________________________________
Conkeror mailing list
Conkeror< at >mozdev.org
https://www.mozdev.org/mailman/listinfo/conkeror

[PATCH] minibuffer: do not assume saved_focused_frame isalive

Joren Van Onder — 2013-02-06T10:37:14

When opening a hyperlink with its target attribute set to "_blank" a
new buffer is opened. When there is no content handler for the
mimetype a content_handler_prompt is opened and the new (blank) buffer
is killed. saved_focused_frame then references a destroyed object.

A simple example of what used to trigger the bug (unless a content
handler for midi files is available):
<a href="a.mid" target="_blank">link</a>
---
 modules/minibuffer.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/minibuffer.js b/modules/minibuffer.js
index 0f3946d..7aec70a 100644
--- a/modules/minibuffer.js
+++ b/modules/minibuffer.js
< at >< at > -358,8 +358,11 < at >< at > minibuffer.prototype = {
                 this.window.buffers.current.browser.focus();
                 if (this.saved_focused_element && this.saved_focused_element.focus)
                     set_focus_no_scroll(this.window, this.saved_focused_element);
-                else if (this.saved_focused_frame)
-                    set_focus_no_scroll(this.window, this.saved_focused_frame);
+                else if (this.saved_focused_frame) {
+                    try {
+                        set_focus_no_scroll(this.window, this.saved_focused_frame);
+                    } catch (e) { /* saved_focused_frame may be dead */ }
+                }
                 this.saved_focused_element = null;
                 this.saved_focused_frame = null;
                 this._show(this.current_message || this.default_message);

Re: zombie tabs

Silvio Levy — 2013-02-06T04:17:40


Will do. Thanks. Also, would the following function be considered too
trivial for the Tips page?  (It wasn't trivial for me, but I got help
from the excellent WritingCommands page.)

interactive("load-file",
            "loads an initialization file",
            function(I) {
                filename= (yield I.minibuffer.read($prompt = "file name: "));
                I.window.minibuffer.message("loaded file "+filename);
                load(make_file(filename));
            }
           );

Best wishes,

Silvio

Re: zombie tabs

John J. Foerch — 2013-02-06T03:32:41

Don't know.  First I've heard of such a problem.  Make use of
bugs.conkeror.org pls.

zombie tabs

Silvio Levy — 2013-02-06T02:53:42

Since I have your attention, let me report another problem, which
while not critical is annoying enough.  I use conkeror in a single
window, with multiple tabs.  Sometimes, when I close the
active tab, its marker remains on the tab bar, though it moves to the
left of the newly active tab.

The buffer itself is no longer accessible -- either by clicking on the
tab bar, or by cycling through the tabs. So there is no way to get rid
of the zombie tab except by restarting conkeror. When I load the
previous session, the zombie is gone.

Certain tasks I do require a lot of tab opening and closing, so I
get a string of zombies, and end up restarting conkeror more often
than I'd like.  

I can't figure out why sometimes a zombie is left and sometimes not.

Silvio

Re: jumps not being read

Silvio Levy — 2013-02-06T02:55:30


OK, thank you!

Silvio

Re: jumps not being read

John J. Foerch — 2013-02-06T02:01:48

By the way, for a single file, pass an nsIFile object to 'load', not a
string.  String arguments are resolved against load_paths, which is not
what you want.  Make nsIFile objects with 'make_file':
load(make_file("~/.c/foo.js"))

Re: jumps not being read

Silvio Levy — 2013-02-06T01:06:45


Ran it and then ran reinit.  No change.  Value of webjumps.foo still empty.

Finally I had the idea of moving /home/levy/.c to /home/levy/.cc and
redefining conkeror.rcfile accordingly. This fixed everything. Moved
it back to /home/levy/.c -- everything still working normally. That
is, changes in jumps.js become active upon reinit, as it used to be.
Caching doesn't seem to be getting in the way (but I'm saving the code
you sent in any case!)

Just one loose end left to tie up: How can I load a specific file by
hand (say one of the files in conkeror.rcfile)?

Thanks a lot for your help.

Silvio

Re: jumps not being read

John J. Foerch — 2013-02-06T00:06:22

The javascript code to clear the startup-cache is as follows:

    var obs = Cc["< at >mozilla.org/observer-service;1"]
        .getService(Ci.nsIObserverService);
    obs.notifyObservers(null, "startupcache-invalidate", null);

You can put this in a command or a function for easy access.

Also, your webjump is called "foo"?  Check the value of webjumps.foo with
the M-: prompt, and see whether it shows up.

What version of XULRunner was it?

Re: jumps not being read

Silvio Levy — 2013-02-05T23:13:57



Good to know. But if I understand your first message, evaluating an
expression with C-: is supposed to clear it, right?


I had caught up with the current version maybe two months ago, and I just
did it again now using

sudo -s; cd /usr/local/src/conkeror; git fetch; git merge origin 

No change in behavior.

Another clue, though, is that changes in bindings.js are likewise not
taking effect (which I hadn't noticed since I seldom make any).  

So yes, it's probably something to do with the startup-cache.  But 
evaluation with M-: definitely doesn't help.

Please tell me:  

1. Is there a command to clear the startup-cache explicitly?

2. How can I load a specific file by hand? (googling didn't help;
M-x load TAB gives nothing)

Silvio

Re: jumps not being read

John J. Foerch — 2013-02-05T22:51:55

The startup-cache does persist across sessions unless explicitly cleared.
How old is your conkeror?

Re: jumps not being read

Silvio Levy — 2013-02-05T22:15:33



Thanks for the reply. Alas, this is not it:

1. evaluating an expression and running reinit makes no difference
2. quitting conkeror and restarting makes no difference
3. as reported in the previous message, jumps.js is not being read
when conkeror starts. From googling "startup cache" I gather than the
startup cache is supposed to last only until the end of the session.

So, something else is "hiding" jumps.js, and using jumps from some
other source.  Please see log below of a session where I cleaned out
my conkerorrc for the purpose.  Note that when I restore my usual
conkerorrc, other things such as preferences and key bindings work as
far as I can tell; only the jumps behave strangely.

Thanks,

Silvio

gar:; ps aux | grep xulr   # make sure no processes survive
levy     21871  0.0  0.0   4660   816 pts/15   S+   19:49   0:00 grep xulr

gar:; ps aux | grep conk   # make sure no processes survive
levy     21873  0.0  0.0   4660   816 pts/15   S+   19:49   0:00 grep conk

gar:;  ls .c   # removed all other files from conkerorrc
jumps.js

gar:; cat .c/jumps.js    # only a single line
define_webjump("foo","file:///u/levy/foo.html");

gar:; xulrunner /usr/local/src/conkeror/application.ini
# no errors or warnings at initialization

C-xC-f about:config confirms that conkeror.rcfile is set to /u/levy/.c
C-xC-f foo  goes to foo.com, ignoring the define_webjump command in jumps.js
C-xC-f sub  goes to http://www.tvsubtitles.net/, a months-old web jump.

Re: jumps not being read

John J. Foerch — 2013-02-05T21:21:12

Sounds like the startup-cache at work.  Try evaluating something with M-:
(a simple number will do), and that will clear the startup cache.

jumps not being read

Silvio Levy — 2013-02-05T20:37:38

My conkeror rc is the directory /u/levy/.c and it is apparently being
read, because most of my customizations work. Also, M-x reinit prints
"Loaded: /u/levy/.c/*.js".

However, the file .c/jumps.js, containing my web jumps, doesn't seem
to be read: all lines added in the last several weeks do not work.
Yet older jumps do work.

Note: the web jumps that don't work are near the top of .c/jumps.js,
so the problem is not that the file is being only partially read. It's
not being read at all. (The read time of the file doesn't get updated
when conkeror is started.)  Yet some older jumps do work.

Any idea what's going on, or how I might debug it?  

output of conkeror -v:
conkeror.mozdev.org conkeror 1.0pre

called with the command
exec xulrunner /usr/local/src/conkeror/application.ini "$< at >"

Thanks,

Silvio