gmane.comp.lang.perl.perl5.porters

[perl #118059] race condition+fail in dist\IO\t\cachepropagate-tcp.t

bulk88 — 2013-05-20T03:24:50

# New Ticket Created by  bulk88 
# Please include the string:  [perl #118059]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=118059 >


This is a bug report for perl from bulk88< at >hotmail.com,
generated with the help of perlbug 1.39 running under perl 5.19.0.


-----------------------------------------------------------------
[Please describe your issue here]

There is a race condition in cachepropagate-tcp.t between the parent 
proc's accept() and the child proc's connection since the child proc has 
a "sleep(1);" delay. On my Win32 32 bit, Server 2003 x64, 8 core, VC 
2008 Perl, the ->accept() times out, does not return an obj, and then 
fatally errors when ->sockdomain() is called on an undefined scalar. Example

___________________________________________________________________________
C:\p519\src\t>..\perl.exe -I..\lib harness ../dist/IO/t/cachepropagate-tcp.t
../dist/IO/t/cachepropagate-tcp.t .. 1/8 Can't call method "sockdomain" 
on an un
defined value at t/cachepropagate-tcp.t line 46.
# Looks like you planned 8 tests but ran 5.
# Looks like your test exited with 9 just after 5.
../dist/IO/t/cachepropagate-tcp.t .. Dubious, test returned 9 (wstat 
2304, 0x900
)
Failed 3/8 subtests

Test Summary Report
-------------------
../dist/IO/t/cachepropagate-tcp.t (Wstat: 2304 Tests: 5 Failed: 0)
  Non-zero exit status: 9
  Parse errors: Bad plan.  You planned 8 tests but ran 5.
Files=1, Tests=5,  2 wallclock secs ( 0.03 usr +  0.00 sys =  0.03 CPU)
Result: FAIL

C:\p519\src\t>
___________________________________________________________________________

running with -v,
___________________________________________________________________________
C:\p519\src\t>..\perl.exe -I..\lib harness -v 
../dist/IO/t/cachepropagate-tcp.t
../dist/IO/t/cachepropagate-tcp.t ..
1..8
ok 1 - socket created
ok 2 - protocol defined
ok 3 - domain defined
ok 4 - type defined
ok 5 - spawned a child
Can't call method "sockdomain" on an undefined value at 
t/cachepropagate-tcp.t l
ine 46.
# Looks like you planned 8 tests but ran 5.
# Looks like your test exited with 9 just after 5.
Dubious, test returned 9 (wstat 2304, 0x900)
Failed 3/8 subtests

Test Summary Report
-------------------
../dist/IO/t/cachepropagate-tcp.t (Wstat: 2304 Tests: 5 Failed: 0)
  Non-zero exit status: 9
  Parse errors: Bad plan.  You planned 8 tests but ran 5.
Files=1, Tests=5,  1 wallclock secs ( 0.02 usr +  0.00 sys =  0.02 CPU)
Result: FAIL

C:\p519\src\t>
__________________________________________________________________________

line 46 is
__________________________________________________________________________
    my $new = $listener->accept();

 >>>>>>>>>>>>>>>>>>    is($new->sockdomain(), $d, 'domain match');
__________________________________________________________________________

accept the function in IO::Socket::accept the method fails with $! being 
"Bad file descriptor"/9. From my research on my machine the timeout is 
undefined, so IO::Select and can_read parts of IO::Socket::accept are 
not executed.

The failing test was added in 
http://perl5.git.perl.org/perl.git/commit/93a5d7bfc07a41ef26fb3e3b298a7d88c3741ed1?f=dist/IO/t/cachepropagate-tcp.t 
as part of CPAN RT #61577 and was written by Daniel Kahn Gillmor. I dont 
see any explanation for the "sleep(1);" in the child fork proc.

If I put a "sleep(1);" before the ->accept(), it passes for me most (4 
trys pass, 5th failed) of the time. If I put a 2 sec sleep, it always 
(10 trys, no fail) passes, but 2 seconds of sleeping is alot of wall 
time wasted. If I remove the sleep(1) from the child proc, it always 
fails (10 fails out of 10 trys). If I put a sleep(1) at the accept, 
remove the sleep(1) at the child (child does not sleep), 10 passes out 
of 10 trys. This sockets/unix IO/unix events stuff I am not very 
familiar with, so I dont know how to fix it.

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
    category=library
    severity=medium
    module=IO
---
Site configuration information for perl 5.19.0:

Configured by Administrator at Sun May 19 19:59:16 2013.

Summary of my perl5 (revision 5 version 19 subversion 0 patch blead 
2013-05-19.21:05:35 bb003204009d113d60d4173c3ed72b10c8169f14 
v5.18.0-25-gbb00320) configuration:
  Snapshot of: bb003204009d113d60d4173c3ed72b10c8169f14
  Platform:
    osname=MSWin32, osvers=5.2, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cl', ccflags ='-nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GS- -GL 
-DWIN32 -D_CONSOLE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE 
-D_CRT_NONSTDC_NO_DEPRECATE  -DPERL_TEXTMODE_SCRIPTS 
-DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO',
    optimize='-O1 -MD -Zi -DNDEBUG -GS- -GL',
    cppflags='-DWIN32'
    ccversion='15.00.30729.01', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', 
lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf 
-ltcg  -libpath:"c:\p519\lib\CORE"  -machine:x86'
    libpth=\lib
    libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  
comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  
netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib 
odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
    perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib 
winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib 
oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  
version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
    libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl519.lib
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug 
-opt:ref,icf -ltcg  -libpath:"c:\p519\lib\CORE"  -machine:x86'

Locally applied patches:
    

---
< at >INC for perl 5.19.0:
    C:/p519/site/lib
    C:/p519/lib
    .

---
Environment for perl 5.19.0:
    CYGWIN=tty
    HOME (unset)
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    
PATH=C:\p519\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\Program 
Files (x86)\Microsoft Visual Studio 9.0\VC\bin;C:\Program Files 
(x86)\Microsoft Visual Studio 9.0\VC;C:\Program Files\TortoiseGit\bin
    PERL_BADLANG (unset)
    SHELL (unset)

Re: [perl #118055] miniperl fails with SIGBUS on sparc (usethreads+use64bitint)

Leon Timmermans — 2013-05-20T03:11:38

This smells like an alignment issue.


That makes perfect sense with my theory. Probably that allocator
should do some padding to 64-bit boundaries.

Leon

[perl #64126] ./Configure -de -Dusevendorprefix doesn't default

James E Keenan via RT — 2013-05-20T02:40:31

Let's try again!  Configure experts, can you take a look?

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=64126

[perl #116851] Test failures on DragonflyBSD

James E Keenan via RT — 2013-05-20T02:37:33

Are these failures still appearing with 5.18.0?

And, assuming they are, do we have an idea how to fix them for this OS

[perl #116158] 5.17.7 breaks rules of assignment

James E Keenan via RT — 2013-05-20T02:34:03

Slight correction:  Sisyphus recommended that ticket be closed, and I
took it in anticipation of closing it within 7 days.



---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116158

[perl #116158] 5.17.7 breaks rules of assignment

James E Keenan via RT — 2013-05-20T02:32:46

It appears that we had *two* tickets in RT titled "5.17* breaks rules of
assignment".  We closed
https://rt.perl.org/rt3/Ticket/Display.html?id=116569 just now.

Could those who participated in the discussion in *this* RT re-evaluate
the discussion and make a recommendation as to whether this ticket
should be kept open; which issues should have new tickets of their own
opened; etc.

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116158

[perl #116098] Error in Getopt::Std documentation examples

James E Keenan via RT — 2013-05-20T02:26:33

Applied in commit 0c0a84c65e572a92388387363562ff4da91a9380.

Thank you very much.  Closing ticket.


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116098

[perl #116569] Re: 5.17.7 breaks rules of assignment

James E Keenan via RT — 2013-05-20T02:10:44

Thanks for getting back so quickly, Rob.

I'll take this ticket for the purpose of closing it in 7 days.  If
anyone wants to keep it open, they can provide a reason and Take it from me.

Thank you very much.
Jim Keenan


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116569

[perl #117313] Modules broken by hash iterator randomization

Ricardo SIGNES via RT — 2013-05-20T01:24:33

I believe we no longer need to keep track of these.

[perl #117473] [PATCH] perl5180delta Fixes

Ricardo SIGNES via RT — 2013-05-20T01:23:41

These largely got applied, thanks.

Re: [perl #116569] Re: 5.17.7 breaks rules of assignment

2013-05-20T00:54:07


-----Original Message----- 
From: James E Keenan via RT


This ticket was created (by me) when COW was enabled by default in 5.17.
Shortly after, COW was disabled by default in 5.17 (and 5.18) - so the 
ticket then became irrelevant wrt default builds of both 5.17 and 5.18. 
However, perl 5.18 *can* be built COW-enabled if the build process is 
configured accordingly.

I have no objection to the closing of this ticket ... and I think that would 
be a reasonable thing to do (though I'm not entirely sure :-)

Cheers,
Rob

[perl #116831] Benchmark tests produce a lot of warnings in 5.17.9

James E Keenan via RT — 2013-05-20T00:35:59

Now that we're post-5.18.0, can someone sum up where we stand with the
issues discussed in this ticket?

If the issues are unresolved, it would be good to know whether we should
continue discussing them in this ticket, versus opening up a new ticket
with a clean statement of the problems.

Thank you very much.
Jim Keenan


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116831

[perl #115910] New copy-on-write breaks CPAN

James E Keenan via RT — 2013-05-20T00:33:09

Now that Perl 5.18.0 is out, it would be good if someone could summarize
the state of issues discussed in this ticket, particularly with respect to:

* Opening tickets for any issues that have appeared with 5.18.0.
* Seeing if we can close *this* ticket.

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=115910

[perl #116569] Re: 5.17.7 breaks rules of assignment

James E Keenan via RT — 2013-05-20T00:30:02

My impression is that the discussion in this RT went all over the place.

Now that Perl 5.18.0 is out, could those who contributed to this ticket
review the discussion with an eye to:

* Creating a new ticket for any well-scoped problem that appears with 5.18.

* Indicating whether we can close *this* ticket.

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116569

[perl #116152] [PATCH] stop "sv_2mortal(&PL_sv_yes)" and "(void)sv_newmortal()" in ParseXS

bulk88 via RT — 2013-05-20T00:05:11

Bump.

[perl #117411] [PATCH] remove obsolete STRUCT_MGVTBL_DEFINITION from mg.h

bulk88 via RT — 2013-05-20T00:03:14

Bump.

[perl #113694] Bleadperl v5.17.0-266-g8a5decd breaks ZEFRAM/Scalar-Number-0.006.tar.gz

James E Keenan via RT — 2013-05-19T23:50:30

wrote:
[snip]

It is still failing on 5.18.0.

#########
Test Summary Report
-------------------
t/class.t     (Wstat: 2560 Tests: 899 Failed: 10)
  Failed tests:  436-437, 440-447
  Non-zero exit status: 10
t/class_pp.t  (Wstat: 512 Tests: 899 Failed: 2)
  Failed tests:  444-445
  Non-zero exit status: 2
t/id_cmp.t    (Wstat: 10240 Tests: 2305 Failed: 40)
  Failed tests:  887, 889-892, 935, 937-940, 983, 985-988
                1028-1030, 1032, 1079, 1081-1084, 1124-1126
                1128, 1172-1174, 1176, 1220-1222, 1224
                1268-1270, 1272
  Non-zero exit status: 40
t/id_cmp_pp.t (Wstat: 4096 Tests: 2305 Failed: 16)
  Failed tests:  891, 939, 987, 1035, 1083, 1131, 1179, 1220-1226
                1228, 1275
  Non-zero exit status: 16
t/part.t      (Wstat: 1792 Tests: 144 Failed: 7)
  Failed tests:  43, 47, 59, 67, 71, 75, 79
  Non-zero exit status: 7
t/part_pp.t   (Wstat: 512 Tests: 144 Failed: 2)
  Failed tests:  67, 75
  Non-zero exit status: 2
Files=9, Tests=6699, 16 wallclock secs ( 3.83 usr  0.49 sys +  7.54 cusr
 0.92 csys = 12.78 CPU)
Result: FAIL
Failed 6/9 test programs. 77/6699 subtests failed.
make: *** [test] Error 255
  ZEFRAM/Scalar-Number-0.006.tar.gz
  /usr/bin/make test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
  reports ZEFRAM/Scalar-Number-0.006.tar.gz
Failed during this command:
 ZEFRAM/Scalar-Number-0.006.tar.gz            : make_test NO
#########

But at this point I think the onus is on the module maintainer to
address the problems.  I recommend that the ticket be closed.

Thank you very much.
Jim Keenan


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=113694

Re: [perl #116098] Error in Getopt::Std documentation examples

Reuben Thomas — 2013-05-19T23:29:51


Apologies; attached.

[perl #117711] can't install deprecated Devel::InnerPackage

James E Keenan via RT — 2013-05-19T23:27:00

chorny,

Can you see if the changes shipped with Perl 5.18.0 clear this problem up?

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=117711

[perl #116098] Error in Getopt::Std documentation examples

James E Keenan via RT — 2013-05-19T23:17:59


I tried applying this patch, but it failed.  I suspect that the failure
was due to the fact that the patch was included inline and I had to try
to copy and paste it into a file.

Would it be possible to re-pull the patch against blead and attach it to
this RT rather than including it in the body of your message.

Thank you very much.
Jim Keenan

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=116098

[perl #117993] Remove unused variable from utf8.pm

James E Keenan via RT — 2013-05-19T23:00:44

Applied to blead in bb003204009d113d60d4173c3ed72b10c8169f14; closing
ticket.

Thank you very much.
Jim Keenan