gmane.comp.java.wicket.devel

Re: [CONF] Apache Wicket > Migration to Wicket 7.0

Ernesto Reinaldo Barreiro — 2013-05-24T17:08:54

Martin,

I do not use inMethod in any of my projects.... but let me know if I can
led a hand.

On Fri, May 24, 2013 at 12:23 PM, Martin Grigorov <mgrigorov-1oDqGaOF3Lkdnm+yROfE0A< at >public.gmane.org>wrote:

Re: [CONF] Apache Wicket > Migration to Wicket 7.0

Martin Grigorov — 2013-05-24T08:23:19

Hi Ernesto,

Thanks for raising this! And for reviewing what we do ! :-)

I think it will be better to update InMethod Grid to the new Tree impl.
I will try to do it at some point. If I don't succeed for some reason I may
copy the old Tree code from Wicket 6.x to InMethod


On Fri, May 24, 2013 at 10:44 AM, Ernesto Reinaldo Barreiro <
reiern70-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:

Re: [CONF] Apache Wicket > Migration to Wicket 7.0

Ernesto Reinaldo Barreiro — 2013-05-24T07:44:11

Martin,

Mind that old tree is used as base for inMethod tree grid. So, either

1-classes might need to be moved there.
2-or rewrite inMethod grid based on new grid implementation.

Cheers,

Ernesto



On Fri, May 24, 2013 at 11:35 AM, <confluence-1oDqGaOF3Lkdnm+yROfE0A< at >public.gmane.org> wrote:

Re: Non-static AjaxFormValidatingBehavior

Sven Meier — 2013-05-23T14:02:52

+1 looks better than before.

 >[line 170]: attributes.setPreventDefault(false);

With WICKET-5197 this is no longer needed for 7.0.0.

I'd suggest that we add this line for 6.9.0 to fix WICKET-5194.

Regards
Sven



On 05/23/2013 01:50 PM, Cedric Gatay wrote:

Re: Non-static AjaxFormValidatingBehavior

Cedric Gatay — 2013-05-23T11:50:17

Hi,
I find it cleaner and easier to use :)

Nice work Martin,

__
Cedric Gatay (< at >Cedric_Gatay <http://twitter.com/Cedric_Gatay>)
http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr


On Thu, May 23, 2013 at 10:30 AM, Martin Grigorov <mgrigorov-1oDqGaOF3Lkdnm+yROfE0A< at >public.gmane.org>wrote:

[ANNOUNCE] WicketStuff 6.8.0 is released

Martin Grigorov — 2013-05-23T09:20:42

Hi,

WicketStuff core 6.8.0 based on Apache Wicket 6.8.0 is released and shortly
will be available in Maven Central.

The changelog for this release is:

Martin Tzvetanov Grigorov (5):
      [gmap3] Issue #210 - Added GIcon constructor with char parameter
      Use Wicket 6.8.0-SNAPSHOT
      Merge branch 'for-upstream2' of https://github.com/wickeria/core into
wickeria-for-upstream2
      [stateless] Import Jolira's stateless components
      release 6.8.0

Horsed (4):
      Project UrlFragment added: Components for reading and writing URL
fragment parameters
      Project UrlFragment added: Components for reading and writing URL
fragment parameters
      changed fragment writing API of bookmarkable components in order to
better encapsulate the corresponding JavaScripts and support custom
fragment updating strategies
      [urlfragment] added method for replacing window.location.hash with a
key-value-pair

dan (3):
      sitemap-xml upgrade to wicket 6
      sitemap-xml upgrade to wicket 6
      sitemap-xml pom artefactId fix

reiern70 (3):
      https://github.com/wicketstuff/core/issues/215. Utility methods to
  trigger events on map.
      added start class to make it easier testing/developing
      Merge branch 'master' of https://github.com/wicketstuff/core.git

Martin Grigorov (2):
      Merge pull request #210 from rbalent/feature
      Merge pull request #214 from seyyaw/master

Nadeem Mohammad (2):
      Fix for issue 205
      Enhance as per 216

Robert Balent (1):
      Issue #209 - Added GIcon constructor with char parameter

seyyaw (1):
      keyboard shortcuts are not working on safari. update it based on the
    latest version here
http://www.openjs.com/scripts/events/keyboard_shortcuts/

svenmeier (1):
      added wicketstuff-lazymodel to modules

The WicketStuff team

Non-static AjaxFormValidatingBehavior

Martin Grigorov — 2013-05-23T08:30:54

Hi,

For https://issues.apache.org/jira/browse/WICKET-5196 I tried to make
AjaxFormValidatingBehavior a bit friendlier for extension.

Please check

AjaxFormValidatingBehavior -
https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=blob;f=wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormValidatingBehavior.java;h=1afcc68533b23b9888112eca0509158b10f99f55;hb=29c952458a8c55974d8e8787fb8cc674e4463824

and the change in its usage -
https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=29c952458a8c55974d8e8787fb8cc674e4463824

What do you think ?
This change is only for 7.0.0.

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Martin Grigorov — 2013-05-22T14:14:55

Please file a ticket so I don't forget and I'll change it.
Or you do it :-)


On Wed, May 22, 2013 at 5:01 PM, Sven Meier <sven-zRslvErEXDSsTnJN9+BGXg< at >public.gmane.org> wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Sven Meier — 2013-05-22T14:01:02

Hi Martin,

I'd say we should change it for 7.x only.

For 6.x it's better to leave it STOP, since that corresponds to the 
behavior before "eventPropagation" was introduced.

Sven

On 05/22/2013 03:46 PM, Martin Grigorov wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Martin Grigorov — 2013-05-22T13:46:54



This is how it was in 6.7.0 and there were two users complaining about the
changed behavior, so we reverted it in 6.8.0 to what it was till 6.6.0.
Do others think that bubble should be the default ?

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Sven Meier — 2013-05-22T13:41:03

With Wicket 7.0.0 we will follow the jquery convention with 
"preventDefault" initially set to false.

< at >Martin:
Shouldn't ARA#eventPropagation set to BUBBLE initially? That would be 
consistent with jquery too.

Sven

On 05/22/2013 03:34 PM, Nick Pratt wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Nick Pratt — 2013-05-22T13:34:32

Hi Martin

I didnt mean to imply that we should change the functionality, just that I
think we should follow the convention of whatever jquery/JS do, except in
the cases where components need to alter this behavior for their correct
functionality. So if the JS/jquery default is to allow event propagation,
then Wicket should default to this same behavior, except where noted.

N


On Wed, May 22, 2013 at 8:44 AM, Martin Grigorov <mgrigorov-1oDqGaOF3Lkdnm+yROfE0A< at >public.gmane.org>wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Martin Grigorov — 2013-05-22T12:44:38

Hi Nick,


On Wed, May 22, 2013 at 3:30 PM, Nick Pratt <nbpratt-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:


We need to prevent the default for AjaxFallback** components because
otherwise both the Ajax and the non-Ajax behaviors will be executed.

We need to stop the propagation of the event by default because otherwise
you may get more than one Ajax calls when you click on a link which is
inside a div which also has listener for 'click' (WICKET-5093).

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Nick Pratt — 2013-05-22T12:30:43

With regards to the default setting of this value, I think we should follow
whatever jquery / JS does by default (I dont know whether this is the case
or not). I think events propagate by default, so any provided components
that need to alter this behavior should explicitly set (false) for this
value.

N


On Wed, May 22, 2013 at 7:14 AM, Martin Grigorov <mgrigorov-1oDqGaOF3Lkdnm+yROfE0A< at >public.gmane.org>wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Martin Grigorov — 2013-05-22T11:14:38


There was a reason why I named it 'allowDefault' but I don't remember it
now.
I'll make a ticket for 7.0.0

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Sven Meier — 2013-05-22T10:46:57

I'm not sure, but it will surely break somewhere.

For 6.x I'd just restore AjaxFormValidatingBehavior's functionality with allowDefault=true iff a throttle is given. This could be done in 6.9.0, a workaround for 6.8.0 exists by copying the #addToAllFormComponents() method.

All developers using throttlingSettings in their own behaviors will have to set allowDefault=true for themselves to restore the old behavior.

For 7.0.0 we could rename the setting to "preventDefault" (as in jquery) with "false" as default value.

Sven



On 05/22/2013 12:30 PM, Martin Grigorov wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Andrea Del Bene — 2013-05-22T10:30:32

After some experiments with the quickstart I think Sven is right. With 
version 6.6.0 it's also impossible to insert an input. However with ver 
6.7.0 is "almost" impossible, meaning that the behavior is a little 
weird. Initially it's impossible, but if you move to the surname field 
and then back to the name field, some characters are randomly accepted.

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Martin Grigorov — 2013-05-22T10:30:07

Ouch!
You are correct!
It is the same behavior in 6.7.0 and 6.6.0.
So, I agree that there is no need of 6.8.1.


I still think we can change the default value for 'allowDefault' to true.
Can you think of a bad scenario when this will break ?
Since there are no user complaints I'm not keen to do the change neither in
6.x nor in 7.0.0 but I think the change is a good improvement.


On Wed, May 22, 2013 at 1:11 PM, Sven Meier <sven-zRslvErEXDSsTnJN9+BGXg< at >public.gmane.org> wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Sven Meier — 2013-05-22T10:11:40

It's been that way ever since:

"keydown" with allowDefault=false -> not character input

Sven

On 05/22/2013 12:07 PM, Martin Grigorov wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Martin Grigorov — 2013-05-22T10:07:43

The quickstart in the ticket is very simple, there is no usage of
throttling.
It's just:

textField.add(new AjaxEventBehavior("keydown") {
 < at >Override
protected void onEvent(AjaxRequestTarget target) {
System.err.println("event");
 }
});

Without explicitly allowing the default behavior the user cannot enter a
single character in the <input type=text>.


On Wed, May 22, 2013 at 1:01 PM, Sven Meier <sven-zRslvErEXDSsTnJN9+BGXg< at >public.gmane.org> wrote:

Re: AjaxRequestAttributes#allowDefault in 6.8.0

Sven Meier — 2013-05-22T10:01:37

AFAICS this is a problem only for behaviors which are throttled. 
AjaxFormValidatingBehavior is the only one in Wicket, we can simple set 
allowDefault=true for that one. And I don't think this is so urgent to 
require a 6.8.1 release.

Anyone else using ThrottlingSettings can easily set allowDefault=true in 
their own behavior.

Changing the default for allowDefault might break many other places in 
user's code :(.

Sven


On 05/22/2013 09:04 AM, Martin Grigorov wrote: