gmane.comp.java.openlaszlo.devel

Re: For Review: Change 20081130-ptw-v Summary: Revertinit arg behavior

André Bargull — 2008-12-02T00:03:52

On 12/1/2008 9:11 PM, P T Withington wrote: It could only be a problem if any construct-method (now or in the future) needs to distinguish between `null` as initial value, or `null` as a marker for binding. But see below, I don't know any decisive arguments (yet) for (or against) the one or the other approach.. I wonder if this a valid argument here, because the iargs need to be a hashtable, so it's both dynamic and all slots are public. :-) I just wanted to be cautious and reduce possible bad user experiences, for instance if a user wants to remove a constraint which is supplied in the iargs-object, and if he sets the entry to `null`, nothing happens, but if he sets the entry to `undefined` (or any other value), the constraint won't be installed. (Yes, I have to admit the example is hypothetical, the user should use `delete`.) There are pros and cons for both approaches, so maybe it's up to personal preference what to do... btw: Still true? Doesn't the compiler know all setters now at compiler-time? btw (2): I also slightly lean toward the Haskell-like syntax for lambda expressions, looks more natural in code. (Haskell-like only because of the backslash) ;-)

So long, and thanks for all the fish

Mamye Kratt — 2008-12-01T23:59:17

Today is my last day. It was a pleasure working with you and I wish Laszlo the best in the future. Mamye AIM: mamye42 EMAIL: mamye< at >comcast.net HOME: 781-391-8606

Re: For Review: Change 20081130-ptw-v Summary: Revertinit arg behavior

P T Withington — 2008-12-01T20:11:09

Good point. I was thinking that I should keep at least a null value in iargs to indicate that the instance had _some_ binding of the argument. I used null to be parallel to the case where there is an initial argument for a slot with a setter: right now LzNode sets the slot to null when the instance is created (rather than leaving it undefined). This seemed to be necessary for some setters to work. I'd like to get away from having to always ask `a in b` and use `b['a'] != null` instead. The `a in b` has caused us trouble in cases where b is not dynamic or a is not a public attribute. Do you think it is really important to go all the way back an not list the argument at all if there is a constraint on it? Thanks for the test case. I'll have a look.

Re: For Review: Change 20081130-ptw-v Summary: Revertinit arg behavior

André Bargull — 2008-12-01T19:41:46

The behaviour doesn't really match 4.0, because the "iargs" are set to `null`, so if a user asks for "'foo' in args", it was `false` in 4.0, but now it's still `true` (if 'foo' is a constraint). What about "deleting" the values from "iargs"? And the changed logic in "LzText#construct(..)" doesn't work, in the following testcase, the fontsize should be 26, but it is the default 11. Should be like so (I think.. at least if the constraint-slot is deleted instead of `null`): (see: http://svn.openlaszlo.org/openlaszlo/tags/4.0.14/WEB-INF/lps/lfc/views/LzText.lzs) test: ---

--- On 12/1/2008 5:55 PM, P T Withington wrote:

Re: Replication example

J Crowley — 2008-12-01T18:33:05

I thought about making them three separate ones, but that kind of makes the laszlo-explorer nav too tall when the L-in-10/Data menu is opened, then. P T Withington wrote:

Re: For Review: 20081201-laszlo-0 Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist, Databinding example 23 exhibits odd behavior

J Crowley — 2008-12-01T18:31:47

Ah, good point. Thanks! I'll fix and file a bug for Lou to eliminate that sentence from the docs. André Bargull wrote:

Re: Replication example

P T Withington — 2008-12-01T17:47:25

Looks fine to me. Perhaps should be 3 separate examples? On 2008-12-01, at 02:03EST, J Crowley wrote:

For Review: Change 20081130-ptw-v Summary: Revert initarg behavior

P T Withington — 2008-12-01T16:55:29

Change 20081130-ptw-v by ptw< at >dueling-banjos.home on 2008-11-30 12:01:16 EST in /Users/ptw/OpenLaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunk Summary: Revert init arg behavior Bugs Fixed: Lpp-7378 LzTextSprite.setPattern warning in Laszlo 4.1.1, not in 4.0.12 LPP-7386 Proposal to revert behavior of LzNode.construct to 4.1 behavior Technical Reviewer: a.bargull< at >intensis.de (pending) QA Reviewer: max (pending) Details: Added a new internal API LzNode/__LZhasConstraint, which can be used in LzNode/construct to determine if an attribute will be constrained by LzNode/__LZapplyArgs. This replaces testing for LzInitExpr's in construct's arglist. LzNode/construct' initargs are now as they were in 4.1 -- only constant initial values appear in that list. Currently only LzText (and subclasses) use the __LZhasConstraint API, because they (apparently) need to know of their width/height will be constrained at construct time. No other LFC classes or component classes use this facility, so I have kept is as an LFC private API. LzTextSprite, LzInputTextSprite: These two sprite classes should not be using the __LZhasConstraint API, but they are probably going to be obsolete soon, so I just fixed them in the most expedient way. LzNode: Remove LzInitExprs from init args when calling construct, while preserving the ability of construct replacing/adding init args. LzText: Use new __LZhasConstraint API. LzText, LzInputText, LaszloView: Simplify construct method, now that args only contains constant values. LzReplicationManager: Clarifying comment hintedlayout: Fix construct arg defaulting bug noted in passing (similar to LPP-7376) Tests: smokecheck, ant test, test case from LPP-7386 Files: M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as M WEB-INF/lps/lfc/kernel/swf/LzInputTextSprite.as M WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as M WEB-INF/lps/lfc/core/LzNode.lzs M WEB-INF/lps/lfc/views/LzInputText.lzs M WEB-INF/lps/lfc/views/LzText.lzs M WEB-INF/lps/lfc/views/LaszloView.lzs M WEB-INF/lps/lfc/data/LzReplicationManager.lzs M demos/lzpixmobile/lib/hintedlayout.lzx Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081130-ptw-v.tar

Re: For Review: Change 20081201-bargull-znZ Summary:add new style setter for "contextmenu"

Henry Minsky — 2008-12-01T16:51:08

approved! On Mon, Dec 1, 2008 at 11:08 AM, André Bargull udo.edu>wrote:

For Review: Change 20081201-bargull-znZ Summary: add new style setter for "contextmenu"

André Bargull — 2008-12-01T16:08:10

Change 20081201-bargull-znZ by bargull< at >dell--p4--2-53 on 2008-12-01 15:57:19 in /home/Admin/src/svn/openlaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunk Summary: add new style setter for "contextmenu" New Features: Bugs Fixed: LPP-7418, LPP-7408 (partial) Technical Reviewer: hminsky QA Reviewer: (pending) Doc Reviewer: (pending) Documentation: Release Notes: Details: SchemaBuilder: - introduce some new types (or the SchemaBuilder will fail to generate the schema) LzDatapointer: - add < at >type for context (the doc explains that this field points to a clonemanager, but there are actually more possibilities, I've enumerated them in a < at >devnote) LaszloView: - add < at >type for contextmenu - add "contextmenu"-setter - deprecate "setContextMenu(..)" - use "contextmenu" directly in "getContextMenu()" (deprecate this method, too?) - remove some legacy code LaszloCanvas: - update callers of "setContextMenu(..)" - add < at >type for "httpdataprovider" and "defaultdataprovider" - add description for "onmouseleave" (copied from LzGlobalMouse) LzContextMenu: - update callers of "setContextMenu(..)" - use the new style setters as the real setters - deprecate the old "setXXX(..)" methods Tests: Files: M WEB-INF/lps/lfc/views/LaszloView.lzs M WEB-INF/lps/lfc/views/LaszloCanvas.lzs M WEB-INF/lps/lfc/data/LzDatapointer.lzs M WEB-INF/lps/lfc/services/LzContextMenu.lzs M WEB-INF/lps/server/src/org/openlaszlo/js2doc/SchemaBuilder.java Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081201-bargull-znZ.tar

Re: UPDATE: For Review: Change 20081128-bargull-RhpSummary: UPDATE: schema build warnings

P T Withington — 2008-12-01T15:33:16

Approved. FWIW, the way to introduce temporary vars at the top level is to put them in a function: if ($profile) { (function () { var ii = Instance.prototype.$lzsc$initialize; ii._dbg_name = ii.name = 'Instance'; })(); } But I seem to forget that more often than not. On 2008-12-01, at 09:56EST, André Bargull wrote:

UPDATE: For Review: Change 20081128-bargull-Rhp Summary: UPDATE: schema build warnings

André Bargull — 2008-12-01T14:56:43

Change 20081128-bargull-Rhp by bargull< at >dell--p4--2-53 on 2008-11-28 22:53:41 in /home/Admin/src/svn/openlaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunk Summary: UPDATE: schema build warnings New Features: Bugs Fixed: LPP-7408 (partial) Technical Reviewer: ptw QA Reviewer: (pending) Doc Reviewer: (pending) Documentation: Release Notes: Details: Class: Changed profile annotation, so it doesn't use a local (actually global) variable to shorten the assignment expression. LzNode: added < at >type LzFont: mark internal properties as < at >access private LzSelectionManager: rename argument to match java-doc LzMakeLoadSprite: rename argument (also a bugfix..) LzBrowserKernel: move doc into code (not really important here, it's a kernel class) LzDataset: rename arg in java-doc to match implementation LzReplicationManager: rename argument to match java-doc Tests: Files: M WEB-INF/lps/lfc/compiler/Class.lzs M WEB-INF/lps/lfc/core/LzNode.lzs M WEB-INF/lps/lfc/data/LzDataset.lzs M WEB-INF/lps/lfc/data/LzReplicationManager.lzs M WEB-INF/lps/lfc/helpers/LzFont.lzs M WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs M WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as M WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081128-bargull-Rhp.tar

Re: For Review: 20081201-laszlo-0 Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist, Databinding example 23 exhibits odd behavior

André Bargull — 2008-12-01T14:21:29

The example (and its documentation) needs to be changed, or else it'll suggest a bit nonsense to the reader: In fact, the "setXPath(..)"-call can be removed completely, you just need to set the rerunxpath-attribute to `false`. And then you also need to adjust this sentence from the doc: Otherwise approved! On 12/1/2008 11:57 AM, J Crowley wrote:

For Review: 20081201-laszlo-0 Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist, Databinding example 23 exhibits odd behavior

J Crowley — 2008-12-01T10:57:23

Change 20081201-laszlo-0 by laszlo< at >T43-L3XEXMW on 2008-12-01 05:36:10 EST in /home/laszlo/src/svn/openlaszlo/trunk-grayfox for http://svn.openlaszlo.org/openlaszlo/trunk Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist Databinding example 23 exhibits odd behavior New Features: Bugs Fixed: LPP-7416 - Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist LPP-7220 - Databinding example 23 exhibits odd behavior Technical Reviewer: ptw QA Reviewer: andre.bargull< at >udo.edu Doc Reviewer: lou< at >louiorio.com Documentation: Release Notes: Details: LPP-7416 - Applied Andre's fix suggestion. LPP-7220 - Changed rerunxpath to false to get the example to function appropriately (with LPP-7416 fixed). Tests: Run databinding-$23.lzx. Click "Next" until you reach the end of the list. Click "Delete". You should now move to the previous node when the current one is deleted, if there is no next node. Compare to an unmodified version, where the data references an invalid node and then subsequently returns all nodes. Files: M WEB-INF/lps/lfc/data/LzDatapointer.lzs M docs/src/developers/programs/databinding-$23.lzx Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081201-laszlo-0.tar

Re: Replication example

J Crowley — 2008-12-01T07:03:18

So how about something like:

Is there anything else I should add to the example that you think should be demonstrated here? P T Withington wrote:

Re: For Review: Change 20081128-Philip-2 Summary: Get lzproject working in swf9

J Crowley — 2008-12-01T06:25:18

Approved! Philip Romanik wrote:

Re: Replication example

J Crowley — 2008-12-01T05:56:41

Thanks! :) P T Withington wrote:

For Review: Change 20081130-hqm-7 Summary: documentLzView.focusable as read/write

Henry Minsky — 2008-12-01T03:02:16

Change 20081130-hqm-7 by hqm< at >badtzmaru.home on 2008-11-30 21:03:47 EST in /Users/hqm/openlaszlo/trunk for http://svn.openlaszlo.org/openlaszlo/trunk Summary: document LzView.focusable as read/write New Features: Bugs Fixed: LPP-6022 Technical Reviewer: max QA Reviewer: mamye Doc Reviewer: (pending) Documentation: Release Notes: Details: Tests: should say read/write in docs Files: M WEB-INF/lps/lfc/views/LaszloView.lzs Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081130-hqm-7.tar

Re: setData() on LzDataText is deprecated?

André Bargull — 2008-11-30T16:08:25

Ok, thanks! I've created "http://www.openlaszlo.org/jira/browse/LPP-7413" to fix it. On 11/30/2008 4:18 PM, Henry Minsky wrote:

Re: For Review: Change 20081130-bargull-a72 Summary:update alldata

Henry Minsky — 2008-11-30T16:01:01

Approved! On Sun, Nov 30, 2008 at 7:54 AM, André Bargull udo.edu>wrote:

Re: For Review: Change 20081129-bargull-85W Summary:turn "setData()" into real setter

Henry Minsky — 2008-11-30T15:59:25

approved! On Sun, Nov 30, 2008 at 6:48 AM, André Bargull udo.edu>wrote: