http://blog.gmane.org/gmane.comp.jakarta.tomcat.devel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120500 <pre> Done. It was pretty straightforward. Please check if I didn't break something? Regards </pre> Mladen Turk 2012-05-24T15:31:25 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120499 <pre>Author: mturk Date: Thu May 24 15:28:13 2012 New Revision: 1342298 URL: http://svn.apache.org/viewvc?rev=1342298&amp;view=rev Log: Move timeouts to tcn_socket_t since they belog to each one individually Modified: tomcat/native/branches/1.1.x/native/include/tcn.h tomcat/native/branches/1.1.x/native/src/poll.c Modified: tomcat/native/branches/1.1.x/native/include/tcn.h URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/include/tcn.h?rev=1342298&amp;r1=1342297&amp;r2=1342298&amp;view=diff ============================================================================== --- tomcat/native/branches/1.1.x/native/include/tcn.h (original) +++ tomcat/native/branches/1.1.x/native/include/tcn.h Thu May 24 15:28:13 2012 &lt; at &gt;&lt; at &gt; -152,6 +152,8 &lt; at &gt;&lt; at &gt; typedef struct { char *jsbbuff; char *jrbbuff; tcn_nlayer_t *net; + apr_time_t last_active; + apr_interval_time_t timeout; } tcn_socket_t; /* Private helper functions */ Modified: tomcat/native/branches/1.1.x/native/src/poll.c URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/poll.c?rev=1342298&amp;r1=1342297&amp;r2=1342298&amp;view=diff ============================================================================== --- tomcat/native/branches/1.1.x/native/src/poll.c (original) +++ tomcat/native/branches/1.1.x/native/src/poll.c Thu May 24 15:28:13 2012 &lt; at &gt;&lt; at &gt; -40,8 +40,6 &lt; at &gt;&lt; at &gt; typedef struct tcn_pollset { apr_pollset_t *pollset; jlong *set; apr_pollfd_t *socket_set; - apr_time_t *socket_last_active; - apr_interval_time_t *socket_timeout; apr_interval_time_t default_timeout; #ifdef TCN_DO_STATISTICS int sp_added; &lt; at &gt;&lt; at &gt; -129,10 +127,6 &lt; at &gt;&lt; at &gt; TCN_IMPLEMENT_CALL(jlong, Poll, create)( TCN_CHECK_ALLOCATED(tps-&gt;set); tps-&gt;socket_set = apr_palloc(p, size * sizeof(apr_pollfd_t)); TCN_CHECK_ALLOCATED(tps-&gt;socket_set); - tps-&gt;socket_last_active = apr_palloc(p, size * sizeof(apr_time_t)); - TCN_CHECK_ALLOCATED(tps-&gt;socket_last_active); - tps-&gt;socket_timeout = apr_palloc(p, size * sizeof(apr_interval_time_t)); - TCN_CHECK_ALLOCATED(tps-&gt;socket_timeout); tps-&gt;nelts = 0; tps-&gt;nalloc = size; tps-&gt;pool = p; &lt; at &gt;&lt; at &gt; -174,21 +168,21 &lt; at &gt;&lt; at &gt; static apr_status_t do_add(tcn_pollset_t #endif return APR_ENOMEM; } - memset(&amp;fd, 0, sizeof(apr_pollfd_t)); - fd.desc_type = APR_POLL_SOCKET; - fd.reqevents = reqevents; - fd.desc.s = s-&gt;sock; - fd.client_data = s; - if (timeout == TCN_NO_SOCKET_TIMEOUT) { timeout = p-&gt;default_timeout; } if (timeout &gt; 0) - p-&gt;socket_last_active[p-&gt;nelts] = apr_time_now(); + s-&gt;last_active = apr_time_now(); else - p-&gt;socket_last_active[p-&gt;nelts] = 0; + s-&gt;last_active = 0; + s-&gt;timeout = socket_timeout; + + memset(&amp;fd, 0, sizeof(apr_pollfd_t)); + fd.desc_type = APR_POLL_SOCKET; + fd.reqevents = reqevents; + fd.desc.s = s-&gt;sock; + fd.client_data = s; - p-&gt;socket_timeout[p-&gt;nelts] = socket_timeout; p-&gt;socket_set[p-&gt;nelts] = fd; p-&gt;nelts++; #ifdef TCN_DO_STATISTICS &lt; at &gt;&lt; at &gt; -232,11 +226,13 &lt; at &gt;&lt; at &gt; static apr_status_t do_remove(tcn_pollse /* Found an instance of the fd: remove this and any other copies */ apr_int32_t dst = i; apr_int32_t old_nelts = p-&gt;nelts; + tcn_socket_t *ds = (tcn_socket_t *)p-&gt;socket_set[dst].client_data; p-&gt;nelts--; #ifdef TCN_DO_STATISTICS p-&gt;sp_removed++; #endif for (i++; i &lt; old_nelts; i++) { + tcn_socket_t *ss = (tcn_socket_t *)p-&gt;socket_set[i].client_data; if (fd-&gt;desc.s == p-&gt;socket_set[i].desc.s) { #ifdef TCN_DO_STATISTICS p-&gt;sp_equals++; &lt; at &gt;&lt; at &gt; -245,8 +241,8 &lt; at &gt;&lt; at &gt; static apr_status_t do_remove(tcn_pollse } else { p-&gt;socket_set[dst] = p-&gt;socket_set[i]; - p-&gt;socket_last_active[dst] = p-&gt;socket_last_active[i]; - p-&gt;socket_timeout[dst] = p-&gt;socket_timeout[i]; + ds-&gt;last_active = ss-&gt;last_active; + ds-&gt;timeout = ss-&gt;timeout; dst++; } } &lt; at &gt;&lt; at &gt; -262,8 +258,9 &lt; at &gt;&lt; at &gt; static void update_last_active(tcn_polls for (i = 0; i &lt; p-&gt;nelts; i++) { if (fd-&gt;desc.s == p-&gt;socket_set[i].desc.s) { + tcn_socket_t *s = (tcn_socket_t *)p-&gt;socket_set[i].client_data; /* Found an instance of the fd: update last active time */ - p-&gt;socket_last_active[i] = t; + s-&gt;last_active = t; break; } } &lt; at &gt;&lt; at &gt; -327,14 +324,15 &lt; at &gt;&lt; at &gt; TCN_IMPLEMENT_CALL(jint, Poll, poll)(TCN /* Find the minimum timeout */ for (i = 0; i &lt; p-&gt;nelts; i++) { apr_interval_time_t socket_timeout = 0; - if (p-&gt;socket_timeout[i] == TCN_NO_SOCKET_TIMEOUT) { + tcn_socket_t *s = (tcn_socket_t *)p-&gt;socket_set[i].client_data; + if (s-&gt;timeout == TCN_NO_SOCKET_TIMEOUT) { socket_timeout = p-&gt;default_timeout; } else { - socket_timeout = p-&gt;socket_timeout[i]; + socket_timeout = s-&gt;timeout; } if (socket_timeout &gt;= 0) { - apr_interval_time_t t = now - p-&gt;socket_last_active[i]; + apr_interval_time_t t = now - s-&gt;last_active; if (t &gt;= socket_timeout) { ptime = 0; break; &lt; at &gt;&lt; at &gt; -403,18 +401,18 &lt; at &gt;&lt; at &gt; TCN_IMPLEMENT_CALL(jint, Poll, maintain) /* Check for timeout sockets */ for (i = 0; i &lt; p-&gt;nelts; i++) { apr_interval_time_t timeout = 0; - if (p-&gt;socket_timeout[i] == TCN_NO_SOCKET_TIMEOUT) { + tcn_socket_t *s = (tcn_socket_t *)p-&gt;socket_set[i].client_data; + if (s-&gt;timeout == TCN_NO_SOCKET_TIMEOUT) { timeout = p-&gt;default_timeout; } else { - timeout = p-&gt;socket_timeout[i]; + timeout = s-&gt;timeout; } if (timeout == -1) { continue; } - if ((now - p-&gt;socket_last_active[i]) &gt;= timeout) { - fd = p-&gt;socket_set[i]; - p-&gt;set[num++] = P2J(fd.client_data); + if ((now - s-&gt;last_active) &gt;= timeout) { + p-&gt;set[num++] = P2J(s); } } if (remove &amp;&amp; num) { </pre> mturk< at >apache.org 2012-05-24T15:28:13 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120498 <pre> That works for me. I should be able to run some basic tests with my modified WebSocket coed by then to check that I actually get infinite time outs (not much point releasing if that doesn't work). If I don;t shout, assume all is OK. Mark </pre> Mark Thomas 2012-05-24T15:18:15 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120497 <pre> I'll see if I'll catch some time tomorrow. Next week? Regards </pre> Mladen Turk 2012-05-24T15:06:37 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120496 <pre> Makes sense to me although I'm unlikely to get to it any time soon. On a related note, thoughts on a 1.1.24 release? We are going to need that for the 7.0.28 release (although that is still a little way off with 15+ open bugs to fix first). Mark </pre> Mark Thomas 2012-05-24T14:47:00 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120495 <pre>2012/5/24 Konstantin Kolinko &lt;knst.kolinko&lt; at &gt;gmail.com&gt;: I see it is has already been fixed by http://svn.apache.org/viewvc?view=revision&amp;revision=1342014 Sorry for the noise. Best regards, Konstantin Kolinko </pre> Konstantin Kolinko 2012-05-24T14:32:56 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120494 <pre>2012/5/24 &lt;markt&lt; at &gt;apache.org&gt;: Looking at the declaration of "socket_last_active" field, the above should have used sizeof(apr_time_t). Best regards, Konstantin Kolinko </pre> Konstantin Kolinko 2012-05-24T14:18:38 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120493 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53289 Priority: P2 Bug ID: 53289 Assignee: dev&lt; at &gt;tomcat.apache.org Summary: Clarify ResourceLink example that uses getConnection(username, password) Severity: enhancement Classification: Unclassified OS: Windows XP Reporter: knst.kolinko&lt; at &gt;gmail.com Hardware: PC Status: NEW Version: 7.0.27 Component: Documentation Product: Tomcat 7 It was reported on the users list: http://marc.info/?t=133780532900005&amp;r=1&amp;w=2 http://markmail.org/thread/26yhdl7pfhdm2dic In documentation there is example [1] on using a ResourceLink with specific value for the factory, org.apache.naming.factory.DataSourceLinkFactory. It allows to specify custom username and password while reusing connections from a global datasource pool. This feature was added per bug 49543. The problem is that there is an important bit that is lacking from the description: this feature requires support from the pool implementation for getConnection(username, password) method. - In Apache Commons DBCP pool there is no support for that method [2]. An UnsupportedOperationException will be thrown. (DBCP 1.4) - In Apache Tomcat JDBC pool support for this feature is off by default (username and password are ignored). It can be enabled by setting alternateUsernameAllowed="true". [3] [1] http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Resource_Links [2] http://commons.apache.org/dbcp/apidocs/org/apache/commons/dbcp/BasicDataSource.html#getConnection%28java.lang.String,%20java.lang.String%29 [3] http://tomcat.apache.org/tomcat-7.0-doc/jdbc-pool.html </pre> bugzilla< at >apache.org 2012-05-24T13:58:15 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120492 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53288 Konstantin Kolinko &lt;knst.kolinko&lt; at &gt;gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID OS| |All --- Comment #1 from Konstantin Kolinko &lt;knst.kolinko&lt; at &gt;gmail.com&gt; --- 1. Bugzilla is not a support forum. Configuration questions should be asked on the users&lt; at &gt; mailing list. http://tomcat.apache.org/bugreport.html#Bugzilla_is_not_a_support_forum Regarding your configuration, I do not see any apparent problems. The only one is that installing into "Program Files" on Vista and later has known problems with permissions. It is mentioned on the "Windows" page of the FAQ. You'd better install it somewhere else and without whitespace in the folder name. 2. The service runner comes from the Apache Commons Daemon project. If there is a bug in it, it is for that project to track and fix it. http://tomcat.apache.org/bugreport.html#Third_party_components </pre> bugzilla< at >apache.org 2012-05-24T11:28:58 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120491 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53288 Priority: P2 Bug ID: 53288 Assignee: dev&lt; at &gt;tomcat.apache.org Summary: Tomcat Windows service goes in "Starting" rather than in "Started" state on Windows 2008 (x64 bit) OS. Severity: major Classification: Unclassified Reporter: anand.rashinkar&lt; at &gt;gmail.com Hardware: PC Status: NEW Version: 6.0.35 Component: Catalina Product: Tomcat 6 OS : Windows 2008 R2 (64 bit) JRE : 1.6.10 (32 bit) Tomcat 6.0.14 (32 bit) Also tested with Tomcat version 6.0.35 (32 bit) Tomcat intermittently doesn't start as a windows service and goes to Starting state instead. Following are log excerpts during startup for this issue. [2012-05-24 09:24:33] [debug] ( javajni.c:206 ) loading jvm 'C:\Program Files (x86)\Tomcat_Install\IC72\Java\bin\server\jvm.dll' [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[0] -Dcatalina.base=C:\Program Files (x86)\Tomcat_Install\IC72\tomcat [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[1] -Dcatalina.home=C:\Program Files (x86)\Tomcat_Install\IC72\tomcat [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[2] -Djava.endorsed.dirs=C:\Program Files (x86)\Avaya\IC72\tomcat\common\endorsed [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[3] -Djava.io.tmpdir=C:\Program Files (x86)\Tomcat_Install\IC72\tomcat\temp [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[4] -Xbootclasspath/a:C:\Program Files (x86)\Tomcat_Install\IC72\tomcat\common\lib\mail.jar [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[5] -Dlog4j.configuration=log4j.xml [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[6] -Dlog4j.debug=true [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[7] -Dhome=C:\Program Files (x86)\Tomcat_Install\IC72 [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[8] -Djava.security.auth.login.config=C:\Program Files (x86)\Avaya\IC72\sdk\cup.security [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[9] -Djava.class.path=C:\Program Files (x86)\Tomcat_Install\IC72\tomcat\bin\bootstrap.jar;. [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[10] -Xms256m [2012-05-24 09:24:33] [debug] ( javajni.c:660 ) Jvm Option[11] -Xmx768m [2012-05-24 09:24:34] [debug] ( javajni.c:844 ) argv[0] = -config [2012-05-24 09:24:34] [debug] ( javajni.c:844 ) argv[1] = C:\Program Files (x86)\Tomcat_Install\IC72\tomcat\conf\server.sdk.xml [2012-05-24 09:24:34] [debug] ( javajni.c:844 ) argv[2] = start As one can see from above logs , tomcat accepts the application specific arguments and is about to start Java (Worker thread) , but somehow it gets stuck at this point after parsing the variable arguments to Tomcat process , and hence the tomcat windows service goes in Starting state. But it sometimes runs cleanly and goes ahead and starts the worker thread. Are there any specific settings needed for Tomcat 32 bit/JRE 32 bit and Win 2k8 64 combination ? I face this issue 6 out of 10 times. Installed tomcat as a service using the service.bat tomcat utility. I face no issues on WIndows 2003 32 bit OS with same tomcat 6.0.14 (32 bit) and JRE 1.6.10 (32 bit) After a clean startup , following trailing tomcat logs are produced (DEBUG MODE). [2012-05-24 09:32:41] [debug] ( javajni.c:844 ) argv[0] = -config [2012-05-24 09:32:41] [debug] ( javajni.c:844 ) argv[1] = C:\Program Files (x86)\Tomcat_Install\IC72\tomcat\conf\server.icsdk.xml [2012-05-24 09:32:41] [debug] ( javajni.c:844 ) argv[2] = start [2012-05-24 09:32:41] [debug] ( javajni.c:896 ) Java Worker thread started org/apache/catalina/startup/Bootstrap:main [2012-05-24 09:32:42] [debug] ( prunsrv.c:1067) Java started org/apache/catalina/startup/Bootstrap [2012-05-24 09:32:43] [info] ( :0 ) Service started in 3744 ms. [2012-05-24 09:32:43] [debug] ( prunsrv.c:1394) Waiting for worker to finish... </pre> bugzilla< at >apache.org 2012-05-24T11:05:50 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120490 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=52055 --- Comment #13 from Sudhan Moghe &lt;sudhan.moghe&lt; at &gt;gmail.com&gt; --- Rest of the stack trace is my application code. I am starting async processing with if (request.isAsyncSupported()) { final AsyncContext asyncCtx = request.startAsync(request, response); final Runnable command = new AsyncRequestProcessor(asyncCtx, this, this.actionObjects); Executor executor = (Executor)request.getServletContext().getAttribute(Constants.ASYNC_REQUEST_EXECUTOR); executor.execute(command); } Next line on stack trace is ServletUtils.getBytesOfStream(ServletUtils.java:425) Code of same is public static ByteArrayInputStreamExt getBytesOfStream(final Map&lt;String, Object&gt; helperMap, final InputStream stream, int len, boolean chunked) throws IOException { try { ByteArrayInputStreamExt bais = (ByteArrayInputStreamExt) helperMap.get(Constants.DATA); byte[] tempBuf = null; if (bais == null) { tempBuf = new byte[len]; bais = new ByteArrayInputStreamExt(tempBuf); } else { tempBuf = bais.getBuffer(); } int readSoFar = 0; int bytesRead = 0; while (len &gt; readSoFar) { bytesRead = stream.read(tempBuf, readSoFar, (len - readSoFar)); if (bytesRead == -1) { if (chunked) { if (readSoFar == 0) { bais.reset(0); return bais; } else { bais.reset(readSoFar); return bais; } } throw new IOException("Failed to read from inputstream"); } readSoFar += bytesRead; } bais.reset(len); return bais; } catch (OutOfMemoryError th) { logger.error("Creating a byte array of length: " + len + " has resulted in OOM error: " + th.getMessage()); } return null; } And this method is called with ServletUtils.getBytesOfStream(request.getInputStream(), length); This method is called in a loop reading 10MB at a time. For chunked, loop stops with EOF. The ByteArrayInputStreamExt handling is for reusing the byte[]. This happens only when client aborts. Let me know if you need anymore info. Which class should I check if I have to debug this? Thanks, Sudhan </pre> bugzilla< at >apache.org 2012-05-24T08:43:54 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120489 <pre>To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at general&lt; at &gt;gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 10 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 23 mins 27 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-24052012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-24052012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-24052012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-24052012.jar -Dtomcat-db cp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-24052012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv /gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/l ib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org .eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-24052012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-24052012.jar:/srv/gump/public/workspace/junit/dist/junit-24052012.jar --------------------------------------------- [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) [junit] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) [junit] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:269) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:69) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:48) [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:237) [junit] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:61) [junit] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:235) [junit] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:51) [junit] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:228) [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:306) [junit] at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:520) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1060) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:911) [junit] May 24, 2012 5:27:36 AM org.apache.coyote.AbstractProtocol start [junit] INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-2-33872"] [junit] May 24, 2012 5:27:36 AM org.apache.coyote.AbstractProtocol pause [junit] INFO: Pausing ProtocolHandler ["http-nio-127.0.0.1-auto-2-33872"] [junit] May 24, 2012 5:27:36 AM org.apache.catalina.core.StandardService stopInternal [junit] INFO: Stopping service Tomcat [junit] May 24, 2012 5:27:36 AM org.apache.catalina.core.ApplicationContext log [junit] INFO: SessionListener: contextDestroyed() [junit] May 24, 2012 5:27:36 AM org.apache.catalina.core.ApplicationContext log [junit] INFO: ContextListener: contextDestroyed() [junit] May 24, 2012 5:27:36 AM org.apache.coyote.AbstractProtocol stop [junit] INFO: Stopping ProtocolHandler ["http-nio-127.0.0.1-auto-2-33872"] [junit] May 24, 2012 5:27:36 AM org.apache.coyote.AbstractProtocol destroy [junit] INFO: Destroying ProtocolHandler ["http-nio-127.0.0.1-auto-2-33872"] [junit] Running org.apache.tomcat.util.res.TestStringManager [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.026 sec [junit] Running org.apache.tomcat.util.scan.TestJarScanner [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.283 sec [junit] May 24, 2012 5:27:38 AM org.apache.coyote.AbstractProtocol destroy [junit] INFO: Destroying ProtocolHandler ["http-nio-127.0.0.1-auto-1"] [junit] Running org.apache.tomcat.util.threads.TestLimitLatch [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 2.448 sec test-apr-exists: test-apr: test: BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:1149: Some tests completed with a Failure. See /srv/gump/public/workspace/tomcat-trunk/output/build/logs for details, search for "FAILED". Total time: 23 minutes 27 seconds --------------------------------------------- To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/atom.xml ============================== Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 13000024052012, vmgump.apache.org:vmgump:13000024052012 Gump E-mail Identifier (unique within run) #46. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] </pre> Bill Barker 2012-05-24T05:27:51 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120488 <pre>To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at general&lt; at &gt;gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 5 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build) Work ended in a state of : Failed Elapsed: 23 mins 14 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-24052012.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-24052012-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-24052012-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-24052012.jar -Dtomcat-db cp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/ srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-24052012.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv /gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.co re_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-24052012.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-24052012.jar:/srv/gump/ public/workspace/junit/dist/junit-24052012.jar --------------------------------------------- [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) [junit] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) [junit] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:269) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:69) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:48) [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:237) [junit] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:61) [junit] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:235) [junit] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:51) [junit] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:228) [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:306) [junit] at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:520) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1060) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:911) [junit] May 24, 2012 4:58:04 AM org.apache.coyote.AbstractProtocol start [junit] INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-2-39465"] [junit] May 24, 2012 4:58:04 AM org.apache.coyote.AbstractProtocol pause [junit] INFO: Pausing ProtocolHandler ["http-nio-127.0.0.1-auto-2-39465"] [junit] May 24, 2012 4:58:04 AM org.apache.catalina.core.StandardService stopInternal [junit] INFO: Stopping service Tomcat [junit] May 24, 2012 4:58:04 AM org.apache.catalina.core.ApplicationContext log [junit] INFO: SessionListener: contextDestroyed() [junit] May 24, 2012 4:58:04 AM org.apache.catalina.core.ApplicationContext log [junit] INFO: ContextListener: contextDestroyed() [junit] May 24, 2012 4:58:04 AM org.apache.coyote.AbstractProtocol stop [junit] INFO: Stopping ProtocolHandler ["http-nio-127.0.0.1-auto-2-39465"] [junit] May 24, 2012 4:58:04 AM org.apache.coyote.AbstractProtocol destroy [junit] INFO: Destroying ProtocolHandler ["http-nio-127.0.0.1-auto-2-39465"] [junit] Running org.apache.tomcat.util.res.TestStringManager [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.026 sec [junit] Running org.apache.tomcat.util.scan.TestJarScanner [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.273 sec [junit] May 24, 2012 4:58:06 AM org.apache.coyote.AbstractProtocol destroy [junit] INFO: Destroying ProtocolHandler ["http-nio-127.0.0.1-auto-1"] [junit] Running org.apache.tomcat.util.threads.TestLimitLatch [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 2.464 sec test-apr-exists: test-apr: test: BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:1127: Some tests completed with a Failure. See /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs for details, search for "FAILED". Total time: 23 minutes 13 seconds --------------------------------------------- To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/atom.xml ============================== Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 13000024052012, vmgump.apache.org:vmgump:13000024052012 Gump E-mail Identifier (unique within run) #45. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] </pre> Bill Barker 2012-05-24T04:58:20 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120487 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53285 Priority: P2 Bug ID: 53285 Assignee: dev&lt; at &gt;tomcat.apache.org Summary: Web app configuration fails when security-role-ref does not contain role-link Severity: normal Classification: Unclassified OS: Windows XP Reporter: sjdavies&lt; at &gt;acm.org Hardware: PC Status: NEW Version: 7.0.27 Component: Catalina Product: Tomcat 7 Created attachment 28829 --&gt; https://issues.apache.org/bugzilla/attachment.cgi?id=28829&amp;action=edit Sample WAR The &lt;role-link&gt; element is optional content within &lt;security-role-ref&gt;. However, an application will fail to deploy if the optional element is missing. I've attached a sample WAR that highlights the problem. Note, the attached WAR will deploy ok in 6.0.35. Console output from running 7.0.27 embedded in Eclipse: INFO: Starting Servlet Engine: Apache Tomcat/7.0.27 24/05/2012 2:32:34 PM org.apache.tomcat.util.digester.Digester endElement SEVERE: End event threw exception Throwable occurred: java.lang.IllegalArgumentException: Can't convert argument: null at org.apache.tomcat.util.IntrospectionUtils.convert(IntrospectionUtils.java:966) at org.apache.tomcat.util.digester.CallMethodRule.end(CallMethodRule.java:476) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1051) at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1537) at org.apache.catalina.startup.ContextConfig.parseWebXml(ContextConfig.java:1825) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1201) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:855) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:345) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1566) at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1556) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:314) at java.util.concurrent.FutureTask.run(FutureTask.java:149) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:897) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:919) at java.lang.Thread.run(Thread.java:736) 24/05/2012 2:32:34 PM org.apache.catalina.startup.ContextConfig parseWebXml SEVERE: Parse error in application web.xml file at jndi:/localhost/testApp/WEB-INF/web.xml Throwable occurred: java.lang.IllegalArgumentException: Can't convert argument: null at org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2687) at org.apache.tomcat.util.digester.Digester.createSAXException(Digester.java:2719) at org.apache.tomcat.util.digester.Digester.endElement(Digester.java:1054) at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanEndElement(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1537) at org.apache.catalina.startup.ContextConfig.parseWebXml(ContextConfig.java:1825) at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1201) at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:855) at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:345) at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5161) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1566) at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1556) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:314) at java.util.concurrent.FutureTask.run(FutureTask.java:149) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:897) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:919) at java.lang.Thread.run(Thread.java:736) 24/05/2012 2:32:34 PM org.apache.catalina.startup.ContextConfig parseWebXml SEVERE: Occurred at line 18 column 23 </pre> bugzilla< at >apache.org 2012-05-24T04:52:55 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120486 <pre> Think we should move both socket_last_active and socket_timeout to tcn_socket_t. They are always bound to socket and we won't have to allocate two additional arrays and copying won't be needed since they will be part of apr_pollfd's client_data Regards </pre> Mladen Turk 2012-05-24T04:19:03 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120485 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53283 --- Comment #6 from Marvin Addison &lt;marvin.addison&lt; at &gt;gmail.com&gt; --- Actually, it was leveraging the system property replacement feature in the docs you cited that led to this enhancement request. We were setting system properties in setenv.sh, but then discovered that had the very undesirable consequence of leaking sensitive data to anyone on the system via ps output. While I could have engineered a valve or something to set system properties more discretely, storing credentials in a global, long-term facility seemed less desirable than a more targeted solution. The patch here is about 20 lines and adds reasonable value. I hope you'll consider it. I'm happy to respond to feedback on the patch if that will increase the likelihood of acceptance. </pre> bugzilla< at >apache.org 2012-05-23T21:49:20 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120484 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53283 --- Comment #5 from Mark Thomas &lt;markt&lt; at &gt;apache.org&gt; --- http://tomcat.apache.org/tomcat-7.0-doc/config/index.html Second paragraph. Lots of ways to set the property values for replacement. </pre> bugzilla< at >apache.org 2012-05-23T21:37:23 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120483 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53283 --- Comment #4 from Konstantin Kolinko &lt;knst.kolinko&lt; at &gt;gmail.com&gt; --- http://wiki.apache.org/tomcat/FAQ/Password </pre> bugzilla< at >apache.org 2012-05-23T21:33:35 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120482 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53283 --- Comment #3 from Marvin Addison &lt;marvin.addison&lt; at &gt;gmail.com&gt; --- I'm embarrassed if that's supported and I missed it. I took the time for a thoughtful code review of jdbc-pool and didn't see what I was looking for, so wrote a simple patch. If it's not too much trouble, I wonder if you'd quickly review the patch to see if similar functionality is supported. If so I'll follow up on list. </pre> bugzilla< at >apache.org 2012-05-23T21:27:40 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120481 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=53283 --- Comment #2 from Marvin Addison &lt;marvin.addison&lt; at &gt;gmail.com&gt; --- Created attachment 28828 --&gt; https://issues.apache.org/bugzilla/attachment.cgi?id=28828&amp;action=edit Patch for externalized credentials in properties file. Attached patch for this feature made against jdbc-pool-1.2-SNAPSHOT. I've tested this against tomcat-7.0.27 and works as expected. </pre> bugzilla< at >apache.org 2012-05-23T21:25:20 http://permalink.gmane.org/gmane.comp.jakarta.tomcat.devel/120480 <pre>https://issues.apache.org/bugzilla/show_bug.cgi?id=52055 Mark Thomas &lt;markt&lt; at &gt;apache.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO --- Comment #12 from Mark Thomas &lt;markt&lt; at &gt;apache.org&gt; --- Full stack traces please. </pre> bugzilla< at >apache.org 2012-05-23T21:24:13 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.jakarta.tomcat.devel