http://blog.gmane.org/gmane.comp.jakarta.tapestry.devel hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50029 <pre>https://issues.apache.org/jira/browse/TAP5-1938 Done On Thu, May 24, 2012 at 4:28 PM, Igor Drobiazko &lt;igor.drobiazko&lt; at &gt;gmail.com&gt; wrote: </pre> Dimitris Zenios 2012-05-24T14:19:19 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50028 <pre>Dimitris Zenios created TAP5-1938: ------------------------------------- Summary: The ValueEncoder for JPA entity types should encode transient instances as null rather than throw an exception Key: TAP5-1938 URL: https://issues.apache.org/jira/browse/TAP5-1938 Project: Tapestry 5 Issue Type: Bug Components: tapestry-jpa Affects Versions: 5.3.3, 5.3.4 Reporter: Dimitris Zenios The current behavior gets in the way in many cases, such as creating a single page that will either edit an existing entity or editing a newly created entity before its first save, where the instance (transient or persistent) is stored as page activation context. Same bug for Tapestry-Hibernate was resolved from Howard https://issues.apache.org/jira/browse/TAP5-1641 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Dimitris Zenios (JIRA 2012-05-24T14:18:57 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50027 <pre>Pleas fill an issue On Tue, May 22, 2012 at 5:43 PM, Dimitris Zenios &lt;dimitris.zenios&lt; at &gt;gmail.com&gt;wrote: </pre> Igor Drobiazko 2012-05-24T13:28:17 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50026 <pre>Yes, I'm using it every day. Awesome. On Thu, May 24, 2012 at 2:32 PM, Massimo Lusetti &lt;mlusetti&lt; at &gt;gmail.com&gt; wrote: </pre> Igor Drobiazko 2012-05-24T13:27:40 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50025 <pre>Tim Böhler created TAP5-1937: -------------------------------- Summary: removeCookieValue with custom path Key: TAP5-1937 URL: https://issues.apache.org/jira/browse/TAP5-1937 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3.3 Reporter: Tim Böhler Priority: Minor When you write a cookie value, you can set additionally domain and path. But when you delete a cookie, the path is always set to request.getContext()+"/". So that, cookies saved with the path different from context+"/" are never deleted. This issue was already mentioned here: http://tapestry.1045711.n5.nabble.com/T5-1-Cookies-removeCookieValue-issue-td2435448.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Tim Böhler (JIRA 2012-05-24T13:00:57 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50024 <pre>Hi dev, I've realized that spockframework has a tapestry module to let you test tapestry-ioc applications. Thats great! Did anyone of you actually used it? Cheers </pre> Massimo Lusetti 2012-05-24T12:32:40 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50023 <pre> The correct mirror at github is named after the new repo at git-wip so is: https://github.com/apache/tapestry-5 I'm in contact with Jukka who is doing all the work to remove the old repo. Cheers </pre> Massimo Lusetti 2012-05-24T07:22:43 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50022 <pre>Anyone? On Tue, May 22, 2012 at 6:43 PM, Dimitris Zenios &lt;dimitris.zenios&lt; at &gt;gmail.com&gt; wrote: </pre> Dimitris Zenios 2012-05-23T17:40:36 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50021 <pre> [ https://issues.apache.org/jira/browse/TAP5-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&amp;focusedCommentId=13281196#comment-13281196 ] Ray Nicholus edited comment on TAP5-1933 at 5/23/12 4:12 PM: ------------------------------------------------------------- We addressed this in our own project by using the following regex pattern (lifted from regular-expressions.info): [a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+)*&lt; at &gt;(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])? So, the Email validator class can be fixed by removing all of the regex patterns other than the PATTERN object, and then replacing the regex text in the PATTERN object with the one referenced above. was (Author: rnicholus): We addressed this in our own project by using the following regex pattern (lifted from regular-expressions.info): [a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+)*&lt; at &gt;(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])? So, the Email validator class can be fixed by removing all of the regex patterns other than the PATTERN object, and then replacing the regex text in the PATTERN object with the one references above. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Ray Nicholus (JIRA 2012-05-23T16:12:41 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50020 <pre> [ https://issues.apache.org/jira/browse/TAP5-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&amp;focusedCommentId=13281196#comment-13281196 ] Ray Nicholus edited comment on TAP5-1933 at 5/23/12 4:12 PM: ------------------------------------------------------------- We addressed this in our own project by using the following regex pattern (lifted from regular-expressions.info): [a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+)*&lt; at &gt;(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])? So, the Email validator class can be fixed by removing all of the regex patterns other than the PATTERN object, and then replacing the regex text in the PATTERN object with the one references above. was (Author: rnicholus): We addressed this in our own project by using javax.mail's InternetAddress class to validate the email addresses. We did have to manually check for addresses that end in quotes though since InternetAddress seems to think these are valid. I'm guessing this is not an option for Tapestry as this would require Tap5 to depend on javax.mail. Another option for Tapestry would be to use the following regex pattern (lifted from regular-expressions.info): [a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+)*&lt; at &gt;(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Ray Nicholus (JIRA 2012-05-23T16:12:41 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50019 <pre>Thanks. It is great that 5.3 will benefit from it since upgrading all projects from one tapestry version to the next is always lot of (testing) work. So should developers now always submit patches for 5.4 and can expect them to be added to 5.3? </pre> Michael Wyraz 2012-05-23T15:13:08 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50018 <pre>Updated Branches: refs/heads/master 6e16b6eeb -&gt; 8224aae21 Fix incorrectly constructed feature method Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/8224aae2 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/8224aae2 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/8224aae2 Branch: refs/heads/master Commit: 8224aae21d746c1b42846fe983b1254b17e4f070 Parents: 6e16b6e Author: Howard M. Lewis Ship &lt;hlship&lt; at &gt;apache.org&gt; Authored: Wed May 23 08:09:56 2012 -0700 Committer: Howard M. Lewis Ship &lt;hlship&lt; at &gt;apache.org&gt; Committed: Wed May 23 08:09:56 2012 -0700 ---------------------------------------------------------------------- .../services/FilterMethodAnalyzerSpec.groovy | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/8224aae2/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy ---------------------------------------------------------------------- diff --git a/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy b/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy index 93afb73..5f5f9ef 100644 --- a/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy +++ b/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy &lt; at &gt;&lt; at &gt; -3,17 +3,19 &lt; at &gt;&lt; at &gt; package org.apache.tapestry5.ioc.internal.services import spock.lang.Specification import spock.lang.Unroll - class FilterMethodAnalyzerSpec extends Specification { - def find(clazz, name) { + private MethodSignature find(clazz, name) { new MethodSignature(clazz.methods.find { it.name == name }) } &lt; at &gt;Unroll - def "position of delegate parameter for #filterMethod should be #position"() { + def "position of delegate parameter for #methodName should be #position"() { def analyzer = new FilterMethodAnalyzer(SampleService) + def mainMethod = find SampleService, methodName + def filterMethod = find SampleFilter, methodName + expect: analyzer.findServiceInterfacePosition(mainMethod, filterMethod) == position &lt; at &gt;&lt; at &gt; -27,7 +29,5 &lt; at &gt;&lt; at &gt; class FilterMethodAnalyzerSpec extends Specification { "missingServiceInterface" | -1 "complexMatch" | 2 - mainMethod = find SampleService, methodName - filterMethod = find SampleFilter, methodName } } </pre> hlship< at >apache.org 2012-05-23T15:10:02 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50017 <pre>I'm seeing some minor bugs fixed in master (5.4); I'm sure our users would like to see those back-ported to 5.3. Now that we have Git, it is generally super-easy to do, just a matter of using the git cherry-pick command. When I've been back porting, I identify both releases as the fix releases when I close the issue; that way it'll show in the release notes for both 5.3 and 5.4. </pre> Howard Lewis Ship 2012-05-23T15:02:14 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50016 <pre> [ https://issues.apache.org/jira/browse/TAP5-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&amp;focusedCommentId=13281464#comment-13281464 ] Lance commented on TAP5-1837: ----------------------------- This spring-integration jira seems to be solving a similar issue https://jira.springsource.org/browse/INT-2115 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Lance (JIRA 2012-05-23T08:49:41 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50015 <pre>Thanks, https://issues.apache.org/jira/browse/TAP5-1936 with a patch Denis 2012/5/22 Howard Lewis Ship &lt;hlship&lt; at &gt;gmail.com&gt;: </pre> Denis Delangle 2012-05-23T06:48:57 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50014 <pre> [ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Delangle updated TAP5-1936: --------------------------------- Attachment: patch-TAP5-1936.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Denis Delangle (JIRA 2012-05-23T06:47:40 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50013 <pre> [ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Delangle updated TAP5-1936: --------------------------------- Fix Version/s: (was: 5.3) Description: I get this error when clicking a link with parameters in PageTester java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.String.substring(String.java:1937) at java.lang.String.substring(String.java:1904) at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345) That bug was corrected revision 896555 and put back revision 1185926. The correction is trivial but have been done twice, so the bug is still there. I submit a patch to correct it was: Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c int comma is set to 52 path: /filelist.delete/c$002ftest2-2510777506787452085.txt then trying to do a path.substring(comma+1) Fix: use linkPath instead of path at line 304: if (comma &gt; 0) decodeParametersIntoRequest(path.substring(comma + 1)); Affects Version/s: (was: 5.1.0.5) 5.3.3 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Denis Delangle (JIRA 2012-05-23T06:45:40 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50012 <pre>Denis Delangle created TAP5-1936: ------------------------------------ Summary: REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string Key: TAP5-1936 URL: https://issues.apache.org/jira/browse/TAP5-1936 Project: Tapestry 5 Issue Type: Bug Components: tapestry-test Affects Versions: 5.1.0.5 Reporter: Denis Delangle Assignee: Howard M. Lewis Ship Fix For: 5.3 Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c int comma is set to 52 path: /filelist.delete/c$002ftest2-2510777506787452085.txt then trying to do a path.substring(comma+1) Fix: use linkPath instead of path at line 304: if (comma &gt; 0) decodeParametersIntoRequest(path.substring(comma + 1)); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Denis Delangle (JIRA 2012-05-23T06:39:42 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50011 <pre> [ https://issues.apache.org/jira/browse/TAP5-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalle Korhonen updated TAP5-1935: --------------------------------- Description: This causes issues whenever a file has a hash character ('#') in the name since everything after that it is interpreted as an anchor and excluded from the path used in URL.openStream(). Use file.toURI().toURL() instead. (was: This causes issues whenever a file has a hash character ('#') in the name since everything after that it is interpreted as an anchor and included in the path used in URL.openStream(). Use file.toURI().toURL() instead.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Kalle Korhonen (JIRA 2012-05-22T20:45:40 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50010 <pre> [ https://issues.apache.org/jira/browse/TAP5-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&amp;focusedCommentId=13281196#comment-13281196 ] Ray Nicholus commented on TAP5-1933: ------------------------------------ We addressed this in our own project by using javax.mail's InternetAddress class to validate the email addresses. We did have to manually check for addresses that end in quotes though since InternetAddress seems to think these are valid. I'm guessing this is not an option for Tapestry as this would require Tap5 to depend on javax.mail. Another option for Tapestry would be to use the following regex pattern (lifted from regular-expressions.info): [a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&amp;'*+/=?^_`{|}~-]+)*&lt; at &gt;(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira </pre> Ray Nicholus (JIRA 2012-05-22T20:41:40 http://permalink.gmane.org/gmane.comp.jakarta.tapestry.devel/50009 <pre>Updated Branches: refs/heads/master 2afbddda3 -&gt; 6e16b6eeb Create a variable to store the Hibernate version number required since upgrade Gradle to 1.0-rc-3 Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/6e16b6ee Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/6e16b6ee Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/6e16b6ee Branch: refs/heads/master Commit: 6e16b6eebe1c4921d822c2e9e399e4658cf06941 Parents: 2afbddd Author: fran</pre> ffacon< at >apache.org 2012-05-22T20:41:12 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.comp.jakarta.tapestry.devel