gmane.comp.hardware.gps.gpsbabel.devel

Re: patch for linux gui

tsteven4 — 2012-05-20T12:34:21

a replacement patch with more direct identification of .ts files.

On 5/19/2012 4:38 PM, tsteven4 wrote:
Index: gui/makelinuxdist.sh.in
===================================================================
--- gui/makelinuxdist.sh.in(revision 4182)
+++ gui/makelinuxdist.sh.in(working copy)
< at >< at > -24,24 +24,13 < at >< at >
 cp $QTSHDIR/translations/qt_*.qm $DISTDIR/translations/
 
 # Generate the compiled translations
-TSFILES="gpsbabel_de.ts 
-gpsbabel_es.ts 
-gpsbabel_fr.ts 
-gpsbabel_hu.ts 
-gpsbabel_it.ts 
-gpsbabelfe_de.ts 
-gpsbabelfe_es.ts 
-gpsbabelfe_fr.ts 
-gpsbabelfe_hu.ts 
-gpsbabelfe_it.ts"
+TSFILES="gpsbabel_*.ts gpsbabelfe_*.ts"
 
 #
 lrelease $TSFILES
 QMFILES=`echo $TSFILES | sed -e 's/\.ts/.qm/g'`
 cp $TSFILES $DISTDIR/translations
-#
-# Only Spanish and German are moderately OK.
-cp gpsbabel_es.ts gpsbabelfe_es.ts gpsbabel_de.ts gpsbabelfe_de.ts $DISTDIR/translations
+cp $QMFILES $DISTDIR/translations
 
 # Now our gui
 cp gmapbase.html $DISTDIR/
< at >< at > -54,7 +43,7 < at >< at >
 # Help needs to be donea
 cp ../../babelweb/htmldoc-development/* $DISTDIR/help/
 
-cp COPYING $DISTDIR/
+cp COPYING.txt $DISTDIR
 #cp AUTHORS $DISTDIR/
 #cp README.contrib $DISTDIR/
 #cp README.gui $DISTDIR/
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

[PATCH 1/5] gpsbabel/parse.c: ensurelathemi/lonhemi are initialized.

Bernd Zeimetz — 2012-05-20T10:09:23

---
 gpsbabel/parse.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gpsbabel/parse.c b/gpsbabel/parse.c
index 46807a4..1c45ee7 100644
--- a/gpsbabel/parse.c
+++ b/gpsbabel/parse.c
< at >< at > -166,6 +166,7 < at >< at > parse_coordinates(const char *str, int datum, const grid_type grid,
   const char *format;
 
   valid = 1;
+  lathemi = lonhemi = '\0';
 
   switch (grid) {
 
< at >< at > -211,7 +212,6 < at >< at > parse_coordinates(const char *str, int datum, const grid_type grid,
         fatal("%s: Unable to convert BNG coordinates (%s)!\n",
               module, str);
     }
-    lathemi = lonhemi = '\0';
     break;
 
   case grid_utm:
< at >< at > -225,7 +225,6 < at >< at > parse_coordinates(const char *str, int datum, const grid_type grid,
         fatal("%s: Unable to convert UTM coordinates (%s)!\n",
               module, str);
     }
-    lathemi = lonhemi = '\0';
     break;
 
   case grid_swiss: {

[PATCH 4/5] gpsbabel/util.c: Ensure a non-nullargument is passed to strlen.

Bernd Zeimetz — 2012-05-20T10:09:26

---
 gpsbabel/util.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gpsbabel/util.c b/gpsbabel/util.c
index 65460b3..4303645 100644
--- a/gpsbabel/util.c
+++ b/gpsbabel/util.c
< at >< at > -141,7 +141,7 < at >< at > xstrdup(const char *s)
 #endif
 
   if (!o) {
-    fatal("gpsbabel: Unable to allocate %ld bytes of memory.\n", (unsigned long) strlen(s));
+    fatal("gpsbabel: Unable to allocate %ld bytes of memory.\n", (unsigned long) strlen( s ? s : ""));
   }
 
   return o;

[PATCH 0/5] First fixes for scan-build detected bugs

Bernd Zeimetz — 2012-05-20T10:09:22

Hi,

here are the first few fixes for the obvious problems which were detected
by scan-build. There are some more which are worth to be fixed imho, but
I did not have the time to understand the (mostly uncommented) code in the
few minutes I had. Maybe later :)

Cheers,

Bernd



Bernd Zeimetz (5):
  gpsbabel/parse.c: ensure lathemi/lonhemi are initialized.
  gpsbabel/route.c: avoid dereference of null pointer
  gpsbabel/cst.c: Initialize wpt before using the struct.
  gpsbabel/util.c: Ensure a non-null argument is passed to strlen.
  gpsbabel/gpssim.c: '-' as filename means stdout.

 gpsbabel/cst.c    |    2 +-
 gpsbabel/gpssim.c |    2 +-
 gpsbabel/parse.c  |    3 +--
 gpsbabel/route.c  |   12 ++++++------
 gpsbabel/util.c   |    2 +-
 5 files changed, 10 insertions(+), 11 deletions(-)

[PATCH 5/5] gpsbabel/gpssim.c: '-' as filenamemeans stdout.

Bernd Zeimetz — 2012-05-20T10:09:27

Don't compare an option string (which might be null) instead.
---
 gpsbabel/gpssim.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gpsbabel/gpssim.c b/gpsbabel/gpssim.c
index 618463e..46e465b 100644
--- a/gpsbabel/gpssim.c
+++ b/gpsbabel/gpssim.c
< at >< at > -59,7 +59,7 < at >< at > gpssim_wr_init(const char* fname)
   splitfiles = splitfiles_opt ? atoi(splitfiles_opt) : 0;
 
   /* If writing to stdout, never split files */
-  if (0 == strcmp("-",splitfiles_opt)) {
+  if (0 == strcmp("-",fname)) {
     splitfiles = 0;
   }

[PATCH 2/5] gpsbabel/route.c: avoid dereference ofnull pointer

Bernd Zeimetz — 2012-05-20T10:09:24

---
 gpsbabel/route.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gpsbabel/route.c b/gpsbabel/route.c
index 0085db3..67f6ba2 100644
--- a/gpsbabel/route.c
+++ b/gpsbabel/route.c
< at >< at > -182,12 +182,12 < at >< at > any_route_add_wpt(route_head *rte, waypoint *wpt, int *ct, int synth)
   rte->rte_waypt_ct++;/* waypoints in this route */
   if (ct) {
     (*ct)++;
-  }
-  if (synth && !wpt->shortname) {
-    char tmpnam[10];
-    snprintf(tmpnam, sizeof(tmpnam), "RPT%03d",*ct);
-    wpt->shortname = xstrdup(tmpnam);
-    wpt->wpt_flags.shortname_is_synthetic = 1;
+    if (synth && !wpt->shortname) {
+      char tmpnam[10];
+      snprintf(tmpnam, sizeof(tmpnam), "RPT%03d",*ct);
+      wpt->shortname = xstrdup(tmpnam);
+      wpt->wpt_flags.shortname_is_synthetic = 1;
+    }
   }
   update_common_traits(wpt);
 }

[PATCH 3/5] gpsbabel/cst.c: Initialize wpt beforeusing the struct.

Bernd Zeimetz — 2012-05-20T10:09:25

---
 gpsbabel/cst.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gpsbabel/cst.c b/gpsbabel/cst.c
index ffe8940..ec77287 100644
--- a/gpsbabel/cst.c
+++ b/gpsbabel/cst.c
< at >< at > -164,7 +164,7 < at >< at > cst_data_read(void)
   int cst_version;
   int cst_points = -1;
   route_head* track = NULL;
-  waypoint* wpt = NULL;
+  waypoint* wpt = waypt_new();
 
   while ((buff = gbfgetstr(fin))) {
     char* cin = buff;

patch for linux gui

tsteven4 — 2012-05-19T22:38:39

While my bias is towards the command line I like the preview available 
in the gui which led me to build it on centos 6.

I needed a few changes to make the linux distribution.  Some of these 
parallel the changes in setup.iss from r4096.  These are included in the 
patch.

I need other changes to build on my system, but at least some of these 
are system dependent.
1. Change QTLIBDIR, QTSHDIR.  It would be better to get the necessary 
information from "qmake -query QT_INSTALL_TRANSLATIONS" and "qmake 
-query QT_INSTALL_PLUGINS", at least with qt4, and make appropriate 
changes where these variables are used.
2. comment out libphonon and libaudio.  These are not dynamically loaded 
by the fe when I compile it, and if the ldd|grep|awk returns nothing 
then the script bombs.  I don't know if these are ever needed, or if 
that they just  weren't on my system.
3. for me the plugins were in another path, but see 1. above.
4. with qt4 on my system lrelease is named lrelease-qt4.


I also note that  ../../babelweb does not exist.  I left this in because 
it seems like a reminder that work needs to be done wrt help and it 
didn't cause the script to bomb.

Index: gui/makelinuxdist.sh.in
===================================================================
--- gui/makelinuxdist.sh.in(revision 4182)
+++ gui/makelinuxdist.sh.in(working copy)
< at >< at > -24,24 +24,13 < at >< at >
 cp $QTSHDIR/translations/qt_*.qm $DISTDIR/translations/
 
 # Generate the compiled translations
-TSFILES="gpsbabel_de.ts 
-gpsbabel_es.ts 
-gpsbabel_fr.ts 
-gpsbabel_hu.ts 
-gpsbabel_it.ts 
-gpsbabelfe_de.ts 
-gpsbabelfe_es.ts 
-gpsbabelfe_fr.ts 
-gpsbabelfe_hu.ts 
-gpsbabelfe_it.ts"
+TSFILES=`ls gpsbabel_*.ts gpsbabelfe_*.ts`
 
 #
 lrelease $TSFILES
 QMFILES=`echo $TSFILES | sed -e 's/\.ts/.qm/g'`
 cp $TSFILES $DISTDIR/translations
-#
-# Only Spanish and German are moderately OK.
-cp gpsbabel_es.ts gpsbabelfe_es.ts gpsbabel_de.ts gpsbabelfe_de.ts $DISTDIR/translations
+cp $QMFILES $DISTDIR/translations
 
 # Now our gui
 cp gmapbase.html $DISTDIR/
< at >< at > -54,7 +43,7 < at >< at >
 # Help needs to be donea
 cp ../../babelweb/htmldoc-development/* $DISTDIR/help/
 
-cp COPYING $DISTDIR/
+cp COPYING.txt $DISTDIR
 #cp AUTHORS $DISTDIR/
 #cp README.contrib $DISTDIR/
 #cp README.gui $DISTDIR/
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

Re: test on skytraq-artificial.gpx failing

Robert Lipe — 2012-05-18T16:31:18

See the thread on gpsbabel-misc "Canmore GT-73FL-S" from earlier in
the week.  It's awaiting investigation from Mathias.

On Fri, May 18, 2012 at 4:31 AM, Bernd Zeimetz <bernd< at >bzed.de> wrote:

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Re: clang scan-build report of gpsbabel

Bernd Zeimetz — 2012-05-18T10:46:36

Sure, that makes a lot of sense - and its not hard to make scan-build to ignore
such cases. Also I found a few false-positives, That happens when you use the
latest shiniest code ;)


I'll have a look at those which are easy or obvious to fix, but there are some
issues like
http://devel.recluse.de/~bzed/scan-build/gpsbabel/2012-05-18-1/report-jxOGrD.html#EndPath
in mapsource.c that need knowledge about the format.

test on skytraq-artificial.gpx failing

Bernd Zeimetz — 2012-05-18T09:31:23

hi,

in the current trunk (and since adding the test
Running testo.d/skytraq.test
--- /tmp/gpsbabel.21809/skytraq-artificial.gpx2012-05-18 11:23:53.131458101 +0200
+++ ./reference/skytraq-artificial.gpx2012-05-18 11:12:50.347645329 +0200
< at >< at > -82,7 +82,7 < at >< at >
 </trkpt>
 <trkpt lat="47.547749767" lon="9.679499575">
   <ele>435.413042</ele>
-  <time>2009-09-10T03:07:53Z</time>
+  <time>2009-09-10T21:20:09Z</time>
   <speed>0.000000</speed>
   <name>TP0009</name>
 </trkpt>
< at >< at > -232,7 +232,7 < at >< at >
 </trkpt>
 <trkpt lat="-30.376946121" lon="-97.665030673">
   <ele>185.882330</ele>
-  <time>2019-04-05T18:25:39Z</time>
+  <time>2019-04-06T12:37:55Z</time>
   <speed>55.555557</speed>
   <name>TP0034</name>
 </trkpt>
ERROR comparing /tmp/gpsbabel.21809/skytraq-artificial.gpx
./reference/skytraq-artificial.gpx

r4178 fixed most of the issues, but these two still show up.
I could try to find out what the reason for that is, but first I would prefer if
somebody ensures that the skytraq-artificial.gpx is valid and what I see is a
real issue.

Cheers,

Bernd

Re: clang scan-build report of gpsbabel

Robert Lipe — 2012-05-17T20:15:04

I looked through the list and while I didn't study every one, I didn't
see anything that's actually very interesting.   While I do generally
like tools like this, they tend to result in a lot of busy work.  For
example, GCC's requirement to double the parens in the perfectly
semantically legal "if ((foo = bar))" doesn't really advance the state
of the industry.

Do we have dead writes to variables that aren't read?  Yeah.  So?

    u16 = gbfgetuint16(fin)

Throwing that line away is absolutely wrong. (void) gbfgetuint16(fin)
would silence the warning, but it's not actually any easier to read
and I doubt that any self-respecting optimizer would generate even one
opcode differently.

If someone on the list wants to tackle this, great. I'll apply
reasonable patches, but I'm focused on other development tasks.

RJL

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Re: clang scan-build report of gpsbabel

Bernd Zeimetz — 2012-05-17T16:55:34

Hi,



I don't assume that people will fix these issues automatically - but usually
people are happy if somebody at least looks for such defects. If I find the time
I'll also send patches, but for somebody not knowing the code it is much more
work in a lot of cases than for somebody who knows it already.


Sure, why not. :)

Cheers,

Bernd

Re: clang scan-build report of gpsbabel

Thorben Thuermer — 2012-05-17T15:58:45

Hello,

well, you may be right,
and it's surely not a bad thing to alert people to potential issues,
but also for some part it's a matter of taste to fix all of the
minor problems.

what i find a little strange is your assumption that people will be
willing to devote their time to fixing issues that you just throw at
them as an automatically generated report, instead of, say,
giving instructions what to fix, or submitting a patch.

but then, please just ignore me, i'm not even a developer of gpsbabel,
as i said, after spending some time reading your report, i just thought
it'd be appropriate to report my opinion on it.

it's really something for mr. lipe to decide on,
i'll refrain from further comments.

- T.

On Thu, 17 May 2012 17:33:48 +0200 Bernd Zeimetz <bernd< at >bzed.de> wrote:

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Re: clang scan-build report of gpsbabel

Bernd Zeimetz — 2012-05-17T15:33:48

Hi,


I did not read all of them, but yes I understand them. Also if you have no idea
what scan-build is you should learn about it, then you will also learn that it
might produce false positives, but in most cases its findings are just right. If
you actually think that there is a real false positive (as in: it is not just
something you ignore for your own lazyness of writing good code), please report
it on the Clang Static Analyzer development mailinglist - see
http://clang-analyzer.llvm.org/
I'm commenting on some of the things you are mentioning where scan-build is
right on the first look. Don't have the time or the mood to waste my time on
replies to unfriendly mails as yours.



The first thing that will be done on the next iteration is
slen = 0;
So the data saved in slen won't be used again. It could even be that slen=0
sould be moved out of the loop (actually removed as it is initialized already)
to give the loop some more sense. Obviously my "tool" realized that. If can't
know if the first slen=0; in the loop is wrong or if adding something to slen
which is not being used again is wrong, but it shows that there is something
wrong that needs to be fixed.



An initialization about 20 lines about the place where exactly the same line
comes up again doesn't make things more readable. Yes, it doesn't do anything
bad, but it is also just not needed to have it in there twice. One day somebody
will add some code in between the two initializations and will have a fun time
trying ti figure out why the introduced code doesn't seem to do anything at all.



Yes and so on. Obviously you are a fan of having dead code in a project. I leave
it to you to learn why dead code / dead stores should be removed.



Security is *always* a major issue. There are people running gpsbabel on data
provided by users on websites, they expect gpsbabel not to choke on malformed
input. Or you just want to convert a "track" you've downloaded from the internet
to have a look at it - you want to trust your favourite tool that using it on
such data is safe.



The code is not complex and the error is well explained. recType is not
initialized if neither tracks nor waypoints were handled before looking on
routes. I don't think that is an unlikely condition, it is a common task to
extract only parts of a given data source.


Cheers,

Bernd

Re: clang scan-build report of gpsbabel

Thorben Thuermer — 2012-05-17T14:02:01

Hello,

i'm not even a gpsbabel developer, but i've looked at the report and
report my findings...


sorry, but...
have you actually read those reports or understand them?
i've wasted some of my time looking at a few, and none of them are bugs,
most seem either irrelevant, or false positives...

false positive:
http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-4qnTWr.html
it seems your tool does not resolve macros correcly, and assumes the code
would try to operate on an empty list...?

http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-TxWcEg.html
your tool does not realize this code is part of a loop,
and the value will be used on the next iteration?

irrelevant:
http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-B4Cv3H.html
that's an excess initialization of a variable used as a counter.
it's hardly a bug, and might rather make the code more readable...

http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-nnDoke.html
the control variable is already initialized, and instead of leaving the
initialization empty, it's assigned to itself...
makes the code more readable, and will be optimized out anyway.

http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-FyAuMY.html
another duplicate initialization of a control variable

and so on...

http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-hLVZn7.html
after no less than 30 branches the code might write to an uninitialized
pointer... this might indeed cause a crash on some malformed input...
if security was a major issue, an extra check might be justified...

this one _might_ be valid, the code is too complex to tell right away:
http://devel.recluse.de/scan-build/gpsbabel/2012-05-17-1/report-ipSdJi.html
an uninitialized value  might be read in some unlikely condition
when the operation has already failed anyway...


- T.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

clang scan-build report of gpsbabel

Bernd Zeimetz — 2012-05-17T12:50:20

Hi,

I've built gpsbabel with clang's scan-build, the current report (which shows 207
bugs) is available at

http://devel.recluse.de/scan-build/gpsbabel/

For now I'll rebuild the sources every night and a new report will be generated,
assuming there is some interest to fix those bugs :)

Cheers,

Bernd

Re: Patch to add "discard" option to track filter

Robert Lipe — 2012-05-15T14:16:18

Lovely.  Committed.   Thank you.

On Tue, May 15, 2012 at 4:27 AM, Tom Paton <tom.paton< at >gmail.com> wrote:

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

Re: Patch to add "discard" option to track filter

Tom Paton — 2012-05-15T09:27:14

Hi Robert,

I checked the latest revision and it's working as expected for me,
it's just the test that's too noisy.

I've attached a quieter test together with a new reference file, the
other files are unchanged.

Thanks for including the patch, it helps me out a lot.

Tom

On Tue, May 15, 2012 at 9:12 AM, Tom Paton <tom.paton< at >gmail.com> wrote:
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

Re: Bad CRC with Qstarz travel recorder EX

P. Borgentun — 2012-05-14T19:33:19

Hi,I looked through my mailbox and from what I can see there was a problem with gpsbabel 1.3.6 (and earlier). 
As far as I know this problem should be solved, I have succesfully tested the current SVN with a large logfile
received from another user.

If you still have problems with a recent version you could send me the  .bin file 
and I'll have a closer look on the problem.

Regards
P. Borgentun



________________________________
 From: Dirk Stichling <mytracks4mac< at >me.com>
To: gpsbabel code list <gpsbabel-code< at >lists.sourceforge.net> 
Sent: Wednesday, May 9, 2012 6:31 PM
Subject: [Gpsbabel-code] Bad CRC with Qstarz travel recorder EX
 
Hi.

A user of my application myTracks (which uses gpsbabel internally) reports that he has problems with his Qstarz travel recorder EX. The mtk driver of gpsbabel is used for the communication. Reading tracks from the logger works fine as long as the memory of the logger is not too full. But when the memory reaches about 50% gpsbabel reports "bad CRC" errors.

I did some research on the net and found a discussion on that topic (http://old.nabble.com/Error-reading-BT-Q100P-when-more-than-50--td22123960.html).

Now my question is whether this problem has not yet been addressed? If not, is there anything I can do to help solving the problem?

Thanks,
Dirk


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

Re: Fwd: [Gpsbabel-misc] Garmin Edge 800 FIT format won't convert after firmware upgrade

Robert Lipe — 2012-05-14T19:31:15


Please update to the latest and run 'svn diff' to create a patch.   As I
had to make extensive changes to your previous patch to make it fit our
style, the diffs to this file are impractical to read.



That's fine, but at some level, a debugger is necessary.    The changes I
made were in the case where debug was not specified.  There was no reason
to stream warnings for record types that you know well enough to skip
around, for example.  Just running testo garmin_fit was resulting in
hundreds of lines of chatter.

Please sync to the latest and submit a patch for review.  Thanx.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code