gmane.comp.gnome.apps.pan.devel

Re: Poster e-mail adress (e87f297d) s/adress/address/

Duncan — 2012-05-22T17:02:15

Petr Kovar posted on Tue, 22 May 2012 16:03:33 +0200 as excerpted:


Thanks.

FWIW, watching your commits in git, I've agreed with I think every one.  
Your eye for documentation detail and catching the little things that I'd 
have simply passed over is amazing, and I'm beginning to see what the 
value of a good docs person on a team actually is.

Which is why it was equally amazing to see you miss "adress".  Of course 
it wasn't your mis-type originally, but watching your commits, that's 
exactly the type of "small" thing I've seen you catch and fix, 
repeatedly, yet it was right there in the line you changed something else 
in, and you didn't catch this one.

Must have been sleepy or distracted at the time!

Anyway, fixed now. =:^)

Re: Poster e-mail adress (e87f297d) s/adress/address/

Petr Kovar — 2012-05-22T14:03:33

Hey Duncan,

On Mon, 21 May 2012 11:42:45 +0000 (UTC)
Duncan <1i5t5.duncan-j9pdmedNgrk-XMD5yJDbdMReXY1tMh2IBg< at >public.gmane.org> wrote:


Good catch! Thanks for pointing that out. 

Fixed in 746a2907319e8da54cee5e9347dec238204bdd1e.

There were three occurrences of "adress" in the source code. One was in the
comment, all of them are corrected. :-)

Cheers,
Petr Kovar

Re: New segfault in group-preferences editor

Duncan — 2012-05-22T09:18:17

walt posted on Sun, 20 May 2012 15:32:26 -0700 as excerpted:


I'm seeing it now, too (commit 169a3a7 according to about).

Poster e-mail adress (e87f297d) s/adress/address/

Duncan — 2012-05-21T11:42:45

Checking git whatchanged commit e87f297d, minor string edits,
looked interesting enough to git show...

Those strings need a bit /more/ minor editing...

s/adress/address/

(You've no idea how hard it is to type "adress" when you've been 
automatically double-d-ing AND double-s-ing it since you learned to type, 
over a quarter century (getting close to a third, now) ago!  I'm almost 
positive it was one of the words in my typing lessons, too, making it 
even worse!  I kept double-d-ing it above, and even on the first line of 
this paragraph, I got the adr... and had to stop and double-check, my 
fingers bewildered at this "strange word" they were being told to type 
that simply did NOT make sense!  Hopefully I don't have to use the word 
"address" later this week and screw it up now! =;^)

Meanwhile, I see the group-color fixes.  I've not actually rebuilt and 
tried it yet, but thanks (to both of you).  And the readme changes make 
sense. =:^)

Re: New segfault in group-preferences editor

walt — 2012-05-20T23:09:14


Damn, I'm smart :p

Ten seconds after hitting "Send" I realized that what I wrote
was actually a hypothesis, and every hypothesis cries out to
be tested.  (I read that somewhere.)

So, I switched gtk themes and both the warning and segfault
went away.

I do see two assertions now, but I don't know if they are
significant:

(pan:13857): Gtk-CRITICAL **: IA__gtk_rc_get_style: assertion `GTK_IS_WIDGET (widget)' failed

(pan:13857): Gtk-CRITICAL **: IA__gtk_style_lookup_color: assertion `GTK_IS_STYLE (style)' failed

New segfault in group-preferences editor

walt — 2012-05-20T22:32:26

Hi Heinrich.  Just pulled from git [da407793] and I get a segfault
when I try to edit group-preferences.  The warning about the missing
theme engine is not new.  "hcengine" probably refers to the "high-
color" gtk theme I'm using.  I don't know if it's now a problem for
pan, but I've seen the same warning many times before today.

warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

(pan:13375): Gtk-WARNING **: Unable to locate theme engine in module_path: "hcengine",

[New Thread 0x7fffeddc3700 (LWP 13378)]
[New Thread 0x7fffed5c2700 (LWP 13379)]
[New Thread 0x7fffecdc1700 (LWP 13380)]
[New Thread 0x7fffe7fff700 (LWP 13381)]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff791631b in gtk_rc_get_style () from /usr/lib64/libgtk-x11-2.0.so.0
(gdb) bt
#0  0x00007ffff791631b in gtk_rc_get_style () from /usr/lib64/libgtk-x11-2.0.so.0
#1  0x00000000004a434f in new_color_button (dialog=0x2f68490, prefs=..., group=...)
    at ../../../pan/gui/group-prefs-dialog.cc:241
#2  pan::GroupPrefsDialog::GroupPrefsDialog (this=0x2f68490, data=..., groups=..., prefs=..., group_prefs=..., 
    parent_window=<optimized out>) at ../../../pan/gui/group-prefs-dialog.cc:308
#3  0x000000000047739a in pan::GUI::do_show_group_preferences_dialog (this=0x1ca5700) at ../../../pan/gui/gui.cc:902
#4  0x00007ffff5c723c0 in g_closure_invoke () from /usr/lib64/libgobject-2.0.so.0
#5  0x00007ffff5c831a0 in signal_emit_unlocked_R () from /usr/lib64/libgobject-2.0.so.0
#6  0x00007ffff5c8b48f in g_signal_emit_valist () from /usr/lib64/libgobject-2.0.so.0
#7  0x00007ffff5c8b623 in g_signal_emit () from /usr/lib64/libgobject-2.0.so.0
#8  0x00007ffff780b71b in _gtk_action_emit_activate () from /usr/lib64/libgtk-x11-2.0.so.0
#9  0x00007ffff5c725f3 in _g_closure_invoke_va () from /usr/lib64/libgobject-2.0.so.0
#10 0x00007ffff5c8ab0c in g_signal_emit_valist () from /usr/lib64/libgobject-2.0.so.0
#11 0x00007ffff5c8b623 in g_signal_emit () from /usr/lib64/libgobject-2.0.so.0
#12 0x00007ffff79dd56e in gtk_widget_activate () from /usr/lib64/libgtk-x11-2.0.so.0
#13 0x00007ffff78dc88d in gtk_menu_shell_activate_item () from /usr/lib64/libgtk-x11-2.0.so.0
#14 0x00007ffff78dcbf7 in gtk_menu_shell_button_release () from /usr/lib64/libgtk-x11-2.0.so.0
#15 0x00007ffff78ca570 in _gtk_marshal_BOOLEAN__BOXED () from /usr/lib64/libgtk-x11-2.0.so.0
#16 0x00007ffff5c723c0 in g_closure_invoke () from /usr/lib64/libgobject-2.0.so.0
#17 0x00007ffff5c837b4 in signal_emit_unlocked_R () from /usr/lib64/libgobject-2.0.so.0
#18 0x00007ffff5c8b14f in g_signal_emit_valist () from /usr/lib64/libgobject-2.0.so.0
#19 0x00007ffff5c8b623 in g_signal_emit () from /usr/lib64/libgobject-2.0.so.0
#20 0x00007ffff79de33f in gtk_widget_event_internal () from /usr/lib64/libgtk-x11-2.0.so.0
#21 0x00007ffff78c8ac3 in gtk_propagate_event () from /usr/lib64/libgtk-x11-2.0.so.0
#22 0x00007ffff78c8e6b in gtk_main_do_event () from /usr/lib64/libgtk-x11-2.0.so.0
#23 0x00007ffff753632c in gdk_event_dispatch () from /usr/lib64/libgdk-x11-2.0.so.0
#24 0x00007ffff557971a in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
#25 0x00007ffff5579a78 in g_main_context_iterate.clone.6 () from /usr/lib64/libglib-2.0.so.0
#26 0x00007ffff5579e72 in g_main_loop_run () from /usr/lib64/libglib-2.0.so.0

color-groups: group-prefs set colors don't take

Duncan — 2012-05-15T18:12:07

The git commit should be in the headers.

I noticed immediately after rebuilding (first time with color-groups) 
that the group colors had reverted to black, not so good on a dark 
background, tho it's not black so I could sort of see them.

But I had read about group colors in git whatchanged, so immediately set 
out to fix things.

But while setting the color in group prefs changes it there, hitting done 
doesn't apply that change, and reopening group prefs shows no change.

But editing the xml file by hand (with pan closed) has the desired 
effect.  The (default #000000) colors were stored there, so all I had to 
do was change the existing entries as desired.

So:

1. Please fix group prefs to actually apply the chosen color.

2. Preferably, fix the default so it detects the existing text color and 
defaults to that, not simply to black.  I think you'll have to query gtk 
for it.  But if it's too hard don't bother, just fix the group prefs to 
apply the color correctly and that'll do.

ANN : Ubuntu package PPA

Heinrich Müller — 2012-05-06T20:14:09

Hi,
I just want to announce that Klaus Vormweg has created a PPA for Ubuntu
with the latest packages that he updates regularly.


https://launchpad.net/~klaus-vormweg/+archive/pan


Cheers,
judgefudge

Re: The status of --enable-gkr?

Heinrich Müller — 2012-05-03T15:39:33

Am 02.05.2012 21:02, schrieb walt:
Damn, thanks for the heads-up. I forgot to change that. The expected
behaviour is auto-off, yes.

The status of --enable-gkr?

walt — 2012-05-02T19:02:29

Hi Heinrich, and thanks for the gnutls fix.

While testing the latest I found that I didn't get gnome-keyring
support until I actually used --enble-gkr.  Is that what you
intended?  configure --help still says "normally yes" for gkr.

ANN: Pan 0.137 "The Mattel and Mars Bar Quick EnergyChocobot Hour"

Petr Kovar — 2012-05-01T18:35:12

May 1, 2012 - New Release:
Pan 0.137 "The Mattel and Mars Bar Quick Energy Chocobot Hour"
http://pan.rebelbase.com/download/

What is Pan?

Pan is a newsreader which attempts to be pleasing to both new and
experienced users. In addition to the standard newsreader features, Pan
also supports yEnc, offline newsreading, article filtering, multiple
connections, and more.

It's also the only Unix newsreader to get a perfect score on the Good
Net-Keeping Seal of Approval evaluations.

About 0.137

This is a bugfix release for certain issues regarding race conditions with
thread handling, which resulted in random errors and segmentation faults.
Everybody using older versions of Pan is encouraged to upgrade. There have
been some minor UI enhancements, too.

Changes since 0.136

* Fixed errors regarding the segmentation faults etc. with thread handling.
  (Heinrich Müller)
* Colorize group names. (Heinrich Müller)
* Fix three-horizontal-pane layout between sessions. (Heinrich Müller)
* Stop tasks when there is no space left on device. (Heinrich Müller)
* Honor default attachments folder setting if group folder is not set.
  (Heinrich Müller)
* Updated translations: Spanish (Daniel Mustieles), Slovenian (Matej
  Urbančič, Martin Srebotnjak).

Re: [git 6120c8644] Assertion hit when using ssl

Heinrich Mueller — 2012-04-26T09:40:37

Am 26.04.2012 00:52, schrieb walt:
Has been fixed in git repo, thanks.

Cheers.

[git 6120c8644] Assertion hit when using ssl

walt — 2012-04-25T22:52:59

Hi Heinrich.  Just pulled again today for testing purposes and I'm hitting
an assertion I've never seen before:

** (pan:6114): WARNING **: The certificate is not trusted.


** (pan:6114): WARNING **: The certificate hasn't got a known issuer.

pan: ../../../pan/data-impl/server.cc:209: virtual void pan::DataImpl::save_server_info(const pan::Quark&): Assertion `s' failed.
Aborted

This happens immediately after clicking on the "accept" button in
the certificate dialog box.  Technically the cert dialog box should
not pop up because the flags for that news server are already set:
    <use-ssl>1</use-ssl>
    <trust>1</trust>

I notice that pan correctly re-saves the same settings before hitting
the assertion.  (At least the time stamp on servers.xml is updated to
the current time.)

This particular cert is actually expired and I suspect the cert dialog
box is opening for that reason even though the 'trust' flag is already
set to 1.  I've seen this since I started using your gnutls code but
the assertion appeared today for the first time.  No idea why.

(BTW, news.gmane.org works correctly with ssl because their cert isn't
expired :)

ANN: Pan 0.136 "Far too busy being delicious..."

Petr Kovar — 2012-04-08T17:34:32

April 8, 2012 - New Release:
Pan 0.136 "Far too busy being delicious..."
http://pan.rebelbase.com/download/

What is Pan?

Pan is a newsreader which attempts to be pleasing to both new and
experienced users. In addition to the standard newsreader features, Pan
also supports yEnc, offline newsreading, article filtering, multiple
connections, and more.

It's also the only Unix newsreader to get a perfect score on the Good
Net-Keeping Seal of Approval evaluations.

About 0.136

This release introduces a plethora of bugfixes and improvements, everybody
using older versions of Pan is encouraged to upgrade. This version supports
binary uploading, TLS (SSL) connections, PGP handling and other nice
features.

Changes since 0.135

* Support for uploading attachments (with NZB creation) to Usenet.
  (Heinrich Müller)
* Selectable Content-Transfer-Encoding. (Heinrich Müller)
* Selectable GtkSpell default language. (Heinrich Müller)
* Support for encrypting and signing articles with a public/private PGP key.
  (Heinrich Müller)
* Connections can now be encrypted with TLS 1.0. (Heinrich Müller)
* Various bugfixes/enhancements from Bugzilla.
* Auto-Cache/-Download/-Delete/-Mark read based on scores. (Heinrich Müller)
* D-Bus support for automatic batch addition of new files to the Download
  Queue. (Heinrich Müller)
* Status Icon support. (Heinrich Müller)
* GNOME Keyring support for safely storing server passwords. (Heinrich
  Müller)
* Updated translations and help: Spanish (Daniel Mustieles, Nicolás
  Satragno), Slovenian (Andrej Žnidaršič, Matej Urbančič, Martin
  Srebotnjak), German (Christian Kirbach, Mario Blättermann), Czech (Marek
  Černocký, Petr Kovar), Esperanto (Kristjan SCHMIDT), Danish (Joe Hansen),
  Japanese (OKANO Takayoshi), Russian (Yuri Myasoedov), French (Bruno
  Brouard), Brazilian Portuguese (Gabriel Speckhahn).

Re: [pan.git] Reproducible segfault when "saving articles from selected nzb"

walt — 2012-04-05T20:32:19

Sorry, same thing.  Every time I click on Trust or Apply I immediately
get another identical popup dialog.  With every iteration I see another
two warnings on the console:

** (pan:32302): WARNING **: The certificate is not trusted.


** (pan:32302): WARNING **: The certificate has expired

This cycle continues until I click Cancel.

BTW, this is pan 47c5f947

Thanks Heinrich

Re: Next Pan release this weekend, 0.136

Duncan — 2012-04-05T00:26:01

Heinrich Müller posted on Wed, 04 Apr 2012 18:39:46 +0000 as excerpted:


Cool!  I wasn't expecting it until August, to keep the annual first week 
in August pan update tradition that seems to have been the case for 
several years.

But I'm not going to complain about an early version drop. =:^)

Next Pan release this weekend, 0.136

Heinrich Müller — 2012-04-04T18:39:46

Title says it all... Stay tuned!_______________________________________________
Pan-devel mailing list
Pan-devel-qX2TKyscuCcdnm+yROfE0A< at >public.gmane.org
https://lists.nongnu.org/mailman/listinfo/pan-devel

Re: [pan.git] Reproducible segfault when "saving articles from selected nzb"

Heinrich Mueller — 2012-04-04T16:30:23

Am 04.04.2012 02:34, schrieb walt:
I changed the logic to accept this condition.
Please pull again and try, it should work now.

Cheers.

Re: [pan.git] Reproducible segfault when "saving articles from selected nzb"

walt — 2012-04-04T00:34:55


Hi Heinrich.  I just pulled again and rebuilt (git 074e20fb).  Just
as with Alan's patch I'm getting persistent popup dialogs asking me
to accept the server's certificate even though I already have the
"always trust" checkbox checked.  Here is the console output, which
repeats endlessly when I click on "accept":

** (pan:14235): WARNING **: The certificate is not trusted.


** (pan:14235): WARNING **: The certificate has expired


** (pan:14235): WARNING **: The certificate is not trusted.


** (pan:14235): WARNING **: The certificate has expired

BTW, the cert did indeed expire December 2011, but it was no doubt
self-signed by the news admin anyway, so should we really care?

Re: [pan.git] Reproducible segfault when "saving articles from selected nzb"

Heinrich Mueller — 2012-04-03T18:05:36

Am 02.04.2012 22:03, schrieb Alan Young:
Thanks for that. I went a different route and removed g_error in favor 
of g_warning and removed g_warning on the
always_trust condition.

Re: [pan.git] Reproducible segfault when "saving articles from selected nzb"

Alan Young — 2012-04-03T01:23:52

Oh, sorry about that.  It has been a while since I posted to this list 
and could not remember if attachments were ok.  I've attached an actual 
patch file to this mail.  So hopefully it will get through.  If not, I 
can always try again. :)

It could be that there's another place to patch for the nzbs.  I usually 
use a different program for those.   I'll have to find something to try 
in Pan tonight.  For regular message reading or decoding, I do not get 
any pop ups to accept the cert.  Just the warning messages in the output.

Alan
--- cert-store.cc.orig2012-04-01 01:26:55.100783006 -0700
+++ cert-store.cc2012-04-01 02:10:31.454124927 -0700
< at >< at > -139,8 +139,14 < at >< at >
 
     if (!gnutls_x509_crt_check_hostname (cert, mydata->hostname_full.c_str()))
     {
+// if we trust make it warning instead of a abort/error
+// ? how to print cert's hostname...
+     if (mydata->always_trust)
+      g_warning ("The certificate's owner does not match hostname '%s' !\n", mydata->hostname_full.c_str());
+      else {
       g_error ("The certificate's owner does not match hostname '%s' !\n", mydata->hostname_full.c_str());
       goto _fail;
+     }
     }
 
     if (fail) goto _fail;
_______________________________________________
Pan-devel mailing list
Pan-devel-qX2TKyscuCcdnm+yROfE0A< at >public.gmane.org
https://lists.nongnu.org/mailman/listinfo/pan-devel