gmane.comp.freedesktop.devicekit.devel

Re: [PATCH] Rely on the "Resuming" signal only on a system withsystemd

Michael Biebl — 2013-05-12T17:08:31

We already have a runtime check for systemd-logind. Why do we need a
compile-time check, too?
Am 12.05.2013 14:46 schrieb "Imran Haider" <imran1008< at >gmail.com>:

[PATCH] Rely on the "Resuming" signal only on a system with systemd

Imran Haider — 2013-05-12T12:49:09

The notify-upower.sh script is only executed on a system with systemd. For
distributions that use logind without a full fledged systemd, this script
will not get executed and so upower would not know that it has resumed.

This change fixes an issue where the system goes to sleep only once and
does not sleep until upowerd is restarted.
---
 src/linux/up-backend.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/linux/up-backend.c b/src/linux/up-backend.c
index b9f75f5..e3c6c0a 100644
--- a/src/linux/up-backend.c
+++ b/src/linux/up-backend.c
< at >< at > -614,9 +614,11 < at >< at > up_backend_get_hibernate_command (UpBackend *backend)
 gboolean
 up_backend_emits_resuming (UpBackend *backend)
 {
+#ifdef HAVE_SYSTEMD
 if (LOGIND_AVAILABLE())
 return TRUE;
 else
+#endif
 return FALSE;
 }
 #endif

Re: [PATCH v2][UPower] build: detect udev rules dir

Richard Hughes — 2013-05-07T13:25:47

Applied, thanks.

Richard.

[PATCH v2][UPower] build: detect udev rules dir

Tom Gundersen — 2013-03-20T16:31:21

Udev rules may live in either /lib/udev/rules.d or /usr/lib/udev/rules.d depending on the distro.
Remove the heuristic for deciding the dir, use pkgconfig to detect the location and allow it to be
set manually.

v2: fix specifying --with-udevrulesdir
---
 configure.ac      | 12 +++++-------
 rules/Makefile.am |  1 -
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/configure.ac b/configure.ac
index 56db585..f97ff37 100644
--- a/configure.ac
+++ b/configure.ac
< at >< at > -82,13 +82,11 < at >< at > AM_CONDITIONAL(MAN_PAGES_ENABLED, test x$enable_man_pages = xyes)
 
 GTK_DOC_CHECK([1.11],[--flavour no-tmpl])
 
-# udev rules go in /lib, not /usr/lib
-if test "$prefix" = "/usr" -o "$prefix" = "/usr/local" ; then
-  slashlibdir=/lib
-else
-  slashlibdir=$prefix/lib
-fi
-AC_SUBST(slashlibdir)
+AC_ARG_WITH([udevrulesdir],
+            AS_HELP_STRING([--with-udevrulesdir=DIR], [Directory for udev rules]),
+            [],
+            [with_udevrulesdir=$($PKG_CONFIG --variable=udevdir udev)"/rules.d"])
+AC_SUBST([udevrulesdir], [$with_udevrulesdir])
 
 # History/Db dir
 AC_ARG_WITH([historydir],
diff --git a/rules/Makefile.am b/rules/Makefile.am
index 1564b40..a66490a 100644
--- a/rules/Makefile.am
+++ b/rules/Makefile.am
< at >< at > -1,6 +1,5 < at >< at >
 ## Process this file with automake to produce Makefile.in
 
-udevrulesdir = $(slashlibdir)/udev/rules.d
 udevrules_DATA =\
 95-upower-battery-recall-dell.rules\
 95-upower-battery-recall-fujitsu.rules\

Re: [PATCH][UPower] build: detect udev rules dir

Tom Gundersen — 2013-03-20T16:26:08

Ah, you are right. I missed that. Resending.


I don't think that's really necessary, but if you think so, it might
be best to do that in a separate patch and also make the same change
for the other uses of pkg-config.

-t

Re: [PATCH][UPower] build: detect udev rules dir

Dan Nicholson — 2013-03-20T14:00:15

depending on the distro.
location and allow it to be
x$enable_man_pages = xyes)
udev rules]),
udev)"/rules.d"])

Did you test that the manual setting actually worked? You're passing
udevdir to AC_ARG_WITH, which will cause autoconf to set with_udevdir.
That's not what you're using for the actual setting (with_udevrulesdir). I
think if you change it to [udevrulesdir] it will work.

Also, it might be a good idea to be defensive and check that pkg-config
returned anything useful. That's pretty unlikely at that point, though.

Otherwise, this seems good to me.

Dan

Re: [PATCH][UPower] build: detect udev rules dir

Tom Gundersen — 2013-03-20T13:00:31

PS

Currently we do:
<https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/upower#n20>.

-t

Re: [PATCH][UPower] build: detect udev rules dir

Tom Gundersen — 2013-03-20T12:59:27

At least Arch does.

I would expect Fedora (and anyone else who merged /lib into /usr/lib)
does too, but perhaps their package managers are more forgiving and
considers /lib an alias for /usr/lib?

Cheers,

Tom

Re: [PATCH][UPower] build: detect udev rules dir

Andrey Borzenkov — 2013-03-20T12:59:21

openSUSE 12.3 at least. I was under impression, Fedora moved too. Was
not the goal to move everything except /etc under /usr?

Re: [PATCH][UPower] build: detect udev rules dir

Richard Hughes — 2013-03-20T12:55:45

What distro uses /usr/lib/udev/rules.d?

Richard.

Re: [udisks] moving shared mounts from /media to /run/media ?

Tom Gundersen — 2013-03-19T15:11:16

Sorry for the delay, but here it is:
<https://bugs.freedesktop.org/show_bug.cgi?id=62527>.

-t

[PATCH][UPower] build: detect udev rules dir

Tom Gundersen — 2013-03-19T12:33:12

Udev rules may live in either /lib/udev/rules.d or /usr/lib/udev/rules.d depending on the distro.
Remove the heuristic for deciding the dir, use pkgconfig to detect the location and allow it to be
set manually.
---
 configure.ac      | 12 +++++-------
 rules/Makefile.am |  1 -
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/configure.ac b/configure.ac
index 56db585..c03e8e8 100644
--- a/configure.ac
+++ b/configure.ac
< at >< at > -82,13 +82,11 < at >< at > AM_CONDITIONAL(MAN_PAGES_ENABLED, test x$enable_man_pages = xyes)
 
 GTK_DOC_CHECK([1.11],[--flavour no-tmpl])
 
-# udev rules go in /lib, not /usr/lib
-if test "$prefix" = "/usr" -o "$prefix" = "/usr/local" ; then
-  slashlibdir=/lib
-else
-  slashlibdir=$prefix/lib
-fi
-AC_SUBST(slashlibdir)
+AC_ARG_WITH([udevdir],
+            AS_HELP_STRING([--with-udevrulesdir=DIR], [Directory for udev rules]),
+            [],
+            [with_udevrulesdir=$($PKG_CONFIG --variable=udevdir udev)"/rules.d"])
+AC_SUBST([udevrulesdir], [$with_udevrulesdir])
 
 # History/Db dir
 AC_ARG_WITH([historydir],
diff --git a/rules/Makefile.am b/rules/Makefile.am
index 1564b40..a66490a 100644
--- a/rules/Makefile.am
+++ b/rules/Makefile.am
< at >< at > -1,6 +1,5 < at >< at >
 ## Process this file with automake to produce Makefile.in
 
-udevrulesdir = $(slashlibdir)/udev/rules.d
 udevrules_DATA =\
 95-upower-battery-recall-dell.rules\
 95-upower-battery-recall-fujitsu.rules\

UPower 0.9.20

Richard Hughes — 2013-03-18T16:29:07

Version 0.9.20
~~~~~~~~~~~~~~
Released: 2013-03-18

New Features:
 - Add a --enable-deprecated configure argument to remove pm-utils
support (Richard Hughes)
 - Deprecate running the powersave scripts (Richard Hughes)
 - Factor out the Logitech Unifying support to support other devices
(Richard Hughes)
 - Require applications to define UPOWER_ENABLE_DEPRECATED to use
deprecated functionality (Richard Hughes)

Bugfixes:
 - Bump maximum accepted "time to empty" to 10 days (Martin Pitt)
 - Don't use the deprecated INCLUDES in Makefile.am (Richard Hughes)
 - Fix batteries which report current energy but full charge (Alex Hornung)
 - Fix K750 features name, use 1 second interval (Julien Danjou)
 - Fix memory leak in up_polkit_get_subject (Charles Kerr)
 - Fix two memory leaks (Colin Watson)
 - integration-test: Always run on a fake system bus (Martin Pitt)
 - integration-test: Move to using umockdev (Martin Pitt)
 - Never use -WError when building (Richard Hughes)
 - Raise the hard PolicyKit dep to 0.97 (Richard Hughes)

Richard

What happened to the permissions checkbox?

Phillip Susi — 2013-03-13T03:03:32

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Some users have had problems restoring a system from backup because
they used gnome-disks-utility to format the disk, and the permissions
on the root fs were wrong.  A while back, a checkbox was added to take
ownership of the newly formatted filesystem, as this often is what
users want, but this checkbox seems to have vanished, and now there
seems to be no way avoid changing the permissions.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJRP+yEAAoJEJrBOlT6nu75IFkH/RHI8UpZsLdoXOR7Uuzq9/6H
2L5UgtyWjSDXA0y+FipZ25rIGSE1gbdQ8dCzQ8+zbOkbrn1e/U53NHeRyipNp8BS
aqQ1QhGtEKVjk/K7dMIx9A8C1LMrTlc7i8u9vyoIMIa2U82Q211rXNgqKFi+2FL5
lNIq+eDGGjx6FEyo8NCONV1U/El5yzJFtM+jC+bKY6SVWDYfKIyf93In1BwRTi6m
isB9XHYXXYEPassSqWlOfDYZ/+t3wZezVpaRzGKcm/r1ETSOO3h/l30Z5i5WdPRN
dUup8el+UTXUQkUfC77dfX84UKabXNjwYz6TDWx0sDY6roXWUQDVkoSere5bo3E=
=0B0B
-----END PGP SIGNATURE-----

Re: External media mounts

Stef Bon — 2013-03-09T13:53:35

Hi,

I agree that sharing an USB stick is desired in various situations. The 
patch introducing ¨UDISKS_FILESYSTEM_SHARED¨ tries to handle that, but 
does the patch tackle all those situations??

Stef

Re: External media mounts

Kevin Chadwick — 2013-03-05T23:05:00

Or they could use a filesystem which has permissions (SGID
folders are useful) for such corner case scenarios and gives fine
grained control and widely useful and understood and even intuitive via
file managers.

There is also default umasks and mount option umasks (don't forget
options like noexec which should be settable as default) which could
override them and should be easily controllable and usable with FAT.
Though you probably should have root filesystem write priviledges toa
config file via sudo or distro defaults to do so.

Re: External media mounts

Phillip Susi — 2013-03-05T19:09:10

No, I accounted for multiseat in my suggestion.  There is one active 
session per seat.  The active session of the seat gets access to mounts 
associated with that seat.  In this way it is possible to have two 
different seats that each have their own usb port and each person can 
plug in their own usb flash drive, and not interfere with each other, 
even if they happen to both be using a common guest UID.

Re: External media mounts

Stef Bon — 2013-03-05T18:46:37

What you want with the inactive user versus the active one, does not 
work with multiseat.
In that situation more users are active.

With a usb stick connected, there are various situations possible:

a. one user ¨owns¨ the device, and it´s mounted by him/her, others don´t 
have access (mounted at /run/media/$USER somewhere)

b. a device is shared using a public user. (mounted at /media/somewhere)

The suggested solution in the patch above (by introducing the 
UDISKS_FILESYSTEM_SHARED) is a good step to handle these situations.

And when another user wants to own the device, they should agree the 
first should unmount it, and let others have to ability to ¨grap¨ it.

Stef

Re: [udisks] moving shared mounts from /media to /run/media ?

Ivan Lezhnjov Jr. — 2013-03-05T14:46:22

This commit was rather stealthy, but anyway thank you David!

I really do believe it's a change that great many users will find empowering.

Ivan

On Feb 19, 2013, at 11:49 PM, David Zeuthen <zeuthen< at >gmail.com> wrote:

Re: External media mounts

Ivan Lezhnjov Jr. — 2013-03-05T14:34:24

That was directly in response to commit commentary.

You might want to see these to understand where I'm coming from:
http://lists.freedesktop.org/archives/devkit-devel/2013-February/001354.html

And there was also another message like mine approximately a month before:
http://lists.freedesktop.org/archives/devkit-devel/2013-January/001345.html

And luckily 5 days later after the thread that I'd kicked off we've got a commit that addresses this problem:
http://lists.freedesktop.org/archives/devkit-devel/2013-February/001365.html
http://cgit.freedesktop.org/udisks/commit/?id=6ae6c19ad981801d08f3f5b59c0301ed3fe8b7b4

for which I'm grateful and really happy to see that I've influenced the development of the project in a positive way (or was it just a coincidence?)

I'm amused by the attitude of the committer, though, clearly mistaking hate for legitimate frustration.

There's no hate, just love because this commit is going to make a lot of people a tad bit happier when they're working in Linux.

On Mar 5, 2013, at 4:07 PM, Phillip Susi <psusi< at >ubuntu.com> wrote:

Re: External media mounts

Phillip Susi — 2013-03-05T14:07:09

What?