gmane.comp.emulators.wine.devel

Re: Testing regedit

Daniel Jelinski — 2012-05-24T06:47:20

2012/5/24 Austin English <austinenglish< at >gmail.com>:

One found with both native and builtin comctl32 - if you right-click a
key and select New, the new one is created under the node that was
last selected, not under the one that was right-clicked. This is
different form windows regedit and can be confusing.
Two others present with Windows comctl, but work correctly with wine's:
- you can't edit names of keys - even when you add a new key
- if you add a subkey to a key that did not have any subkeys before,
the new subkey is not visible and the parent key is not expandable.
After restarting regedit the keys are present and visible.

Regards,
Daniel

Re: gdiplus: Reimplement GdipIsEmptyRegion.

Dmitry Timoshkov — 2012-05-24T04:22:31

Hello,

I'm surprised that such a trivial patch wasn't accepted yet. But just
in case it matters, current implementation doesn't work for paths and
combined/complex regions.

Re: Testing regedit

Austin English — 2012-05-24T02:46:04

What sort of bugs? In general, any bugs found with native dlls are suspect..

Testing regedit

Daniel Jelinski — 2012-05-23T19:24:09

Hello,
I just noticed that wine's regedit has a few interesting bugs that
appear when running with native comctl32. Can I/should I file them in
the bugzilla?

Regards,
Daniel

Re: [PATCH variant 1] dsound: use a low-quality FIR for games

Alexander E. Patrakov — 2012-05-23T17:33:44

2012/5/23 Alexander E. Patrakov <patrakov< at >gmail.com>:

If your CPU is fast enough to play GTA:SA with full-quality resampler
(I can't test because I don't have this game), you can test this
clicking problem by setting the HQBuffersMax registry entry to
something that is higher than the "normal" number of the concurrent
buffers but lower than the peak number. When the threshold is crossed,
something interesting (I guess, a click) should happen with the sound,
and I also want to know what exactly :)

Re: [PATCH variant 1] dsound: use a low-quality FIR for games

Alexander E. Patrakov — 2012-05-23T17:08:45

2012/5/22 Andrew Eikum <aeikum< at >codeweavers.com>:

Yes. And Windows has two code paths as well. OTOH the linear resampler
has lower quality, and different latency from the FIR-based filter.
Due to this difference of latency there may be unaviodable clicks in
games (sorry, no concrete example) that frequently switch from 3 to 4
buffers and back. The FIR-based approach eliminates this effect,
because there is no latency difference (or, because this is untested,
better say: it's a bug in my code if there is any latency difference).


I have no real preference. If there are no other arguments (i.e. if
clicks due to switching resamplers are not a valid/worthy argument),
let's use the linear resampler, because I wrote it first and because
GyB tested it. Anyway, it doesn't really matter, because it is
possible to change this later, or even implement a 3-level quality
degradation strategy (long FIR -> short FIR -> linear interpolation).

As for your performance analysis - yes, get_current_sample() is cheap,
and the main cost is due to caching the FIR and calculating the
convolution. As far as I understand (but I can be wrong here), it
would be fair enough to count only the "sum += fir_copy[j] *
cache[j];" line. Still, I don't think it explains the whole picture.

Let's say that the FIR length is X samples of the lowest of the two
frequencies (X is a constant for a given FIR, and for my FIR it is
66). So, if upsampling, each output sample is affected by X input
samples, and by X * freqAdjust input samples when downsampling. Since
both GTA:SA and Darwinia use 32 buffers, we can consider only a single
buffer and count the number of passes through the "sum" line per
second.

Darwinia downsamples, has freqAdjust ~ 2..4. Thus, it executes the
"sum" line 2..4 * X times per output sample, i.e. 40000..90000 * X
times per second per input buffer.

GTA:SA upsamples, and thus executes the "sum" line X times per output
sample, i.e. 48000 * X times per second per input buffer.

The ratio seems to be consistent with the number of convolutions per
buffer per time step that you report, because the number of sampes per
time step is different for these two games.

So I am not convinced with your analysis - but this is based on the
assumption that only the "sum += fir_copy[j] * cache[j];" line really
matters and that filling in fir_cache eats time proportional to the
summing (it has to go through the same number of iterations).

Re: vbscript: Add support for integer values in conditional jumps.

Francois Gouget — 2012-05-23T13:51:23


I believe this is the usual VBScript test issue. At least the test 
passed on my Windows XP VM.

Re: vbscript: Add support for integer values in conditional jumps.

Marvin — 2012-05-23T13:42:14

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=18547

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
No test summary line found

=== W2KPROSP4 (32 bit) ===
No test summary line found

=== WXPPROSP3 (32 bit) ===
No test summary line found

=== W2K3R2SESP2 (32 bit) ===
No test summary line found

=== WVISTAADM (32 bit) ===
No test summary line found

=== W2K8SE (32 bit) ===
No test summary line found

=== W7PRO (32 bit) ===
No test summary line found

=== W7PROX64 (32 bit) ===
No test summary line found

=== TEST64_W7SP1 (32 bit) ===
No test summary line found

=== W7PROX64 (64 bit) ===
No test summary line found

=== TEST64_W7SP1 (64 bit) ===
No test summary line found

Re: [2/2] gdi32: Add support for emulating bold faces of bitmapfonts. Take 2. Resend.

Bruno Jesus — 2012-05-22T19:59:51

I don't know if this patch was directly related to a bug or not but
now we are sure it does really fix at least this bug:
http://bugs.winehq.org/show_bug.cgi?id=12476

Best wishes,
Bruno

Re: wineqtdecoder: Recreate audio extraction session when we runout of frames.

Aric Stewart — 2012-05-22T16:11:49

Ah, I will update the comment.

-aric

On 12/05/22 11:05, Alexandre Julliard wrote:

Re: wineqtdecoder: Recreate audio extraction session when we run outof frames.

Alexandre Julliard — 2012-05-22T16:05:24


What about the comment that says that we can't do that?

Re: [PATCH variant 1] dsound: use a low-quality FIR for games

Andrew Eikum — 2012-05-22T15:39:41

Thanks Alexander. Thoughts below...

On Sat, May 19, 2012 at 09:09:35PM +0600, Alexander E. Patrakov wrote:

Do you have an opinion on which of these patches to use? The
low-quality FIR has the advantage of not introducing another codepath.
On the other hand, the linear resampler codepath is very simple, and
even easier on the CPU.

I'm leaning towards the linear resampler for its larger CPU usage
benefits.


I did some research on this. Darwinia creates up to 32 buffers, like
you said. GTA:SA creates and destroys buffers as needed, and I saw it
go as high as 31 in a quick test. Darwinia's buffer frequencies range
in the 40-90 kHz range and resample to 22050 Hz, while GTA:SA's range
around 10-20 kHz and resample to 48 kHz.

So in each time step, GTA:SA requires about 1000-2000
get_current_sample() calls, but 4800 FIR convolutions per buffer.

Darwinia requires 4000-9000 get_current_sample() calls, but only about
2200 convolutions per buffer.

I suspect the convolutions are considerably more expensive than the
get_current_sample() calls, so I would actually expect GTA:SA to be
more CPU taxing. That should explain what's going on here.

We could test this on Gyb's machine by setting DefaultSampleRate=22050
and hacking <dlls/dsound/primary.c:primarybuffer_SetFormat> to return
S_OK without actually changing the primary buffer's format. That
should give GTA:SA similar cp_fields performance to Darwinia, and I
expect it would fix the lag issue.

Andrew

Re: winetricks & DLL overrides

2012-05-22T04:33:07

Od: "Dan Kegel" <dank< at >kegel.com>


Many thanks, i use that since the release. But i noticed that
winecfg is messed by "DLLs" like Makefile, some .a library etc. It
probably doesn't hurt anything. Maybe generate the DLL list based
only on folders (not folders + "root" files)?


Yes. That double listed DLLs in winecfg (with asterix + without
asterix) come from manually setting the DLL in winecfg and after
that running winetricks setting all the dll to builtin. Unfortunatly
the non-asterix verision wins, because the entries are latter in the
list. So winetricks may not do what one could except (all builtin).
I'm aware of that now, so again it doesn't hurt me.


Thanks again for that.
W.

Re: [1/2] ole32: Forward OleCreateLinkFromData andOleCreateStaticFromData to OleCreateFromData.

Dmitry Timoshkov — 2012-05-22T03:21:43


Probably, but these forwards make a real application that uses them
work. If you prefer I can add a FIXME stating that it's a semi-stub.

Re: [1/2] ole32: Forward OleCreateLinkFromData andOleCreateStaticFromData to OleCreateFromData.

Alexandre Julliard — 2012-05-21T19:35:19


Surely there's more to these functions than that.

Re: quartz/tests: Fix compilation on systems that don't supportnameless structs.

Francois Gouget — 2012-05-21T15:19:11

[...]
[...]

On systems that support nameless unions, which I have no doubt is the 
case of the testbot's build environment, my patch does not changed the 
preprocessed code. So I don't think it's the cause of these errors.

However what is strange is that the testbot's VMs that run the tests for 
test.winehq.org don't fail. In fact they skip the quartz tests entirely 
which seems to indicate a different VM configuration is used.

Re: quartz/tests: Fix compilation on systems that don't supportnameless structs.

Marvin — 2012-05-20T16:11:26

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=18512

Your paranoid android.


=== WNT4WSSP6 (32 bit filtermapper) ===
filtermapper.c:96: Test failed: CoCreateInstance failed with 80040154
filtermapper.c:233: Test failed: CoCreateInstance failed with 80040154
filtermapper.c:347: Test failed: CoCreateInstance failed with 80040154
filtermapper.c:405: Test failed: CoCreateInstance failed with 80040154

Re: [PATCH 3/3] shell32: Move the pidl handling to theExtractIcon_Constructor

Nikolay Sivov — 2012-05-20T17:03:58

I think it's better to pass riid to constructor helper and return 
appropriate vtable according to that riid. That will also collapse this 
to a single 'if' testing for both interfaces.

Same here as in previous patch - storing combined result vs. making 
another clone.

Re: [PATCH 1/3] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf[try 2]

Nikolay Sivov — 2012-05-20T16:59:54

I don't see a reason to ILClone() here. You could just store ILCombine() 
result.

Re: dsound: Fixed compilation error caused by 942f2ce7

Alexander E. Patrakov — 2012-05-19T15:50:18

OK, after a "make clean" and "make" it is clear that nothing needs to
be changed.

2012/5/19 Alexander E. Patrakov <patrakov< at >gmail.com>:

Re: dsound: Fixed compilation error caused by 942f2ce7

Alexander E. Patrakov — 2012-05-19T15:41:53

2012/5/19 Jacek Caban <jacek< at >codeweavers.com>:

On my system, the generated propidl.h file contains this:

struct tagPROPVARIANT {

    VARTYPE vt;
    WORD wReserved1;
    WORD wReserved2;
    WORD wReserved3;
    __C89_NAMELESS union {
/* lots of fields */
    } __C89_NAMELESSUNIONNAME;
};

So indeed, my patch is wrong, it should use __C89_NAMELESSUNIONNAME
(which expands to nothing here) instead of nothing. Please reject it.