gmane.comp.emulators.ovirt.engine.patches

Change in ovirt-engine[master]: core: Fix handlingsame network on different nics

2012-05-24T07:22:39

Moti Asayag has posted comments on this change.

Change subject: core: Fix handling same network on different nics
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
Line 165:                 // If network is on same bond, it's OK and no need to process it, otherwise it's illegal.
the check should verify the network is not associated with any other interface if it is already bonded

--
To view, visit http://gerrit.ovirt.org/4713
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cb7f7c0c7cc7c2240b72e411d81c2ddbc561766
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Livnat Peer <lpeer-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Mike Kolesnik <mkolesni-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Moti Asayag <masayag-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Supportremove of shareable disk.

2012-05-24T07:20:03

Maor Lipchuk has posted comments on this change.

Change subject: core:Support remove of shareable disk.
......................................................................


Patch Set 17: Verified; Looks good to me, approved

Acked by mkublin and rgolan

--
To view, visit http://gerrit.ovirt.org/4490
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Supportremove of shareable disk.

2012-05-24T07:18:54

Roy Golan has posted comments on this change.

Change subject: core:Support remove of shareable disk.
......................................................................


Patch Set 17: Looks good to me, approved

ack on the diff between 16 and 17

--
To view, visit http://gerrit.ovirt.org/4490
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Useattachable disk for shareable

2012-05-24T07:18:12

Maor Lipchuk has posted comments on this change.

Change subject: core:Use attachable disk for shareable
......................................................................


Patch Set 12: Verified; Looks good to me, approved

Acked by mkublin

--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e69edcd5ab63d09ae35abaec4ba6991978369be
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Update VmDaoto return multiple Vms for disk.

2012-05-24T07:17:54

Maor Lipchuk has posted comments on this change.

Change subject: core:Update VmDao to return multiple Vms for disk.
......................................................................


Patch Set 11: Verified; Looks good to me, approved

Acked by mkublin

--
To view, visit http://gerrit.ovirt.org/4491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8d0bbef4828100217e488d6dbab1b81ee65103d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Support moveof shareable disk

2012-05-24T07:17:30

Maor Lipchuk has posted comments on this change.

Change subject: core:Support move of shareable disk
......................................................................


Patch Set 13: Verified; Looks good to me, approved

Acked by mkublin

--
To view, visit http://gerrit.ovirt.org/4492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c59562fdd45cea4628c1e40e65713581647f86f
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Validateshareable disk which attached to VMs

2012-05-24T07:17:07

Maor Lipchuk has posted comments on this change.

Change subject: core:Validate shareable disk which attached to VMs
......................................................................


Patch Set 15: Verified; Looks good to me, approved

Acked by mkublin and ofrenkel

--
To view, visit http://gerrit.ovirt.org/4493
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1024782e96f341d0c9b1d24eb283e76797c0a128
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Fix imageshandler CDA.

2012-05-24T07:16:05

Maor Lipchuk has posted comments on this change.

Change subject: core:Fix images handler CDA.
......................................................................


Patch Set 16: Verified; Looks good to me, approved

Acked by mkublin

--
To view, visit http://gerrit.ovirt.org/4638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c9537e48130cf4113c933fafbcac7dd06c5d77
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Change CDAmessage to fit shareable disk

2012-05-24T07:14:38

Maor Lipchuk has posted comments on this change.

Change subject: core:Change CDA message to fit shareable disk
......................................................................


Patch Set 18: Verified; Looks good to me, approved

Acked by mkublin

--
To view, visit http://gerrit.ovirt.org/4639
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15e648267a78a76a5390ad24367a7cb2e9b8a2a3
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Allon Mureinik <amureini-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core:Cleanup forBaseImageCommand

2012-05-24T07:14:12

Maor Lipchuk has posted comments on this change.

Change subject: core:Cleanup for BaseImageCommand
......................................................................


Patch Set 18: Verified; Looks good to me, approved

Acked by mkublin

--
To view, visit http://gerrit.ovirt.org/4644
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida5aa7be5d5193a0e15d89a7888bdc0a8c15b083
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Michael Kublin <mkublin-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: engine: RefactorLdapProviderType and LdapVendorNameEnum

2012-05-24T06:55:29

Roy Golan has posted comments on this change.

Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
......................................................................


Patch Set 1: (3 inline comments)

Sharad this was exactly what we thought. good work.

....................................................
File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java
Line 4:     activeDirectory("don't know"),
hhh nice -  "Microsoft Active Directory"

Line 7:     general("what goes here"); // for rootDSE purpose
I think "Deprecated - for auto-detection usages" is ok. any thoughts?
some backgound - 
this is an uknown provider type which  trriggres auto-detection of the real provider type. its really temp till we pull the auto-detection out, don't know which versin will that be.

Line 9:     private String vendorName;
great

--
To view, visit http://gerrit.ovirt.org/4727
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8< at >public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: engine: RefactorLdapProviderType and LdapVendorNameEnum

2012-05-24T06:45:24

Roy Golan has posted comments on this change.

Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
......................................................................


Patch Set 1:

excuse us for not putting a nice link with the ovirt code-review wiki (will do some day soon) - a general work in progress rule (till we have gerrit upgraded) is to prefix your commit subject with WIP: ....

--
To view, visit http://gerrit.ovirt.org/4727
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8< at >public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: restapi: errorgetting VM NIC with non-exists network (#7824...

2012-05-24T06:45:24

Moti Asayag has uploaded a new change for review.

Change subject: restapi: error getting VM NIC with non-exists network (#782437)
......................................................................

restapi: error getting VM NIC with non-exists network (#782437)

https://bugzilla.redhat.com/782437

There are scenarios in which the network of a VM Nic does no longer
exists (e.g. exporting a VM template with nic, the network is removed
from the data-center and the template is imported, or using the same
export domain across various data-centers with different DC networks).

The patch removes the failure on retrieving the network associated with
a nic, if such network doesn't exist.

Change-Id: I66e94f92ead04a565bacb417b630db365ae4b682
Signed-off-by: Moti Asayag <masayag-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNicsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
2 files changed, 11 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/4732/1
--
To view, visit http://gerrit.ovirt.org/4732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66e94f92ead04a565bacb417b630db365ae4b682
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: webadmin: GlusterVolume - brick server changes

2012-05-24T05:54:05

Kanagaraj M has uploaded a new change for review.

Change subject: webadmin: Gluster Volume - brick server changes
......................................................................

webadmin: Gluster Volume - brick server changes

Add Bricks was using the vds_name as server name.
Now this is changed to make use of  host_name while creating bricks.

Change-Id: I009d4a76e7a96245d8ca4b7b2cd5ae3dc73e1ad6
Signed-off-by: Kanagaraj M <kmayilsa-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/4729/1
--
To view, visit http://gerrit.ovirt.org/4729
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I009d4a76e7a96245d8ca4b7b2cd5ae3dc73e1ad6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: engine: RefactorLdapProviderType and LdapVendorNameEnum

Sharad Mishra — 2012-05-24T04:41:10

Sharad Mishra has uploaded a new change for review.

Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
......................................................................

engine: Refactor LdapProviderType and LdapVendorNameEnum

This patch is still a work in progress. Its not complete and there are
holes in it. Like when merging LdapProviderType and LdapVendorNameEnum
I did not see a Vendor Name with AD. Need to know what goes there. Also
need to know what to do with 'general'.

I am emailing it out early to get feedback. There will be more versions
of it out based on feedback.

Roy and Yair, Is this what you were thinking?

Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb
Signed-off-by: Sharad Mishra <snmishra-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8< at >public.gmane.org>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/Domain.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPILdapTemplateWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapProviderType.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapVendorNameEnum.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RootDSEFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SimpleLdapTemplateWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTester.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapVendorNameEnum.java
18 files changed, 35 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/4727/1
--
To view, visit http://gerrit.ovirt.org/4727
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8< at >public.gmane.org>

Change in ovirt-engine[master]: MoveconvertToStatusList to ServerConnectionStatusReturnForX...

2012-05-23T20:01:03

Yair Zaslavsky has posted comments on this change.

Change subject: Move convertToStatusList to ServerConnectionStatusReturnForXmlRpc
......................................................................


Patch Set 1: Looks good to me, approved

One step in making some order.
Too bad it reminded me that for some strange reason Disconnect extends Connect.
It should be taken care of in a different patchset.

--
To view, visit http://gerrit.ovirt.org/4680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b2202c766050a1c865b360226694537fd09495e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: Fix warning forStorageHelperDirector

2012-05-23T19:55:02

Yair Zaslavsky has posted comments on this change.

Change subject: Fix warning for StorageHelperDirector
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java
Line 33:                     java.lang.reflect.Constructor<?> info = actionType.getConstructors()[0];
+1 on that . You can also follow Kolesnik's WIKI on installing jenkins and get it triggered per local commits (i.e - install on a host).
In general - I'm in favor of separating cleanup patches from changes, but it doesn't have to do with re-compiling

--
To view, visit http://gerrit.ovirt.org/4681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab0652d83b6fffa28fd4bc37a84ab616647cf813
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Moti Asayag <masayag-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: Fix warning forStorageHelperDirector

2012-05-23T19:34:29

Moti Asayag has posted comments on this change.

Change subject: Fix warning for StorageHelperDirector
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java
Line 22:                 java.lang.Class actionType = null;
same change could be done here as well - since it is the same type of warning.

Line 33:                     java.lang.reflect.Constructor<?> info = actionType.getConstructors()[0];
I'm fine with not doing it, however i do recommend on compiling the sources after rebase before merging the patch.

compilation takes ~4 minutes (with webadmin)

--
To view, visit http://gerrit.ovirt.org/4681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab0652d83b6fffa28fd4bc37a84ab616647cf813
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Moti Asayag <masayag-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: Fix warning forStorageHelperDirector

2012-05-23T19:13:05

Saggi Mizrahi has posted comments on this change.

Change subject: Fix warning for StorageHelperDirector
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java
Line 33:                     java.lang.reflect.Constructor<?> info = actionType.getConstructors()[0];
No, it's unrelated and it will require another compile

--
To view, visit http://gerrit.ovirt.org/4681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab0652d83b6fffa28fd4bc37a84ab616647cf813
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Moti Asayag <masayag-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine[master]: core: removeobselete scripts (#819806)

2012-05-23T18:55:51

Yair Zaslavsky has posted comments on this change.

Change subject: core: remove obselete scripts (#819806)
......................................................................


Patch Set 2:

Roy, actually, I'm rebased against master, and do not find the IPA script at the location (or at any location under the local repo).

--
To view, visit http://gerrit.ovirt.org/4569
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728836d77e9b00cbff24274a7f788ecdad0d48b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Ofer Schreiber <oschreib-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>

Change in ovirt-engine-cli[master]: cli: Implementhistory browsing mechanism #823512

2012-05-23T18:46:49

Michael Pasternak has uploaded a new change for review.

Change subject: cli: Implement history browsing mechanism #823512
......................................................................

cli: Implement history browsing mechanism #823512

implemented:

1. persistent history stack
2. recursive history search - ctrl+r
3. history listing - history
4. history slide retrieval - history N

https://bugzilla.redhat.com/show_bug.cgi?id=823512

Change-Id: Ibf390532331ae2b47952b1556b0d3267f80b09d5
Signed-off-by: Michael Pasternak <mpastern-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
---
A src/ovirtcli/historymanager.py
M src/ovirtcli/shell/engineshell.py
A src/ovirtcli/shell/historycmdshell.py
3 files changed, 146 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/18/4718/1
--
To view, visit http://gerrit.ovirt.org/4718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf390532331ae2b47952b1556b0d3267f80b09d5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>