gmane.comp.desktop.rox.devel

Re: ROX-Filer log window bug

Thomas Leonard — 2012-05-20T14:51:39

Applied:

http://repo.or.cz/w/rox-filer.git/commitdiff/37a0c90d8a7e69cedf94cee6e84eafd945ffd02f

(I use a tiling window manager, so I don't notice when windows are
missing size hints)

Thanks!

ROX SOAP/RPC loss explained

Christopher Oliver — 2012-04-02T04:50:02

   I tracked the problem down to the following, when my laptop goes online, the results of gethostbyname may
change as well.  Unfurtunately, this means that the property name used to find the running ROX-Filer no longer
matches.  I'd like to suggest that remote.c should not use our_host_name() to build the unique_id if /etc/machine-id
or /var/lib/dbus/machine-id is present.  The contents of those files should be used in preference to the hostname().

Thoughts?

SOAP RPC getting occasionally dropped

Christopher Oliver — 2012-03-28T15:21:07

I run ROX-Filer 2.11 under Slackware 13.37 with fbpanel and PekWM, the supplied GTK+ is version 2.24, and I'm
starting my session from GDM or XDM depending on whether the box is Salix or vanilla Slackware.  Occasionally
ROX-Filer seems to be ignoring SOAP RPC requests.  I've run into this with rox -D and rox -x.  The difficulty in
diagnosing is that if I quit the filer and restart it, the problem vanishes; the new ROX-Filer responds to the requests
just fine.  I suspect a race of some sort during startup, but I'm unsure what that could be between.

Ideas?

Re: Coherent naming for backdrop styles

Greygjhart — 2012-03-19T10:07:14

Hi there,


Yes I'm not very familiar yet with the development process of a 'real'
software like rox so I totally missed out backward compatibility
problems. I guess that's fine as long as the manual documents properly
documents which name to use for each property in which place.


Cool ! Good to see that my mail wasn't completely useless : )

Greygjhart


------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure

Re: Coherent naming for backdrop styles

Thomas Leonard — 2012-03-18T21:41:22

I've applied the Fit RPC part of the patch.

Thanks!

Re: Coherent naming for backdrop styles

Stephen Watson — 2012-03-17T16:10:16


Changing the names used in the config isn't really viable as it would
invalidate existing configuration files.  The missing Fit in RPC is a
genuine bug, as is the lack of a mention of Stretch in the manual.

Coherent naming for backdrop styles

Greygjhart — 2012-03-16T12:55:57

Hello there,

I had a very hard time trying to figure out what I was expected to write
to get a RPC command to actually set my wallpaper in a given mode. Of
course my first instinct was to look at the config file to find a hint,
as I could perfectly set it with rox' utility.

I was very surprised to find that what was called Centred in one was
Centre in the other one, and that's the same for others, though there
doesn't seem to be any generality here. As I still could manage to get
the 'Fit' mode to work (even after having commited atrocities like
'Fitted' or such), I proceeded to read the source code.

This is when I was flabbergasted to discover that Fit mode wasn't even
possible to set with a RPC command because its line had obviously been
forgotten.

I promised I searched a long time on the forum but I couldn't find any
topic mentioning that. Plus, it's not really a feature request or a bug
report, it's just a tiny mistake that takes no time to correct so I
really think it would've been corrected at once.

So here is the patch I propose to solve this issue and use the same
names everywhere (in the config and in the RPC commands).

Thanks a lot everybody and keep up the good work ! I've never found
anything quite like Rox among other file managers.

Greygjhart

diff --git a/ROX-Filer/src/pinboard.c b/ROX-Filer/src/pinboard.c
index 466930b..fcfde98 100644
--- a/ROX-Filer/src/pinboard.c
+++ b/ROX-Filer/src/pinboard.c
< at >< at > -1511,11 +1511,11 < at >< at > static void backdrop_from_xml(xmlNode *node)
 if (style)
 {
 current_pinboard->backdrop_style =
-  g_strcasecmp(style, "Tiled") == 0 ? BACKDROP_TILE :
-  g_strcasecmp(style, "Scaled") == 0 ? BACKDROP_SCALE :
+  g_strcasecmp(style, "Tile") == 0 ? BACKDROP_TILE :
+  g_strcasecmp(style, "Scale") == 0 ? BACKDROP_SCALE :
+  g_strcasecmp(style, "Stretch") == 0 ? BACKDROP_STRETCH :
+  g_strcasecmp(style, "Centre") == 0 ? BACKDROP_CENTRE :
   g_strcasecmp(style, "Fit") == 0 ? BACKDROP_FIT :
-  g_strcasecmp(style, "Stretched") == 0 ? BACKDROP_STRETCH :
-  g_strcasecmp(style, "Centred") == 0 ? BACKDROP_CENTRE :
   g_strcasecmp(style, "Program") == 0 ? BACKDROP_PROGRAM :
      BACKDROP_NONE;
 g_free(style);
< at >< at > -1660,11 +1660,11 < at >< at > static void pinboard_save(void)
 tree = xmlNewTextChild(root, NULL, "backdrop",
 current_pinboard->backdrop);
 xmlSetProp(tree, "style",
-style == BACKDROP_TILE   ? "Tiled" :
-style == BACKDROP_CENTRE ? "Centred" :
-style == BACKDROP_SCALE  ? "Scaled" :
+style == BACKDROP_TILE   ? "Tile" :
+style == BACKDROP_SCALE  ? "Scale" :
+style == BACKDROP_STRETCH  ? "Stretch" :
+style == BACKDROP_CENTRE ? "Centre" :
 style == BACKDROP_FIT    ? "Fit" :
-style == BACKDROP_STRETCH  ? "Stretched" :
    "Program");
 }
 
diff --git a/ROX-Filer/src/remote.c b/ROX-Filer/src/remote.c
index b71a06a..abe1503 100644
--- a/ROX-Filer/src/remote.c
+++ b/ROX-Filer/src/remote.c
< at >< at > -885,6 +885,7 < at >< at > static xmlNodePtr rpc_SetBackdrop(GList *args)
     !g_strcasecmp(style, "Scale") ? BACKDROP_SCALE :
     !g_strcasecmp(style, "Stretch") ? BACKDROP_STRETCH :
     !g_strcasecmp(style, "Centre") ? BACKDROP_CENTRE :
+    !g_strcasecmp(style, "Fit") ? BACKDROP_FIT :
      BACKDROP_NONE;
 
 if (s == BACKDROP_NONE)
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure_______________________________________________
rox-devel mailing list
rox-devel< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rox-devel

Re: ROX-Filer focus problem still there

Thomas Leonard — 2012-02-19T14:00:28

Applied - thanks (also for the detailed commit messages :-)!

Re: ROX-Filer focus problem still there

Barry Kauler — 2012-02-19T07:26:28

Nicola,
Yes, yes, yes! Thank you so much. In retrospect, looking at the code
in menu.c, what you have changed is quite obvious, and even I with
minimal C and GTK coding skills should have been able to extrapolate
from the earlier patch made by Thomas. Oh well.

Nicola, your name is going to be up in lights when I post to my blog.
This fix is a big deal to us. I have only applied your 0002 patch, as
we don't have any problem with compiling so don't need the 0001 patch.

Barry Kauler
http://bkhome.org/blog/

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/

Re: ROX-Filer focus problem still there

Nicola Fontana — 2012-02-18T14:47:57

Il giorno Sat, 18 Feb 2012 16:23:15 +0800
Barry Kauler <bkauler< at >gmail.com> ha scritto:


I attached a patch that extends the above fix to "Send to...", together
with another patch that let me build ROX-Filer on my system.


This is another issue. For what I can understand from the code, this is
expected and only happens with multiple selection.

Ciao.

Re: ROX-Filer focus problem still there

Barry Kauler — 2012-02-18T08:23:15

It is a great shame that the maintainers of ROX-Filer are not
interested in fixing this major bug.

Unfortunately, GDK_NATIVE_WINDOWS=true is not a viable workaround, as
I have reported here:

http://murga-linux.com/puppy/viewtopic.php?t=72258&start=315

...thanks for Puppy Linux forum member npierce who did some reasearch
on GDK_NATIVE_WINDOWS. Yes, exporting it only for ROX-Filer means that
other GTK apps don't crash/hang, however even if it is applied to
ROX-Filer windows only, unfortunately under certain circumstances the
Rox windows can freeze.

I lack the expertise to fix this myself. As the chief developer of
Puppy Linux, I would very much like to. Puppy has used Rox as it's
core app for file manager and desktop pinboard for years, and we are
pretty deeply tied into using it. We have used other file and desktop
managers but with the loss of some functionality.

Regards,
Barry Kauler




------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/

ROX-Filer focus problem still there

Barry Kauler — 2012-01-28T23:26:23

Probably this email needs attention by Thomas Leonard, thanks.

I originally reported an icon focus problem, that Thomas fixed, see
patch from Thomas:
http://repo.or.cz/w/rox-filer.git/commit/c2232d5075342347a8ff814ced5ce8b9e1cf64b9

...which did fix the problem, partly. However, even that fix no longer works.

It may be because Puppy Linux has progressed to GTK 2.24.8. Back then,
I think we were using GTK 2.18.x or 2.21.x.

Back then, after applying Thomas's patch, I found that there was still
a problem, that I reported:
https://sourceforge.net/tracker/?func=detail&aid=3147977&group_id=7023&atid=107023

Note, not many ROX-Filer users are reporting this problem, as some
binary package maintainers, Debian included I think, also some
releases of Puppy Linux, have put in a work-around. If this is put
into /etc/profile:

export GDK_NATIVE_WINDOWS=true

...this does fix it, however, I have had reports that this is a hack
that can upset some applications, can even upset ROX-Filer, cause a
crash.

I really don't want to have to resort to that hack. This problem has
been going on for such a long time, it would be great if it could be
finally fixed.

Sourceforge member 'n80' has recently posted a bug report about this
bug, and a patch:
https://sourceforge.net/tracker/?func=detail&aid=3463291&group_id=7023&atid=107023

...the patch is for ROX-Filer 2.11. I have tested it, it doesn't work.
Perhaps again, it is an issue with GTK 2.24.x.

Regards,
Barry Kauler

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2

Re: Rox Filer unable to compile on NetBSD (propably onOpenBSD too) (patch) (fwd)

Stephen Watson — 2012-01-17T18:10:17


I'm testing a version that removes dlopen entirely.  It was only in there
for old versions of libc without xattr support and I don't think we need to
support those anymore.

Rox Filer unable to compile on NetBSD (propably on OpenBSD too) (patch) (fwd)

Petri Laakso — 2012-01-17T11:49:46

Original post to mailing list bounced back because I was not subscribed,
so here you go:

---------- Forwarded message ----------
Date: Tue, 17 Jan 2012 12:42:25 +0200 (EET)
From: Petri Laakso <petri.laakso< at >asd.fi>
To: rox-devel< at >lists.sourceforge.net
Subject: Rox Filer unable to compile on NetBSD (propably on OpenBSD too) (patch)


Hi

I was unable to build Rox Filer on NetBSD i386 from pkgsrc-2011Q4:

xtypes.c: In function 'xattr_init':
xtypes.c:62: error: 'RTLD_NOLOAD' undeclared (first use in this function)
xtypes.c:62: error: (Each undeclared identifier is reported only once
xtypes.c:62: error: for each function it appears in.)
*** Error code 1

I found that NetBSD or OpenBSD does not have RTLD_NOLOAD flag for dlopen,
so I just removed RTLD_NOLOAD's from xtypes.c and live happily after.
Is this correct fix? If this is a correct fix, could it be implemented on
upstream sources also?

Petri

Proposed fix:

demoni$ diff -uN xtypes.c.orig xtypes.c
--- xtypes.c.orig       2009-07-18 17:23:18.000000000 +0300
+++ xtypes.c    2012-01-16 15:30:05.000000000 +0200
< at >< at > -59,11 +59,11 < at >< at >
  {
         void *libc;

-       libc = dlopen("libc.so.6", RTLD_LAZY | RTLD_NOLOAD);
+       libc = dlopen("libc.so.6", RTLD_LAZY);
         if (!libc)
         {
                 /* Try a different name for uClib support */
-               libc = dlopen("libc.so", RTLD_LAZY | RTLD_NOLOAD);
+               libc = dlopen("libc.so", RTLD_LAZY);
         }

         if (!libc)

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d

Re: ja.po for 2.11

Thomas Leonard — 2011-10-22T17:49:47

Applied - thanks!

ja.po for 2.11

TANAKA hioraki — 2011-10-21T13:50:54

New ja.po trancelated.

Please marge this.

Re: ROX-Filer 2.11

TANAKA hioraki — 2011-10-16T11:29:20

On Sat, 15 Oct 2011 18:47:24 +0100
Thomas Leonard <talex5< at >gmail.com> wrote:


I confirmed now. 
Thank you, Dr.

Re: ROX-Filer 2.11

Thomas Leonard — 2011-10-15T17:47:24

OK, I've updated the update-po script. It should work now.

http://repo.or.cz/w/rox-filer.git/commitdiff/63fba8188768f92a615534fe2589183e22c45d8b

Re: ROX-Filer 2.11

TANAKA hioraki — 2011-10-10T16:39:05

On Sun, 9 Oct 2011 19:32:59 +0100
Dr.Thomas Leonard <talex5< at >gmail.com> wrote:


I am very glad to have waited for a time!

But I am encountering trouble to updating translation. 

I did,

 $ cd ROX-Filer/src/po
 $ ./update-po

But update-po script make 0 bite files each po.

Error message is displayed in ja-jp locale, it's contained meaning
"Not existing ../messages.pot".

  2.10 -> rox-filer-2.10/ROX-Filer/Templates.glade
  2.11 -> rox-filer-2.11/ROX-Filer/Templates.ui

Changed, but update-po Line24 is

xgettext --keyword=_ --keyword=N_ --output=messages.pot \
      *.c tips ../Templates.glade)

...

ROX-Filer and Glade

Thomas Leonard — 2011-10-02T15:25:03

Some distributions are now shipping without libglade. To avoid problems:

- I added an explicit dependency on libglade to ROX-Filer's 0install
feed, so it will download libglade if you don't have it already
- I've switched from glade to GtkBuilder in the Git version

Re: Creating a ROX application ...in TCL

Stephen Watson — 2011-09-23T16:18:39


You can indeed write a ROX application in (almost) any language, it's just
easier if somebody has already written a library for that language.