gmane.os.freebsd.devel.cvs.src

svn commit: r250975 - head/usr.bin/patch

Glen Barber — 2013-05-25T07:17:16

Author: gjb (doc,ports committer)
Date: Sat May 25 07:17:16 2013
New Revision: 250975
URL: http://svnweb.freebsd.org/changeset/base/250975

Log:
  Revert r250972 to fix build.

Modified:
  head/usr.bin/patch/patch.c
  head/usr.bin/patch/util.c

Modified: head/usr.bin/patch/patch.c
==============================================================================
--- head/usr.bin/patch/patch.cSat May 25 06:28:30 2013(r250974)
+++ head/usr.bin/patch/patch.cSat May 25 07:17:16 2013(r250975)
< at >< at > -303,7 +303,7 < at >< at > main(int argc, char *argv[])
     ++fuzz <= mymaxfuzz);
 
 if (skip_rest_of_patch) {/* just got decided */
-if (ferror(ofp) | fclose(ofp)) {
+if (ferror(ofp) || fclose(ofp)) {
 say("Error writing %s\n",
     TMPOUTNAME);
 error = 1;
< at >< at > -385,7 +385,7 < at >< at > main(int argc, char *argv[])
 }
 }
 }
-if (ferror(rejfp) | fclose(rejfp)) {
+if (ferror(rejfp) || fclose(rejfp)) {
 say("Error writing %s\n", rejname);
 error = 1;
 }
< at >< at > -977,7 +977,7 < at >< at > spew_output(

svn commit: r250974 - head/sys/net80211

Adrian Chadd — 2013-05-25T06:28:30

Author: adrian
Date: Sat May 25 06:28:30 2013
New Revision: 250974
URL: http://svnweb.freebsd.org/changeset/base/250974

Log:
  Fix net80211 fragment creation.
  
  When creating fragment frames, the header length should honour the
  DATAPAD flag.
  
  This fixes the fragments that are queued to the ath(4) driver but it
  doesn't yet fix fragment transmission.  That requires further changes
  to the ath(4) transmit path.  Well, strictly speaking, it requires
  further changes to _all_ wifi driver transmit paths, but this is at least
  a start.
  
  Tested:
  
  * AR5416, STA mode, w/ fragthreshold set to 256.

Modified:
  head/sys/net80211/ieee80211_output.c

Modified: head/sys/net80211/ieee80211_output.c
==============================================================================
--- head/sys/net80211/ieee80211_output.cFri May 24 18:59:44 2013(r250973)
+++ head/sys/net80211/ieee80211_output.cSat May 25 06:28:30 2013(r250974)
< at >< at > -1495,18 +1495,28 < at >< at > static int
 ieee80211_fragment(struct ieee80211vap *v

Re: svn commit: r250972 - head/usr.bin/patch

Glen Barber — 2013-05-25T05:11:27



This breaks head/.

===> usr.bin/patch (all)
cc  -O2 -pipe  -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts
-Winline -Wnested-exter
ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/src/usr.bin/patch/backupfile.c
cc  -O2 -pipe  -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts
-Winline -Wnested-exter
ns -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/src/usr.bin/patch/inp.c
cc  -O2 -pipe  -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k
-W -Wno-unused-paramete
r -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
-Wcast-qual -Wwrite-str
ings -Wswitc

Re: svn commit: r250972 - head/usr.bin/patch

Bruce Evans — 2013-05-25T04:31:12


This is more broken than before.  Now the order of operations is
indeterminate, so the behaviour is undefined if fclose(ofp) is evaluated
before ferror(ofp) (then ferror(ofp) is passed an invalid pointer).
Now even the usual case when there is no error initially is broken.

According to C99 6.5:

        [#3]  The grouping of operators and operands is indicated by
        the syntax.61)  Except as specified later (for the function-
        call  (),  &&,  ||,  ?:,  and comma operators), the order of
        evaluation of subexpressions and the  order  in  which  side
        effects take place are both unspecified.

The && and || operators are often abused slightly, as here, to get
a particular order of evaluation in a largish subexpression.


Similarly.


SImilarly.


Error handling is very rarely correct in utilities that use stdio.
patch at least checks for errors.  The easiest way to improve it (not
just for patch) is to sprinkle fflush()es.  Blindly doing voided
fflush()es before every ferror() check

svn commit: r250973 - in stable/9: lib/libc/sys sys/kern

Jilles Tjoelker — 2013-05-24T18:59:45

Author: jilles
Date: Fri May 24 18:59:44 2013
New Revision: 250973
URL: http://svnweb.freebsd.org/changeset/base/250973

Log:
  MFC r248593: Allow O_CLOEXEC in posix_openpt() flags.
  
  PR:kern/162374

Modified:
  stable/9/lib/libc/sys/posix_openpt.2
  stable/9/sys/kern/tty_pts.c
Directory Properties:
  stable/9/lib/libc/   (props changed)
  stable/9/lib/libc/sys/   (props changed)
  stable/9/sys/   (props changed)

Modified: stable/9/lib/libc/sys/posix_openpt.2
==============================================================================
--- stable/9/lib/libc/sys/posix_openpt.2Fri May 24 18:54:52 2013(r250972)
+++ stable/9/lib/libc/sys/posix_openpt.2Fri May 24 18:59:44 2013(r250973)
< at >< at > -37,7 +37,7 < at >< at >
 .\"
 .\" $FreeBSD$
 .\"
-.Dd August 20, 2008
+.Dd March 21, 2013
 .Dt POSIX_OPENPT 2
 .Os
 .Sh NAME
< at >< at > -71,7 +71,7 < at >< at > Values for
 are constructed by a bitwise-inclusive OR of flags from the following
 list, defined in
 .In fcntl.h :
-.Bl -tag -width ".Dv O_NOCTTY"
+.Bl -tag -width ".Dv O_CLOEXEC"
 .It

svn commit: r250972 - head/usr.bin/patch

Stefan Esser — 2013-05-24T18:54:52

Author: se
Date: Fri May 24 18:54:52 2013
New Revision: 250972
URL: http://svnweb.freebsd.org/changeset/base/250972

Log:
  The error handling for writes to the target file could lead to the final
  fclose() being skipped. Fix this by using boolean "&" and "|" instead of
  short-cut operators "&&" and "||".
  While here, increment the last part of the version string. The reason is
  the fixed output file selection logic in pch.c, which was committed as
  r250943, yesterday.
  
  Reviewed by:pfg

Modified:
  head/usr.bin/patch/patch.c
  head/usr.bin/patch/util.c

Modified: head/usr.bin/patch/patch.c
==============================================================================
--- head/usr.bin/patch/patch.cFri May 24 18:28:27 2013(r250971)
+++ head/usr.bin/patch/patch.cFri May 24 18:54:52 2013(r250972)
< at >< at > -303,7 +303,7 < at >< at > main(int argc, char *argv[])
     ++fuzz <= mymaxfuzz);
 
 if (skip_rest_of_patch) {/* just got decided */
-if (ferror(ofp) || fclose(ofp)) {
+if (ferror(ofp) | fclos

svn commit: r250971 - stable/8/usr.sbin/pciconf

Konstantin Belousov — 2013-05-24T18:28:27

Author: kib
Date: Fri May 24 18:28:27 2013
New Revision: 250971
URL: http://svnweb.freebsd.org/changeset/base/250971

Log:
  MFC r250741:
  Decode new HT 3.00 and 3.10 capabilities.

Modified:
  stable/8/usr.sbin/pciconf/cap.c
Directory Properties:
  stable/8/usr.sbin/pciconf/   (props changed)

Modified: stable/8/usr.sbin/pciconf/cap.c
==============================================================================
--- stable/8/usr.sbin/pciconf/cap.cFri May 24 18:26:12 2013(r250970)
+++ stable/8/usr.sbin/pciconf/cap.cFri May 24 18:28:27 2013(r250971)
< at >< at > -276,6 +276,18 < at >< at > cap_ht(int fd, struct pci_conf *p, uint8
 case PCIM_HTCAP_X86_ENCODING:
 printf("X86 encoding");
 break;
+case PCIM_HTCAP_GEN3:
+printf("Gen3");
+break;
+case PCIM_HTCAP_FLE:
+printf("function-level extension");
+break;
+case PCIM_HTCAP_PM:
+printf("power management");
+break;
+case PCIM_HTCAP_HIGH_NODE_COUNT:
+printf("high node count");
+break;
 default:
 printf("unknown %02x", command);
 b

svn commit: r250970 - stable/8/sys/dev/pci

Konstantin Belousov — 2013-05-24T18:26:12

Author: kib
Date: Fri May 24 18:26:12 2013
New Revision: 250970
URL: http://svnweb.freebsd.org/changeset/base/250970

Log:
  MFC r250740:
  Add new capability types encodings from HyperTransport I/O Link
  Specification revisions 3.00 and 3.10.

Modified:
  stable/8/sys/dev/pci/pcireg.h
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/dev/   (props changed)
  stable/8/sys/dev/pci/   (props changed)

Modified: stable/8/sys/dev/pci/pcireg.h
==============================================================================
--- stable/8/sys/dev/pci/pcireg.hFri May 24 15:53:13 2013(r250969)
+++ stable/8/sys/dev/pci/pcireg.hFri May 24 18:26:12 2013(r250970)
< at >< at > -609,6 +609,10 < at >< at >
 #definePCIM_HTCAP_VCSET0xb800/* 10111 */
 #definePCIM_HTCAP_RETRY_MODE0xc000/* 11000 */
 #definePCIM_HTCAP_X86_ENCODING0xc800/* 11001 */
+#definePCIM_HTCAP_GEN30xd000/* 11010 */
+#definePCIM_HTCAP_FLE0xd800/* 11011 */
+#definePCIM_HTCAP_PM0xe000/* 11100 */
+#definePCIM_HTCAP_HIGH_NODE_COUNT

Re: svn commit: r250860 - head/gnu/usr.bin/diff

Brooks Davis — 2013-05-24T16:07:39

During the build, headers should either be found directly in the
source tree, or in WORLDTMP because it is specified as the compiler's
sysroot, not because the path is hardcoded.

svn commit: r250969 - head

Marcel Moolenaar — 2013-05-24T15:53:13

Author: marcel
Date: Fri May 24 15:53:13 2013
New Revision: 250969
URL: http://svnweb.freebsd.org/changeset/base/250969

Log:
  Fix building on slightly older -current and stable systems after
  the switch to bmake. The rescue bits are built via crunchgen,
  which didn't respect the MAKE environment variable until r237574
  (i.e. ~11 months ago). This resulted in a failure due to bmake's
  internal -J flag being passed around and not being understood by
  the standard (i.e. host's) make.
  Note that the failure is conditional upon having the jobServer
  feature enabled within bmake.

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1Fri May 24 14:57:38 2013(r250968)
+++ head/Makefile.inc1Fri May 24 15:53:13 2013(r250969)
< at >< at > -1215,6 +1215,10 < at >< at > _yacc=lib/liby \
 usr.bin/yacc
 .endif
 
+.if ${BOOTSTRAPPING} < 1000014
+_crunch=usr.sbin/crunch
+.endif
+
 .if ${BOOTSTRAPPING} < 1000026
 _nmtree

svn commit: r250968 - head/share/man/man8

Jamie Gritton — 2013-05-24T14:57:38

Author: jamie
Date: Fri May 24 14:57:38 2013
New Revision: 250968
URL: http://svnweb.freebsd.org/changeset/base/250968

Log:
  Mention the "nojailvnet" keyword.
  
  MFC after:3 days

Modified:
  head/share/man/man8/rc.8

Modified: head/share/man/man8/rc.8
==============================================================================
--- head/share/man/man8/rc.8Fri May 24 11:27:06 2013(r250967)
+++ head/share/man/man8/rc.8Fri May 24 14:57:38 2013(r250968)
< at >< at > -124,7 +124,9 < at >< at > Load the configuration files.
 Determine if booting in a jail,
 and add
 .Dq Li nojail
-to the list of KEYWORDS to skip in
+(no jails allowed) or
+.Dq Li nojailvnet
+(only allow vnet-enabled jails) to the list of KEYWORDS to skip in
 .Xr rcorder 8 .
 .It
 Invoke
_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250967 - head/sys/cam/scsi

Steven Hartland — 2013-05-24T11:27:06

Author: smh
Date: Fri May 24 11:27:06 2013
New Revision: 250967
URL: http://svnweb.freebsd.org/changeset/base/250967

Log:
  Enforce validation on the selected delete method via sysctl.
  
  This prevents users from selecting a delete method which may cause
  corruption e.g. MPS WS16 on pre P14 firmware.
  
  Reviewed by:pjd (mentor)
  Approved by:pjd (mentor)
  MFC after:2 days

Modified:
  head/sys/cam/scsi/scsi_da.c

Modified: head/sys/cam/scsi/scsi_da.c
==============================================================================
--- head/sys/cam/scsi/scsi_da.cFri May 24 09:48:42 2013(r250966)
+++ head/sys/cam/scsi/scsi_da.cFri May 24 11:27:06 2013(r250967)
< at >< at > -1780,7 +1780,8 < at >< at > dadeletemethodsysctl(SYSCTL_HANDLER_ARGS
 if (error != 0 || req->newptr == NULL)
 return (error);
 for (i = 0; i <= DA_DELETE_MAX; i++) {
-if (strcmp(buf, da_delete_method_names[i]) != 0)
+if (!(softc->delete_available & (1 << i)) ||
+    strcmp(buf, da_delete_method_names[i]) != 0)
 continue;
 dadeletemeth

svn commit: r250966 - head/sys/dev/md

Konstantin Belousov — 2013-05-24T09:48:42

Author: kib
Date: Fri May 24 09:48:42 2013
New Revision: 250966
URL: http://svnweb.freebsd.org/changeset/base/250966

Log:
  Fix the data corruption on the swap-backed md.
  
  Assign the rv variable a success code if the pager was not asked for
  the page.  Using an error code from the previous processed page caused
  zeroing of the valid page, when e.g. the previous page was not
  available in the pager.
  
  Reported by:lstewart
  Sponsored by:The FreeBSD Foundation
  MFC after:1 week

Modified:
  head/sys/dev/md/md.c

Modified: head/sys/dev/md/md.c
==============================================================================
--- head/sys/dev/md/md.cFri May 24 09:33:55 2013(r250965)
+++ head/sys/dev/md/md.cFri May 24 09:48:42 2013(r250966)
< at >< at > -829,7 +829,9 < at >< at > mdstart_swap(struct md_s *sc, struct bio
 m = vm_page_grab(sc->object, i, VM_ALLOC_NORMAL |
     VM_ALLOC_RETRY);
 if (bp->bio_cmd == BIO_READ) {
-if (m->valid != VM_PAGE_BITS_ALL)
+if (m->valid == VM_PAGE_BITS_ALL)
+rv = VM_P

svn commit: r250965 - stable/9/usr.sbin/pciconf

Konstantin Belousov — 2013-05-24T09:33:56

Author: kib
Date: Fri May 24 09:33:55 2013
New Revision: 250965
URL: http://svnweb.freebsd.org/changeset/base/250965

Log:
  MFC r250741:
  Decode new HT 3.00 and 3.10 capabilities.

Modified:
  stable/9/usr.sbin/pciconf/cap.c
Directory Properties:
  stable/9/usr.sbin/pciconf/   (props changed)

Modified: stable/9/usr.sbin/pciconf/cap.c
==============================================================================
--- stable/9/usr.sbin/pciconf/cap.cFri May 24 09:30:10 2013(r250964)
+++ stable/9/usr.sbin/pciconf/cap.cFri May 24 09:33:55 2013(r250965)
< at >< at > -276,6 +276,18 < at >< at > cap_ht(int fd, struct pci_conf *p, uint8
 case PCIM_HTCAP_X86_ENCODING:
 printf("X86 encoding");
 break;
+case PCIM_HTCAP_GEN3:
+printf("Gen3");
+break;
+case PCIM_HTCAP_FLE:
+printf("function-level extension");
+break;
+case PCIM_HTCAP_PM:
+printf("power management");
+break;
+case PCIM_HTCAP_HIGH_NODE_COUNT:
+printf("high node count");
+break;
 default:
 printf("unknown %02x", command);
 b

svn commit: r250964 - stable/9/sys/dev/pci

Konstantin Belousov — 2013-05-24T09:30:10

Author: kib
Date: Fri May 24 09:30:10 2013
New Revision: 250964
URL: http://svnweb.freebsd.org/changeset/base/250964

Log:
  MFC r250740:
  Add new capability types encodings from HyperTransport I/O Link
  Specification revisions 3.00 and 3.10.

Modified:
  stable/9/sys/dev/pci/pcireg.h
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/dev/   (props changed)

Modified: stable/9/sys/dev/pci/pcireg.h
==============================================================================
--- stable/9/sys/dev/pci/pcireg.hFri May 24 09:22:43 2013(r250963)
+++ stable/9/sys/dev/pci/pcireg.hFri May 24 09:30:10 2013(r250964)
< at >< at > -612,6 +612,10 < at >< at >
 #definePCIM_HTCAP_VCSET0xb800/* 10111 */
 #definePCIM_HTCAP_RETRY_MODE0xc000/* 11000 */
 #definePCIM_HTCAP_X86_ENCODING0xc800/* 11001 */
+#definePCIM_HTCAP_GEN30xd000/* 11010 */
+#definePCIM_HTCAP_FLE0xd800/* 11011 */
+#definePCIM_HTCAP_PM0xe000/* 11100 */
+#definePCIM_HTCAP_HIGH_NODE_COUNT0xe800/* 11101 */
 
 /* HT MSI Mapping C

svn commit: r250963 - in head: share/man/man4 sys/amd64/conf sys/conf sys/dev/aacraid sys/i386/conf sys/ia64/conf sys/modules sys/modules/aacraid sys/modules/aacraid/aacraid_linux

Achim Leubner — 2013-05-24T09:22:43

Author: achim
Date: Fri May 24 09:22:43 2013
New Revision: 250963
URL: http://svnweb.freebsd.org/changeset/base/250963

Log:
  Driver 'aacraid' added. Supports Adaptec by PMC RAID controller families Series 6, 7, 8 and upcoming products. Older Adaptec RAID controller families are supported by the 'aac' driver.
  
  Approved by:scottl (mentor)

Added:
  head/share/man/man4/aacraid.4   (contents, props changed)
  head/sys/dev/aacraid/
  head/sys/dev/aacraid/aacraid.c   (contents, props changed)
  head/sys/dev/aacraid/aacraid_cam.c   (contents, props changed)
  head/sys/dev/aacraid/aacraid_debug.c   (contents, props changed)
  head/sys/dev/aacraid/aacraid_debug.h   (contents, props changed)
  head/sys/dev/aacraid/aacraid_linux.c   (contents, props changed)
  head/sys/dev/aacraid/aacraid_pci.c   (contents, props changed)
  head/sys/dev/aacraid/aacraid_reg.h   (contents, props changed)
  head/sys/dev/aacraid/aacraid_var.h   (contents, props changed)
  head/sys/modules/aacraid/
  head/sys/modules/aacraid/Makefile

svn commit: r250962 - head/sys/netinet

Michael Tuexen — 2013-05-24T09:21:18

Author: tuexen
Date: Fri May 24 09:21:18 2013
New Revision: 250962
URL: http://svnweb.freebsd.org/changeset/base/250962

Log:
  Withdraw http://svnweb.freebsd.org/changeset/base/250809
  since the real fix is in http://svnweb.freebsd.org/changeset/base/250952.

Modified:
  head/sys/netinet/sctp_os_bsd.h

Modified: head/sys/netinet/sctp_os_bsd.h
==============================================================================
--- head/sys/netinet/sctp_os_bsd.hFri May 24 06:13:36 2013(r250961)
+++ head/sys/netinet/sctp_os_bsd.hFri May 24 09:21:18 2013(r250962)
< at >< at > -435,7 +435,6 < at >< at > typedef struct rtentry sctp_rtentry_t;
 { \
 int o_flgs = IP_RAWOUTPUT; \
 struct sctp_tcb *local_stcb = stcb; \
-M_SETFIB(o_pak, 0); \
 if (local_stcb && \
     local_stcb->sctp_ep && \
     local_stcb->sctp_ep->sctp_socket) \
< at >< at > -446,7 +445,6 < at >< at > typedef struct rtentry sctp_rtentry_t;
 #define SCTP_IP6_OUTPUT(result, o_pak, ro, ifp, stcb, vrf_id) \
 { \
 struct sctp_tcb *local_stcb = stcb; \
-M_SETFIB(o_pak, 0); \
 if (loca

Re: svn commit: r250809 - head/sys/netinet

Julian Elischer — 2013-05-24T07:23:45

yeah. sorry about that...

_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250809 - head/sys/netinet

Michael Tuexen — 2013-05-24T06:52:55

OK. I just saw
http://svnweb.freebsd.org/changeset/base/250952

I'll back out
http://svnweb.freebsd.org/changeset/base/250809
later today.

Best regards
Michael

_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

Re: svn commit: r250809 - head/sys/netinet

Michael Tuexen — 2013-05-24T06:50:36

And the real bug is that SCTP doesn't support multiple fibs, right?
That would mean the system crashes on reception of an out of the blue
SCTP packet...

Best regards
Michael

_______________________________________________
svn-src-all< at >freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe< at >freebsd.org"

svn commit: r250961 - stable/9/sys/cam

Scott Long — 2013-05-24T06:13:36

Author: scottl
Date: Fri May 24 06:13:36 2013
New Revision: 250961
URL: http://svnweb.freebsd.org/changeset/base/250961

Log:
  Revert r250948, it was merged too soon.

Modified:
  stable/9/sys/cam/cam_periph.c

Modified: stable/9/sys/cam/cam_periph.c
==============================================================================
--- stable/9/sys/cam/cam_periph.cFri May 24 04:03:04 2013(r250960)
+++ stable/9/sys/cam/cam_periph.cFri May 24 06:13:36 2013(r250961)
< at >< at > -733,8 +733,6 < at >< at > cam_periph_mapmem(union ccb *ccb, struct
 case XPT_CONT_TARGET_IO:
 if ((ccb->ccb_h.flags & CAM_DIR_MASK) == CAM_DIR_NONE)
 return(0);
-KASSERT((ccb->ccb_h.flags & CAM_DATA_MASK) == CAM_DATA_VADDR,
-    ("not VADDR for SCSI_IO %p %x\n", ccb, ccb->ccb_h.flags));
 
 data_ptrs[0] = &ccb->csio.data_ptr;
 lengths[0] = ccb->csio.dxfer_len;
< at >< at > -744,8 +742,6 < at >< at > cam_periph_mapmem(union ccb *ccb, struct
 case XPT_ATA_IO:
 if ((ccb->ccb_h.flags & CAM_DIR_MASK) == CAM_DIR_NONE)
 return(0);
-KASSERT((ccb->ccb_h.flags &