gmane.os.cygwin.patches

Re: [PATCH] Export memrchr

Corinna Vinschen — 2012-05-10T08:36:59



Thanks, applied.


Corinna

[PATCH] Export memrchr

Yaakov (Cygwin/X — 2012-05-09T08:18:35

Here are the patches for exporting memrchr, once my patches to newlib
are accepted.


Yaakov

Re: elf.h incomplete

Ryan Johnson — 2012-05-04T05:49:29

Linux kernel build's "modpost" utility that started off this whole 
discussion? I'm not going to be able to test it any time soon, myself, tho.

Also, libelf might use it, since it supplies its own values only if it 
can't find them in system headers, IIRC.

Ryan

Re: elf.h incomplete

Christopher Faylor — 2012-05-04T05:46:49

I think this really needs to be tested against something that uses it.

Anyone have an application that could exercise this?

cgf

Re: elf.h incomplete

Yaakov (Cygwin/X — 2012-05-03T22:03:23

This patch is a direct copy from FreeBSD HEAD.  I have NOT tested it, 
though.


Yaakov

Re: [PATCH] Extended mouse coordinates

Corinna Vinschen — 2012-04-25T08:22:57

Patch applied and rigged into 1.7.14.


Thanks,
Corinna

Re: [PATCH] Extended mouse coordinates

Thomas Wolff — 2012-04-24T21:58:17

Am 24.04.2012 22:22, schrieb Corinna Vinschen:
Here's the missing patch and changelog. Sorry again for previous mix-up.
Thomas
2012-04-24  Thomas Wolff  <towo< at >towo.net>

* fhandler.h (class dev_console): Add member ext_mouse_mode5.
* fhandler_console.cc (fhandler_console::read): Implement extended
mouse mode 1005 (xterm, mintty).
Fix actual mouse reporting for large coordinates.

diff -rup sav/fhandler.h ./fhandler.h
--- sav/fhandler.h2012-04-24 16:29:37.000000000 +0200
+++ ./fhandler.h2012-04-24 23:48:29.453125000 +0200
< at >< at > -1288,6 +1288,7 < at >< at > class dev_console
 
   bool insert_mode;
   int use_mouse;
+  bool ext_mouse_mode5;
   bool ext_mouse_mode6;
   bool ext_mouse_mode15;
   bool use_focus;
diff -rup sav/fhandler_console.cc ./fhandler_console.cc
--- sav/fhandler_console.cc2012-04-24 16:39:22.000000000 +0200
+++ ./fhandler_console.cc2012-04-24 23:52:00.265625000 +0200
< at >< at > -307,14 +307,6 < at >< at > fhandler_console::mouse_aware (MOUSE_EVE
       return 0;
     }
 
-  /* Check whether adjusted mouse position

Re: [PATCH] Extended mouse coordinates

Corinna Vinschen — 2012-04-24T20:22:55


Please recreate the patch against current CVS.  And please use
__small_sprintf instead of sprintf.


Corinna

Re: [PATCH] Extended mouse coordinates

Thomas Wolff — 2012-04-24T20:00:23

Am 24.04.2012 21:47, schrieb Corinna Vinschen:
Sh.. I see. My deep apologies, I must have been confused. Here is the 
actual updated patch which should be used instead.
Sorry for the trouble.
Thomas
2012-04-20  Thomas Wolff  <towo< at >towo.net>

* fhandler.h (class dev_console): Flags for extended mouse modes.
* fhandler_console.cc: Supporting mouse coordinates greater than 222.
(fhandler_console::read) Implemented extended mouse modes 
1015 (urxvt, mintty, xterm), 1006 (xterm), and 1005 (xterm, mintty).
Also: two { wrap formatting consistency fixes.
(fhandler_console::mouse_aware) Removed limitation of not sending 
anything at exceeded coordinates; sending 0 byte instead (xterm).
(fhandler_console::char_command) Initialization of enhanced 
mouse reporting modes.

diff -rup sav/fhandler.h ./fhandler.h
--- sav/fhandler.h2012-04-18 07:58:04.000000000 +0200
+++ ./fhandler.h2012-04-20 13:59:02.265328800 +0200
< at >< at > -1288,6 +1288,9 < at >< at > class dev_console
 
   bool insert_mode;
   int use_mouse;
+  bool ext_mous

Re: [PATCH] Extended mouse coordinates

Corinna Vinschen — 2012-04-24T19:47:53

...and as far as quoting goes, the above is the ChangeLog you provided
with your updated patch.


Corinna

Re: [PATCH] Extended mouse coordinates

Corinna Vinschen — 2012-04-24T19:45:13

That was exactly the patch I applied.  I only chnaged the formatting
and changed sprintf to  __small_sprintf.


Corinna

Re: [PATCH] Extended mouse coordinates

Thomas Wolff — 2012-04-24T19:35:00

Am 24.04.2012 16:44, schrieb Corinna Vinschen:
Hmm, thanks but I'm afraid this went wrong. You quote (and probably 
applied) my first patch which is missing mouse mode 1005 and 
unfortunately also has a bug which effectively makes the extended 
coordinates unusable (because the reports are suppressed in that case as 
they were before :( ).
The mail you responded to contained an updated patch.
Thomas

Re: [PATCH] Extended mouse coordinates

Corinna Vinschen — 2012-04-24T14:44:03


Patch applied with changes.  Please use __small_sprintf rather than
sprintf.  I also changed the CHangeLog entry slightly.  Keep it short
and in present tense.


Thanks,
Corinna

Re: Building for nocygwin

Corinna Vinschen — 2012-04-24T07:39:33

I uploaded the changes to the FAQ pages on cygwin.com.


Thanks,
Corinna

Re: Regenerate configures

Christopher Faylor — 2012-04-23T22:27:05

No, go ahead.

cgf

Regenerate configures

Yaakov (Cygwin/X — 2012-04-23T22:17:10

cygwin/doc/configure and cygwin/testsuite/configure are now the only 
configure scripts in the winsup tree which were generated with 
autoconf-2.5x.  Any objections to regenerating them with 2.68?


Yaakov

Re: Building for nocygwin

Christopher Faylor — 2012-04-23T20:06:31

Thanks very much.  Please check in (with typo correction mentioned in
followon mail).

I suspect that we'll probably need to flesh this out over time but at
least we aren't suggesting the use of a deprecated compiler option now.

cgf

Re: Building for nocygwin

Peter Rosin — 2012-04-23T19:42:04


compilers

Cheers,
Peter

Re: Building for nocygwin

Yaakov (Cygwin/X — 2012-04-23T19:35:16

Patch attached.


Yaakov

[PATCH] Extended mouse coordinates

Thomas Wolff — 2012-04-22T19:07:50

This patch replaces my previous proposal 
(http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two 
modifications:

  * Fixed a bug that suppressed mouse reporting at large coordinates (in
    all modes actually:-\ )
  * Added mouse mode 1005 (total of 3 three new modes, so all reporting
    modes run by current terminal emulators would be implemented)

I would appreciate the patch to be applied this time, planned to be my 
last mouse patch :)

Kind regards,
Thomas
2012-04-03  Thomas Wolff  <towo< at >towo.net>

* fhandler.h (class dev_console): Two flags for extended mouse modes.
* fhandler_console.cc (fhandler_console::read): Implemented 
extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
Not implemented extended mouse mode 1005 (xterm, mintty).
Supporting mouse coordinates greater than 222 (each axis).
Also: two { wrap formatting consistency fixes.
(fhandler_console::char_command) Initialization of enhanced 
mouse reporting modes.

diff -rup sav/fhandler.h ./fhandler.h
--- s

Re: [PATCH] Setting TZ may break time() in non-Cygwin programs

Christopher Faylor — 2012-04-17T20:42:37

I understand that it affects programs which use time() but the Cygwin
mailing list isn't filled with complaints about TZ being wrong for
Windows programs.  And, if we always unset it that means that these
time() using programs can never ever use the TZ environment variable.

cgf