http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs hourly 1 1901-01-01T00:00+00:00 http://gmane.org/img/gmane-25t.png http://gmane.org http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172585 <pre>Mark Bergsma has submitted this change and it was merged. Change subject: I screwed that up didn't I? ...................................................................... I screwed that up didn't I? Change-Id: I68852ed30d25029d6d47c833bb1945d3080eac67 --- M manifests/role/cache.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mark Bergsma: Looks good to me, approved jenkins-bot: Verified diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp index 8208e45..5f68862 100644 --- a/manifests/role/cache.pp +++ b/manifests/role/cache.pp &lt; at &gt;&lt; at &gt; -357,7 +357,7 &lt; at &gt;&lt; at &gt; class upload { # FIXME: remove this hack -if $::site == "eqiad" or $::realm == 'labs' { +if $::site in ["eqiad","esams"] or $::realm == 'labs' { # Varnish $cluster = "cache_upload" </pre> Mark Bergsma (Code Review 2013-05-24T10:42:41 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172584 <pre>Mark Bergsma has uploaded a new change for review. https://gerrit.wikimedia.org/r/65245 Change subject: I screwed that up didn't I? ...................................................................... I screwed that up didn't I? Change-Id: I68852ed30d25029d6d47c833bb1945d3080eac67 --- M manifests/role/cache.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/45/65245/1 diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp index 8208e45..5f68862 100644 --- a/manifests/role/cache.pp +++ b/manifests/role/cache.pp &lt; at &gt;&lt; at &gt; -357,7 +357,7 &lt; at &gt;&lt; at &gt; class upload { # FIXME: remove this hack -if $::site == "eqiad" or $::realm == 'labs' { +if $::site in ["eqiad","esams"] or $::realm == 'labs' { # Varnish $cluster = "cache_upload" </pre> Mark Bergsma (Code Review 2013-05-24T10:41:21 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172583 <pre>Mark Bergsma has submitted this change and it was merged. Change subject: Decommission old knsq* servers, and amssq* upload squids ...................................................................... Decommission old knsq* servers, and amssq* upload squids Change-Id: I2c1833bf8df1c9c1833dcbe1bb19dc524729e4ea --- M manifests/decommissioning.pp M manifests/role/cache.pp M manifests/site.pp 3 files changed, 32 insertions(+), 59 deletions(-) Approvals: Mark Bergsma: Looks good to me, approved jenkins-bot: Verified diff --git a/manifests/decommissioning.pp b/manifests/decommissioning.pp index b5687c7..8703784 100644 --- a/manifests/decommissioning.pp +++ b/manifests/decommissioning.pp &lt; at &gt;&lt; at &gt; -4,6 +4,22 &lt; at &gt;&lt; at &gt; $decommissioned_servers = [ 'adler', +'amssq47', +'amssq48', +'amssq49', +'amssq50', +'amssq51', +'amssq52', +'amssq53', +'amssq54', +'amssq55', +'amssq56', +'amssq57', +'amssq58', +'amssq59', +'amssq60', +'amssq61', +'amssq62', 'barium', 'bayes', 'bellin', &lt; at &gt;&lt; at &gt; -58,7 +74,20 &lt; at &gt;&lt; at &gt; 'knsq13', 'knsq14</pre> Mark Bergsma (Code Review 2013-05-24T10:37:36 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172582 <pre>Asher has submitted this change and it was merged. Change subject: typo fix ...................................................................... typo fix Change-Id: I4eb1587813e18e92905e01c1d5bdcf88c9cf0771 --- M modules/mysql_multi_instance/manifests/instance.pp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asher: Verified; Looks good to me, approved diff --git a/modules/mysql_multi_instance/manifests/instance.pp b/modules/mysql_multi_instance/manifests/instance.pp index dcfc438..cb065c7 100644 --- a/modules/mysql_multi_instance/manifests/instance.pp +++ b/modules/mysql_multi_instance/manifests/instance.pp &lt; at &gt;&lt; at &gt; -57,7 +57,7 &lt; at &gt;&lt; at &gt; service { "mysql-${port}": - enabled =&gt; true, + enable =&gt; true, require =&gt; File["/etc/init.d/mysql-${port}"], } </pre> Asher (Code Review 2013-05-24T10:32:45 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172581 <pre>Asher has uploaded a new change for review. https://gerrit.wikimedia.org/r/65244 Change subject: typo fix ...................................................................... typo fix Change-Id: I4eb1587813e18e92905e01c1d5bdcf88c9cf0771 --- M modules/mysql_multi_instance/manifests/instance.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/44/65244/1 diff --git a/modules/mysql_multi_instance/manifests/instance.pp b/modules/mysql_multi_instance/manifests/instance.pp index dcfc438..cb065c7 100644 --- a/modules/mysql_multi_instance/manifests/instance.pp +++ b/modules/mysql_multi_instance/manifests/instance.pp &lt; at &gt;&lt; at &gt; -57,7 +57,7 &lt; at &gt;&lt; at &gt; service { "mysql-${port}": - enabled =&gt; true, + enable =&gt; true, require =&gt; File["/etc/init.d/mysql-${port}"], } </pre> Asher (Code Review 2013-05-24T10:32:24 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172580 <pre>Mark Bergsma has uploaded a new change for review. https://gerrit.wikimedia.org/r/65243 Change subject: Decommission old knsq* servers, and amssq* upload squids ...................................................................... Decommission old knsq* servers, and amssq* upload squids Change-Id: I2c1833bf8df1c9c1833dcbe1bb19dc524729e4ea --- M manifests/decommissioning.pp M manifests/role/cache.pp M manifests/site.pp 3 files changed, 32 insertions(+), 59 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/43/65243/1 diff --git a/manifests/decommissioning.pp b/manifests/decommissioning.pp index b5687c7..8703784 100644 --- a/manifests/decommissioning.pp +++ b/manifests/decommissioning.pp &lt; at &gt;&lt; at &gt; -4,6 +4,22 &lt; at &gt;&lt; at &gt; $decommissioned_servers = [ 'adler', +'amssq47', +'amssq48', +'amssq49', +'amssq50', +'amssq51', +'amssq52', +'amssq53', +'amssq54', +'amssq55', +'amssq56', +'amssq57', +'amssq58', +'amssq59', +'amssq60', +'amssq61', +'amssq62', 'barium', 'bayes', 'bellin'</pre> Mark Bergsma (Code Review 2013-05-24T10:28:49 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172579 <pre>Asher has submitted this change and it was merged. Change subject: auto start mysql-multi instances ...................................................................... auto start mysql-multi instances Change-Id: I7f77268fd6733702b93562ce01b768d50284bc77 --- M modules/mysql_multi_instance/manifests/instance.pp 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Asher: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/modules/mysql_multi_instance/manifests/instance.pp b/modules/mysql_multi_instance/manifests/instance.pp index 4656c41..dcfc438 100644 --- a/modules/mysql_multi_instance/manifests/instance.pp +++ b/modules/mysql_multi_instance/manifests/instance.pp &lt; at &gt;&lt; at &gt; -55,6 +55,12 &lt; at &gt;&lt; at &gt; content =&gt; template('mysql_multi_instance/mysql.init.erb'); } + service { + "mysql-${port}": + enabled =&gt; true, + require =&gt; File["/etc/init.d/mysql-${port}"], + } + ## some per-instance monitoring here nrpe::monitor_service { "mysql_recent</pre> Asher (Code Review 2013-05-24T10:27:45 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172578 <pre>Pyoungmeister has submitted this change and it was merged. Change subject: comment for bookkeeping ...................................................................... comment for bookkeeping Change-Id: I92d40e7993bf430049f4cc324f699bc3384cf4de --- M manifests/site.pp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified diff --git a/manifests/site.pp b/manifests/site.pp index bc2dd4c..37a9c3a 100644 --- a/manifests/site.pp +++ b/manifests/site.pp &lt; at &gt;&lt; at &gt; -716,9 +716,9 &lt; at &gt;&lt; at &gt; } } -## 2013-04-10: py using db101[345] for testing +## 2013-04-10: py using db101[45] and db1023 for testing ## not currently in production and/or hardware issues -node /^db10(1[345]|2[3]|3[2367]|4[45])\.eqiad\.wmnet/ { +node /^db10(1[45]|2[3]|3[2367]|4[45])\.eqiad\.wmnet/ { include standard } </pre> Pyoungmeister (Code Review 2013-05-24T10:27:32 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172577 <pre>Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/65242 Change subject: Wikimedia pakistan chapter redirect ...................................................................... Wikimedia pakistan chapter redirect Bug: 48754 Change-Id: Ib90f30c4d08f17c2ad20ffc46ac4131ba9308178 --- M redirects.conf 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/apache-config refs/changes/42/65242/1 diff --git a/redirects.conf b/redirects.conf index e546165..2898b36 100644 --- a/redirects.conf +++ b/redirects.conf &lt; at &gt;&lt; at &gt; -56,6 +56,7 &lt; at &gt;&lt; at &gt; nb.wikipedia.org tp.wikipedia.org \ nostalgia.wikimedia.org \ pa.us.wikimedia.org \ + pk.wikimedia.org \ pt.wikimedia.org \ quality.wikipedia.org quality.wikipedia.com \ quote.wikipedia.org \ &lt; at &gt;&lt; at &gt; -638,6 +639,9 &lt; at &gt;&lt; at &gt; RewriteCond %{HTTP_HOST} =cs.wikimedia.org RewriteRule . http://www.wikimedia.cz/ [R=301,L] + RewriteCond %{HTTP_HOST} =pk.w</pre> Reedy (Code Review 2013-05-24T10:27:26 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172576 <pre>Dereckson has uploaded a new change for review. https://gerrit.wikimedia.org/r/65241 Change subject: (bug 48682) Enable flood group on es.wikipedia ...................................................................... (bug 48682) Enable flood group on es.wikipedia New group: Group name .... flood User rights ... bot Permissions: Bureaucrats ... / Sysops ........ add/del to self Change-Id: If39689610c26d96c22cd0db9eeef7572544a4f0e --- M wmf-config/InitialiseSettings.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/41/65241/1 diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 12119d5..778e84d 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php &lt; at &gt;&lt; at &gt; -6960,6 +6960,7 &lt; at &gt;&lt; at &gt; '*' =&gt; array( 'patrolmarks' =&gt; true ), 'autopatrolled' =&gt; array( 'autopatrol' =&gt; true ), 'patroller' =&gt; array( 'patrol' =&gt; true, 'autopatrol' =&gt; true ), +'flood' =&gt; a</pre> Dereckson (Code Review 2013-05-24T10:17:58 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172575 <pre>jenkins-bot has submitted this change and it was merged. Change subject: Added tests for Diff getAddedValues and getRemovedValues ...................................................................... Added tests for Diff getAddedValues and getRemovedValues Change-Id: I73f11cd054407f9824d1dc7e7c591049511b4025 --- M tests/phpunit/diffop/diff/DiffTest.php 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/diffop/diff/DiffTest.php b/tests/phpunit/diffop/diff/DiffTest.php index 5f41319..a2fc15f 100644 --- a/tests/phpunit/diffop/diff/DiffTest.php +++ b/tests/phpunit/diffop/diff/DiffTest.php &lt; at &gt;&lt; at &gt; -538,6 +538,48 &lt; at &gt;&lt; at &gt; call_user_func_array( $function, $arguments ); } +public function testGetAddedValues() { +$diff = new Diff( array( +new DiffOpAdd( 0 ), +new DiffOpRemove( 1 ), +new DiffOpAdd( 2 ), +new DiffOpRemove( 3 ), +new DiffOpAdd( 4 ), +new DiffOpChange( 7, 5 ), +new Di</pre> jenkins-bot (Code Review 2013-05-24T10:12:58 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172574 <pre>jenkins-bot has submitted this change and it was merged. Change subject: Added tests for exceptions in Diff constructor ...................................................................... Added tests for exceptions in Diff constructor Change-Id: I1dcde55de96c144d3d26410ba0e749d168ca42ec --- M tests/phpunit/diffop/diff/DiffTest.php 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/phpunit/diffop/diff/DiffTest.php b/tests/phpunit/diffop/diff/DiffTest.php index 5f41319..c4803f8 100644 --- a/tests/phpunit/diffop/diff/DiffTest.php +++ b/tests/phpunit/diffop/diff/DiffTest.php &lt; at &gt;&lt; at &gt; -629,5 +629,58 &lt; at &gt;&lt; at &gt; $list-&gt;append( $invalidDiffOp ); } +/** + * &lt; at &gt;dataProvider invalidIsAssociativeProvider + */ +public function testConstructWithInvalidIsAssociative( $isAssociative ) { +$this-&gt;setExpectedException( 'InvalidArgumentException' ); +new Diff( array(), $isAssociative ); +} + +public function invalid</pre> jenkins-bot (Code Review 2013-05-24T10:12:44 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172573 <pre>Pyoungmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/65240 Change subject: comment for bookkeeping ...................................................................... comment for bookkeeping Change-Id: I92d40e7993bf430049f4cc324f699bc3384cf4de --- M manifests/site.pp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/40/65240/1 diff --git a/manifests/site.pp b/manifests/site.pp index bc2dd4c..37a9c3a 100644 --- a/manifests/site.pp +++ b/manifests/site.pp &lt; at &gt;&lt; at &gt; -716,9 +716,9 &lt; at &gt;&lt; at &gt; } } -## 2013-04-10: py using db101[345] for testing +## 2013-04-10: py using db101[45] and db1023 for testing ## not currently in production and/or hardware issues -node /^db10(1[345]|2[3]|3[2367]|4[45])\.eqiad\.wmnet/ { +node /^db10(1[45]|2[3]|3[2367]|4[45])\.eqiad\.wmnet/ { include standard } </pre> Pyoungmeister (Code Review 2013-05-24T10:10:39 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172572 <pre>Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/65239 Change subject: phplint builder now uses git-changed-in-head ...................................................................... phplint builder now uses git-changed-in-head The phplint macro relied on the old ant build script. Its main feature was merely to find modified php/php5/inc/phtml files in HEAD. The git-changed-in-head is way nicer to find those changes. Change-Id: I1eddacb044e4c614c3051bafe5797a3b96085f49 --- M macro.yaml 1 file changed, 3 insertions(+), 12 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config refs/changes/39/65239/1 diff --git a/macro.yaml b/macro.yaml index 2b0a89f..e862f6f 100644 --- a/macro.yaml +++ b/macro.yaml &lt; at &gt;&lt; at &gt; -282,18 +282,9 &lt; at &gt;&lt; at &gt; - builder: name: phplint builders: - # For some reason php5-parsekit segfaults when an error is encountered - # - shell: | - # #!/bin/bash - # # Files changed in this revision, e</pre> Hashar (Code Review 2013-05-24T10:09:37 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172571 <pre>Tobias Gritschacher has submitted this change and it was merged. Change subject: List rotator widget: Assigning position absolute to menu ...................................................................... List rotator widget: Assigning position absolute to menu List rotator menu needs to be positioned "absolute" on order for its position to be calculated correctly. Change-Id: I09ec3008a66673a4c45324ae5568e2672c3dffd9 --- M ValueView/resources/jquery.ui/jquery.ui.listrotator.css 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/ValueView/resources/jquery.ui/jquery.ui.listrotator.css b/ValueView/resources/jquery.ui/jquery.ui.listrotator.css index e606613..2c4b193 100644 --- a/ValueView/resources/jquery.ui/jquery.ui.listrotator.css +++ b/ValueView/resources/jquery.ui/jquery.ui.listrotator.css &lt; at &gt;&lt; at &gt; -67,6 +67,7 &lt; at &gt;&lt; at &gt; .ui-listrotator-menu { font-size: 84%; padding: 0; +position: absolute; z-index: 1; } </pre> Tobias Gritschacher (Code Review 2013-05-24T10:05:11 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172570 <pre>Tobias Gritschacher has submitted this change and it was merged. Change subject: Input extender widget: Removed obsolete stopPropagation() ...................................................................... Input extender widget: Removed obsolete stopPropagation() Calling stopPropagation() interferes with other widgets listening to click events on parent nodes. Even more, calling stopPropagation is not required since checking if the extension is clicked is done by using jQuery's ".closest()". Change-Id: I178f80357cb4fed7b9d186f4c9e3b6811850289e --- M ValueView/resources/jquery.ui/jquery.ui.inputextender.js 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tobias Gritschacher: Looks good to me, approved diff --git a/ValueView/resources/jquery.ui/jquery.ui.inputextender.js b/ValueView/resources/jquery.ui/jquery.ui.inputextender.js index d00393d..0ce49fe 100644 --- a/ValueView/resources/jquery.ui/jquery.ui.inputextender.js +++ b/ValueView/resources/jquery.ui/jquery.ui.inputextender.js &lt; at &gt;&lt; at &gt; -</pre> Tobias Gritschacher (Code Review 2013-05-24T10:05:02 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172569 <pre>Dr0ptp4kt has uploaded a new change for review. https://gerrit.wikimedia.org/r/65238 Change subject: Make addWarning() return the provided link if no pattern match. ...................................................................... Make addWarning() return the provided link if no pattern match. Change-Id: I1329d85c31a51ff189cb3b9d67744f21490df85a --- M includes/PageRenderingHooks.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess refs/changes/38/65238/1 diff --git a/includes/PageRenderingHooks.php b/includes/PageRenderingHooks.php index d538878..88f154c 100644 --- a/includes/PageRenderingHooks.php +++ b/includes/PageRenderingHooks.php &lt; at &gt;&lt; at &gt; -648,6 +648,8 &lt; at &gt;&lt; at &gt; $link ); return $link; +} else { +return $link; } } </pre> Dr0ptp4kt (Code Review 2013-05-24T10:03:38 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172568 <pre>jenkins-bot has submitted this change and it was merged. Change subject: Unset language specific aliases set when removing the last alias ...................................................................... Unset language specific aliases set when removing the last alias (bug 48744) Change-Id: I087433203db60abfc3c59883b12894bc965bba59 --- M DataModel/DataModel/Entity/Entity.php M lib/tests/phpunit/entity/EntityDiffOldTest.php 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/DataModel/DataModel/Entity/Entity.php b/DataModel/DataModel/Entity/Entity.php index 0cba035..5fd1828 100644 --- a/DataModel/DataModel/Entity/Entity.php +++ b/DataModel/DataModel/Entity/Entity.php &lt; at &gt;&lt; at &gt; -335,7 +335,12 &lt; at &gt;&lt; at &gt; * &lt; at &gt;param array $aliases */ public function setAliases( $languageCode, array $aliases ) { -$this-&gt;data['aliases'][$languageCode] = array_unique( $aliases ); +$aliases = array_unique( $aliases ); +if( count</pre> jenkins-bot (Code Review 2013-05-24T09:50:42 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172567 <pre>Pyoungmeister has submitted this change and it was merged. Change subject: cking out testing stuffs for db77 ...................................................................... cking out testing stuffs for db77 Change-Id: I0e7dfd7bb7b5cdef59ed9abb2766131d62d717e9 --- M manifests/site.pp 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Pyoungmeister: Looks good to me, approved jenkins-bot: Verified diff --git a/manifests/site.pp b/manifests/site.pp index 8ee8d72..bc2dd4c 100644 --- a/manifests/site.pp +++ b/manifests/site.pp &lt; at &gt;&lt; at &gt; -527,19 +527,6 &lt; at &gt;&lt; at &gt; } } -node "db77.pmtpa.wmnet" { - -# include role::fundraising::database::dump_slave -# class { 'misc::fundraising::backup::archive_sync': hour =&gt; [4,12,20], minute =&gt; 5 } - - system_role { "role::fundraising::database::dump": description =&gt; "Fundraising Database Dump/Backup" } - system_role { "role::fundraising::database": description =&gt; "Fundraising Database (${mysql_role})" } - include role::coredb::fundraising - include misc::fu</pre> Pyoungmeister (Code Review 2013-05-24T09:46:47 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172566 <pre>Pyoungmeister has uploaded a new change for review. https://gerrit.wikimedia.org/r/65237 Change subject: cking out testing stuffs for db77 ...................................................................... cking out testing stuffs for db77 Change-Id: I0e7dfd7bb7b5cdef59ed9abb2766131d62d717e9 --- M manifests/site.pp 1 file changed, 0 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/37/65237/1 diff --git a/manifests/site.pp b/manifests/site.pp index 8ee8d72..bc2dd4c 100644 --- a/manifests/site.pp +++ b/manifests/site.pp &lt; at &gt;&lt; at &gt; -527,19 +527,6 &lt; at &gt;&lt; at &gt; } } -node "db77.pmtpa.wmnet" { - -# include role::fundraising::database::dump_slave -# class { 'misc::fundraising::backup::archive_sync': hour =&gt; [4,12,20], minute =&gt; 5 } - - system_role { "role::fundraising::database::dump": description =&gt; "Fundraising Database Dump/Backup" } - system_role { "role::fundraising::database": description =&gt; "Fundraising Database (${mysql_role})" } - include role::</pre> Pyoungmeister (Code Review 2013-05-24T09:45:23 http://permalink.gmane.org/gmane.org.wikimedia.mediawiki.cvs/172565 <pre>ArielGlenn has uploaded a new change for review. https://gerrit.wikimedia.org/r/65236 Change subject: XML text dumps: skip rev length check for weird content models ...................................................................... XML text dumps: skip rev length check for weird content models Change-Id: I199531901d91185a578e7857bc15f28ce2021eef --- M maintenance/backupTextPass.inc 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/36/65236/1 diff --git a/maintenance/backupTextPass.inc b/maintenance/backupTextPass.inc index c5e48f4..b40f8b3 100644 --- a/maintenance/backupTextPass.inc +++ b/maintenance/backupTextPass.inc &lt; at &gt;&lt; at &gt; -414,6 +414,8 &lt; at &gt;&lt; at &gt; * &lt; at &gt;throws MWException */ function getText( $id ) { +global $wgContentHandlerUseDB; + $prefetchNotTried = true; // Whether or not we already tried to get the text via prefetch. $text = false; // The candidate for a good text. false if no proper value. $failures = 0; // The </pre> ArielGlenn (Code Review 2013-05-24T09:39:45 Search the mailing list at Gmane query http://search.gmane.org/?group=$group=gmane.org.wikimedia.mediawiki.cvs