gmane.org.wikimedia.mediawiki.codereview

[pywikipedia r10825]: New comment added

MediaWiki Mail — 2013-01-01T20:43:28

"Huji" posted a comment on pywikipedia.r10825.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10825#c33217

Commit summary for pywikipedia.r10825:

(bug 3598083) Internationalizing the comma in lists

Huji's comment:

Yes sir, I understood you the first time. My response was to Ladsgroup; to rephrase myself: we need only one message for localized comma, but we will not use it everywhere; in some places, we should still stick to the unlocalized comma.

[pywikipedia r10825]: New comment added

MediaWiki Mail — 2013-01-01T15:13:37

"Ladsgroup" posted a comment on pywikipedia.r10825.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10825#c33216

Commit summary for pywikipedia.r10825:

(bug 3598083) Internationalizing the comma in lists

Ladsgroup's comment:

I agree with xqt

[pywikipedia r10825]: New comment added

MediaWiki Mail — 2013-01-01T13:33:45

"Xqt" posted a comment on pywikipedia.r10825.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10825#c33215

Commit summary for pywikipedia.r10825:

(bug 3598083) Internationalizing the comma in lists

Xqt's comment:

My intention is: we do not need translations "interwiki-comma", "template-comma", "wikipedia-comma", "subster-comma", "apispec-comma", "archivebot-comma" etc. which all use a ", ".join() for any output. Btw i18n is not only for the edit summary but also for log pages and files and not least for the user interface (see config.userinterface_lang). So I propose to use only one central i18n translation at /i18n/pywikibot.py or the mediawiki message [[MediaWiki:Comma-separator]]. Since we have only a few translations [http://translatewiki.net/w/i.php?title=Special%3APrefixIndex&prefix=Comma&namespace=8] and the others are equal to the default one we do not need additional translations and I prefer to use the mw message instead.

[Wikimedia r2416]: Revision status changed

MediaWiki Mail — 2013-01-01T01:51:58

"Adamw" changed the status of Wikimedia.r2416 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/2416

Old status:  new
New status: ok

Commit summary for Wikimedia.r2416:

GC Audit Module - Added logic to not blow up if all we did to halt execution was run out of logs.

[Wikimedia r2415]: Revision status changed

MediaWiki Mail — 2012-12-31T23:26:07

"Adamw" changed the status of Wikimedia.r2415 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/2415

Old status:  new
New status: ok

Commit summary for Wikimedia.r2415:

GC Audit Module - Killing some log noise and unused variables.

[pywikipedia r10769]: New comment added

MediaWiki Mail — 2012-12-31T21:10:25

"Xqt" posted a comment on pywikipedia.r10769.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10769#c33214

Commit summary for pywikipedia.r10769:

Page.comment() method added.
Page edit restriction will raise if the last comment contents the bots username. In most cases the previous edit was reverted.

Xqt's comment:

Hm the same exception is raised when a page is (b)locked by a template. Should this also get a different exception error?

[Wikimedia r2414]: Revision status changed

MediaWiki Mail — 2012-12-31T21:01:22

"Adamw" changed the status of Wikimedia.r2414 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/2414

Old status:  new
New status: ok

Commit summary for Wikimedia.r2414:

Getting the GC audit module to stop exploding unnecessarily.

[pywikipedia r10769]: New comment added,and revision status changed

MediaWiki Mail — 2012-12-31T20:09:15

"Multichill" changed the status of pywikipedia.r10769 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10769#c33213

Old Status: new
New Status: fixme

Commit summary for pywikipedia.r10769:

Page.comment() method added.
Page edit restriction will raise if the last comment contents the bots username. In most cases the previous edit was reverted.

Multichill's comment:

Causing problems, see http://lists.wikimedia.org/pipermail/pywikipedia-l/2012-December/thread.html#7679 .

If a page is not locked a LockedPage exception should never be thrown, that's just incorrect.

[pywikipedia r10852]: Revision status changed

MediaWiki Mail — 2012-12-31T11:19:44

"Xqt" changed the status of pywikipedia.r10852 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10852

Old status:  new
New status: ok

Commit summary for pywikipedia.r10852:

Update family file

[pywikipedia r10833]: Revision status changed

MediaWiki Mail — 2012-12-30T16:35:26

"Xqt" changed the status of pywikipedia.r10833 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10833

Old status:  new
New status: ok

Commit summary for pywikipedia.r10833:

user names must be normalized to avoid repeated API calls for userinfo.

[pywikipedia r10828]: Revision status changed

MediaWiki Mail — 2012-12-30T16:09:52

"Xqt" changed the status of pywikipedia.r10828 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10828

Old status:  new
New status: ok

Commit summary for pywikipedia.r10828:

bug fix; 'svn:keywords Id' set for families folder

[pywikipedia r10838]: Revision status changed

MediaWiki Mail — 2012-12-30T16:08:28

"Xqt" changed the status of pywikipedia.r10838 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10838

Old status:  new
New status: ok

Commit summary for pywikipedia.r10838:

more docu and usage info

[pywikipedia r10839]: Revision status changed

MediaWiki Mail — 2012-12-30T12:32:05

"Xqt" changed the status of pywikipedia.r10839 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10839

Old status:  new
New status: ok

Commit summary for pywikipedia.r10839:

bug fix; use pywikibot.output instead of print in order to log

[pywikipedia r10835]: Revision status changed

MediaWiki Mail — 2012-12-30T11:38:35

"Xqt" changed the status of pywikipedia.r10835 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10835

Old status:  new
New status: ok

Commit summary for pywikipedia.r10835:

wikivoyage_family:add more info and cross_project datas

[pywikipedia r10845]: Revision status changed

MediaWiki Mail — 2012-12-30T11:37:17

"Xqt" changed the status of pywikipedia.r10845 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10845

Old status:  new
New status: ok

Commit summary for pywikipedia.r10845:

Localisation updates from http://translatewiki.net.

[MediaWiki r97686]: New comment added

MediaWiki Mail — 2012-12-30T11:23:38

"Helder.wiki" posted a comment on MediaWiki.r97686.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97686#c33212

Commit summary for MediaWiki.r97686:

Make per page edit notices work in namespaces without subpages enabled.

Helder.wiki's comment:

<small>[[bugzilla:22094|ignore me]]</small>

[MediaWiki r48276]: New comment added

MediaWiki Mail — 2012-12-30T11:23:23

"Helder.wiki" posted a comment on MediaWiki.r48276.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/48276#c33211

Commit summary for MediaWiki.r48276:

remove per-page editnotice functionality, message files and message cache are supposed to be global data.

Helder.wiki's comment:

<small>[[bugzilla:22094|ignore me]]</small>

[pywikipedia r10836]: Revision status changed

MediaWiki Mail — 2012-12-30T10:16:09

"Xqt" changed the status of pywikipedia.r10836 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10836

Old status:  new
New status: ok

Commit summary for pywikipedia.r10836:

Create use_hard_category_redirects property for future use; see [[commons:Template talk:Category redirect]] for a proposal to replace category redirect templates with hard redirects.

[pywikipedia r10825]: New comment added

MediaWiki Mail — 2012-12-29T18:26:06

"Huji" posted a comment on pywikipedia.r10825.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10825#c33210

Commit summary for pywikipedia.r10825:

(bug 3598083) Internationalizing the comma in lists

Huji's comment:

I have been thinking about that too. With the interwiki, we might want to stick with the non-localized comma separator, but with other scripts, we should switch to localized one.

[pywikipedia r10832]: Revision status changed

MediaWiki Mail — 2012-12-29T18:24:42

"Huji" changed the status of pywikipedia.r10832 to "reverted"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10832

Old status:  new
New status: reverted

Commit summary for pywikipedia.r10832:

(bug 3594792) do not convert English comma to Persian comma; the current exceptions are not complicated enough, analysis of bot activities shows that false positive rate is too high, therefore the feature is removed

[pywikipedia r10837]: Revision status changed

MediaWiki Mail — 2012-12-29T18:24:31

"Huji" changed the status of pywikipedia.r10837 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10837

Old status:  new
New status: ok

Commit summary for pywikipedia.r10837:

reverting r10832 and fixing up bug #3594792, per our talk in [[w:fa:User talk:Huji#اعتراض]]

_______________________________________________
MediaWiki-CodeReview mailing list
MediaWiki-CodeReview< at >lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview