gmane.org.netlabs.fm2.devel

Re: WinDlgBox

Steven Levine — 2013-04-22T00:38:03

In <003.60d2040060687451.006-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org>, on 04/21/13
   at 04:29 PM, "Gregg Young" <ygk-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org> said:

Hi,


I think I see what's wrong.  It's the HELPSUBTABLE definitions.  Each
subtable corresponds to a specific window.  It you change the HELPTABLE to
something like

HELPTABLE ID_HELPTABLE
{
   HELPITEM MAIN_FRAME,      ID_HELPSUBTABLE_MAIN,  HELP_MAIN
   HELPITEM ASS_FRAME,       ID_HELPSUBTABLE_ASS, HELP_ASSOC
   HELPITEM EXEC_FRAME,      ID_HELPSUBTABLE_EXEC, HELP_CMDLINE
   HELPITEM ASEL_FRAME,      ID_HELPSUBTABLE_ASEL, HELP_ARCHIVERS
   HELPITEM ASEL_EDIT_FRAME, ID_HELPSUBTABLE_ASEL_EDIT, HELP_EDITARC
   HELPITEM FLE_FRAME,       ID_HELPSUBTABLE_FLE, HELP_INFO 
   HELPITEM CMD_FRAME,       ID_HELPSUBTABLE_CMD, HELP_COMMAND 
   HELPITEM EA_FRAME,        ID_HELPSUBTABLE_EA, HELP_EAS
}

and update the HELPSUBTABLE definitions to match, the dialog help should
start working better when you use a subtable with entries that match the
dialog wind

Re: WinDlgBox

Steven Levine — 2013-04-22T00:09:22

In <003.60d2040060687451.006-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org>, on 04/21/13
   at 04:29 PM, "Gregg Young" <ygk-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org> said:

Hi,



This says you need to tweak your pmspy settings.  Be sure to enable the
Help/IPF message group.  Use to File->profile save/load options to
preserve your settings across pmspy restarts.


I'll do some more testing later.

Steven

Re: WinDlgBox

Gregg Young — 2013-04-21T22:29:52

Working
Commands (edit commands)
Associations (edit associations)

Not working
Display EAs (EA_FRAME)
Display object information (FLE_FRAME)


I get nothing.


Not working:
FileInfoProc
DisplayEAsProc

Working:
CommandDlgProc
AssocDlgProc



I only see the WM_HELP message. There aren't any HM_ messages displayed. This is true 
for both the working and nonworking dialogs

It is now. I just committed my working and nonworking HELPTABLE additions. Thanks

Gregg

Re: WinDlgBox

Steven Levine — 2013-04-21T19:10:34

In <003.00470900702f7451.026-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org>, on 04/21/13
   at 12:26 PM, "Gregg Young" <ygk-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org> said:

Hi,


Since you didn't mention specific dialog boxes, I took a look at a couple
of possible culprits and they seem to exit as I would expect.


I would not expect them to.  The work is done by WinDefDlgProc.


What does happen for the failing dialogs?  Are you getting just generic
help?


With pmspy, less is better.  Turn everything off and enable just what you
need.

A quick test enabling just WM_HELP and the HM_ message group works fine
here.


Try again using my less is better approach.  Pmspy obviously can be very
instrusive.  It was never intended to be used with everything enabled.


I'm not sure which dialog you are talking about.  What is the name of the
dialog procedure?


Offhand I have to suspect a problem with the help ids.

As I mentioned, try PMSPY with HM_, WM_HELP and WM_COMMAND enabled and I
think you should be able to figure ou

Re: WinDlgBox

Gregg Young — 2013-04-21T18:26:56

Steven

Both the working and non working dialog procs end with: 
return WinDefDlgProc(hwnd, msg, mp1, mp2);
I don't see where they are intercepting any HM_ messages either.  I don't see any clear 
difference between the 2 groups (working and not working).


I tried this. On my main partition if I started it before FM2, FM2 wouldn't start unless I switch 
off part of spy's hooks. I also noticed that Ctrl-Esc doesn't bring up the window list (the 
start key does however). After I crashed spy it wouldn't restart. It appeared in the CAD list 
and could be killed but never appeared in the window list or on the desktop. 

Booted to my 2.2 test partition I was able to use it with FM2. On the nonworking dialogs 
(object info dialog was what I tested) nothing happens when you press F1 over the frame 
window when it has focus. I then selected its listbox to spy on. It discards the WM_HELP 
message even though it is listed in the obj info window's  help subtable. I also tried this 
with the ea dialog and included it ml

Re: WinDlgBox

Steven Levine — 2013-04-21T00:32:03

In <003.a04a0b00152b7351.005-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org>, on 04/20/13
   at 05:56 PM, "Gregg Young" <ygk-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org> said:

Hi Gregg,


The parameter does not mattter, TTBOMK.  However, what may matter is
whether or not the dialog procedure calls WinDefDlgProc for all messages
is does not handle.  If one or more of the HM_... messages are discarded,
the help tables may not be loaded into memory correctly.

What might be worthwhile is to crank up ipspy and watch how the two kinds
of dialogs handle the HM_ messages.

Steven

WinDlgBox

Gregg Young — 2013-04-20T23:56:05

Hi

I am trying to populate the help table so you can get F1 context help everywhere. I have 
found that some dialog boxes work fine if I add them to the table and others do not. The 
only difference I can see is that the ones that fail pass a pointer to a data area in the last 
parameter ofWinDlgBox. The ones that work pass NULL. Is this the issue or am I missing 
something? Thanks

Gregg

Re: Comp.c fixes

Gregg Young — 2013-03-10T19:35:16

Hi

Sorry about that. It is all there now. Thanks

Gregg

On Sun, 10 Mar 2013 10:57:17 -0700 Steven Levine wrote:

Re: Comp.c fixes

Steven Levine — 2013-03-10T17:57:17

In <002.6818070053bd3c51.010-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org>, on 03/10/13
   at 11:05 AM, "Gregg Young" <ygk-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org> said:

Hi Gregg,


Looks like you got them all, but it also looks like you missed a commit or
two.  fm3str.h is missing IDS_SNAPSHOTFILELOADFAILED and so on.

Thanks,

Steven

Re: Comp.c fixes

Gregg Young — 2013-03-10T18:05:23

Hi

While I didn't have an exact backup. I had merged our changes keeping mostly mine. The 
result appears to work, including the confirm action option.  You can now reapply any 
changes I should have kept. Thanks

Gregg

Re: Comp.c fixes

Steven Levine — 2013-03-10T06:38:56

In <002.00710200dd033c51.004-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org>, on 03/09/13
   at 08:54 PM, "Gregg Young" <ygk-r9/a4iiAUwJeoWH0uzbU5w< at >public.gmane.org> said:

Hi Gregg,


That's odd.  My fixes where a line here and there.  Oh, I bet I know what
happened.  I ran comp.c through my whitespace cleaner thinking that no one
else was working on the code.

Do you have a backup of your changes based on r1682?  If so, I recommend
you use svn merge to back out the r1684 changeset.  Restore comp.c from
your backup and redo the svn update.  This should update cleanly.  After
you commit your changes, I will use gnu patch to reapply and recommit the
changes I did for r1683.  This will ensure that your changes go in without
errors.

If you don't have a backup, I will review the attached comp.c

Steven

Comp.c fixes

Gregg Young — 2013-03-10T03:54:05

Hi

Our Comp.c fixes collided pretty significantly. I had wrappered the WinMessageBox2 as 
saymessage2 to get away from the header issue with open watcom. I also discovered that 
the snapshot parsing code was more messed up than your fix anticipated. The 
TimeSeparator and DateSeparators were not being honored in some cases. I have 
attempted to merge our code. Please take a look at the attached comp.c and make what 
ever change are needed to fix my "fixes". Thanks

Gregg


---------------------------------------------------------------------
To unsubscribe, e-mail: fm2-dev-unsubscribe-wlNknbtBlidAfugRpC6u6w< at >public.gmane.org
For additional commands, e-mail: fm2-dev-help-wlNknbtBlidAfugRpC6u6w< at >public.gmane.org

Re: Test

Gregg Young — 2013-01-20T18:07:18

Compare Snapshot file

Gregg Young — 2013-01-19T23:35:18

Hi

I broke this back in 2009. I have fixed it by reverting to the original file creation code. Have 
setup the parsing code to read either this format or the one that was created by the broken 
code. Unfortunately, there is no reliable way to identify the broken files on all systems. 
Works on mine but won't work reliably on systems where the default date separator is 
really /. However my default separator is / but it is read from CtryInfo.szDateSeparator as 
-. Local shows it as /. First I don't understand why CtryInfo.szDateSeparator is wrong. 
Second, I have 2 choices with the broken files what I am doing now (parsing both types) 
which runs the risk some or all of the dates in the broken version will be wrong (some 
because I do a secondary check for commas in the file sizes but I can't guarantee the first or 
any file in the list is large enough to contain one). Alternatively I can simply have them fail 
with an error message. It is probably a mote point since no one has noticed this (at least 
they h

File Manager/2 v3.21 released

2013-01-01T22:10:42

FM/2 3.21.0 has been released. The file name is fm2-3-21-0.zip

It has been uploaded to Netlabs and to Hobbes.

NETLABS
Initially uploaded to:
  <ftp://ftp.netlabs.org/incoming/fm2/fm2-3-21-0.zip>
Eventual location:
  <ftp://ftp.netlabs.org/pub/fm2/fm2-3-21-0.zip>

HOBBES
Search for it at:
  <http://hobbes.nmsu.edu/h-search.php?sh=1&button=Search&key=fm2-3-21-0.zip&dir=%2Fpub>
Initially uploaded to:
  <http://hobbes.nmsu.edu/pub/incoming/fm2-3-21-0.zip>
Eventual location:
  <http://hobbes.nmsu.edu/pub/os2/util/browser/fm2-3-21-0.zip>

3.21.0 Changes:
 * Search for duplicates now sorts results by filename. Ticket 8 (Gregg)
 * Since eCS includes unlock.exe I have added unlock file to the file (directory container context) menu
   so you can easily unlock a dll or exe file. Delete, copy and move operations open a dialog which allow
   you to unlock files as part of these operations. An icon is included if you wish to add unlock to a
   toolbar button. Ticket 11, 12, 357, 408 (Gregg)
 * Added information on FM/2

Request: Commit work for upcoming release.

2013-01-01T17:41:26

The release of FM/2 3.21.0 is imminent.

Please commit all work for this release within 24 hours.

Reply to this email if there are reasons to delay the release.

/L %* as parameters in Archive Viewer properties

Gregg Young — 2012-12-16T23:28:25

John

What is your reasoning for adding /L %* as parameters to the archive viewer object? It 
causes a failure if you associate the object with archives and the archive file's path has a 
space in it. The archive doesn't open. Without the parameters it works fine. We should 
either remove the parameters or document why they are there and the association issue. I 
can work around it by creating a second object or by associating directly to av2.exe. 
Thanks.

Gregg

Test

Gregg Young — 2012-11-11T18:35:54

Please ignore

Readonly/locked file handling

Gregg Young — 2012-07-04T20:41:29

Hi

FM/2 is schizophrenic in its handling of readonly files. For delete it simply turns off the 
readonly attribute and deletes it but for copy and move it gives an error if the target is 
readonly. I have added an optional (settings notebook checkbox default on) readonly 
warning.   I used the same code to fix ticket 319 (copy and move fails with an error on 
readonly targets) which if the warning is off changes FM/2's behavior by silently 
overwriting readonly files. The warning allows you to skip the readonly files for any of the 3 
operations. I have not implement a check for readonly files prior to the copy/move 
operation as suggested by Steven in Ticket 319 because it could be very IO intensive for 
large operations and probably at a very low yield. For copy and move the readonly warning 
can be overidden for a given operation from the file exists dialog. This same code also 
allows for unlocking locked files if unlock.exe is in the PATH.  What are your thoughts on 
these changes? 

Thanks

Gregg

Readonly/locked file handling

Gregg Young — 2012-07-04T20:41:29

Hi

FM/2 is schizophrenic in its handling of readonly files. For delete it simply turns off the 
readonly attribute and deletes it but for copy and move it gives an error if the target is 
readonly. I have added an optional (settings notebook checkbox default on) readonly 
warning.   I used the same code to fix ticket 319 (copy and move fails with an error on 
readonly targets) which if the warning is off changes FM/2's behavior by silently 
overwriting readonly files. The warning allows you to skip the readonly files for any of the 3 
operations. I have not implement a check for readonly files prior to the copy/move 
operation as suggested by Steven in Ticket 319 because it could be very IO intensive for 
large operations and probably at a very low yield. For copy and move the readonly warning 
can be overidden for a given operation from the file exists dialog. This same code also 
allows for unlocking locked files if unlock.exe is in the PATH.  What are your thoughts on 
these changes? 

Thanks

Gregg

File Manager/2 v3.20 released

2012-01-08T22:25:43

FM/2 3.20.0 has been released. The file name is fm2-3-20-0.zip

It has been uploaded to Netlabs and to Hobbes.

NETLABS
Initially uploaded to:
  <ftp://ftp.netlabs.org/incoming/fm2-3-20-0.zip>
Eventual location:
  <ftp://ftp.netlabs.org/pub/fm2/fm2-3-20-0.zip>

HOBBES
Search for it at:
  <http://hobbes.nmsu.edu/h-search.php?sh=1&button=Search&key=fm2-3-20-0.zip&dir=%2Fpub>
Initially uploaded to:
  <http://hobbes.nmsu.edu/pub/incoming/fm2-3-20-0.zip>
Eventual location:
  <http://hobbes.nmsu.edu/pub/os2/util/browser/fm2-3-20-0.zip>

3.20.0 Changes:
 * Identified mmioIdentifyFile's failure to correctly identify some files as the root cause of
   a trap in GBM.DLL. ShowMultiMedia now only checks files with known multimedia extensions.
   This will minimize but not complete prevent the problem. Ticket 402 (Gregg)
 * Add suggested drive flags for use with Netdrive drives to help file. Ticket 171 (Gregg)
 * Clarify ARCHIVER.BB2 date types and add a new one to fix displaying of .tar.gz files for Tar 1.15 and higher.