gmane.network.ryu.devel

Re: [PATCH 4/7] import msgpack into ryu/contrib

Isaku Yamahata — 2013-05-24T01:28:39

No objection from me.

[PATCH] Ethernet padding handling and minor OF1.3 fixes

Shaun Crampton — 2013-05-23T18:32:12

* Fix handling of ethernet padding (add on serialize, remove on
deserialize).
* Update UTs to expect ethernet padding.
* Support for packet suffixes as well as headers.
* Make Packet a sequence type.
* Various typo fixes in OF1.3 parser.
* Add missing imports to OF1.3 parser.
---
 ryu/lib/packet/__init__.py             |    2 ++
 ryu/lib/packet/ethernet.py             |    9 ++++++--
 ryu/lib/packet/icmp.py                 |    1 -
 ryu/lib/packet/packet.py               |   37
++++++++++++++++++++++++++++----
 ryu/ofproto/ofproto_v1_3.py            |    3 ++-
 ryu/ofproto/ofproto_v1_3_parser.py     |   12 +++++------
 ryu/tests/unit/packet/test_ethernet.py |    6 ++++--
 ryu/tests/unit/packet/test_lldp.py     |    3 ++-
 ryu/tests/unit/packet/test_packet.py   |   37
+++++++++++++++++++-------------
 9 files changed, 78 insertions(+), 32 deletions(-)

diff --git a/ryu/lib/packet/__init__.py b/ryu/lib/packet/__init__.py
index e69de29..cfd0f3d 100644
--- a/ryu/lib/packet/__init__.py
+++ b/ryu/lib/packet/__init

Re: [PATCH 4/7] import msgpack into ryu/contrib

FUJITA Tomonori — 2013-05-23T11:07:48

On Thu, 23 May 2013 15:30:39 +0900
Isaku Yamahata <yamahata-jCdQPDEk3idL9jVzuh4AOg< at >public.gmane.org> wrote:


Then I'm inclined not to put this into contrib. Objections?

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: Ryu on OpenFlow

FUJITA Tomonori — 2013-05-23T11:02:55

On Thu, 23 May 2013 14:58:12 +0700
Agung Ridwan SN <agung.ridwan-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org> wrote:


OF1.0 + nicira extensions gives multi-table support.

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Ryu on OpenFlow

Agung Ridwan SN — 2013-05-23T07:58:12

Hi,

I want to ask about output dump-flow from OpenStack+Ryu. I saw multi-table
exist in dump-flow. But OpenFlow header (from capturing packet) said :
OFP_VERSION 1.0. AFAIK, multi-tables are specified in OF spec v1.1? I
searched from ryu directory, nothing of "ofproto_v1_1" but v1_0, v1_2, and
v1_3 are exist. How come this happen? Thanks

Re: [PATCH 4/7] import msgpack into ryu/contrib

Isaku Yamahata — 2013-05-23T06:30:39

If the next grizzly/stable is released, no, we don't.
It's about two weeks.

https://wiki.openstack.org/wiki/StableBranchRelease

Re: [PATCH 4/7] import msgpack into ryu/contrib

FUJITA Tomonori — 2013-05-22T23:53:09

On Fri, 17 May 2013 11:52:07 +0900
YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg< at >public.gmane.org> wrote:


Can you describe why we need this in a commit message? However, a fix
for this issue was merged into grizzly/stable and master. If so, if we
ignore folsom, we don't need to have this in contrib directory, right?

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: [PATCH 0/2] RFC: of-wire json representation

FUJITA Tomonori — 2013-05-22T23:47:40

On Fri, 17 May 2013 13:55:01 +0900
YAMAMOTO Takashi <yamamoto-jCdQPDEk3idL9jVzuh4AOg< at >public.gmane.org> wrote:


I think that we can handle binary data as blob. However, can we
separating 'printing binary with base64' feature? The main reason why
we need this is RPC API. Our current choice of RPC encoding can handle
binary data without base64.


Having a special rule for converting "hoge_" to 'hoge' is enough?

 "port_no": 4}}}, "n_buffers": 256}}

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: [PATCH] test_parser_v10: remove tests for str

FUJITA Tomonori — 2013-05-22T22:54:23

On Tue, 21 May 2013 13:13:58 +0900
YAMADA Hideki <yamada.hideki-lJ4LtgMnyE9L9jVzuh4AOg< at >public.gmane.org> wrote:


Oops, how I missed this regression...



I've applied this. If you think it's worth having this tests, please
send a patch with a clever parser.

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: [PATCH] docs: fix ryu module import

FUJITA Tomonori — 2013-05-22T22:54:23

On Sat, 18 May 2013 06:00:50 +0900 (JST)
FUJITA Tomonori <fujita.tomonori-Zyj7fXuS5i5L9jVzuh4AOg< at >public.gmane.org> wrote:


Applied.

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: [PATCH 1/2] lib/packet/vrrp: fix is_valid()

FUJITA Tomonori — 2013-05-22T22:54:23

On Tue, 21 May 2013 13:44:09 +0900
YAMADA Hideki <yamada.hideki-lJ4LtgMnyE9L9jVzuh4AOg< at >public.gmane.org> wrote:


Applied both, thanks.

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: Sending OFPT13_SET_ASYNC message..

Isaku Yamahata — 2013-05-22T16:11:59

It's fixed by 97c1aad368215fbd8825048fe9db1cd71bbeebd0
Please try master repo.


On Wed, May 22, 2013 at 07:39:57PM +0530, nitish nagesh wrote:

Sending OFPT13_SET_ASYNC message..

nitish nagesh — 2013-05-22T14:09:57

Hello,

   I am trying to write an Ryu app to send the OFPT13_SET_ASYNC message but
i am unable to figure out how to fill the various masks given in the
ofp13_async_config structure into the OFPSetAsync class (as the class
initializer doesnt take any argument other than the datapath id). Can you
please give me some hints or point to any existing examples which do this?

Thank you,
Nitish
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may_______________________________________________
Ryu-devel mailing list
Ryu-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ryu-devel

How to profile an app?

Can Zhang — 2013-05-22T03:57:30

Hello,

Now I want to profile my ryu app and plan to use cProfile. So I'd like to know where should I put cProfile.run() calls?
And how do you do that in ryu?


Best regards,
Can Zhang





------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Re: [PATCH 1/2] lib/packet/vrrp: fix is_valid()

Isaku Yamahata — 2013-05-21T10:26:20

Oops. The both patches looks good.

On Tue, May 21, 2013 at 01:44:09PM +0900, YAMADA Hideki wrote:

Re: [PATCH] test_parser_v10: remove tests for str

Isaku Yamahata — 2013-05-21T06:23:52

Although I'm not sure how much make sense to keep the test,
it will make test pass to make string parser a bit smarter.

From
        str_ = str_.rsplit()
to something like
[re.sub('\).*', '', r) for r in re.split('[(,= ]', str(res))]

thanks

On Tue, May 21, 2013 at 01:13:58PM +0900, YAMADA Hideki wrote:

[PATCH 2/2] tests/unit/packet/test_vrrp: add tests foris_valid()

YAMADA Hideki — 2013-05-21T04:44:10

Signed-off-by: YAMADA Hideki <yamada.hideki-lJ4LtgMnyE9L9jVzuh4AOg< at >public.gmane.org>
---
 ryu/tests/unit/packet/test_vrrp.py |   92 +++++++++++++++++++++++++++++++++++-
 1 files changed, 91 insertions(+), 1 deletions(-)

diff --git a/ryu/tests/unit/packet/test_vrrp.py b/ryu/tests/unit/packet/test_vrrp.py
index 32dbdb4..282c9fa 100644
--- a/ryu/tests/unit/packet/test_vrrp.py
+++ b/ryu/tests/unit/packet/test_vrrp.py
< at >< at > -21,7 +21,7 < at >< at > import logging
 import struct
 import netaddr
 
-from nose.tools import eq_
+from nose.tools import eq_, ok_
 from nose.tools import raises
 
 from ryu.ofproto import inet
< at >< at > -137,6 +137,51 < at >< at > class Test_vrrpv2(unittest.TestCase):
         p1.serialize()
         eq_(p0.data, p1.data)
 
+    def _test_is_valid(self, type_=None, vrid=None, priority=None,
+                       max_adver_int=None):
+        if type_ is None:
+            type_ = self.type_
+        if vrid is None:
+            vrid = self.vrid
+        if priority is None:
+            priority = self.priority
+

[PATCH 1/2] lib/packet/vrrp: fix is_valid()

YAMADA Hideki — 2013-05-21T04:44:09

Signed-off-by: YAMADA Hideki <yamada.hideki-lJ4LtgMnyE9L9jVzuh4AOg< at >public.gmane.org>
---
 ryu/lib/packet/vrrp.py |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/ryu/lib/packet/vrrp.py b/ryu/lib/packet/vrrp.py
index 7c50fed..8b6140a 100644
--- a/ryu/lib/packet/vrrp.py
+++ b/ryu/lib/packet/vrrp.py
< at >< at > -395,7 +395,7 < at >< at > class vrrp(packet_base.PacketBase):
 
     def is_valid(self):
         cls = self._VRRP_VERSIONS.get(self.version, None)
-        if None:
+        if cls is None:
             return False
         return cls.is_valid(self)
 
< at >< at > -499,8 +499,8 < at >< at > class vrrpv2(vrrp):
         return (self.version == VRRP_VERSION_V2 and
                 self.type == VRRP_TYPE_ADVERTISEMENT and
                 VRRP_VRID_MIN <= self.vrid and self.vrid <= VRRP_VRID_MAX and
-                VRRP_PRIORITY_MIN <= self.vrid and
-                self.vrid <= VRRP_PRIORITY_MAX and
+                VRRP_PRIORITY_MIN <= self.priority and
+                self.priority <= VRRP_PRIORITY_MAX a

[PATCH] test_parser_v10: remove tests for str

YAMADA Hideki — 2013-05-21T04:13:58

Following errors occur at current master
(commit 21692141dc7e8be2d44338ce4eff5af584e4ff8f)

======================================================================
ERROR: test_parser (ryu.tests.unit.ofproto.test_parser_v10.TestOFPFlowRemoved)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/hideki/ryu/ryu/tests/unit/ofproto/test_parser_v10.py", line 4080, in test_parser
    eq_(str(cookie['val']), check['cookie'])
KeyError: 'cookie'

======================================================================
ERROR: test_parser (ryu.tests.unit.ofproto.test_parser_v10.TestOFPPacketIn)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/hideki/ryu/ryu/tests/unit/ofproto/test_parser_v10.py", line 3782, in test_parser
    ok_(self._test_parser())
  File "/home/hideki/ryu/ryu/tests/unit/ofproto/test_parser_v10.py", line 3774, in _test_parser
    eq_(str(buffer_id['val']), check['buff

Re: question about ryu

Isaku Yamahata — 2013-05-20T07:28:21

Simple isolation doesn't support live-migration.
In case of Simple vlan case, it up to OVS mac learning and
guest VM seinding GARP.
In case of GRE tunneling case, ryu/app/gre_tunnel.GRETunnel._vm_port_add.
grep it with "live-migration"



By detecting OVS port with same quantum port uuid and mac address which
are stored in ovsdb as external-id.
When live-migration, there are two ovs ports with same quantum port uuid
and mac address.

thanks,

Re: question about ryu

hsin han Liu — 2013-05-20T07:10:57

thanks a lot for the information!

Also,can i ask which part of the code is supporting live migration as the
document says?

https://github.com/osrg/ryu/wiki/Details-of-Ryu-in-cooperation-with-OpenStack-Grizzly

how does ryu know vm is about to migrate?


Thanks,

Allen



2013/5/20 Isaku Yamahata <yamahata-jCdQPDEk3idL9jVzuh4AOg< at >public.gmane.org>

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d_______________________________________________
Ryu-devel mailing list
Ryu-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ryu-devel

gmane.network.ryu.devel

Re: [PATCH 4/7] import msgpack into ryu/contrib

[PATCH] Ethernet padding handling and minor OF1.3 fixes

Re: [PATCH 4/7] import msgpack into ryu/contrib

Re: Ryu on OpenFlow

Ryu on OpenFlow

Re: [PATCH 4/7] import msgpack into ryu/contrib

Re: [PATCH 4/7] import msgpack into ryu/contrib

Re: [PATCH 0/2] RFC: of-wire json representation

Re: [PATCH] test_parser_v10: remove tests for __str__

Re: [PATCH] docs: fix ryu module import

Re: [PATCH 1/2] lib/packet/vrrp: fix is_valid()

Re: Sending OFPT13_SET_ASYNC message..

Sending OFPT13_SET_ASYNC message..

How to profile an app?

Re: [PATCH 1/2] lib/packet/vrrp: fix is_valid()

Re: [PATCH] test_parser_v10: remove tests for __str__

[PATCH 2/2] tests/unit/packet/test_vrrp: add tests foris_valid()

[PATCH 1/2] lib/packet/vrrp: fix is_valid()

[PATCH] test_parser_v10: remove tests for __str__

Re: question about ryu

Re: question about ryu

Re: [PATCH] test_parser_v10: remove tests for str

Re: [PATCH] test_parser_v10: remove tests for str

[PATCH] test_parser_v10: remove tests for str