gmane.network.jabber.psi.devel

Re: [Patches] [Patch] Spell checker doesn't handleabbreviated words

Michail Pishchagin — 2008-07-21T23:03:39

On 17.07.2008, at 13:38, Norman Rasmussen wrote: Very likely, I'd prefer to get a unit-test first in order to make sure it works. In case of ^foo$ regexp it should work the same, but most of the time I'm happy with partial matches too and got used to this way of doing things. I don't hold hard feelings for indexOf() as long as everything works alright. -Michail

Re: User icon not updated

Frederik Schwarzer — 2008-07-20T01:41:47

Sorry for never reporting back. I haven't seen that for ages (using svn versions), so I suppose it is fixed. Regards

Re: Group list is not sorted in Add User dialog

Kevin Smith — 2008-07-19T21:36:40

On Thu, Aug 2, 2007 at 10:30 AM, Norman Rasmussen public.gmane.org> wrote: I just had a look to patch this, and it looks like someone beat me to it :) (yes, I'm trying to clear out old Psi tasks) /K

Re: User icon not updated

Kevin Smith — 2008-07-19T21:32:27

Thread necromancy: I can't remember ever seeing this - hopefully this isn't an issue, or isn't an issue any more? /K

Re: Does common.cpp leak memory?

Marcus Dübois — 2008-07-18T10:28:30

Found some more places that may need to be patched, attaching it below. Looking forward to dig into the rest of the source and hopefully give something back to the community =) Kind regards Marcus

Re: Does common.cpp leak memory?

Marcus Dübois — 2008-07-18T08:31:09

Is there something I can do to help you with? I have alot of experience with testing software and find it quite entertaining. Do you have some kind of roadmap or some previous tests that I can start from? Seems like a good project for me the help out with, given that I love Psi and where it's heading. Kind regards Marcus

Re: Does common.cpp leak memory?

Remko Tronçon — 2008-07-18T08:23:14

I wouldn't be surprised if you would find other leaks. It's been a while since we valgrinded, and even when we do, we don't test all fucntionality (we hardly have any tests atm). cheers, Remko

Re: Does common.cpp leak memory?

Marcus Dübois — 2008-07-18T08:00:41

Thanks Remko! I'll look through the rest of the code base as well just in case =) But probably it was just a lucky shot. Marcus On 18 jul 2008, at 09.44, Remko Tronçon wrote:

Re: Does common.cpp leak memory?

Remko Tronçon — 2008-07-18T07:44:36

You're right. Common mistake to use delete instead of delete[]. Thanks for the patch. Remko

Does common.cpp leak memory?

Marcus Dübois — 2008-07-18T07:40:58

Hi, I've got a question about the method fileCopy in the file common.cpp. To me it seems like it doesn't free/delete the 'dat' pointer correctly and I suspect a memory leak. I have attached a small patch to this mail and would love to hear your thoughts about it. Maybe I'm wrong and if so please enlight me! Kind regards Marcus

Re: [Patches] [Patch] Spell checker doesn't handleabbreviated words

Norman Rasmussen — 2008-07-17T09:38:50

Re: MUC paste nick by click

Michail Pishchagin — 2008-07-16T22:38:23

It would be cool to have these patches readily available in a http://github.com/mblsha/psi/tree/master fork ;-) The patch (which is currently located at http://bombus-im.org/zet/psi/patches/16_psi-muc-nickclick-chat.diff) is mostly ok, but I'd rewritten large portions before inclusion to the repository. Thanks! -Michail

Re: [Patches] [Patch] Spell checker doesn't handleabbreviated words

Michail Pishchagin — 2008-07-16T22:30:20

On 14.07.2008, at 13:34, Norman Rasmussen wrote: Ahhar, we need to put a unit-test around our highlighter. This solution works for me: rehighlightTimer_->stop(); needRehighlight_ = previousBlockState() != -1; int cursorPosition = cursorPositionInCurrentBlock(); // Underline QTextCharFormat tcf; tcf.setUnderlineColor(QBrush(QColor(255,0,0))); tcf.setUnderlineStyle(QTextCharFormat::SpellCheckUnderline); // Match words (minimally) static QRegExp expression("\\b\\w+\\b"); static QRegExp number("^\\d+$"); // Iterate through all words int index = text.indexOf(expression); while (index >= 0) { int length = expression.matchedLength(); if (expression.cap().indexOf(number) >= 0) { // skipping numbers } else if (cursorPosition >= index && (cursorPosition <= index + length)) { needRehighlight_ = true; } else { if (!SpellChecker::instance()->isCorrect(expression.cap())) setFormat(index, length, tcf); } index = text.indexOf(expression, index + length); } setCurrentBl

Re: MUC paste nick by click

Maciek Niedzielski — 2008-07-14T10:34:10

Wow, nice one. I wish I noticed this earlier! Just one thing, we should probably use something like x-psi-addnick:xyz instead of addnick:xyz. But that's not a problem.

Re: MUC paste nick by click

zet — 2008-07-14T10:22:09

Здравствуйте, Michail. Вы писали 14 июля 2008 г., 2:48:16: http://bombus-im.org/zet/psi/patches/12_psi-muc-nickclick-chat.diff

Re: [Patches] [Patch] Spell checker doesn't handleabbreviated words

Norman Rasmussen — 2008-07-14T09:34:31

Re: MUC paste nick by click

Michail Pishchagin — 2008-07-13T22:48:16

On 17.06.2008, at 1:20, Kevin Smith wrote: Hm, the one I have inserts a nick when a contact is middle-clicked in room roster. Inserting a nick when clicking on a nick in ChatView would be very nice too. Where I could find the patch? -Michail

Re: [Patches] [Patch] Spell checker doesn't handleabbreviated words

Michail Pishchagin — 2008-07-13T21:32:51

Could you please give some examples? Seems to be true with Mac OS X's spell checker too. One other problem that you approach doesn't fix is that aspell erroneously highlights numbers. And there's one more problem as well: we shouldn't highlight words on top of which the cursor is located. I have a private prototype patch that fixes two problems I've specified, and I wanted to clean it up for inclusion in 0.13. -Michail

Re: [patch] for Plugins

Piotr Budny — 2008-07-13T11:19:57

Dnia sobota, 12 lipca 2008, C. H. napisał: Great! Would be nice having option to hide this button. [...] Two things I've noticed: 1. can't close window with close [X] on decorations (Esc works fine) 2. too long status messages makes popup notifications very long & ugly Regards, vip; _______________________________________________ Psi-Devel mailing list Psi-Devel< at >lists.affinix.com http://lists.affinix.com/listinfo.cgi/psi-devel-affinix.com

Re: Psi 0.12 RC2: toolbar problems

2008-07-12T22:55:28

Re: [patch] for Plugins

Maciek Niedzielski — 2008-07-12T18:36:45

yeah, thanks for everything :) It's too late for 0.12. Plus these would have to be submitted again, one feature/change per file - otherwise it's hard to do anything with it.