gmane.network.dns.c-ares

RELEASE: c-ares 1.10.0

Daniel Stenberg — 2013-05-12T13:55:21

Hi friends!

Almost eleven months since the previous release, I'm glad to announce a brand 
new c-ares tarball uploaded to the site: http://c-ares.haxx.se/

c-ares version 1.10.0

Changes:

  o Added ares_create_query(), to be used instead of ares_mkquery()
  o ares_inet_ntop() and ares_inet_pton() are now recognized c-ares functions

Bug fixes:

  o include the ares_parse_soa_reply.* files in the tarball
  o read_udp_packets: bail out loop on bad sockets
  o get_DNS_AdaptersAddresses: fix IPv6 parsing
  o adig: perror() doesn't work for socket errors on windows
  o ares_parse_aaaa_reply: fix memory leak
  o setup_once.h: HP-UX <sys/socket.h> issue workaround
  o configure: several fixes
  o config-dos.h: define strerror() to strerror_s_() for High-C
  o config-dos.h: define HAVE_CLOSE_S for MSDOS/Watt-32
  o ares_build.h.dist: enhance non-configure GCC ABI detection logic
  o ares.h: stricter CARES_EXTERN linkage decorations logic
  o ares_cancel(): cancel requests safely
  o protocol parsing: check input d

Re: ares_set_servers_csv and compressed IPv6 string

Steinar H. Gunderson — 2013-05-09T08:57:39

2013/5/9 Timothy J Fontaine <tjfontaine-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>:

Without knowing the c-ares internals here, the normal way of
specifying IPv6 address + port is with brackets, like this:
[2001:4860:4860::8888]:53. So I'd guess this is a bug.

/* Steinar */

ares_set_servers_csv and compressed IPv6 string

Timothy J Fontaine — 2013-05-08T22:27:12

When passing in a compressed IPv6 string like "2001:4860:4860::8888" to
ares_set_servers_csv everything to the right of the first ":" in "::" is
stripped and interpreted as part of the port for the entry.

Is the intended behavior to require an IPv6 address in uncompressed
notation, or is this merely a bug?

On a tangent, is there any interest in actually supporting specifying the
port to be used? Conceptually I like the idea, but in practice I can't
imagine many people using it.

Re: Fixing a few errors and warning detected by coverity

Jaap Keuter — 2013-05-07T06:08:54

Now these _are_ interesting changes.

Thanks,
Jaap

Re: DNS servers on windows

Patrick Valsecchi — 2013-05-03T11:51:08

I guess he means IN6_IS_ADDR_SITELOCAL, yes. I didn't know of this macro.

But I have a few comments about that:
  - the macro checks only the first 10 bits of the IPv6 address and I 
check the first 64 bits.
  - since this range has been deprecated, I guess the macro will go away...
  - the macro doesn't work with sockaddr_in6 as defined in ares_ipv6. So 
I don't think it will work on every platforms...

Re: DNS servers on windows

Steinar H. Gunderson — 2013-05-03T11:35:21

2013/5/3 Gisle Vanem <gvanem-gyXR7Lt7FVk/G1V5fR+Y7Q< at >public.gmane.org>:

You mean SITELOCAL, not LINKLOCAL, right?

/* Steinar */

Re: DNS servers on windows

Gisle Vanem — 2013-05-03T11:29:49


From your patch:

+static bool is_default_server(const struct ares_addr* addr)
+{
+  return addr->family == AF_INET6 &&
+         addr->addr.addr6._S6_un._S6_u8[0] == 0xFE &&
+         addr->addr.addr6._S6_un._S6_u8[1] == 0xC0 &&
+         addr->addr.addr6._S6_un._S6_u8[2] == 0x00 &&
+         addr->addr.addr6._S6_un._S6_u8[3] == 0x00 &&
+         addr->addr.addr6._S6_un._S6_u8[4] == 0x00 &&
+         addr->addr.addr6._S6_un._S6_u8[5] == 0x00 &&
+         addr->addr.addr6._S6_un._S6_u8[6] == 0xFF &&
+         addr->addr.addr6._S6_un._S6_u8[7] == 0xFF;
+}

Could this be simplified as (untested):

 return addr->family == AF_INET6 &&
           IN6_IS_ADDR_LINKLOCAL(&addr->addrV6);

Referring what Bert Belder said in this thread:

  Windows implements a draft RFC from 2001
  (http://tools.ietf.org/id/draft-ietf-ipngwg-dns-discovery-03.txt) that
  suggests that DNS resolvers try a couple of fixed "site-local" IPv6    << !!
  addresses (fec0:0:0:ffff::1, fec0:0:0:ffff::2 and fec0:0:0:ffff::3), which
  would all

Re: Fixing a few errors and warning detected by coverity

Patrick Valsecchi — 2013-05-03T07:33:47

Because it's a first step to make c-ares compilable in C++ (I know you 
don't care) and it doesn't hurt.

But since I don't want to start a holy war ;-), I've put a new patch in 
attachment and we'll try to teach Coverity to ignore those.

Re: Fixing a few errors and warning detected by coverity

Kamil Dudka — 2013-05-03T06:58:39

The manual type-casting approach feels useless to me.  It makes the code more 
chatty without providing any real benefit.  What would probably make sense is 
a macro like this (slightly inspired by [1]):

#define NEW(T) (T *) malloc(sizeof(T))

... which ensures you allocate sufficient space to store an object of type T.

Kamil

[1] http://www.akkadia.org/drepper/defprogramming.pdf

Re: DNS servers on windows

Patrick Valsecchi — 2013-05-03T06:29:20

Never used git so far and it's quite different from Mercurial, SVN, CVS 
or RC ;-)

Is the attached stuff what you are expecting?

Re: Fixing a few errors and warning detected by coverity

Jaap Keuter — 2013-05-03T06:11:50

Hi,

It's more a matter of taste, allowing implicit casts or not. Coverity can be
tweaked in many many ways to fit your needs.

Since there are so many, it would be beneficial to have a Coverity run without
this checker rule. Then the other changes (for 'real' problems) may stand out
better.

Thanks,
Jaap

Re: Cosmetic bugs in http://c-ares.haxx.se/ares_parse_a_reply.html and http://c-ares.haxx.se/ares_parse_aaaa_reply.html

Daniel Stenberg — 2013-05-02T21:13:00


Thanks! It took me forever but I've now pushed a fix for these mistakes.

Re: DNS servers on windows

Daniel Stenberg — 2013-05-02T20:55:10


Can you please provide a full patch, including a sensible commit message that 
explains the change?

It is easily done if you do a full local commit and then generate the patch 
for us with "git format-patch"

Re: Fixing a few errors and warning detected by coverity

Daniel Stenberg — 2013-05-02T20:51:34


Thanks!

There's a large amount of added typecasts for malloc() and a few other void 
pointers in that patch. Why do we need them?

Re: Patch to build current head (3f0ec47) on msvc11

Daniel Stenberg — 2013-05-02T20:48:02


Thanks, merged and pushed!

Fixing a few errors and warning detected by coverity

Patrick Valsecchi — 2013-05-02T06:25:35

Hi,

A colleague ran Coverity (a static analysis tool) against c-ares and 
fixed a few reported errors and warnings.

Please have a look at the attached patch.

Thanks.

Re: DNS servers on windows

Alex Loukissas — 2013-05-02T06:23:31

This patch can be applied as-is in the said commit hash. One of the
committers in the project can push a commit with these changes.


On Wed, May 1, 2013 at 11:12 PM, Patrick Valsecchi <pvalsecc-FYB4Gu1CFyUAvxtiuMwx3w< at >public.gmane.org>wrote:

Re: DNS servers on windows

Patrick Valsecchi — 2013-05-02T06:12:52

On 04/23/2013 11:17 AM, Patrick Valsecchi wrote:

Where do we stand on this one? Do I have to change something in this 
proposed patch?

Thanks.

Patch to build current head (3f0ec47) on msvc11

Alex Loukissas — 2013-05-01T17:44:13

Hi folks,

I'm a newcomer in the c-ares project and wanted to build it on my msvc11
(Visual C++ 2012), but I was failing to do so using the instructions in
https://github.com/bagder/c-ares/blob/master/Makefile.msvc

Since I figured out the issue, I thought I'd share the patch with you. Feel
free to use it.

Thanks
Alex

Re: Proposal for unittests

Guenter — 2013-04-29T16:45:50

Hi Daniel,
Am 28.04.2013 23:50, schrieb Daniel Stenberg:
BTW libmetalink uses it too IIRC, but I've not yet tested with it ...

Gün.

Re: Proposal for unittests

Patrick Valsecchi — 2013-04-29T07:03:00

Yes it looks prettier and has the advantage of being able to run a 
single test out of the box. OK, I'll switch to this one if it's OK for 
the others.