gmane.linux.x25

testing new majordomo settings, test 2

2010-01-31T23:04:26

thanks, postmaster
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

testing new majordomo settings

2010-01-31T22:57:52

test
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org

DEARMADAM BUSINESS PROPOSAL PLEASE VIEW ATTACHED FILE FOR DETAILS‏.doc

LUIS ANDERSON — 2010-01-14T12:27:07

(unknown)

info — 2010-01-08T14:41:51

You have won £1,500,000.00,.Confirm this receipt by replying to the processing officer harry1< at >gala.net :send your details:FullName,Address,Tel,Occupation,etc
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(unknown)

info — 2010-01-08T14:24:00

You have won £1,500,000.00,.Confirm this receipt by replying to the processing officer harry1< at >gala.net :send your details:FullName,Address,Tel,Occupation,etc
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Request for confirmation

Webmaster — 2010-01-04T22:20:37

Sorry to bother you: we are cleaning up our database and it appears that
you have previously signed up to eBuppies.com mailinglists and not
confirmed your subscription.We would like to give you the opportunity to
re-confirm your subscription. The instructions on how to confirm are below.
 

  Almost welcome to our newsletter(s) ...

  Someone, hopefully you, has subscribed your email address to the
following newsletters:
  
  

  If this is correct, please click the following link to confirm your
subscription.
  Without this confirmation, you will not receive any newsletters.
  
 
http://ebuppies.com/emailserv/?p=confirm&uid=40c7fd8d5ede10b2b6cd9e72558f556f
  
  If this is not correct, you do not need to do anything, simply delete
this message.

  Thank you
  
    


--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

you have won 801,613.00 euro..

IL — 2009-12-27T15:18:48

Hello,
you have won 801,613.00 euro from the Irish Christmas lottery. Call Monte
Fred now on phone: +447031953564 and send your
name,address,age,occupation,nationality,phone number etc to
fredmonte505< at >gmail.com so that he can help you make to arrangement
transfer your 801,613.00 euro to your bank account in your country.

Deniss Powell
P.R.O.
Irish Lottry

--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] X25: Move SYSCTL ifdefs into header

Eric W. Biederman — 2009-11-27T22:34:44


This looks like a reasonable change and it doesn't conflict
with my pending changes in the sysctl tree.

Acked-by: "Eric W. Biederman" <ebiederm< at >xmission.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] X25: Move SYSCTL ifdefs into header

andrew hendry — 2009-11-25T01:15:26

Moves the CONFIG_SYSCTL ifdefs in x25_init into header.

Signed-off-by: Andrew Hendry <andrew.hendry< at >gmail.com>

diff -uprN -X a/Documentation/dontdiff a/include/net/x25.h b/include/net/x25.h
--- a/include/net/x25.h2009-11-10 11:32:31.000000000 +1100
+++ b/include/net/x25.h2009-11-25 09:05:21.000000000 +1100
< at >< at > -287,8 +287,14 < at >< at > extern unsigned long x25_display_timer(s
 extern void x25_check_rbuf(struct sock *);

 /* sysctl_net_x25.c */
+#ifdef CONFIG_SYSCTL
 extern void x25_register_sysctl(void);
 extern void x25_unregister_sysctl(void);
+#else
+static inline void x25_register_sysctl(void) {};
+static inline void x25_unregister_sysctl(void) {};
+#endif /* CONFIG_SYSCTL */
+
 struct x25_skb_cb {
 unsigned flags;
 };
diff -uprN -X a/Documentation/dontdiff a/net/x25/af_x25.c b/net/x25/af_x25.c
--- a/net/x25/af_x25.c2009-11-17 10:30:18.000000000 +1100
+++ b/net/x25/af_x25.c2009-11-25 09:04:25.000000000 +1100
< at >< at > -1667,9 +1667,7 < at >< at > static int __init x25_init(void)

 printk(KERN_INFO "X.25 for Linux Version

Re: [PATCH] X25: Enable setting of cause and diagnostic fields

David Miller — 2009-11-19T07:30:51

From: andrew hendry <andrew.hendry< at >gmail.com>
Date: Thu, 19 Nov 2009 10:24:01 +1100


Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] X25: Enable setting of cause and diagnostic fields

andrew hendry — 2009-11-18T23:24:01

Thanks, will make sure to check 32/64 in the future.

Adds SIOCX25SCAUSEDIAG, allowing X.25 programs to set the cause and
diagnostic fields.
Normally used to indicate status upon closing connections.

Signed-off-by: Andrew Hendry <andrew.hendry< at >gmail.com>

diff -uprN -X a/Documentation/dontdiff a/include/linux/x25.h
b/include/linux/x25.h
--- a/include/linux/x25.h2009-11-16 13:44:41.138892908 +1100
+++ b/include/linux/x25.h2009-11-11 16:05:06.625958557 +1100
< at >< at > -25,6 +25,7 < at >< at >
 #define SIOCX25SENDCALLACCPT    (SIOCPROTOPRIVATE + 9)
 #define SIOCX25GDTEFACILITIES (SIOCPROTOPRIVATE + 10)
 #define SIOCX25SDTEFACILITIES (SIOCPROTOPRIVATE + 11)
+#define SIOCX25SCAUSEDIAG(SIOCPROTOPRIVATE + 12)

 /*
  *Values for {get,set}sockopt.
diff -uprN -X a/Documentation/dontdiff a/net/x25/af_x25.c b/net/x25/af_x25.c
--- a/net/x25/af_x25.c2009-11-16 13:44:41.745816123 +1100
+++ b/net/x25/af_x25.c2009-11-16 13:49:51.277655328 +1100
< at >< at > -1430,6 +1430,17 < at >< at > static int x25_ioctl(struct socket *sock
 break;
 }

+case SI

Re: [PATCH] X25: Enable setting of cause and diagnostic fields

David Miller — 2009-11-14T04:32:48

From: andrew hendry <andrew.hendry< at >gmail.com>
Date: Thu, 12 Nov 2009 11:13:27 +1100


This change is incomplete.

You need to add handling to compat_x25_ioctl().
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] net/x25: push BKL usage into x25_proto

andrew hendry — 2009-11-12T05:18:42

For anyone who looking at the next step, be aware there is an existing
bug in this area.

With single threaded x.25 processes and light X.25 traffic over time
'dead sockets' hang around. They sometimes have negative values in the
inode field and all the timers are timed out. When they exist rmmod
x25 will crash the system, even though lsmod shows 0 usage if all x.25
programs are shutdown.

# cat /proc/net/x25/socket
dest_addr  src_addr   dev   lci st vs vr va   t  t2 t21 t22 t23 Snd-Q
Rcv-Q inode
0505xxxxxxxxx 0505xxxxxxxxx x25tap0 000  0  0  0  0   0   3 200 180
180     0     0 6198164303842135440
0505xxxxxxxxx 0505xxxxxxxxx x25tap0 000  0  0  0  0   0   3 200 180
180     0     0 111073138
They can be reproduced faster with threaded client/server test
programs doing connect/disconnect. No time to look further at the
moment, but I can help test.


On Fri, Nov 6, 2009 at 1:37 AM, Arnd Bergmann <arnd< at >arndb.de> wrote:
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a messa

[PATCH] X25: Enable setting of cause and diagnostic fields

andrew hendry — 2009-11-12T00:13:27

Adds SIOCX25SCAUSEDIAG, allowing X.25 programs to set the cause and
diagnostic fields.
Normally used to indicate status upon closing connections.

Signed-off-by: Andrew Hendry <andrew.hendry< at >gmail.com>


diff -uprN -X a/Documentation/dontdiff a/include/linux/x25.h
b/include/linux/x25.h
--- a/include/linux/x25.h2009-11-11 14:03:26.659663301 +1100
+++ b/include/linux/x25.h2009-11-11 16:05:06.625958557 +1100
< at >< at > -25,6 +25,7 < at >< at >
 #define SIOCX25SENDCALLACCPT    (SIOCPROTOPRIVATE + 9)
 #define SIOCX25GDTEFACILITIES (SIOCPROTOPRIVATE + 10)
 #define SIOCX25SDTEFACILITIES (SIOCPROTOPRIVATE + 11)
+#define SIOCX25SCAUSEDIAG     (SIOCPROTOPRIVATE + 12)

 /*
  *Values for {get,set}sockopt.
diff -uprN -X a/Documentation/dontdiff a/net/x25/af_x25.c b/net/x25/af_x25.c
--- a/net/x25/af_x25.c2009-11-11 14:02:44.027061001 +1100
+++ b/net/x25/af_x25.c2009-11-11 16:22:51.374077963 +1100
< at >< at > -1430,6 +1430,17 < at >< at > static int x25_ioctl(struct socket *sock
 break;
 }

+case SIOCX25SCAUSEDIAG: {
+struct x25_causediag cause

Re: [PATCH] net: Cleanup redundant tests on unsigned

David Miller — 2009-10-29T08:40:24

From: Roel Kluin <roel.kluin< at >gmail.com>
Date: Fri, 23 Oct 2009 17:21:56 +0200


Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] net: Cleanup redundant tests on unsigned

Roel Kluin — 2009-10-23T15:21:56

If there is data, the unsigned skb->len is greater than 0.

rt.sigdigits is unsigned as well, so the test `>= 0' is
always true, the other part of the test catches wrapped
values.

Signed-off-by: Roel Kluin <roel.kluin< at >gmail.com>
---
 net/x25/x25_in.c    |    2 +-
 net/x25/x25_route.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/x25/x25_in.c b/net/x25/x25_in.c
index 7d7c3ab..96d9227 100644
--- a/net/x25/x25_in.c
+++ b/net/x25/x25_in.c
< at >< at > -114,7 +114,7 < at >< at > static int x25_state1_machine(struct sock *sk, struct sk_buff *skb, int frametyp
 /*
  *Copy any Call User Data.
  */
-if (skb->len >= 0) {
+if (skb->len > 0) {
 skb_copy_from_linear_data(skb,
       x25->calluserdata.cuddata,
       skb->len);
diff --git a/net/x25/x25_route.c b/net/x25/x25_route.c
index 2c999cc..66961ea 100644
--- a/net/x25/x25_route.c
+++ b/net/x25/x25_route.c
< at >< at > -190,7 +190,7 < at >< at > int x25_route_ioctl(unsigned int cmd, void __user *arg)
 goto out;
 
 rc = -EINVAL;
-if (rt.sig

[PATCH] x25: bit and/or confusion in x25_ioctl()?

Roel Kluin — 2009-10-07T10:59:42

Looking at commit ebc3f64b864f it appears that this was intended
and not the original, equivalent to `if (facilities.reverse & ~0x81)'.

In x25_parse_facilities() that patch changed how facilities->reverse
was set. No other bits were set than 0x80 and/or 0x01.

Signed-off-by: Roel Kluin <roel.kluin< at >gmail.com>
---
This is correct isn't it?

diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 7fa9c7a..ca4dc28 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
< at >< at > -1363,7 +1363,7 < at >< at > static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
     facilities.throughput > 0xDD)
 break;
 if (facilities.reverse &&
-(facilities.reverse | 0x81)!= 0x81)
+(facilities.reverse & 0x81) != 0x81)
 break;
 x25->facilities = facilities;
 rc = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

UNF Notification

2009-10-06T10:15:32

You have been choosen by the U.N Foundation to receive a grant donation of
$1,000 000.00USD.Your Qualification Numbers(G-999-747,UZ-900 77),Contact
Ewa Morgan with Name,Address,country for claim: info.unfgrant< at >gmail.com

United Nations Foundation.
http://www.unfoundation.org/

--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] x25: bit and/or confusion?

Roel Kluin — 2009-08-22T18:40:28

Could it be that something like this was intended?

diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 5e6c072..bbfcdfa 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
< at >< at > -1363,7 +1363,7 < at >< at > static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
     facilities.throughput > 0xDD)
 break;
 if (facilities.reverse &&
-(facilities.reverse | 0x81)!= 0x81)
+(facilities.reverse & 0x81) != 0x81)
 break;
 x25->facilities = facilities;
 rc = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] x25: bit and/or confusion?

Roel Kluin — 2009-08-22T18:40:28

Could it be that something like this was intended?

diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 5e6c072..bbfcdfa 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
< at >< at > -1363,7 +1363,7 < at >< at > static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
     facilities.throughput > 0xDD)
 break;
 if (facilities.reverse &&
-(facilities.reverse | 0x81)!= 0x81)
+(facilities.reverse & 0x81) != 0x81)
 break;
 x25->facilities = facilities;
 rc = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-x25" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html