gmane.linux.usb.general

Re: [PATCH v2 05/12] usb: chipidea: add imx driver binding

Alexander Shishkin — 2012-05-23T13:02:21


Yes, I like Felipe's suggestion. Currently (with Felipe's patches from
yesterday), there is only one dependency (PCI for ci13xxx_pci, which is
ok). So let's try to keep it that way.

I'll push the patches to my tree on github [1] soon, which I propose to
use for all chipidea-related patches.

[1] git://github.com/virtuoso/linux-ci.git

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: chipidea: remove unneeded NULL check

Alexander Shishkin — 2012-05-23T13:00:56

As reported by Dan Carpenter, there is a NULL check in udc_start() that
follows a dereference of the pointer that's being checked. However, at
that point udc pointer shouldn't ever be NULL and if it is, the dereference
should cause an oops.

Reported-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin-VuQAYsv1563Yd54FQh9/CA< at >public.gmane.org>
---
 drivers/usb/chipidea/udc.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 51f9694..cdb9212 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
< at >< at > -1647,9 +1647,6 < at >< at > static int udc_start(struct ci13xxx *udc)
 struct device *dev = udc->dev;
 int retval = 0;
 
-if (!udc)
-return -EINVAL;

[PATCH] [g_mass_storage] Fix unmount problem with OS-X

Pantelis Antoniou — 2012-05-24T11:49:03

OS-X uses a sequence on unmounting that makes us close the backing
file. Apparently there's no way to open it again, which makes it
impossible to remount without rmmod'ing g_mass_storage.

Fix this by adding a media_ejected flag to each lun, and keeping
track of it properly.

Any other method (i.e. preventing unmount, and not keeping track
of the eject status) failed due to OS-X sending start stop commands
after the unmount and checking again.
---
 drivers/usb/gadget/f_mass_storage.c |   21 ++++++++++++++-------
 drivers/usb/gadget/storage_common.c |   11 +++++++++++
 2 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index cb8c162..b865d20 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
< at >< at > -1445,6 +1445,9 < at >< at > static int do_start_stop(struct fsg_common *common)
 curlun->sense_data = SS_MEDIUM_NOT_PRESENT;
 return -EINVAL;
 }
+
+/* if the host is trying again, the media ar

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Felipe Balbi — 2012-05-23T10:47:24

Hi,

On Wed, May 23, 2012 at 06:38:38PM +0800, Richard Zhao wrote:

Is that such a big issue ? Besides you do have timestamping working fine
on sysfs too.

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Richard Zhao — 2012-05-23T10:38:38

I don't need to disable irq here.
pci device may have hotplug capability.
It the id is smaller than last one, people may be confused which is new
one.

Thanks
Richard



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Felipe Balbi — 2012-05-23T10:25:19

sorry, can you explain why that could/would happen and why is it bad ?

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Felipe Balbi — 2012-05-23T10:24:53

I have added the remove method to ci13xxx_msm, patches where sent
yesterday to linux-usb.

[PATCH] drivers: usb: musb: add bf60x support

Bob Liu — 2012-05-23T10:09:49

Bf60x uses new musb ip which is a little different from old blackfin boards.
Now it's the same as most of other arch without a lot of blackfin specific
anomaly.

Signed-off-by: Bob Liu <lliubbo-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
---
 drivers/usb/musb/Kconfig     |    3 ++-
 drivers/usb/musb/blackfin.c  |   31 +++++++++++++++++++++++++------
 drivers/usb/musb/musb_core.c |    5 +++--
 drivers/usb/musb/musb_core.h |    2 +-
 drivers/usb/musb/musb_dma.h  |    2 +-
 drivers/usb/musb/musb_io.h   |    2 +-
 drivers/usb/musb/musb_regs.h |    2 +-
 drivers/usb/musb/musbhsdma.c |    2 +-
 drivers/usb/musb/musbhsdma.h |    2 +-
 9 files changed, 36 insertions(+), 15 deletions(-)

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f70cab3..0fb1466 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
< at >< at > -7,6 +7,7 < at >< at >
 config USB_MUSB_HDRC
 tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
 depends on USB && USB_GADGET
+depends on (ARM || (BF54x && !BF544) || (B

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Richard Zhao — 2012-05-23T09:53:51

If it supports hotplug, the ids may be like 0 1 2 3 1 0 3 ...
It's bad comparing to incremental method.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Richard Zhao — 2012-05-23T09:51:00

Note that we'll need a ci13xxx_remove_device to put id.

Thanks
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Richard Zhao — 2012-05-23T09:35:22

ok
but it needs a loop. hmm.. bitmap is better. I'll change
that way as dwc3_get_device_id.

Thanks
Richard



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] USB: Chipidea: use simple incremental integter as device id

Felipe Balbi — 2012-05-23T09:24:08

Hi,

On Wed, May 23, 2012 at 11:13:40AM +0800, Richard Zhao wrote:

needs commit log


if you used a bitmap you wouldn't need the lock.

Re: [PATCH 1/4] USB: Chipidea: rename struct ci13xxx_udc_driver to struct ci13xxx_platform_data

Felipe Balbi — 2012-05-23T09:23:02

Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0< at >public.gmane.org>

Re: [PATCH 2/4] USB: Chipidea: rename struct ci13xxx variables from udc to ci

Felipe Balbi — 2012-05-23T09:22:34

Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0< at >public.gmane.org>

Re: [PATCH v2] USB: Chipidea: add unified ci13xxx_add_device for platform drivers

Felipe Balbi — 2012-05-23T09:22:12

Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0< at >public.gmane.org>

[PATCH v2] USB: Chipidea: add unified ci13xxx_add_device for platform drivers

Richard Zhao — 2012-05-23T09:11:48

Platform drivers do the similar things to add ci13xxx device, so
create a unified one.

Signed-off-by: Richard Zhao <richard.zhao-KZfg59tc24xl57MIdRCFDg< at >public.gmane.org>
---
 drivers/usb/chipidea/ci13xxx_msm.c |   32 ++++-------------------
 drivers/usb/chipidea/ci13xxx_pci.c |   32 +++--------------------
 drivers/usb/chipidea/core.c        |   48 ++++++++++++++++++++++++++++++++++++
 include/linux/usb/chipidea.h       |    5 +++
 4 files changed, 64 insertions(+), 53 deletions(-)

diff --git a/drivers/usb/chipidea/ci13xxx_msm.c b/drivers/usb/chipidea/ci13xxx_msm.c
index 07c6b73..e1c4fc1 100644
--- a/drivers/usb/chipidea/ci13xxx_msm.c
+++ b/drivers/usb/chipidea/ci13xxx_msm.c
< at >< at > -58,41 +58,21 < at >< at > static struct ci13xxx_platform_data ci13xxx_msm_platdata = {
 static int ci13xxx_msm_probe(struct platform_device *pdev)
 {
 struct platform_device *plat_ci;
-int ret;
 
 dev_dbg(&pdev->dev, "ci13xxx_msm_probe\n");
 
-plat_ci = platform_device_alloc("ci_hdrc", -1);
-if (!plat_ci) {
-dev_err(&pdev->dev, "can't

Re: [PATCH 3/4] USB: Chipidea: add unified ci13xxx_add_device for platform drivers

Richard Zhao — 2012-05-23T08:14:44

[snip]
Ok. Thanks.

Richard



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 02/12] usb: chipidea: permit driver bindings pass phy pointer

Alexander Shishkin — 2012-05-23T08:08:51


Currently, it's a static structure, see 05/12 and my comment there.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] USB: Chipidea: add unified ci13xxx_add_device for platform drivers

Felipe Balbi — 2012-05-23T07:53:54

please make this EXPORT_SYMBOL_GPL() we only want GPL drivers to use
this ;-)

Re: [PATCH] usb: fix possible oops in serial option driver

Matthias Urlichs — 2012-05-23T05:39:14

That's cool. The patch should document that, as the fact that there
is no race condition in the code introduced by the patch is somewhat
non-obvious.
(I was initially thinking the same thing.)

Re: [PATCH] usb: fix possible oops in serial option driver

Jan Safrata — 2012-05-23T05:12:39

The mutex cannot be used in the option_send_setup() function, because it
is already held in usb_wwan_dtr_rts() which calls the option_send_setup(),
so simple check of serial->disconnected flag should be ok there.

Best regards,
Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html