gmane.linux.serial

Re: [PATCH 5/5] Serial: UART driver changes for Cavium OCTEON.

Shinya Kuribayashi — 2008-12-02T01:30:52

Great! and makes sense. Thank you for taking care of my comments. I've also checked the serial patches of version 2, and they looks in good shape.

[PATCH 4/4] Serial: UART driver changes for Cavium OCTEON.

David Daney — 2008-12-01T23:49:28

Cavium UART implementation is not covered by existing uart_configS. Define a new uart_config (PORT_OCTEON) which is specified by OCTEON platform device registration code. Signed-off-by: Tomaso Paoletti caviumnetworks.com> Signed-off-by: David Daney caviumnetworks.com> --- drivers/serial/8250.c | 7 +++++++ include/linux/serial_core.h | 3 ++- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 3ae4974..daa0056 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -279,6 +279,13 < at >< at > static const struct serial8250_config uart_config[] = { .fcr= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, .flags= UART_CAP_FIFO, }, +[PORT_OCTEON] = { +.name= "OCTEON", +.fifo_size= 64, +.tx_loadsz= 64, +.fcr= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, +.flags= UART_CAP_FIFO, +}, }; #if defined (CONFIG_SERIAL_8250_AU1X00) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h

[PATCH 3/4] Serial: Allow port type to be specified when calling serial8250_register_port.

David Daney — 2008-12-01T23:49:27

Add flag value UPF_FIXED_TYPE which specifies that the UART type is known and should not be probed. For this case the UARTs properties are just copied out of the uart_config entry. This allows us to keep SOC specific 8250 probe code out of 8250.c. In this case we know the serial hardware will not be changing as it is on the same silicon as the CPU, and we can specify it with certainty in the board/cpu setup code. The alternative is to load up 8250.c with a bunch of OCTEON specific special cases in the probing code. Signed-off-by: David Daney caviumnetworks.com> Signed-off-by: Andrew Morton linux-foundation.org> --- drivers/serial/8250.c | 9 +++++++++ drivers/serial/serial_core.c | 7 +++++-- include/linux/serial_8250.h | 1 + include/linux/serial_core.h | 2 ++ 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 849af9d..3ae4974 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -2903,6 +2

[PATCH 1/4] 8250: Don't clobber spinlocks.

David Daney — 2008-12-01T23:49:25

In serial8250_isa_init_ports(), the port's lock is initialized. We should not overwrite it. In early_serial_setup(), only copy in the fields we need. Since the early console code only uses a subset of the fields, these are sufficient. Signed-off-by: David Daney caviumnetworks.com> Signed-off-by: Tomaso Paoletti caviumnetworks.com> Signed-off-by: Andrew Morton linux-foundation.org> --- drivers/serial/8250.c | 15 +++++++++++++-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 303272a..8e28750 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -2752,12 +2752,23 < at >< at > static struct uart_driver serial8250_reg = { */ int __init early_serial_setup(struct uart_port *port) { +struct uart_port *p; + if (port->line >= ARRAY_SIZE(serial8250_ports)) return -ENODEV; serial8250_isa_init_ports(); -serial8250_ports[port->line].port= *port; -serial8250_ports[port->line].port.ops= &serial8250_pops;

[PATCH 2/4] 8250: Serial driver changes to support future Cavium OCTEON serial patches.

David Daney — 2008-12-01T23:49:26

In order to use Cavium OCTEON specific serial i/o drivers, we first patch the 8250 driver to use replaceable I/O functions. Compatible I/O functions are added for existing iotypeS. An added benefit of this change is that it makes it easy to factor some of the existing special cases out to board/SOC specific support code. The alternative is to load up 8250.c with a bunch of OCTEON specific iotype code and bug work-arounds. Signed-off-by: David Daney caviumnetworks.com> Signed-off-by: Tomaso Paoletti caviumnetworks.com> Signed-off-by: Andrew Morton linux-foundation.org> --- drivers/serial/8250.c | 194 ++++++++++++++++++++++++++++++------------- include/linux/serial_8250.h | 2 + include/linux/serial_core.h | 2 + 3 files changed, 140 insertions(+), 58 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 8e28750..849af9d 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -303,16 +303,16 < at >< at > static const u8 au_io_out_map[] = { }

[PATCH 0/4] serial: Patches for OCTEON CPU support (version 2).

David Daney — 2008-12-01T23:46:22

The previous patch set was Signed-off-by: Andrew Morton and added to the -mm tree, however comments from Shinya Kuribayashi prompted me to make some improvements. The first three patches are unchanged from the previous set (I hope it is not a breach of etiquette to include them again). The forth which allows uart bug types to be statically specified is completely removed. And the fifth (now forth) is simplified and now only adds a uart type for the OCTEON uart. And as I previously said: Since these are the only non-mips specific patches required for OCTEON cpu support, it is necessary to get these Signed-off-by before the full OCTEON patch set can proceed. Four patches to follow. Thanks, David Daney (4): 8250: Don't clobber spinlocks. 8250: Serial driver changes to support future Cavium OCTEON serial patches. Serial: Allow port type to be specified when calling serial8250_register_port. Serial: UART driver changes for Cavium OCTEON. drivers/serial/8250.c | 225 +++++

Re: [PATCH 5/5] Serial: UART driver changes for Cavium OCTEON.

David Daney — 2008-12-01T18:43:11

Unfortunately I overlooked the patch comment when I moved the other bug workaround to platform code. However after your suggestion below... [...] ... All our boards are now working with no extra bug flags needed. So I will simplify this patch set by getting rid of UART_BUG_TIMEOUT. Thanks, David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

BUG REPORT: 8250 serial driver tcsetattr / TIOCMIWAIT interaction

Lawrence Rust — 2008-11-28T10:05:26

[1.] Calling tcsetattr prevents any thread suspended in ioctl TIOCMIWAIT from ever resuming. [2.] If a thread is suspended inside a call to ioctl TIOCMIWAIT, waiting for a modem status change, the 8250 driver enables modem status interrupts. The modem status interrupt service routine resumes the suspended thread on the next modem status irq. If in the mean time, another thread calls tcsetattr then the 8250 driver disables modem status interrupts (unless CTS/RTS handshaking is enabled). This prevents the suspended thread from ever being resumed. [3.] Keywords serial, 8250 [4.] Kernel 2.6.24-21 [4.1.] cat /proc/version: Linux version 2.6.24-21-lvr (root< at >Collins) (gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)) #2 Wed Oct 22 19:42:04 CEST 2008 [7.] Example C program to demonstrate: /* gcc -o test test.c -l pthread */ #include #include #include #include #include #include #include #include static void* monit

Re: [PATCH 5/5] Serial: UART driver changes for Cavium OCTEON.

Shinya Kuribayashi — 2008-11-28T03:27:33

Hi David, David Daney wrote: You just added one new bug type, not two. ;-) I see your point. Then let's look at this commit: |commit 40b36daad0ac704e6d5c1b75789f371ef5b053c1 |Author: Alex Williamson hp.com> |Date: Wed Feb 14 00:33:04 2007 -0800 | | [PATCH] 8250 UART backup timer | | The patch below works around a minor bug found in the UART of the remote | management card used in many HP ia64 and parisc servers (aka the Diva | UARTs). The problem is that the UART does not reassert the THRE interrupt | if it has been previously cleared and the IIR THRI bit is re-enabled. This | can produce a very annoying failure mode when used as a serial console, | allowing a boot/reboot to hang indefinitely until an RX interrupt kicks it | into working again (ie. an unattended reboot could stall). | | To solve this problem, a backup timer is introduced that runs alongside the | standard interrupt driven mechanism. This timer wakes up periodically, | checks for a

[PATCH] 8250: when waking, PM hook should be called before accessing port

Kevin Hilman — 2008-11-27T00:25:23

The UART suspend hook may have disabled the UART clocks such that accesses to the port may fail. So before accessing the port call the PM hook so it has a chance to enable clocks. Signed-off-by: Kevin Hilman deeprootsystems.com> --- drivers/serial/8250.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 993a242..a181667 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -2334,10 +2334,18 < at >< at > serial8250_pm(struct uart_port *port, unsigned int state, unsigned int oldstate) { struct uart_8250_port *p = (struct uart_8250_port *)port; +int sleep = state != 0; -serial8250_set_sleep(p, state != 0); +/* If we're waking up, call the PM hook before waking up + * so port can be properly activated/enabled if necessary */ +if (p->pm && !sleep) +p->pm(port, state, oldstate); + +serial8250_set_sleep(p, sleep); -if (p->pm) +/* If we're going to sleep, PM hook should be called after + * t

[PATCH] mpc52xx/serial: add rts/cts handling

Wolfram Sang — 2008-11-26T15:04:54

Add RTS/CTS-support for the PSC of the MPC5200B. Tested with a Phytec MPC5200B-IO. Signed-off-by: Wolfram Sang pengutronix.de> --- arch/powerpc/include/asm/mpc52xx_psc.h | 11 +++++++- drivers/serial/mpc52xx_uart.c | 41 ++++++++++++++++++++++++++++--- 2 files changed, 47 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h index 8917ed6..a218da6 100644 --- a/arch/powerpc/include/asm/mpc52xx_psc.h +++ b/arch/powerpc/include/asm/mpc52xx_psc.h < at >< at > -68,12 +68,20 < at >< at > #define MPC52xx_PSC_IMR_ORERR0x1000 #define MPC52xx_PSC_IMR_IPC0x8000 -/* PSC input port change bit */ +/* PSC input port change bits */ #define MPC52xx_PSC_CTS0x01 #define MPC52xx_PSC_DCD0x02 #define MPC52xx_PSC_D_CTS0x10 #define MPC52xx_PSC_D_DCD0x20 +/* PSC acr bits */ +#define MPC52xx_PSC_IEC_CTS0x01 +#define MPC52xx_PSC_IEC_DCD0x02 + +/* PSC output port bits */ +#define MPC52xx_PSC_OP_RTS0x01 +#define MPC52xx_PSC_OP_RES0x0

[PATCH 3/5] Serial: Allow port type to be specified when calling serial8250_register_port.

David Daney — 2008-11-26T00:18:37

Add flag value UPF_FIXED_TYPE which specifies that the UART type is known and should not be probed. For this case the UARTs properties are just copied out of the uart_config entry. This allows us to keep SOC specific 8250 probe code out of 8250.c. In this case we know the serial hardware will not be changing as it is on the same silicon as the CPU, and we can specify it with certainty in the board/cpu setup code. The alternative is to load up 8250.c with a bunch of OCTEON specific special cases in the probing code. Signed-off-by: David Daney caviumnetworks.com> --- drivers/serial/8250.c | 9 +++++++++ drivers/serial/serial_core.c | 7 +++++-- include/linux/serial_8250.h | 1 + include/linux/serial_core.h | 2 ++ 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 849af9d..3ae4974 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -2903,6 +2903,7 < at >< at > static int __devinit serial8250_probe(struct pla

[PATCH 5/5] Serial: UART driver changes for Cavium OCTEON.

David Daney — 2008-11-26T00:18:39

Cavium UART implementation won't work with the standard 8250 driver as-is. Define a new uart_config (PORT_OCTEON) and use it to enable special handling required by the OCTEON's serial port. Two new bug types are defined. Signed-off-by: Tomaso Paoletti caviumnetworks.com> Signed-off-by: David Daney caviumnetworks.com> --- drivers/serial/8250.c | 10 +++++++++- drivers/serial/8250.h | 1 + include/linux/serial_core.h | 3 ++- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 3bb8e30..63dbbb6 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -279,6 +279,14 < at >< at > static const struct serial8250_config uart_config[] = { .fcr= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, .flags= UART_CAP_FIFO, }, +[PORT_OCTEON] = { +.name= "OCTEON", +.fifo_size= 64, +.tx_loadsz= 64, +.bugs= UART_BUG_TIMEOUT, +.fcr= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10, +.flags= UART_CAP_FIFO

[PATCH 4/5] 8250: Allow port type to specify bugs that are not probed for.

David Daney — 2008-11-26T00:18:38

Add a bugs field to the serial8250_config and propagate it to the port's bugs field when the port is registered and configured. This is a follow on to the previous patch. Now that we can specify the port type and don't have to probe for it, we can avoid probing for bugs if they are known with certainty to exist. The alternative is to load up 8250.c with a bunch of OCTEON specific special cases in the probing code. Signed-off-by: David Daney caviumnetworks.com> --- drivers/serial/8250.c | 2 ++ drivers/serial/8250.h | 1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 3ae4974..3bb8e30 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -1212,6 +1212,7 < at >< at > static void autoconfig(struct uart_8250_port *up, unsigned int probeflags) up->port.fifosize = uart_config[up->port.type].fifo_size; up->capabilities = uart_config[up->port.type].flags; up->tx_loadsz = uart_config[up->port.type].tx_loadsz; +up->bugs |=

[PATCH 1/5] 8250: Don't clobber spinlocks.

David Daney — 2008-11-26T00:18:35

In serial8250_isa_init_ports(), the port's lock is initialized. We should not overwrite it. In early_serial_setup(), only copy in the fields we need. Since the early console code only uses a subset of the fields, these are sufficient. Signed-off-by: David Daney caviumnetworks.com> Signed-off-by: Tomaso Paoletti caviumnetworks.com> --- drivers/serial/8250.c | 15 +++++++++++++-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 303272a..8e28750 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -2752,12 +2752,23 < at >< at > static struct uart_driver serial8250_reg = { */ int __init early_serial_setup(struct uart_port *port) { +struct uart_port *p; + if (port->line >= ARRAY_SIZE(serial8250_ports)) return -ENODEV; serial8250_isa_init_ports(); -serial8250_ports[port->line].port= *port; -serial8250_ports[port->line].port.ops= &serial8250_pops; +p = &serial8250_ports[port->line].port; +p->iobase

[PATCH 2/5] 8250: Serial driver changes to support future Cavium OCTEON serial patches.

David Daney — 2008-11-26T00:18:36

In order to use Cavium OCTEON specific serial i/o drivers, we first patch the 8250 driver to use replaceable I/O functions. Compatible I/O functions are added for existing iotypeS. An added benefit of this change is that it makes it easy to factor some of the existing special cases out to board/SOC specific support code. The alternative is to load up 8250.c with a bunch of OCTEON specific iotype code and bug work-arounds. Signed-off-by: David Daney caviumnetworks.com> Signed-off-by: Tomaso Paoletti caviumnetworks.com> --- drivers/serial/8250.c | 194 ++++++++++++++++++++++++++++++------------- include/linux/serial_8250.h | 2 + include/linux/serial_core.h | 2 + 3 files changed, 140 insertions(+), 58 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 8e28750..849af9d 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c < at >< at > -303,16 +303,16 < at >< at > static const u8 au_io_out_map[] = { }; /* sane hardware needs no mapping */ -static inline

[PATCH 0/5] serial: Patches for OCTEON CPU support.

David Daney — 2008-11-26T00:14:52

Previously I have posted these five patches as part of the larger CPU support patch set. I am separating them out now as I have incorporated changes as suggested by Alan Cox, and these are ready for review now. Changes from previous version: * I/O functions now called serial_{in,out}. * UART_BUG_OCTEON_IIR workaround moved to OCTEON serial_in function and out of this patch set. Since these are the only non-mips specific patches required for OCTEON cpu support, it is necessary to get these Signed-off-by before the full OCTEON patch set can proceed. Also since serial is lacking active maintainers, I am sending directly to akpm and Alan in hopes that one or more of them will review the patches. Five patches to follow. David Daney (5): 8250: Don't clobber spinlocks. 8250: Serial driver changes to support future Cavium OCTEON serial patches. Serial: Allow port type to be specified when calling serial8250_register_port. 8250: Allow port type to specify bugs that are not probed for

Re: [PATCH/RFC v1 00/12] Support for Broadcom 63xx SOCs

Florian Fainelli — 2008-11-25T17:44:26

Hi again, Le Wednesday 22 October 2008 15:58:23 Florian Fainelli, vous avez écrit : So the OpenWrt community did the following succesful tests : - Inventel Livebox Pro (Need the OpenWrt patches plus some glue code to retrieve the MAC address) (6348) - Neufbox 4 (6358) - Comtrend CT536+ (6348) - A custom design based on a BCM6348 There might be other successful reports as well.

Re: [PATCH] 8250: Eliminate compile warning of 8250.c

Sheng Yang — 2008-11-25T11:32:07

OK, I got it now. Comparing the result of deleting a meaningful line, this modification result in no more warning. And you also think one additional BUG_ON just for fixing compiler's mistake, so it's unacceptable. So leave the patch as it was. Seems many people need to upgrade compiler to avoid this thing. :)

Re: [PATCH] 8250: Eliminate compile warning of 8250.c

Olivier Galibert — 2008-11-25T11:12:13

The new compiler gets it right. If you delete the assignment with the new compiler, *then* you get a warning. Compile-time error detection is better than runtime. OG. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] 8250: Eliminate compile warning of 8250.c

Alan Cox — 2008-11-25T11:13:42

Why No.. if you hid the warning by hacking around the compiler mistake with extra bogus assignments you would hide a future mistake. The compiler does now get it right - I checked. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html