gmane.linux.serial

Re: [Resend/PATCHv5 0/3] Omap serial cleanup

Kevin Hilman — 2013-05-23T14:14:41

Hi Sourav,

Sourav Poddar <sourav.poddar< at >ti.com> writes:


Greg has queued the serial core changes for v3.11, and I've queued this
series for the OMAP specific changes for v3.11[1].

Thanks again for your persistence with this series.

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.11/uart/no_console_suspend

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/4] ARM: davinci: uart: move to dev_id based clk_get

Manjunathappa, Prakash — 2013-05-23T13:25:57

Hi Sekhar,

Thanks for reviewing.

On Fri, Apr 26, 2013 at 12:31:53, Nori, Sekhar wrote:

True, will change them.


Ok. I will remove them.


Correct, I will change it.


Ok I will cleanup this and submit v2.

Thanks,
Prakash

[PATCH] serial: use platform_{get,set}_drvdata()

Jingoo Han — 2013-05-23T10:39:36

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Jingoo Han <jg1.han< at >samsung.com>
---
 drivers/tty/serial/cpm_uart/cpm_uart_core.c |    4 ++--
 drivers/tty/serial/mpc52xx_uart.c           |    9 ++++-----
 drivers/tty/serial/of_serial.c              |    4 ++--
 drivers/tty/serial/sc26xx.c                 |    5 ++---
 drivers/tty/serial/sunhv.c                  |    6 ++----
 drivers/tty/serial/sunsab.c                 |    6 ++----
 drivers/tty/serial/sunsu.c                  |    8 +++-----
 drivers/tty/serial/sunzilog.c               |    6 ++----
 drivers/tty/serial/ucc_uart.c               |    5 ++---
 drivers/tty/serial/xilinx_uartps.c          |    6 ++----
 10 files changed, 23 insertions(+), 36

Re: [PATCH v3] tty: serial: add Freescale lpuart driver support

Shawn Guo — 2013-05-23T02:51:01

You can never tell in 5 or 10 years.  Also no major version doesn't
necessarily mean no minor updates or revise.


Yeah, if IP designers name it lpuart2.0, it surely works.  But from my
experience on IMX, hardware guys are not always properly updating IP
name.  Then the version 2.0 becomes a versioning given by software
people which is improper to be used in compatible string.


Not only select the driver but also the programing model implemented in
the driver.  Take a look at drivers/mmc/host/sdhci-esdhc-imx.c or
drivers/net/ethernet/freescale/fec_main.c, multiple compatible strings
select the same driver but the different programing model implemented in
the driver.


Seriously?  The "version" equally means the compatibility here.  How can
a compatible string be not used to describe "version" - compatibility?


If the IP gets a revise, the driver should be updated to support a new
programing model with a new compatible string.


Think about it from "compatibility" point of view.  It does not cause
confusio

[PATCH] serial/JSM: change maintainer to myself

Thadeu Lima de Souza Cascardo — 2013-05-22T18:15:24

Lucas has moved on. Since his email address does not work any more, it's
not expected to get his ack.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo< at >linux.vnet.ibm.com>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 829c032..e713e57 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
< at >< at > -4559,7 +4559,7 < at >< at > F:fs/jbd2/
 F:include/linux/jbd2.h
 
 JSM Neo PCI based serial card
-M:Lucas Tavares <lucaskt< at >linux.vnet.ibm.com>
+M:Thadeu Lima de Souza Cascardo <cascardo< at >linux.vnet.ibm.com>
 L:linux-serial< at >vger.kernel.org
 S:Maintained
 F:drivers/tty/serial/jsm/

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

Arnd Bergmann — 2013-05-22T15:13:37

What may have happened here is that custom_divisor was used in a different
way when I added that code than it is today, and the change was not propagated
into the of_serial driver. However, going back to 2.6.20 shows no different
code than what we have today in this regard. It may simply have been a mistake
on my side.


I looked it up in the original serial port binding at
http://www.openfirmware.org/1275/bindings/devices/html/serial.html, which does
not specify the property, and in ePAPR, which does have it in the section about
"serial class devices":

18 6.2.1.2 current-speed
19 Property: current-speed
20 Value type: <u32>
21 Description:
22 Specifies the current speed of a serial device in bits per second. A boot program should set
23 this property if it has initialized the serial device.
24 Example:
25 current - speed = <115200>; # 115200 baud

The reason you want this is so that the driver can initialize the hardware from
scratch more easily and get back to the same settings. Why they only specified
t

[PATCH 1/1] serial: vt8500: Remove redundant use of of_match_ptr macro

Sachin Kamat — 2013-05-22T11:36:29

'wmt_dt_ids' is always compiled in. Hence of_match_ptr is not
necessary.

Signed-off-by: Sachin Kamat <sachin.kamat< at >linaro.org>
---
 drivers/tty/serial/vt8500_serial.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c
index 1a8bc22..48af43d 100644
--- a/drivers/tty/serial/vt8500_serial.c
+++ b/drivers/tty/serial/vt8500_serial.c
< at >< at > -648,7 +648,7 < at >< at > static struct platform_driver vt8500_platform_driver = {
 .driver = {
 .name = "vt8500_serial",
 .owner = THIS_MODULE,
-.of_match_table = of_match_ptr(wmt_dt_ids),
+.of_match_table = wmt_dt_ids,
 },
 };

RE: [PATCH v3] tty: serial: add Freescale lpuart driver support

Jin Zhengxiong-R64188 — 2013-05-22T08:59:20

[Jason Jin-R64188] For the lpuart itself, I do not think it will have different version IP. The general name is sufficient and soc related name can introduce the minor difference. If the there are update version, we can name it lpuart2.0 or something like that.

For the compatible property itself, the ePAPR described it as:
---- 
The compatible property value consists of one or more strings that define the specific programming model for the device. This list of strings should be used by a client program for device driver selection. The property value consists of a concatenated list of null terminated strings, from most specific to most general. 
----
So for the IPs especially for the peripheral IPs, the compatible just used to select the driver for the device. It should not used to describe the version information. If the version changed and the driver cannot be used for the device then another compatible strings should be used.

As I said, Another reason for the general strings used is the across platform i

Re: [PATCH v3] tty: serial: add Freescale lpuart driver support

Shawn Guo — 2013-05-22T07:23:05

As I already said, a generic compatible string does not specify
anything about compatibility/version, and hence it's not a good
compatible for IP block which is possibly to be integrated on multiple
SoCs with slight differences.

For example, if there is a new SoC mvf900 integrating the IP with
everything compatible to the version used on mvf600,

  compatible = <fsl,mvf900-uart>, <fsl,mvf600-uart>;
  compatible = <fsl,mvf900-uart>, <fsl,lpuart>;

which one do you think is better to tell the compatibility/version?

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] tty: mxser: Fix build warning introduced by dfc7b837c7f9 (Re: linux-next: build warning after merge of the tty.current tree)

Matwey V. Kornilov — 2013-05-22T07:13:38

From: Matwey V. Kornilov <matwey< at >sai.msu.ru>

Fix build warning at mxser.c introduced by dfc7b837c7f9

Signed-off-by: Matwey V. Kornilov <matwey< at >sai.msu.ru>
---

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index f97b196..4c4a236 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
< at >< at > -1674,15 +1674,15 < at >< at > static int mxser_ioctl(struct tty_struct *tty,
  return mxser_ioctl_special(cmd, argp);

  if (cmd == MOXA_SET_OP_MODE || cmd == MOXA_GET_OP_MODE) {
-if (info->board->chip_flag != MOXA_MUST_MU860_HWID)
-return -EFAULT;
-
  int p;
  unsigned long opmode;
  static unsigned char ModeMask[] = { 0xfc, 0xf3, 0xcf, 0x3f };
  int shiftbit;
  unsigned char val, mask;

+if (info->board->chip_flag != MOXA_MUST_MU860_HWID)
+return -EFAULT;
+
  p = tty->index % 4;
  if (cmd == MOXA_SET_OP_MODE) {
  if (get_user(opmode, (int __user *) argp))

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More m

RE: [PATCH v3] tty: serial: add Freescale lpuart driver support

Sharma Bhupesh-B45370 — 2013-05-22T06:54:17

It's better to use the generic name lpuart in the compatible string as it provides
much closer association with the lpuart driver which can be generic across SoCs.

As Jason pointed out, minor differences in IP implementation across SoCs can be
handled by passing the soc related compatible string.

Regards,
Bhupesh


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v3] tty: serial: add Freescale lpuart driver support

Jin Zhengxiong-R64188 — 2013-05-22T06:40:21

[Jason Jin-R64188] Reuse the same LPUART on LS-1 with the compatible strings 'fsl,mvf600-lpuart' is technically OK, But it will fuss the route map of the product Line. The general name can show that the IP is shared between several product lines, and the history for which SOC firstly used the IP is not very important. With general compatible name, We can setup the general dts for the shared IPs.

That's also the case for the IPs used on Power platform, Take the IFC for example, this IP implemented on Power platform will also be reused LS-1, The compatible string is set as  "fsl,ifc", "simple-bus" but not the soc name on which the IP first used.

 Another example, though a little different, the nor flash driver, which is used for many platform, the compatible "cfi-flash" will be more reasonable than the soc/board name.

With the general name for the compatible string in the driver, if there is minor difference for the different implementation of the same IP, we can add the soc related compatible string to the

RE: [PATCH] ARM: bcm2835: override the HW UART periphid

Jongsung Kim — 2013-05-22T01:52:22

Stephen Warren <swarren< at >wwwdotorg.org> :
presumably

Thank you, Stephen.


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: bcm2835: override the HW UART periphid

Stephen Warren — 2013-05-21T16:34:17

I know this will work, because I tried out the same thing last week.

However, I'm not convinced that it's the correct approach. What other
changes exist between r1p4 and r1p5; can you check in the TRM? Faking
the periphid would prevent the driver from taking account of any other
changes. Should we instead add a DT property solely to override the FIFO
size, and then set that for bcm2835? I guess if there really aren't any
other SW-visible changes in r1p5, this approach is fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] tty: mxser: fix usage of opmode_ioaddr

Matwey V. Kornilov — 2013-05-21T09:57:37

From: Matwey V. Kornilov <matwey< at >sai.msu.ru>

mxser_port->opmode_ioaddr is initialized only for MOXA_MUST_MU860_HWID 
chips, but no precautions have been undertaken to prevent reading and 
writing to undefined port number.

Signed-off-by: Matwey V. Kornilov <matwey< at >sai.msu.ru>
---

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index 71d6eb2..f97b196 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
< at >< at > -1618,8 +1618,12 < at >< at > static int mxser_ioctl_special(unsigned int cmd, void __user *argp)
  if (ip->type == PORT_16550A)
  me->fifo[p] = 1;

-opmode = inb(ip->opmode_ioaddr)>>((p % 4) * 2);
-opmode &= OP_MODE_MASK;
+if (ip->board->chip_flag == MOXA_MUST_MU860_HWID) {
+opmode = inb(ip->opmode_ioaddr)>>((p % 4) * 2);
+opmode &= OP_MODE_MASK;
+} else {
+opmode = RS232_MODE;
+}
  me->iftype[p] = opmode;
  mutex_unlock(&port->mutex);
  }
< at >< at > -1670,6 +1674,9 < at >< at > static int mxser_ioctl(struct tty_struct *tty,
  return mxser_ioctl_special(cmd, argp)

Re: [PATCH] ARM: bcm2835: override the HW UART periphid

Gordon Hollingworth — 2013-05-21T09:00:37

Have checked with the designer of the UART block and he confirmed that
the 2835 PL011 contains a 16 deep fifo not 32 deep...

Hardware guys, they can never just leave it alone!!!

Gordon

On 21 May 2013 07:07, Jongsung Kim <neidhard.kim< at >lge.com> wrote:
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tty: nwpserial: Pass correct pointer to free_irq()

Benjamin Krill — 2013-05-21T07:18:10

Acked-off-by: Benjamin Krill <ben< at >codiert.org>

On Mon, 2013-05-20 at 19:07 +0200, Lars-Peter Clausen wrote:


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] serial: 8250_dw: add ACPI ID for Intel BayTrail

Heikki Krogerus — 2013-05-21T06:34:24

This is the same controller as on Intel Lynxpoint but the
ACPI ID is different.

Signed-off-by: Heikki Krogerus <heikki.krogerus< at >linux.intel.com>
---
 drivers/tty/serial/8250/8250_dw.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 0b0eef9..d07b6af 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
< at >< at > -369,6 +369,7 < at >< at > MODULE_DEVICE_TABLE(of, dw8250_of_match);
 static const struct acpi_device_id dw8250_acpi_match[] = {
 { "INT33C4", 0 },
 { "INT33C5", 0 },
+{ "80860F0A", 0 },
 { },
 };
 MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);

RE: [PATCH] ARM: bcm2835: override the HW UART periphid

Jongsung Kim — 2013-05-21T06:07:34

Jongsung Kim <neidhard.kim< at >lge.com> :
b/arch/arm/boot/dts/bcm2835.dtsi

Stephen, how do you think about this kind of approach instead?

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: bcm2835: override the HW UART periphid

Jongsung Kim — 2013-05-21T06:02:29

Stephen Warren reported the recent commit 78506f2 (add support for
extended FIFO-size of PL011-r1p5) breaks the serial port on the
BCM2835 ARM SoC.

A UART compatible with the ARM PL011-r1p5 should have 32-deep FIFOs.
The BCM2835 UART just looks like an ARM PL011-r1p5, but has 16-deep
FIFOs just like PL011-r1p4 or earlier revisions. As a workaround for
this compatibility issue, this patch overrides the HW UART periphid
register values with the actually compatible UART periphid 0x00241011
(r1p3 or r1p4).

Reported-by: Stephen Warren <swarren< at >wwwdotorg.org>
Signed-off-by: Jongsung Kim <neidhard.kim< at >lge.com>
---
 arch/arm/boot/dts/bcm2835.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index f0052dc..1e12aef 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
< at >< at > -44,6 +44,7 < at >< at >
 reg = <0x7e201000 0x1000>;
 interrupts = <2 25>;
 clock-frequency = <3000000>;
+arm,primecell-periphid

Re: [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

Stephen Warren — 2013-05-21T02:12:58

This all seems rather academic. Irrespective of what the cause of the
problem is, the commit actively breaks a previously working
configuration. I still believe we should revert it first, then find out
exactly what's going on later. Should I sent the revert commit?

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html