gmane.linux.ports.sh.devel

Re: [PATCH] libata: do not limit R-Car SATA driver to shmobile

Sergei Shtylyov — 2013-05-24T18:35:55

Hello.

On 05/24/2013 06:34 AM, Tejun Heo wrote:


     I guess you haven't pushed it out -- I don't see the commit when 
pulling.


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/17 v2] ARM: shmobile: r8a7778: add I2C support

Sergei Shtylyov — 2013-05-24T14:10:34

Hello.

On 24-05-2013 8:39, Kuninori Morimoto wrote:




    I don't think anybody familiar with arithmetic operator priorities 
(i.e. having graduated from a primary school) can misread this.


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Sergei Shtylyov — 2013-05-24T14:02:32

Hello.

On 24-05-2013 6:06, Simon Horman wrote:


     I don't see where you are adding clock for device tree case.


     Does R8A7790 have these "early" and "late" lists? I guess not.



[...]
[...]

    What's with SATA0?


    Non-static variable with an intializer? Won't this be a waste of 
code? Wouldn't it be better to have it static __initdata?


     2 megabytes? Won't it be a waste of memory?


    Same comment about non-static initialized structure...


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 15/21] ARM: shmobile: armadillo-reference: Move st1232 reset GPIO to DT

Magnus Damm — 2013-05-24T12:24:26

Hi Linus,

On Fri, May 24, 2013 at 5:59 PM, Linus Walleij <linus.walleij< at >linaro.org> wrote:

Yes, agreed, even grumpy me starts thinking this looks good. =)


Regarding dependency handing of driver and board code, I believe
Laurent has us covered.

As for breaking non-DT boot, under mach-shmobile the code for DT
"-reference" board support is DT only so judging by the file name this
kind of change should be fine.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: shmobile: irqpin: map spurious interrupts in DT case

Guennadi Liakhovetski — 2013-05-24T09:13:07

In the non-DT case all interrupts get mapped statically during probing,
therefore, if a spurious interrupt arrives, it can easily be mapped back
to hardware registers and bits and handled. In the DT case interrupts are
mapped only when a device, using that interrupt is instantiated from DT.
So, spurious interrupts occur unmapped and thus cannot be handled properly.
This patch fixes this by mapping such interrupts as they occur.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
---
 drivers/irqchip/irq-renesas-intc-irqpin.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/irqchip/irq-renesas-intc-irqpin.c b/drivers/irqchip/irq-renesas-intc-irqpin.c
index 82cec63..e62d76d 100644
--- a/drivers/irqchip/irq-renesas-intc-irqpin.c
+++ b/drivers/irqchip/irq-renesas-intc-irqpin.c
< at >< at > -71,6 +71,7 < at >< at > struct intc_irqpin_priv {
 struct intc_irqpin_iomem iomem[INTC_IRQPIN_REG_NR];
 struct intc_irqpin_irq irq[INTC_IRQPIN_MAX];
 struct renesas_intc_irqpin_config config;
+

Re: [PATCH v4 15/21] ARM: shmobile: armadillo-reference: Move st1232 reset GPIO to DT

Linus Walleij — 2013-05-24T08:59:50

On Tue, May 21, 2013 at 2:14 PM, Laurent Pinchart
<laurent.pinchart+renesas< at >ideasonboard.com> wrote:



Just as a random example this becomes:

gpios = <&pfc 166 GPIO_ACTIVE_LOW>;

Which is WAAAY more readable.


Not really my business but I guess the driver is already augmented to pick its
GPIO from the device tree in this case? And are you willingly breaking
non-DT boots or something?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 02/21] sh-pfc: Add DT support

Linus Walleij — 2013-05-24T08:52:42

On Tue, May 21, 2013 at 2:14 PM, Laurent Pinchart
<laurent.pinchart+renesas< at >ideasonboard.com> wrote:

(...)

(Again I'm rather nervous about all the device tree binding reviewing being
dropped in the lap of Linux subsystem maintainers and then expecting them
to be good and OS-neutral... Not your fault though.)


Then just use a boolean.


Just use a boolean oneliner then.

But I prefer that you define something really generic in
Documentation/devicetree/bindings/pinconf.txt for anyone using
generic pin config, then reference that.

This way we can have a more general config binding for any system
using generic pin config, mapping to the configs we have in
<linux/pinctrl/pinconf-generic.h>

The upside is that we could move the pinconf generic parsing code
to drivers/pinctrl/pinconf-generic.c and thus avoid code duplication.

We have so far not tried much to standardize pinctrl bindings, but
this would be a good opportunity.



I suggest these properties shall be defined in an include file using that new
inclu

Re: [PATCH v4 01/21] sh-pfc: Remove support for platform data

Linus Walleij — 2013-05-24T08:23:14

On Tue, May 21, 2013 at 2:14 PM, Laurent Pinchart
<laurent.pinchart+renesas< at >ideasonboard.com> wrote:


Acked-by: Linus Walleij <linus.walleij< at >linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/17 v2] ARM: shmobile: r8a7778: add I2C support

Kuninori Morimoto — 2013-05-24T04:39:33

Hi


I can prevent misreading.


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Simon Horman — 2013-05-24T03:44:20

Thanks, I will look at that.


I think it is not so important.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Kuninori Morimoto — 2013-05-24T03:11:05

Hi Simon


Caring both SATA0/1 are nice IMO :)


can you check r8a7778_sdhi_init(int id, xxx) ?
It is caring both id field and resources.


OK, nice.

Do you think other chip (= r8a7778) should follow same naming?


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Simon Horman — 2013-05-24T02:59:44

Because the lager board only seems to expose SATA1 and I was
interested in something I could test.

I am happy to start caring about SATA0 if you think it is
a good idea.


Sure, but I'm unsure how you want r8a7790_register_sata to handle id.

Is it just for the id field of struct platform_device_info pdevinfo?
Or also to switch between resources somehow?


I chose register as it seemed to be consistent with the
existing contents of r8a7790_add_standard_devices().
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: do not limit R-Car SATA driver to shmobile

Tejun Heo — 2013-05-24T02:34:15

On Fri, May 24, 2013 at 11:05 AM, Simon Horman
<horms+renesas< at >verge.net.au> wrote:

Applied to libata/for-3.11.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Kuninori Morimoto — 2013-05-24T02:21:17

Hi Simon


This "using local variable" make sense.
It don't need "__initdata"


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Kuninori Morimoto — 2013-05-24T02:17:22

Hi Simon


(snip)

This is a little bit strange for me.
Why you don't care SATA0 ?

Can you use like this ?

static __init void r8a7790_register_sata(int id);


BTW, we need to decide "driver registration function naming" ?
In r8a7778 case, it is using 

r8a7778_add_xxx_device()
r8a7778_add_xxx_devices()

but r8a7778_register_xxx seems nice naming :)

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: mach-shmobile: r8a7790: add SATA support

Simon Horman — 2013-05-24T02:06:24

Add SATA clock for r8a7790 SoC (for both device tree and usual cases).
Register SATA controller as a "late" platform device on r8a7790 SoC.

Based on "ARM: mach-shmobile: r8a7779: add SATA support" by
Vladimir Barinov.

Signed-off-by: Simon Horman <horms+renesas< at >verge.net.au>
---
 arch/arm/mach-shmobile/clock-r8a7790.c |  4 ++++
 arch/arm/mach-shmobile/setup-r8a7790.c | 21 +++++++++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
index b393592..3619a52 100644
--- a/arch/arm/mach-shmobile/clock-r8a7790.c
+++ b/arch/arm/mach-shmobile/clock-r8a7790.c
< at >< at > -50,6 +50,7 < at >< at >
 #define SMSTPCR2 0xe6150138
 #define SMSTPCR3 0xe615013c
 #define SMSTPCR7 0xe615014c
+#define SMSTPCR8 0xe6150990
 
 #define MODEMR0xE6160060
 #define SDCKCR0xE6150074
< at >< at > -180,6 +181,7 < at >< at > static struct clk div6_clks[DIV6_NR] = {
 
 /* MSTP */
 enum {
+MSTP814,
 MSTP721, MSTP720,
 MSTP304,
 MSTP216, MSTP207, MSTP206, MSTP204, MSTP203, MSTP202,
< at >< at >

[PATCH] libata: do not limit R-Car SATA driver to shmobile

Simon Horman — 2013-05-24T02:05:59

The motivation for this is to allow the driver to be
used with the r8a7790 SoC.

I believe that rather than adding another SoC to the list of allowed SoCs
it is better to simply remove the dependency of the driver on shmobile all
together.

Signed-off-by: Simon Horman <horms+renesas< at >verge.net.au>
---
 drivers/ata/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index a5a3ebc..aba6e93 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
< at >< at > -263,7 +263,6 < at >< at > config SATA_PROMISE
 
 config SATA_RCAR
 tristate "Renesas R-Car SATA support"
-depends on ARCH_SHMOBILE && ARCH_R8A7779
 help
   This option enables support for Renesas R-Car Serial ATA.

[PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver

Sergei Shtylyov — 2013-05-23T22:11:28

From: Vladimir Barinov <vladimir.barinov< at >cogentembedded.com>

Add Renesas R-Car VIN (Video In) V4L2 driver.

Based on the patch by Phil Edworthy <phil.edworthy< at >renesas.com>.

Signed-off-by: Vladimir Barinov <vladimir.barinov< at >cogentembedded.com>
[Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id'
values, reordered rcar_vin_id_table[] entries,  removed senseless parens from
to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the
*if* statement  and  used 'bool' values instead of 0/1 where necessary, removed
unused macros, done some reformatting and clarified some comments.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov< at >cogentembedded.com>

---
This patch is against the 'media_tree.git' repo.
It requires two following patches from Guennadi Liakhovetski:

https://patchwork.linuxtv.org/patch/18209/
https://patchwork.linuxtv.org/patch/18210/

Changes since version 5:
- handled subdevice's inability to support cropping;
- set the field format depending on a video

Re: [PATCH v2 04/11] pwm: Add Renesas TPU PWM driver

Thierry Reding — 2013-05-23T21:45:17

Sorry for taking so long to look at this...


If the driver can be built, it'd be good to include a short sentence
saying what it will be called, just like for the other drivers.

[...]

I don't think you need this. The pwm_device.hwpwm field carries the same
information.


Can't you reuse the infrastructure built into the PWM subsystem? You can
associate chip-specific data with each PWM device. You can look at the
pwm-atmel-tcb and pwm-bfin drivers for usage examples. In a nutshell you
hook the .request() function and setup the driver-specific structure and
associate them with the PWM using pwm_set_chip_data().

This has the advantage that you don't need the pwms array in tpu_device
and you also don't need TPU_CHANNEL_MAX because only the pwm_chip.npwm
field needs to contain the number of channels.


Can you please stick to the standard coding style for block comments?
That is:

/*
 * Make sure...
 * ...
 * glitches.
 */


I find these separators more distracting than helpful. But if you have a
strong

[PATCH v5] V4L2: I2C: ML86V7667 video decoder driver

Sergei Shtylyov — 2013-05-23T20:07:32

From: Vladimir Barinov <vladimir.barinov< at >cogentembedded.com>

Add OKI Semiconductor ML86V7667 video decoder driver.

Signed-off-by: Vladimir Barinov <vladimir.barinov< at >cogentembedded.com>
[Sergei: added v4l2_device_unregister_subdev() call to the error cleanup path of
ml86v7667_probe(); some cleanup.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov< at >cogentembedded.com>

---
This patch is against the 'media_tree.git' repo.

Changes since version 4:
- set the field format independent of a video standard in try_mbus_fmt() method;
- removed ml86v7667_g_mbus_fmt(), ml86v7667_g_mbus_fmt(), and the 'fmt'  field
  from 'struct ml86v7667_priv', and so use ml86v7667_try_mbus_fmt() to implement
  both g_mbus_fmt() and s_mbus_fmt() methods;
- removed cropcap() method;
- removed permission check from g_register() and s_register() methods.

Changes since version 3:
- set the field format depending on video standard in try_mbus_fmt() method;
- refreshed the patch.

Changes since version 2:
- removed now unused #include;
- fi

Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()

Thierry Reding — 2013-05-23T19:12:17

I'd rather take this through the PWM tree along with the original driver
patch.

Thierry