gmane.linux.ports.parisc

[PATCH] parisc/superio: Use module_pci_driver to register driver

Peter Huewe — 2013-05-20T20:56:45

Removing some boilerplate by using module_pci_driver instead of calling
register and unregister in the otherwise empty init/exit functions.

Signed-off-by: Peter Huewe <peterhuewe< at >gmx.de>
---
 drivers/parisc/superio.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c
index ac6e8e7..a042d06 100644
--- a/drivers/parisc/superio.c
+++ b/drivers/parisc/superio.c
< at >< at > -494,15 +494,4 < at >< at > static struct pci_driver superio_driver = {
 .probe =        superio_probe,
 };
 
-static int __init superio_modinit(void)
-{
-return pci_register_driver(&superio_driver);
-}
-
-static void __exit superio_exit(void)
-{
-pci_unregister_driver(&superio_driver);
-}

[PATCH] parisc: make interrupt and interruption stack allocation reentrant

John David Anglin — 2013-05-20T16:42:53

The get_stack_use_cr30 and get_stack_use_r30 macros allocate a stack  
frame for external
interrupts and interruptions requiring a stack frame.  They are  
currently not reentrant in that
they save register context before the stack is set or adjusted.

I have observed a number of system crashes where there was clear  
evidence of stack corruption
during interrupt processing, and as a result register corruption.   
Some interruptions can still occur
during interruption processing, however external interrupts are  
disabled and data TLB misses
don't occur for absolute accesses.  So, it's not entirely clear what  
triggers this issue.  Also, if an
interruption occurs when Q=0, it is generally not possible to recover  
as the shadowed registers
are not copied.

The attached patch reworks the get_stack_use_cr30 and  
get_stack_use_r30 macros to allocate
stack before doing register saves.  The new code is a couple of  
instructions shorter than the old
implementation.  Thus, it's an improvement even if it doesn't

[PATCH] parisc: use arch_spinlock_t instead of raw_spinlock_t in irqstacks

Helge Deller — 2013-05-18T22:21:13

We need to use arch_spinlock_t spinlocks instead of raw_spinlock_t
spinlocks for irqstack protection else we will hit the "trylock failure
on UP" error message with CONFIG_SMP=n and CONFIG_DEBUG_SPINLOCK=y.

Since we can be called recursive here even on UP (we are in the irq
handler which handles even irq bh) this spinlock error message is just
wrong.

Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/include/asm/processor.h b/arch/parisc/include/asm/processor.h
index cfbc439..b2dca96 100644
--- a/arch/parisc/include/asm/processor.h
+++ b/arch/parisc/include/asm/processor.h
< at >< at > -69,7 +69,7 < at >< at >
 
 union irq_stack_union {
 unsigned long stack[IRQ_STACK_SIZE/sizeof(unsigned long)];
-raw_spinlock_t lock;
+arch_spinlock_t lock;
 };
 
 DECLARE_PER_CPU(union irq_stack_union, irq_stack_union);
diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c
index 55237a7..9ba8e5a 100644
--- a/arch/parisc/kernel/irq.c
+++ b/arch/parisc/kernel/irq.c
< at >< at > -443,14 +451,14 < at >< at > panic_check:
 
 #ifdef CON

Re: [PATCH] parisc: avoid WARNING: at kernel/cpu/idle.c:96

Helge Deller — 2013-05-18T19:40:55

Thanks Srivatsa!

I can push it through the parisc tree if nobody objects...

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] parisc: show number of FPE and unaligned access handler calls in /proc/interrupts

Helge Deller — 2013-05-18T19:35:44

Show number of floating point assistant and unaligned access fixup
handler in /proc/interrupts file. 

Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/include/asm/hardirq.h b/arch/parisc/include/asm/hardirq.h
index c19f713..4c6dd8d 100644
--- a/arch/parisc/include/asm/hardirq.h
+++ b/arch/parisc/include/asm/hardirq.h
< at >< at > -28,6 +28,8 < at >< at > typedef struct {
 unsigned int irq_resched_count;
 unsigned int irq_call_count;
 #endif
+unsigned int irq_unaligned_count;
+unsigned int irq_fpassist_count;
 unsigned int irq_tlb_count;
 } ____cacheline_aligned irq_cpustat_t;
 
diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c
index 55237a7..9c2d953 100644
--- a/arch/parisc/kernel/irq.c
+++ b/arch/parisc/kernel/irq.c
< at >< at > -188,6 +188,14 < at >< at > int arch_show_interrupts(struct seq_file *p, int prec)
 seq_printf(p, "%10u ", irq_stats(j)->irq_call_count);
 seq_puts(p, "  Function call interrupts\n");
 #endif
+seq_printf(p, "%*s: ", prec, "UAH");
+for_each_online_cpu(j)
+seq_printf(p, "%10u

Re: parisc boot crash on 3.10-rc1+git

Helge Deller — 2013-05-17T20:15:55

I'm not sure any more, that DISCONTIGMEM is buggy... still need more testing on this.


Just as a heads-up.

I was able to build a stable kernel (3.10-rc1 based + patches).
Dave and me still have at least two patches which made my kernel stable.
With those, I was now able to boot, install and fully upgrade to debian-unstable on my rp5470 (4xPA8700 CPUs).
In the config I used CONFIG_SMP=y (CONFIG_SMP=n crashed!), CONFIG_DISCONTIGMEM=n and CONFIG_PREEMPT=n. 
My config is attached to this mail. 
So, please stay tuned, I'm still working on getting further patches into 3.10.

And, maybe we get to a point, where we can provide new installation-medias....

Helge
#
# Automatically generated file; DO NOT EDIT.
# Linux/parisc 3.10.0-rc1 Kernel Configuration
#
CONFIG_PARISC=y
CONFIG_MMU=y
CONFIG_STACK_GROWSUP=y
CONFIG_RWSEM_GENERIC_SPINLOCK=y
# CONFIG_ARCH_HAS_ILOG2_U32 is not set
# CONFIG_ARCH_HAS_ILOG2_U64 is not set
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_TIME_LOW_RES=y

Re: [PATCH] parisc: avoid WARNING: at kernel/cpu/idle.c:96

Srivatsa S. Bhat — 2013-05-17T19:25:47

This patch looks like the correct fix to me.

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat< at >linux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat


--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] parisc: make default cross compiler search more robust

Greg KH — 2013-05-17T18:25:37

I prefer to take the original upstream patches, so I've just applied
both of these, instead of your merge.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] parisc: avoid WARNING: at kernel/cpu/idle.c:96

James Bottomley — 2013-05-17T06:25:35

Ping on this, please, Thomas ... the patch looks fairly obviously
correct, do you just want us to take it through the parisc tree?

James





--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] parisc: add additional parisc git tree to MAINTAINERS file

Helge Deller — 2013-05-16T21:00:16

Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/MAINTAINERS b/MAINTAINERS
index 3d7782b..c0aab68 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
< at >< at > -6069,6 +6069,7 < at >< at > L:linux-parisc< at >vger.kernel.org
 W:http://www.parisc-linux.org/
 Q:http://patchwork.kernel.org/project/linux-parisc/list/
 T:git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/parisc-2.6.git
+T:git git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git
 S:Maintained
 F:arch/parisc/
 F:drivers/parisc/
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] parisc: use PAGE_SHIFT instead of hardcoded value 12 in pacache.S

Helge Deller — 2013-05-16T20:51:41

additionally clean up some whitespaces & tabs.

Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/kernel/pacache.S b/arch/parisc/kernel/pacache.S
index 5e1de60..36d7f40 100644
--- a/arch/parisc/kernel/pacache.S
+++ b/arch/parisc/kernel/pacache.S
< at >< at > -605,14 +605,14 < at >< at > ENTRY(copy_user_page_asm)
 convert_phys_for_tlb_insert20 %r26/* convert phys addr to tlb insert format */
 convert_phys_for_tlb_insert20 %r23/* convert phys addr to tlb insert format */
 depd%r24,63,22, %r28/* Form aliased virtual address 'to' */
-depdi0, 63,PAGE_SHIFT, %r28  /* Clear any offset bits */
+depdi0, 63,PAGE_SHIFT, %r28/* Clear any offset bits */
 copy%r28, %r29
 depdi1, 41,1, %r29/* Form aliased virtual address 'from' */
 #else
 extrw,u%r26, 24,25, %r26/* convert phys addr to tlb insert format */
 extrw,u%r23, 24,25, %r23/* convert phys addr to tlb insert format */
 depw%r24, 31,22, %r28/* Form aliased virtual address 'to' */
-depwi0, 31,12, %r28/* Clear any offset bits */

[PATCH] parisc: add rp5470 entry to machine database

Helge Deller — 2013-05-16T20:42:39

Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/kernel/hardware.c b/arch/parisc/kernel/hardware.c
index f7752f6..9e2d2e4 100644
--- a/arch/parisc/kernel/hardware.c
+++ b/arch/parisc/kernel/hardware.c
< at >< at > -222,6 +222,7 < at >< at > static struct hp_hardware hp_hardware_list[] = {
 {HPHW_NPROC,0x5DD,0x4,0x81,"Duet W2"},
 {HPHW_NPROC,0x5DE,0x4,0x81,"Piccolo W+"},
 {HPHW_NPROC,0x5DF,0x4,0x81,"Cantata W2"},
+{HPHW_NPROC,0x5DF,0x0,0x00,"Marcato W+? (rp5470)"},
 {HPHW_NPROC,0x5E0,0x4,0x91,"Cantata DC- W2"},
 {HPHW_NPROC,0x5E1,0x4,0x91,"Crescendo DC- W2"},
 {HPHW_NPROC,0x5E2,0x4,0x91,"Crescendo 650 W2"},
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] parisc: use long branch in fork_like macro

Helge Deller — 2013-05-16T19:28:12

please add to stable kernel v3.9
upstream commit bbbfde782084b4f0d85ddffb88f1cf4650ff40e4

From: John David Anglin <dave.anglin< at >bell.net>

The "b" branch instruction used in the fork_like macro only can handle
17-bit pc-relative offsets.
This fails with an out of range offset with some .config files.
Rewrite to use the "be" instruction which
can branch to any address in a space.

Signed-off-by: John David Anglin  <dave.anglin< at >bell.net>
Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S
index aa486e4..36f4f1d 100644
--- a/arch/parisc/kernel/entry.S
+++ b/arch/parisc/kernel/entry.S
< at >< at > -1702,7 +1702,8 < at >< at > ENTRY(sys_\name\()_wrapper)
 ldoTASK_REGS(%r1),%r1
 reg_save %r1
 mfctl%cr27, %r28
-bsys_\name
+ldilL%sys_\name, %r31
+beR%sys_\name(%sr4,%r31)
 STREG%r28, PT_CR27(%r1)
 ENDPROC(sys_\name\()_wrapper)
 .endm

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org

[PATCH] parisc: fix SMP races when updating PTE and TLB entries in entry.S

Helge Deller — 2013-05-16T19:25:28

please add to stable kernel v3.9
upstream commit f0a18819e261afc5fdbd8c5c6f9943123c5461ba

From: John David Anglin <dave.anglin< at >bell.net>

Currently, race conditions exist in the handling of TLB interruptions in
entry.S.  In particular, dirty bit updates can be lost if an accessed
interruption occurs just after the dirty bit interruption on a different
cpu.  Lost dirty bit updates result in user pages not being flushed and
general system instability.  This change adds lock and unlock macros to
synchronize all PTE and TLB updates done in entry.S.  As a result,
userspace stability is significantly improved.

Signed-off-by: John David Anglin  <dave.anglin< at >bell.net>
Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S
index 4bb96ad..ae27cb6 100644
--- a/arch/parisc/kernel/entry.S
+++ b/arch/parisc/kernel/entry.S
< at >< at > -452,9 +452,41 < at >< at >
 L2_ptep\pgd,\pte,\index,\va,\fault
 .endm
 
+/* Acquire pa_dbit_lock lock. */
+.macrodbit_lockspc,tmp,tmp1
+#if

[PATCH] parisc: only re-enable interrupts if we need to schedule or deliver signals when returning to userspace

Helge Deller — 2013-05-16T19:22:20

please include to stable kernel v3.9 series.
upstream commit c207a76bf155cb5cf24cf849c08f6555e9180594

From: John David Anglin <dave.anglin< at >bell.net>

Helge and I have found that we have a kernel stack overflow problem
which causes a variety of random failures.  Currently, we re-enable
interrupts when returning from an external interrupt incase we need to
schedule or delivery signals.  As a result, a potentially unlimited
number of interrupts can occur while we are running on the kernel stack.
It is very limited in space (currently, 16k).  This change defers
enabling interrupts until we have actually decided to schedule or
delivery signals.  This only occurs when we about to return to
userspace.  This limits the number of interrupts on the kernel stack to
one.  In other cases, interrupts remain disabled until the final return
from interrupt (rfi).

Signed-off-by: John David Anglin  <dave.anglin< at >bell.net>
Signed-off-by: Helge Deller <deller< at >gmx.de>

diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel

Re: parisc boot crash on 3.10-rc1+git

Meelis Roos — 2013-05-16T12:23:02

I took 3.10-rc1+git with the batch of hppa changes: 
v3.10-rc1-87-g674825d

[    0.000000] Memory Ranges:
[    0.000000]  0) Start 0x0000000000000000 End 0x000000003fffffff Size   1024 MB
[    0.000000]  1) Start 0x0000004040000000 End 0x000000407fdfffff Size   1022 MB

.config was already on the list, there are

CONFIG_IRQSTACKS=y
CONFIG_ARCH_SELECT_MEMORY_MODEL=y
CONFIG_ARCH_DISCONTIGMEM_ENABLE=y
CONFIG_ARCH_FLATMEM_ENABLE=y
CONFIG_ARCH_DISCONTIGMEM_DEFAULT=y
CONFIG_NODES_SHIFT=3
CONFIG_PREEMPT_NONE=y
# CONFIG_PREEMPT_VOLUNTARY is not set
# CONFIG_PREEMPT is not set
CONFIG_PREEMPT_COUNT=y

CONFIG_DISCONTIGMEM_MANUAL=y
CONFIG_DISCONTIGMEM=y

Re: parisc boot crash on 3.10-rc1+git

John David Anglin — 2013-05-16T12:15:07



3.9.0 plus all parisc changes for 3.10 runs ok on my rp3440.  Do you  
have
the three parisc patches merged after 3.10-rc1?  There's only about  
one day's
worth of commits between what I have and 3.10-rc1.

I have CONFIG_DISCONTIGMEM set.

Memory Ranges:
  0) Start 0x0000000000000000 End 0x000000003fffffff Size   1024 MB
  1) Start 0x0000000100000000 End 0x00000001ffdfffff Size   4094 MB
  2) Start 0x0000004040000000 End 0x00000040ffffffff Size   3072 MB
Total Memory: 8190 MB

--
John David Anglindave.anglin< at >bell.net



--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: parisc boot crash on 3.10-rc1+git

Rolf Eike Beer — 2013-05-16T08:38:33

Am Mittwoch 15 Mai 2013, 18:32:34 schrieb John David Anglin:

The C8000 has discontigmem. I can easily see if it is working or not: if I 
only have 1GB of RAM available it doesn't work. But I have all 2GB of RAM 
available.

Eike

Re: parisc boot crash on 3.10-rc1+git

Meelis Roos — 2013-05-16T06:35:00

My RP3440 runs 3.9.0 fine, with mostly the same config as I sent (modulo 
the new questions).

Debian was becoming too hard so I switched to Gentoo on parisc and so 
far it has been fine. But to bootstrap Gentoo, I had to use old Debian 
so no ext4, just ext3.

Re: parisc boot crash on 3.10-rc1+git

John David Anglin — 2013-05-15T22:32:34



I suspect that you actually have to have discontiguous memory to  
trigger the bug.

Dave
--
John David Anglindave.anglin< at >bell.net



--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: parisc boot crash on 3.10-rc1+git

Rolf Eike Beer — 2013-05-15T19:34:44

Am Mittwoch 15 Mai 2013, 20:16:21 schrieb Helge Deller:

My C8000 runs 3.7.3 happily, so it must have happened after that.

Eike