gmane.linux.ltp

Re: Regarding LTP contribution

Garrett Cooper — 2013-05-18T11:48:27


Hi jungsoo son!
    I recommend following up on ltp-list requesting these details. Also, these details should be updated in any documentation attached to the project (I think there's some IIRC).
Cheers!
-Garrett------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d_______________________________________________
Ltp-list mailing list
Ltp-list-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f< at >public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [PATCH] mount/mount03.c: Add mode argument to open call.

Wanlong Gao — 2013-05-18T00:40:46

Applied, thank you.

Wanlong Gao


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Ltp-list mailing list
Ltp-list< at >lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[PATCH] mount/mount03.c: Add mode argument to open call.

Vinson Lee — 2013-05-17T18:56:46

From: Vinson Lee <vlee< at >twitter.com>

This patch fixes this build error on Ubuntu introduced with commit
24324ad5dae71172125060b82580486b0f3d37da.

In file included from /usr/include/fcntl.h:252:0,
                 from mount03.c:73:
In function ‘open’,
    inlined from ‘setup’ at mount03.c:447:5:
/usr/include/x86_64-linux-gnu/bits/fcntl2.h:51:24: error: call to ‘__open_missing_mode’ declared with attribute error: open with O_CREAT in second argument needs 3 arguments

Signed-off-by: Vinson Lee <vlee< at >twitter.com>
---
 testcases/kernel/syscalls/mount/mount03.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/mount/mount03.c b/testcases/kernel/syscalls/mount/mount03.c
index 295b6da..b1aa71f 100644
--- a/testcases/kernel/syscalls/mount/mount03.c
+++ b/testcases/kernel/syscalls/mount/mount03.c
< at >< at > -444,7 +444,7 < at >< at > void setup()
  path_name, DIR_MODE);
 
 snprintf(file, PATH_MAX, "%s/setuid_test", path_name);
-fd = open(file, O_CREAT | O_TRUNC);
+fd =

Re: [PATCH 2/2] waitid02: split code into separate testcases

Wanlong Gao — 2013-05-17T09:39:21

Acked-by: Wanlong Gao <gaowanlong-BthXqXjhjHXQFUHtdCDX3A< at >public.gmane.org>



------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH 1/2] waitid02: cleanup

Wanlong Gao — 2013-05-17T09:39:07

Acked-by: Wanlong Gao <gaowanlong-BthXqXjhjHXQFUHtdCDX3A< at >public.gmane.org>



------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

[PATCH 1/2] waitid02: cleanup

Jan Stancek — 2013-05-17T08:59:21

Remove useless comments, convert spaces to tabs
and fix long lines.

Signed-off-by: Jan Stancek <jstancek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
---
 testcases/kernel/syscalls/waitid/waitid02.c |  104 +++++++++------------------
 1 files changed, 33 insertions(+), 71 deletions(-)

diff --git a/testcases/kernel/syscalls/waitid/waitid02.c b/testcases/kernel/syscalls/waitid/waitid02.c
index 98bf3ea..e265c32 100644
--- a/testcases/kernel/syscalls/waitid/waitid02.c
+++ b/testcases/kernel/syscalls/waitid/waitid02.c
< at >< at > -11,9 +11,9 < at >< at >
 /* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See                  */
 /* the GNU General Public License for more details.                           */
 /*                                                                            */
-/* You should have received a copy of the GNU General Public License          */
-/* along with this program;  if not, write to the Free Software               */
-/* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 U

[PATCH 2/2] waitid02: split code into separate testcases

Jan Stancek — 2013-05-17T08:59:22

Previous code in main was:
- using sleep for synchronization
  The sleep make take longer if run in overcommitted
  z/VM environment with considerably high steal time, which
  causes testcase to hang.
- missing wait for last child

This patch splits code from main() into separate testcases,
each with its own setup/cleanup and expected outcome.

Signed-off-by: Jan Stancek <jstancek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>
---
 testcases/kernel/syscalls/waitid/waitid02.c |  361 +++++++++++++++++----------
 1 files changed, 230 insertions(+), 131 deletions(-)

diff --git a/testcases/kernel/syscalls/waitid/waitid02.c b/testcases/kernel/syscalls/waitid/waitid02.c
index e265c32..bd5a13c 100644
--- a/testcases/kernel/syscalls/waitid/waitid02.c
+++ b/testcases/kernel/syscalls/waitid/waitid02.c
< at >< at > -50,31 +50,246 < at >< at >
 #include "usctest.h"
 #include "linux_syscall_numbers.h"
 
+struct testcase_t {
+const char *msg;
+idtype_t idtype;
+id_t id;
+pid_t child;
+int options;
+int exp_ret;
+int exp_errno;
+int pipefd[

Re: [PATCH 1/2] shmat/shmat01.c: cleanup

Wanlong Gao — 2013-05-17T07:24:23

Applied, thank you.

Wanlong Gao


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH V2 2/2] shmat/shmat01.c: Test for specifying NULL to shmaddr

Wanlong Gao — 2013-05-17T07:24:06

Applied, thank you.

Wanlong Gao


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH] mem.c: check whether MADV_MERGEABLE is available

Wanlong Gao — 2013-05-17T07:23:44

Applied, thank you.

Wanlong Gao


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH V2 2/2] shmat/shmat01.c: Test for specifying NULL to shmaddr

Jan Stancek — 2013-05-17T07:06:46


----- Original Message -----

V2 looks good to me, applies cleanly, tested on x86_64.

Reviewed-by: Jan Stancek <jstancek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH] mem.c: check whether MADV_MERGEABLE is available

Jan Stancek — 2013-05-17T06:52:14


----- Original Message -----

Small and straightforward change.

Reviewed-by: Jan Stancek <jstancek-H+wXaHxf7aLQT0dZR+AlfA< at >public.gmane.org>


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

[PATCH V2 2/2] shmat/shmat01.c: Test for specifying NULL to shmaddr

DAN LI — 2013-05-17T05:39:32

Test for statement:
"If shmaddr is NULL, the system chooses a suitable (unused) address
at which to attach the segment."

Signed-off-by: DAN LI <li.dan-BthXqXjhjHXQFUHtdCDX3A< at >public.gmane.org>
---
 testcases/kernel/syscalls/ipc/shmat/shmat01.c | 60 +++++++++++++++++----------
 1 file changed, 38 insertions(+), 22 deletions(-)

diff --git a/testcases/kernel/syscalls/ipc/shmat/shmat01.c b/testcases/kernel/syscalls/ipc/shmat/shmat01.c
index 3461782..3c09817 100644
--- a/testcases/kernel/syscalls/ipc/shmat/shmat01.c
+++ b/testcases/kernel/syscalls/ipc/shmat/shmat01.c
< at >< at > -46,7 +46,7 < at >< at >
 #define CASE120

 char *TCID = "shmat01";
-int TST_TOTAL = 3;
+int TST_TOTAL = 4;

 int shm_id_1 = -1;

< at >< at > -62,6 +62,7 < at >< at > static struct test_case_t {
 int *shmid;
 int offset;
 int flags;
+int getbase;
 } *TC;

 static void check_functionality(int);
< at >< at > -70,6 +71,7 < at >< at > int main(int argc, char *argv[])
 {
 int lc, i;
 char *msg;
+void *attchaddr;

 msg = parse_opts(argc, argv, NULL, NULL);
 if (msg != NULL)
< at >< at > -83,12 +85,

[PATCH] mem.c: check whether MADV_MERGEABLE is available

DAN LI — 2013-05-17T02:32:16

Before using MADV_MERGEABLE, check whether it's available by macro
HAVE_MADV_MERGEABLE.

Signed-off-by: DAN LI <li.dan-BthXqXjhjHXQFUHtdCDX3A< at >public.gmane.org>
---
 testcases/kernel/mem/lib/mem.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
index 7cda3c5..9bc926e 100644
--- a/testcases/kernel/mem/lib/mem.c
+++ b/testcases/kernel/mem/lib/mem.c
< at >< at > -494,8 +494,10 < at >< at > void test_ksm_merge_across_nodes(unsigned long nr_pages)
     MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
 if (memory[i] == MAP_FAILED)
 tst_brkm(TBROK|TERRNO, tst_exit, "mmap");
+#ifdef HAVE_MADV_MERGEABLE
 if (madvise(memory[i], length, MADV_MERGEABLE) == -1)
 tst_brkm(TBROK|TERRNO, tst_exit, "madvise");
+#endif

 #if HAVE_NUMA_H && HAVE_LINUX_MEMPOLICY_H && HAVE_NUMAIF_H \
 && HAVE_MPOL_CONSTANTS

[PATCH] Create a function tst_resm_hexd to print a buffer inhex values

Alexey Kodanev — 2013-05-16T12:20:11

Signed-off-by: Alexey Kodanev <alexey.kodanev-QHcLZuEGTsvQT0dZR+AlfA< at >public.gmane.org>
---
 include/test.h |    2 ++
 lib/tst_res.c  |   34 ++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 0 deletions(-)

diff --git a/include/test.h b/include/test.h
index e36ca38..17b8e39 100644
--- a/include/test.h
+++ b/include/test.h
< at >< at > -191,6 +191,8 < at >< at > void tst_res(int ttype, char *fname, char *arg_fmt, ...)
 __attribute__ ((format (printf, 3, 4)));
 void tst_resm(int ttype, char *arg_fmt, ...)
 __attribute__ ((format (printf, 2, 3)));
+void tst_resm_hexd(int ttype, const char *buf, size_t size, char *arg_fmt, ...)
+__attribute__ ((format (printf, 4, 5)));
 void tst_brk(int ttype, char *fname, void (*func)(void), char *arg_fmt, ...)
 __attribute__ ((format (printf, 4, 5)));
 void tst_brkm(int ttype, void (*func)(void), char *arg_fmt, ...)
diff --git a/lib/tst_res.c b/lib/tst_res.c
index ffac6d7..e7c9d5d 100644
--- a/lib/tst_res.c
+++ b/lib/tst_res.c
< at >< at > -675,6 +675,40 < at >< at > void tst_resm(int ttype,

Re: [PATCH] New core test of cgroups and extended attributes

2013-05-16T10:06:41

Hi!

Sounds good.

Re: [PATCH] New core test of cgroups and extended attributes

2013-05-16T09:36:07

On 05/16/2013 12:39 PM, chrubis-AlSwsSmVLrQ< at >public.gmane.org wrote:
tst_resm_hexd()? to make name similar to hexdump and od utilities.

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH] New core test of cgroups and extended attributes

2013-05-16T08:39:24

Hi!

Naming things right is hard. I agree that 'hex' should be part of the
name but ideally something like 'dump' or 'buf' should be there as well
at least in form of the first letter (to keep the name reasonably short).

tst_resm_bhex() or tst_resm_dhex() ?

Re: [PATCH 2/2] shmat/shmat01.c: Test for specifying NULLtoshmaddr

Jan Stancek — 2013-05-16T07:23:56


----- Original Message -----

Hi,

I'd suggest adding a field to test_case_t, which would tell if you need probe_free_addr()
or NULL, so you don't need to check for specific testcase number.


Since case 0 and case 1 are the same, I'd suggest making it as fallthrough.


It's not directly visible in patch, but case 2 is now using TC[1].

Comments don't match case numbers, both case 0 and case 1 say now "first call",
I would drop that numbering in comments.

Regards,
Jan


------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

Re: [PATCH] New core test of cgroups and extended attributes

2013-05-16T06:58:19

Hi!

On 05/15/2013 06:56 PM, chrubis-AlSwsSmVLrQ< at >public.gmane.org wrote:
Since we're going to print buf in hex, may be we can use
tst_resm_hex(flags, buf, buf_len, fmt, ...) to make it more descriptive?

Thanks,
Alexey

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d

[PATCH] prot_hsymlinks.c: remove the unnecessary calling of cleanup

DAN LI — 2013-05-16T06:08:37

Should not call cleanup here since nothing was setted by setup.

Signed-off-by: DAN LI <li.dan-BthXqXjhjHXQFUHtdCDX3A< at >public.gmane.org>
---
 testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
b/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
index 1eec0f9..82bc770 100644
--- a/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
+++ b/testcases/kernel/security/prot_hsymlinks/prot_hsymlinks.c
< at >< at > -196,10 +196,9 < at >< at > static void setup(int argc, char *argv[])

 tst_require_root(NULL);

-if (tst_kvercmp(3, 7, 0) < 0) {
-tst_brkm(TCONF, cleanup,
+if (tst_kvercmp(3, 7, 0) < 0)
+tst_brkm(TCONF, NULL,
 "Test must be run with kernel 3.7 or newer");
-}

 /* initialize user names */
 strcpy(users[ROOT].name, "root");