gmane.linux.kernel.wireless.general

Re: [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211

Oleksij Rempel — 2013-05-24T11:35:24

Am 24.05.2013 12:18, schrieb Oleksij Rempel:

comment for my self. i forgot to include <net/ieee80211_radiotap.h>
for IEEE80211_RADIOTAP_MCS_HAVE_STBC. This patch is broken.

Re: [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211

Oleksij Rempel — 2013-05-24T10:32:46

Am 24.05.2013 12:29, schrieb Johannes Berg:

They support STBC but don't report it. First device whhic can report it 
is ar9280.

Re: [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211

Johannes Berg — 2013-05-24T10:29:59

Are you sure this is right? It seems that if other devices don't support
STBC they can report all frames to be w/o STBC. Or do they support STBC
but don't report it?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211

Oleksij Rempel — 2013-05-24T10:18:31

Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
---
 drivers/net/wireless/ath/ath9k/init.c | 9 +++++++--
 drivers/net/wireless/ath/ath9k/mac.c  | 5 +++++
 drivers/net/wireless/ath/ath9k/mac.h  | 3 ++-
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index aba4151..7739b05 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
< at >< at > -769,8 +769,13 < at >< at > void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
 IEEE80211_HW_REPORTS_TX_ACK_STATUS |
 IEEE80211_HW_SUPPORTS_RC_TABLE;
 
-if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT)
- hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
+if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_HT) {
+hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
+
+if (AR_SREV_9280_20_OR_LATER(ah))
+hw->radiotap_mcs_details |=
+IEEE80211_RADIOTAP_MCS_HAVE_STBC;
+}
 
 if (AR_SREV_9160_10_OR_LATER(sc->sc_ah) || ath9

[PATCH 1/2] ath9k: remove useless flag conversation.

Oleksij Rempel — 2013-05-24T10:18:30

some flags used only outside of ath9k - In this case we can use
"enum mac80211_rx_flags" and pass it upstream without extra
conversation.

Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
---
 drivers/net/wireless/ath/ath9k/ar9003_mac.c |  5 +++--
 drivers/net/wireless/ath/ath9k/mac.c        | 11 +++++++----
 drivers/net/wireless/ath/ath9k/mac.h        |  1 +
 drivers/net/wireless/ath/ath9k/recv.c       |  5 +----
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mac.c b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
index 301bf72..5163abd 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
< at >< at > -469,6 +469,7 < at >< at > int ath9k_hw_process_rxdesc_edma(struct ath_hw *ah, struct ath_rx_status *rxs,
 
 rxs->rs_status = 0;
 rxs->rs_flags =  0;
+rxs->flag =  0;
 
 rxs->rs_datalen = rxsp->status2 & AR_DataLen;
 rxs->rs_tstamp =  rxsp->status3;
< at >< at > -493,8 +494,8 < at >< at > int ath9k_hw_process_r

[PATCH 0/2] ath9k: STBC Rx monitoring

Oleksij Rempel — 2013-05-24T10:18:29

this are two remaining patches to allow STBC Rx monitoring
on ath9k devices.
This patches depend on currently applied:
[PATCH v4 1/3] mac80211: add STBC flag for radiotap

Oleksij Rempel (2):
  ath9k: remove useless flag conversation.
  ath9k: check for Rx-STBC flag and pass it to ieee80211

 drivers/net/wireless/ath/ath9k/ar9003_mac.c |  5 +++--
 drivers/net/wireless/ath/ath9k/init.c       |  9 +++++++--
 drivers/net/wireless/ath/ath9k/mac.c        | 16 ++++++++++++----
 drivers/net/wireless/ath/ath9k/mac.h        |  4 +++-
 drivers/net/wireless/ath/ath9k/recv.c       |  5 +----
 5 files changed, 26 insertions(+), 13 deletions(-)

Re: [PATCH v4 1/3] mac80211: add STBC flag for radiotap

Oleksij Rempel — 2013-05-24T10:11:03

Am 24.05.2013 12:08, schrieb Johannes Berg:

thank you.

Re: [PATCH v4 1/3] mac80211: add STBC flag for radiotap

Johannes Berg — 2013-05-24T10:08:08

Applied, thanks.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 1/3] mac80211: add STBC flag for radiotap

Oleksij Rempel — 2013-05-24T10:05:45

Some chips can tell us if received frame was
encoded with STBC or not. To make this information available
in user space we can use updated radiotap specification:
http://www.radiotap.org/defined-fields/MCS

This patch will set number of STBC encoded spatial streams (Nss).
The HAVE_STBC flag should be provided by driver.

Signed-off-by: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw< at >public.gmane.org>
---
 include/net/ieee80211_radiotap.h | 7 +++++++
 include/net/mac80211.h           | 4 ++++
 net/mac80211/rx.c                | 4 ++++
 3 files changed, 15 insertions(+)

diff --git a/include/net/ieee80211_radiotap.h b/include/net/ieee80211_radiotap.h
index c399963..c6d07cb 100644
--- a/include/net/ieee80211_radiotap.h
+++ b/include/net/ieee80211_radiotap.h
< at >< at > -269,6 +269,7 < at >< at > enum ieee80211_radiotap_type {
 #define IEEE80211_RADIOTAP_MCS_HAVE_GI0x04
 #define IEEE80211_RADIOTAP_MCS_HAVE_FMT0x08
 #define IEEE80211_RADIOTAP_MCS_HAVE_FEC0x10
+#define IEEE80211_RADIOTAP_MCS_HAVE_STBC0x20
 
 #define IEEE80211_RA

[PATCH] mwl8k: Fix the firmware hang issue for 8764

Nishant Sarmukadam — 2013-05-24T09:12:25

The firmware hang issue is not seen very often,
though it is still seen sometimes (once in 12
hours in local tests). The changes in the driver
,to interrupt the firmware, are needed when we
detect that firmware is stuck and when the host
queues are full and we begin to drop packets.
This is to ensure that the firmware does not
miss any PPA_RDY interrupts to cause the firmware
restart dont miss PPA_READY interrupt for SC2

Signed-off-by: Nishant Sarmukadam <nishants-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
Signed-off-by: Yogesh Ashok Powar <yogeshp-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
---
 drivers/net/wireless/mwl8k.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 6820fce..a3707fd 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
< at >< at > -1548,7 +1548,7 < at >< at > static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
 if (!priv->pending_tx_pkts)
 return 0;
 
-retry = 0;
+retry = 1;
 rc

Re: skb_under_panic in ath9k

Marc Kleine-Budde — 2013-05-24T08:47:23

added ath9k-devel to Cc

On 05/23/2013 12:02 AM, Marc Kleine-Budde wrote:

Cross compilation compat-wireless in kernel-2.6.35 for powerpc

Suman Pandit — 2013-05-24T06:24:46

"WARNING: CONFIG_CFG80211_WEXT will be deactivated or not working because
kernel was compiled with CONFIG_WIRELESS_EXT=n. Tools using wext interface
like iwconfig will not work. To activate it build your kernel e.g. with
CONFIG_LIBIPW=m."
./scripts/gen-compat-autoconf.sh config.mk > include/linux/compat_autoconf.h


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: ath9k_htc p2p finding issue

Deng, Flavian — 2013-05-24T01:46:52

Hi Arend,
Thanks for your suggestion, but it looks the ath9k_htc didn't get probe request frame. I added debug message in "ath9k_rx_tasklet()"(htc_drv_txrx.c), but no probe request frame arrived there.
After more test, it looks this issue occurred after "compat-wireless-3.6.2-1", and this issue couldn't be observed in "compat-wireless-3.5.4-1".

Do you have other suggestion for this issue?

Thanks
Flavian Deng


-----Original Message-----
From: Arend van Spriel [mailto:arend< at >broadcom.com] 
Sent: 2013年5月23日 16:13
To: Zhou, Robie
Cc: linux-wireless< at >vger.kernel.org; Deng, Flavian
Subject: Re: ath9k_htc p2p finding issue

On 05/23/2013 07:58 AM, Zhou, Robie wrote:

Did you confirm ath9k_htc is handing over probe requests to mac80211? 
Might be useful to add debugging in prepare_for_handlers() instead.

Regards,
Arend

[PATCH 3.10] mac80211: close AP_VLAN interfaces before unregistering all

Johannes Berg — 2013-05-23T23:10:08

From: Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w< at >public.gmane.org>

Since Eric's commit efe117ab8 ("Speedup ieee80211_remove_interfaces")
there's a bug in mac80211 when it unregisters with AP_VLAN interfaces
up. If the AP_VLAN interface was registered after the AP it belongs
to (which is the typical case) and then we get into this code path,
unregister_netdevice_many() will crash because it isn't prepared to
deal with interfaces being closed in the middle of it. Exactly this
happens though, because we iterate the list, find the AP master this
AP_VLAN belongs to and dev_close() the dependent VLANs. After this,
unregister_netdevice_many() won't pick up the fact that the AP_VLAN
is already down and will do it again, causing a crash.

Cc: stable-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org [2.6.33+]
Cc: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
Signed-off-by: Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w< at >public.gmane.org>
---
 net/mac80211/iface.c | 9 +++++++++
 1 file changed

RE: [PATCH v2 1/2] iw: use updated structures and enums for packet pattern

Bing Zhao — 2013-05-23T22:36:24

Hi Johannes,


OK, No hurry.

Thanks,
Bing

Re: [PATCH v2 1/2] iw: use updated structures and enums for packet pattern

Johannes Berg — 2013-05-23T22:28:12

No, no need. Just wanted to double-check. I started going through the
kernel side patches and had some comments, but I'm too tired to finish
now.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] iw: use updated structures and enums for packet pattern

Johannes Berg — 2013-05-23T21:39:17

This isn't really necessary, right? I mean, it should compile w/o this
even after the kernel patches, but this is just for making it look
nicer?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA< at >public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] iw: use updated structures and enums for packet pattern

Bing Zhao — 2013-05-23T21:35:40

From: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>

They are renamed so that they can be used for new feature.

Signed-off-by: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
Signed-off-by: Bing Zhao <bzhao-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
---
 info.c   |  2 +-
 wowlan.c | 32 ++++++++++++++++----------------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/info.c b/info.c
index 54d9a8d..d893ffc 100644
--- a/info.c
+++ b/info.c
< at >< at > -432,7 +432,7 < at >< at > broken_combination:
 [NL80211_WOWLAN_TRIG_RFKILL_RELEASE] = { .type = NLA_FLAG },
 [NL80211_WOWLAN_TRIG_TCP_CONNECTION] = { .type = NLA_NESTED },
 };
-struct nl80211_wowlan_pattern_support *pat;
+struct nl80211_pattern_support *pat;
 int err;
 
 err = nla_parse_nested(tb_wowlan, MAX_NL80211_WOWLAN_TRIG,
diff --git a/wowlan.c b/wowlan.c
index b4a2715..d323ca7 100644
--- a/wowlan.c
+++ b/wowlan.c
< at >< at > -261,11 +261,11 < at >< at > static int handle_wowlan_enable(struct nl80211_state *state, struct nl

[PATCH v2 2/2] cfg80211/nl80211: Add packet coalesce support

Bing Zhao — 2013-05-23T21:35:08

From: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>

In most cases, host that receives IPv4 and IPv6 multicast/broadcast
packets does not do anything with these packets. Therefore the
reception of these unwanted packets causes unnecessary processing
and power consumption.

Packet coalesce feature helps to reduce number of received
interrupts to host by buffering these packets in firmware/hardware
for some predefined time. Received interrupt will be generated when
one of the following events occur.
a) Expiration of hardware timer whose expiration time is set to
maximum coalescing delay of matching coalesce rule.
b) Coalescing buffer in hardware reaches it's limit.
c) Packet doesn't match any of the configured coalesce rules.

This patch adds set/get configuration support for packet coalesce.
User needs to configure following parameters for creating a coalesce
rule.
a) Maximum coalescing delay
b) List of packet patterns which needs to be matched
c) Condition for coalescence. pattern 'match

[PATCH v2 1/2] cfg80211/nl80211: rename packet pattern related structures and enums

Bing Zhao — 2013-05-23T21:35:07

From: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>

Currently packet patterns and it's enum/structures are used only
for WoWLAN feature. As we intend to reuse them for new feature
packet coalesce, they are renamed in this patch.

Older names are kept for backward compatibility purpose.

Signed-off-by: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
Signed-off-by: Bing Zhao <bzhao-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
---
v2: more details about the renames in commit log (Luis R. Rodriguez)
    don't break the API with existing applications (Johannes Berg)

 drivers/net/wireless/ath/ath9k/main.c   |  2 +-
 drivers/net/wireless/mwifiex/cfg80211.c |  3 +--
 drivers/net/wireless/ti/wlcore/main.c   | 10 ++++----
 include/net/cfg80211.h                  |  6 ++---
 include/uapi/linux/nl80211.h            | 45 ++++++++++++++++++++-------------
 net/wireless/nl80211.c                  | 34 ++++++++++++-------------
 6 files changed, 53 insertions(+), 47 deletions(-)

diff -

[PATCH v2 2/2] iw: add coalesce support

Bing Zhao — 2013-05-23T21:35:41

From: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>

User can add one coalesce rule at a time using 'iw coalesce add'
command. The settings can be cleared using 'iw coalesce disable'
command. 'iw coalesce show' displays current configuration.

Signed-off-by: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
Signed-off-by: Bing Zhao <bzhao-eYqpPyKDWXRBDgjK7y7TUQ< at >public.gmane.org>
---
 Makefile   |   2 +-
 coalesce.c | 232 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 info.c     |  14 ++++
 3 files changed, 247 insertions(+), 1 deletion(-)
 create mode 100644 coalesce.c

diff --git a/Makefile b/Makefile
index c485b5e..f042e30 100644
--- a/Makefile
+++ b/Makefile
< at >< at > -16,7 +16,7 < at >< at > OBJS = iw.o genl.o event.o info.o phy.o \
 interface.o ibss.o station.o survey.o util.o \
 mesh.o mpath.o scan.o reg.o version.o \
 reason.o status.o connect.o link.o offch.o ps.o cqm.o \
-bitrate.o wowlan.o roc.o p2p.o
+bitrate.o wowlan.o coalesce.o roc.o p2p.o
 OBJS += sect