gmane.linux.kernel.mmc

Re: [PATCH V3 00/10] mmc_of_parse() adaptations, DT support for Sheevaplugs

Jason Cooper — 2013-05-21T13:14:55

Patches 7, 9, and 10 already pulled into mvebu/dt.  You can drop those
from this series if you need to do another revision.


I happen to have one.  Unfortunately, it is currently my primary email
server, dhcp, dns, file server, and a few other irreplaceable things. :(
I *really* need to upgrade/reconfigure ...

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1

Yuvaraj Kumar C D — 2013-05-21T09:38:43

With the new eMMC5.1 spec,there is a new EXT_CSD register with
the revision number(EXT_CSD_REV) 7.This patch updates the check
for ext-csd.rev number as 7.

Signed-off-by: Alim Akhtar <alim.akthar< at >samsung.com>
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd< at >samsung.com>
---
 drivers/mmc/core/mmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 0cbd1ef..73f58e0 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
< at >< at > -293,7 +293,7 < at >< at > static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
 }
 
 card->ext_csd.rev = ext_csd[EXT_CSD_REV];
-if (card->ext_csd.rev > 6) {
+if (card->ext_csd.rev > 7) {
 pr_err("%s: unrecognised EXT_CSD revision %d\n",
 mmc_hostname(card->host), card->ext_csd.rev);
 err = -EINVAL;

Re: [PATCH V3 01/10] mmc: return mmc_of_parse() errors to caller

Ulf Hansson — 2013-05-21T07:00:09

Reviewed-by: Ulf Hansson <ulf.hansson< at >linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 10/10] ARM: Kirkwood: add DT support for Sheevaplug and Sheevaplug eSATA

Andrew Lunn — 2013-05-21T05:13:15

Acked-by: Andrew Lunn <andrew< at >lunn.ch>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 09/10] ARM: Kirkwood: Add dts files for Sheevaplug and eSATA Sheevaplug

Andrew Lunn — 2013-05-21T05:11:32

Hi Simon

Looks good

Acked-by: Andrew Lunn <andrew< at >lunn.ch>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V3 10/10] ARM: Kirkwood: add DT support for Sheevaplug and Sheevaplug eSATA

Simon Baatz — 2013-05-20T23:01:51

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 arch/arm/mach-kirkwood/Kconfig            |    7 +++++++
 arch/arm/mach-kirkwood/Makefile           |    1 +
 arch/arm/mach-kirkwood/board-dt.c         |    4 ++++
 arch/arm/mach-kirkwood/board-sheevaplug.c |   27 +++++++++++++++++++++++++++
 arch/arm/mach-kirkwood/common.h           |    5 +++++
 5 files changed, 44 insertions(+)
 create mode 100644 arch/arm/mach-kirkwood/board-sheevaplug.c

diff --git a/arch/arm/mach-kirkwood/Kconfig b/arch/arm/mach-kirkwood/Kconfig
index 7509a89..58518a2 100644
--- a/arch/arm/mach-kirkwood/Kconfig
+++ b/arch/arm/mach-kirkwood/Kconfig
< at >< at > -296,6 +296,13 < at >< at > config MACH_READYNAS_DT
   Say 'Y' here if you want your kernel to support the
   NETGEAR ReadyNAS Duo v2 using Fattened Device Tree.
 
+config MACH_SHEEVAPLUG_DT
+bool "Marvell (eSATA) SheevaPlug (Flattened Device Tree)"
+select ARCH_KIRKWOOD_DT
+help
+  Say 'Y' here if you want your kernel to support the
+  Marvell (eSATA) SheevaPlug (Flattened Device Tree).
+

[PATCH V3 09/10] ARM: Kirkwood: Add dts files for Sheevaplug and eSATA Sheevaplug

Simon Baatz — 2013-05-20T23:01:50

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 arch/arm/boot/dts/Makefile                        |    2 +
 arch/arm/boot/dts/kirkwood-sheevaplug-common.dtsi |   97 +++++++++++++++++++++
 arch/arm/boot/dts/kirkwood-sheevaplug-esata.dts   |   40 +++++++++
 arch/arm/boot/dts/kirkwood-sheevaplug.dts         |   45 ++++++++++
 4 files changed, 184 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-sheevaplug-common.dtsi
 create mode 100644 arch/arm/boot/dts/kirkwood-sheevaplug-esata.dts
 create mode 100644 arch/arm/boot/dts/kirkwood-sheevaplug.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b9f7121..e81a387 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
< at >< at > -84,6 +84,8 < at >< at > dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
 kirkwood-ns2max.dtb \
 kirkwood-ns2mini.dtb \
 kirkwood-nsa310.dtb \
+kirkwood-sheevaplug.dtb \
+kirkwood-sheevaplug-esata.dtb \
 kirkwood-topkick.dtb \
 kirkwood-ts219-6281.dtb \
 kirkwood-ts219-6282.dtb \
dif

[PATCH V3 06/10] mmc: tegra: handle mmc_of_parse() errors during probe

Simon Baatz — 2013-05-20T23:01:47

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 drivers/mmc/host/sdhci-tegra.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index e0dba74..7eb62f8 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
< at >< at > -205,7 +205,7 < at >< at > static const struct of_device_id sdhci_tegra_dt_match[] = {
 };
 MODULE_DEVICE_TABLE(of, sdhci_tegra_dt_match);
 
-static void sdhci_tegra_parse_dt(struct device *dev)
+static int sdhci_tegra_parse_dt(struct device *dev)
 {
 struct device_node *np = dev->of_node;
 struct sdhci_host *host = dev_get_drvdata(dev);
< at >< at > -213,7 +213,7 < at >< at > static void sdhci_tegra_parse_dt(struct device *dev)
 struct sdhci_tegra *tegra_host = pltfm_host->priv;
 
 tegra_host->power_gpio = of_get_named_gpio(np, "power-gpios", 0);
-mmc_of_parse(host->mmc);
+return mmc_of_parse(host->mmc);
 }
 
 static int sdhci_tegra_probe(struct platform_device *pdev)
< at >< at > -245,7 +245,9 < at >< at > static int sdh

[PATCH V3 08/10] mmc: mvsdio: use standard MMC device-tree binding parser mmc_of_parse()

Simon Baatz — 2013-05-20T23:01:49

Instead of parsing the DT binding on our own, use the standard parser
mmc_of_parse(), introduced by commit 6c56e7a.

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 drivers/mmc/host/mvsdio.c |   73 +++++++++++++++++++++++++--------------------
 1 file changed, 40 insertions(+), 33 deletions(-)

diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
index 8960fc8..edfc481 100644
--- a/drivers/mmc/host/mvsdio.c
+++ b/drivers/mmc/host/mvsdio.c
< at >< at > -35,7 +35,7 < at >< at >
 
 #define DRIVER_NAME"mvsdio"
 
-static int maxfreq = MVSD_CLOCKRATE_MAX;
+static int maxfreq;
 static int nodma;
 
 struct mvsd_host {
< at >< at > -685,7 +685,6 < at >< at > static int __init mvsd_probe(struct platform_device *pdev)
 const struct mbus_dram_target_info *dram;
 struct resource *r;
 int ret, irq;
-int gpio_card_detect, gpio_write_protect;
 struct pinctrl *pinctrl;
 
 r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
< at >< at > -718,6 +717,20 < at >< at > static int __init mvsd_probe(struct platform_device *pdev)
 if (!IS_ERR(host->clk))
 clk_prep

[PATCH V3 04/10] mmc: mxcmmc: handle mmc_of_parse() errors during probe

Simon Baatz — 2013-05-20T23:01:45

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 drivers/mmc/host/mxcmmc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
index d503635..f47546f 100644
--- a/drivers/mmc/host/mxcmmc.c
+++ b/drivers/mmc/host/mxcmmc.c
< at >< at > -1067,7 +1067,9 < at >< at > static int mxcmci_probe(struct platform_device *pdev)
 goto out_release_mem;
 }
 
-mmc_of_parse(mmc);
+ret = mmc_of_parse(mmc);
+if (ret)
+goto out_free;
 mmc->ops = &mxcmci_ops;
 
 /* For devicetree parsing, the bus width is read from devicetree */

[PATCH V3 05/10] mmc: sdhci-pxav3: handle mmc_of_parse() errors during probe

Simon Baatz — 2013-05-20T23:01:46

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 drivers/mmc/host/sdhci-pxav3.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 1ae358e..67ea388 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
< at >< at > -252,7 +252,9 < at >< at > static int sdhci_pxav3_probe(struct platform_device *pdev)
 
 match = of_match_device(of_match_ptr(sdhci_pxav3_of_match), &pdev->dev);
 if (match) {
-mmc_of_parse(host->mmc);
+ret = mmc_of_parse(host->mmc);
+if (ret)
+goto err_of_parse;
 sdhci_get_of_property(pdev);
 pdata = pxav3_get_mmc_pdata(dev);
 } else if (pdata) {
< at >< at > -313,10 +315,11 < at >< at > static int sdhci_pxav3_probe(struct platform_device *pdev)
 
 return 0;
 
+err_of_parse:
+err_cd_req:
 err_add_host:
 clk_disable_unprepare(clk);
 clk_put(clk);
-err_cd_req:
 err_clk_get:
 sdhci_pltfm_free(pdev);
 kfree(pxa);

[PATCH V3 07/10] ARM: mvebu: Use standard MMC binding for all users of mvsdio

Simon Baatz — 2013-05-20T23:01:48

In order to prepare the switch to the standard MMC device tree parser
for mvsdio, adapt all current uses of mvsdio in the dts files to the
standard format.

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---
 arch/arm/boot/dts/armada-370-db.dts                |    1 +
 arch/arm/boot/dts/armada-370-mirabox.dts           |    1 +
 arch/arm/boot/dts/armada-370-rd.dts                |    1 +
 arch/arm/boot/dts/armada-370-xp.dtsi               |    4 ++++
 arch/arm/boot/dts/armada-xp-db.dts                 |    1 +
 arch/arm/boot/dts/kirkwood-dreamplug.dts           |    1 +
 .../arm/boot/dts/kirkwood-guruplug-server-plus.dts |    2 ++
 arch/arm/boot/dts/kirkwood-mplcec4.dts             |    2 +-
 arch/arm/boot/dts/kirkwood-topkick.dts             |    1 +
 arch/arm/boot/dts/kirkwood.dtsi                    |    4 ++++
 10 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
index 2353b1f..beee169 100644
--- a/arch/arm/boot/dts/arm

[PATCH V3 01/10] mmc: return mmc_of_parse() errors to caller

Simon Baatz — 2013-05-20T23:01:42

In addition to just logging errors encountered during DT parsing or
allocating GPIO slots for CD/WP, mmc_of_parse() now returns with an error.

In particular, this is needed if the GPIO allocation may return
EPROBE_DEFER.

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
---

changes in V3:
- Handle EPROBE_DEFER case

 drivers/mmc/core/host.c  |   30 +++++++++++++++++++++++++-----
 include/linux/mmc/host.h |    2 +-
 2 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 2a3593d..89f5849 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
< at >< at > -306,7 +306,7 < at >< at > static inline void mmc_host_clk_sysfs_init(struct mmc_host *host)
  * parse the properties and set respective generic mmc-host flags and
  * parameters.
  */
-void mmc_of_parse(struct mmc_host *host)
+int mmc_of_parse(struct mmc_host *host)
 {
 struct device_node *np;
 u32 bus_width;
< at >< at > -315,7 +315,7 < at >< at > void mmc_of_parse(struct mmc_host *host)
 int len, ret, gpio;
 
 if (!

[PATCH V3 03/10] mmc: tmio-mmc: handle mmc_of_parse() errors during probe

Simon Baatz — 2013-05-20T23:01:44

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
---
 drivers/mmc/host/tmio_mmc_pio.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c
index f508ecb..f1a9d4a 100644
--- a/drivers/mmc/host/tmio_mmc_pio.c
+++ b/drivers/mmc/host/tmio_mmc_pio.c
< at >< at > -988,7 +988,9 < at >< at > int tmio_mmc_host_probe(struct tmio_mmc_host **host,
 if (!mmc)
 return -ENOMEM;
 
-mmc_of_parse(mmc);
+ret = mmc_of_parse(mmc);
+if (ret < 0)
+goto host_free;
 
 pdata->dev = &pdev->dev;
 _host = mmc_priv(mmc);

[PATCH V3 02/10] mmc: sh_mmcif: handle mmc_of_parse() errors during probe

Simon Baatz — 2013-05-20T23:01:43

Signed-off-by: Simon Baatz <gmbnomis< at >gmail.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski< at >gmx.de>
---
 drivers/mmc/host/sh_mmcif.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index ba76a53..6ded7fb 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
< at >< at > -1369,7 +1369,11 < at >< at > static int sh_mmcif_probe(struct platform_device *pdev)
 ret = -ENOMEM;
 goto ealloch;
 }
-mmc_of_parse(mmc);
+
+ret = mmc_of_parse(mmc);
+if (ret < 0)
+goto eofparse;
+
 host= mmc_priv(mmc);
 host->mmc= mmc;
 host->addr= reg;
< at >< at > -1464,6 +1468,7 < at >< at > eclkupdate:
 clk_put(host->hclk);
 eclkget:
 pm_runtime_disable(&pdev->dev);
+eofparse:
 mmc_free_host(mmc);
 ealloch:
 iounmap(reg);

[PATCH V3 00/10] mmc_of_parse() adaptations, DT support for Sheevaplugs

Simon Baatz — 2013-05-20T23:01:41

Hi,

V3 changes:
- Patch 01/10: Added EPROBE_DEFER case to mmc_of_parse() 
- Added Acked-By to (unmodified) patches 02 and 03.

V2 changes:
- Converted mvsdio to use mmc_of_parse()
- Adapted DTS files using mvsdio accordingly
- Changed mmc_of_parse() to return errors to the caller

While adding DT support for the Sheevaplugs by Globalscale Technologies
(Kirkwood), it turned out that the DT binding of mvsdio lacked features to
properly support the hardware (active high/low of CD and WP pins could not
be described in DT).

This is standard functionality provided by the mmc_of_parse() helper
function.  However, mmc_of_parse() may allocate GPIO lines.  If the
allocation fails, it outputs an error, but does not return an error to its
caller.  Therefore, a proposal to handle errors in mmc_of_parse() is made.

The patch set is structured as follows:

1   Adapt mmc_of_parse() to return errors
2-6 Handle errors in current drivers using mmc_of_parse() (compile tested
    only)
7-8 Convert mvsdio and respective

Re: [RESEND PATCH v2 1/3] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

Tony Lindgren — 2013-05-20T20:58:16

* Andreas Fenkart <andreas.fenkart< at >streamunlimited.com> [130515 01:51]:

Looks like this somehow breaks detecting of eMMC on mmc2 for me at least
with the non-dt legacyboot. For a removable mmc1 still keeps working.

For mmc2 I have .nonremovable = true and no gpio_cd or gpio_wp.

Also few comments below.
 

This should be checked, we have systems with all muxing done statically
in the bootloader. And we also have systems that provide the default
pinctrl state only as they don't need remuxing. So at most a warning should
be printed.


The check for sdio_irq && host->pinctrl looks broken too as we may
have not dynamic muxing via pinctrl needed for let's say omap3 based
systems.

Other than that, looks good to me.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

Dinh Nguyen — 2013-05-20T14:47:43

Hi Seungwon,

On 05/20/2013 12:40 AM, Seungwon Jeon wrote:

Yes, I missed the comment. Will change in rev3.


OK.


Ok, will move.


Thanks for the review.

Dinh

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

Dinh Nguyen — 2013-05-20T14:40:18

Hi Pavel,

On 05/17/2013 06:46 AM, Pavel Machek wrote:

Will fix in rev3.


Will remove.


Will add comments.


Divisor of 0 is not valid. Not sure what you mean my low divisos?

Thanks,
Dinh
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCHv2 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

Seungwon Jeon — 2013-05-20T05:40:04

Did you check Jaehoon Chung's comment?
It's trivial, but more common.
((((smplsel) & 0x38) << 3) | (((drvsel) & 0x7) << 0))

You can use clk_prepare_enable/clk_disable_unprepare instead of clk_enable/clk_disable.

How about placing syscon_regmap_lookup_by_compatible in dw_mci_socfpga_priv_init.
It seems more proper place.

Error check would be helpful.
ret = of_property_read_u32();

Thanks,
Seungwon Jeon


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA

Pavel Machek — 2013-05-17T11:46:07

Hi!



Actually it is   dw_mmc-exynos.c


Should SYSMGR stuff go to shared header file somewhere?


This is unused.


comment would be nice, something like
/* card interface unit divisor */ ?


/* card interface unit phase shift for RX/TX mode */
?


Previous version said:

+       host->bus_hz /= priv->ciu_div;

I see you want to avoid division by zero, but this will introduce
significant error for low divisors, right? Is divisor of 0 valid?

Otherwise it looks good. Thanks,
Pavel