gmane.linux.kernel.input

Re: [PATCH v4] input: Add MELFAS mms114 touchscreen driver

Henrik Rydberg — 2012-05-23T11:52:03

Hi Joonyoung,


Look good overall, some minor comments below which may be
ignored. Thank you,

    Reviewed-by: Henrik Rydberg <rydberg< at >euromail.se>

Henrik


Why not pass a struct like this instead:

struct mms114_touch {
       u8 id : 4, type : 3, pressed : 1;
       u8 x_hi : 4, y_hi : 4;
       u8 x_lo;
       u8 y_lo;
       u8 width;
       u8 strength;
} __packed;

Most of the code above would go away, together with some defines.



A more canonical formulation of the above function would be:

  int error = 0;

  mutex_lock(&data->mutex);
  if (data->enabled)
          goto out;

  if (data->core_reg)
          regulator_enable(data->core_reg);
  if (data->io_reg)
          regulator_enable(data->io_reg);
  mdelay(MMS114_POWERON_DELAY);

  error = mms114_setup_regs(data);
  if (error)
          goto out;

  data->enabled = true;
out:
  mutex_unlock(&data->mutex);
  return error;



Ditto.


It should really stop unconditionally here, but the above ought to
yield the same result.



Could use more got

Re: [Linuxwacom-devel] [PATCH] Input: wacom - add support for the DTI-520 graphics tablet

Ping Cheng — 2012-05-22T22:12:38

I don't have the device to test this patch. Just to share my comments
(inline) based on the code itself. I am cc'ing linux-input, where this
patch normally goes.

Ping


The line above should  be after the if statement below. Otherwise
wacom->tool can be uninitialized.


Need tp post wacom->id[0] through ABS_MISC here.


This short if block should be inside the long if block above.


Looks like we could define default vaules for those buttons.


Why do we clear ABS_MISC for pen tool?


This interface does not support ABS_X and ABS_Y either, right? Do we
need a tool type for this button box?

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: Force Sentelic reconnect when mode setting has failed

Matthew Garrett — 2012-05-22T20:28:39

When working: 0700, 4005, 4180, 4237
When broken : 0700, 4005, 4180, 4237

Re: [PATCH] Input: synaptics - reject out of range position values

Seth Forshee — 2012-05-22T20:00:57

Dmitry,

Is there someone else I should Cc who might know the answer?

Thanks,
Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] input: wacom - battery reporting improvements

Ping Cheng — 2012-05-22T18:05:28

Reviewed by: Ping Cheng <pingc< at >wacom.com>

Thank you for rearranging the failure cases. It makes the driver more
user friendly and fixes potential memory leaks..

Ping

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] input: wacom - Bamboo One 1024 pressure fix

Ping Cheng — 2012-05-22T17:42:44

Reviewed-by: Ping Cheng <pingc< at >wacom.com>

Ping

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] input: Add support for the Semtech SX8634 controller

Thierry Reding — 2012-05-22T13:48:34

Any comments on this one?

Thierry

Re: [PATCH 1/2] of: Add Semtech Corp. vendor prefix

Thierry Reding — 2012-05-22T13:47:44

Does this patch need any more work or can it go in?

Thierry

[MailServer Notification]Attachment Blocking Notification

2012-05-22T03:44:16

The get_state.sh has been blocked,
and Replace has been taken on 5/21/2012 8:43:23 PM.
Message details:
Server:WACOM-NT10
Sender: avatar< at >sentelic.com;
Recipient:mjg59< at >srcf.ucam.org;os< at >ohmu.fi;dtor< at >mail.ru;linux-input< at >vger.kernel.org;
Subject:Re: [PATCH] input: Force Sentelic reconnect when mode setting has failed
Attachment name:get_state.sh
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: Force Sentelic reconnect when mode setting has failed

Tai-hwa Liang — 2012-05-22T03:42:28

Hi Matthew,

   Would you please run the attached script and post the result next time
when you run into the abnormal scenario(FSP sends normal instead of abs.
packets)?

   You probably need to do this experiment without the reconnecting patch
applied.

Thank you,

Tai-hwa Liang

Re: [PATCH 01/16] Input: Add Device Tree support to the ab8500-ponkey driver

Linus Walleij — 2012-05-21T21:32:45


Acked-by: Linus Walleij <linus.walleij< at >linaro.org>

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dear account user

Technical Warning — 2012-05-21T14:28:33

Dear account user
 we are currently upgrading our data base and e-mail center
for this year 2012. Your mailbox has exceeded the limit of 20 GB, which is
as set by administrator, you are currently at 20.9GB, you will not be able
to create newe-mail to send or receive again until you validate your
mailbox to
prevent your account from closing.

Your email account has to be upgraded to our new faculty F- Secure R HTK4S
anti-virus/anti-Spam version 2012 to prevent damage to our account login and
your important files. You are required to upgrade before the  next 24 hours
of receipt of this email or your info will be erased and De- activated from
our database.

You will have to update it below so that we will know it's a present used
account.
Warning!!! E-mail owner that refuses to update his or her Email,within 24hrs
of receiving this warning will lose his or her E-mail permanently. You are
required to send us the below information via email below. CONFIRM YOUR E-
MAIL IDENTITY BELOW:
First Name:__________________

Re: Rotation Sensor in EEE Slate

Cedric Sodhi — 2012-05-21T21:01:04

Thank you for the suggestions but I did not get far with that. The patch
to asus-laptp.c is far over my head, but I have the vague idea that it
does not make the sensor any more known to my OS than it currently is.

There really is absolutely no trace of any sensor anywhere where I'd
understand it. Again, I'm no match for ACPI tables - my pathetic attempt
to grep for "sensor" in the disassembled tables failed as expected.

I also tried to grep for XLRX in the DSDT, but there was no match.

Thanks though
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

STORAGE LIMIT REACHED

System Administrator — 2012-05-21T17:30:15

Dear Email User

Your mailbox has exceeded the storage limit as set by your administrator,
you are currently running on low percent, you may not be able to send or receive new mail until you
re-validate your mailbox. To re-validate your mailbox please click or copy and paste the link below 
on your browser to re-validate your account,login after clicking the link or copying it to your browser
and follow up the procedure.


http://tinyurl.com/chsdzr3 



Thanks
System Administrator
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] HID: hid-multitouch: fix wrong protocol detection

Benjamin Tissoires — 2012-05-21T16:43:29

Hi Paul,

On Fri, May 18, 2012 at 11:14 PM, Drews, Paul <paul.drews< at >intel.com> wrote:

Thank you very much for this patch. However, Jiri already applied mine
with the allocation/free mechanism.

You're idea is good but it has one big problem with Win8 devices:
As we can have 2 X and 2 Y per touch report, if these dual-X reporting
or dual-Y reporting is present in the report, we will stop at the
second X or the second Y seen, which will lead to a buggy touchscreen
(the first touch won't get it's second coordinate). However, without
this particularity, the patch would have worked ;-)

If the Win8 norm has came earlier, the initial implementation that
relies on the collection would have suffice, but some hardware makers
made a bad use of it, leading us to stop using this, and relying on a
more brutal approach.

I found a little problem in the patch too:


I'm sure you wanted to put here:
                       if (td->first_slot_field == usage->hid)

Cheers,
Benjamin

--
To unsubscribe from this list

Re: [PATCH] input: Force Sentelic reconnect when mode setting has failed

Matthew Garrett — 2012-05-21T15:28:51

None that I've identified. It only seems to do it once, and afterwards 
it's fine. I agree that this seems to be covering up some more insidious 
bug, but I spent most of Friday and Saturday failing to find one.

Re: [PATCH] input: Force Sentelic reconnect when mode setting has failed

Tai-hwa Liang — 2012-05-21T15:22:07

    Sounds to me that the hardware was reset, which usually happens if
there's intermittent power failure events.  Is there any particular step
to reproduce this unexpected resetting?

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: wacom: Add LED selector control for Wacom Intuos4 WL

Przemo Firszt — 2012-05-21T14:08:56

Dnia 20 Maja 2012, 3:11 am, N, David Rientjes napisał(a):
[..]
Thanks for catching that!

STORAGE LIMIT REACHED

System Administrator — 2012-05-21T13:32:01

Dear Email User

Your mailbox has exceeded the storage limit as set by your administrator,
you are currently running on low percent, you may not be able to send or receive new mail until you
re-validate your mailbox. To re-validate your mailbox please click or copy and paste the link below 
on your browser to re-validate your account,login after clicking the link or copying it to your browser
and follow up the procedure.


http://tinyurl.com/chsdzr3 



Thanks
System Administrator
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Elantech touchpad detected as Logitech PS2 Wheel Mouse

Nicola Alessi — 2012-05-21T13:45:40

Hi,

I'd like to thank you all for the time you dedicated to this problem.
I'll try to experiment with the patch and I'll report if something
interesting happens.

< at >Jonathan: there are two things that make me think to have a elantech
touchpad. First, a sticker from the manufacturer below laptop's battery
pack (in the slot, you can see it only if you remove the battery)
labeled "ELANTEK". Second, I think more important, I've played around
(about two months ago) with dkms and patches to psmouse. More in detail,
I tried the patch from Seth Forshee (see
https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/681904/comments/111).
Through it didn't fix the issue (the touchpad was totally unusable due
to continuous "sync lost" messages) the touchpad was recognized as an
elantech (I don't remember the details, but I could try to build the
module again and mail some info).

Thanks again,

Nicola

Il 21/05/12 10:28, Jonathan Nieder ha scritto:

--
To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] HID: wacom: Add LED selector control for Wacom Intuos4 WL

Jiri Kosina — 2012-05-21T13:28:50


Right, thanks for your report. Now queued.