gmane.linux.kernel.input

Support Touchscreen SoundGraph

xavier hervy — 2008-09-05T16:33:43

Hi, I am trying to make my touch screen work (Zalman HD160XT Plus) but I could not find any suitable driver for it. The Touch screen is an USB Device which consist of : - a touch screen - a knob - few buttons in a front panel - A remote control lsusb -v Bus 004 Device 004: ID 15c2:0034 SoundGraph Inc. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 1.10 bDeviceClass 0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 8 idVendor 0x15c2 SoundGraph Inc. idProduct 0x0034 bcdDevice 0.12 iManufacturer 0 iProduct 0 iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 59 bNumInterfaces 2 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powere

__initdata and struct dmi_system_id?

Németh Márton — 2008-09-05T05:45:42

Hi, I have a question about how the __initdata sections are handled under Linux. As far as I understand after the init function is finished all the data from the __initdata section is freed. For this reason all the data which are marked as __initdata should be separated to a different section by the compiler. I take for example the drivers/input/keyboards/atkbd.c where we can see the following dmi_system_id structure: static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = { { .ident = "Dell Latitude series", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"), }, .callback = atkbd_setup_fixup, .driver_data = atkbd_latitude_keymap_fixup, }, { .ident = "HP 2133", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), DMI_MATC

[PATCH 2/2] input: mousedev: Emulate right and middle buttons for single-button touchpads

Henrik Rydberg — 2008-09-05T01:19:56

On most linux-based systems, the right and middle buttons are used extensively. On computers lacking either of those buttons, such as the Apple Macbooks, emulation is needed. This patch adds emulation of the missing buttons via two-fingers-and-click and three-fingers- and-click operations, which has recently become standard, both in MacOS and in the Xorg synaptics driver. Signed-off-by: Henrik Rydberg euromail.se> --- drivers/input/mousedev.c | 31 +++++++++++++++++++++++++++++++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index 27e1d73..a1e929f 100644 --- a/drivers/input/mousedev.c +++ b/drivers/input/mousedev.c < at >< at > -53,6 +53,14 < at >< at > static unsigned tap_move = 20; module_param(tap_move, uint, 0644); MODULE_PARM_DESC(tap_move, "Tap distance for touchpads in absolute mode (res)"); +static unsigned two_finger_code = BTN_RIGHT; +module_param(two_finger_code, uint, 0644); +MODULE_PARM_DESC(two_finger_code, "Button code of two-fi

[PATCH 1/2] input: mousedev: Distinguish a moving finger from a tapping finger

Henrik Rydberg — 2008-09-05T01:17:42

The tap functionality of mousedev does not distinguish between a tap (on/off localized in time and space) and a quick move (on/off localized in time only). This patch improves the tap detection by testing also for space locality. Signed-off-by: Henrik Rydberg euromail.se> --- drivers/input/mousedev.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index 8137e50..27e1d73 100644 --- a/drivers/input/mousedev.c +++ b/drivers/input/mousedev.c < at >< at > -49,6 +49,10 < at >< at > static unsigned tap_time = 200; module_param(tap_time, uint, 0644); MODULE_PARM_DESC(tap_time, "Tap time for touchpads in absolute mode (msecs)"); +static unsigned tap_move = 20; +module_param(tap_move, uint, 0644); +MODULE_PARM_DESC(tap_move, "Tap distance for touchpads in absolute mode (res)"); + struct mousedev_hw_data { int dx, dy, dz; int x, y; < at >< at > -76,6 +80,7 < at >< at > struct mousedev { int old_x[4], old_y[4]; int frac_dx, frac_dy; unsigned long to

[PATCH 2/5] HID: move thrustmaster FF processing

Jiri Slaby — 2008-09-04T12:59:44

Signed-off-by: Jiri Slaby gmail.com> --- drivers/hid/Kconfig | 9 ++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 4 + drivers/hid/hid-dummy.c | 3 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-tmff.c | 265 +++++++++++++++++++++++++++++++++++++++++ drivers/hid/usbhid/Kconfig | 11 -- drivers/hid/usbhid/Makefile | 3 - drivers/hid/usbhid/hid-ff.c | 6 - drivers/hid/usbhid/hid-tmff.c | 232 ------------------------------------ include/linux/hid.h | 1 - 11 files changed, 284 insertions(+), 253 deletions(-) create mode 100644 drivers/hid/hid-tmff.c delete mode 100644 drivers/hid/usbhid/hid-tmff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 7220e6f..268fcd1 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig < at >< at > -243,6 +243,15 < at >< at > config HID_SUNPLUS ---help--- Support for Sunplus WDesktop input device. +config THRUSTMASTER_FF +tristate "ThrustMaster devices support" +

[PATCH 5/5] HID: convert to dev_* prints

Jiri Slaby — 2008-09-04T12:59:47

Since we have a real device bound to a driver, we may use struct device for printing. Use dev_* functions instead of printks in 3 drivers. Signed-off-by: Jiri Slaby gmail.com> --- drivers/hid/hid-lg2ff.c | 8 ++++---- drivers/hid/hid-pl.c | 11 ++++++----- drivers/hid/hid-zpff.c | 6 +++--- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/hid/hid-lg2ff.c b/drivers/hid/hid-lg2ff.c index b2e9a67..4e6dc6e 100644 --- a/drivers/hid/hid-lg2ff.c +++ b/drivers/hid/hid-lg2ff.c < at >< at > -71,18 +71,18 < at >< at > int lg2ff_init(struct hid_device *hid) int error; if (list_empty(report_list)) { -printk(KERN_ERR "hid-lg2ff: no output report found\n"); +dev_err(&hid->dev, "no output report found\n"); return -ENODEV; } report = list_entry(report_list->next, struct hid_report, list); if (report->maxfield < 1) { -printk(KERN_ERR "hid-lg2ff: output report is empty\n"); +dev_err(&hid->dev, "output report is empty\n"); return -ENODEV; } if (report->field[0]->rep

[PATCH 3/5] HID: move zeroplus FF processing

Jiri Slaby — 2008-09-04T12:59:45

Signed-off-by: Jiri Slaby gmail.com> --- drivers/hid/Kconfig | 8 ++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 2 + drivers/hid/hid-dummy.c | 3 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-zpff.c | 162 +++++++++++++++++++++++++++++++++++++++++ drivers/hid/usbhid/Kconfig | 8 -- drivers/hid/usbhid/Makefile | 3 - drivers/hid/usbhid/hid-ff.c | 4 - drivers/hid/usbhid/hid-zpff.c | 107 --------------------------- include/linux/hid.h | 1 - 11 files changed, 178 insertions(+), 123 deletions(-) create mode 100644 drivers/hid/hid-zpff.c delete mode 100644 drivers/hid/usbhid/hid-zpff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 268fcd1..e4d5263 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig < at >< at > -252,6 +252,14 < at >< at > config THRUSTMASTER_FF Say Y here if you have a THRUSTMASTER FireStore Dual Power 2 or a THRUSTMASTER Ferrari GT Rumble Force or Force Feedback Whee

[PATCH 1/5] HID: move pantherlord FF processing

Jiri Slaby — 2008-09-04T12:59:43

Move the force feedback precessing into a separate module. Signed-off-by: Jiri Slaby gmail.com> --- drivers/hid/Kconfig | 16 +++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 2 + drivers/hid/hid-dummy.c | 3 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-pl.c | 205 +++++++++++++++++++++++++++++++++++++++ drivers/hid/usbhid/Kconfig | 8 -- drivers/hid/usbhid/Makefile | 3 - drivers/hid/usbhid/hid-ff.c | 4 - drivers/hid/usbhid/hid-plff.c | 139 -------------------------- drivers/hid/usbhid/hid-quirks.c | 1 - include/linux/hid.h | 1 - 12 files changed, 229 insertions(+), 156 deletions(-) create mode 100644 drivers/hid/hid-pl.c delete mode 100644 drivers/hid/usbhid/hid-plff.c diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 46337a2..7220e6f 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig < at >< at > -199,6 +199,22 < at >< at > config HID_MONTEREY ---help--- S

[PATCH 4/5] HID: remove hid-ff

Jiri Slaby — 2008-09-04T12:59:46

hid-ff.c now calls only pidff (generic driver), the special ones are now in separate drivers. Invoke pidff on all non-special directly. Signed-off-by: Jiri Slaby gmail.com> --- drivers/hid/usbhid/Kconfig | 13 -------- drivers/hid/usbhid/Makefile | 3 -- drivers/hid/usbhid/hid-core.c | 2 +- drivers/hid/usbhid/hid-ff.c | 69 ----------------------------------------- include/linux/hid.h | 9 +----- 5 files changed, 2 insertions(+), 94 deletions(-) delete mode 100644 drivers/hid/usbhid/hid-ff.c diff --git a/drivers/hid/usbhid/Kconfig b/drivers/hid/usbhid/Kconfig index 3cfc076..5d9aa95 100644 --- a/drivers/hid/usbhid/Kconfig +++ b/drivers/hid/usbhid/Kconfig < at >< at > -24,21 +24,8 < at >< at > config USB_HID comment "Input core support is needed for USB HID input layer or HIDBP support" depends on USB_HID && INPUT=n -config HID_FF -bool "Force feedback support (EXPERIMENTAL)" -depends on USB_HID && EXPERIMENTAL -help - Say Y here is you want force feedback support for a few

Re: [PATCH 1/3] Input: ads7846 - introduce .gpio_pendown to get pendown state

Eric Miao — 2008-09-04T10:50:04

Signed-off-by: Eric Miao marvell.com> --- This one should be cleaner. drivers/input/touchscreen/ads7846.c | 68 +++++++++++++++++++++++++++------- include/linux/spi/ads7846.h | 3 ++ 2 files changed, 57 insertions(+), 14 deletions(-) diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index ce6f48c..8583c76 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c < at >< at > -24,6 +24,7 < at >< at > #include #include #include +#include #include #include #include < at >< at > -116,6 +117,7 < at >< at > struct ads7846 { void*filter_data; void(*filter_cleanup)(void *data); int(*get_pendown_state)(void); +intgpio_pendown; }; /* leave chip selected when we're done, for quicker re-select? */ < at >< at > -491,6 +493,14 < at >< at > static struct attribute_group ads784x_attr_group = { /*----------------------------------------------

Re: [PATCH 1/3] Input: ads7846 - introduce .gpio_pendown to get pendown state

Eric Miao — 2008-09-04T10:39:08

So maybe I can simplify that code a bit more :) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] Input: ads7846 - introduce .gpio_pendown to get pendown state

Eric Miao — 2008-09-04T10:38:15

On Thu, Sep 4, 2008 at 6:00 PM, Russell King - ARM Linux arm.linux.org.uk> wrote: Indeed, I'll fix the other SPI GPIO CS patch as well. There is a warning If none is provided, and probe() will fail. So actually get_pendown_state() will never reach the last "return 0" statement.

Re: [PATCH 1/3] Input: ads7846 - introduce .gpio_pendown to get pendown state

Russell King - ARM Linux — 2008-09-04T10:00:51

The comment doesn't match the code. get_pendown_state() is used if it's non-NULL, otherwise, the GPIO if it's not -1. I'm getting a little worried about these tests for valid gpio numbers in drivers - some check for non-zero, this one checks for not -1. I get the feeling that this is storing up problems for later. Maybe using gpio_is_valid() would be a good idea? But... a related question: do we need to do the check here? Surely either a pendown function is going to be supplied, or if not we're going to use a GPIO, in which case the GPIO better be valid. Maybe something to check at driver initialisation time only? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] Input: ads7846 - introduce .gpio_pendown to get pendown state

Eric Miao — 2008-09-04T09:21:05

The GPIO connected to ADS7846 nPENIRQ signal is usually used to get the pendown state as well. Introduce a .gpio_pendown, and use this to decide the pendown state if .get_pendown_state is NULL. Signed-off-by: Eric Miao marvell.com> --- drivers/input/touchscreen/ads7846.c | 73 ++++++++++++++++++++++++++++------- include/linux/spi/ads7846.h | 4 ++ 2 files changed, 63 insertions(+), 14 deletions(-) diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index ce6f48c..4fd449a 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c < at >< at > -24,6 +24,7 < at >< at > #include #include #include +#include #include #include #include < at >< at > -116,6 +117,7 < at >< at > struct ads7846 { void*filter_data; void(*filter_cleanup)(void *data); int(*get_pendown_state)(void); +intgpio_pendown; }; /* leave chip selected w

[PATCH 3/3] bcm5974-0.64: BTN_TOUCH event added for mousedev

Henrik Rydberg — 2008-09-03T20:25:40

The mousedev driver requires the use of BTN_TOUCH events to process ABS_X and ABS_Y events properly, which is what is needed for the bcm5974-based apple computers to have a functional pointer out-of-the-box. This patch adds the BTN_TOUCH events to bcm5974. Signed-off-by: Henrik Rydberg euromail.se> --- drivers/input/mouse/bcm5974.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index 8568211..18f4d7f 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c < at >< at > -253,6 +253,7 < at >< at > static void setup_events_to_report(struct input_dev *input_dev, 0, cfg->y.dim, cfg->y.fuzz, 0); __set_bit(EV_KEY, input_dev->evbit); +__set_bit(BTN_TOUCH, input_dev->keybit); __set_bit(BTN_TOOL_FINGER, input_dev->keybit); __set_bit(BTN_TOOL_DOUBLETAP, input_dev->keybit); __set_bit(BTN_TOOL_TRIPLETAP, input_dev->keybit); < at >< at > -320,6 +321,7 < at >< at > static int report_tp_state(struct bcm5974 *dev, int size) if

[PATCH 2/3] bcm5974-0.64: Finger tracking and counting improved further

Henrik Rydberg — 2008-09-03T20:23:45

The problem of finger tracking, i.e., when to switch focus from one finger to another on the trackpad, has been improved by utilizing more information from the bcm5974 chip output. This results in less pointer hopping when many fingers are on the trackpad. In addition, a finger counting method based on pressure information from all fingers is introduced. Together with a pressure hysteresis window, this yields a more stable counting of the number of fingers on the trackpad. Signed-off-by: Henrik Rydberg euromail.se> --- drivers/input/mouse/bcm5974.c | 70 +++++++++++++++++++++++++++++++--------- 1 files changed, 54 insertions(+), 16 deletions(-) diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index ae78bb8..8568211 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c < at >< at > -105,7 +105,7 < at >< at > struct tp_header { /* trackpad finger structure */ struct tp_finger { -__le16 origin;/* left/right origin? */ +__le16 origin;/* zero when switching tr

[PATCH 1/3] bcm5974-0.64: minor cleanups for scripts/checkpatch.pl

Henrik Rydberg — 2008-09-03T20:21:59

Signed-off-by: Henrik Rydberg euromail.se> --- drivers/input/mouse/bcm5974.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index 2ec921b..ae78bb8 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c < at >< at > -63,7 +63,7 < at >< at > } /* table of devices that work with this driver */ -static const struct usb_device_id bcm5974_table [] = { +static const struct usb_device_id bcm5974_table[] = { /* MacbookAir1.1 */ BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING_ANSI), BCM5974_DEVICE(USB_DEVICE_ID_APPLE_WELLSPRING_ISO),

Re: [PATCH] bcm5974-0.62: Compatibility mode reverted, BTN_TOUCHevent added

Dmitry Torokhov — 2008-09-03T20:02:04

That is fine. Yes. Mousedev is a stop-gap measure and is to be used only while user installs proper driver. It does not need to be perfect.

Re: [PATCH] bcm5974-0.62: Compatibility mode reverted, BTN_TOUCH event added

Henrik Rydberg — 2008-09-03T19:55:16

I have, and the problem is somewhat more complicated when dealing with multiple fingers. The simple patch shown about actually works very well in practice. However, things can always improve. Yesterday I sent a second patch, bcm5974-0.63, which addressed this issue. However, the quality of the mouse movement has regressed a little in that patch. I would like to send yet another patch today, bcm5974-0.64, I hope this does not cause too much confusion. Regarding mousedev, I noticed that the tap functionality does not distinguish between a tap (on/off localized in time and space) and a quick drag (on/off localized in time only). -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo< at >vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Remove HID ignore quirk for MGE UPS devices

Jiri Kosina — 2008-09-03T13:33:36

Agreed. Even the "quirk support" is now more mature -- there are hidbus patches queued in my tree, that allow for creation of separate drivers for every non-standard HID device, so that quirks don't have to be sprinkled randomly all over the HID code. If you are going to add any new more or less complex quirks, I'd like to ask you to look into this infrastructure. Thanks,

[PATCH 2/2] bcm5974-0.63: BTN_TOUCH event added for mousedev

Henrik Rydberg — 2008-09-03T12:02:54

The mousedev driver requires the use of BTN_TOUCH events to process ABS_X and ABS_Y events properly, which is what is needed for the bcm5974-based apple computers to have a functional pointer out-of-the-box. This patch adds the BTN_TOUCH events to bcm5974. Signed-off-by: Henrik Rydberg euromail.se> --- drivers/input/mouse/bcm5974.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index acc401d..5132775 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c < at >< at > -253,6 +253,7 < at >< at > static void setup_events_to_report(struct input_dev *input_dev, 0, cfg->y.dim, cfg->y.fuzz, 0); __set_bit(EV_KEY, input_dev->evbit); +__set_bit(BTN_TOUCH, input_dev->keybit); __set_bit(BTN_TOOL_FINGER, input_dev->keybit); __set_bit(BTN_TOOL_DOUBLETAP, input_dev->keybit); __set_bit(BTN_TOOL_TRIPLETAP, input_dev->keybit); < at >< at > -303,6 +304,7 < at >< at > static int report_tp_state(struct bcm5974 *dev, int size) if