gmane.linux.ide

Re: [PATCH v3 1/4] libata: add R-Car SATA driver

Sergei Shtylyov — 2013-05-24T23:12:22

Hello.

On 02/20/2013 11:10 PM, Sergei Shtylyov wrote:

     Tejun, a question for you... see below.


     Not all bugs turned out to be fixed... :-/

[...]
[...]

    This value should have been put into the 'dma_boundary' field of the
'struct scsi_host_template', IIUC. Tejun, if I do it, do I need this 
check at all?

[...]

     This should have been ATA_BASE_SHT() and the proepr values 
specified for
the 'sg_tablesize' and 'dma_boundary' fields. R-Car SATA descriptors are not
the same as SFF-8038i, they allow up to 512 megs of data to be specified in
one descriptor and don't care about 64KiB boundaries.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ata: use platform_{get,set}_drvdata()

'Tejun Heo' — 2013-05-24T01:26:40

Applied to libata/for-3.11.  Thanks.

I am Mr Chan Yuan..

Chan Yuan — 2013-05-23T00:23:58

I am Mr Chan Yuan,we are looking for a representative in your country to assist us pick up funds from our clients in your location. If you are interested do get back to me for futher details with your name/address/tel.There is no financial obligation on your part. Do also note that your are entitled to 10% of each installmental payment made out to you by our clients.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_rcar: clear STOP bit in bmdma_start() method

Sergei Shtylyov — 2013-05-23T12:14:40

Hello.

On 22-05-2013 17:12, Sergei Shtylyov wrote:





     Although bmdma_stop() also can stop DMA which is not as improbable 
(media errors, etc.). I could have wrotten a better changelog. :-/


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ata: use platform_{get,set}_drvdata()

Jingoo Han — 2013-05-23T10:41:21

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Jingoo Han <jg1.han< at >samsung.com>
---
 drivers/ata/pata_arasan_cf.c |    2 +-
 drivers/ata/pata_at91.c      |    2 +-
 drivers/ata/pata_bf54x.c     |   10 ++++------
 drivers/ata/pata_imx.c       |    2 +-
 drivers/ata/pata_mpc52xx.c   |    4 ++--
 drivers/ata/pata_pxa.c       |    2 +-
 drivers/ata/sata_fsl.c       |   14 +++++---------
 drivers/ata/sata_rcar.c      |    2 +-
 8 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 7638121..848ed32 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
< at >< at > -908,7 +908,7 < at >< at > free_clk:
 
 static int arasan_cf_remove

I am Mr Chan Yuan

Chan Yuan — 2013-05-22T23:59:16

I am Mr Chan Yuan,we are looking for a representative in your country to assist us pick up funds from our clients in your location. If you are interested do get back to me for futher details with your name/address/tel.There is no financial obligation on your part. Do also note that your are entitled to 10% of each installmental payment made out to you by our clients.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

Ralf Baechle — 2013-05-22T17:14:46


Done.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

Jens Axboe — 2013-05-22T17:03:05

Would be most awesome, I'm sure Nic would not mind a bit of help on the
SCSI/libata side :-)

And personally, can't wait to run it on the laptop! That's right, I
alpha test on the laptop.

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

David Daney — 2013-05-22T16:13:50

Can you take v2 instead?  It has the missing watchdog adjustment that is 
not in v1.

Thanks,
David Daney


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

David Daney — 2013-05-22T16:10:46

From: David Daney <david.daney< at >cavium.com>

CAVIUM_OCTEON_SOC most place we used to use CPU_CAVIUM_OCTEON.  This
allows us to CPU_CAVIUM_OCTEON in places where we have no OCTEON SOC.

Remove CAVIUM_OCTEON_SIMULATOR as it doesn't really do anything, we can
get the same configuration with CAVIUM_OCTEON_SOC.

Signed-off-by: David Daney <david.daney< at >cavium.com>
Cc: linux-ide< at >vger.kernel.org
Cc: linux-edac< at >vger.kernel.org
Cc: linux-i2c< at >vger.kernel.org
Cc: netdev< at >vger.kernel.org
Cc: spi-devel-general< at >lists.sourceforge.net
Cc: devel< at >driverdev.osuosl.org
Cc: linux-usb< at >vger.kernel.org
Acked-by: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
Acked-by: Wolfram Sang <wsa< at >the-dreams.de>
Acked-by: Mauro Carvalho Chehab <mchehab< at >redhat.com>
---
It may make sense to merge this before 3.10 as it touches a ton of
Kconfigs that are more likely to experiance merge problems in a full
merge window.  Also it is only Kconfigery and no 'real' code, so there
are fewer chances of really screwing things up.

Changes from v1: White spa

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

Alexander Gordeev — 2013-05-22T14:39:24

I am not committing, but will look into it, sure.

Re: [PATCH] sata_rcar: clear STOP bit in bmdma_start() method

Sergei Shtylyov — 2013-05-22T13:12:48

Hello.

On 22-05-2013 3:41, Tejun Heo wrote:




    Thanks, I forgot about -stable. Anyway, it doesn't seem that serious 
as bmdma_setup() usually shouldn't abort DMA.


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] AHCI: Make distinct names for ports in /proc/interrupts /proc/interrupts

Tejun Heo — 2013-05-21T23:55:19

I've refreshed on top of libata/for-3.11 and applied it.  If I broke
something, please let me know.

Thanks a lot!

From b29900e62598cecd519c9ab2b8e4d03f8ebf702d Mon Sep 17 00:00:00 2001
From: Alexander Gordeev <agordeev< at >redhat.com>
Date: Wed, 22 May 2013 08:53:48 +0900

Currently all interrupts assigned to AHCI ports show up in
'/proc/interrupts' as 'ahci'. This fix adds port numbers as
suffixes and hence makes the descriptions distinct.

Reported-by: Jan Beulich <JBeulich< at >suse.com>
Signed-off-by: Alexander Gordeev <agordeev< at >redhat.com>
Signed-off-by: Tejun Heo <tj< at >kernel.org>
---
 drivers/ata/ahci.c    |  4 +++-
 drivers/ata/ahci.h    |  1 +
 drivers/ata/libahci.c | 10 ++++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 251e57d..4d1c672 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
< at >< at > -1142,9 +1142,11 < at >< at > int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis)
 return rc;
 
 for (i = 0; i < host->n_ports;

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

Tejun Heo — 2013-05-21T23:50:03

Hello, Alexander.

(cc'ing Jens and Nicholas, hey guys)

On Tue, May 21, 2013 at 09:00:27PM +0200, Alexander Gordeev wrote:

Hmmmmmm..... I'd normally apply this patch but block layer is just
growing multi-queue support and libata is likely to be converted to mq
in foreseeable future, so I'm a bit hesitant to make irq handling more
sophiscated right now.  Would you be interested in looking into
converting libata to blk mq support?  I'm pretty sure it'd yield far
better outcome if done properly.

Thanks.

Re: [PATCH] sata_rcar: clear STOP bit in bmdma_start() method

Tejun Heo — 2013-05-21T23:41:28

Applied to libata/for-3.10-fixes w/ stable cc'd.

Thanks.

[PATCH 2/2] libata: Add atapi_dmadir force flag

Tejun Heo — 2013-05-21T23:35:18

Applied to libata/for-3.11.  Thanks a lot!

From 966fbe193f47c68e70a80ec9991098e88e7959cb Mon Sep 17 00:00:00 2001
From: Vincent Pelletier <plr.vincent< at >gmail.com>
Date: Tue, 21 May 2013 22:30:58 +0200

Some device require DMADIR to be enabled, but are not detected as such
by atapi_id_dmadir.  One such example is "Asus Serillel 2"
SATA-host-to-PATA-device bridge: the bridge itself requires DMADIR,
even if the bridged device does not.

As atapi_dmadir module parameter can cause problems with some devices
(as per Tejun Heo's memory), enabling it globally may not be possible
depending on the hardware.

This patch adds atapi_dmadir in the form of a "force" horkage value,
allowing global, per-bus and per-device control.

Signed-off-by: Vincent Pelletier <plr.vincent< at >gmail.com>
Signed-off-by: Tejun Heo <tj< at >kernel.org>
---
 Documentation/kernel-parameters.txt | 2 ++
 drivers/ata/libata-core.c           | 3 ++-
 include/linux/libata.h              | 1 +
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/D

[PATCH 1/2] libata: make ata_exec_internal_sg honor DMADIR

Tejun Heo — 2013-05-21T23:32:58

Applied to libata/for-3.10-fixes w/ stable cc'd.

Thanks a lot!

From e771451c0a831d96a7c14b0ca8a8ec671d98567b Mon Sep 17 00:00:00 2001
From: Vincent Pelletier <plr.vincent< at >gmail.com>
Date: Sat, 18 May 2013 18:44:04 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

libata honors DMADIR for regular commands, but not for internal commands
used (among other) during device initialisation.

This makes SATA-host-to-PATA-device bridges based on Silicon Image SiL3611
(such as "Abit Serillel 2") end up disabled when used with an ATAPI device
after a few tries.

Log output of the bridge being hot-plugged with an ATAPI drive:

  [ 9631.212901] ata1: exception Emask 0x10 SAct 0x0 SErr 0x40c0000 action 0xe frozen
  [ 9631.212913] ata1: irq_stat 0x00000040, connection status changed
  [ 9631.212923] ata1: SError: { CommWake 10B8B DevExch }
  [ 9631.212939] ata1: hard resetting link
  [ 9632.104962] ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
  [ 9632.106393] ata1.0

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

David Daney — 2013-05-21T22:07:23

Good point.  I will regenerate the patch to correct this.

Thanks,
David Daney



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] make ata_exec_internal_sg honor DMADIR

Vincent Pelletier — 2013-05-21T20:37:25

Hi.

Attached should be the final patches, unless someone has objections.

Changes since previous version:
- noatapi_dmadir dropped
- flag documented
- slight change to 2/2 commit message
- tested

Regards,

[PATCH] ipr: qc_fill_rtf() method should not store alternate status register

Sergei Shtylyov — 2013-05-21T19:24:22

The 'ctl' field of  the 'struct ata_taskfile' is not really dual purpose, i.e.
it is not intended  for storing the alternate status register (which is mapped
at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
not do this as well...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov< at >cogentembedded.com>

---
The patch is against the recent Linus' tree.

 drivers/scsi/ipr.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux/drivers/scsi/ipr.c
===================================================================
--- linux.orig/drivers/scsi/ipr.c
+++ linux/drivers/scsi/ipr.c
< at >< at > -6662,7 +6662,6 < at >< at > static bool ipr_qc_fill_rtf(struct ata_q
 tf->hob_lbal = g->hob_lbal;
 tf->hob_lbam = g->hob_lbam;
 tf->hob_lbah = g->hob_lbah;
-tf->ctl = g->alt_status;
 
 return true;
 }
--
To unsubscribe from this list: send the line "unsubsc

[PATCH] sata_rcar: clear STOP bit in bmdma_start() method

Sergei Shtylyov — 2013-05-21T19:07:54

Iff bmdma_setup() has to stop a DMA transfer before starting a new one, then the
STOP bit in the ATAPI_CONTROL1 register will remain set (it's only cleared when
setting the START bit to 1) and then bmdma_start() method will set both START
and STOP bits simultaneously which should abort the transfer being just started.
Avoid that by explicitly clearing the STOP bit in bmdma_start() method (in this
case it will be ignored on write).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov< at >cogentembedded.com>

---
This patch is against 'for-3.10-fixes' branch of Tejun Heo's 'libata.git' repo.

 drivers/ata/sata_rcar.c |    1 +
 1 file changed, 1 insertion(+)

Index: libata/drivers/ata/sata_rcar.c
===================================================================
--- libata.orig/drivers/ata/sata_rcar.c
+++ libata/drivers/ata/sata_rcar.c
< at >< at > -549,6 +549,7 < at >< at > static void sata_rcar_bmdma_start(struct
 
 /* start host DMA transaction */
 dmactl = ioread32(priv->base + ATAPI_CONTROL1_REG);
+dmactl &= ~ATAPI_CONTROL1_STOP;