gmane.linux.file-systems

[rfc v2 4/7] fs, eventfd: Add procfs fdinfo helper

Cyrill Gorcunov — 2012-05-23T10:25:45

This allow us to print out raw counter value.
The /proc/pid/fdinfo/fd output is

 | pos:0
 | flags:04002
 | eventfd-count:               5a

This feature is CONFIG_CHECKPOINT_RESTORE only.

Signed-off-by: Cyrill Gorcunov <gorcunov< at >openvz.org>
CC: Andrew Morton <akpm< at >linux-foundation.org>
CC: Pavel Emelyanov <xemul< at >parallels.com>
CC: James Bottomley <jbottomley< at >parallels.com>
---
 fs/eventfd.c |   55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

Index: linux-2.6.git/fs/eventfd.c
===================================================================
--- linux-2.6.git.orig/fs/eventfd.c
+++ linux-2.6.git/fs/eventfd.c
< at >< at > -19,6 +19,8 < at >< at >
 #include <linux/export.h>
 #include <linux/kref.h>
 #include <linux/eventfd.h>
+#include <linux/proc_fs.h>
+#include <linux/seq_file.h>
 
 struct eventfd_ctx {
 struct kref kref;
< at >< at > -437,3 +439,56 < at >< at > SYSCALL_DEFINE1(eventfd, unsigned int, c
 return sys_eventfd2(count, 0);
 }
 
+#if defined(CONFIG_PROC_FS) && defined(CONFIG_CHECKPOINT_R

You have been chosen: (Potential Income) Recommends Advanced Sports to you

2012-05-23T08:17:57

Email        :christine< at >yahoo.com
Friend Name  :Friend
Friend Email :linux-fsdevel< at >vger.kernel.org
comment      :

You have been picked to be an exclusive online profits case study.

You will be taught personally from a $2,192,289 online marketer.

This is the same EXACT system.


Never before has this been done.


If you want to be one of the lucky 30 students 

of master Jamie.. be one of 30 lucky actual case studies 

right now by signing up here: 


Christine Sarrosa

The sender of this email receives compensation
when products are purchased. Results will widely vary.
This is an advertisement.


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

CONTACT DR.RUBEN LEE

UCCCON — 2012-05-23T07:57:22

KINDLY FIND ATTACHED MESSAGE AND GET BACK TO ME

Re: [PATCH] autofs4 - fix get_next_positive_subdir()

Ian Kent — 2012-05-23T07:30:48

Correction, that second check is actually !(positive and hashed) in the
code.



--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] autofs4 - fix get_next_positive_subdir()

Ian Kent — 2012-05-23T07:22:01

It's good that you questioned this Linus.

Looking again at dput() I think the traversal still isn't quite right.

For a start the test for d_count 0 or positive and hashed can never be
true since the point of the change was to take the d_lock of the
d_subdirs dentry for the traversal.

I'll need to work on this some more, thanks.
Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] autofs4 - fix get_next_positive_subdir()

Ian Kent — 2012-05-23T02:49:50

From: Ian Kent <raven< at >themaw.net>

The locking for the list traversal in get_next_positive_subdir() is
wrong, so fix it.

Signed-off-by: Ian Kent <raven< at >themaw.net>
---

 fs/autofs4/expire.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c
index 1feb68e..20cc9fd 100644
--- a/fs/autofs4/expire.c
+++ b/fs/autofs4/expire.c
< at >< at > -97,9 +97,9 < at >< at > static struct dentry *get_next_positive_subdir(struct dentry *prev,
 struct dentry *p, *q;
 
 spin_lock(&sbi->lookup_lock);
+spin_lock(&root->d_lock);
 
 if (prev == NULL) {
-spin_lock(&root->d_lock);
 prev = dget_dlock(root);
 next = prev->d_subdirs.next;
 p = prev;
< at >< at > -107,12 +107,13 < at >< at > static struct dentry *get_next_positive_subdir(struct dentry *prev,
 }
 
 p = prev;
-spin_lock(&p->d_lock);
+spin_lock_nested(&p->d_lock, DENTRY_D_LOCK_NESTED);
 again:
 next = p->d_u.d_child.next;
 start:
 if (next == &root->d_subdirs) {
 spin_unlock(&p->d_lock);
+spin_unlock(&root->d_lock);

Re: v3.4 will not compile

David Rientjes — 2012-05-22T22:41:30


Sounds good for s/GFS_FS/GFS2_FS/
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.

Jeff Moyer — 2012-05-22T20:41:02


OK, this took me a while to wrap my head around, mostly due to confusion
with ki_nbytes and ki_left.  When doing p{read|write}v, aio_nbytes is
used to store the number of vectors.  Thus, we need to set both ki_left
and ki_nbytes to the result of the rw_verify_area call, which means that
when ki_left goes to 0, we'll exit out of this loop:

do {
ret = rw_op(iocb, &iocb->ki_iovec[iocb->ki_cur_seg],
    iocb->ki_nr_segs - iocb->ki_cur_seg,
    iocb->ki_pos);
if (ret > 0)
aio_advance_iovec(iocb, ret);

/* retry all partial writes.  retry partial reads as long as its a
 * regular file. */
} while (ret > 0 && iocb->ki_left > 0 &&
 (opcode == IOCB_CMD_PWRITEV ||
  (!S_ISFIFO(inode->i_mode) && !S_ISSOCK(inode->i_mode))));

and here:

/* This means we must have transferred all that we could */
/* No need to retry anymore */
if ((ret == 0) || (iocb->ki_left == 0))
ret = iocb->ki_nbytes - iocb->ki_left;

ki_nbytes will remain at whatever rw_verify_area returned, and ki_left
should be zero.

[PATCH 1/1] xfstests 286: test for 2G overflows in AIO

Eric Sandeen — 2012-05-22T19:26:56

Here's a testcase for xfstests.
---

Add new testcase looking for overflows in AIO code when 2G write
requests are issued.

Also fix up ltp/aio-stress.c to not overflow before the request
ever gets to the kernel...

Signed-off-by: Eric Sandeen <sandeen< at >redhat.com>
---

diff --git a/286 b/286
new file mode 100755
index 0000000..f5daa96
--- /dev/null
+++ b/286
< at >< at > -0,0 +1,75 < at >< at >
+#! /bin/bash
+# FS QA Test No. 286
+#
+# Check for 2G overflows in AIO
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2012 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# Y

Re: [PATCH v2 1/2] block: add BH_Meta flag

Jeff Moyer — 2012-05-22T16:37:54


Presumably you're doing this to get better performance for some
workload, yes?  Could you please let us know what workloads you tested
and how this patch set helps?  In other words, what benchmarking did you
perform and what were the results?  Do you expect this to make some
other workloads perform worse?

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.

manish honap — 2012-05-22T16:13:40

Hello Linus, Ted



On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote:

Patch works on my machine also. 

Used Chris Mason's aio-stress.c

- Manish

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 2/5] block: Do not stop draining if waitqueue is not empty.

Tejun Heo — 2012-05-22T15:07:42

Hello, Asias.

On Tue, May 22, 2012 at 02:48:55PM +0800, Asias He wrote:

Hmm.... unbalanced how?  I think bugs in this area are much more
likely to show up as live queue hang rather than issues during queue
shutdown.


If the problem is that easily reproducible (you mean that you can
reproduce it every other time, right?), it would be immensely helpful
if you can root cause the issue properly.  As it currently stands,
this series seems to work around the problem by adding extra API
without properly root-causing it.  Workarounds without proper
root-causing are already pretty bad and adding extra API for that is
rather silly, IMHO.

Thanks.

You have been chosen: (Potential Income) Recommends Advanced Sports to you

2012-05-22T14:05:09

Email        :christine< at >yahoo.com
Friend Name  :Friend
Friend Email :linux-fsdevel< at >vger.kernel.org
comment      :

You have been picked to be an exclusive online profits case study.

You will be taught personally from a $2,192,289 online marketer.

This is the same EXACT system.


Never before has this been done.


If you want to be one of the lucky 30 students 

of master Jamie.. be one of 30 lucky actual case studies 

right now by signing up here: 


Christine Sarrosa

The sender of this email receives compensation
when products are purchased. Results will widely vary.
This is an advertisement.


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: v3.4 will not compile

James Bottomley — 2012-05-22T10:23:40

No, that's not it.  The problem is that DLM can't be a module if GFS_FS
is built in because GFS needs to use DLM functions (so DLM can be a
module as long GFS_FS is)

so this should be

&& (DLM=y || (DLM=m && GFS_FS=m))

James


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 2/5] block: Do not stop draining if waitqueue is not empty.

Asias He — 2012-05-22T06:48:55

Hi, Tejun

I actually saw this happened though it should not happen. I have no idea 
why this happens. Maybe unbalanced prepare_to_wait_exclusive() in 
get_request_wait() and wake_up() in __freed_request()?

With this happened, I saw some fio threads in D state which are sleeping 
on get_request_wait(). If I wake up the threads in the wait queue in 
q->abort_queue_fn() callback which i proposed in the 1/5 of this patch 
set, the queue cleanup and thus hot-unplug went pretty well. (Passed 
3000~ rounds of test, without this 2~ round of test would fail). See 
this patch [RFC PATCH 4/5] virtio-blk: Use q->abort_queue_fn() to abort.

Re: [PATCH v2 1/2] block: add BH_Meta flag

Saugata Das — 2012-05-22T04:18:24

Hi Ted, Christoph

Will you please provide your feedback for these patch set,
[PATCH v2 1/2] block: add BH_Meta flag
[PATCH v2 2/2] ext4: annotate all meta data requests

If there is no comment then will you please merge them.


Regards
Saugata


On 17 May 2012 17:51, Saugata Das <saugata.das< at >stericsson.com> wrote:
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.

Linus Torvalds — 2012-05-21T22:22:28

On Sun, May 20, 2012 at 9:50 PM, Linus Torvalds
<torvalds< at >linux-foundation.org> wrote:

Ok, so with that patch, your program gives the expected

  2147479552 (0x7ffff000) bytes transferred

which is indeed MAX_INT aligned down to a page boundary (ie MAX_RW_COUNT).

So I'm pretty sure this patch is what we want, and rw_verify_area()
really is required to protect low-level filesystems from these kinds
of issues. Not just ext4.

At the same time, I would *really* want somebody who actually uses
anything AIO to test it out too. Because I want to not only commit it,
but also mark it for stable - and it would be nice to have some more
testing than me saying "ok, it passes the one test-case sent to me"
and "hey, the code looks sane".

Anybody?

                              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

SHOCKING SYSTEM.(and one weird rule) Recommends Advanced Sports to you

2012-05-21T19:14:12

Email        :ronrajan< at >yahoo.com
Friend Name  :Friend
Friend Email :linux-fsdevel< at >vger.kernel.org
comment      :


Hi Friend,

Here's a controversial new system revealing

affiliate marketing's number one rule...

=======>  http://bit.ly/LarThw

During this revealing presentation, this crazy
underground affiliate reveals the BRUTAL TRUTH why
most beginner marketers DON'T make even one cent
online.

Ya, you might say it's a bit controversial...

.BUT if you want to discover the truth about
driving insane amounts of traffic the way the top
super affiliates do it, and find out the number
one rule that's been kept from you all along, then
you need to check out what this guy has to say:

=======>  http://bit.ly/LarThw

This WON'T be available forever so my best advice
is to go check it out right now.

Ron Rajan

P.S. If you've been looking for a STEP BY STEP
system for getting crazy amounts of laser targeted
traffic, then you'll certainly want to check this
out.

Just make sure you pay close attention to the
weir

Re: [PATCH] fs: Fix NULL pointer dereference at copy_mnt_ns().

Al Viro — 2012-05-21T18:35:13

Nah, just me cherry-picking unfixed variant.  It had come up back in March,
remember?  Replaced with fixed variant in the local tree, will go into
for-next (and for-linus, while we are at it) tonight or tomorrow morning.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fs: Fix NULL pointer dereference at copy_mnt_ns().

Andi Kleen — 2012-05-21T18:27:21


oops. Thanks for finding that. Must have been a merge error somewhere.

Should be a stable candidate.

Acked-by: Andi Kleen <ak< at >linux.intel.com>

For your information

Eric Chua — 2012-05-21T13:23:15

Good day, 

My name is Eric Chua, Director at SWIFT Securities Markets, Asia Pacific China. This letter is written to you regarding a fixed investment account under our foreign investment policy.

Being mandatory that holder/beneficiary is periodically notified concerning financial status of account(s), I am writing to this effect since you share the same last name as this investment account. Upon your earliest reply, detail and necessary information will be made available for your reference.

Kind regards,
Eric Chua
SWIFT Securities Markets, 
Asia Pacific China
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html