gmane.linux.file-systems

Re: [PATCH v3 06/13] locks: protect most of the file_lock handling with i_lock

Jeff Layton — 2013-06-18T17:43:46

On Mon, 17 Jun 2013 11:49:38 -0400
Jeff Layton <jlayton< at >redhat.com> wrote:


...and scratch that again...

There is a bug in the posix_unblock_lock delta above. We don't need to
hold the i_lock there, but we should probably be taking the
file_lock_lock before checking fl_next.

In truth, I have a hard time seeing how that race would manifest itself
in practice, but that's how the existing code works so it's probably
best to preserve that as closely as possible.

Fixed in my git repo and the next spin of this set will have it.

Sorry again for the noise... ;)

(unknown)

Linda Loan Company Ltd — 2013-06-18T10:19:55



Do you need a loan?If yes reply us for more details at:mrslinda4help< at >qq.com

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] writeback: plug writeback at a high level

Chris Mason — 2013-06-18T11:16:35

Quoting Dave Chinner (2013-06-17 21:58:06)

Very true, but at the same time we do wait for background writeback
sometimes.  It's worth a quick test...


Ok, I'll try something less exotic here ;)

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(unknown)

Linda Loan Company Ltd — 2013-06-18T09:41:47


Do you need a loan?If yes reply us for more details at:mrslinda4help< at >qq.com


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

attention

penny williams — 2013-06-17T23:23:10

Attention Please!!!

Contact Mrs Donna Siford The US Customs office New York City for your 
$950,000.00 USD Compensation Funds from Benin Government & the IMF.

Contact the US Customs Mrs.Donna Siford with your full 
info Name & Address, Here her email address: mrsdnnasiford< at >yahoo.gr, contact 
her now for your package.

Thanks,
Mrs.Penny B Williams
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] writeback: plug writeback at a high level

Dave Chinner — 2013-06-18T01:58:06

I'm testing on SSDs, but the impact has nothing to do with the
underlying storage.


Oh, that's completely different situation - it's application
submitted IO wherhe Io latency is a deterimining factor in
performance.

This is for background writeback, where IO latency is not a primary
performance issue - maximum throughput is what we are trying to
acheive here. For writeback, well formed IO has a much greater
impact on throughput than low latency IO submission, even for SSD
based storage.


The host has an XFS filesystem on a md RAID0 of 4x40Gb slices off
larger SSDs:

$ cat /proc/mdstat
Personalities : [raid0] 
md2 : active raid0 sdb1[0] sde1[3] sdd1[2] sdc1[1]
      167772032 blocks super 1.2 32k chunks

built with mkfs.xfs defaults. A sparse 100TB file is created and
then fed to KVM with cache=none,virtio.

The guest formats the 100TB device using default mkfs.xfs parameters
and uses default mount options, so it's a 100TB filesytsem with
about 150GB of real storage in it...

The underlying hardware cont

attention

penny williams — 2013-06-18T00:40:53

Attention Please!!!

Contact Mrs Donna Siford The US Customs office New York City for your 
$950,000.00 USD Compensation Funds from Benin Government & the IMF.

Contact the US Customs Mrs.Donna Siford with your full 
info Name & Address, Here her email address: mrsdnnasiford< at >yahoo.gr, contact 
her now for your package.

Thanks,
Mrs.Penny B Williams
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(unknown)

AFG GTBANK LOAN — 2013-06-17T19:28:00



Loan Syndicacion

Am AFG Guaranty Trust Bank, zu strukturieren wir Kreditlinien treffen Sie
unsere
Kunden spezifischen geschäftlichen Anforderungen und einen deutlichen
Mehrwert für unsere
Kunden Unternehmen.
eine Division der AFG Finance und Private Bank plc.

Wenn Sie erwägen, eine große Akquisition oder ein Großprojekt sind, können
Sie
brauchen eine erhebliche Menge an Kredit. AFG Guaranty Trust Bank setzen
können
zusammen das Syndikat, das die gesamte Kredit schnürt für
Sie.


Als Bank mit internationaler Reichweite, sind wir gekommen, um Darlehen zu
identifizieren
Syndizierungen als Teil unseres Kerngeschäfts und durch spitzte diese Zeile
aggressiv sind wir an einem Punkt, wo wir kommen, um als erkannt haben
Hauptakteur in diesem Bereich.


öffnen Sie ein Girokonto heute mit einem Minimum Bankguthaben von 500 £ und
Getup zu £ 10.000 als Darlehen und auch den Hauch einer Chance und gewann
die Sterne
Preis von £ 500.000 in die sparen und gewinnen promo in may.aply jetzt.


mit dem Folowin

Re: [Ocfs2-devel] [PATCH] ocfs2: llseek need to inode cluster lockand unlock for update the inode size in SEEK_END.

Mark Fasheh — 2013-06-17T17:02:51

yes, please describe while we're taking the lock here (describing the race
you're talking about would be fine).



If we're going through the trouble of locking we *need* to put the offset
calculation inside the lock otherwise we can still get stale i_size and
basically haven't fixed anything.


Btw, do you feel that this could impact performance for other workloads that
ocfs2 usually does?
--Mark

--
Mark Fasheh
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/24] nilfs2: introduce debugging subsystem implementation

Ryusuke Konishi — 2013-06-17T17:02:35

Looks like you are trying to reinvent the wheel.

Please consider using trace events kernel API (See
Documentation/trace/events.txt and include/trace/events/xxxx.h etc),
and do not try to add own debug/tracing framework.  With the trace
events framekwork, you will be able to add flexible and switchable
debug functionalities without abusing NILFS2_DEBUG_XXXX kernel options
and printk variants.

As I usually comment to you, start small, with a simple but powerful
change, and try to keep your patchset as simple as you can.

Regards,
Ryusuke Konishi

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ocfs2: llseek need to inode cluster lock and unlock for update the inode size in SEEK_END.

shencanquan — 2013-06-17T14:48:54

We found that llseek has a bug when in SEEK_END.  it need to add the 
inode lock and unlock.
This bug can be reproduce the following scenario:
On one nodeA, open the file and then write some data to file and close 
the file .
On another nodeB , open the file and llseek the end of file . the 
position of file is old.

Signed-off-by: jensen <shencanquan< at >huawei.com>
---
  file.c |    7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/file.c b/file.c
index ff54014..4ee7c80 100644
--- a/file.c
+++ b/file.c
< at >< at > -2626,6 +2626,13 < at >< at > static loff_t ocfs2_file_llseek(struct file 
*file, loff_t offset, int whence)
      case SEEK_SET:
          break;
      case SEEK_END:
+        /*need to inode lock and unlock for update the inode size.*/
+        ret = ocfs2_inode_lock(inode, NULL, 0);
+        if (ret < 0) {
+            mlog_errno(ret);
+            goto out;
+        }
+        ocfs2_inode_unlock(inode, 0);
          offset += inode->i_size;
          break;
      case SEEK_CUR:

Re: [PATCH] writeback: plug writeback at a high level

Chris Mason — 2013-06-17T14:34:57

Quoting Dave Chinner (2013-06-14 22:50:50)

I'm a little worried about this one, just because of the impact on ssds
from plugging in the aio code:

https://lkml.org/lkml/2011/12/13/326

How exactly was your FS created?  I'll try it here.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 24/24] nilfs2: introduce option of using dynamic debugging

Vyacheslav Dubeyko — 2013-06-17T12:29:56

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 24/24] nilfs2: introduce option of using dynamic debugging

This patch implements opportunity of dynamic debugging in NILFS2 driver.
It introduces CONFIG_NILFS2_USE_PR_DEBUG kernel configuration
option. Enabling of this option results in using of pr_debug()
instead of printk() and print_hex_dump_bytes() instead of
print_hex_dump(). If CONFIG_NILFS2_USE_PR_DEBUG is not set then
debugging messages are selected for printing in system log by means of
comparing of requested flags and DBG_MASK's flags set. Otherwise, the
behaviour of of pr_debug()/print_hex_dump_bytes()s are controlled via
writing to a control file in the 'debugfs' filesystem.

If CONFIG_NILFS2_USE_PR_DEBUG option is not set then it is used
printk()/print_hex_dump() for printing debugging messages in
system log.

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/Kconfig |   22 ++++++++++++++++++++++
 fs/nilfs2/debug.h

[PATCH 14/24] nilfs2: introduce buffer management subsystem debugging output option

Vyacheslav Dubeyko — 2013-06-17T12:24:55

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 14/24] nilfs2: introduce buffer management subsystem debugging output option

This patch adds subsystem's flags for page.c module.
Flags for these modules are grouped by
CONFIG_NILFS2_DEBUG_BUFFER_MANAGEMENT kernel configuration option.
This kernel configuration option enables (or disables) debugging
output from of all above-mentioned modules.

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/Kconfig |    6 ++++++
 fs/nilfs2/debug.h |   10 ++++++++++
 2 files changed, 16 insertions(+)

diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig
index b40fd85..d6299c6 100644
--- a/fs/nilfs2/Kconfig
+++ b/fs/nilfs2/Kconfig
< at >< at > -86,6 +86,12 < at >< at > config NILFS2_DEBUG_BLOCK_MAPPING
   This option enables debugging output in alloc.c, bmap.c, btnode.c,
   btree.c, direct.c modules.
 
+config NILFS2_DEBUG_BUFFER_MANAGEMENT
+bool "Enable buffer/page management subsystem debugging output"
+defaul

[PATCH 07/24] nilfs2: implement segments subsystem debugging output

Vyacheslav Dubeyko — 2013-06-17T12:23:32

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 07/24] nilfs2: implement segments subsystem debugging output

This patch adds debugging output by means of nilfs2_debug() method
into modules that are grouped by segments subsystem debugging output
option (CONFIG_NILFS2_DEBUG_SEGMENTS_SUBSYSTEM).

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/segbuf.c  |   30 +++++++
 fs/nilfs2/segment.c |  247 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 274 insertions(+), 3 deletions(-)

diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
index dc9a913..6ee75b1 100644
--- a/fs/nilfs2/segbuf.c
+++ b/fs/nilfs2/segbuf.c
< at >< at > -73,6 +73,10 < at >< at > void nilfs_segbuf_free(struct nilfs_segment_buffer *segbuf)
 void nilfs_segbuf_map(struct nilfs_segment_buffer *segbuf, __u64 segnum,
      unsigned long offset, struct the_nilfs *nilfs)
 {
+nilfs2_debug(DBG_SEGBUF,
+"segbuf %p, segnum %llu, offset %lu, nilfs %p\n",
+segbuf

[PATCH 02/24] nilfs2: introduce base subsystem debugging output option

Vyacheslav Dubeyko — 2013-06-17T12:22:22

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 02/24] nilfs2: introduce base subsystem debugging output option

This patch adds subsystem's flags for super.c, the_nilfs.c, namei.c,
ioctl.c, inode.c, file.c, dir.c modules. Flags for these modules are
grouped by CONFIG_NILFS2_DEBUG_BASE_OPERATIONS kernel configuration
option. This kernel configuration option enables (or disables)
debugging output from of all above-mentioned modules.

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/Kconfig |   23 +++++++++++++++++++++++
 fs/nilfs2/debug.h |   21 ++++++++++++++++++++-
 2 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig
index a379d8e..d886e15 100644
--- a/fs/nilfs2/Kconfig
+++ b/fs/nilfs2/Kconfig
< at >< at > -34,4 +34,27 < at >< at > config NILFS2_DEBUG
   written to the system log.  Under normal circumstances, this
   results in very little overhead.

+if NILFS2_DEBUG
+
+config NILFS2_DEBUG_SU

[PATCH 15/24] nilfs2: implement buffer management subsystem debugging output

Vyacheslav Dubeyko — 2013-06-17T12:25:05

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 15/24] nilfs2: implement buffer management subsystem debugging output

This patch adds debugging output by means of nilfs2_debug() method
into modules that are grouped by buffer management subsystem debugging
output option (CONFIG_NILFS2_DEBUG_BUFFER_MANAGEMENT).

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/page.c |   50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
index 0ba6798..330f172 100644
--- a/fs/nilfs2/page.c
+++ b/fs/nilfs2/page.c
< at >< at > -47,6 +47,12 < at >< at > __nilfs_get_page_block(struct page *page, unsigned long block, pgoff_t index,
 unsigned long first_block;
 struct buffer_head *bh;
 
+nilfs2_debug(DBG_PAGE,
+"i_ino %lu, block %lu, index %lu, "
+"blkbits %d, b_state %#lx\n",
+page->mapping->host->i_ino,
+block, index, blkbits, b_state);
+
 if (!page_has_buffers(pag

[PATCH 13/24] nilfs2: implement block mapping subsystem debugging output

Vyacheslav Dubeyko — 2013-06-17T12:24:43

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 13/24] nilfs2: implement block mapping subsystem debugging output

This patch adds debugging output by means of nilfs2_debug() method
into modules that are grouped by block mapping subsystem debugging output
option (CONFIG_NILFS2_DEBUG_BLOCK_MAPPING).

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/alloc.c  |   15 ++++
 fs/nilfs2/bmap.c   |   81 ++++++++++++++++++++-
 fs/nilfs2/btnode.c |   28 +++++++
 fs/nilfs2/btree.c  |  205 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 fs/nilfs2/direct.c |   51 +++++++++++++
 5 files changed, 375 insertions(+), 5 deletions(-)

diff --git a/fs/nilfs2/alloc.c b/fs/nilfs2/alloc.c
index eed4d7b..2ce1fd4 100644
--- a/fs/nilfs2/alloc.c
+++ b/fs/nilfs2/alloc.c
< at >< at > -62,6 +62,10 < at >< at > int nilfs_palloc_init_blockgroup(struct inode *inode, unsigned entry_size)
 {
 struct nilfs_mdt_info *mi = NILFS_MDT(inode);
 
+nilfs2_debug(DBG_ALLOC,
+"i_

[PATCH 12/24] nilfs2: introduce block mapping subsystem debugging output option

Vyacheslav Dubeyko — 2013-06-17T12:24:31

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 12/24] nilfs2: introduce block mapping subsystem debugging output option

This patch adds subsystem's flags for alloc.c, bmap.c, btnode.c,
btree.c, direct.c modules. Flags for these modules are grouped by
CONFIG_NILFS2_DEBUG_BLOCK_MAPPING kernel configuration option.
This kernel configuration option enables (or disables) debugging
output from of all above-mentioned modules.

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/Kconfig |    7 +++++++
 fs/nilfs2/debug.h |   15 +++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig
index 5eb5140..b40fd85 100644
--- a/fs/nilfs2/Kconfig
+++ b/fs/nilfs2/Kconfig
< at >< at > -79,6 +79,13 < at >< at > config NILFS2_DEBUG_RECOVERY_SUBSYSTEM
 help
   This option enables debugging output in recovery.c module.
 
+config NILFS2_DEBUG_BLOCK_MAPPING
+bool "Enable block mapping subsystem debugging output"
+default n

[PATCH 11/24] nilfs2: implement recovery subsystem debugging output

Vyacheslav Dubeyko — 2013-06-17T12:24:19

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 11/24] nilfs2: implement recovery subsystem debugging output

This patch adds debugging output by means of nilfs2_debug() method
into modules that are grouped by recovery subsystem debugging output
option (CONFIG_NILFS2_DEBUG_RECOVERY_SUBSYSTEM).

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/recovery.c |   63 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/fs/nilfs2/recovery.c b/fs/nilfs2/recovery.c
index ff00a0b..1099ba1 100644
--- a/fs/nilfs2/recovery.c
+++ b/fs/nilfs2/recovery.c
< at >< at > -110,6 +110,11 < at >< at > static int nilfs_compute_checksum(struct the_nilfs *nilfs,
 unsigned long size;
 u32 crc;
 
+nilfs2_debug(DBG_RECOVERY,
+"nilfs %p, bhs %p, sum %p, offset %lu"
+"check_bytes %llu, start %lu, nblock %lu\n",
+nilfs, bhs, sum, offset, check_bytes, start, nblock);
+
 BUG_ON(offset >= blocksize);
 check_bytes -= offs

[PATCH 10/24] nilfs2: introduce recovery subsystem debugging output option

Vyacheslav Dubeyko — 2013-06-17T12:24:06

From: Vyacheslav Dubeyko <slava< at >dubeyko.com>
Subject: [PATCH 10/24] nilfs2: introduce recovery subsystem debugging output option

This patch adds subsystem's flags for recovery.c module.
Flags for these modules are grouped by CONFIG_NILFS2_DEBUG_RECOVERY_SUBSYSTEM
kernel configuration option. This kernel configuration option enables
(or disables) debugging output from of all above-mentioned modules.

Signed-off-by: Vyacheslav Dubeyko <slava< at >dubeyko.com>
CC: Ryusuke Konishi <konishi.ryusuke< at >lab.ntt.co.jp>
---
 fs/nilfs2/Kconfig |    6 ++++++
 fs/nilfs2/debug.h |    9 +++++++++
 2 files changed, 15 insertions(+)

diff --git a/fs/nilfs2/Kconfig b/fs/nilfs2/Kconfig
index 465b9aa..5eb5140 100644
--- a/fs/nilfs2/Kconfig
+++ b/fs/nilfs2/Kconfig
< at >< at > -73,6 +73,12 < at >< at > config NILFS2_DEBUG_GC_SUBSYSTEM
 help
   This option enables debugging output in gcinode.c module.
 
+config NILFS2_DEBUG_RECOVERY_SUBSYSTEM
+bool "Enable recovery subsystem debugging output"
+default n
+help
+  This option enables debugging output