gmane.linux.drivers.hostap

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Arend van Spriel — 2013-05-24T08:15:03

The situation is this:
1. load hwsim -> wlan0 down.
2. start wpa_supplicant -> wlan0 up, p2p-dev-wlan0 started.
3. do P2P_GROUP_ADD in wpa_cli -> p2p-wlan0-0 created.

So the -EBUSY is coming because wlan0 is UP as already.

Gr. AvS

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Johannes Berg — 2013-05-24T08:10:38


Oh. I thought it was brcmfmac. With hwsim there shouldn't be an issue.


No, P2P_DEVICE doesn't use up a channel (in hwsim.) And setting an
interface UP won't consume and require a channel anyway.

johannes

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Arend van Spriel — 2013-05-24T08:05:23

Will give it a try.


This log was testing with mac80211_hwsim, which has the following:

static const struct ieee80211_iface_limit hwsim_if_limits[] = {
{ .max = 1, .types = BIT(NL80211_IFTYPE_ADHOC) },
{ .max = 2048,  .types = BIT(NL80211_IFTYPE_STATION) |
 BIT(NL80211_IFTYPE_P2P_CLIENT) |
#ifdef CONFIG_MAC80211_MESH
 BIT(NL80211_IFTYPE_MESH_POINT) |
#endif
 BIT(NL80211_IFTYPE_AP) |
 BIT(NL80211_IFTYPE_P2P_GO) },
{ .max = 1, .types = BIT(NL80211_IFTYPE_P2P_DEVICE) },
};

static struct ieee80211_iface_combination hwsim_if_comb = {
.limits = hwsim_if_limits,
.n_limits = ARRAY_SIZE(hwsim_if_limits),
.max_interfaces = 2048,
.num_different_channels = 1,
};

Crap. num_different_channels should probably be 2 here, right?

Gr. AvS

Re: How to set a scan with ath9k driver

Matt Chen — 2013-05-24T07:47:55

INIT_DELAYED_WORK(&local->scan_work, ieee80211_scan_work);

So it would do void ieee80211_scan_work(struct work_struct *work) {.....


2013/5/24 Francisco Cuesta <ndarkness< at >gmail.com>

_______________________________________________
HostAP mailing list
HostAP< at >lists.shmoo.com
http://lists.shmoo.com/mailman/listinfo/hostap

Re: How to set a scan with ath9k driver

Francisco Cuesta — 2013-05-24T07:12:55

HEllo Mohammend, thanks for replying your sequence was really helpful

2013/5/22 Mohammed Shafi Shajakhan <mohammed< at >qca.qualcomm.com>:
I'm getting stuck since I'm looking for the function queues
ieee80211_scan_work, but I cannot identify it on my mac80211 code,
which is as follows

static int ieee80211_start_sw_scan(struct ieee80211_local *local)
{
    /*
     * Hardware/driver doesn't support hw_scan, so use software...
     */
    drv_sw_scan_start(local);

    local->leave_oper_channel_time = jiffies;
    local->next_scan_state = SCAN_DECISION;
    local->scan_channel_idx = 0;

    ieee80211_offchannel_stop_vifs(local, true);

    ieee80211_configure_filter(local);

    /* We need to set power level at maximum rate for scanning. */
    ieee80211_hw_config(local, 0);

    ieee80211_queue_delayed_work(&local->hw,
                     &local->scan_work, 0);

    return 0;
}

Is the function called ieee80211_queue_delayed_work??

Re: [PATCH] wpa_supplicant: Emit signal when the station authorizedor deauthorized in AP mode

Chengyi Zhao — 2013-05-24T01:59:29

Hi,

Please tell me how to submit this patch.

Thanks.

Chengyi

2013/5/23 Chengyi Zhao <chengyix.zhao< at >gmail.com>:

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Johannes Berg — 2013-05-23T20:48:33

You really should be on IRC ;-)


From the log it seems you get -EBUSY, which is a bit odd. Are you sure
your advertised interface combinations support what you were doing?

johannes

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Arend van Spriel — 2013-05-23T20:27:50

I actually did and it is working with brcmfmac advertising P2P_DEVICE 
and I would like to keep it in for 3.10, but it does not make much sense 
if there is no user-space support (apart from iw).

I tried getting hwsim to work with P2P_DEVICE by removing 
'p2p_no_group_iface=1' from the configuration files. wpa_supplicant will 
create a P2P_GO interface but I get a failure when bringing the 
interface up (see attached log). Creating a P2P_GO using iw and bringing 
it up with ifconfig works fine.

Gr. AvS

1369339573.419211: wpa_supplicant v2.1-devel
1369339573.419269: random: Trying to read entropy from /dev/random
1369339573.419284: Successfully initialized wpa_supplicant
1369339573.419296: Initializing interface 'wlan0' conf '/home/arend/scm/hostap/tests/hwsim/p2p0.conf' driver 'nl80211' ctrl_interface 'N/A' bridge 'N/A'
1369339573.419308: Configuration file '/home/arend/scm/hostap/tests/hwsim/p2p0.conf' -> '/home/arend/scm/hostap/tests/hwsim/p2p0.conf'
1369339573.419350: Reading configuration file '/home

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Johannes Berg — 2013-05-23T20:12:57


Yes, this is a bit unfortunate. We can probably send a patch to 3.9
stable to remove the P2P_DEVICE advertising. However, I'm not all that
worried about hwsim, and iwlmvm unfortunately is looking like we won't
be able to ship firmware that works with the driver in 3.9 given the
recent firmware changes. As such, I think there aren't and won't be any
real drivers that actually advertise P2P_DEVICE.


The current wireless-testing should have all the required fixes, can
somebody verify that?

johannes

Re: [PATCH] P2P: Add IFNAME=iface command option for interfaceredirection

Dmitry Shmidt — 2013-05-23T17:49:05

Great, thanks !

Re: [PATCH] P2P: Add IFNAME=iface command option for interfaceredirection

Jouni Malinen — 2013-05-23T17:40:34

I was thinking of quite a bit more complete integration to the existing
command completion mechanism than use of the raw command. I pushed these
commits now to address this:

http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=commitdiff;h=13b11ba70260d99de5015e06142b6168d645c169
http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=commitdiff;h=376204934db44d45f798bdde4db005bc88d666f0

I would find it quite painful if I had to live without full tab
completion support for commands and arguments.. ;-)

[PATCH] wpa_supplicant: Emit signal when the station authorized ordeauthorized in AP mode

Chengyi Zhao — 2013-05-23T02:25:16

From: Chengyi Zhao <chengyix.zhao< at >gmail.com>

Signed-off-by: Chengyi Zhao <chengyix.zhao< at >gmail.com>
---
 wpa_supplicant/dbus/dbus_new.c |   78 ++++++++++++++++++++++++++++++++++++++++
 wpa_supplicant/dbus/dbus_new.h |   16 +++++++++
 wpa_supplicant/notify.c        |    4 +++
 3 files changed, 98 insertions(+)

diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
index e9bd51f..dfd0a8b 100644
--- a/wpa_supplicant/dbus/dbus_new.c
+++ b/wpa_supplicant/dbus/dbus_new.c
< at >< at > -868,6 +868,72 < at >< at > nomem:
 dbus_message_unref(msg);
 }
 
+/**
+ * wpas_dbus_signal_sta - Send a station related event signal
+ * < at >wpa_s: %wpa_supplicant network interface data
+ * < at >sta: station address
+ * < at >sig_name: signal name - StaAuthorized or StaDeauthorized
+ *
+ * Notify listeners about event related with station
+ */
+static void wpas_dbus_signal_sta(struct wpa_supplicant *wpa_s,
+ const u8 *sta, const char *sig_name)
+{
+struct wpas_dbus_priv *iface;
+DBusMessage *msg;
+char sta_mac[WPAS_DBUS_OBJECT_PATH_M

Re: How to work with hostapd code

Arend van Spriel — 2013-05-22T20:29:47

I stopped using Eclipse for the linux kernel, but I just cloned the git 
repositories in my Eclipse workspace and add a project for it. You can 
also take a look at EGit [1].

Regards,
Arend

[1] http://www.eclipse.org/egit/

How to work with hostapd code

Francisco Cuesta — 2013-05-22T20:20:35

Hello,

I was wondering what is the better way of import the hostapd code to
Eclipse. I mean, I don´t know whether is better to work with git or
download the tar, uncompress it and load the code into Eclipse.
Indeed, I have already try to do the second option, but Eclipse
complains aboout the paths...

What is your advice?

Thanks in advance

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Arend van Spriel — 2013-05-22T20:15:59

The drivers are indicating whether P2P Device is supported. Our brcmfmac 
driver had it set to 3.9 but it was removed as wpa_supplicant had no 
support. Bit of a chicken-egg story. Also at least a number of issues in 
cfg80211 and mac80211 has been found and fixed in 3.10-rc1, so wireless 
drivers can start to consider announcing P2P Device support. A quick 
grep in v3.9 shows iwlwifi and mac80211_hwsim are the only driver 
reporting P2P Device support. That should only be true when cfg80211 and 
mac80211 changes are also applied to 3.9 kernel and those will probably 
not work because cfg80211 and mac80211 fixes are missing.

I decided to dive into hwsim tests and tested test_p2p_discovery.py with 
3.10-rc1 kernel. Device discovery works for test_discovery(), but 
Provision Discovery fails unless I create the control interfaces on 
p2p-dev-wlanX in run-tests.py. So it seems not all p2p commands are 
truly global.

The other test test_discovery_group_client also fails, but that is 
because p2p0.conf has 'p2p

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Arend van Spriel — 2013-05-22T16:13:44

I have not. Thanks.

Gr. AvS

Re: [PATCH] wpa_supplicant: Emit signal when the station connect ordisconnect the AP

Dan Williams — 2013-05-22T15:16:25

At some point there should probably be a property for
"AuthorizedStations" which is a string list containing the MAC addresses
of all authorized stations.  Otherwise a client connecting to the
supplicant after it has authorized a station has no idea that station is
authorized, because it never heard the StaConnected signal.

Also, shouldn't the signals really be "StaAuthorized" and
"StaDeauthorized" instead of Connected?  Same for the functions.  We
might want to use "connected" for something else in the future.

Dan

Re: wpa_supplicant: Issue with long scan times on startup.

Ben Greear — 2013-05-22T14:52:49

The logic that shares scan results helps a lot, and the kernel will reject
(EBUSY I think) duplicate scan attempts.  As long as supplicant backs off
in some way, I don't think the initial scan time that this patch modifies
matters too much.  I'm tempted to decrease it down to % 2, in fact...

The patch I put in recently to allow scan-on-channel when 1+ VIFS is associated is
also a big help in this case.  At least for ath9k, there is basically zero
overhead to scanning just on the working channel (we can continue processing
normal frames during the scan process).

Another reason why I don't like the initial timer is that we may
have 100 stations associated, and then we add the 101'st.  There is no
reason not to scan right away..or at least very quickly, since it will
be the only station scanning....

Thanks,
Ben

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Johannes Berg — 2013-05-22T14:08:50

Do you have

http://git.kernel.org/cgit/linux/kernel/git/linville/wireless.git/commit/?id=1b737f88dc1b05cf571e96d42f748aaff6df1eb5

johannes

Re: [PATCH 00/20] wpa_s: p2p: support nl80211 P2P_DEVICE interface

Arend van Spriel — 2013-05-22T14:03:35

The issue you saw were that pcap dump shows only probe requests, right? 
I ran hwsim tests or actually the tests in test_p2p_discovery.py and 
used cfg80211 tracing. It seems mac80211 only calls cfg80211_rx_mgmt() 
for wdev(1) and returns false as it is not registered for that. The P2P 
Device interface is wdev(2). I am not that familiar with mac80211 rx 
path, but probe request register seems to succeed for wdev(2). The 
function __ieee80211_rx_handle_packet() seems to feed the frame to the 
virtual interfaces.

Johannes, do you have any clues here? I think this is the issue that 
David saw when using my patch fixing registration of probe requests as 
that failed for him (using a mac80211 driver).

commit 1b3aa0c188ddc3f912f1ee5cd3c7207088a32751
Author: Arend van Spriel <arend< at >broadcom.com>
Date:   Mon Mar 25 14:47:25 2013 +0100

     p2p_supplicant: probe reporting should be from listen interface

     P2P listen phase is used to listen for P2P probe request messages
     from peers. The probe reporting c

Re: How to set a scan with ath9k driver

Mohammed Shafi Shajakhan — 2013-05-22T12:51:59

nl80211 nl80211_trigger_scan->rdev_scan which
calls mac80211's callback iee80211_scan 

iee80211_scan -> ieee80211_request_scan -> ieee80211_start_scan
->ieee80211_start_sw_scan -> queues ieee80211_scan_work

ieee80211_scan_work has the states 
SCAN_DECISION/SET_CHANNEL/PROBE etc

SCAN_SET_CHANNEL calls drivers ath9k_config with CONF_CHANGE_CHANNEL
flag set, please follow from there for the driver code.