gmane.linux.drivers.driver-project.devel

You shipping to Russia?

Richard Fenske — 2013-05-26T04:34:59

Good day!
My name is Richard. I live in the USA.
I would like to make a gift for my future wife. Аt the present moment It`s very important for me.
Answer please the following questions:
Do you have a possibility to send packages to Russia?
Do you accept credit cards from other countries?
What should be the maximum sum of money (in dollars) for buying a package in order to escape problems at custom?
Yours faithfully,
Richard
_______________________________________________
devel mailing list
devel< at >linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Re: [PATCH] staging: btmtk_usb: check for a valid io_buf pointer

Dan Carpenter — 2013-05-25T18:44:18

Yes.  Feel free to change it.

It's not in an IRQ and there are no spinlocks held.  We just did a
GFP_KERNEL allocation a few lines earlier in the call to
hci_alloc_dev().

regards,
dan carpenter

Re: [PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

Dan Carpenter — 2013-05-25T18:26:59

Cool.  Thanks for your work on this.

regards,
dan carpenter

Re: [PATCH] staging: btmtk_usb: cancel work when disconnect called

devendra.aaru — 2013-05-25T17:54:03

I am wrong hdev->close call will do cancel_work_sync, Please ignore this patch!

very sorry,

On Sat, May 25, 2013 at 11:13 PM, Devendra Naga <devendra.aaru< at >gmail.com> wrote:

[PATCH] staging: btmtk_usb: cancel work when disconnect called

Devendra Naga — 2013-05-26T03:13:54

when disconnect calls (driver unloads) the work that is scheduled
is still be present in kernel global workqueue, calling cancel_
work_sync makes it remove from the global workqueue.

Signed-off-by: Devendra Naga <devendra.aaru< at >gmail.com>
---
 drivers/staging/btmtk_usb/btmtk_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index ab57a4b..bf7f812 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
< at >< at > -1630,6 +1630,7 < at >< at > static void btmtk_usb_disconnect(struct usb_interface *intf)
 return;
 
 hdev = data->hdev;
+cancel_work_sync(&data->work);
 usb_set_intfdata(data->intf, NULL);
 
 if (data->isoc)

[PATCH] staging: btmtk_usb: check for a valid io_buf pointer

Devendra Naga — 2013-05-26T03:04:16

assigned to retval of kmalloc but not checked whether the allocation failed or not,
fail the registering if allocation fail

Signed-off-by: Devendra Naga <devendra.aaru< at >gmail.com>
---

Hello, 

Seems that kmalloc is called with GFP_ATOMIC flag
which is in registering stage, as since there wont be any interrupt context in this path,
may i change it to GFP_KERNEL in a subsequent patch?

Thanks
 drivers/staging/btmtk_usb/btmtk_usb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index 85bafac..ab57a4b 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
< at >< at > -1597,6 +1597,11 < at >< at > static int btmtk_usb_probe(struct usb_interface *intf,
 }
 
 data->io_buf = kmalloc(256, GFP_ATOMIC);
+if (!data->io_buf) {
+hci_free_dev(hdev);
+kfree(data);
+return -ENOMEM;
+}
 
 btmtk_usb_switch_iobase(data, WLAN);

[PATCH] staging: ozwpan: Revert last changes

Xenia Ragiadakou — 2013-05-25T03:42:45

This patch reverts the changes made by the following patches:

commit id: edea341b0477ce5d53f7341f8b8cf8c91ad54ecf
[PATCH 1/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozpd.c

commit id: b59983f525396a47cf8b28c13bbd5d5ff57859b8
[PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

commit id: 4422a6c14d0d0bfe519ec487693f1787f64b0b90
[PATCH 3/4] ozwpan: replace kfree_skb with dev_kfree_skb in ozpd.c

commit id: e241a8b61671b487e1a04b455dbd32ab965250ef
[PATCH 4/4] ozwpan: replace kfree_skb with dev_kfree_skb in ozproto.c

The reason of this revert is that dev_alloc_skb() is not defined
to be used in the allocation of socket buffers on the transmit path
but on the receive path.

Signed-off-by: Xenia Ragiadakou <burzalodowa< at >gmail.com>
---
 drivers/staging/ozwpan/ozpd.c    |   19 ++++++++++---------
 drivers/staging/ozwpan/ozproto.c |    4 ++--
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
index 26db8e3..f8b9d

Re: [PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

Xenia Ragiadakou — 2013-05-25T03:22:06

Hi Dan,

I looked more carefully at the definition of the netdev_alloc_skb()
(and dev_alloc_skb()) and it is meant to be used for the allocation
of socket buffers in the case of packet reception and not for
the allocation of socket buffers that will be used for transmission.

netdev_alloc_skb() allocates extra bytes padded to the headroom
(NET_SKB_PAD), maybe for use by the higher layers in the network
stack (i am not sure). On the transmit path there is no need
for such padding since the headers are already well specified by
the upper layers.

Another difference between the two functions, is that netdev_alloc_skb()
for sizes smaller than the page size, allocates directly a page fragment of
equal size. That maybe is an enhancement for reducing memory fragmentation
but again i am not sure.

So when i read that "sk_buff allocation is done with alloc_skb() or
dev_alloc_skb(); drivers use dev_alloc_skb()", it was probably
refering to skbs on the receive path.

However, the changes that i made in my patch target

Re: [PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

Dan Carpenter — 2013-05-23T22:10:53

Yep.  That's fine.  All four of these patches can be merged into one
and it still fits in the one change per patch rule.

regards,
dan carpenter

Re: [PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

Xenia Ragiadakou — 2013-05-23T21:57:17

You are right, since there is a net_device pointer in the function
there is no reason not to put netdev_alloc_skb().
I will fix this patch and i will try to justify it in changelog (as much as
my comprehension and my english permit it).
Also i will make all the changes in one patch, since i should not
separate function pairs I agree.

And the next time i hope that i won't be so light minded when
replacing code (i hope) ;)

Thanks,
Ksenia

CONGRATULATION LUCKY WINNER

2013-05-20T16:58:35

INTERNATIONAL Cricket Council,
( I.P.L-Cricket) Games Federation,
Street 69 London Sports City Emirates Road
P O Box 500070, LONDON
United Kingdom 
Email: claimcricket_iplaward< at >consultant.com
-------------------------------------------------------------------------------------
International Cricket Council- United Kingdom. Tel: +44 8719740362 -------------------------------------
Dear winner Congratulations!!!
The International Cricket Council (I. P.L- Cricket 2013) Games Federation is proud to congratulate you on your success as a winner of the year 2013 Cricket Star Promotion that was conducted over the internet with our automated email selecting machine. Your E-mail address emerged as one of the Hundred (100) lucky Email Addresses selected as won in the yearly Promotion (2013).You have been declared the proud winner of ( 500,000,00gbp),
Forward the following information below to the Subsidiary of Cricket Council for Payment,

Full Name, _______________________
Address, _________________________
Country,

Re: [PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

Dan Carpenter — 2013-05-23T21:18:11

No worries.


I don't know much about networking.  The problems with this patch
are:

1) No reason to apply it in the changelog.
2) The kfree_skb() wasn't updated to match.  After sending my email
   I saw that you fixed this in a later patch and I sent a grumpier
   than necessary email.  Sorry.  Splitting that up into two patches
   breaks git bisect so it's not allowed.  Anyways, it's a newbie
   mistake.  No worries again.
3) The comments on dev_alloc_skb() say it's obsolete and we should
   use netdev_alloc_skb() instead.

I don't actually know when it's appropriate to use one or the other
honestly...  It could be that you're right about this here.  I
honestly don't know, so that's why it has to be explained to me in
the changelog.

regards,
dan carpenter

Re: [PATCH 00/33] devm improvement series, part 1, take 2

Thierry Reding — 2013-05-23T20:32:43

Sorry for jumping in so late. I generally like the idea. One small
inconvenience is that devm_ioremap_resource() returns -EINVAL if
res == NULL, which means that drivers will now also return -EINVAL
in cases where no resource was returned. Typically drivers handle
this by returning something like -ENODEV, -ENXIO, -ENOENT. Some do
return -EINVAL but perhaps having a separate error code (and maybe
error message as well) for a missing resource would be helpful.

Doing this would be rather easy now that you've paved the way by
making devm_ioremap_resource() usage consistent across drivers.

Thierry
_______________________________________________
devel mailing list
devel< at >linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[PATCH 77/77] staging: comedi: usbduxsigma: tidy up the multi-line comments

H Hartley Sweeten — 2013-05-23T20:09:45

Modify the multi-line comments to follow the CodingStyle.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 40 +++++++++++++++-------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index b42ef8c..898c3c4 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -1,25 +1,27 < at >< at >
 /*
-   comedi/drivers/usbdux.c
-   Copyright (C) 2011 Bernd Porr, Bernd.Porr< at >f2s.com
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but

[PATCH 76/77] staging: comedi: usbduxsigma: remove a space before tab

H Hartley Sweeten — 2013-05-23T20:09:25

checkpatch.pl reports:

WARNING: please, no space before tabs
+^Ihigh_speed = 0; ^I/* (devpriv->high_speed) */$

Remove the space to avoid the warning.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index a5883be..b42ef8c 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -898,7 +898,7 < at >< at > static int usbduxsigma_ao_cmdtest(struct comedi_device *dev,
 unsigned int flags;
 
 /* high speed conversions are not used yet */
-high_speed = 0; /* (devpriv->high_speed) */
+high_speed = 0;/* (devpriv->high_speed) */
 
 /* Step 1 : check if triggers are trivially valid */

[PATCH 75/77] staging: comedi: usbduxsigma: tidy up chanToInterval()

H Hartley Sweeten — 2013-05-23T20:09:08

Rename the function to have namespace associated with the driver.
Rename the CamelCase parameter 'nChannels' to avoid the checkpatch.pl
warning.

Tidy up the function a bit.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index e070477..a5883be 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -502,16 +502,13 < at >< at > static int usbduxsigma_submit_urbs(struct comedi_device *dev,
 return 0;
 }
 
-static int chanToInterval(int nChannels)
+static int usbduxsigma_chans_to_interval(int num_chan)
 {
-if (nChannels <= 2)
-/* 4kHz */
-return 2;
-if (nChannels <= 8)
-/* 2kHz */
-return 4;
-/* 1kHz */
-return 8;
+if (num_c

[PATCH 74/77] staging: comedi: usbduxsigma: add missing spaces reported by checkpatch.pl

H Hartley Sweeten — 2013-05-23T20:08:51

checkpatch.pl reports:

ERROR: space required after that ',' (ctx:VxV)
+               dev_dbg(dev->class_dev,"CRC error in ISO IN stream\n");
                                      ^

ERROR: spaces required around that '=' (ctx:VxW)
+       struct usbduxsigma_private *devpriv= dev->private;
                                           ^
Add the missing spaces to avoid the error.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index ee2b0ba..e070477 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -244,7 +244,7 < at >< at > static void usbduxsigma_ai_urb_complete(struct urb *urb)
  * we don't copy the data into the transfer buffer
  * and recy

[PATCH 73/77] staging: comedi: usbduxsigma: rename CamelCase vars in private data

H Hartley Sweeten — 2013-05-23T20:08:33

Rename the CamelCase variables in the private data to avoid the
checkpatch.pl warning.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 158 +++++++++++++--------------
 1 file changed, 79 insertions(+), 79 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 34a6369..ee2b0ba 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -147,24 +147,24 < at >< at > static const struct comedi_lrange usbduxsigma_ai_range = {
 
 struct usbduxsigma_private {
 /* actual number of in-buffers */
-int numOfInBuffers;
+int n_ai_urbs;
 /* actual number of out-buffers */
-int numOfOutBuffers;
+int n_ao_urbs;
 /* ISO-transfer handling: buffers */
-struct urb **urbIn;
-struct urb **urbOut;
+struct urb **ai_urbs;
+struct urb **ao_urbs;
 /* pwm-trans

[PATCH 72/77] staging: comedi: usbduxsigma: remove some unused defines

H Hartley Sweeten — 2013-05-23T20:08:14

These defines are not used in the driver. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 8011191..34a6369 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -64,16 +64,6 < at >< at > Status: testing
 /* internal addresses of the 8051 processor */
 #define USBDUXSUB_CPUCS 0xE600
 
-/*
- * the minor device number, major is 180 only for debugging purposes and to
- * upload special firmware (programming the eeprom etc) which is not
- * compatible with the comedi framwork
- */
-#define USBDUXSUB_MINOR 32
-
-/* max lenghth of the transfer-buffer for software upload */
-#define TB_LEN 0x2000
-
 /* USB endpoints */
 #define USBDUXSIGMA_CMD_OUT

[PATCH 71/77] staging: comedi: usbduxsigma: tidy up the usb endpoint defines

H Hartley Sweeten — 2013-05-23T20:07:53

Rename the defines so they have namespace associated with the driver.
Tidy up the defines.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 32 +++++++++++-----------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 6358383..8011191 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -74,20 +74,12 < at >< at > Status: testing
 /* max lenghth of the transfer-buffer for software upload */
 #define TB_LEN 0x2000
 
-/* Input endpoint number: ISO/IRQ */
-#define ISOINEP           6
-
-/* Output endpoint number: ISO/IRQ */
-#define ISOOUTEP          2
-
-/* This EP sends DUX commands to USBDUX */
-#define COMMAND_OUT_EP     1
-
-/* This EP receives the DUX commands from USBDUX */
-#define COMMAND

[PATCH 69/77] staging: comedi: usbduxsigma: rename usbdux_{ai, ao}_stop() functions

H Hartley Sweeten — 2013-05-23T20:07:14

Rename the functions so they have namespace associated with the driver.

For aesthetic reasons, pass the comedi_device pointer instead of the
private data pointer as the first parameter.

Signed-off-by: H Hartley Sweeten <hsweeten< at >visionengravers.com>
Cc: Ian Abbott <abbotti< at >mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh< at >linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 34 ++++++++++++++++------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 64d27a6..8938305 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
< at >< at > -213,8 +213,10 < at >< at > struct usbduxsigma_private {
 struct semaphore sem;
 };
 
-static void usbdux_ai_stop(struct usbduxsigma_private *devpriv, int do_unlink)
+static void usbduxsigma_ai_stop(struct comedi_device *dev, int do_unlink)
 {
+struct usbduxsigma_private *devpriv = dev->private;
+
 if (do_unlink)