gmane.linux.davinci

Re: [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support

Sekhar Nori — 2013-06-18T10:19:59

void __iomem *xbar;


Please drop unnecessary casting. Simply:

mux = readl(xbar + offset);


Fix the writel likewise.


Please fix the alignment here.

Thanks,
Sekhar

Re: [PATCH v11 2/8] ARM: edma: Add DT and runtime PM support to theprivate EDMA API

Sekhar Nori — 2013-06-18T09:39:47

On 6/18/2013 12:08 PM, Joel A Fernandes wrote:

These functions dont get used here. Can you introduce them when you
actually need them?


rsv_slots is unused. You get an unused variable warning here. rsv_chans
is also unused.


n_tc is not used in the driver AFAICS. You can drop this line and also
possibly remove the platform data member as well.


Extra empty line here.


Usage of devres APIs in this function is nice, but, there is no check
for return value of edma_of_parse_dt() in the probe down below. So in
effect it leaks memory on error.


Nit: just {NULL} is enough.


No need for this change. C array initialization will initialize missing
values to 0.


res and len should disappear once you rebase to Prabhakar's patch. That
patch is present in v3.11/soc-2 branch of my tree. Please rebase your
series to that.


This hunk doesnt really belong here. You can merge it with the patch
which introduces EDMA support to AM335x.


This causes a bunch of gcc and sparse warnings in devices-da8xx.c (and
probably el

Re: [PATCH v2] ARM: edma: Convert to devm_* api

Prabhakar Lad — 2013-06-18T08:45:13

Hi Sekhar,

On Tue, Jun 18, 2013 at 2:05 PM, Sekhar Nori <nsekhar-l0cyMroinI0< at >public.gmane.org> wrote:
Thanks for fixing it.

Regards,
--Prabhakar Lad

Re: [PATCH v2] ARM: edma: Convert to devm_* api

Sekhar Nori — 2013-06-18T08:35:15

Nice clean-up. The patch did not build since <linux/err.h> was not
included. I fixed it locally and applied to v3.11/soc-2 branch of my tree.

Thanks,
Sekhar

[PATCH v11 4/8] ARM: dts: add AM33XX EDMA support

Joel A Fernandes — 2013-06-18T06:38:15

From: Matt Porter <mdp-l0cyMroinI0< at >public.gmane.org>

Adds AM33XX EDMA support to the am33xx.dtsi as documented in
Documentation/devicetree/bindings/dma/ti-edma.txt

Joel: Drop DT entries that are non-hardware-description for now as discussed in [1]

[1] https://patchwork.kernel.org/patch/2226761/

Signed-off-by: Matt Porter <mporter-l0cyMroinI0< at >public.gmane.org>
Signed-off-by: Joel A Fernandes <joelagnel-l0cyMroinI0< at >public.gmane.org>
---
 arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index d9cad72..3d59bb3 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
< at >< at > -89,6 +89,18 < at >< at >
 reg = <0x48200000 0x1000>;
 };
 
+edma: edma< at >49000000 {
+compatible = "ti,edma3";
+ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
+reg =<0x49000000 0x10000>,
+<0x44e10f90 0x10>;
+interrupts = <12 13 14>;
+#dma-cells = <1>;
+dma-channels = <64>;
+ti,edma-regions =

[PATCH v11 1/8] dmaengine: edma: Add TI EDMA device tree binding

Joel A Fernandes — 2013-06-18T06:38:12

From: Matt Porter <mdp-l0cyMroinI0< at >public.gmane.org>

The binding definition is based on the generic DMA controller
binding.

Joel:
* Droped reserved and queue DT entries from Documentation
for now from the original patch series (v10)
* Included properties in Documentation and clarified DMA properties (V11)
* Made ti,hwmod option
* Clarified DMA entries

Signed-off-by: Matt Porter <mporter-l0cyMroinI0< at >public.gmane.org>
Signed-off-by: Joel A Fernandes <joelagnel-l0cyMroinI0< at >public.gmane.org>
---
 Documentation/devicetree/bindings/dma/ti-edma.txt |   34 +++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt

diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt b/Documentation/devicetree/bindings/dma/ti-edma.txt
new file mode 100644
index 0000000..9fbbdb7
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
< at >< at > -0,0 +1,34 < at >< at >
+TI EDMA
+
+Required properties:
+- compatible : "ti,edma3"
+- ti,edma-regions: Number of re

[PATCH v11 2/8] ARM: edma: Add DT and runtime PM support to theprivate EDMA API

Joel A Fernandes — 2013-06-18T06:38:13

From: Matt Porter <mporter-l0cyMroinI0< at >public.gmane.org>

Adds support for parsing the TI EDMA DT data into the required EDMA
private API platform data. Enables runtime PM support to initialize
the EDMA hwmod. Enables build on OMAP.

Changes by Joel:
* Setup default one-to-one mapping for queue_priority and queue_tc
mapping as discussed in [1].
* Split out xbar stuff to separate patch. [1]

[1] https://patchwork.kernel.org/patch/2226761/

Signed-off-by: Matt Porter <mporter-l0cyMroinI0< at >public.gmane.org>
Acked-by: Sekhar Nori <nsekhar-l0cyMroinI0< at >public.gmane.org>
Signed-off-by: Joel A Fernandes <joelagnel-l0cyMroinI0< at >public.gmane.org>
---
 arch/arm/common/edma.c             |  190 +++++++++++++++++++++++++++++++++---
 arch/arm/mach-omap2/Kconfig        |    1 +
 include/linux/platform_data/edma.h |    4 +-
 3 files changed, 181 insertions(+), 14 deletions(-)

diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index a1db6cd..9823b79 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
< at >< at >

[PATCH v11 0/8] ] DMA Engine support for AM33XX

Joel A Fernandes — 2013-06-18T06:38:11

This series is a repost of Matt Porter's EDMA patches for AM33XX EDMA support
with changes for few pending review comments on v9 series.

Currently this is required for AM33XX (Beaglebone or EVM) to access MMC
and be able mount to rootfs and boot till command prompt over MMC.
Unless there are other pending review comments, I hope this series can
make it into 3.11 merge window, the dependent series has been posted at [1]
and completed review.

Tested EDMA on AM1808 EVM and AM33XX Beaglebone with MMC.

Sekhar Nori has posted a GIT PULL [1] which has 2 patches this series depends on:
[1] http://www.spinics.net/lists/arm-kernel/msg251503.html

Changes since v10:
- Reworked documentation based on Arnd's feedback
- Moved EDMA bindings documentation earlier in series
- Dropped mention on am33xx on 2/8 and 3/8 in the series

Changes since v9:
    - Droped reserved and queue DT entries from Documentation
    for now from the original patch series.
    - Drop DT entries that are non-hardware-description
    - Split

[PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support

Joel A Fernandes — 2013-06-18T06:38:14

From: Matt Porter <mporter-l0cyMroinI0< at >public.gmane.org>

Changes by Joel:
* Split EDMA xbar support out of original EDMA DT parsing patch
to keep it easier for review.
* Rewrite shift and offset calculation.

Suggested-by: Sekhar Nori <nsekhar-l0cyMroinI0< at >public.gmane.org>
Suggested by: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
Signed-off-by: Joel A Fernandes <joelagnel-l0cyMroinI0< at >public.gmane.org>

Reference:
[1] https://patchwork.kernel.org/patch/2226991/
---
 arch/arm/common/edma.c             |   59 ++++++++++++++++++++++++++++++++++++
 include/linux/platform_data/edma.h |    1 +
 2 files changed, 60 insertions(+)

diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index 9823b79..1c2fb15 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
< at >< at > -1410,6 +1410,52 < at >< at > static int edma_of_read_u32_to_s16_array(const struct device_node *np,
 return 0;
 }
 
+static int edma_xbar_event_map(struct device *dev,
+       struct device_node *node,
+       st

Re: [PATCH v10 0/8] DMA Engine support for AM33XX

Sekhar Nori — 2013-06-18T05:48:18

Joel,

When you respin this, please base on top of Prabhakar's clean-up titled:
"ARM: edma: Convert to devm_* api".

Or better still, include his patch in your series.

Thanks,
Sekhar

[GIT PULL v2] DaVinci SoC updates for v3.11

Sekhar Nori — 2013-06-18T05:45:12

Hi Olof,

Here is an updated version of this pull request with Mark's
and your Acks added to the dma code movement.

Thanks,
Sekhar

The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:

  Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/linux-davinci.git tags/davinci-for-v3.11/soc-v2

for you to fetch changes up to 7bb5d75ce91ca3725256c0d502624ed697231cde:

  ARM: edma: remove unused transfer controller handlers (2013-06-18 10:53:13 +0530)

----------------------------------------------------------------
DaVinci SoC changes for v3.11

This pull request moves DaVinci EDMA library to
arch/arm/common so it can be used by OMAP based AM335x.
This is a temporary step until all drivers are converted
to use the dmaengine driver in drivers/dma/edma.c.

Several drivers like SPI, MMC/SD have already been converted.
Some like audio are pending.

The other two patches in the pull request are cleanup in nat

Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

Sekhar Nori — 2013-06-18T04:40:51

On 6/17/2013 9:10 PM, Fernandes, Joel A wrote:

I have already asked for ti,hwmods to be made optional. Please see my
comment from yesterday.

Thanks,
Sekhar

Re: [PATCH v10 1/2] ARM: davinci: move private EDMA API to arm/common

Sekhar Nori — 2013-06-18T04:34:28

PRIV is short for "private". We will get rid of TI_PRIV_EDMA along with
all users of private DMA API (including audio). TI_EDMA and TI_PRIV_EDMA
denote different things and we cannot reuse one for the other.

Thanks,
Sekhar

RE: [PATCH v10 1/2] ARM: davinci: move private EDMA API to arm/common

Fernandes, Joel A — 2013-06-17T17:55:42

Hi Olof,

 [Joel] TI_EDMA already exists. It is used to build drivers/dma/edma.
I have a patch that reuses the TI_EDMA option instead of the PRIV one . I will
include that In my v11 series for EDMA (v10 was just posted) . If its ok, let us
merge Sekhar's patch as-is, and then mine will get rid of the PRIV option
(among other things).

Thanks,
Joel

Re: [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management

Tony Lindgren — 2013-06-17T17:27:52

* Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A< at >public.gmane.org> [130617 09:14]:

In most cases all the pins can be released reliably if
the pinctrl driver won't do anything with the pins on
release.

After all that's what bootloaders have been doing for
ages :)


Hmm maybe I need to try it again. The last time I tried
I had to comment those out, but that was a while back.
And I probably had also some other hack to release pins.

Regards,

Tony

RE: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

Fernandes, Joel A — 2013-06-17T16:25:31


 
[Joel] 
Ah! Will fix, it's a channel number.

Thanks,
Joel

RE: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

Fernandes, Joel A — 2013-06-17T15:40:29

Hi Arnd,

 
[Joel] Thanks for the suggestion, I updated it and it looks like this now:
                                                                                                             
Required properties:                                                                                                                   
- compatible : "ti,edma3"                                                                                                              
- ti,hwmods: Name of the hwmods associated to the EDMA                                                                                 
- ti,edma-regions: Number of regions                                                                                                   
- ti,edma-slots: Number of slots
- #dma-cells: Should be set to <1> 
              Clients should use a single number per DMA channel request.
- dma-channels: Specify total DMA channels per CC                                                                                      
- r

[PATCH v4 04/11] media: davinci: vpif_capture: move the freeing ofirq and global variables to remove()

Prabhakar Lad — 2013-06-17T15:20:44

From: "Lad, Prabhakar" <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>

Ideally the freeing of irq's and the global variables needs to be
done in the remove() rather than module_exit(), this patch moves
the freeing up of irq's and freeing the memory allocated to channel
objects to remove() callback of struct platform_driver.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
---
 drivers/media/platform/davinci/vpif_capture.c |   29 ++++++++++---------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
index d004531..7d3c449 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
< at >< at > -2159,17 +2159,27 < at >< at > vpif_int_err:
  */
 static int vpif_remove(struct platform_device *device)
 {
-int i;
 struct channel_obj *ch;
+struct resource *res;
+int irq_num, i = 0;
+
+while ((res = platform_get_reso

[PATCH v4 02/11] media: davinci: vpif: Convert to devm_* api

Prabhakar Lad — 2013-06-17T15:20:42

From: "Lad, Prabhakar" <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>

Use devm_ioremap_resource instead of reques_mem_region()/ioremap().
This ensures more consistent error values and simplifies error paths.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw< at >public.gmane.org>
---
 drivers/media/platform/davinci/vpif.c |   27 ++++-----------------------
 1 file changed, 4 insertions(+), 23 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
index 761c825..164c1b7 100644
--- a/drivers/media/platform/davinci/vpif.c
+++ b/drivers/media/platform/davinci/vpif.c
< at >< at > -37,8 +37,6 < at >< at > MODULE_LICENSE("GPL");
 #define VPIF_CH2_MAX_MODES(15)
 #define VPIF_CH3_MAX_MODES(02)
 
-static resource_size_tres_len;
-static struct resource*res;
 spinlock_t vpif_lock;
 
 void __iomem *vpif_base;
< at >< at > -421,23 +419,12 < at >< at > EXPORT_SYMBOL(vpif_channel_getfid);
 
 stat

[PATCH v4 03/11] media: davinci: vpif: remove unnecessary bracesaround defines

Prabhakar Lad — 2013-06-17T15:20:43

From: "Lad, Prabhakar" <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>

This patch removes unnecessary braces around defines.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg-Re5JQEeQqe8AvxtiuMwx3w< at >public.gmane.org>
Acked-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw< at >public.gmane.org>
---
 drivers/media/platform/davinci/vpif.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
index 164c1b7..cd08e52 100644
--- a/drivers/media/platform/davinci/vpif.c
+++ b/drivers/media/platform/davinci/vpif.c
< at >< at > -32,10 +32,10 < at >< at >
 MODULE_DESCRIPTION("TI DaVinci Video Port Interface driver");
 MODULE_LICENSE("GPL");
 
-#define VPIF_CH0_MAX_MODES(22)
-#define VPIF_CH1_MAX_MODES(02)
-#define VPIF_CH2_MAX_MODES(15)
-#define VPIF_CH3_MAX_MODES(02)
+#define VPIF_CH0_MAX_MODES22
+#define VPIF_CH1_MAX_MODES2
+#define VPIF_CH2_MAX_MODES15
+#define VPIF_CH3_MAX_MODES2
 
 spinlock_t vpif_lock;

Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

Sekhar Nori — 2013-06-17T11:01:24

Grant, Rob,

Can one of you please take a look at this patch and see if you have any
comments on the binding definition?

Joel,

Ideally the bindings are described before they are used or along with
its usage. In that aspect, this patch is present too far back in the
series. Can you please fix this if you get to posting another version. I
think I gave the same comment on v9 as well.

On 6/15/2013 8:02 AM, Joel A Fernandes wrote:

ti,hwmods should be optional, no? hwmod is not present on DaVinci where
EDMA is also used. If it is not optional then these bindings wont work
there.

Thanks,
Sekhar