gmane.linux.can

Re: facing some problem with flexcan driver

Marc Kleine-Budde — 2013-05-21T06:56:21

----->8--------

Does the patch fix your problem?

regards,
Marc

Re: [PATCH] net/can/mcp251x: Use module_spi_driver to register driver

Peter Hüwe — 2013-05-20T20:17:29

Am Montag, 20. Mai 2013, 21:53:31 schrieb Marc Kleine-Budde:


Thanks for noticing!
I was unfortunately working on a stale tree - sorry for the noise.

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/can/mcp251x: Use module_spi_driver to register driver

Marc Kleine-Budde — 2013-05-20T19:53:31

A similar patch [1] by Lars-Peter Clausen hit mainline in v3.10-rc1.

thanks, Marc

[1] 01b8807 can: mcp251x: Use module_spi_driver

[PATCH] net/can/mcp251x: Use module_spi_driver to register driver

Peter Huewe — 2013-05-20T19:49:59

Removing some boilerplate by using module_spi_driver instead of calling
register and unregister in the otherwise empty init/exit functions

Signed-off-by: Peter Huewe <peterhuewe< at >gmx.de>
---
 drivers/net/can/mcp251x.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
index f32b9fc..7a42e0f 100644
--- a/drivers/net/can/mcp251x.c
+++ b/drivers/net/can/mcp251x.c
< at >< at > -1218,19 +1218,7 < at >< at > static struct spi_driver mcp251x_can_driver = {
 .resume = mcp251x_can_resume,
 };
 
-static int __init mcp251x_can_init(void)
-{
-return spi_register_driver(&mcp251x_can_driver);
-}
-
-static void __exit mcp251x_can_exit(void)
-{
-spi_unregister_driver(&mcp251x_can_driver);
-}
-
-module_init(mcp251x_can_init);
-module_exit(mcp251x_can_exit);
-
+module_spi_driver(mcp251x_can_driver);
 MODULE_AUTHOR("Chris Elston <celston< at >katalix.com>, "
       "Christian Pellegrin <chripell< at >evolware.org>");
 MODULE_DESCRIPTION("Microchip 251x CAN driver");

Re: [PATCH] can: flexcan: Use SIMPLE_DEV_PM_OPS

Marc Kleine-Budde — 2013-05-20T18:47:08

Please just indent with one space after ".pm". No need to resend, I'll
fix it while applying it to linux-can-next.

tnx, Marc

[PATCH] can: flexcan: Use SIMPLE_DEV_PM_OPS

Fabio Estevam — 2013-05-20T18:43:43

Using SIMPLE_DEV_PM_OPS can make the code smaller and simpler.
    
Also change CONFIG_PM to CONFIG_PM_SLEEP.

Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 drivers/net/can/flexcan.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 4a40a18..d85d9ff 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
< at >< at > -1137,10 +1137,10 < at >< at > static int flexcan_remove(struct platform_device *pdev)
 return 0;
 }
 
-#ifdef CONFIG_PM
-static int flexcan_suspend(struct platform_device *pdev, pm_message_t state)
+#ifdef CONFIG_PM_SLEEP
+static int flexcan_suspend(struct device *device)
 {
-struct net_device *dev = platform_get_drvdata(pdev);
+struct net_device *dev = dev_get_drvdata(device);
 struct flexcan_priv *priv = netdev_priv(dev);
 
 flexcan_chip_disable(priv);
< at >< at > -1154,9 +1154,9 < at >< at > static int flexcan_suspend(struct platform_device *pdev, pm_message_t state)
 return 0;
 }
 
-static in

Re: [PATCH v2] can: flexcan: remove HAVE_CAN_FLEXCAN Kconfig symbol

Marc Kleine-Budde — 2013-05-20T16:06:24

Thanks.

An Acked-by by the powerpc people would be fine. However, if nobody
doesn't object, I'm sending this patch via linux-can and net-next upstream.

regards,
Marc

[PATCH 2/2] can: flexcan: Let device core handle pinctrl

Fabio Estevam — 2013-05-20T13:06:18

Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove 
devm_pinctrl_get_select_default() from the driver.

Cc: Marc Kleine-Budde <mkl< at >pengutronix.de>
Cc: <linux-can< at >vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam< at >freescale.com>
---
 drivers/net/can/flexcan.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 4a40a18..a93cdb2 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
< at >< at > -37,7 +37,6 < at >< at >
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
-#include <linux/pinctrl/consumer.h>
 
 #define DRV_NAME"flexcan"
 
< at >< at > -1004,16 +1003,11 < at >< at > static int flexcan_probe(struct platform_device *pdev)
 struct flexcan_priv *priv;
 struct resource *mem;
 struct clk *clk_ipg = NULL, *clk_per = NULL;
-struct pinctrl *pinctrl;
 void __iomem *base;
 resource_size_t mem_size;
 int err, irq;
 u32 clock_f

Re: [PATCH v2] can: flexcan: remove HAVE_CAN_FLEXCAN Kconfig symbol

Shawn Guo — 2013-05-17T09:09:51

Acked-by: Shawn Guo <shawn.guo< at >linaro.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] can: flexcan: remove HAVE_CAN_FLEXCAN Kconfig symbol

Marc Kleine-Budde — 2013-05-17T08:59:17

This patch removes the Kconfig symbol HAVE_CAN_FLEXCAN from arch/{arm,powerpc}
and allowing compilation unconditionally on all arm and powerpc platforms.

This brings a bigger compile time coverage and removes the following dependency
warning found by Arnd Bergmann:

    warning: (SOC_IMX28 && SOC_IMX25 && SOC_IMX35 && IMX_HAVE_PLATFORM_FLEXCAN &&
        SOC_IMX53 && SOC_IMX6Q) selects HAVE_CAN_FLEXCAN
    which has unmet direct dependencies (NET && CAN && CAN_DEV)

Cc: Arnd Bergmann <arnd< at >arndb.de>
Cc: Shawn Guo <shawn.guo< at >linaro.org>
Cc: Sascha Hauer <s.hauer< at >pengutronix.de>
Cc: Kumar Gala <galak< at >kernel.crashing.org>
Cc: U Bhaskar-B22300 <B22300< at >freescale.com>
Cc: linux-arm-kernel< at >lists.infradead.org
Cc: linuxppc-dev< at >lists.ozlabs.org
Signed-off-by: Marc Kleine-Budde <mkl< at >pengutronix.de>
---
Changes since v1:
- don't remove IMX_HAVE_PLATFORM_FLEXCAN, which breaks non DT imx platforms
  tnx Shawn

 arch/arm/mach-imx/Kconfig         | 4 ----
 arch/arm/mach-imx/devices/Kconfig | 1 -
 arch/arm/mach-mxs/Kconfig

Re: [PATCH] can: flexcan: allow compilation on arm and powerpc

Marc Kleine-Budde — 2013-05-17T08:51:00

Doh! - I've removed too much, will change.

Tnx,
Marc

Re: [PATCH] can: flexcan: allow compilation on arm and powerpc

Shawn Guo — 2013-05-17T02:03:52

Hi Marc,

On Thu, May 16, 2013 at 03:42:36PM +0200, Marc Kleine-Budde wrote:

I'm generally fine with the approach.  But with Kconfig symbol
IMX_HAVE_PLATFORM_FLEXCAN removed, how does the build of
platform-flexcan.o work?

arch/arm/mach-imx/devices/Makefile:obj-$(CONFIG_IMX_HAVE_PLATFORM_FLEXCAN) += platform-flexcan.o

Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: pull-request: can-next 2013-05-16

David Miller — 2013-05-17T00:12:46

From: Marc Kleine-Budde <mkl< at >pengutronix.de>
Date: Thu, 16 May 2013 14:51:56 +0200

 ...

Pulled, thanks Marc.
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: command ip -details -statistics link show wlan0

Ernast Sevo — 2013-05-16T16:37:27

Great! Thank you very much for all your help! And I will take a closer
look at that optimized driver.

Best,

 Ernast

On Thu, May 16, 2013 at 11:43 AM, Wolfgang Grandegger <wg< at >grandegger.com> wrote:

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: command ip -details -statistics link show wlan0

Wolfgang Grandegger — 2013-05-16T15:43:01

Hi Ernast,

please don't frop the CC to the mailing list...

On 05/16/2013 05:32 PM, Ernast Sevo wrote:

That would be my guess as well.


You may try to increase the priority of the MCP2515 IRQ thread.

Recently I also stumbled over the following optimized driver for the
MCP2515:

  http://clientes.netvisao.pt/anbadeol/mcp2515.html

But that would required some effort to update and test it.

Wolfgang.

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: command ip -details -statistics link show wlan0

Marc Kleine-Budde — 2013-05-16T15:37:53



Yes, exactly.


If you don't get any dropped frames reported via SO_RXQ_OVFL (see
Wolfgang mail) you can be sure they are lost at the hardware level. I
suggest don't use the mcp251x, it's really slow and puts heavy load on
the machine. However there might be some knobs to tune in your SPI
controller/driver.

Marc

Re: command ip -details -statistics link show wlan0

Ernast Sevo — 2013-05-16T15:32:00

Yes I am using MCP2515. I am getting a couple of rx buffer overflow errors
so I was wondering how these errors corresponded to packet loss,
whether this is a 1:1 relationship or 1:N relationship (if i am
interpretting Marc's post
correctly should I assume 1:1 for best case and 1:N for worst case? ).
Essentially I am trying to determine at what speed i can have stuff
coming in before
I start losing packets for any reason. I know how to account packets
lost in userspace
 and packets lost by the driver (which you mentioned above) and now I
am trying to
account for packets lost at the hardware level. Knowing how these rx buffer
overflow/overrun errors correspond to packet loss would help make my
data more accurate and reliable.

Thanks,

Ernast
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: command ip -details -statistics link show wlan0

Marc Kleine-Budde — 2013-05-16T13:45:16

This depends on the hardware/driver. But usually that means 11 overrun
events, which means _at_least_ 11 CAN frames lost.

Marc

command ip -details -statistics link show wlan0

Ernast Sevo — 2013-05-16T13:43:38



Hi Wolfgang,

That definitely clears things up a bit. One more question though. Does
the number in
overrun or the number in errors from the command above then directly
refer to the number
of packets lost on the hardware level due to there being no space to
store it (i.e 11 overrun or
errors means 11 packets lost) ?

Thanks again,

Ernast
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo< at >vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

pull-request: can-next 2013-05-16

Marc Kleine-Budde — 2013-05-16T12:51:56

Hello David,

this is a pull-request for net-next/master. It consists of 4 patches by
Jingoo Han, which remove the unnecessary platform_set_drvdata() and a
patch by Laurent Navet converting the grcan driver to use
devm_ioremap_resource().

regards,
Marc

---

The following changes since commit dbbffe6898fd0d7bac66ded5d3c58835b13ddefc:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2013-05-13 13:25:36 -0700)

are available in the git repository at:


  git://gitorious.org/linux-can/linux-can-next.git for-davem

for you to fetch changes up to 5727dc6bf5b70dd278e58e26137e2df729b9c107:

  net: can: ti_hecc: remove unnecessary platform_set_drvdata() (2013-05-16 13:27:20 +0200)

----------------------------------------------------------------
Jingoo Han (4):
      net: can: at91_can: remove unnecessary platform_set_drvdata()
      net: can: c_can: remove unnecessary platform_set_drvdata()
      net: can: flexcan: remove unnecessary platform_set_drvdata()
      net: can: ti_hecc: remove unnecessa

Re: [PATCH] drivers: net: can: grcan: use devm_ioremap_resource()

Marc Kleine-Budde — 2013-05-16T11:50:00

The "IS_ERR(base)" ...


... introduces this sparse warning:


I think it's the __iomem annotation of the void pointer that
devm_ioremap_resource() returns. Is there a clever way to improve IS_ERR
and PTR_ERR?

Marc