gmane.linux.alsa.devel

[PATCH1/1] hda: digital slave support for IDT codecs

Matthew Ranostay — 2008-09-07T18:36:53

Added slave_dig_outs entries for several IDT codecs that have multiple SPDIF outs, and enabled these SPDIF outs in several pin configs. --- Signed-off-by: Matthew Ranostay embeddedalley.com> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index 9968ee4..52b3579 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c < at >< at > -229,6 +229,10 < at >< at > static hda_nid_t stac92hd73xx_pwr_nids[8] = { 0x0f, 0x10, 0x11 }; +static hda_nid_t stac92hd73xx_slave_dig_outs[2] = { +0x26, 0, +}; + static hda_nid_t stac92hd73xx_adc_nids[2] = { 0x1a, 0x1b }; < at >< at > -274,6 +278,10 < at >< at > static hda_nid_t stac92hd83xxx_pwr_nids[4] = { 0xa, 0xb, 0xd, 0xe, }; +static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = { +0x1e, 0, +}; + static unsigned int stac92hd83xxx_pwr_mapping[4] = { 0x03, 0x0c, 0x10, 0x40, }; < at >< at > -303,6 +311,10 < at >< at > static hda_nid_t stac92hd71bxx_dmic_nids[STAC92HD71BXX_NUM_DMICS + 1] = { 0x18, 0x19, 0 }; +static hda_nid_t stac92hd71bxx_slave_dig_outs[2] = { +0x22, 0 +}; +

[PATCH0/1] hda: slave digital out support

Matthew Ranostay — 2008-09-07T18:31:40

Added support for playing a stream on multiple digital outs. This is done by defining codec->slave_dig_outs as array of hda_nid_t with a null-terminated entry to set the slave SPDIF outs, in which the slave outs have cloned settings of the master out (e.g. dig_out_nid). --- Signed-off-by: Matthew Ranostay embeddedalley.com> diff --git a/pci/hda/hda_codec.c b/pci/hda/hda_codec.c index 4f32911..696d77e 100644 --- a/pci/hda/hda_codec.c +++ b/pci/hda/hda_codec.c < at >< at > -1454,12 +1454,22 < at >< at > static int snd_hda_spdif_default_put(struct snd_kcontrol *kcontrol, codec->spdif_ctls = val; if (change) { +hda_nid_t *d; snd_hda_codec_write_cache(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff); snd_hda_codec_write_cache(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_2, val >> 8); + +for (d = codec->slave_dig_outs; *d; d++) { +snd_hda_codec_write_cache(codec, *d, 0, + AC_VERB_SET_DIGI_CONVERT_1, + val & 0xff); +snd_hda_codec_write_cache(codec, *d, 0, +

Re: [PATCH] hda: SPDIF mux controls

Matthew Ranostay — 2008-09-07T15:17:47

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Takashi Iwai wrote: Ah but it isn't a capture source mux it's actually for the output SPDIF's. - - Matt -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkjD8JsACgkQ7s2wy7nhBHXdBQCfUiU4xhBYTMONOMoOzYaQiu7E 84YAnR4W8wbOJKgcOSRWUqefri7buPN0 =Hnl6 -----END PGP SIGNATURE-----

[PATCH] fix section mismatch in the sound_core

Krzysztof Helt — 2008-09-07T15:24:33

From: Krzysztof Helt wp.pl> The __exit cleanup_oss_soundcore() is called from the __init init_soundcore(). This causes section mismatch and breaks kernel's linking on sparc64. Remove the __exit attribute from the cleanup_oss_soundcore(). Signed-off-by: Krzysztof Helt wp.pl> --- Patch against 2.6.27-rc5-mm1. diff -urp linux-ref/sound/sound_core.c linux-2.6.26/sound/sound_core.c --- linux-ref/sound/sound_core.c2008-09-07 18:54:22.800008536 -0400 +++ linux-2.6.26/sound/sound_core.c2008-09-07 18:55:56.805521447 -0400 < at >< at > -13,7 +13,7 < at >< at > #ifdef CONFIG_SOUND_OSS_CORE static int __init init_oss_soundcore(void); -static void __exit cleanup_oss_soundcore(void); +static void cleanup_oss_soundcore(void); #else static inline int init_oss_soundcore(void){ return 0; } static inline void cleanup_oss_soundcore(void){ } < at >< at > -573,7 +573,7 < at >< at > int soundcore_open(struct inode *inode, MODULE_ALIAS_CHARDEV_MAJOR(SOUND_MAJOR); -static void __exit cleanup_oss_soundcore(void) +static voi

[PATCH] ice1712 drivers coding style fixes (part 2)

Vedran Miletić — 2008-09-07T15:07:39

I started with Takashi's sound-unstable tree as a base: Fixed: * ice1724 compilation error (one { too much) * checkpatch errors along the files sound/pci/ice1712/ak4xxx.c total: 1 errors, 3 warnings, 0 checks, 196 lines checked sound/pci/ice1712/amp.h total: 0 errors, 0 warnings, 1 checks, 51 lines checked sound/pci/ice1712/aureon.c total: 0 errors, 121 warnings, 3 checks, 2284 lines checked sound/pci/ice1712/aureon.h total: 0 errors, 1 warnings, 0 checks, 65 lines checked sound/pci/ice1712/delta.c total: 17 errors, 44 warnings, 1 checks, 817 lines checked sound/pci/ice1712/delta.h total: 0 errors, 8 warnings, 0 checks, 153 lines checked sound/pci/ice1712/envy24ht.h total: 0 errors, 21 warnings, 0 checks, 221 lines checked sound/pci/ice1712/ews.c total: 27 errors, 64 warnings, 2 checks, 1087 lines checked sound/pci/ice1712/ews.h total: 0 errors, 7 warnings, 0 checks, 86 lines checked sound/pci/ice1712/hoontech.c total: 13 errors, 10 warnings, 1 checks, 360 lines checked sound/pci/ice1712/hoontech.h total: 2

Re: [PATCH] ice1712.c: fix coding style

Takashi Iwai — 2008-09-07T10:48:44

At Sun, 7 Sep 2008 14:35:46 +0400, Alexander Beregalov wrote: If you send multiple patches at once, then it'd be helpful. Then I would notice more easily if any patch is missing. Of course, this isn't a strict rule. That is, it'd be nice if you can give some information that any patches are pending. thanks, Takashi

Re: [PATCH] phase and juli coding style fixes (morecoming up)

Takashi Iwai — 2008-09-07T10:45:23

At Sun, 7 Sep 2008 12:29:08 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote: Don't use alsa-kmirror then. The submitted patch should have been tested properly. If untested, please describe it clearly. A missing semicolon in a line. The standard procedure is to pull the upstream tree onto yours. That is, run % git pull git://git.kernel.org/pub/.../tiwai/sound-2.6.git master then the changes in sound-2.6.git tree will be merged into yours. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel< at >alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ice1712.c: fix coding style

Alexander Beregalov — 2008-09-07T10:35:46

2008/9/7 Takashi Iwai suse.de>: Ok, thanks. Is that also needed for patches which are not depended from each other?

Re: [PATCH] phase and juli coding style fixes (morecoming up)

Vedran Miletić — 2008-09-07T10:29:08

Sorry for missing that one, I'm not able to compile alsa for some reason. Some change in alsa-kmirror don't work with current alsa-driver on my 2.6.26 kernel. I will be more careful next time. Just wondering, what did I miss? BTW, I was wondering: do you sync your tree (sound-2.6 or sound-unstable-2.6) with 2.6.27 Linus's tree? Because, if that's the case, then I might be tempted to switch to using that tree as my "everyday kernel". 2008/9/7 Takashi Iwai suse.de>:

Re: [PATCH] ice1712.c: fix coding style

Takashi Iwai — 2008-09-07T10:28:05

At Sun, 7 Sep 2008 14:17:02 +0400, Alexander Beregalov wrote: Applied, too. But, before submitting the next: if you are sending a series of patches, please add [PATCH xx/yy] in the subject, so that I can wait for all patches. Thanks, Takashi

Re: [PATCH] hda: removed unneeded hp_nid references.

Takashi Iwai — 2008-09-07T10:23:58

At Fri, 05 Sep 2008 17:06:19 -0400, Matthew Ranostay wrote: Applied. Thanks. Takashi

Re: [PATCH] hda: SPDIF mux controls

Takashi Iwai — 2008-09-07T10:23:47

At Fri, 05 Sep 2008 14:55:02 -0400, Matthew Ranostay wrote: Thanks, applied. One concern is whether "IEC958 Mux" is the right name for this. Maybe something like "IEC958 Capture Source" would be more intuitive. However, note that "Capture Source" name is often problematic for multiple instances due to a bug (or a feature) of alsa-lib mixer abstraction. (That's why "Input Source" is used in many HD-audio codes.) Takashi

Re: [PATCH] phase and juli coding style fixes (morecoming up)

Takashi Iwai — 2008-09-07T10:21:45

At Sun, 7 Sep 2008 11:39:10 +0200, =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote: Thanks. Applied now. BTW, there was a typo in your patch that broke the compile. Please check the build properly before submitting the patch. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel< at >alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ice1724.c: fix coding style

Takashi Iwai — 2008-09-07T10:20:32

At Sun, 7 Sep 2008 14:11:04 +0400, Alexander Beregalov wrote: Applied this, too. Takashi

Re: [PATCH] ice1712/wtm: fix coding style

Takashi Iwai — 2008-09-07T10:20:17

At Sun, 7 Sep 2008 01:54:27 +0400, Alexander Beregalov wrote: Applied this one, too. Takashi

Re: [PATCH] ice1712/aureon.c: fix coding style

Takashi Iwai — 2008-09-07T10:20:03

At Sun, 7 Sep 2008 01:19:00 +0400, Alexander Beregalov wrote: Applied. Thanks. Takashi

[PATCH] ice1712.c: fix coding style

Alexander Beregalov — 2008-09-07T10:17:02

before: total: 113 errors, 169 warnings, 2786 lines checked total: 26 errors, 24 warnings, 504 lines checked after: total: 14 errors, 163 warnings, 2799 lines checked total: 0 errors, 24 warnings, 504 lines checked Compile tested only. Signed-off-by: Alexander Beregalov gmail.com> --- sound/pci/ice1712/ice1712.c | 237 +++++++++++++++++++++++-------------------- sound/pci/ice1712/ice1712.h | 52 +++++----- 2 files changed, 151 insertions(+), 138 deletions(-) diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c index 05ffab6..5b44238 100644 --- a/sound/pci/ice1712/ice1712.c +++ b/sound/pci/ice1712/ice1712.c < at >< at > -17,7 +17,7 < at >< at > * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * - */ + */ /* NOTES: < at >< at > -35,7 +35,7 < at >< at > * * 2002.11.26James Stafford ampltd.com> *Added support for VT1724 (Envy24HT) - *I have left out support for 176.4 and 192 KHz for

[PATCH] ice1724.c: fix coding style

Alexander Beregalov — 2008-09-07T10:11:04

before: total: 96 errors, 66 warnings, 2612 lines checked after: total: 11 errors, 64 warnings, 2624 lines checked Compile tested only. Signed-off-by: Alexander Beregalov gmail.com> --- sound/pci/ice1712/ice1724.c | 180 +++++++++++++++++++++++-------------------- 1 files changed, 96 insertions(+), 84 deletions(-) diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c index 7bb99df..1b3f117 100644 --- a/sound/pci/ice1712/ice1724.c +++ b/sound/pci/ice1712/ice1724.c < at >< at > -20,9 +20,9 < at >< at > * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * - */ + */ -#include +#include #include #include #include < at >< at > -105,7 +105,7 < at >< at > static unsigned int PRO_RATE_DEFAULT = 44100; /* * Basic I/O */ - + /* * default rates, default clock routines */ < at >< at > -198,7 +198,7 < at >< at > static void snd_vt1724_set_gpio_dir(struc

Re: [PATCH] hda: multiple SPDIF outputs support

Takashi Iwai — 2008-09-07T10:06:40

At Fri, 05 Sep 2008 17:45:54 -0400, Matthew Ranostay wrote: Could you split this patch to two parts? - Addition of slave SPDIF outputs in the common code - Addition of slave SPDIF outputs for Sigmatel/IDT codecs For the former patch, please add a bit more description (e.g. how the slave SPDIF devices behave). thanks, Takashi

[PATCH] phase and juli coding style fixes (more comingup)

Vedran Miletić — 2008-09-07T09:39:10

From my signoff: From b4a282ae0d54087bc152571c250afcd57fa9fa38 Mon Sep 17 00:00:00 2001 From: Vedran Miletic gmail.com> Date: Sun, 7 Sep 2008 11:22:35 +0200 Subject: [PATCH] ALSA: ice1712/ice1724: Coding style fixes part 1 (more coming up) Inspired by Alexander Beregalov's patches for wtm and aureon.c, I decided to run checkpatch on some more files. After some work checkpatch.pl-0.23 --no-tree --file --strict reports 0 errors, 0 warnings, 0 checks, n lines checked for: phase.c phase.h juli.c (1 check about unused code, maybe we should comment it) juli.h (no changes necessary) In other files I have just fixed // comments and long lines along the way (but not all of them), more coming up. Signed-off-by: Vedran Miletic gmail.com> Patch is attached.

Re: [PATCH] ice1712/aureon.c: fix coding style

Vedran Miletić — 2008-09-07T08:34:01

It is awesome that someone remembered to do this; you have motivated me to fix stuff related to my card. I have phase.c and phase.h patch coming up soon. 2008/9/6 Alexander Beregalov gmail.com>: