gmane.linux.alsa.devel

[PATCH: TinyCompress] fix error reporting intinycompress

Vinod Koul — 2013-05-23T07:45:19

From: Lakshmi N Vinnakota <lakshmi.n.vinnakota< at >intel.com>

The compress API are expected to return a negative value on an error
with errno indicating the type of error. But in some cases, this is
not happening.

The fix is the oops function always returns -1 and the actual
error number is determined by the global variable errno.

Signed-off-by: Lakshmi N Vinnakota <lakshmi.n.vinnakota< at >intel.com>
Signed-off-by: Vinod Koul <vinod.koul< at >intel.com>
---
 compress.c |   61 ++++++++++++++++++++++++++++++-----------------------------
 1 files changed, 31 insertions(+), 30 deletions(-)

diff --git a/compress.c b/compress.c
index 8753758..7f56c78 100644
--- a/compress.c
+++ b/compress.c
< at >< at > -102,10 +102,11 < at >< at > static int oops(struct compress *compress, int e, const char *fmt, ...)
 va_end(ap);
 sz = strlen(compress->error);
 
-if (errno)
-snprintf(compress->error + sz, COMPR_ERR_MAX - sz,
-": %s", strerror(e));
-return e;
+snprintf(compress->error + sz, COMPR_ERR_MAX - sz,
+": %s", strerror(e));
+errno = e;

Re: [TINYCOMPRESS][PATCH 1/1] crec: Initial versionofa compressed capture utility

Charles Keepax — 2013-05-23T08:00:10

All good points, apologies for those. This tool wasn't really
quite ready for upstreaming just yet, I have been diverted some
what the last week or so but hopefully should get round to a more
suitable upstream version shortly.

Thanks,
Charles

Re: [TINYCOMPRESS][PATCH 1/1] compress: fix hpointer error when nosample rate

Vinod Koul — 2013-05-23T02:28:37

Applied thanks

--
~Vinod

Re: [TINYCOMPRESS][PATCH 1/1] crec: Initial version of a compressedcapture utility

Vinod Koul — 2013-05-23T02:24:18

This and above seems to be copy-paste error, can you fix that
raw? What is the format supported here. I would expect it do store the file in mp3
format at least

okay, so you are supporting only PCM here. Well we can use for PCM, lets also
write toa proper .wav file?

This should poll till one fragment is availble...
argument should support duration, thats very helpful while testing :)

One thing missing would be exception handling. For recording its important as
you would like the user to terminate the program but still get all the samples
recorded. So then we drain and read the buffers and store in file.

--
~Vinod

Re: [PATCH] ALSA: hda - Enable runtime pm for Haswell

Wang, Xingchao — 2013-05-23T02:59:06

Hi Rafael,



It's interesting something maybe wrong in my test:
1. withtout calling pm_runtime_allow(), azx_runteim_idle/suspend() will not be called.

2. another trick is on my Haswell ULT C stepping board, the runtime PM only work
after exit from resume:

echo mem > /sys/power/state

if you donot let system enter suspend manually, the runtime pm will not be triggered.

Is there any dependency between runtime pm suspend and normal suspend?

Thanks
--xingchao

[PATCH 4/4 V2] ALSA: hda - Continue probe in workcontext to avoid request_module deadlock

Wang Xingchao — 2013-05-23T01:51:07

There's deadlock when request_module(i915) in azx_probe.
It looks like:
device_lock(audio pci device) -> azx_probe -> module_request
(or symbol_request) -> modprobe (userspace) -> i915 init ->
drm_pci_init -> pci_register_driver -> bus_add_driver -> driver_attach ->
which in turn tries all locks on pci bus, and when it tries the one on the
audio device, it will deadlock.

This patch introduce a work to store remaining probe stuff, and let
request_module run in safe work context.

Signed-off-by: Wang Xingchao <xingchao.wang< at >linux.intel.com>
---
 sound/pci/hda/hda_i915.c  |  13 ++++--
 sound/pci/hda/hda_intel.c | 105 +++++++++++++++++++++++++++-------------------
 2 files changed, 71 insertions(+), 47 deletions(-)

diff --git a/sound/pci/hda/hda_i915.c b/sound/pci/hda/hda_i915.c
index 76c13d5..7547b20 100644
--- a/sound/pci/hda/hda_i915.c
+++ b/sound/pci/hda/hda_i915.c
< at >< at > -42,13 +42,18 < at >< at > int hda_i915_init(void)
 {
 int err = 0;
 
-get_power = symbol_request(i915_request_power_well);
+get_power = symbol_get

Re: [PATCH] ASoC: Fix early event callback listiteration

Mark Brown — 2013-05-22T22:34:25

Gah, I had noticed occasional errors but hadn't seen them often enough
to reproduce reliably in my testing.  Thanks!

Re: [PATCH] ASoC: Add ssm2518 support

Mark Brown — 2013-05-22T22:07:56




That's not the kernel coding style and I have to say these examples were
all jumping out at me as weird, I was looking for an else clause or
something.

[PATCH] ASoC: Fix early event callback list iteration

Lars-Peter Clausen — 2013-05-22T22:12:53

The power_list field is used when adding a widget to a power sequence list. Use
the same field when iterating the list using list_for_each_entry, otherwise
we'll see undefined behavior.

Signed-off-by: Lars-Peter Clausen <lars< at >metafoo.de>
---
 sound/soc/soc-dapm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 071579b..3507346 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
< at >< at > -1738,11 +1738,11 < at >< at > static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event)
 &async_domain);
 async_synchronize_full_domain(&async_domain);
 
-list_for_each_entry(w, &down_list, list) {
+list_for_each_entry(w, &down_list, power_list) {
 dapm_seq_check_event(dapm, w, SND_SOC_DAPM_WILL_PMD);
 }
 
-list_for_each_entry(w, &up_list, list) {
+list_for_each_entry(w, &up_list, power_list) {
 dapm_seq_check_event(dapm, w, SND_SOC_DAPM_WILL_PMU);
 }

Re: regression: from 3.8 to 3.9: headphones output no sound on Intel HDA, codec VIA VT1802

Alex Riesen — 2013-05-22T21:06:53

Ping? Can I do something for you?

Regards,
Alex

On Sat, May 18, 2013 at 10:29 PM, Alex Riesen <raa.lkml< at >gmail.com> wrote:

Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086

Mark Brown — 2013-05-22T19:31:17


I'll apply any sensible driver that gets submitted.

Re: [PATCH 1/4] cs42l52: use same init values for MASTERA_VOL/MASTERB_VOL.

Austin, Brian — 2013-05-22T18:42:51


On May 22, 2013, at 8:34, "Mark Brown" <broonie< at >kernel.org> wrote:


Your right Mark. I missed that. These registers should be default of 0x00.

Thanks

Re: [PATCH 4/4] cs42l52: fix master playback mute mask.

Mark Brown — 2013-05-22T18:39:32

Applied, thanks.

Re: [PATCH 3/4] cs42l52: fix bogus shifts in "Speaker Volume" and "PCM Mixer Volume" controls.

Mark Brown — 2013-05-22T18:39:06

Applied, thanks.

Re: [PATCH 2/4] cs42l52: microphone bias is controlled by IFACE_CTL2 register.

Mark Brown — 2013-05-22T18:38:50

Applied, but please always CC maintainers on patches and use changelogs
appropriate for the subsystem.

Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086

Daniel Mack — 2013-05-22T18:36:58

Ok, I guess that's enough justification to not add it now, at least for
the fact that nobody is able to test this driver now ...


Thanks,
Daniel

Re: [PATCH 1/4] cs42l52: use same init values for MASTERA_VOL/MASTERB_VOL.

Mark Brown — 2013-05-22T18:34:25

Why?


Note that the register defaults need to reflect the default value
for the registers.

Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086

2013-05-22T18:33:45

Yes, but they were added before the chips went out of production.

Mark/Liam - you can add my TAS5504 driver if you want it. As far as I
know there is no Linux based hardware using the chip except for a few
prototypes we built about five years ago.

Of course it is easier to find CPU boards with exposed I2S (we had to
build a CPU board too) now than it was five years ago so these chips
may see more activity. Those TI evals board should easily attach to a
Beaglebone.




--
Jon Smirl
jonsmirl< at >gmail.com

Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086

Daniel Mack — 2013-05-22T18:25:38

That might be, but we have tons of drivers for devices in the mainline
kernel which aren't in production anymore.


Daniel

Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086

2013-05-22T18:24:06

TI has stopped making the TAS5504 but they still make the TAS5508
which is very similar.

TAS5508 eval board is $399.
http://www.ti.com/tool/tas5508-5142k7evm

TAS5086 eval for $299
http://www.ti.com/tool/tas5086-5186v6evm





--
Jon Smirl
jonsmirl< at >gmail.com

Re: [PATCH] ALSA: ASoC: add codec driver for TI TAS5086

2013-05-22T18:20:03

These ST amps are more recent that the TI parts.

http://www.st.com/web/catalog/sense_power/FM125/SC1756





--
Jon Smirl
jonsmirl< at >gmail.com